5 years ago0027286: Visualization, TKOpenGl - avoid using light index within built-in GLSL progr...
kgv [Wed, 23 Mar 2016 09:42:17 +0000 (12:42 +0300)]
0027286: Visualization, TKOpenGl - avoid using light index within built-in GLSL programs for simplest configuration

OpenGl_ShaderManager::stdComputeLighting() - handle single directional light specifically
for compatibility with broken OpenGL ES drivers.

Added test cases using built-in GLSL shading programs.

5 years ago0026293: Error opening the document
apn [Tue, 22 Mar 2016 12:43:35 +0000 (15:43 +0300)]
0026293: Error opening the document

Added test cases bugs/caf/bug26293_1 bug26293_2

Unnecessary catch were deleted.

5 years ago0027274: Regression vs 6.9.1: Wrong result of General Fuse operation on two cylinders
emv [Thu, 17 Mar 2016 14:10:11 +0000 (17:10 +0300)]
0027274: Regression vs 6.9.1: Wrong result of General Fuse operation on two cylinders

When reducing the tolerance values of the vertices put on section curves take into
account all section curves, not only those for which the tolerance have been reduced
(method void BOPAlgo_PaveFiller::CorrectToleranceOfSE()).
The new protection has been added to avoid reducing of tolerance values of vertices
to the values less than the tolerance values of edges containing these vertices.

Adjusting of test case bugs/modalg_5/bug25232_9

5 years ago0027293: Add debug function to save a list of shapes into a compound
msv [Mon, 21 Mar 2016 15:45:29 +0000 (18:45 +0300)]
0027293: Add debug function to save a list of shapes into a compound

5 years agoAdjusting test case after changes of issue 27270
apv [Mon, 21 Mar 2016 11:56:33 +0000 (14:56 +0300)]
Adjusting test case after changes of issue 27270

5 years ago0027281: Some classes in GCPnts are not const-correct
Benjamin Bihler [Thu, 17 Mar 2016 13:19:37 +0000 (14:19 +0100)]
0027281: Some classes in GCPnts are not const-correct

const keyword has been added to the method parameters

5 years ago0027285: Visualization - selection of AIS_MultipleConnectedInteractive is broken
vpa [Fri, 18 Mar 2016 11:26:07 +0000 (14:26 +0300)]
0027285: Visualization - selection of AIS_MultipleConnectedInteractive is broken

- method SelectMgr_SelectableObject::HasSelection became virtual, unnecessary variable was removed;
- redefined HasSelection method for multiple connected interactives;
- AIS_InteractiveContext::AddOrRemoveSelected was corrected to use global selection owner;
- test case for issue #27285

5 years ago0027270: Boolean operations: incorrect assembling of sub-shapes in container shapes...
emv [Thu, 17 Mar 2016 09:04:59 +0000 (12:04 +0300)]
0027270: Boolean operations: incorrect assembling of sub-shapes in container shapes (wires, shells, compsolids)

The map to protect the result of Boolean operation from duplicating parts in containers has been removed (method void BOPAlgo_BOP::BuildShape()).
The results of Boolean operations on containers will be the following:
1. For the arguments of collection type (WIRE, SHELL, COMPSOLID) containing overlapping parts the overlapping parts
passed into result will be repeated for each container from the input shapes containing such parts.
2. The result of the operation Fuse for the arguments of collection type (WIRE, SHELL, COMPSOLID) will contain
the same number of containers as the arguments. The overlapping parts (EDGES/FACES/SOLIDS) will be shared among them.
For example, the result of Fuse operation between two wires will be two wires sharing coinciding edges if any.
3. The result of the operation Common for the arguments of collection type (WIRE, SHELL, COMPSOLID) will consist
of the containers containing the same overlapping parts. For example, the result of Common operation between two
fully/partially overlapping wires will be two wires containing the same edges.

Style correction.

Added test case bugs/modalg_1/bug13538
Modified boolean test cases according to new begavior

5 years ago0027261: Incorrect bounding boxes computed for the b-spline faces
aml [Tue, 15 Mar 2016 11:57:15 +0000 (14:57 +0300)]
0027261: Incorrect bounding boxes computed for the b-spline faces

Protection from the out of bounds parameters is added.
Test cases are added.

5 years ago0027176: Configuration, CMake - INSTALL_DIR is a common prefix for all other install...
ski [Fri, 18 Mar 2016 05:25:53 +0000 (08:25 +0300)]
0027176: Configuration, CMake - INSTALL_DIR is a common prefix for all other install variables

Possibility to customize layout of installation of OCCT is introduced by:
- variable INSTALL_DIR_LAYOUT - select one of the two predefined layouts: either Windows (classic OCCT layout) or Unix (Linux standard)
- variables INSTALL_DIR_* (BIN, LIB, INCLUDE, RESOURCE, DOC, TESTS, SCRIPT, SAMPLES, DATA) - specify locations of relevant components
- variable INSTALL_DIR_WITH_VERSION (bool) - specifies whether full version of OCCT should be used in paths in Unix layout

Files LICENSE_LGPL_21.txt and OCCT_LGPL_EXCEPTION.txt are always installed.

Environment is extended to support non-default layouts.
For that, environment variables "CSF_OCCT*Path" are defined, corresponding to CMake variables INSTALL_DIR_* described above.
Visual Studio environment, DRAW, tests, samples are amended to use these variables instead of (or as alternative to) CASROOT.

Settings of Products-specific vars are removed from environment scripts.

File genconf.bat was corrected to avoid error message for the case when path to TCL contains spaces.

Product name in rc files changed to "Open CASCADE Technology".

5 years ago0027253: Boolean cut produces invalid result shape
msv [Fri, 11 Mar 2016 13:28:31 +0000 (16:28 +0300)]
0027253: Boolean cut produces invalid result shape

Add test case for this bug.

5 years ago0027263: Regression vs 6.9.1: Exception is raised during intersection of two faces
nbv [Tue, 15 Mar 2016 12:26:11 +0000 (15:26 +0300)]
0027263: Regression vs 6.9.1: Exception is raised during intersection of two faces

1. Protection against getting access to null-handle has been entered.

2. Function AreSamePoints() has been substituted by appropriate method IntSurf_PntOn2S::IsSame(...)

Test cases for issues #27262 and #27263 have been created.

5 years ago0027190: IntPatch_ImpPrmIntersection algorithm does not split intersection curve...
nbv [Wed, 24 Feb 2016 09:59:36 +0000 (12:59 +0300)]
0027190: IntPatch_ImpPrmIntersection algorithm does not split intersection curve by the seam-edge of the quadric

1. Processing when IntPatch_WLine/IntPatch_RLine goes through the seam edge has been improved in DecomposeResult(...) function (see IntPatch_ImpPrmIntersection.cxx).
2. Incorrect initialization of last point of IntPatch_WLine/IntPatch_RLine has been eliminated. Earlier it was the reason of exception.

Creation of test case for this issue.

Adjusting some test cases according to their new behavior. Namely:

1) tests\bugs\modalg_4\bug825 (bug825_2)
Details are described in issue #25915. In short, new intersection algorithm works better than old (WLine without "jumping"). However, Boolean operation loses degenerated edges of the sphere. Consequently, we get the result with Not-closed face.

2) tests\bugs\modalg_6\bug26684_2
TolReached of intersection curve has become smaller. Consequently, intersection algorithm works better than earlier.

5 years ago0027267: [Regression to 6.9.1] geom/boolean_operations_06/G3: Cut produces invalid...
nbv [Wed, 16 Mar 2016 14:49:16 +0000 (17:49 +0300)]
0027267: [Regression to 6.9.1] geom/boolean_operations_06/G3: Cut produces invalid shape

Calling IntPatch_WLineTool::ComputePurgedWLine() algorithm is forbidden if Walking-line is obtained from analytic line.

Creation of test case for this issue.

5 years ago0027277: geom/extruded_00/A0: OCAF document is not opened correctly
abv [Thu, 17 Mar 2016 12:04:19 +0000 (15:04 +0300)]
0027277: geom/extruded_00/A0: OCAF document is not opened correctly

Reading of attribute TDataStd_ExtStringList from CSFDB format is corrected for null strings: empty value is used.

Test bugs caf bug27277 added.

5 years ago0027266: Coding, TKOpenGl - drop unused files OpenGl_telem_util.hxx and OpenGl_tgl_fu...
kgv [Tue, 15 Mar 2016 18:02:32 +0000 (21:02 +0300)]
0027266: Coding, TKOpenGl - drop unused files OpenGl_telem_util.hxx and OpenGl_tgl_funcs.hxx

5 years ago0027241: Create a complete test case to verify reading of all attribute types from...
myn [Fri, 11 Mar 2016 19:08:01 +0000 (22:08 +0300)]
0027241: Create a complete test case to verify reading of all attribute types from MDTV-Standard document

Added test case that works in one of two modes:
1) create synthetic document (in old version of OCCT) containing all possible attributes.
2) open the document and compare all attributes with expected values.

Fixed reading of TDataStd_NamedData, TDataXtd_PatternStd, and PColStd_HArray2OfReal.
Point and curve representations are created even from NULL geometry handles.
The code is simplified by abandoning usage of templates from StdObjMgt_ContentTypes class for persistent data elements.

Fixed SetAsciiString Draw command failed when the target label contained NamedData attribute.

5 years ago0027237: genproj file does not take into account any arguments
abv [Mon, 14 Mar 2016 14:45:32 +0000 (17:45 +0300)]
0027237: genproj file does not take into account any arguments

Arguments of genproj tool are revised:
* -path option eliminated (current directory is always used);
* IDE should be always indicated by first argument (instead of -target=<ide> option);
* second argument can be used to specify non-default platform (wnt, mac, lin, ios, qnx);
* option -h, -help, --help can be used to get help
* option -static can be used to build static libs with XCode

README.txt and docs on building are updated.
codeblocks.bat is corrected to be able to detect 32-bit installation of Code::Blocks on 64-bit Windows.
Remains of support of OpenCL (obsolete) are commented out in genconf.tcl
genproj.tcl will not copy env.bat if it already exists.

5 years ago0027242: Configuration - add missing Standard_EXPORT to OpenGl_TextBuilder class...
kgv [Thu, 10 Mar 2016 06:53:35 +0000 (09:53 +0300)]
0027242: Configuration - add missing Standard_EXPORT to OpenGl_TextBuilder class constructor

5 years ago0027231: Obsolete OCCT features still mentioned in the documentation
abv [Tue, 8 Mar 2016 11:12:45 +0000 (14:12 +0300)]
0027231: Obsolete OCCT features still mentioned in the documentation

A few remaining places mentioning .cdl files are corrected to mention only .hxx
Obsolete description of storage in old format is revised in OCAF User's Guide.

5 years ago0027247: Eliminate remaining compiler warnings in MFC samples and with OCCT_DEBUG
abv [Fri, 11 Mar 2016 04:23:55 +0000 (07:23 +0300)]
0027247: Eliminate remaining compiler warnings in MFC samples and with OCCT_DEBUG

Unsafe and useless casts of handles are eliminated

5 years ago0027250: Samples - define proper file header for pathtrace.tcl
kgv [Fri, 11 Mar 2016 08:33:08 +0000 (11:33 +0300)]
0027250: Samples - define proper file header for pathtrace.tcl

Sample "Path tracing" is corrected to be shown in Visualization section, and to explain what it does during execution

5 years ago0027254: [Regression] 7.0 types initialization mechanism is not thread-safe on VS2013
Roman Lygin [Fri, 11 Mar 2016 13:44:55 +0000 (17:44 +0400)]
0027254: [Regression] 7.0 types initialization mechanism is not thread-safe on VS2013

The code in Standard_Type::type_instance<T>::get() distinguishes between compilers supporting and not supporting N2660. VS2013 was incorrectly considered as supporting, although the comment stated the opposite.

The fix makes VS2013 treated as not supporting N2660.

5 years ago0027233: Configuration - do not include version in SONAME for Android target
kgv [Sat, 5 Mar 2016 13:51:26 +0000 (16:51 +0300)]
0027233: Configuration - do not include version in SONAME for Android target

5 years ago0027232: Configuration - fix mblen missing building issue on Android
kgv [Sat, 5 Mar 2016 12:46:42 +0000 (15:46 +0300)]
0027232: Configuration - fix mblen missing building issue on Android

Assume UTF-8 as the only locale supported on Android.

5 years ago0027206: Inconsistent and obsolete information in persistence documentation and Relea... V7_0_0rc
abv [Fri, 4 Mar 2016 11:42:53 +0000 (14:42 +0300)]
0027206: Inconsistent and obsolete information in persistence documentation and Release Notes

Technical docs are reviewed to:
* update references to page with third-party products
* update description of persistence, handles, and RTTI according to changes in OCCT 7.0
* remove references to CDL, WOK, and WOK-generated stuff
* update the list of environment variables

5 years agoIncrementation OCCT version up to 7.0.0 rc
bugmaster [Fri, 4 Mar 2016 06:56:28 +0000 (09:56 +0300)]
Incrementation OCCT version up to 7.0.0 rc

5 years ago0027218: Add information about porting from earlier versions in update guide
ysn [Thu, 3 Mar 2016 15:37:41 +0000 (18:37 +0300)]
0027218: Add information about porting from earlier versions in update guide

- porting notes for earlier versions starting with 6.5;
- section about zoom persistent selection

5 years ago0027193: Describe building OCCT with genproj tool
abv [Thu, 3 Mar 2016 17:25:01 +0000 (20:25 +0300)]
0027193: Describe building OCCT with genproj tool

Description of building OCCT with WOK and automake scripts is removed from documentation.
Use of genproj utility is described in pages on building with MSVC, Code::Blocks, and XCode projects.

New script genconf allows starting configuration GUI explicitly; dialog is slightly revised.
Script genproj.sh is renamed to genproj; permissions for scripts are corrected for Linux.

Script env.bat does not set anymore environment required for Products.

5 years ago0026961: Recover possibility to read files in old persistence format
myn [Wed, 2 Mar 2016 20:04:30 +0000 (23:04 +0300)]
0026961: Recover possibility to read files in old persistence format

Possibility to read shapes and OCAF documents from old persistence format (Std and StdL schema) is restored.

Test cases used old persistent files on input are restored with suffix "_std"

Removing toolkit from OS package

5 years ago0026571: Visualization, TKOpenGl - write depth values within RayTracing program
duv [Mon, 29 Feb 2016 14:11:34 +0000 (17:11 +0300)]
0026571: Visualization, TKOpenGl - write depth values within RayTracing program

View-projection matrix was added to raytrace shaders (as uniform) in order to compute correct depth values for OpenGL.
For path tracing the additional depth buffer sampler was added to Display.fs program. It allows propagation of depth values from internal FBO to resulting FBO.
The old approach of mixing of OpenGL and ray-tracing graphics was kept in order to keep correct blending of transparent ray-traced objects with non-transparent OpenGL objects.

5 years ago0027216: Review the documentation before the final release.
ysn [Thu, 3 Mar 2016 10:33:48 +0000 (13:33 +0300)]
0027216: Review the documentation before the final release.

Some pre-release updates, reviewing and implementation of some adequate remarks from JMA:
- redundant chapters in IGES and STEP guides
- proofreading of recent insertions in Draw, and tests guides
- mathjax information
- data, version, addresses, system requirements in overview.md


5 years ago0027197: Configuration - fix compilation issues when using mingw
kgv [Sat, 27 Feb 2016 23:07:27 +0000 (02:07 +0300)]
0027197: Configuration - fix compilation issues when using mingw

AIS_ColorScale, AIS_Dimension - the protected method DrawText()
has been renamed to drawText() to avoid name collisions with macros.

_MSC_VER/_WIN32 misuse has been fixed in several places.
Header <malloc.h> is now included where alloca() is used.
Draw_Window - dllimport flag has been dropped from inline methods.

TKernel - mandatory dependencies Winspool.lib and Psapi.lib
are now linked explicitly (instead of msvc-specific pragma syntax).

CMake scripts - the option -std=c++0x has been replaced by -std=gnu++0x
for mingw to allow extensions (like _wfopen() and others).
The minimum Windows version has been set to _WIN32_WINNT=0x0501.
Invalid options "-z defs" and "-lm" have been dropped for mingw.
Flag --export-all-symbols has been added to CMAKE_SHARED_LINKER_FLAGS
to workaround missing vtable symbols when using mingw.
FreeType is now linked explicitly on Windows.

Draw::Load() - "lib" suffix is now prepended on mingw as well.

Drop redundant declaration of _TINT from OSD_WNT_1.hxx.
NCollection_UtfString::FromLocale() - platform-specific code has been moved to .cxx file.
Draw_BasicCommands - fixed incorrect mingw64 version macros.

genproj, cbp - added workaround for process argument list limits on Windows.
TKSTEP linkage is failing on this platform due to too long list of files.
The list of object files to link is now stored in dedicated file which is passed to gcc.

Option "-z defs" removed from CMake linker options to avoid problems when building with different configurations of VTK on Linux

Some MinGW-specific compiler warnings (potentially uninitialized vars, use of NULL, parentheses in conditional expressions) are fixed (speculatively)

5 years ago0027198: OSD_Environment - use wide characters API on Windows
kgv [Mon, 22 Feb 2016 19:07:45 +0000 (22:07 +0300)]
0027198: OSD_Environment - use wide characters API on Windows

5 years ago0026827: Position and orientation for GD&T frames
gka [Mon, 18 Jan 2016 16:32:22 +0000 (19:32 +0300)]
0026827: Position and orientation for GD&T frames

Implementation of graphical annotations of the PMI read from STEP

5 years ago0027196: CMake - avoid setting option -EHa for compilers other than MSVC
abv [Mon, 22 Feb 2016 08:03:27 +0000 (11:03 +0300)]
0027196: CMake - avoid setting option -EHa for compilers other than MSVC

Option -EHa is now added only if MSVC is defined.

Descriptions of option -fp:precise in CMake and method OSD::SetSignal() in header file are updated.

5 years ago0027180: Visualization - improve selection logic of MeshVS_Mesh
vpa [Wed, 2 Mar 2016 17:27:42 +0000 (20:27 +0300)]
0027180: Visualization - improve selection logic of MeshVS_Mesh

MeshVS_Mesh selection logic in MeshVS_SMF_Mesh mode (entire mesh) has been optimized.
MeshVS_Mesh::ComputeSelection() now creates single sensitive entity
MeshVS_CommonSensitiveEntity (new class) instead of small sensitive entity on each element.
MeshVS_SensitiveQuad (new class) and Select3D_SensitiveTriangle are used instead of Select3D_SensitiveFace for local selection to reduce memory consumption when possible.

5 years ago0027207: New universal method for extracting of results of work of HLRBRep_Algo algorithm
jgv [Fri, 26 Feb 2016 12:20:32 +0000 (15:20 +0300)]
0027207: New universal method for extracting of results of work of HLRBRep_Algo algorithm

New method HLRBRep_HLRToShape::CompoundOfEdges with options:
- type of resulting edge
- visibility
- 3d/2d
has been added.

Minor correction of comments

5 years ago0026969: Visualization - support custom vertex attributes in GLSL program
kgv [Sat, 20 Feb 2016 10:10:41 +0000 (13:10 +0300)]
0026969: Visualization - support custom vertex attributes in GLSL program

Graphic3d_TypeOfData - added Graphic3d_TOD_FLOAT for passing single-float vertex attributes.
Graphic3d_TOA_CUSTOM - changed value to increase the range for custom vertex attributes locations (to fit into hardware limits).
Graphic3d_ShaderProgram::SetVertexAttributes() - introduced API for defining custom vertex attributes.

For compatibility with automated wrappers:
- Graphic3d_Buffer::Init() - added prototype taking NCollection_Array1<Graphic3d_Attribute> instead of C array
- Graphic3d_IndexBuffer::InitInt32() - added typed initialization method.
- Graphic3d_ShaderProgram::PushVariableVec3() and others - added typed methods to push uniform varibales.

5 years ago0027208: Show method in Message_ProgressIndicator::NewScope should not be commented out
Benjamin Bihler [Fri, 26 Feb 2016 13:07:28 +0000 (14:07 +0100)]
0027208: Show method in Message_ProgressIndicator::NewScope should not be commented out

Undone commenting out of Show method

5 years ago0026338: STL export (especially binary) needs a lot of time if selected export path...
abv [Thu, 25 Feb 2016 04:30:18 +0000 (07:30 +0300)]
0026338: STL export (especially binary) needs a lot of time if selected export path is not local

Method StlAPI_Writer::Write() is reimplemented to write triangulation directly, without conversion to StlMesh_Mesh.

New DRAW command "tessellate" is added to generate rapidly triangulation of prescribed size (on surface).

Command "tricheck" is protected to deal correctly with triangulation without UV data.

New tests added: perf de bug26338_1 and _2; bugs stlvrml bug26338

Correction of testing environment

5 years ago0024665: A sample for advanced function mechanism
bugmaster [Thu, 25 Feb 2016 14:08:20 +0000 (17:08 +0300)]
0024665: A sample for advanced function mechanism
Update for Linux platform

5 years agoCorrection misprinting
bugmaster [Sun, 21 Feb 2016 05:39:14 +0000 (08:39 +0300)]
Correction misprinting

5 years ago0027135: Incorrect result of the normal projection algorithm
aml [Thu, 11 Feb 2016 10:38:55 +0000 (13:38 +0300)]
0027135: Incorrect result of the normal projection algorithm

New check for possible local traps was added to build correct projection cache.

5 years ago0027152: Undefined symbols in library TKernel.so using clang compiler
apn [Wed, 17 Feb 2016 12:59:12 +0000 (15:59 +0300)]
0027152: Undefined symbols in library TKernel.so using clang compiler

Added ldl dependency for TKernel only (other toolkits were checked, no undefined symbols)
Added  option "-z defs" for linking on Linux
Added lm dependency for all toolkits

5 years ago0024594: Missing surfaces from STL output (second example)
oan [Fri, 19 Feb 2016 12:10:18 +0000 (15:10 +0300)]
0024594: Missing surfaces from STL output (second example)

Added test case
Small corrections of test case

5 years ago0027159: Section between two faces is lost
jgv [Mon, 15 Feb 2016 11:20:40 +0000 (14:20 +0300)]
0027159: Section between two faces is lost

Minor correction of test case

Another small correction of test case

One more correction of test case

5 years ago0027177: Review of recent additions in tests.md
ysn [Thu, 18 Feb 2016 08:56:58 +0000 (11:56 +0300)]
0027177: Review of recent additions in tests.md

Document corrected, warnings fixed.

5 years ago0025045: STEP Import fails to find all surfaces
oan [Fri, 19 Feb 2016 11:58:49 +0000 (14:58 +0300)]
0025045: STEP Import fails to find all surfaces

Added test case
Small corrections in test case

5 years ago0024593: Missing surfaces from STL output
oan [Fri, 19 Feb 2016 11:56:06 +0000 (14:56 +0300)]
0024593: Missing surfaces from STL output

Added test cases
Small corrections of test cases

5 years ago0026985: Wrong section between two faces: it has a gap
jgv [Tue, 16 Feb 2016 12:43:13 +0000 (15:43 +0300)]
0026985: Wrong section between two faces: it has a gap

5 years ago0027138: Configuration, Cmake - incorrect binaries installation path for single gener...
ibs [Fri, 5 Feb 2016 16:14:56 +0000 (19:14 +0300)]
0027138: Configuration, Cmake - incorrect binaries installation path for single generators

specify a path for toolkit shared library

5 years ago0027035: General fuse algorithm loses face
nbv [Mon, 15 Feb 2016 10:51:12 +0000 (13:51 +0300)]
0027035: General fuse algorithm loses face

The main reason of the bug is incorrect check, if the edge is seam-edge or not.
In the fix it is determined with new methods in GeomLib class.

The bug is fixed.

Creation of test case for this fix

Small correction in the code

5 years ago0024665: A sample for advanced function mechanism
vro [Wed, 10 Feb 2016 05:04:45 +0000 (08:04 +0300)]
0024665: A sample for advanced function mechanism

PRO file is added + a description of how to generate the Visual Studio projects and compile.
In addition, the sample folder is renamed to FuncDemo.

Adding 64 bit configuration to VC projects

5 years ago0026231: Visualization - Update description of selection algorithm in the user's...
vpa [Wed, 17 Feb 2016 14:57:33 +0000 (17:57 +0300)]
0026231: Visualization - Update description of selection algorithm in the user's guide

- updated description of selection mechanism in sections occt_visu_2_2, occt_visu_3_2_4 and occt_visu_3_6;
- unnecessary images were removed.

New Selection section  reviewed.

Semantic corrections

5 years ago0027104: DownCast() cannot return null for mismatched handle
abv [Mon, 25 Jan 2016 07:14:20 +0000 (10:14 +0300)]
0027104: DownCast() cannot return null for mismatched handle

Method DownCast() is made template, to be available only when argument is actually a pointer or handle to a base class.

For compatibility with existing code, method DownCast() that can be used for the same type, derived, or unrelated class (i.e. where there is no actual down casting) is still available, its use shall cause "deprecated" compiler warning.

OCCT code is updated to remove meaningless DownCast()s; a few places where DownCast() was used with argument of unrelated type are corrected.

DRAW command QAHandleCast is removed (it was useful only during redesign of handles).

5 years ago0026549: Provide move constructors and operators for basic classes
abv [Tue, 11 Aug 2015 20:01:05 +0000 (23:01 +0300)]
0026549: Provide move constructors and operators for basic classes

Move constructor and operator added for opencascade::handle<>

5 years ago0027111: Add generalized copy constructor in handle class for old compilers
abv [Sat, 6 Feb 2016 12:26:26 +0000 (15:26 +0300)]
0027111: Add generalized copy constructor in handle class for old compilers

Copy constructor and assignment operator from handle of derived type is added in handle class.
They are enabled only if macro OCC_HANDLE_NOCASTS is defined, and operators of cast of handle to reference to handle to base type are disabled in that case.

Useless type casts to handle to base type are removed in GC and GCE2d classes.
Code returning reference to handle from function is corrected to return it either by value or as reference to handle of actual type.

5 years ago0026377: Passing Handle objects as arguments to functions as non-const reference...
abv [Wed, 17 Feb 2016 14:33:18 +0000 (17:33 +0300)]
0026377: Passing Handle objects as arguments to functions as non-const reference to base type is dangerous

Operator of cast to non-const reference is declared deprecated to produce compiler warning if used (usually implicitly).

OCCT code is updated to avoid that cast, occurring when function accepting non-const reference to handle is called with handle to derived type.
For that, local variable of argument type is passed instead, and down-cast is used to get it to desired type after the call.
A few occurrences of use of uninitialized variable are corrected.

5 years ago0027118: Configuration - do not suppress deprecation warnings when using msvc
kgv [Sat, 30 Jan 2016 12:51:35 +0000 (15:51 +0300)]
0027118: Configuration - do not suppress deprecation warnings when using msvc

Patch removes option -wd4996 from VS project settings (which suppresses old deprecation warnings).
Instead, macros _CRT_SECURE_NO_WARNINGS (suppresses 444 warnings) and _CRT_NONSTDC_NO_DEPRECATE (suppresses 17 warnings) have been added.

Deprecation warning on GetVersionEx() has been suppressed locally in OSD_Host.cxx.
In STEPConstruct_AP203Context.cxx, OSD_Host is used instead of low-level system functions.
This eliminates dependency of TKSTEP on winsock32.lib on Windows.

5 years ago0027113: Coding - add macros Standard_DEPRECATED for marking deprecated functionality
kgv [Sat, 30 Jan 2016 11:54:12 +0000 (14:54 +0300)]
0027113: Coding - add macros Standard_DEPRECATED for marking deprecated functionality

Macro Standard_DEPRECATED("message") can be used in declarations to mark a method deprecated and generate compiler warning when it is used.
If OCCT_NO_DEPRECATED is defined, Standard_DEPRECATED is disabled (defined empty).

5 years ago0027107: ShapeAnalysis_Surface should use GeomAdaptor_Surface for surface evaluation
abv [Sun, 14 Feb 2016 08:16:24 +0000 (11:16 +0300)]
0027107: ShapeAnalysis_Surface should use GeomAdaptor_Surface for surface evaluation

ShapeAnalysis_Surface is improved to use adaptor for evaluation of points on a surface.
Useless field myExtSur is removed.
DE tests are amended according to induced changes (number of edges varied).

5 years ago0026384: Add explicit check for null magnitude instead of catching of exception in...
oan [Wed, 17 Feb 2016 14:17:54 +0000 (17:17 +0300)]
0026384: Add explicit check for null magnitude instead of catching of exception in BRepMesh_FastDiscretFace::control()

Check normal for null magnitude using gp::Resolution ()

5 years ago0027131: [Regression to 6.7] DistShapeShape performance loss
aml [Tue, 9 Feb 2016 12:19:25 +0000 (15:19 +0300)]
0027131: [Regression to 6.7] DistShapeShape performance loss

Lipchitz constant approximation and fixes in global optimization algorithm added to improve performance.
Test case added.

Possibility to freeze Lipchitz constant is added to improve performance.

5 years ago0027156: Doxygen warnings on overview docs
abv [Fri, 12 Feb 2016 17:14:27 +0000 (20:14 +0300)]
0027156: Doxygen warnings on overview docs

Documentation corrected to avoid Doxygen warnings

5 years ago0027162: Draw command "(2d)extrema" incorrectly represent underlying algorithm results
aml [Tue, 16 Feb 2016 12:47:38 +0000 (15:47 +0300)]
0027162: Draw command "(2d)extrema" incorrectly represent underlying algorithm results

Correct handling of infinity solutions added for Curve / Curve case.
Unused code deleted.
Test cases updated to the new behavior.

5 years ago0027172: Visualization - avoid signed integer overflow within Graphic3d_ArrayOfPrimitives
kgv [Wed, 17 Feb 2016 14:37:43 +0000 (17:37 +0300)]
0027172: Visualization - avoid signed integer overflow within Graphic3d_ArrayOfPrimitives

5 years ago0023202: BRepMesh of face fails
apn [Wed, 17 Feb 2016 10:24:44 +0000 (13:24 +0300)]
0023202: BRepMesh of face fails

Added test case bugs/mesh/bug23202

5 years ago0026692: BRepMesh hangs on the attached shape due to tessellation points produced...
oan [Mon, 15 Feb 2016 16:33:29 +0000 (19:33 +0300)]
0026692: BRepMesh hangs on the attached shape due to tessellation points produced out of surface range

BRepMesh_EdgeTessellator: do not use points out of face range and edge tolerance.

Test cases for issue CR26692

5 years ago0026941: Building on Windows with VC14 - debug info is generated for Release build
abv [Sun, 14 Feb 2016 04:33:18 +0000 (07:33 +0300)]
0026941: Building on Windows with VC14 - debug info is generated for Release build

Generation of debug info is explicitly disabled on link step in templates of Visual Studio 10+ project files used by genproj, to avoid relying on default settings of Visual Studio.

5 years ago0027086: Samples, jniviewer - avoid duplicating viewer redraws
kgv [Mon, 18 Jan 2016 09:57:23 +0000 (12:57 +0300)]
0027086: Samples, jniviewer - avoid duplicating viewer redraws

5 years ago0026939: Configuration, NCollection_UBTreeFiller - do not use _REENTRANT in a header...
kgv [Fri, 22 Jan 2016 12:55:55 +0000 (15:55 +0300)]
0026939: Configuration, NCollection_UBTreeFiller - do not use _REENTRANT in a header file

Use std::mt19937 random number generator instead of rand() in NCollection_UBTreeFiller.

boolean gdml_private ZI7 ZJ7 - TODO "bopcheck failed" is only for Linux now, checkshape faulty is unstable (issue #27052)
boolean volumemaker B6 - Added TODO (bopcheck and checkshape faulties)
boolean volumemaker C9 - Added TODO (checkprops and checkshape faulties)
boolean volumemaker D2 - Added TODO (checkshape faulty)
boolean volumemaker H4 - Added TODO (checkprops and checkshape faulties Linux only)
boolean volumemaker D5 - IMVPROVEMENT, TODOs were deleted (bopcheck and checkshape faulties)
bugs modalg_1 buc60462_2 - modified TODOs according to new behavior
boolean gdml_private ZI7 ZJ7 - unstable case, added check for surface area and TODO

samples/tcl/ANC101.tcl - amended due to changed order of edges in BOP result

5 years agoRevert "0026314: Method SetShape working not correctly."
abv [Tue, 16 Feb 2016 11:53:16 +0000 (14:53 +0300)]
Revert "0026314: Method SetShape working not correctly."

This reverts commit e2df45413ea1d506d911c6f29dacf42c80ca8a35.

5 years agoMerge between correction test case in issue 27119 and 26939
bugmaster [Fri, 12 Feb 2016 08:33:08 +0000 (11:33 +0300)]
Merge between correction test case in issue 27119 and 26939

5 years ago0027053: Compilation fails with "fatal error RC1103: invalid option, /fp:precise"
abv [Sun, 24 Jan 2016 06:28:08 +0000 (09:28 +0300)]
0027053: Compilation fails with "fatal error RC1103: invalid option, /fp:precise"

CMake script is corrected to add compiler options (except macro definitions) to CMAKE_CXX_FLAGS and CMAKE_C_FLAGS variables directly, instead of using add_definitions() command.
This eliminates failure of build by NMake due to incorrect options passed to RC compiler.

5 years ago0026260: Tcl scripts for MBB Gehause Rohteil and ANC101 to be added to Samples
ssv [Mon, 8 Feb 2016 07:43:54 +0000 (10:43 +0300)]
0026260: Tcl scripts for MBB Gehause Rohteil and ANC101 to be added to Samples

Two new sample scripts added, modeling classic shapes from used for comparing modeling systems in 1979 and again in 1983 by Computer Aided Manufacturing International (CAM-I).

5 years ago0027137: Visualization - handle shadow structures within V3d_View::Gravity()
kgv [Wed, 10 Feb 2016 13:19:20 +0000 (16:19 +0300)]
0027137: Visualization - handle shadow structures within V3d_View::Gravity()

OpenGl_StructureShadow - copy bounding box from parent structure.
Prs3d_PresentationShadow::CalculateBoundBox() - do nothing.

V3d_View::Gravity() - skip presentations with transformation persistence flags.
Use cached presentation bounding box.

5 years ago0027119: Regression: Draw command "incmesh" hangs on the attacheced face.
oan [Mon, 1 Feb 2016 14:20:37 +0000 (17:20 +0300)]
0027119: Regression: Draw command "incmesh" hangs on the attacheced face.

BRepMesh_CircleTool: extend radius of circle by quite small value in order to classify points forming inscribed triangle as lying on it. Do not use PConfusion due to false positive result leading algorithm to hanging.

Small correction in test cases bugs/mesh/bug27119

Update of test cases according to the new behavior:

5 years ago0012042: Problem with standard Qt-based Import/Export sample application
apn [Tue, 9 Feb 2016 11:30:52 +0000 (14:30 +0300)]
0012042: Problem with standard Qt-based Import/Export sample application

Front and right views in OCCT CSharp/mfc/qt samples were swapped.

5 years ago0027145: Remove redundant usage of GetPercent procedure
ski [Tue, 9 Feb 2016 13:57:15 +0000 (16:57 +0300)]
0027145: Remove redundant usage of GetPercent procedure

Usage of GetPercent procedure was replaced by checkreal procedure.

5 years ago0027134: Offset algorithm produces an invalid shape from a cone
jgv [Wed, 10 Feb 2016 11:37:31 +0000 (14:37 +0300)]
0027134: Offset algorithm produces an invalid shape from a cone

Correction of test case for issue CR27134

5 years ago0027065: BRepOffsetAPI_MakePipe misses definition of virtual method Generated()
jgv [Thu, 4 Feb 2016 10:35:52 +0000 (13:35 +0300)]
0027065: BRepOffsetAPI_MakePipe misses definition of virtual method Generated()

Virtual method Generated() inherited from BRepPrimAPI_MakeSweep is overridden in class BRepOffsetAPI_MakePipe, providing information on shapes generated from the profile.

5 years ago0026333: Regression of BRepOffsetAPI_MakeOffset regarding to 6.7.0: it fails on a...
ski [Tue, 22 Dec 2015 13:59:20 +0000 (16:59 +0300)]
0026333: Regression of BRepOffsetAPI_MakeOffset regarding to 6.7.0: it fails on a shape with BSpline boundaries

Added test case

Small corrections for issue CR26333

5 years ago0027136: Visualization - skip void bounding box within SelectMgr_SelectableObjectTrsf...
kgv [Fri, 5 Feb 2016 10:12:36 +0000 (13:12 +0300)]
0027136: Visualization - skip void bounding box within SelectMgr_SelectableObjectTrsfPersSet::BVH()

5 years ago0026980: Intersection algorithm spends much system time and system memory
nbv [Mon, 8 Feb 2016 07:01:22 +0000 (10:01 +0300)]
0026980: Intersection algorithm spends much system time and system memory

1. Step of Walking-line has been increased as possible and now computes by iteratively adaptive algorithm (every iteration checks if current step is too big/small and decreases/increases one).

2. Interface of IntWalk_PWalking class has been changed
2.1. Method MaxStep() has been added in order to know about maximal distance between 2D-points.
2.2. Method ComputePasInit(...) has been added in order to initial step value computation.
2.3. Fields myTolTang (tolerance for intersection algorithm) and myStepMin (minimal step value) have been added.

Correction of some test cases.
Creation test case for this issue.
Changes to eliminate compiler warnings.

5 years ago0026415: <TFunction_GraphNode> XML should not break line in the middle of text.
abv [Mon, 1 Feb 2016 14:33:25 +0000 (17:33 +0300)]
0026415: <TFunction_GraphNode> XML should not break line in the middle of text.

Line break between "previous" and "next" ids is replaced by additional spaces (these facilitate visual separation of the two sub-lists).

5 years ago0027114: [Regression to 6.7] DistShapeShape does not find a solution edge-face
aml [Fri, 29 Jan 2016 06:11:46 +0000 (09:11 +0300)]
0027114: [Regression to 6.7] DistShapeShape does not find a solution edge-face

Extrema Curve / Surface algorithm changed to perform more accurate search.

test case bug25232_8 - improvement, one additional intersection point is detected now.
test case bug23830 - normal behavior, position of extrema is changed.

test case for original issue added.

5 years ago0027126: Create command checktrinfo to verify meshes
ski [Tue, 2 Feb 2016 14:14:15 +0000 (17:14 +0300)]
0027126: Create command checktrinfo to verify meshes

Command checktrinfo was created.
Test cases were updated to use command checktrinfo.

5 years ago0027120: Documentation for check commands
apn [Thu, 28 Jan 2016 13:14:23 +0000 (16:14 +0300)]
0027120: Documentation for check commands

Added documentation fot checkprops, checkdump and checklength commands.

Corrected line break in generated documentation.

5 years ago0027095: Configuration, CMake - configuration process finds tcl folder with incorrect...
ski [Wed, 3 Feb 2016 13:37:52 +0000 (16:37 +0300)]
0027095: Configuration, CMake - configuration process finds tcl folder with incorrect bitness for 32bit case

New pattern for seeking of 3rdparty products was added.

5 years ago0027063: BRepGProps raises exception on edge with no curves
ifv [Tue, 10 Dec 2013 11:40:40 +0000 (15:40 +0400)]
0027063: BRepGProps raises exception on edge with no curves

Method BRepGProp::LinearProperties() is corrected to treat not geometric edges (their length is zero). To avoid wrong working of command nexplode global properties are calculated as point properties of vertexes. Small value Epsilon(1.) is used as density of points. This prevents exception on shapes that contain such edges, e.g. copy of a wire containing degenerated edge.

Method BRep_Tool::IsGeometric() is optimized to avoid nested iteration for check of 3D curve for Null.
Small bug is fixed in GProp_PGProps.cxx

5 years ago0026833: Create command checkview containing all viewer types
ski [Wed, 27 Jan 2016 06:55:25 +0000 (09:55 +0300)]
0026833: Create command checkview containing all viewer types

Created command checkview for displaying shapes.

5 years ago0025574: gp_YawPitchRoll Euler Angle computation gives wrong results - warnings
abv [Fri, 5 Feb 2016 08:14:03 +0000 (11:14 +0300)]
0025574: gp_YawPitchRoll Euler Angle computation gives wrong results - warnings

Eliminate VC14 compiler warnings

5 years ago0027121: Configuration, CMake - build process does not use patched header files
ski [Thu, 28 Jan 2016 11:48:07 +0000 (14:48 +0300)]
0027121: Configuration, CMake - build process does not use patched header files

Corrected collecting of all headers to <binary dir>/inc folder

Small correction of documentation about CMake configuration process

5 years ago0027123: Visualization, TKOpenGl - fix environment texture GLSL program
kgv [Sat, 30 Jan 2016 15:24:12 +0000 (18:24 +0300)]
0027123: Visualization, TKOpenGl - fix environment texture GLSL program

OpenGl_ShaderManager::prepareStdProgramFlat() - properly initialize vec4.

5 years ago0027110: Regression: Draw command "parameters" can not compute parameter on the line.
ifv [Tue, 26 Jan 2016 13:56:23 +0000 (16:56 +0300)]
0027110: Regression: Draw command "parameters" can not compute parameter on the line.

Useless variable MAXTOLERANCEGEOM is removed in order to allow to place point at any distance from curve/surface.
Algorithm is simplified: particular calculations for analytical geometry are removed, only using of Extrema_... is kept.

Test case for issue #27110

5 years ago0026726: Draw Harness, ViewerTest - AIS_InteractiveContext::EraseSelected() lacks...
isk [Fri, 29 Jan 2016 07:34:22 +0000 (10:34 +0300)]
0026726: Draw Harness, ViewerTest - AIS_InteractiveContext::EraseSelected() lacks test case
Update draw command ViewerTest::Erase().

5 years ago0027094: Create command checkdump for parsing dumps (geometry test group)
apn [Fri, 22 Jan 2016 12:59:10 +0000 (15:59 +0300)]
0027094: Create command checkdump for parsing dumps (geometry test group)

checkdump - procedure to parse output dump and compare it with reference values;
checklength - procedure to compute length of input shape.
Added procedures and modified test group geometry.

5 years ago0027109: Modifiy test cases using procedure checklength
apn [Mon, 25 Jan 2016 15:55:11 +0000 (18:55 +0300)]
0027109: Modifiy test cases using procedure checklength

Modify cases

5 years ago0027083: Visualization, Ray Tracing - shape with visible face boundaries disappears...
vpa [Wed, 20 Jan 2016 19:11:02 +0000 (22:11 +0300)]
0027083: Visualization, Ray Tracing - shape with visible face boundaries disappears after turning the ray-tracing on

- default state of aspects is now restored to prevent backface culling which is not supported by ray-tracing yet;
- added test case for issue #27083