2 years ago0030156: Visualization, TKV3d - Triangles outside of selection volume are selected
asl [Mon, 24 Sep 2018 08:00:18 +0000 (11:00 +0300)]
0030156: Visualization, TKV3d - Triangles outside of selection volume are selected

The addition of elements to map is put under correct condition that element overlaps with selection volume

2 years ago0030157: Draw Harness - xwd image dump should not be limited by desktop size within...
kgv [Mon, 24 Sep 2018 08:31:40 +0000 (11:31 +0300)]
0030157: Draw Harness - xwd image dump should not be limited by desktop size within batch testing

DrawWindow now uses SWP_NOSENDCHANGING flag within batch mode to ensure
that created window is not clipped in size by desktop dimensions.

2 years ago0028949: BRepOffsetAPI_MakePipe Generated() method produces no result for spine edges
jgv [Thu, 13 Sep 2018 13:17:21 +0000 (16:17 +0300)]
0028949: BRepOffsetAPI_MakePipe Generated() method produces no result for spine edges

Add history for subshapes of spine: edges and vertices. Each edge of spine generates a shell. Each vertex of spine generates a set of edges and, possibly, faces (in the case of Round Corner).

2 years ago0030146: Visualization - exception during attempt to display Edge without geometry
kgv [Thu, 20 Sep 2018 08:40:19 +0000 (11:40 +0300)]
0030146: Visualization - exception during attempt to display Edge without geometry

StdPrs_ToolRFace no skips curves with NULL curves.
Code has been cleaned up from duplicated checks, redundant casts
and dummy Adaptor2d_Curve2dPtr typedef.

StdSelect_BRepSelectionTool::GetSensitiveForFace() now catches
Standard_NullObject exception to skip invalid Edges.

2 years ago0030136: Visualization, TKOpenGl - Graphic3d_TOSM_FACET does not work on mobile devices
mnv [Thu, 13 Sep 2018 14:47:51 +0000 (17:47 +0300)]
0030136: Visualization, TKOpenGl - Graphic3d_TOSM_FACET does not work on mobile devices

Added new type of graphic3d limit Graphic3d_TypeOfLimit_HasFlatShading.
Added workaround for unexpected behaviour of mobile devices with Adreno GPU.
Added new complex flag hasFlatShading to OpenGl_Context for indicating support of flat shading.

2 years ago0030142: Application Framework, TPrsStd_AISPresentation - Hidden Presentations Are...
vro [Tue, 18 Sep 2018 13:24:06 +0000 (16:24 +0300)]
0030142: Application Framework, TPrsStd_AISPresentation - Hidden Presentations Are Computed During Document Retrieval

2 years ago0030140: Modeling Algorithms - Access Null Pointer
nbv [Tue, 18 Sep 2018 08:10:19 +0000 (11:10 +0300)]
0030140: Modeling Algorithms - Access Null Pointer

The array TabP has been allocated correctly.

2 years ago0030143: Foundation Classes - provide operator[] alias for NCollection_Array1, NColle...
kgv [Mon, 17 Sep 2018 10:14:00 +0000 (13:14 +0300)]
0030143: Foundation Classes - provide operator[] alias for NCollection_Array1, NCollection_Vector

2 years ago0030135: Visualization, TKOpenGl - frame statistics do not include information about... IR-2018-09-14 OCCT_VC2017_73
kgv [Thu, 13 Sep 2018 14:34:08 +0000 (17:34 +0300)]
0030135: Visualization, TKOpenGl - frame statistics do not include information about instanced structures

OpenGl_FrameStats now takes into account OpenGl_Structure::InstancedStructure().
OpenGl_View::renderStructs() - fixed resetting non-culled structure counters.

2 years ago0030130: Coding Rules - MSVC 2017 gives warnings about using of std::fpos::seekpos...
abv [Wed, 12 Sep 2018 19:38:38 +0000 (22:38 +0300)]
0030130: Coding Rules - MSVC 2017 gives warnings about using of std::fpos::seekpos() within RWStl

Use of deprecated method std::fpos::seekpos() is avoided with MSVC 11 (Visual Studio 2012) and above.

2 years ago0030131: Foundation Classes - support of Linear builder for 2D BVH trees
osa [Tue, 11 Sep 2018 18:56:14 +0000 (21:56 +0300)]
0030131: Foundation Classes - support of Linear builder for 2D BVH trees

BVH_LinearBuilder and BVH_RadixSorter now accept N==2.
NCollection_Vec2/3/4 - added missing division by vec operators.

2 years ago0029988: AIS_Shape - SetWidth() and SetColor() has no effect for FaceBoundary
kgv [Mon, 10 Sep 2018 15:44:17 +0000 (18:44 +0300)]
0029988: AIS_Shape - SetWidth() and SetColor() has no effect for FaceBoundary

AIS_Shape SetWidth and SetColor methods now propagate modifications to FaceBoundary aspect.

2 years ago0030118: Draw Harness - extend vcomputehlr command with HLR algo type
kgv [Mon, 10 Sep 2018 09:25:29 +0000 (12:25 +0300)]
0030118: Draw Harness - extend vcomputehlr command with HLR algo type

vcomputehlr has been extended with -algoType argument
and sets result as DBRep shape in addition to displaying AIS_Shape.

2 years ago0030092: Modeling Algorithms - Invalid result of Section operation
emv [Wed, 29 Aug 2018 08:51:43 +0000 (11:51 +0300)]
0030092: Modeling Algorithms - Invalid result of Section operation

The following improvements have been made in Boolean operations algorithm in order to fix the problem:
1. Initialization of the pave blocks which vertices have acquired the SD ones.
2. Removing from Data Structure the small edges having the same vertices on both ends (either initially or acquired).
3. Avoid adding empty SD connections when one vertex points to itself.

Test case for the issue.

2 years ago0029986: Configuration - environment scripts generated by CMake on Linux do not allow...
apn [Wed, 29 Aug 2018 09:40:35 +0000 (12:40 +0300)]
0029986: Configuration - environment scripts generated by CMake on Linux do not allow starting DRAW from build folder

Correct launching custom.sh in env.sh.in.
Correct definition of FFMPEG_DIR in custom.build.bat/sh.in and generation of custom_*.sh (variables CSF_OCCTBinPath and CSF_OCCTLibPath are not empty on the first run)

2 years ago0030091: Configuration - allow cross-compilation from Linux (case sensitive filesyste...
abv [Thu, 6 Sep 2018 15:59:19 +0000 (18:59 +0300)]
0030091: Configuration - allow cross-compilation from Linux (case sensitive filesystem) to x86_64-w64-mingw32

Names of Windows header files are corrected to be lower case to match their actual names on Windows (except Windows.h) and MinGW.
Files COMMANDWINDOW.h and MAINWINDOW.h in Draw package are renamed to CamelCase according to names of corresponding CXX files.

2 years ago0030026: Configuration, CMake - not clear description of some fields
mnv [Thu, 9 Aug 2018 09:27:10 +0000 (12:27 +0300)]
0030026: Configuration, CMake - not clear description of some fields

Updated description for 3RDPARTY_FREETYPE_INCLUDE_DIR_freetype2 and 3RDPARTY_FREETYPE_INCLUDE_DIR_ft2build fields.

2 years ago0030094: Modeling Algorithms - Defeaturing does not work on the attached shape due...
emv [Fri, 31 Aug 2018 07:17:47 +0000 (10:17 +0300)]
0030094: Modeling Algorithms - Defeaturing does not work on the attached shape due to incorrect extension of the torus

BRepLib::ExtendFace method when working with analytical and periodic faces now takes into account the possible closeness of the result face.
Test cases for the issue.

2 years ago0030100: Modeling Algorithms - ShapeUpgrade_UnifySameDomain is unable to unify faces...
emv [Fri, 31 Aug 2018 07:07:05 +0000 (10:07 +0300)]
0030100: Modeling Algorithms - ShapeUpgrade_UnifySameDomain is unable to unify faces based on the same toroidal surface

When performing intersection of toroidal faces check first if they are based on the same surface.
Test cases for the issue.

2 years ago0029972: Intersection curve has a weird gap in the middle of it
nbv [Mon, 23 Jul 2018 11:00:16 +0000 (14:00 +0300)]
0029972: Intersection curve has a weird gap in the middle of it

1. The condition of WLine breaking (in IntWalk_IWalking algorithm) has become more independent of the input tolerance.

2. Currently the algorithm of IntPatch_Points of WLine processing depends on the algorithm of obtaining the WLine.

3. The methods IntSurf_LineOn2S::Add(...) and IntSurf_LineOn2S::SetUV(...) have become not inline (see the message ~0077431 in the issue #29866).

2 years ago0030087: Invalid result of the translation of the assembly when relating and related...
gka [Fri, 24 Aug 2018 16:08:38 +0000 (19:08 +0300)]
0030087: Invalid result of the translation of the assembly when relating and related products are mixed in the SRR entity

Detection of specific case of error in the definition of transformation matrix describing position of the component within assembly, when it has Axis Placements swapped, is corrected to handle the case when one of these Axis Placements is contained in both Shape Representations (of the assembly and its component).
This allows the problematic STEP file to be translated correctly.

Added test bugs step bug30087

2 years ago0030102: Visualization, TKOpenGl - Graphic3d_TOSM_FACET shading is incorrect in some...
mnv [Fri, 31 Aug 2018 12:14:49 +0000 (15:14 +0300)]
0030102: Visualization, TKOpenGl - Graphic3d_TOSM_FACET shading is incorrect in some casesn

gl_FrontFacing is now considered within Normal computation.

2 years ago0030093: Test system - Incorrect parsing of the regular expression
apn [Mon, 3 Sep 2018 08:52:00 +0000 (11:52 +0300)]
0030093: Test system - Incorrect parsing of the regular expression

Add "\-" to regular expression (which contained only literal, numeric and underscore character).

2 years ago0030090: Modeling Algorithms - BRepLib::FindValidRange does not find valid range...
emv [Tue, 28 Aug 2018 09:22:01 +0000 (12:22 +0300)]
0030090: Modeling Algorithms - BRepLib::FindValidRange does not find valid range for the edge

BRepLib::FindValidRange - check each sampling point to be out of tolerance sphere of the vertex.
Test case for the issue.

2 years ago0027928: BOP common produces empty compound
emv [Wed, 29 Aug 2018 06:08:13 +0000 (09:08 +0300)]
0027928: BOP common produces empty compound

BOPTools_AlgoTools::ComputeState - increase the chance of correct classification of the face relatively solid by classifying the point located inside that face instead of the point taken near the edge of that face.
Test case for the issue.

2 years ago0030082: Intersection algorithm returns curve with big tolerance value
nbv [Thu, 23 Aug 2018 13:37:59 +0000 (16:37 +0300)]
0030082: Intersection algorithm returns curve with big tolerance value

The fix inserts new points at the end of the WLine in case when the direction of the intersection curve is significantly changed.

2 years ago0030058: Visualization, Select3D_SensitivePrimitiveArray - the selection is not fast...
kgv [Fri, 17 Aug 2018 12:00:11 +0000 (15:00 +0300)]
0030058: Visualization, Select3D_SensitivePrimitiveArray - the selection is not fast enough

Select3D_SensitiveSet::Matches() has been improved to check if BVH node is fully included by selection volume
and pass this information to overlapsElement()/elementIsInside() interfaces
to avoid expensive partial overlapping checks for individual elements.
Select3D_SensitivePrimitiveArray implements this new interface to improve partial overlapping performance.
Select3D_SensitivePrimitiveArray::Matches() now handles rectangle selection for sub-elements when Elements map is defined.
Added missing const to SelectMgr_BaseFrustum::Overlaps() methods.

AIS_PointCloud has been extended with new selection mode for collecting selected nodes

Draw Harness command vdrawparray has been extended with an option -shape
allowing to create a triangulation from tessellated shape.

2 years ago0029881: Data Exchange - PMI entities ignore length Units
skl [Tue, 21 Aug 2018 14:33:03 +0000 (17:33 +0300)]
0029881: Data Exchange - PMI entities ignore length Units

2 years ago0030081: Visualization - selection does not work when two clipping planes cut object...
kgv [Thu, 23 Aug 2018 13:26:12 +0000 (22:26 +0900)]
0030081: Visualization - selection does not work when two clipping planes cut object from opposite sides

Fixed combining independent clipping planes into single range within SelectMgr_RectangularFrustum::computeClippingRange().

2 years ago0028694: IGES reader produces too small edge covered by its vertices
skl [Thu, 9 Aug 2018 09:26:20 +0000 (12:26 +0300)]
0028694: IGES reader produces too small edge covered by its vertices

Methods IsUClosed() and IsVClosed() are changed (check distance to middle point is added).

2 years ago0030068: Documentation - V3d_View::ToPixMap() description should clarify that method...
kgv [Wed, 15 Aug 2018 18:08:00 +0000 (21:08 +0300)]
0030068: Documentation - V3d_View::ToPixMap() description should clarify that method will redraw the View content before dump

2 years ago0030071: Tests - locate_data_file does not skip .git folders
kgv [Thu, 16 Aug 2018 11:42:30 +0000 (14:42 +0300)]
0030071: Tests - locate_data_file does not skip .git folders

Regexp is now applied to subfolder name to filter folders starting with dot.

2 years ago0029782: Shape Healing - Reading of invalid shape
skl [Mon, 13 Aug 2018 13:34:26 +0000 (16:34 +0300)]
0029782: Shape Healing - Reading of invalid shape

2 years agoAdjusting testing cases for VC 2017 IR-2018-08-09 JT-12-WEEK32
bugmaster [Wed, 8 Aug 2018 15:33:16 +0000 (18:33 +0300)]
Adjusting testing cases for VC 2017

2 years ago0029910: Porting to Debian80-64 : Regressions in Modeling Algorithms
nbv [Mon, 16 Jul 2018 12:32:23 +0000 (15:32 +0300)]
0029910: Porting to Debian80-64 : Regressions in Modeling Algorithms

Adjusting test cases.
Creation of new test cases.

2 years ago0030015: Documentation - Correct warnings in OCCT and PRODUCTS documentation
apn [Mon, 6 Aug 2018 13:58:02 +0000 (16:58 +0300)]
0030015: Documentation - Correct warnings in OCCT and PRODUCTS documentation

Fix warning multiple use of section label 'upgrade_740_extremaalgo' in the file upgrade.md

2 years ago0029978: Data Exchange, macOS - the result of reading some entity from STEP looks odd IR-2018-08-03 JT-12-WEEK31
abv [Thu, 26 Jul 2018 07:36:12 +0000 (10:36 +0300)]
0029978: Data Exchange, macOS - the result of reading some entity from STEP looks odd

On Apple with XCode 9.4.1 and onwards, the compiler optimization is disabled for method gp_Mat::Transpose() as optimizer generates invalid code when that method is used.
Some refactoring of the code affected by this bug.

2 years ago0029938: Visualization - SelectMgr_ViewerSelector::PickedPoint() should return point...
mnv [Mon, 23 Jul 2018 12:08:01 +0000 (15:08 +0300)]
0029938: Visualization - SelectMgr_ViewerSelector::PickedPoint() should return point lying on an object

Extended SelectBasics_PickResult structure by myObjPickedPnt field, which contained the value of the 3d point on the selected object.
Changed all Overlaps methods. Parameter theDepth replaced on object of the structure SelectBasics_PickResult. This approach will be able to add new fields to SelectBasics_PickResult structure without big changes in modules which contained Overlaps method.

2 years ago0030005: Visualization, OpenGl_Context - replace NCollection_SparseArray with NCollec...
kgv [Tue, 31 Jul 2018 19:12:04 +0000 (22:12 +0300)]
0030005: Visualization, OpenGl_Context - replace NCollection_SparseArray with NCollection_Array1 for myDrawBuffers

2 years ago0030004: Visualization, AIS_Manipulator - disable detection of Rotating circle when...
kgv [Tue, 31 Jul 2018 14:37:49 +0000 (17:37 +0300)]
0030004: Visualization, AIS_Manipulator - disable detection of Rotating circle when picking ray lies on its plane

2 years ago0029915: Porting to VC 2017 : Regressions in Modeling Algorithms on VC 2017
jgv [Tue, 17 Jul 2018 18:16:35 +0000 (21:16 +0300)]
0029915: Porting to VC 2017 : Regressions in Modeling Algorithms on VC 2017

Methods GeomConvert::ConcatG1, GeomConvert::ConcatC1, Geom2dConvert::ConcatG1, Geom2dConvert::ConcatC1 are corrected to prevent exceeding maximum degree of BSpline curve in case of closed contour.

2 years ago0029940: The method TPrsStd_AISPresentation::SetSelectionMode() seems useless for...
vro [Tue, 10 Jul 2018 11:58:08 +0000 (14:58 +0300)]
0029940: The method TPrsStd_AISPresentation::SetSelectionMode() seems useless for transactions

A boolean parameter is added with a default value to the method TPrsStd_AISPresentation::SetSelectionMode().
By default, behavior of the method is not changed. But if the parameter's value is changed to FALSE, change of selection mode for the object will not influence the transaction. In other words, the attribute will not set modified and will not put into transaction delta. This behavior suits the usual notion of the object in an application: the object has color, material, transparency, but selection mode is not a property of the object. It is a property of an operation involving the object. Therefore, it has sense to remove the method SetSelectionMode() from TPrsStd_AISPresentation. For a while, it is marked as obsolete.

2 years ago0029994: Misprint in IntWalk_PWalking::Perform(...) method
nbv [Fri, 27 Jul 2018 13:29:55 +0000 (16:29 +0300)]
0029994: Misprint in IntWalk_PWalking::Perform(...) method

In the fragment

        if (aNewPnt[0] < u1min || aNewPnt[0] > u1max ||
            aNewPnt[1] < v1min || aNewPnt[1] > v1max ||
            aNewPnt[2] < u2min || aNewPnt[2] > u2max ||
            aNewPnt[3] < v2min || aNewPnt[3] > v2max)
          break; // Out of borders, handle this later.

the parameters are compared with values obtained by IntPolyh_MaillageAffinage algorithm and do not have any relations to the domain boundaries.

This misprint has been eliminated.

2 years ago0028085: Incorrect result of CUT operation
nbv [Tue, 17 Jul 2018 09:32:14 +0000 (12:32 +0300)]
0028085: Incorrect result of CUT operation

Before the fix, small arc of circle returned as intersection result. It was connected with the fact that the circle always was limited in 0 and 2*PI points. Currently the bounds of the circle (retrieved as an intersection curve) are computed from the real domain of the arguments (there is not a snap to the fixed 0 and 2*PI points).

2 years ago0029997: Coding Rules - eliminate GCC compiler warnings -Wmaybe-uninitialized in...
kgv [Sat, 28 Jul 2018 18:18:05 +0000 (21:18 +0300)]
0029997: Coding Rules - eliminate GCC compiler warnings -Wmaybe-uninitialized in Select3D_InteriorSensitivePointSet.cxx

2 years ago0029573: ConcatenateWireC0 crashes on two edges wire
ifv [Fri, 27 Jul 2018 07:21:43 +0000 (10:21 +0300)]
0029573: ConcatenateWireC0 crashes on two edges wire

Wrong setting first/last vertices is fixed
Test case added

2 years ago0029911: Porting to Debian80-64 : Regressions in Foundation Classes IR-2018-07-27 JT-12-WEEK30
abv [Tue, 24 Jul 2018 14:45:15 +0000 (17:45 +0300)]
0029911: Porting to Debian80-64 : Regressions in Foundation Classes

Test for handles is updated according to behavior expected from modern compilers.

Performance test perf ncollection A1 is updated (valid range extended) according to measurements made on Debian 8 with GCC 4.9 and on Ubuntu 16.04 with CLang 3.8 and 6.0 and GCC 4.7, 4.9, and 5.0.

2 years ago0029859: Coding - GCC compiler warning -Warray-bounds in IntPatch_InterferencePolyhed...
abv [Thu, 26 Jul 2018 04:48:56 +0000 (07:48 +0300)]
0029859: Coding - GCC compiler warning -Warray-bounds in IntPatch_InterferencePolyhedron.cxx

2 years ago0029967: Draw Harness - command bounding has annoying syntax
kgv [Fri, 20 Jul 2018 10:07:47 +0000 (13:07 +0300)]
0029967: Draw Harness - command bounding has annoying syntax

Bnd_OBB constructor from Bnd_Box is fixed for VOID input.

DRAW command bounding command is adjusted:
- Support of old syntax 'bounding shape'is restored.
- Exception on VOID bounding box is avoided.
- Arguments are handled in case-insensitive way.
- Options -s, -perfmeter, and ability to set result as first argument are removed as redundant.
- Help is moved to command definition.

Separate command OCC29311 is added (in QADraw) to do the same as option -perfmeter did; tests are updated.

2 years ago0029973: Modeling Algorithms - access violation within BRepAlgoAPI_Cut on empty input...
emv [Fri, 20 Jul 2018 12:16:50 +0000 (15:16 +0300)]
0029973: Modeling Algorithms - access violation within BRepAlgoAPI_Cut on empty input shape

Boolean Operations algorithm has been improved to handle the cases with empty shapes arguments correctly.
Test cases for the issue.

2 years ago0029711: General Fuse operation produces invalid result
emv [Wed, 16 May 2018 09:12:09 +0000 (12:12 +0300)]
0029711: General Fuse operation produces invalid result

The following improvements have been introduced in Boolean Operations algorithm s:
1. UBTree is replaced with EBTree in Boolean operations to be able to add/remove elements into the tree of bounding boxes.
2. Repeated (nested) intersection of sub-shapes is performed with argument vertices whose tolerances increased during the operation.
3. The algorithms of Edge/Edge and Edge/Face intersection have been improved for the cases when the intersection point is located close to the edge boundaries .
4. New procedure has been implemented to ensure forced creation of Edge/Face common blocks in cases when the edge is really close to the face.
5. Post-processing of Face/Face intersection results has been improved.
6. Extension of the planar faces for Plane/Plane intersection is avoided.
7. Builder Face now better classifies potentially internal edges relatively to new faces with filtering by bounding boxes.

Side effect changes:
1. IntTools_ShrunkRange now keeps the length of the valid range of the edge.
2. The method BOPDS_DS::UpdateEdgeTolerance() has been removed as unused (replaced by the BOPAlgo_PaveFiller::UpdateEdgeTolerance()).

Test case for the issue 0029900.
Test case for the issue 0029711.
Adjustments of the existing test cases.

Avoid using uninitialized variables.

2 years ago0029958: Visualization - add method Graphic3d_ArrayOfPrimitives::AddEdges() taking...
kgv [Sat, 14 Jul 2018 10:59:22 +0000 (13:59 +0300)]
0029958: Visualization - add method Graphic3d_ArrayOfPrimitives::AddEdges() taking up to 4 edges

2 years ago0029975: Visualization - Graphic3d_ClipPlane::ProbeBox() returns Out for fully In box
kgv [Fri, 20 Jul 2018 07:40:14 +0000 (10:40 +0300)]
0029975: Visualization - Graphic3d_ClipPlane::ProbeBox() returns Out for fully In box

2 years ago0029981: Coding - Clang 6.0 warning [-Wenum-compare-switch]
abv [Mon, 23 Jul 2018 18:58:47 +0000 (21:58 +0300)]
0029981: Coding - Clang 6.0 warning [-Wenum-compare-switch]

In implementation of DRAW command "mkplane", the case labels of the switch statement are corrected to use values of the enum matching the type of the switch argument.

2 years ago0029980: Configuration, CMake - impossible to override CMAKE_CXX_USE_RESPONSE_FILE_FO...
kgv [Mon, 23 Jul 2018 16:13:29 +0000 (19:13 +0300)]
0029980: Configuration, CMake - impossible to override CMAKE_CXX_USE_RESPONSE_FILE_FOR_OBJECTS

Variables are not assigning only if have not been previously defined.

2 years ago0029740: Draw Harness - eliminate redundant casts to AIS_InteractiveObject
kgv [Mon, 23 Jul 2018 18:12:13 +0000 (21:12 +0300)]
0029740: Draw Harness - eliminate redundant casts to AIS_InteractiveObject

NCollecton_DoubleMap has been extended with two new methods Find1() and Find2()
performing lookup and returning found key withoout throwing an exception
(similar to NCollection_DataMap::Find()).

ViewerTest_DoubleMapOfInteractiveAndName has been redeclared to define
Handle(AIS_InteractiveObject) key instead of Handle(Standard_Transient).

2 years ago0029974: Visualization - OpenGl_Layer::Render() produces inconsistent state of Polygo...
kgv [Thu, 19 Jul 2018 17:32:51 +0000 (20:32 +0300)]
0029974: Visualization - OpenGl_Layer::Render() produces inconsistent state of Polygon Offset settings

OpenGl_Layer::Render() now calls OpenGl_Workspace::SetDefaultPolygonOffset()
for managing default polygon offset settings considering OpenGl_Workspace applied aspect logic.

2 years ago0029949: Draw Harness - simplify vtriangle command implementation
kgv [Wed, 11 Jul 2018 14:50:39 +0000 (17:50 +0300)]
0029949: Draw Harness - simplify vtriangle command implementation

vtriangle and vsegment commands now share presentation created by vdrawparray command.

Added missing accessors to Graphic3d_ArrayOfPrimitives properties
VertexNumberAllocated(), EdgeNumberAllocated() and BoundNumberAllocated().

2 years ago0029969: Modeling Algorithms - BRepPrimAPI_MakeHalfSpace::Shape() returns NULL shape...
kgv [Tue, 17 Jul 2018 22:04:58 +0000 (01:04 +0300)]
0029969: Modeling Algorithms - BRepPrimAPI_MakeHalfSpace::Shape() returns NULL shape while reporting IsDone()

2 years ago0029955: Face and Solid BOP: Building 2D curve of edge on face has failed
emv [Tue, 17 Jul 2018 07:08:27 +0000 (10:08 +0300)]
0029955: Face and Solid BOP: Building 2D curve of edge on face has failed

Test case for the issue as it is not reproduced anymore.

2 years ago0028113: BOPAlgo_Builder produces invalid shape IR-2018-07-20 JT-12-WEEK29
emv [Tue, 17 Jul 2018 09:07:59 +0000 (12:07 +0300)]
0028113: BOPAlgo_Builder produces invalid shape

Fast rebuilding of the face is now avoided if its edges have been unified during the intersection.
Full rebuilding of the face is required in this case (using BuilderFace algorithm).

2 years ago0029970: Coding Rules - StdSelect_BRepOwner::Set() method is declared but undefined
kgv [Fri, 20 Jul 2018 08:08:34 +0000 (11:08 +0300)]
0029970: Coding Rules - StdSelect_BRepOwner::Set() method is declared but undefined

Undefined method has been removed.

2 years ago0028123: Boolean Cut produces faulty shape
emv [Mon, 16 Jul 2018 12:45:02 +0000 (15:45 +0300)]
0028123: Boolean Cut produces faulty shape

Test case for the issue as it is not reproduced anymore.

2 years ago0029968: Modeling Algorithms - BRepAlgoAPI_Cut produces an empty result with half...
emv [Wed, 18 Jul 2018 12:31:52 +0000 (15:31 +0300)]
0029968: Modeling Algorithms - BRepAlgoAPI_Cut produces an empty result with half-space

IntTools_Context::IsInfiniteFace() - Make the conclusion about infinity of the face basing on its bounding box only. No need to check NaturalRestriction flag.

2 years ago0029830: STEPCAFControl_Reader poor performance - quadratic dependence
msv [Fri, 1 Jun 2018 11:38:39 +0000 (14:38 +0300)]
0029830: STEPCAFControl_Reader poor performance - quadratic dependence

Various performance improvements in STEP read/write algorithms:
- Search for the  label of a shape or component shape is improved using map mechanism instead of brute force iteration.
- Invariant FindEntities() is moved out of the loop in the method getStyledItem in STEPCAFControl/STEPCAFControl_Writer.cxx.
- A pointer to the end of binders chain is added in Transfer_Binder class to speed up adding a binder to the chain.
- Small fixes are added  to eliminate excess copying of handles, calls of handle DownCasts and so on.

Stack overflow is removed during destruction of STEP model with long chains of Transfer_Binder.
It is possible to use the Draw commands ReadStep and WriteStep to read/write from the session without accessing the disk file (use '.' for the file name).

Performance test cases for STEP reading/writing have been added.

2 years ago0029769: Uninitialized data with BSplCLib_Cache, BSplSLib_Cache
abv [Sun, 10 Jun 2018 19:40:12 +0000 (22:40 +0300)]
0029769: Uninitialized data with BSplCLib_Cache, BSplSLib_Cache

Implementation of classes BSplCLib_Cache and BSplSLib_Cache is revised:
- Common functionality dealing with spans along one parametric direction is separated to new struct BSplCLib_CacheParams
- Empty constructors are removed; copying is prohibited
- Code reconsidering degree and other parameters on each call to BuildCache() is eliminated; curve parameters must be the same in constructor and all calls to BuildCache()
- Extra call to BuildCache() from constructor is eliminated

2 years ago0025852: Visualization - Font_BRepFont produces bad faces for circled symbols
skl [Thu, 12 Jul 2018 06:47:02 +0000 (09:47 +0300)]
0025852: Visualization - Font_BRepFont produces bad faces for circled symbols

Font_BRepFont now uses a dedicated algorithm for text-to-BRep transformation instead of relying on ShapeFix.
It orders wires based on wire classification, analyzes internal zones and creates a few faces (if needed).
TKService dependency from TKShHealing has been dropped.

2 years ago0029861: Modeling Algorithms - BiTgte_Blend gives exception
jgv [Fri, 15 Jun 2018 17:22:38 +0000 (20:22 +0300)]
0029861: Modeling Algorithms - BiTgte_Blend gives exception

The algorithm has been corrected to avoid exception.
Now both Draw commands "brollingball" and "rollingball" give correct results.
Test cases "offset faces_type_a A3, A4, A9" are good now.

2 years ago0029959: Coding - new warnings after integration 29846
gka [Mon, 16 Jul 2018 09:08:00 +0000 (12:08 +0300)]
0029959: Coding - new warnings after integration 29846

Erroneous label declaration has been removed in function SetMaterial from XDEDRAW_Props.cxx

2 years ago0027230: Boolean operations fails on attached shapes
emv [Mon, 16 Jul 2018 10:03:17 +0000 (13:03 +0300)]
0027230: Boolean operations fails on attached shapes

Test case for the issue as it is not reproduced anymore.

2 years ago0029961: Foundation Classes - NCollection_Shared constructor passes arguments by...
kgv [Sun, 15 Jul 2018 08:35:12 +0000 (11:35 +0300)]
0029961: Foundation Classes - NCollection_Shared constructor passes arguments by copy

New NCollection_Shared constructors taking arguments by reference have been added.

2 years ago0029960: Foundation Classes - disarm OSD_ThreadPool copy constructor
kgv [Sat, 14 Jul 2018 16:17:26 +0000 (19:17 +0300)]
0029960: Foundation Classes - disarm OSD_ThreadPool copy constructor

Private copy constructors have been added to OSD_ThreadPool
and Standard_Condition to protect misuse.

2 years ago0029846: Data Exchange - STEP validation properties support is obsolete IR-2018-07-13
gka [Thu, 5 Jul 2018 16:10:31 +0000 (19:10 +0300)]
0029846: Data Exchange - STEP validation properties support is obsolete

Name of the PROPERTY_DEFINITION entity for validation properties is changed to "geometric validation property" according to the current version of the recommended practices.
For compatibility with older definitions (with underscores) the check is made using string with underscores replaced by spaces.

2 years ago0029817: Documentation - avoid excessive use of "please"
ysn [Mon, 9 Jul 2018 10:53:01 +0000 (13:53 +0300)]
0029817: Documentation - avoid excessive use of "please"

"Please" is now used in the documentation only in sensitive cases.

2 years ago0029873: Data Exchange - STEPCAFControl_Reader::Transfer() returns TRUE even when...
skl [Tue, 10 Jul 2018 11:45:11 +0000 (14:45 +0300)]
0029873: Data Exchange - STEPCAFControl_Reader::Transfer() returns TRUE even when external files are missing

Output information about failure during reading of external file has been added (it can be checked by using Draw command "tpstat").
If the reader cannot find an external file at the first found location
(using entity APPLIED_EXTERNAL_IDENTIFICATION_ASSIGNMENT) it checks other information about file path
(using entity DOCUMENT_FILE related with the above-mentioned entity) and uses a new location for import of the external file.

2 years ago0029935: Foundation Classes - introduce OSD_ThreadPool class defining a thread pool
kgv [Fri, 6 Jul 2018 23:27:51 +0000 (02:27 +0300)]
0029935: Foundation Classes - introduce OSD_ThreadPool class defining a thread pool

New class OSD_ThreadPool has been introduced to define a Thread Pool for multi-threading algorithm.
Thread Pool assigns a serial number for each thread allowing Multi-Threading algorithm to allocate thread-local storage variables as an array whose size is the same as the number of threads.

OSD_ThreadPool also redirects exceptions to a thread calling parallel execution and consistently initializes FPE exception handling.

New class Standard_Condition provides a platform-independent  tool similar to Event in WinAPI.

A new auxiliary function Standard_Atomic_CompareAndSwap() has been introduced
for performing atomic compare and swap of integer number.
Standard_Atomic_Increment/Standard_Atomic_Decrement fallback implementation
using ASM code for x86 processors for GCC has been dropped;
instead, it is expected that GCC should be properly configured targeting modern x86 architectures.

OSD_Signal now declares fFltExceptions as thread_local variable accessible through OSD::ToCatchFloatingSignals() property.
Standard_THREADLOCAL macro (wrapping thread_local attribute) has been moved to public header Standard_Macro.hxx.

OSD_Parallel::ForEach() has been extended with new optional parameter theNbItems and uses OSD_ThreadPool::DefaultPool().

2 years ago0029425: Visualization - AIS_InteractiveContext::SetAutomaticHilight() has no affect
kgv [Thu, 21 Jun 2018 09:19:08 +0000 (12:19 +0300)]
0029425: Visualization - AIS_InteractiveContext::SetAutomaticHilight() has no affect

AIS_InteractiveContext::MoveTo() and ::Select() now do not highlight entities
when ::AutomaticHilight() option is turned off.

vselprops command has been extended with new arguments -autoHighlight and -highlightSelected
(vhighlightselected command is now deprecated).

2 years ago0029945: Export body of revolution to STEP breaks the shape
ika [Wed, 11 Jul 2018 14:29:34 +0000 (17:29 +0300)]
0029945: Export body of revolution to STEP breaks the shape

Now vertex loops on surfaces of revolution are imported from STEP format in the same way as on spheres and b-spline surfaces: in case of a single vertex loop neutral bounds will be used.

2 years ago0029936: Documentation - improve description of AIS_Animation class
kgv [Sat, 7 Jul 2018 01:08:57 +0000 (04:08 +0300)]
0029936: Documentation - improve description of AIS_Animation class

2 years ago0029947: Visualization - SelectMgr_SelectableObject::GetSelectPresentation() should...
kgv [Wed, 11 Jul 2018 12:52:02 +0000 (15:52 +0300)]
0029947: Visualization - SelectMgr_SelectableObject::GetSelectPresentation() should copy object clipping planes

Methods SelectMgr_SelectableObject::GetHilightPresentation(), ::GetSelectPresentation() and ::UpdateClipping()
have been corrected to copy clipping planes of the object into highlighting and selection presentations.

2 years ago0029948: Uninitialized variable in GeomEvaluator_OffsetSurface::CalculateD0(...)...
nbv [Wed, 11 Jul 2018 14:29:54 +0000 (17:29 +0300)]
0029948: Uninitialized variable in GeomEvaluator_OffsetSurface::CalculateD0(...) method

Variable "NStatus" from GeomEvaluator_OffsetSurface class is now initialized correctly.

2 years ago0029866: Intersector returns two overlapped curves as a result
nbv [Tue, 3 Jul 2018 15:14:30 +0000 (18:14 +0300)]
0029866: Intersector returns two overlapped curves as a result

Since now a new WLine is not created if its start point lies in another earlier computed WLine. It allows avoiding creation of duplicate WLines in the intersection result.


1. Methods IsOutSurf1Box(...), IsOutSurf2Box(...), IsOutBox(...) for classes IntSurf_LineOn2S and IntPatch_RLine have been created.

2 years ago0029939: Modeling Algorithms - add NULL check to BRepGProp_Face::Load()
kgv [Wed, 4 Jul 2018 09:09:50 +0000 (12:09 +0300)]
0029939: Modeling Algorithms - add NULL check to BRepGProp_Face::Load()

BRepGProp_Face::Load() has been protected against crash in case of edges without p-curves.

2 years ago0029944: Porting to VC 2017 : Regressions on the gcc (Debian 4.9.2-10) 4.9.2. Excepti...
gka [Tue, 10 Jul 2018 16:20:50 +0000 (19:20 +0300)]
0029944: Porting to VC 2017 : Regressions on the gcc (Debian 4.9.2-10) 4.9.2. Exception is raised during load STEP file.

Boolean parameter "same_sence" from class RWStepShape_RWAdvancedFace.cxx is now initialized correctly.

2 years ago0029942: Porting to Debian80-64 : Regressions in Modeling Algorithms after integratio...
nbv [Tue, 10 Jul 2018 09:50:03 +0000 (12:50 +0300)]
0029942: Porting to Debian80-64 : Regressions in Modeling Algorithms after integration fix for 29807

Correction in the test case perf/modalg/bug27021.

2 years ago0029916: Regressions in Data Exchange on VC 2017
gka [Wed, 4 Jul 2018 16:45:58 +0000 (19:45 +0300)]
0029916: Regressions in Data Exchange on VC 2017

The "end" file from folder "de" has been corrected to exclude comparing the number of edges in the shapes from current result with test data.
"TODO messages generated for differences were removed.
Data exchange tests were regenerated.

2 years ago0029934: Visualization - handle properly orthogonal clipping plane within SelectMgr_R...
kgv [Fri, 6 Jul 2018 16:04:49 +0000 (19:04 +0300)]
0029934: Visualization - handle properly orthogonal clipping plane within SelectMgr_RectangularFrustum::computeClippingRange()

SelectMgr_RectangularFrustum now considers the direction of clipping plane orthogonal to picking ray.

2 years ago0029823: Visualization, TKOpenGl - highlighting by Bounding Box mistreats Local Trans... IR-2018-07-06 JT-12-WEEK37
mnv [Mon, 2 Jul 2018 08:21:35 +0000 (11:21 +0300)]
0029823: Visualization, TKOpenGl - highlighting by Bounding Box mistreats Local Transformation

The problem when object transformation was applied to the bounding box twice has been fixed in OpenGl_Structure.
OpenGl_ShaderManager has been extended with GLSL program drawing bounding box.
OpenGl_Structure does not create extra Groups for drawing bounding box.

2 years ago0029874: Visualization - capping plane transparency does not work
kgv [Fri, 15 Jun 2018 16:39:31 +0000 (19:39 +0300)]
0029874: Visualization - capping plane transparency does not work

Interface OpenGl_RenderFilter and its implementations have been merged into OpenGl_Workspace.
This limits flexibility of interface, but simplifies logic.
- OpenGl_RenderFilter_FillModeOnly flag replaces OpenGl_CappingAlgoFilter;
- OpenGl_RenderFilter_NonRaytraceableOnly flag replaces OpenGl_RaytraceFilter;
- OpenGl_RenderFilter_OpaqueOnly flag replaces OpenGl_OpaqueFilter;
- OpenGl_RenderFilter_TransparentOnly flag replaces OpenGl_TransparentFilter.

OpenGl_CappingAlgo now:
- avoids redundant Stencil clearing when Layer contains at least one transparent Element;
- renders semitransparent capping plane within transparent elements pass.

vclipplane command has been extended by new argument -transparency.

2 years ago0029929: Visualization, V3d_View - make method ::FitMinMax() public
kgv [Thu, 5 Jul 2018 09:54:05 +0000 (12:54 +0300)]
0029929: Visualization, V3d_View - make method ::FitMinMax() public

2 years ago0029928: Regressions: a lot of warnings produced during generation Overview by Doxygen
apn [Wed, 4 Jul 2018 10:17:51 +0000 (13:17 +0300)]
0029928: Regressions: a lot of warnings produced during generation Overview by Doxygen

Warnings in upgrade.md have been eliminated.

2 years ago0029927: Coding Rules - eliminate GCC compiler warnings -Wmaybe-uninitialized in...
kgv [Wed, 4 Jul 2018 07:49:44 +0000 (10:49 +0300)]
0029927: Coding Rules - eliminate GCC compiler warnings -Wmaybe-uninitialized in BRepApprox

The code has been fixed to avoid taking a reference from a field of a temporary variable
(BRepApprox_ApproxLine::Point() returns non-reference structure).

2 years ago0029834: Coding Rules - eliminate GCC compiler warnings -Wformat-overflow in IGESData...
abv [Tue, 3 Jul 2018 21:54:46 +0000 (00:54 +0300)]
0029834: Coding Rules - eliminate GCC compiler warnings -Wformat-overflow in IGESData_IGESWriter

String buffers have been increased to be sufficient to accommodate result of sprintf() for any possible printed integer values.

2 years ago0029868: Draw Harness - help message for readstl command is unclear
kgv [Thu, 14 Jun 2018 15:45:58 +0000 (18:45 +0300)]
0029868: Draw Harness - help message for readstl command is unclear

readstl syntax has been modified, so that it creates a single-face triangulation by default.
The argument "trinagulation" is no more supported.
The new argument "-brep" has been introduced to generate
a compound of per-triangle faces instead (old default behavior of the command).

2 years ago0029909: Coding - GCC compiler warnings in Qt headers while building Samples in OCCT...
kgv [Tue, 3 Jul 2018 11:31:40 +0000 (14:31 +0300)]
0029909: Coding - GCC compiler warnings in Qt headers while building Samples in OCCT and Products on Debian80 64 bit

Standard_WarningsDisable.hxx has been extended by ignoring -Wunused-local-typedefs within GCC compiler.

2 years ago0029807: [Regression to 7.0.0] Impossible to cut cone from prism
nbv [Fri, 25 May 2018 08:05:58 +0000 (11:05 +0300)]
0029807: [Regression to 7.0.0] Impossible to cut cone from prism

The algorithm has been improved for the cases when the intersection line goes through the cone apex.


1. All special points are put to the ALine forcefully (if they are true intersection point). Currently this step has not been implemented yet.

2. Now the tolerance of IntPatch_Point (put into ALine) is computed in order to cover the distance between it and the correspond ALine.

3. Test cases have been created.

4. Procedure of trimming IntAna_Curve has been improved.

5. Criterion when the discriminant of IntAna_Curve can be considered to be equal to 0 has been improved.

6. Methods IntAna_Curve::FindParameter(...) (and IntPatch_ALine::FindParameter(...)) currently returns list of all parameters corresponding the given point (IntAna_Curve can be self-interfered curve). Before the fix, this method always returned only one (randomly chosen) parameter.

7. Interfaces of the following methods have been changed: IntAna_Curve::FindParameter(...), IntPatch_ALine::FindParameter(...), IntPatch_ALine::ChangeVertex(...), IntPatch_SpecialPoints::AddPointOnUorVIso(...), IntPatch_SpecialPoints::AddSingularPole(...), IntPatch_WLineTool::ExtendTwoWLines().

8. Following methods have been added: IntAna_Quadric::SpecialPoints(...), IntPatch_ALineToWLine::GetSectionRadius(...), IntPatch_SpecialPoints::ProcessSphere(...), IntPatch_SpecialPoints::ProcessCone(...), IntPatch_SpecialPoints::GetTangentToIntLineForCone(...).

1) tests/boolean/volumemaker/C5

They are real IMPROVEMENTS. In the FIX (in compare with MASTER), section result between pairs of faces f2&f6 (C5), f3&f7 (C6) and f1&f5 (E7) is closed. Separated test cases have been created in order to focus on the problem with section. Bug #28503 has been fixed.

Correction in test cases.

2 years ago0029925: Foundation Classes - add missing cast to LowerCase() and UpperCase() arguments
kgv [Mon, 2 Jul 2018 21:45:41 +0000 (00:45 +0300)]
0029925: Foundation Classes - add missing cast to LowerCase() and UpperCase() arguments

Argument of LowerCase() and UpperCase() is cast to int via unsigned char to avoid passing negative integer in the case if the argument char is in the extended part of ASCII table (which would result in undefined behavior according to C++ standard).

2 years ago0029924: Configuration - remove obsolete folders from .gitignore
abv [Mon, 2 Jul 2018 15:48:44 +0000 (18:48 +0300)]
0029924: Configuration - remove obsolete folders from .gitignore

Folders drv, sun, sil and ao1 have been removed from .gitignore

2 years ago0029857: Incorrect behavior of Point-Curve Extrema IR-2018-06-29
ifv [Tue, 26 Jun 2018 11:54:35 +0000 (14:54 +0300)]
0029857: Incorrect behavior of Point-Curve Extrema

Check for double solutions has been  added in algorithms Extrema_ELPCOfLocateExtPC and  Extrema_ELPCOfLocateExtPC2d
that find extrema between point and curve.

2 years ago0029894: Visualization - AIS_ColorScale ColorRange returns only min color
mnv [Tue, 26 Jun 2018 13:27:12 +0000 (16:27 +0300)]
0029894: Visualization - AIS_ColorScale ColorRange returns only min color

A typo in AIS_ColorScale::ColorRange function has been fixed.