anv [Thu, 8 Feb 2018 15:41:09 +0000 (18:41 +0300)]
0029097: Visualization - allow picking Graphic3d_TypeOfShadingModel per-object
Graphic3d_AspectFillArea3d has been extended by new property ::ShadingModel(),
which is set to Graphic3d_TOSM_DEFAULT by default.
The new API allows assigning Shading Model to specific Primitive Array groups
instead of entire Viewer, which was the only possibility before.
Graphic3d_TypeOfShadingModel has been extended with Graphic3d_TOSM_DEFAULT value
meaining that Shading Model defined as default for the Viewer should be used.
Graphic3d_TOSM_NONE has been renamed to Graphic3d_TOSM_UNLIT.
Documentation of Shading Models has been improved by more details.
V3d_TypeOfShadingModel enumeration has been merged into Graphic3d_TypeOfShadingModel
avoiding duplicated definitions and confusion.
Old values has been left for compatibility with old code and can be marked deprecated in future.
Draw Harness command vaspects has been extended by new argument -setShadingModel
for testing Shading Models assigned to entire objects.
OpenGl_SetOfShaderPrograms now holds an array of Shading Models.
OpenGl_ShaderManager interface has been modified and now requires enumeration as input
in several places where Boolean flags have been used previously
(methods ::BindFaceProgram(), ::BindLineProgram(), ::BindMarkerProgram()).
OpenGl_Workspace now defines default (undefined) OpenGl_AspectFace as Graphic3d_TOSM_UNLIT
to simplify indication of primitive groups with undefined Fill Area aspects,
and so that Graphic3d_TOSM_UNLIT set as default Shading Model will not make artifacts on Lines and Markers.
AIS_Manipulator::Axis::Compute() - added missing initialization of Fill Area aspects (leading to undefined behavior).
apn [Mon, 19 Feb 2018 09:24:55 +0000 (12:24 +0300)]
0029514: Configuration, CMake - OpenGL ES should be available for Linux
Allow optionally building OCCT with GLESv2 and EGL on Linux
kgv [Thu, 8 Feb 2018 13:16:45 +0000 (16:16 +0300)]
0029492: Coding Rules. NCollection_IndexedDataMap - add missing documentation to method ::Add()
apn [Fri, 16 Feb 2018 13:08:31 +0000 (16:08 +0300)]
0029513: Replace OCC logo in user guides
Replace OCC logo by occ_logo.png in higher quality
apn [Fri, 16 Feb 2018 11:54:14 +0000 (14:54 +0300)]
0027747: Incomplete section curves between faces
Added test case bugs/modalg_7/bug27747
nbv [Thu, 15 Feb 2018 11:38:59 +0000 (14:38 +0300)]
0029510: IntWalk_PWalking:: PutToBoundary(...) method results in appearing several coincident points in Walking-line
Places have been detected where coincident points are created. The problem has been fixed.
nbv [Thu, 8 Feb 2018 12:59:41 +0000 (15:59 +0300)]
0029494: Intersection line between two parametric surfaces is restricted incorrectly if it matches the surface boundary
Creation of IntPatch_Points is forbidden in tangent-zones exceptionally domain boundaries of intersected surface.
nbv [Thu, 8 Feb 2018 13:57:36 +0000 (16:57 +0300)]
0029496: No intersection curve between faces if starting points are given
Now, bounded IntPatch_Points are found in case when starting points are used in intersection algorithm. Before the fix, these points were not looked for (even).
kgv [Wed, 14 Feb 2018 19:58:34 +0000 (22:58 +0300)]
0029509: Visualization, TKOpenGl - Weighted OIT + MSAA shader compilation errors
Fix implicit cast ivec2->vec2 and specify GLSL version to "320 es" on appropriate devices.
kgv [Wed, 14 Feb 2018 17:18:39 +0000 (20:18 +0300)]
0029508: Visualization, TKOpenGl - visual artifacts on Adreno 305/308
OpenGl_ShaderManager now:
- prefers GLSL ES 100 over GLSL ES 300 on devices reporting OpenGL ES 3.0;
- prefers GLSL ES 300 on devices reporting OpenGL ES 3.1+.
to workaround known buggy implementations of OpenGL ES 3.0 drivers.
kgv [Wed, 14 Feb 2018 13:10:48 +0000 (16:10 +0300)]
0029507: Visualization, TKOpenGl - uninitialized class field OpenGl_FrameBuffer::myIsOwnDepth
kgv [Tue, 13 Feb 2018 21:07:48 +0000 (00:07 +0300)]
0029503: Visualization, TKOpenGl - fix access violation due to misprint in OpenGl_AspectMarker
Misprint mySprite->mySpriteA has been corrected.
apl [Mon, 27 Nov 2017 12:16:21 +0000 (15:16 +0300)]
0029337: Visualization, TKOpenGl - visual artifacts on Intel Broadwell GPU
Enable multiple draw buffers in shader program only if its required by specific application.
occSetFragColor() - a new GLSL function has been introduced
as an alternative to setting occFragColor/occFragCoverage variables.
emv [Tue, 13 Feb 2018 12:01:39 +0000 (15:01 +0300)]
0029502: Improve performance of the ShapeUpgrade_UnifySameDomain::UnifyEdges() method
Avoid repeated merging of the same chains of edges by processing all edges at once.
Test cases for the issue.
dipts [Sat, 10 Feb 2018 23:31:43 +0000 (00:31 +0100)]
0029500: Visualization - AIS_Point dynamic highlighting is not drawn on RedrawImmediate
ZLayer for Dynamic highlighting of AIS_Point has been set to Graphic3d_ZLayerId_Top
and of Selected highlighting to Graphic3d_ZLayerId_UNKNOWN,
to follow the behavior of normal AIS object.
dipts [Mon, 5 Feb 2018 21:11:42 +0000 (22:11 +0100)]
0029395: Visualization, V3d_View - Grid disappears forever after enabling RayTracing
Custom Graphic3d_Structure implementation has been added to V3d_RectangularGrid and V3d_CircularGrid to trigger recompute in case of device lost.
Primitive arrays are no more (re)computed while grid is not actually displayed.
kgv [Thu, 8 Feb 2018 06:30:39 +0000 (09:30 +0300)]
0029491: Visualization, AIS_Shape - filter unsupported Display Modes within ::AcceptDisplayMode()
AIS_Shape::AcceptDisplayMode() now accepts only modes 0,1 and 2.
AIS_ColoredShape::Compute() no more computes presentation for unknown display mode.
emv [Wed, 7 Feb 2018 11:31:43 +0000 (14:31 +0300)]
0029488: Regression: boolean operation " general fuse" creates solid containing 5 not connected shells lying on the one level.
Boolean Operations - when checking two faces with the same bounds on Same Domain, take into account possible deviation of the edges from the faces surfaces.
Test cases for the issue.
gka [Fri, 2 Feb 2018 09:32:46 +0000 (12:32 +0300)]
0029473: DRAW command "splitshape" produces invalid result on the cylindrical face.
Added taking into account distance between edges in the UV space for periodical surfaces in the LocOpe_SplitShape.cxx method ChoixUV
emv [Mon, 5 Feb 2018 12:10:32 +0000 (15:10 +0300)]
0029484: Avoid inheritance of the BRepAlgoAPI_Check from BRepBuilderAPI_MakeShape
Inherit BRepAlgoAPI_Check class from BOPAlgo_Options instead of BRepAlgoAPI_Algo, as the latter is too excessive for checking purposes.
Implementation of the Draw command "bopapicheck" for testing the BRepAlgoAPI_Check algorithm.
nbv [Mon, 11 Dec 2017 14:04:01 +0000 (17:04 +0300)]
0028886: infinite loop at intersecting two faces / surfaces
The reason of constantly increasing/decreasing steps has been eliminated for the problem case.
kgv [Fri, 2 Feb 2018 17:14:49 +0000 (20:14 +0300)]
0029477: Visualization, TKOpenGl - MSAA FBO initialization failure on OpenGL ES 3.2 device
OpenGl_View::myFboColorFormat now initialized using sized texture format GL_RGBA8
on mobile platforms (as in case of desktop platform).
emv [Thu, 1 Feb 2018 10:10:16 +0000 (13:10 +0300)]
0029465: Regression relation to 691 version: Extrema_ExtCC returns IsParallel equal to true for not parallel curves
Strengthening of the criteria of the parallel status of the curves by additional checking if the ends of the curves do not diverge.
Test cases for the issue.
kgv [Fri, 2 Feb 2018 13:21:47 +0000 (16:21 +0300)]
0029474: Visualization, TKOpenGl - GLSL compilation errors on buggy OpenGL ES driver for PowerVR SGX 544MP
OpenGl_ShaderProgram::Initialize() now defines THE_MAX_LIGHTS/THE_MAX_CLIP_PLANES
to zeros to workaround issues with some buggy OpenGL drivers.
emv [Tue, 26 Dec 2017 11:28:27 +0000 (14:28 +0300)]
0028599: Replacement of old Boolean operations with new ones in BRepProj_Projection algorithm
The usage of *BRepAlgo_Section* has been replaced with the usage of *BRepAlgoAPI_Section* in *BRepProj_Projection* algorithm.
The TODO statements have been removed from the failing test case in the "prj" grid as they are working correctly now.
The following changes have been made to improve the performance *BRepAlgoAPI_Section*:
1. Revision of the *IntPolyh_Intersection* class to avoid repeated calculation of the deflection of the same triangulation.
2. Small revision of the Edge/Face intersection algorithm to perform Extrema computation on the whole intersection range of the edge instead of discrete ranges.
3. Implementation of the extrema computation for the Circle and Sphere.
4. Correct computation of the parameter of the point on the Circle.
kgv [Mon, 29 Jan 2018 08:05:20 +0000 (11:05 +0300)]
0029069: Samples - handle UNICODE filenames within C++/CLI CSharp sample
msv [Tue, 30 Jan 2018 13:03:06 +0000 (16:03 +0300)]
0029463: Regression relation to 691 version: Method BndBox::IsOut() returns true for point lying on the planar face
Correct the method BRepBndLib::Add so that to enlarge the bounding box on the tolerance of edges which curves participate in calculation of the box.
aml [Sat, 27 Jan 2018 08:20:27 +0000 (11:20 +0300)]
0028176: Draw Harness - "reshape" command usage is not properly documented
Help message is corrected for "reshape" command. Command implementation is corrected according OCCT coding rules.
abv [Sun, 28 Jan 2018 16:49:43 +0000 (19:49 +0300)]
0029447: The constructor of Message_PrinterOStream mixes up cout and cerr
Use of cerr or cout is corrected in Message_PrinterOStream constructor
aml [Fri, 26 Jan 2018 06:35:19 +0000 (09:35 +0300)]
0029453: Draw Harness - unclear syntax of "add" command
Help message is corrected for "add" command.
abv [Sun, 24 Dec 2017 06:44:04 +0000 (09:44 +0300)]
0029399: Optimize reading of floating point values from text strings
Function Strtod() is reimplemented using open source (MIT-style license) code by David M. Gay instead of strtod() provided by standard run-time library. This improves its performance by 3-10 times.
Functions Atof(), Strtod(), Printf(), Sprintf(), Fprintf() are declared as extern "C" to be usable from C programs.
Strtod() is used in Interface_FileReaderData::Fastof() and in RWStl_Reader to accelerate their work.
DRAW command QATestAtof and test perf fclasses strtod are added to check correctness and performance of Strtod().
Test perf draw restore is added to monitor performance of reading BREP files.
Minor off-topic corrections:
- method Standard_GUID::Assign (const Standard_UUID&) is implemented (was empty);
- Precision.hxx is included in BRepMesh_Vertex.hxx that uses it.
abv [Wed, 10 Jan 2018 18:17:35 +0000 (21:17 +0300)]
0029399: Optimize reading of floating point values from text strings -- base dtoa.c
Fast implementation of strtod downloaded from www.netlib.org/fp/dtoa.c (base version) is integrated as Standard_Strtod.cxx.
msv [Thu, 25 Jan 2018 09:00:46 +0000 (12:00 +0300)]
0029448: The method Extrema_FuncExtCS::GetStateNumber mixes up parameter on curve with parameter U on surface
The code has been corrected to eliminate the mess.
nbv [Fri, 19 Jan 2018 15:07:06 +0000 (18:07 +0300)]
0028102: Problem cutting a plate with several holes (670)
Algorithm of processing cases when point of splitting Walking-line is near to the boundary of the intersection domain but does not match this boundary has been improved.
vro [Tue, 23 Jan 2018 11:06:18 +0000 (14:06 +0300)]
0029443: It is not possible to store an ExtStringArray Ocaf attribute to any previous version in XML file format
ika [Fri, 19 Jan 2018 10:36:30 +0000 (13:36 +0300)]
0029436: Data Exchange - Extend Expand compounds functionality.
Extend permissions for expand in ShapeTool
Fix processing of subshapes
Fix misprints
Add test cases
emv [Mon, 27 Nov 2017 12:52:55 +0000 (15:52 +0300)]
0028385: Improve drawing isolines (DBRep_IsoBuilder algorithm)
1. When computing the iso-lines for the face (*DBRep_IsoBuilder*) prepare the Hatching algorithm with the following elements:
a. Trimmed p-curves of edges. The trimming parameters are computed by intersection with p-curves of the neighboring edges. The trimming will be performed only if the intersection point is covered by the tolerance of common vertex.
b. 2D segments connecting the p-curves of the neighboring edges. These segments will close the 2D gaps, which are closed in 3D by the tolerance of vertices shared between edges. This will allow trimming correctly the iso-lines passing through such gaps.
2. Implementation of the additional Init() method for WireExplorer algorithm taking UV bounds of the face to avoid their repeated computation when work working with a face having multiple wires.
3. Test cases for the issue.
nbv [Tue, 16 Jan 2018 13:03:01 +0000 (16:03 +0300)]
0029430: [Regression] Curve evaluation at boundary point.
Before the fix, BRepAdaptor_CompCurve considered the input wire to be periodic with period LastParameter()-FirstParameter().
Now, method IsPeriodic will always return FALSE because it is impossible to obtain correspondence between the members of BRepAdaptor_CompCurve class and its periodicity status.
New behavior has been documented in upgrade-guide.
msv [Mon, 11 Dec 2017 15:00:19 +0000 (18:00 +0300)]
0029368: Incorrect intersection state of the intersection point of two 2d curves
In the algorithm math_FunctionRoots, improve the case when it is needed to find the extremum of the function. Earlier, to solve this task the method of gold section was used. With the patch, firstly the algorithm tries to find zero value of the derivative function. In most cases it gives precise result. Secondly, the algorithm tries to find zero value of the function using the old approach. The algorithm chooses the best solution among two computed by different methods.
In the method PutStickPavesOnCurve of BOPAlgo_PaveFiller, forbid putting a vertex to the end of the curve if this end already has a vertex assigned to it. This allows getting rid of unwanted colliding of vertices.
In the method UpdatePaveBlocks of BOPAlgo_PaveFiller, make the check for micro edges more precise.
New category of tests "lowalgos" has been added. Tests for low level algorithms are to be put there. "2dinter" is a new group of tests in this category.
Introduction of the new key for "2dintersect" command, allowing printing the intersection state for each point.
It has the following syntax now:
"2dintersect curve1 [curve2] [-tol tol] [-state]"
Options:
-tol - allows changing the intersection tolerance (default value is 1.e-3);
-state - allows printing the intersection state for each point.
Correct the test case bugs/modalg_7/bug28274 to make proper checks of the result.
szy [Thu, 28 Dec 2017 13:53:41 +0000 (16:53 +0300)]
0029385: OCAF - TDataStd_IntPackedMap lacks interface to set map as TColStd_PackedMapOfInteger
Added method ChangeMap (const TColStd_PackedMapOfInteger& theMap).
abv [Thu, 11 Jan 2018 20:23:09 +0000 (23:23 +0300)]
0029422: OCAF, old persistence - wrong implementation of writing a reference
msv [Fri, 29 Dec 2017 14:44:42 +0000 (17:44 +0300)]
0028211: Modeling Algorithms - Boolean fuse operation produces incorrect result
Correct procedure of initialization of BRepTopAdaptor_FClass2d and IntTools_FClass2d classifiers so as to produce more tight polygon in the case of self-intersections on very thin faces.
The idea is concluded in checking the condition:
defl < 2 * S / P, where S - is the surface area computed on produced polygon, P - its perimeter, defl - deflection computed on it.
If the condition is not true the polygon is discretized again using QuasiUniformDeflection tool.
kgv [Fri, 12 Jan 2018 07:36:18 +0000 (10:36 +0300)]
0029419: Make V3d_Viewer::PrivilegedPlane() return const reference rather than a temp object
isn [Mon, 11 Sep 2017 13:53:31 +0000 (16:53 +0300)]
0028681: UnifySameDomain distorts face boundary when merges a chain of small linear edges
In case of sequence of edges based on lines (which are going to be unified into one line-segment), take into account a linear tolerance value.
Get rid of regressions.
Updates of USD-tests.
abv [Tue, 2 Jan 2018 11:03:16 +0000 (14:03 +0300)]
0029409: Configuration, macOS - "Appkit" is spelled in CMake scripts using wrong case for "K"
Spelling error is corrected in name of AppKit library in CMake and genproj scripts for macOS
ifv [Fri, 15 Dec 2017 07:23:29 +0000 (10:23 +0300)]
0028499: Checkshape incorrectly reports BRepCheck_NotClosed when gap is covered by vertex tolerance
Calculation of 2d tolerance is improved
szy [Wed, 27 Dec 2017 14:28:54 +0000 (17:28 +0300)]
0029402: In OCCT7.2.1-dev the names written into a FSD_File are associated with the wrong shapes.
The issue of incorrect Roots indexing is fixed by changing DataMap to IndexedDataMap.
Draw command fsdread was improved to allow restoring of shapes with kept names.
ika [Tue, 26 Dec 2017 10:46:08 +0000 (13:46 +0300)]
0029403: Data Exchange - subshapes names are not imported from step
Fix processing of subshape names in STEP in reading and writing.
Replace creating subshapes in Document as tree (invalid) with plain subshapes structure.
Update test cases.
msv [Tue, 26 Dec 2017 09:14:32 +0000 (12:14 +0300)]
0029358: Unifysamedomain is unable to merge faces with the same underlying surface
The documentation has been updated to avoid misunderstanding of algorithm behavior.
emv [Thu, 21 Dec 2017 14:24:28 +0000 (17:24 +0300)]
0029387: Incorrect result of cut a face with several shapes
Remove section edges having no valid range.
Test case for the issue.
szy [Wed, 20 Dec 2017 09:20:29 +0000 (12:20 +0300)]
0029371: The problem of the attributes constructor call
Default Guid is assigned in constructor.
Add test case: tests\bugs\caf\bug29371.
skl [Thu, 21 Dec 2017 08:15:10 +0000 (11:15 +0300)]
0029391: Invalid import of TrimmedSurface
Fix and test for bug 29391.
msv [Mon, 25 Dec 2017 10:03:00 +0000 (13:03 +0300)]
0029380: Delete "checknbshapes" from bugs/modalg_6/bug27341* test cases
emv [Mon, 25 Dec 2017 08:47:53 +0000 (11:47 +0300)]
0029400: Fuse of two edges creates self-interfered shape
Avoid creation of the edges with too small valid range (not allowing to split the edge) and interfering vertices.
Test case for the issue.
ski [Thu, 21 Dec 2017 12:37:53 +0000 (15:37 +0300)]
0029396: Configuration, Cmake: restore 3rd-party libraries into INTERFACE_LINK_LIBRARIES property of installed OCCT targets
Changes from branch CR29277 were reverted.
bugmaster [Fri, 22 Dec 2017 07:31:15 +0000 (10:31 +0300)]
0029398: Configuration - list lex and yacc files in the StepFile/FILES to avoid CMake warnings
Adding step.lex and step.yacc to StepFile/FILES
szy [Wed, 13 Dec 2017 12:27:50 +0000 (15:27 +0300)]
0029220: Application Framework - replace CDM_MessageDriver interface by Message_Messenger.
anv [Tue, 28 Nov 2017 09:31:08 +0000 (12:31 +0300)]
0029352: Adding support of GBK and Big5 code pages
Added methods to convert GBK and Big5 encodings to Unicode
msv [Tue, 19 Dec 2017 13:01:06 +0000 (16:01 +0300)]
0028248: [Regression] HLR Algo result is retrieved from the last added shape only
Mistakes in retrieving of HLRBRep_EdgeData by value instead of reference have been corrected.
kgv [Tue, 19 Dec 2017 11:00:10 +0000 (14:00 +0300)]
0029393: Samples - AndroidQt sample build fail
AndroidQt - dropped removed arguments within V3d_View::SetWindow() usage [
0024776].
AndroidQt_Window - add missing NativeFBConfig() method declared in the interface [
0026732].
ifv [Mon, 4 Dec 2017 13:20:19 +0000 (16:20 +0300)]
0028722: Conversion of a spherical face to a spline produces an invalid shape
Correction of 2d tolerance calculation for BSpline/Bezier surfaces
Test cases are corrected according to current behavior of algorithm
ika [Mon, 4 Dec 2017 08:05:02 +0000 (11:05 +0300)]
0029362: Data Exchange - Crash during reading step file
Additional check for wires into searching of attached shapes,
Fix Dimension value processing,
kgv [Fri, 8 Dec 2017 12:13:14 +0000 (15:13 +0300)]
0029377: Configuration, CMake - linkage errors while using static OCCT libraries on Windows platform
HAVE_NO_DLL is now defined when building Static libraries.
kgv [Thu, 7 Dec 2017 17:58:36 +0000 (20:58 +0300)]
0029376: Coding Rules, TColStd_PackedMapOfInteger - declare Iterator as nested class of map collection
emv [Tue, 12 Dec 2017 12:10:37 +0000 (15:10 +0300)]
0029363: No history for shapes which were produced as a result of intersection
1. Implementation of the *Generated* method for the algorithms in Boolean Component.
In terms of these algorithms the shape from the arguments can have Generated shapes only if these new shapes have been obtained as a result of pure intersection (not overlapping) of this shape with any other shapes from arguments.
Thus, the Generated shapes are always:
* VERTICES created from the intersection points and may be Generated from edges and faces only;
* EDGES created from the intersection edges and may be Generated from faces only.
So, only EDGES and FACES could have information about Generated shapes. For all other types of shapes the list of Generated shapes will be empty.
2. Optimization and simplification of the Modified and IsDeleted methods based on the correct filling of the BOPAlgo_BuilderShape::myImagesResult map.
3. Provide history of unification of the solids in the CellsBuilder algorithm.
4. Update of the documentation of Boolean Operations User guide with new chapter "History Information" describing rules for filling history for operations in Boolean Component.
5. Test cases for the issue. New grid "history" has been added into "boolean" category.
nbv [Thu, 7 Dec 2017 08:28:20 +0000 (11:28 +0300)]
0029179: Result of Boolean common depends on an order of arguments
Usage of Bnd_Box-filtering is eliminated while putting a (definitely) common vertex between two faces on the intersection curve.
Algorithm of putting not-common (ON/IN) vertices has not been changed.
nbv [Thu, 30 Nov 2017 10:44:48 +0000 (13:44 +0300)]
0029359: Approximation algorithm computes multidimensional distance in Euclidean space incorrectly
Wrong distance computation has been corrected.
Some test-cases have been corrected according to their new behavior. Namely, built (by approximation algorithm) curve(s) has changed its geometrical position.
1. tests/blend/simple/X4
It is not a regression because the result is not correct on both MASTER and FIX (see explanation in the issue #26740). This problem is expected to be solved after porting Fillet-algorithm to new Boolean operation. Old Boolean operations do not cover Edge-Edge tangent-zone by vertex.
2. tests/bugs/modalg_6/bug27341_318
"checknbshapes" has been deleted in order to avoid non-stable behavior (see issue #29360) of this test case. New result is OK on both Linux and Windows platform.
emv [Tue, 5 Dec 2017 11:22:22 +0000 (14:22 +0300)]
0029351: Boolean Operations create invalid pcurves
When making pcurve for edge on face make sure that the produced 2D curve will have the same range as 3D curve of the edge.
vro [Wed, 19 Aug 2015 07:25:11 +0000 (10:25 +0300)]
0026570: Crash on attempt to rotate a shape.
An extended draw-command trotate (ttranslate, tmirror, ...) by an additional parameter "-copy".
New check of edge range is added in BRepCheck/BRepCheck_Edge.cxx
The same checking is added in ShapeAnalysis_Edge.cxx
Fixing this problem is added in ShapeFix_Wire.cxx
GeomLib::SameRange(...) and BRepTools_TrsfModification::NewCurve2d(...) are modified to avoid exception in TrimmedCurve
abv [Sat, 2 Dec 2017 08:24:58 +0000 (11:24 +0300)]
0029355: OCCT 6.9.1 persistence restored in OCCT 7.2.0 not working
Auxiliary classes StdObjMgt_ReadData::Object and StdObjMgt_WriteData::Object are renamed to "ObjectSentry" (to better reflect their nature); constructor is made explicit to ensure that such objects are always created intentionally.
These objects are instantiated explicitly in the body of relevant functions, instead of implicit creation as temporary objects when function requires such object as argument.
Variable used to get char from stream is nullified in several places in FSD_File and other classes, to avoid possible usage of uninitialized memory in case if stream is bad.
kgv [Thu, 7 Dec 2017 07:57:26 +0000 (10:57 +0300)]
0029372: Graphic3d_TransformPers - improve description of Local Coordinate system defined by Transformation Persistence
kgv [Mon, 4 Dec 2017 12:16:34 +0000 (15:16 +0300)]
0029365: Visualization, TKOpenGl - do not include hidden structures to Rendered within frame statistics
OpenGl_Layer::UpdateCulling() now considers structure as culled in case if it has Hidden state.
emv [Wed, 1 Nov 2017 08:30:30 +0000 (11:30 +0300)]
0029312: Using OBB to speed up Boolean Operations
1. Implementation of the user-defined option for usage of Oriented Bounding Boxes (OBB) in Boolean Operations for additional filtering (rejection) of selected for intersection pairs of sub-shapes.
By default the usage of OBB is turned off.
To enable/disable its usage the method SetUseOBB(flag) should be used. This method is available for all operations in Boolean Component.
To enable/disable it in draw the command "buseobb 0/1" should be used. Note, that this will affect all subsequent operations.
The OBB for the shapes are built by first necessity and stored into operation context (IntTools_Context).
2. Usage of the OBB in some test cases.
nbv [Wed, 8 Nov 2017 12:47:09 +0000 (15:47 +0300)]
0029311: Implementation of the Oriented Bounding Boxes (OBB) functionality
1. The class Bnd_OBB has been created to describe the Oriented Bounding Box.
2. Several key methods have been implemented: Bnd_OBB::IsOut(...), Bnd_OBB::Add(...) and Bnd_OBB::Enlarge(...).
3. Interface of Bnd_Box class has changed. New methods have been created. See Bnd_Box.hxx for detailed information.
4. BRepBndLib and Draw_Box classes have been amended in order to provide correct work with Bnd_OBB class.
5. Interface of "bounding" DRAW-command has been changed. Please see help for detailed information.
6. New DRAW-command "isbbinterf" has been created. Please see help for detailed information.
7. "boundingstr" and "optbounding" DRAW-commands have been eliminated because their function can be made by "bounding" DRAW-command (e.g. see tests/bugs/vis/buc60857 or samples/tcl/snowflake.tcl test cases).
8. Documentation has been updated.
kgv [Mon, 4 Dec 2017 13:29:43 +0000 (16:29 +0300)]
0029366: Visualization, OpenGl_Text - artifacts when using Aspect_TODT_SHADOW/Aspect_TODT_DEKALE at different zoom level
OpenGl_Text now applies Polygon Offset instead of Z-shift in world coordinates for drawing background.
OpenGl_Context::SetPolygonOffset() - polygon offset state has been moved from OpenGl_Workspace to OpenGl_Context.
nbv [Mon, 13 Nov 2017 10:55:48 +0000 (13:55 +0300)]
0029323: Intersection algorithm produces the curve with oscillation
Sometimes the algorithm of purging of extra points in the walking line makes enormous difference in distance between two neighbor segments of the line. This badly impacts the quality of approximation result. This patch balances the difference in distances by forbidding deletion of some points.
1. tests/bugs/modalg_6/bug27615
The reason of the correction is explained in the message ~
0072580 (see issue #28557).
2. tests/bugs/modalg_7/bug28892*
tests/bugs/modalg_7/bug28984
The reason of the correction is explained in the message ~
0072583 (see issue #28984).
kgv [Fri, 24 Nov 2017 15:37:01 +0000 (18:37 +0300)]
0029344: Foundation Classes, TCollection_AsciiString - replace confusing strncpy with memcpy
strncpy() usage within TCollection_AsciiString has been replaced by memcpy()
where string length has been already determined.
TCollection_AsciiString::SetValue() now throws exception
on attempt to set '\0' - TCollection_AsciiString::Trunc() should be used instead.
TCollection_AsciiString(const char* , int ) has been modified to properly set string length
in case of NULL-terminator appeared earlier then specified length.
Interface_LineBuffer has been revised for using NCollection_Array1 instead of TCollection_AsciiString
to avoid misusing TCollection_AsciiString interface.
kgv [Fri, 24 Nov 2017 15:43:01 +0000 (18:43 +0300)]
0029346: Visualization, TKOpenGl - collect frame statistics
Graphic3d_RenderingParams::ToShowStats - new option displaying rendering statistics.
OpenGl_FrameStats - new class for accumulating frame statistics.
OpenGl_Context::FrameStats() provides an access to the frame stats
used for currently rendered context.
OpenGl_View::Redraw() and OpenGl_View::RedrawImmediate()
resets counters within OpenGl_Context::FrameStats().
OpenGl_Layer::UpdateCulling() - simplified resetting of culling state for cullable structures.
vro [Wed, 29 Nov 2017 13:36:21 +0000 (16:36 +0300)]
0029353: Optimization of TPrsStd_AISPresentation::SetSelectionMode()
kgv [Thu, 2 Nov 2017 12:36:20 +0000 (15:36 +0300)]
0029290: Visualization, TKOpenGl - allow defining Light source per ZLayer
Graphic3d_CLight is now defined as a class inheriting Standard_Transient,
so that it's fields now should be accessed through methods.
Graphic3d_CLight::IsEnabled() - new property allowing to disable light source everywhere.
Confusing alias OpenGl_Light has been removed.
Graphic3d_CLight::SetAttenuation() - the upper limit 1.0 of attenuation factors has been removed
since it contradicts to OpenGL specs and does not make sense.
Graphic3d_ZLayerSettings::Lights() - light sources list is now property of ZLayer.
When defined, it overrides light sources defined for View/Viewer.
New class Graphic3d_LightSet has been defined to define a set of light sources.
V3d_Light - removed obsolete interface for debug drawing lights sources.
V3d_Light is now an alias to Graphic3d_CLight.
V3d_TypeOfLight is now defined as a typedef to Graphic3d_TypeOfLightSource.
kgv [Tue, 28 Nov 2017 06:46:42 +0000 (09:46 +0300)]
0029350: Visualization, OpenGl_Text - add Aspect_TODT_SHADOW text style
Within new style Aspect_TODT_SHADOW, a tiny shadow is drawn at right-bottom corner
with one pixel shift, producing a slightly nicer visual look than Aspect_TODT_DEKALE.
kgv [Thu, 16 Nov 2017 19:57:48 +0000 (22:57 +0300)]
0029331: Visualization, TKOpenGl - make OpenGl_PrimitiveArray::IsFillDrawMode() as virtual method of OpenGl_Element
kgv [Tue, 31 Jan 2017 08:26:48 +0000 (11:26 +0300)]
0028416: Visualization - SelectMgr_SelectionManager::Activate() should not implicitly deactivate Global Selection Mode
Implicit deactivation of global selection mode has been removed from SelectMgr_SelectionManager::Activate().
Added new method AIS_InteractiveContext::SetSelectionModeActive() as replacement
of AIS_InteractiveContext::Activate() / ::Deactivate().
New method takes an argument AIS_SelectionModesConcurrency which defines
what to do with already activated selection modes in 3 ways:
- AIS_SelectionModesConcurrency_Single, only one selection mode can be activated at
the same moment - previously activated should be deactivated
- AIS_SelectionModesConcurrency_GlobalOrLocal, either Global (AIS_InteractiveObject::GlobalSelectionMode()
or Local (multiple) selection modes can be active at the same moment
- AIS_SelectionModesConcurrency_Multiple, any combination of selection modes can be activated.
emv [Fri, 17 Nov 2017 13:27:36 +0000 (16:27 +0300)]
0029333: Boolean Operations - Prevent modification of the input shapes in case their sub-shapes have not been modified
Prevent modification of the input shapes in destructive mode in case their sub-shapes have not been modified:
1. Prevent edge splitting for the pave blocks with old vertices if it is possible to use the existing edge (*BOPAlgo_PaveFiller::MakeSplitEdges*);
2. Prevent creation of the new containers (WIRES/SHELLS/COMPSOLIDS) if non of its parts have been modified (*BOPAlgo_Builder::FillImagesContainer*);
3. Prevent creation of the new face if non of its wires have been modified (*BOPAlgo_Builder::FillImagesFaces*);
4. If possible, use the original face to be the representative for the group of SD faces (*BOPAlgo_Builder::FillSameDomainFaces*).
Cosmetic changes:
1. Documentation of the *BOPAlgo_Builder* class.
2. Making simple methods of the *BOPAlgo_Builder* class inline.
3. Getting rid of the *BOPAlgo_Builder::mySplits* field as it is excessive. *BOPAlgo_Builder::myImages* can be used instead.
3. Moving the Check Inverted option from *BOPAlgo_Options* to *BOPAlgo_Builder*.
Test cases for the issue.
Adjustment of the test case to their current behavior.
Test case *blend/complex/H2* has been deleted as duplicate of the test case *blend/simple/Z1*.
emv [Thu, 23 Nov 2017 07:57:25 +0000 (10:57 +0300)]
0025609: Clean up the duplicate classes in TKBO project
1. The package BOPCol has been fully removed:
- *BOPCol_BaseAllocator* is replaced with *Handle(NCollection_BaseAllocator)*;
- *BOPCol_BoxBndTree* is replaced with *BOPTools_BoxBndTree*;
- *BOPCol_Box2DBndTree* is removed as unused;
- *BOPCol_DataMapOfIntegerInteger* is replaced with *TColStd_DataMapOfIntegerInteger*;
- *BOPCol_DataMapOfIntegerListOfInteger* is replaced with *TColStd_DataMapOfIntegerListOfInteger*;
- *BOPCol_DataMapOfIntegerListOfShape* is replaced with *TopTools_DataMapOfIntegerListOfShape*;
- *BOPCol_DataMapOfIntegerMapOfInteger.hxx* is removed as unused;
- *BOPCol_DataMapOfIntegerReal* is replaced with *TColStd_DataMapOfIntegerReal*;
- *BOPCol_DataMapOfIntegerShape* is replaced with *TopTools_DataMapOfIntegerShape*;
- *BOPCol_DataMapOfShapeBox* is replaced with *TopTools_DataMapOfShapeBox*;
- *BOPCol_DataMapOfShapeInteger* is replaced with *TopTools_DataMapOfShapeInteger*;
- *BOPCol_DataMapOfShapeListOfShape* is replaced with *TopTools_DataMapOfShapeListOfShape*;
- *BOPCol_DataMapOfShapeReal* is replaced with *TopTools_DataMapOfShapeReal*;
- *BOPCol_DataMapOfShapeShape* is replaced with *TopTools_DataMapOfShapeShape*;
- *BOPCol_DataMapOfTransientAddress* is removed as unused;
- *BOPCol_IndexedDataMapOfIntegerListOfInteger* is removed as unused;
- *BOPCol_IndexedDataMapOfShapeBox* is removed as unused;
- *BOPCol_IndexedDataMapOfShapeInteger* is removed as unused;
- *BOPCol_IndexedDataMapOfShapeListOfShape* is replaced with *TopTools_IndexedDataMapOfShapeListOfShape*;
- *BOPCol_IndexedDataMapOfShapeReal* is removed as unused;
- *BOPCol_IndexedDataMapOfShapeShape* is replaced with *TopTools_IndexedDataMapOfShapeShape*;
- *BOPCol_IndexedMapOfInteger* is replaced with *TColStd_IndexedMapOfInteger*;
- *BOPCol_IndexedMapOfOrientedShape* is replaced with *TopTools_IndexedMapOfOrientedShape*;
- *BOPCol_IndexedMapOfShape* is replaced with *TopTools_IndexedMapOfShape*;
- *BOPCol_ListOfInteger* is replaced with *TColStd_ListOfInteger*;
- *BOPCol_ListOfListOfShape* is replaced with *TopTools_ListOfListOfShape*;
- *BOPCol_ListOfShape* is replaced with *TopTools_ListOfShape*;
- *BOPCol_MapOfInteger* is replaced with *TColStd_MapOfInteger*;
- *BOPCol_MapOfOrientedShape* is replaced with *TopTools_MapOfOrientedShape*;
- *BOPCol_MapOfShape* is replaced with *TopTools_MapOfShape*;
- *BOPCol_PListOfInteger* is removed as unused;
- *BOPCol_PInteger* is removed as unused
- *BOPCol_SequenceOfPnt2d* is replaced with *TColgp_SequenceOfPnt2d*;
- *BOPCol_SequenceOfReal* is replaced with *TColStd_SequenceOfReal*;
- *BOPCol_SequenceOfShape* is replaced with *TopTools_SequenceOfShape*;
- *BOPCol_Parallel* is replaced with *BOPTools_Parallel*;
- *BOPCol_NCVector* is replaced with *NCollection_Vector*;
2. The class *BOPDS_PassKey* and containers for it have been removed as unused;
3. The unused containers from *IntTools* package have been removed:
- *IntTools_DataMapOfShapeAddress* is removed as unused;
- *IntTools_IndexedDataMapOfTransientAddress* is removed as unused;
4. The container *BiTgte_DataMapOfShapeBox* is replaced with *TopTools_DataMapOfShapeBox*;
5. The class *BOPTools* has been removed as duplicate of the class *TopExp*;
kgv [Tue, 28 Nov 2017 05:42:40 +0000 (08:42 +0300)]
0029349: Foundation Classes, OSD_Timer - add missing theThisThreadOnly constructor option available in OSD_Chronometer
OSD_Timer constructor now has theThisThreadOnly option passed to OSD_Chronometer,
which is FALSE by default.
OSD_Chronometer now provides methods ::UserTimeCPU(), ::SystemTimeCPU() allowing
to fetch CPU times without akward syntax through overloaded ::Show().
ifv [Thu, 9 Nov 2017 14:20:10 +0000 (17:20 +0300)]
0029289: Wrong derivatives in math_TrigonometricFunctionRoots.cxx file
Class MyTrigoFunction is removed from file math_TrigonometricFunctionRoots.cxx.
New class math_TrigonometricEquationFunction with the same functionality is created to provide possibilities
for individual testing.
Expressions for derivatives are corrected.
New Draw command "intconcon" for intersection 2d conic curves is created.
Test command OCC29289 (file QABugs_20.cxx) is created for individual testing math_TrigonometricEquationFunction.
It is used in tests/bugs/modalg_7/bug29289
ika [Thu, 23 Nov 2017 09:40:59 +0000 (12:40 +0300)]
0029338: Data Exchange - Add Planes for Tolerance zones in Geometric tolerances
Add new poles to Geometric Tolerance objects
Some code refactoring in GDT attributes
Add Draw functions for affected plane
mkv [Thu, 26 Oct 2017 08:59:25 +0000 (11:59 +0300)]
Update of tests database
Test for
0023171: Got wrong result after stitching
Test for
0023612: BRepPrimAPI_MakeTorus
Test for
0023610: checkshape command does not detect mismatch of the tolerance values among the sub-shapes of the shape
Test for
0023660: 'bsection' produces result with gap
Test for
0024397: BRepBuilderAPI_Copy works not correct
Test for
0023927: BRepProj_Projection produces Edge with one Vertex outside from curve
Test for
0023902: Cannot build fillet
Test for
0023669: Error in Boolean operations algorithm: section between cylindrical face and prism is incomplete
Test for
0023660: 'bsection' produces result with gap
Test for
0024100: Bad pcurve is built on a face while converting the shape from STEP format.
Test for
0024319: Sewing makes a solid transparent
Test for
0024302: Section operation modifies input argument
Test for
0024397: BRepBuilderAPI_Copy works not correct
Test for
0024418: Wrong section curves when intersecting analytical surfaces
szy [Mon, 20 Nov 2017 14:31:15 +0000 (17:31 +0300)]
0029142: Exception on Redo.
Order of attributes deltas is fixed.
emv [Wed, 22 Nov 2017 13:29:40 +0000 (16:29 +0300)]
0029175: BRepOffsetAPI_MakeOffset problem
The problem is fixed by the fix for the issue #29162.
Creating test case for the issue.
emv [Mon, 13 Nov 2017 13:03:31 +0000 (16:03 +0300)]
0029321: Improve performance of the 3D offset algorithm for the planar cases
Disable additional intersection of the splits of offset faces implemented in method BRepOffset_MakeOffset::Intersection3D() for the mode "Complete" and join type "Intersection".
This method is insufficient, as it does not allow to detect the tangential faces, necessary for this mode.
Intersection is performed in the method BuildShellsCompleteInter() developed for this mode.
emv [Mon, 13 Nov 2017 08:11:27 +0000 (11:11 +0300)]
0029322: Unify faces classification procedures in Boolean Operations
1. Unify the faces classification procedure of the methods BOPAlgo_BuilderSolid::PerformInternalShapes() and BOPAlgo_Builder::FillIn3DParts() using the latter as a base.
The new method BOPAlgo_Tools::ClassifyFaces() has been created for that. Both methods mentioned above have been updated to use the new one.
2. Forced intersection of the edges after enlarge of the tolerance values of their vertices during the operation has been added into BOP's intersection algorithm (BOPAlgo_PaveFiller).
BOPAlgo_Tools::PerformCommonBlocks() method has been updated to avoid loosing faces of the already created Common blocks.
As a result the case "boolean gdml_private ZF6" became more stable, because the intermediate result is no longer invalid.
Additional test cases have been added to verify this improvement (bugs modalg_7 bug29322_*)
3. When building PCurves for edges on faces, check the existing PCurves on its validity for periodic surfaces and adjust PCurves if necessary.
The improvement helps to produce the valid result in the test case "bugs moddata_1 bug152".
4. Avoid creation of empty Edge-Edge interference if the intersection point is lying close to a shared vertex.
The improvement helps obtain the valid result of the "bopcheck" operation in the test case "bugs modalg_7 bug27683".
Adjustment of the test case to current behavior:
- Avoid usage of the self-intersecting torus in the test case "boolean gdml_public A9".
- Fix the input shape in the test case "boolean bopfuse_complex H1" to provide valid result.
- Test cases "bugs moddata_1 bug152_1 bug152_2" have been unified into single test case "bugs moddata_1 bug152". Now, the case rebuilds invalid input data and performs all types of Boolean operations.
- Change the test case "bugs modalg_7 bug22750" to produce valid intermediate results used in subsequent operations as arguments.
- The following test cases are improvements:
- "boolean volumemaker D8"
- "boolean volumemaker G1"
- "bugs modalg_7 bug27683"
aml [Fri, 10 Nov 2017 15:21:21 +0000 (18:21 +0300)]
0025879: result of blend fails the bopcheck
Protection from the zero-length gp_Dir construction is added.
abv [Fri, 15 Sep 2017 07:52:14 +0000 (10:52 +0300)]
0029113: Coding Rules - fix convention to have one header per API type
Paragraph on naming of classes is revised to describe correspondence of names of public types and files.
msv [Fri, 20 Oct 2017 15:59:01 +0000 (18:59 +0300)]
0029234: BRepOffsetAPI_NormalProjection produces INTERNAL edges and vertices
Make the algorithm BRepOffsetAPI_NormalProjection use section operation instead of common to get the edge-result of projection to be in face restrictions.
Correct Boolean operation algorithm to produce correctly oriented result in the case of common between face and edge.
The algorithm ShapeUpgrade_UnifySameDomain has been patched to correctly gather same domain faces in a compound.
The TCL script snowflake.tcl has been corrected to get rid of dependence on the order of edges in the result of Boolean operation.
kgv [Tue, 14 Nov 2017 08:38:31 +0000 (11:38 +0300)]
0029317: Configuration, CMake - CSF_d3d9 should be processed for building TKD3DHost using MinGW
msv [Wed, 8 Nov 2017 15:13:47 +0000 (18:13 +0300)]
0029287: Move package GProp from TKG2d to TKG3d
jgv [Wed, 18 Oct 2017 14:35:58 +0000 (17:35 +0300)]
0029204: BRepOffsetAPI_MakePipeShell produces invalid result and raises exception in Draw
1.The algorithm searching the section in the corner (ChooseSection) is modified to be able to find simple cases with rather big tolerance.
2. The constructor of BRepFill_Section is modified: now it removes locations in the shape of section like it was done in BRepFill_Pipe.
3. Correction of U-edges by Same Parameter has been added to the method BRepFill_Sweep::Build.
aml [Sat, 11 Nov 2017 07:33:45 +0000 (10:33 +0300)]
0025968: boolean returning an invalid shape
Problem is not reproduced on current master.
Testing case was created