5 years ago0027591: TKViewerTest, ViewerTest_CmdParser regression - methods ArgVec3f, ArgVec3d...
apl [Fri, 10 Jun 2016 13:35:00 +0000 (16:35 +0300)]
0027591: TKViewerTest, ViewerTest_CmdParser regression - methods ArgVec3f, ArgVec3d return inccorect values

Fix regression in methods ViewerTest_CmdParser::ArgVec3f, ::ArgVec3d, ::ArgVec, ::ArgPnt.

5 years ago0027391: BRepLib::EnsureNormalConsistency() raises exception in case of asynchronious...
isn [Thu, 9 Jun 2016 14:30:26 +0000 (17:30 +0300)]
0027391: BRepLib::EnsureNormalConsistency() raises exception in case of asynchronious PolygonOnTriangulation problem

additional check have been added to BRepLib::EnsureNormalConsistency() func.
Any edges with two adjacent faces will be skipped (while updating of their normals) if the number of discretization points (nodes) will be different for each of this faces on this edge.

test case

5 years ago0027602: gp_TrsfForm.hxx - wrong comment to enum
abv [Tue, 14 Jun 2016 12:05:10 +0000 (15:05 +0300)]
0027602: gp_TrsfForm.hxx - wrong comment to enum

Comment is corrected

5 years ago0027599: Test "demo samples snowflake" does not clear internal data after execution
abv [Tue, 14 Jun 2016 12:09:01 +0000 (15:09 +0300)]
0027599: Test "demo samples snowflake" does not clear internal data after execution

Useless save command is removed

5 years ago0027569: [Regression in 6.9.0] Projecting a curve hangs
aml [Thu, 9 Jun 2016 11:38:04 +0000 (14:38 +0300)]
0027569: [Regression in 6.9.0] Projecting a curve hangs

Parameterization speed is taken into account to avoid ProjLib projector usage in case of bad input data.
Test case is added.
Test cases correction.

5 years ago0027329: Export to STEP failure
ika [Thu, 9 Jun 2016 13:48:53 +0000 (16:48 +0300)]
0027329: Export to STEP failure

Do ProcessShape for non-manifold too,
Add binding of already written shared faces to STEP entity for non-manifold.

Minor correction of test case bugs/step/bug27329

5 years ago0027592: TKV3d, AIS_RubberBand - SWIG error for method void virtual ComputeSelection
apl [Fri, 10 Jun 2016 12:36:19 +0000 (15:36 +0300)]
0027592: TKV3d, AIS_RubberBand - SWIG error for method void virtual ComputeSelection

Commit modifies "AIS_RubberBand.hxx" header file.
- Adds declaration of handle.
- Puts virtual & void modifiers of ComputeSelection method in common order.

5 years ago0027581: Logical error in Bnd_Box(2d)::SquareExtent() method.
nbv [Wed, 8 Jun 2016 14:42:18 +0000 (17:42 +0300)]
0027581: Logical error in Bnd_Box(2d)::SquareExtent() method.

Code in method SquareExtent has been corrected.

5 years ago0027579: Visualization, TKOpenGl - skip FSAA flag within Path Tracing
isk [Wed, 8 Jun 2016 11:33:49 +0000 (14:33 +0300)]
0027579: Visualization, TKOpenGl - skip FSAA flag within Path Tracing

5 years ago0027557: Unstable HLR tests
jgv [Mon, 6 Jun 2016 15:58:40 +0000 (18:58 +0300)]
0027557: Unstable HLR tests

The following modifications were done for stability:
- Precision::PConfusion() was set as parameter of Classifier instead of 0.0
- Coinciding vertices of outlines are united to exclude neighborhood of common vertex from curve-curve intersection
- Draw command "hlrin3d" was modified to prevent exception

Minor corrections

Corrections of test cases for issue CR27557

5 years ago0027565: [Regression to OCCT 7.0.0] Number of Intersections Is Wrong
aml [Fri, 3 Jun 2016 17:08:00 +0000 (20:08 +0300)]
0027565: [Regression to OCCT 7.0.0] Number of Intersections Is Wrong

Incorrect tolerance management is fixed.
Test case is added.

5 years ago0027513: Configuration, CMake - Option INSTALL_TBB does not install tbbmalloc.dll
ski [Thu, 2 Jun 2016 14:41:17 +0000 (17:41 +0300)]
0027513: Configuration, CMake - Option INSTALL_TBB does not install tbbmalloc.dll

Installation of tbbmalloc.dll was corrected.

5 years ago0026747: Some constructors of gp_Parab2d class contain redundant parameters
nbv [Mon, 11 Apr 2016 08:12:45 +0000 (11:12 +0300)]
0026747: Some constructors of gp_Parab2d class contain redundant parameters

1. Useless constructors have been deleted.
2. Value returned by gp_Parab2d::Directrix() method has been corrected to exclude reversing the directrix.
3. Documentation of gp_Parab2d class has been updated (in hxx-file).
4. Upgrade Guide has been updated according to corrections made in this issue.

Creation of test cases for this issue.

5 years ago0027536: Visualization - incorrect behavior of zoom persisted objects
aba [Wed, 1 Jun 2016 15:37:51 +0000 (18:37 +0300)]
0027536: Visualization - incorrect behavior of zoom persisted objects

1) Zoom persistence mode now fixes object in pixel coordinates and  is independent on view size

2) Used gp_GTrsf instead of gp_Trsf SelectMgr_ViewerSelector to store  Graphic3d_Mat4d

3) Zoom persisted objects changed behavior (become bigger) therefore test cases were updated according to new state.

4) Corrected scale for rectangular frustum

Updated test for manipulator

5 years ago0027562: Coding - avoid exporting of inline methods
kgv [Fri, 3 Jun 2016 12:35:52 +0000 (15:35 +0300)]
0027562: Coding - avoid exporting of inline methods

5 years ago0027555: Visualization, AIS_Shape - own deviation coefficient change is not considere...
kgv [Tue, 31 May 2016 13:18:36 +0000 (16:18 +0300)]
0027555: Visualization, AIS_Shape - own deviation coefficient change is not considered by Wireframe presentation mode

5 years ago0027015: Sewing returns invalid shape if some faces are nearly plane cones
aml [Thu, 2 Jun 2016 07:22:10 +0000 (10:22 +0300)]
0027015: Sewing returns invalid shape if some faces are nearly plane cones

Interpolation state check is fixed to mark as valid only ordered sequences of poles.
Refactoring of Approx_SameParameter.cxx.
Test case is added.
Test cases are updated to the new behavior.
Update of testing cases

5 years ago0027544: problem compiling OCCT with gcc version 4.8.2 gives error 'array subscript...
aml [Thu, 26 May 2016 17:08:48 +0000 (20:08 +0300)]
0027544: problem compiling OCCT with gcc version 4.8.2 gives error 'array subscript is above array bounds'

Possible out of borders problem is fixed.

5 years ago0027491: GeomAdaptor_Curve Is Not Thread-Safe (Anymore?)
Benjamin Bihler [Wed, 1 Jun 2016 11:24:23 +0000 (13:24 +0200)]
0027491: GeomAdaptor_Curve Is Not Thread-Safe (Anymore?)

Added hint about BSpline cache and missing thread-safety to adaptor classes.

5 years ago0027344: Configuration, CMake: bugs with detecting third-party products
ski [Tue, 5 Apr 2016 09:38:53 +0000 (12:38 +0300)]
0027344: Configuration, CMake: bugs with detecting third-party products

Information messages for TCL/TK search are corrected.

Compile definitions were added to OpenCASCADEConfig.cmake file

5 years ago0027481: [Regression to OCCT 6.6.0] Modeling Algorithms - incorrect CUT on two solids
azv [Tue, 24 May 2016 12:12:01 +0000 (15:12 +0300)]
0027481: [Regression to OCCT 6.6.0] Modeling Algorithms - incorrect CUT on two solids

* Test case has been added
* Adjust mesh characteristics in test cases according to changes in issue #27537

5 years ago0027537: GCPnts_TangentialDeflection produces incorrect number of sample points for...
azv [Tue, 24 May 2016 11:01:10 +0000 (14:01 +0300)]
0027537: GCPnts_TangentialDeflection produces incorrect number of sample points for circular edge

* Round up number of sample points to satisfy deflection.
* Test case added

5 years ago0027549: Visualization, OpenGl_View - drop confusing misnamed methods Width() and...
kgv [Tue, 31 May 2016 10:24:49 +0000 (13:24 +0300)]
0027549: Visualization, OpenGl_View - drop confusing misnamed methods Width() and Height()

5 years ago0027540: Run-to-run differences in the 3D Offset algorithm
emv [Fri, 27 May 2016 08:19:25 +0000 (11:19 +0300)]
0027540: Run-to-run differences in the 3D Offset algorithm

Calculating the offset vertices by the superposition of intersection vertices
between pairs of edges (BRepOffset_Inter2d::FuseVertices()).

To obtain stable result when calculating the superposition of vertices
they are sorted (BOPTools_AlgoTools::MakeVertex()).

The support of vertices has been added in nexplode command.

Small correction of tests cases for issue CR27540

5 years ago0027038: Visualization - add new presentation for object manipulation
apl [Fri, 27 May 2016 10:15:40 +0000 (13:15 +0300)]
0027038: Visualization - add new presentation for object manipulation

AIS_Manipulator class has been created to provide interactive services for manipulating with mouse local transformations of other interactive objects.

The class features three kinds of transformation modes for attached objects:
- translation of through axis
- scaling within axis
- rotation around axis

For more details please have a look at description of the class in reference manual or in header file.

The patch includes DRAW test workbench for evaluating the AIS_Manipulator features.

Clang warning (override)

5 years ago0027522: Foundation Classes, FSD_BinaryFile - incorrect size check in a stream
kgv [Fri, 27 May 2016 13:00:05 +0000 (16:00 +0300)]
0027522: Foundation Classes, FSD_BinaryFile - incorrect size check in a stream

FSD_BinaryFile::ReadExtendedString() now compares read bytes, not symbols.

5 years ago0027545: Coding - remove unused field in V3d_View::myCamera
kgv [Fri, 27 May 2016 12:43:55 +0000 (15:43 +0300)]
0027545: Coding - remove unused field in V3d_View::myCamera

5 years ago0027492: Change error messages highlighting to make them readable in HTML report
msv [Fri, 13 May 2016 13:46:47 +0000 (16:46 +0300)]
0027492: Change error messages highlighting to make them readable in HTML report

5 years ago0027520: Operation "splitshape" in the Test Harness give invalid result on the attach...
gka [Mon, 16 May 2016 14:10:14 +0000 (17:10 +0300)]
0027520: Operation "splitshape" in the Test Harness give invalid result on the attached case.

The new method has been added in the class BRepFeat_SplitShape for addition of the sequence of the splitting edges or wires for the whole initial shape without specification of the edge->face, edge->edge mapping.
The procedure of collecting wires has been corrected so as not to take into account the distance in 2D space between adjacent edges having a common vertex.
New category of tests "bugs/splitshape" has been added to non-regression data base.

Test cases for issue CR27520

Remove compilation warnings.

Add dependence of TKFeat on TKShHealing in EXTERNLIB in order to build with genproj.

5 years ago0027374: Visualization - optimize management of the scene bounding box
duv [Wed, 25 May 2016 14:00:59 +0000 (17:00 +0300)]
0027374: Visualization - optimize management of the scene bounding box

OpenGl_View now caches bounding boxes per Z-layer (instead of bounding box of entire scene in Graphic3d_CView).
Redundant invalidation of cached scene bounding box is now avoided in case
when new presentation attributes are assigned to the graphic structure.

Add a new methods ConsiderZoomPersistenceObjects() and considerZoomPersistenceObjects() in the Graphic3d_CView, OpenGl_View and OpenGl_Layer classes.
Call ConsiderZoomPersistenceObjects() in the V3d_View::FitMinMax method.

std::numeric_limits<T>::lowest() fix

5 years ago0027341: Incorrect exact HLR results
aml [Wed, 25 May 2016 09:19:24 +0000 (12:19 +0300)]
0027341: Incorrect exact HLR results

- removal of excess interferences in case of simple hiding face
- correct processing of boundary edges coinciding with outlines
- change of API for testing Draw Command
- correction of Draw command "build3d"
- test cases are added.

Linux reference data is changed.

Partially fixed 0027340: Insufficient exact HLR speed

Number of samples in PolyPoly intersection algorithm tuned in each instance of generic class.
Default number of the samples in Geom2dAdaptor is changed according to the Adaptor2d_Curve2d class.
Minimal number of points in case of B-Spline is changed.
Minimal number of samples support is added in intersection algorithms.

5 years ago0027317: Some visualisation tests failed because of exceptions generated by FP signals.
vpa [Fri, 20 May 2016 16:42:09 +0000 (19:42 +0300)]
0027317: Some visualisation tests failed because of exceptions generated by FP signals.

- missing implementation of CenterOfGeometry method was added in MeshVS_CommonSensitiveEntity;
- a check to prevent float overflow was added to OpenGl_BVHClipPrimitiveSet::Center.

5 years ago0027541: ShapeFix_ComposeShell allows usage of uninitialized value of the field myInv...
msv [Wed, 25 May 2016 16:23:52 +0000 (19:23 +0300)]
0027541: ShapeFix_ComposeShell allows usage of uninitialized value of the field myInvertEdgeStatus

Initialize all fields of the class in the constructor.

5 years ago0027538: Visualization, AIS_InteractiveContext::Display() - do not erase previous...
mgn [Tue, 24 May 2016 14:43:32 +0000 (17:43 +0300)]
0027538: Visualization, AIS_InteractiveContext::Display() - do not erase previous display mode.
AIS_InteractiveContext::Display() does not erases old presentation modes of interactive object anymore giving us performance benefit AIS_InteractiveContext::Display() is used. Instead, the method marks them hidden in the same way as AIS_InteractiveContext::SetDisplayMode() and ::UnsetDisplayMode().

5 years ago0027477: Visualization - Select3D_SensitiveCircle always return infinite depth value...
vpa [Mon, 23 May 2016 16:08:24 +0000 (19:08 +0300)]
0027477: Visualization - Select3D_SensitiveCircle always return infinite depth value in boundary mode

- unnecessary re-initialization of pick result was removed from Select3D_SensitiveCircle;
- test case for issue #27477

5 years ago0026512: Build fails with VTK 6.2 and OpenGL2 Rendering Backend
ski [Fri, 20 May 2016 08:31:27 +0000 (11:31 +0300)]
0026512: Build fails with VTK 6.2 and OpenGL2 Rendering Backend

Support of VTK with OpenGL2 Rendering Backend was added.

5 years ago0025623: Some tests become worse after 22598 fix
aml [Thu, 19 May 2016 09:54:18 +0000 (12:54 +0300)]
0025623: Some tests become worse after 22598 fix

Tolerance of line / line analytical intersection is fixed.
Test cases are updated to the new behavior.

Update of test case according to the current behavior

5 years ago0027521: Standard_ConstructionError when trying to use unifySameDom into a shape
msv [Fri, 20 May 2016 08:36:11 +0000 (11:36 +0300)]
0027521: Standard_ConstructionError when trying to use unifySameDom into a shape

Correct the algorithm in the function MergeEdges in ShapeUpgrade_UnifySameDomain.cxx so as to take into account the orientation of the next edge added to the chain.

Test cases for issue CR27521

5 years ago0027458: Configuration, genproj.tcl - add -rpath-link option to linker in Code::Block...
kgv [Sun, 1 May 2016 14:12:47 +0000 (17:12 +0300)]
0027458: Configuration, genproj.tcl - add -rpath-link option to linker in Code::Blocks project

5 years ago0026938: Boolean operations fail between two ellipsoids
aml [Fri, 13 May 2016 10:36:33 +0000 (13:36 +0300)]
0026938: Boolean operations fail between two ellipsoids

Treatment for single singular point is added.
Test cases are updated to the new behavior.
New test cases are added,
Message of "bad" state is corrected.

5 years ago0027194: Possible division by zero in IntPatch_WLineTool
aml [Sat, 20 Feb 2016 08:54:44 +0000 (11:54 +0300)]
0027194: Possible division by zero in IntPatch_WLineTool

Correct handling for division by zero is added. This prevents exception when FPE is enabled

5 years ago0027499: Configuration, CMake - add option INSTALL_NAME_DIR on OS X
kgv [Sun, 15 May 2016 13:41:30 +0000 (16:41 +0300)]
0027499: Configuration, CMake - add option INSTALL_NAME_DIR on OS X

5 years ago0027510: Visualization, OpenGl_Window - do not ignore backing store resize on OS X
kgv [Tue, 17 May 2016 18:22:54 +0000 (21:22 +0300)]
0027510: Visualization, OpenGl_Window - do not ignore backing store resize on OS X

5 years ago0027493: [Regression relative to OCCT 7.0.0] Extrema_ExtCC does not set flag "IsParal...
aml [Tue, 17 May 2016 04:24:57 +0000 (07:24 +0300)]
0027493: [Regression relative to OCCT 7.0.0] Extrema_ExtCC does not set flag "IsParallel" equal to true for the overlapped curves

Check for infinite solutions now starts from two solutions.
Test case is added.

5 years ago0027505: Visualization, Font_FontMgr - do not look for fonts.dir on OS X
kgv [Mon, 16 May 2016 04:39:14 +0000 (07:39 +0300)]
0027505: Visualization, Font_FontMgr - do not look for fonts.dir on OS X

Font_FontMgr::InitFontDataBase() now uses the same approach on OS X as on Android
ignoring fonts.dir files which are non used on these systems.

5 years ago0027466: The algorithm Extrema_GenLocateExtPS gives incorrect result
msv [Wed, 4 May 2016 16:18:12 +0000 (19:18 +0300)]
0027466: The algorithm Extrema_GenLocateExtPS gives incorrect result

Euclidean distance criteria is added for local point / surface extrema.
Classes representing objective criteria are renamed to be consistent.
Local extrema usage is updated according to new behavior.
Test case is added.

Misprint correction.

5 years ago0027490: BRepMesh: Reduce number of memory allocations
msv [Wed, 4 May 2016 01:12:28 +0000 (04:12 +0300)]
0027490: BRepMesh: Reduce number of memory allocations

1) Reduce the number of calls to malloc by grouping requests to larger blocks. To achieve this goal, the following ways are used:

- Containers of types sequence, list and map are initialized with an instance of NCollection_IncAllocator, at this taking care of the time of life of allocated objects, so that not to occupy huge amount of memory.

- Allocation of several arrays having the same and short life time is changed so that to allocate a buffer array of necessary size and to place arrays in this buffer.

2) In BRepMesh_FastDiscretFace, optimize the function filterParameters so that to avoid excess memory allocations.

3) In NCollection_CellFilter, change declaration of the method Reset to accept array by reference rather than by value.

4) Add Allocator() method in map, sequence and vector collection classes by analogy with list collection.

5) Correct the size of block for IncAllocator for x64 platform. In order free-ed block to be returned to the system its size should be at least 1024K on x64 and 512K on x86. This allows to retain free virtual space almost to the state before algorithm run.

6) Decrease amount of memory zeroed by calloc. For that, reduce theIncrement parameter of the embedded vectors of the classes NCollection_UBTreeFiller and BRepMesh_VertexInspector to default value 256.

7) Avoid computing bounding box when not necessary (if no relative deflection is used)

8) Cycles by wires of face using TopExp_Explorer are converted to use TopoDS_Iterator instead.

9) BRepMesh_FastDiscret::Add optimized to avoid storing sequences of faces and edges

10) The tests "mesh standard_* W7" are corrected to accept the new behavior. Earlier the following error took place:
Not connected mesh inside face 9
{12 13}
Now this error was replaced with another one:
free nodes (in pairs: face / node):
{9 12}
Actually it is not a regression, rather improvement, if we look at the snapshot.

11) Change other test cases to their actual state.

5 years agoAdjusting testing cases for current state of OCCT
bugmaster [Thu, 12 May 2016 15:14:18 +0000 (18:14 +0300)]
Adjusting testing cases for current state of OCCT

5 years ago0027169: Suspitious behavior of importing names during STEP import
gka [Tue, 10 May 2016 17:02:50 +0000 (20:02 +0300)]
0027169: Suspitious behavior of importing names during STEP import

In order to avoid using empty strings in the names of the assemblies in the XCAF document after reading step file for cases when description or name is defined by only 1 space character method TCollection_AsciiString::Length()
was replaced on the method TCollection_AsciiString::UsefullLength().

Test case for issue CR27169

Eliminating warning

5 years ago0027432: Null Handle Access When Creating AIS_Trihedron
abv [Tue, 26 Apr 2016 18:24:27 +0000 (21:24 +0300)]
0027432: Null Handle Access When Creating AIS_Trihedron

Debug-only "RaiseIf" is replaced by simple "if" to have exceptional situation handled correctly in Release mode.

Mention mandatory variable CSF_ShadersDirectory in porting notes for OCCT 6.9.0

Test cases for issue CR27432

Deleting test cases for issue CR27432

5 years ago0027463: BRepTools_ReShape ends up with empty shapes
ssv [Thu, 5 May 2016 15:01:02 +0000 (18:01 +0300)]
0027463: BRepTools_ReShape ends up with empty shapes

Add check on empty topological containers.

Add empty shapes to the replacement map.

Add Draw command for Re-Shape.

Add a test grid for reshape with a single use case for starters.

5 years ago0027476: Code alignment for ShapeFix_ComposeShell
anv [Fri, 29 Apr 2016 10:51:18 +0000 (13:51 +0300)]
0027476: Code alignment for ShapeFix_ComposeShell

5 years ago0027331: Not valid result on translating the file
anv [Fri, 29 Apr 2016 09:31:22 +0000 (12:31 +0300)]
0027331: Not valid result on translating the file

Added processing of a short segments of a seam edge.

Test case added.

5 years ago0027475: Incomplete direction for Powell method in math_GlobOptMin
aml [Fri, 6 May 2016 11:57:20 +0000 (14:57 +0300)]
0027475: Incomplete direction for Powell method in math_GlobOptMin

Directions are changed to be valid orthogonal set.

5 years ago0027454: Application hangs while opening a non-OCAF XML file
msv [Fri, 29 Apr 2016 16:31:13 +0000 (19:31 +0300)]
0027454: Application hangs while opening a non-OCAF XML file

1) Add protection against accessing null pointer in PCDM_ReadWriter::FileFormat.

2) In LDOM_XmlReader::ReadRecord, take into account that the character '>' can have no special meaning (e.g., in a text), and we must read the data behind this character to complete the current tag reading. This treatment concerns the mode of work when myTagPerStep is true.

3) Create a test case of reading of XML file not related to OCAF document.

Test case was added.

5 years ago0027467: Modeling Algorithms - class Extrema_ExtCC2d does not find extremum between...
aml [Thu, 5 May 2016 10:55:20 +0000 (13:55 +0300)]
0027467: Modeling Algorithms - class Extrema_ExtCC2d does not find extremum between two intersecting lines

Line / line analytic treatment is added for 2d case.
Test case is added.

5 years ago0027460: Data Exchange - restore method XSControl_WorkSession::MapReader()
kgv [Wed, 4 May 2016 09:52:58 +0000 (12:52 +0300)]
0027460: Data Exchange - restore method XSControl_WorkSession::MapReader()

5 years ago0027463: Checkprops can not be used with several properties
apn [Wed, 4 May 2016 11:13:02 +0000 (14:13 +0300)]
0027463: Checkprops can not be used with several properties

Added possibility to use several properties in one checkprops command

Modified test cases according to changes in checkprops command

5 years ago0027433: Opening/Saving OCAF Documents With Own Document Format Does Not Work
Benjamin Bihler [Thu, 28 Apr 2016 11:18:35 +0000 (14:18 +0300)]
0027433: Opening/Saving OCAF Documents With Own Document Format Does Not Work

Modified Load(...) method of Resource_Manager.cxx to print file names correctly.

Removed appending (empty) file name to directory name, since this is not
necessary and leads to a Standard_OutOfRange failure in TCollection_AsciiString.

Appending file name is done, but only if the name is not empty.

Added test case

5 years ago0027468: Incorrect processing of some cases by HLR algorithm
jgv [Thu, 5 May 2016 12:47:43 +0000 (15:47 +0300)]
0027468: Incorrect processing of some cases by HLR algorithm

Incorrect work of HLR algorithm caused by usage of wrong tolerances, wrong sampling of 2d curve and some other bugs are fixed.

Test cases for issue CR27341

5 years ago0027455: Implementation of connection points
ika [Mon, 25 Apr 2016 06:51:57 +0000 (09:51 +0300)]
0027455: Implementation of connection points

Add Import/Export connection points.
Make some improvements in STEP reading in collections shapes, to which dimension is attached.
Update tests.

5 years ago0027442: Rotation sweep can't be rendered in 3D
oan [Thu, 28 Apr 2016 16:07:15 +0000 (19:07 +0300)]
0027442: Rotation sweep can't be rendered in 3D

Do not insert internal nodes for Cylinder in case if it is less than DefFace value or in case of long cylinder with small radius due to protection against overflow during casting to integer.

Small correction of shape name in test case for issue CR27442

5 years ago0027424: Configuration, genconf.tcl - add missing option to enable TKD3DHost in confi...
kgv [Sat, 30 Apr 2016 14:12:57 +0000 (17:12 +0300)]
0027424: Configuration, genconf.tcl - add missing option to enable TKD3DHost in configurator

5 years ago0026846: Configuration, genproj.tcl - create hardlinks instead for header redirection
kgv [Sat, 30 Apr 2016 15:57:17 +0000 (18:57 +0300)]
0026846: Configuration, genproj.tcl - create hardlinks instead for header redirection

Build guides updated accordingly

Update genconf screenshot for Linux

5 years ago0027478: Configuration - avoid inclusion of Xlib.h within Graphic3d_GraphicDriver.hxx
Benjamin Bihler [Tue, 10 May 2016 17:59:55 +0000 (20:59 +0300)]
0027478: Configuration - avoid inclusion of Xlib.h within Graphic3d_GraphicDriver.hxx

Replace Aspect_DisplayConnection.hxx inclusion by forward declaration.

5 years ago0027384: BRepMesh_IncrementalMesh does not take angular deflection into account for...
oan [Tue, 26 Apr 2016 12:38:42 +0000 (15:38 +0300)]
0027384: BRepMesh_IncrementalMesh does not take angular deflection into account for spun/elementary surfaces

Check deviation of normals at vertices of triangles for complex surface types different from Bezier and BSpline.
Modified test cased according to changes in BRepMesh.
Do not remove more intermediate parameters than N - 3 in order to have at least one parameter related to surface internals.
Check angle for angular deflection before removement of intermediate parameters.
Unify computation of internal vertices for complex surfaces.
Discretization points of edges are taken into account during computation of step of mesh grid.
Remove parameters only if they fit the constrains along the whole surface.
Do not add random internal parameters in case if their number is just 2.
Force freezing parameters both for U and V in case of significant control point.

Modified test cases

Warnings elimination in vc14.

5 years ago0027368: Finding objects in vicinity of a ray
dbp [Mon, 25 Apr 2016 09:29:35 +0000 (12:29 +0300)]
0027368: Finding objects in vicinity of a ray

In frames of this issue, radix sort functionality from BVH_LinearBuilder was generalized and implemented as separate classes in BVH package. The basic API of sorting class is given in BVH_Sorter class, while BVH_QuickSorter and BVH_RadixSorter provide quck sroting and radix sorting algorithms respectivly.

5 years ago0027310: Huge tolerance obtained in the result of intersection of two cylindrical...
nbv [Thu, 7 Apr 2016 10:53:57 +0000 (13:53 +0300)]
0027310: Huge tolerance obtained in the result of intersection of two cylindrical faces

Sometimes start point of the intersection line is in the surface boundary strictly. I.e. the parameter of this point in the surface can be equal to both 0 or 2*PI equivalently. It is important to chose correct parameter value.

The algorithm of prediction is based on monotonicity property (see CylCylMonotonicity(...) function in IntPatch_ImpImpIntersection_4.gxx). Now, this function is used wrongly. The fix improves this situation.

Small optimization in the code.
Creation of test cases .

The logic of returning value by the method BoundariesComputing() has been corrected.

5 years ago0027269: Intersection algorithm produces null-length curve
nbv [Mon, 11 Apr 2016 07:38:50 +0000 (10:38 +0300)]
0027269: Intersection algorithm produces null-length curve

Restriction line can correspond to a degenerated edge. In this case we shall return null-curve (instead of Null-length curve).

5 years ago0027371: Regression: BRepExtrema works too much slower in 691 (from 670)
aml [Tue, 12 Apr 2016 09:15:07 +0000 (12:15 +0300)]
0027371: Regression: BRepExtrema works too much slower in 691 (from 670)

Lipschitz constant tuning.
Shubert estimation for minimal value is added.

Math_GlobOptMin Refactoring.

Test case is added.

class NCollection_CellFilter_Inspector moved into math_GlobOptMin class.

5 years ago0027435: Compilation error on Linux platfrom in Debug mode with enabled OCCT_DEBUG...
ski [Tue, 26 Apr 2016 13:02:32 +0000 (16:02 +0300)]
0027435: Compilation error on Linux platfrom in Debug mode with enabled OCCT_DEBUG definition

Error was fixed.

5 years ago0027195: Configuration, CMake - data and samples/tcl folders are installed with DRAW...
ski [Tue, 26 Apr 2016 10:18:53 +0000 (13:18 +0300)]
0027195: Configuration, CMake - data and samples/tcl folders are installed with DRAW executable only

Installation of data and samples/tcl folders was binded with DRAWEXE

5 years ago0027212: Make cmake configurator flexible concerning option BUILD_WITH_DEBUG
ski [Tue, 26 Apr 2016 08:05:46 +0000 (11:05 +0300)]
0027212: Make cmake configurator flexible concerning option BUILD_WITH_DEBUG

Added flexible behaviour for option BUILD_WITH_DEBUG.

5 years ago0027417: Coose a Better Default Release Optimization Parameter for MinGW-w64
Benjamin Bihler [Fri, 22 Apr 2016 10:07:52 +0000 (13:07 +0300)]
0027417: Coose a Better Default Release Optimization Parameter for MinGW-w64

Forcing CMAKE_CXX_FLAGS_RELEASE to -O2 -DNDEBUG, if the compiler is MinGW-w64.

Switched to replacing optimization parameter instead of overwriting

5 years ago0027402: Fix Compilation with MinGw and Additional Libraries
Benjamin Bihler [Tue, 19 Apr 2016 13:03:03 +0000 (16:03 +0300)]
0027402: Fix Compilation with MinGw and Additional Libraries

Setting CSF_GL2PS in occt_csf.cmake in the same way as CSF_FREETYPE is set.

Added MinGw library suffix to a in 3rdparty_macro.cmake, freetype.cmake and tbb.cmake.

Removed redundant CSF_GL2PS definition for non-Win32 configurations

5 years ago0027427: Exception on loading a DE package to Draw
anv [Mon, 25 Apr 2016 12:29:57 +0000 (15:29 +0300)]
0027427: Exception on loading a DE package to Draw

5 years ago0027425: Unable to build AIS package with OCCT_DEBUG enabled in current master
emv [Mon, 25 Apr 2016 05:56:22 +0000 (08:56 +0300)]
0027425: Unable to build AIS package with OCCT_DEBUG enabled in current master

The usage of the removed field mySelName of the AIS_LocalContext class has also been removed.

5 years agoUpdate of testing cases for current state of OCCT
bugmaster [Fri, 22 Apr 2016 11:15:43 +0000 (14:15 +0300)]
Update of testing cases for current state of OCCT

5 years ago0027349: XtControl_Reader is not thread-safe
anv [Fri, 22 Apr 2016 10:51:24 +0000 (13:51 +0300)]
0027349: XtControl_Reader is not thread-safe

Support of profiles for norms is removed
Getting rid of thread-unsafe static variables.
Sequence is not thread-safe. Replacing it with Vector.
Updating samples due to previous changes.
Resolving conflict with system environment.

5 years ago0026809: Visualization, TKOpenGl - handle point arrays with per-vertex color within...
duv [Sun, 17 Apr 2016 09:43:08 +0000 (12:43 +0300)]
0026809: Visualization, TKOpenGl - handle point arrays with per-vertex color within built-in GLSL programs

Shader rendering of point sprites with per-vertex colors and shading have been fixed.

Material state was removed from OpenGl_ShaderManager.
Material properties now should be modified trough OpenGl_Context::SetShadingMaterial().

5 years ago0027302: Invalid curves number in intersection result
nbv [Tue, 29 Mar 2016 13:38:53 +0000 (16:38 +0300)]
0027302: Invalid curves number in intersection result

1. In frame of the fix for #27282 issue, we have obtained several prolonged curves, which have common point(s). Fix for this issue joins these curves if it is possible.

2. ElCLib::InPeriod(...) method has been improved. Now it has become more faster (in general cases) and more reliable (in frame of  FLT_OVERFLOW and DIVISION_BY_ZERO cases processing).

Creation of test case for issue #27302
Test case tests\bugs\modalg_6\bug27282_2 has been adjusted in accordance with its new behavior.

5 years ago0027202: Visualization - add sensitivity Select3D_SensitivePrimitiveArray for Graphic...
kgv [Wed, 20 Apr 2016 06:48:58 +0000 (09:48 +0300)]
0027202: Visualization - add sensitivity Select3D_SensitivePrimitiveArray for Graphic3d_Buffer

New class Select3D_SensitivePrimitiveArray can be initialized directly from
presentation data structures Graphic3d_Buffer defining triangulation or point set.

This class also can combine several elements into patches
to reduce BVH initialization time in at the expense of slower detection time.

AIS_PointCloud::ComputeSelection() - selection is now computed on point set using Select3D_SensitivePrimitiveArray by default.
PrsMgr_PresentableObject::Compute() - redundant default argument value has been dropped.
BVH - store BVH_Set size in local variable to simplify debugging.

5 years ago0027359: Visualization - add support of flipping for textured text
aba [Thu, 7 Apr 2016 08:50:33 +0000 (11:50 +0300)]
0027359: Visualization - add support of flipping for textured text

Added option for OpenGl_Text to use previous model-view state.
Added interface to enable this option in Prs3d_Text
Added option to enable flipping in AIS_NameLabel

Eliminated warning

5 years ago0026886: Visualization, TKV3d - eliminate global variables
mpa [Fri, 8 Apr 2016 06:47:47 +0000 (09:47 +0300)]
0026886: Visualization, TKV3d - eliminate global variables

- AIS_InteractiveContext - create new dummy class field to have an empty TopoDS_Shape object.
- AIS_Point, PrsMgr_PresentableObject - rename static variables to local function variables.
- AIS_Shape, SelectMgr_SelectableObject - remove unused static variables.
- Graphic3d_MaterialAspect, V3d_Viewer - make global static variables as constant.
- V3d_View - move global variable zRotation to class field.
- Move a variable theCurrentSelection as a field of AIS_InteractiveContext and AIS_LocalContext classes. Multiple selection is not used now, so each Context have an own selection.
- Move myStructGenId from Graphic3d_StructureManager to Graphic3d_GraphicDriver for identifying the structures in the driver.
- Move default variable (no shading light) from static value to the class field of OpenGL_View.
Porting note:
- Static methods of AIS_Selection is not used now. Methods of
  should be used instead of static methods of AIS_Selection.

5 years ago0026434: Visualization - Textured objects should have priority over the environment...
isk [Tue, 29 Mar 2016 04:22:42 +0000 (07:22 +0300)]
0026434: Visualization - Textured objects should have priority over the environment mapping.
Add handle on environment texture in OpenGl_Workspace.
Add a new parameter UseEnvironmentTexture to the Graphic3d_ZLayerSettings.
OSD layers don't use environment texture by default.
zbuffertrihedron doesn't use environment texture.
vzlayer can enable/disable environment texture mappping.
Delete unnecessary files Graphic3d_TypeOfSurfaceDetail.hxx and V3d_TypeOfSurface.hxx.
Delete functions SurfaceDetailType and SetSurfaceDetailType functions from Graphic3d_CView.
Delete functions SurfaceDetailState and UpdateSurfaceDetailStateTo from OpenGl_ShaderManager.
Delete class OpenGl_SurfaceDetailState.
Delete functions SurfaceDetailType and SetSurfaceDetailType from OpenGl_View.
Delete functions SetSurfaceDetail and SurfaceDetail() from V3d_View.
Delete functions SetDefaultSurfaceDetail and DefaultSurfaceDetail from V3d_Viewer.
Delete draw command VSetTextureMode.
Add description in dox.

5 years ago0027275: Unused formal parameter in BSplCLib::EvalBsplineBasis
aml [Thu, 17 Mar 2016 11:22:22 +0000 (14:22 +0300)]
0027275: Unused formal parameter in BSplCLib::EvalBsplineBasis

Unused formal parameter is deleted.

5 years ago0027234: Code duplication: Convert_CompBezierCurvesToBSplineCurve* in ShapeConstruct
abv [Tue, 8 Mar 2016 16:39:15 +0000 (19:39 +0300)]
0027234: Code duplication: Convert_CompBezierCurvesToBSplineCurve* in ShapeConstruct

Classes from ShapeConstruct duplicating the ones from Convert package are removed.
Protection against joining segments when degree is 1 is introduced in Convert classes.
Optimization previously made in Convert_CompBezierCurvesToBSplineCurve class (within #25256) is applied to 2d equivalent.

Data for automatic upgrade procedure are extended to replace removed classes by their duplicates from Convert.

// cout disabled unless OCCT_DEBUG is defined

5 years ago0026930: ShapeConstruct_ProjectCurveOnSurface returns a B-Spline instead of line...
ika [Fri, 19 Feb 2016 11:05:43 +0000 (14:05 +0300)]
0026930: ShapeConstruct_ProjectCurveOnSurface returns a B-Spline instead of line (again)

Upgrade check of closeness of 2dcurve to line during projection:
  For C1 and more surfaces check distance to normal, not to surface, for C0 surfaces update tolerance formula.
  Add check for possible period jump in some inner point.
Update some test cases.

Add cache saving for lines,
update fixPeriodicTroubles() function, using parameters from cashe.

Small correction of test cases for issue #26930

fix processing of points from cache.

Update of test cases according to the new behavior

Fix behavior of fixPeriodicityTroubles() on different isolines,
fix copy/paste mistake.
Update test cases:
iges_2 C4 - return to master values
step_3 E6 - improvement.

5 years ago0027385: assertion in static initializer in a Windows GUI application
abv [Thu, 14 Apr 2016 12:41:59 +0000 (15:41 +0300)]
0027385: assertion in static initializer in a Windows GUI application

Useless global pointer to cerr is removed from OSD_Error, along with methods supporting its customization (Windows-only).
Global accessors to environment variables are replaced by locals in UnitsAPI.cxx.

5 years ago0027272: FixMissingSeam function creates G1 seam curves
gka [Tue, 12 Apr 2016 13:34:34 +0000 (16:34 +0300)]
0027272: FixMissingSeam function creates G1 seam curves

Method BRepLib::EncodeRegularity() is improved to set regularity GeomAbs_CN for edges lying on the same-domain surfaces (where derivatives on both surfaces are equal in all points).

DRAW command getedgeregularity is added to query regularity of the edge on specified faces.
DRAW command edgeregul is removed (this functionality is provided by command encoderegularity).

Added tests: bugs modalg_6 bug27272, bug27383_1, bug27383_2

Correction of shape name in test case for issue CR27272

5 years ago0027351: Custom OCCT DLL name suffixes
ski [Fri, 8 Apr 2016 13:55:24 +0000 (16:55 +0300)]
0027351: Custom OCCT DLL name suffixes

Added generation of libraries with postfix.

5 years ago0027380: cmake should not try to link against 3rd-party libs when configuring a stati...
ski [Wed, 13 Apr 2016 09:38:17 +0000 (12:38 +0300)]
0027380: cmake should not try to link against 3rd-party libs when configuring a static OCCT build

Linking against 3rd-party libs when configuring a static OCCT build is eliminated.

math library is not linked if build is static

also: an info message is expanded by several words describing using of only header files of 3rdparties

Removed unnecessary for static build CMake gui variables

5 years ago0027369: Assistance building Parasolid importer
apn [Mon, 11 Apr 2016 12:37:49 +0000 (15:37 +0300)]
0027369: Assistance building Parasolid importer

OpenCASCADE${OCCT_MODULE}Targets are generated for all dependent toolkits.

5 years ago0027280: HLR algorithms taking seam edges into account
jgv [Thu, 7 Apr 2016 14:13:49 +0000 (17:13 +0300)]
0027280: HLR algorithms taking seam edges into account

Interface of HLRAppli_ReflectLines has been modified.
New Draw command "hlrin3d" has been added.

5 years ago0026918: GeomLib_CheckCurveOnSurface cannot compute distance if 3D-curve is periodic
nbv [Tue, 12 Apr 2016 15:16:00 +0000 (18:16 +0300)]
0026918: GeomLib_CheckCurveOnSurface cannot compute distance if 3D-curve is periodic

Creation of test case for this issue.

5 years ago0027124: Invalid curve on surface in the result of General Fuse operation
nbv [Tue, 12 Apr 2016 13:45:37 +0000 (16:45 +0300)]
0027124: Invalid curve on surface in the result of General Fuse operation

Creation of test cases for issues #27124 and #27129.

5 years ago0027372: Import/Export dimension text position
ika [Thu, 7 Apr 2016 11:57:51 +0000 (14:57 +0300)]
0027372: Import/Export dimension text position

Modify Import/Export STEP.
Add Draw commands to set and get orientation and position of dimension text.
Add Draw commands to set and get presentation.
Add test.

5 years ago0027322: geom/revolution_00/A1: Incorrect pcurve creation
ifv [Thu, 7 Apr 2016 12:35:39 +0000 (15:35 +0300)]
0027322: geom/revolution_00/A1: Incorrect pcurve creation

ProjLib_Cone.cxx - correction wrong calculation of projection line on cone
GeomInt_IntSS_1.cxx - modification of method BuildPCurves(...) - adjusting first or last knots of 2d Curve
ProjLib_ComputeApprox.cxx - modification of method Function_SetUVBounds(...) for case projecting line on cone.
Modification of tests - removing first TODO

Test case for issue #27322

5 years ago0027379: Unable to build TKXDESTEP using WOK (wgenproj command) in current master
emv [Tue, 12 Apr 2016 10:26:10 +0000 (13:26 +0300)]
0027379: Unable to build TKXDESTEP using WOK (wgenproj command) in current master

The dependency on TKShHealing has been added.

5 years ago0027321: Configuration, CMake - check for doxygen during the first configuration...
ibs [Wed, 30 Mar 2016 12:55:59 +0000 (15:55 +0300)]
0027321: Configuration, CMake - check for doxygen during the first configuration and turn on overview building if doxygen is found