From: nbv Date: Thu, 12 Apr 2018 08:10:22 +0000 (+0300) Subject: 0029691: Constructor of BRepFill_MultiLine adjusts V-parameter of sphere in the range... X-Git-Tag: OCCT_VC2017_73~114 X-Git-Url: http://git.dev.opencascade.org/gitweb/?a=commitdiff_plain;h=ef33df518a21aceb02edfc2374197bf24e84ef56;p=occt-copy.git 0029691: Constructor of BRepFill_MultiLine adjusts V-parameter of sphere in the range -PI/2 ... +PI/2 mistakenly. 1. Sphere is not V-periodic surface. See the section "Periodicity concept" written in frame of the fix 0029115. Therefore, applying ElCLib::AdjustPeriodic(...) method is unreasonable. 2. Default U work range of sphere is 0 ... 2*PI. Therefore, adjusting U parameter in range -PI/2 ... +PI/2 is unreasonable. --- diff --git a/src/BRepFill/BRepFill_MultiLine.cxx b/src/BRepFill/BRepFill_MultiLine.cxx index b51f7fe7f0..da087a47c3 100644 --- a/src/BRepFill/BRepFill_MultiLine.cxx +++ b/src/BRepFill/BRepFill_MultiLine.cxx @@ -227,16 +227,6 @@ BRepFill_MultiLine::BRepFill_MultiLine(const TopoDS_Face& Face1, Precision::PConfusion(), Vmin, Vmax); } - if (GAS1.GetType() == GeomAbs_Sphere) { - if (myIsoU1) - ElCLib::AdjustPeriodic(-M_PI/2.,M_PI/2., - Precision::PConfusion(), - Umin, Umax); - else - ElCLib::AdjustPeriodic(-M_PI/2.,M_PI/2., - Precision::PConfusion(), - Vmin, Vmax); - } // end try duplication myU1 = Geom2dAdaptor_Curve(GeomProjLib::Curve2d(UU1, BasisPlane), @@ -343,16 +333,6 @@ BRepFill_MultiLine::BRepFill_MultiLine(const TopoDS_Face& Face1, Precision::PConfusion(), Vmin, Vmax); } - if (GAS2.GetType() == GeomAbs_Sphere) { - if (myIsoU2) - ElCLib::AdjustPeriodic(-M_PI/2.,M_PI/2., - Precision::PConfusion(), - Umin, Umax); - else - ElCLib::AdjustPeriodic(-M_PI/2.,M_PI/2., - Precision::PConfusion(), - Vmin, Vmax); - } // end try duplication myU2 = Geom2dAdaptor_Curve(GeomProjLib::Curve2d(UU2, BasisPlane),