From: abv <abv@opencascade.com>
Date: Thu, 25 Sep 2014 09:50:45 +0000 (+0400)
Subject: 0025077: [OOP] Explicit initialization of copy constructor
X-Git-Tag: V6_8_0_beta~86
X-Git-Url: http://git.dev.opencascade.org/gitweb/?a=commitdiff_plain;h=a9b30f0acb62a71c17670e4a1c2bfc2a40fec6c9;p=occt.git

0025077: [OOP] Explicit initialization of copy constructor

Explicit calls of copy constructor of base class added where compiler warnings are reported

Minor correction
---

diff --git a/src/BOPDS/BOPDS_PassKey.lxx b/src/BOPDS/BOPDS_PassKey.lxx
index dabd82bef9..cffef3ba1e 100644
--- a/src/BOPDS/BOPDS_PassKey.lxx
+++ b/src/BOPDS/BOPDS_PassKey.lxx
@@ -46,23 +46,11 @@ static
 //function :
 //purpose  : 
 //=======================================================================
-  inline BOPDS_PassKey::BOPDS_PassKey(const BOPDS_PassKey& aOther)
+  inline BOPDS_PassKey::BOPDS_PassKey(const BOPDS_PassKey& theOther)
+:
+  myPtr(0)
 {
-  Standard_Integer i;
-  //
-  myPtr=NULL;
-  Clear();
-  //
-  myAllocator=aOther.myAllocator;
-  myNbIds=aOther.myNbIds;
-  mySum=aOther.mySum;
-  //
-  if (myNbIds) {
-    myPtr=Allocate(myNbIds);
-    for (i=0; i<myNbIds; ++i) {
-      myPtr[i]=aOther.myPtr[i];
-    }
-  }
+  (*this) = theOther;
 }
 //=======================================================================
 //function :operator =
@@ -70,8 +58,6 @@ static
 //=======================================================================
   inline BOPDS_PassKey& BOPDS_PassKey::operator =(const BOPDS_PassKey& aOther)
 {
-  Standard_Integer i;
-  //
   Clear();
   //
   myAllocator=aOther.myAllocator;
@@ -80,7 +66,7 @@ static
   //
   if (myNbIds) {
     myPtr=Allocate(myNbIds);
-    for (i=0; i<myNbIds; ++i) {
+    for (int i=0; i<myNbIds; ++i) {
       myPtr[i]=aOther.myPtr[i];
     }
   }
diff --git a/src/BOPDS/BOPDS_PassKeyBoolean.lxx b/src/BOPDS/BOPDS_PassKeyBoolean.lxx
index e3f5b02d17..abeb0c690a 100644
--- a/src/BOPDS/BOPDS_PassKeyBoolean.lxx
+++ b/src/BOPDS/BOPDS_PassKeyBoolean.lxx
@@ -40,11 +40,11 @@
 //function :
 //purpose  : 
 //=======================================================================
-  inline BOPDS_PassKeyBoolean::BOPDS_PassKeyBoolean(const BOPDS_PassKeyBoolean& aOther)
+  inline BOPDS_PassKeyBoolean::BOPDS_PassKeyBoolean(const BOPDS_PassKeyBoolean& theOther)
+:
+  BOPDS_PassKey(theOther)
 {
-  myPtr=NULL;
-  BOPDS_PassKey::operator =(aOther);
-  myFlag=aOther.myFlag;
+  myFlag = theOther.myFlag;
 }
 //=======================================================================
 //function :~
diff --git a/src/Graphic3d/Graphic3d_ClipPlane.cxx b/src/Graphic3d/Graphic3d_ClipPlane.cxx
index 31963d9027..71b9325fe3 100755
--- a/src/Graphic3d/Graphic3d_ClipPlane.cxx
+++ b/src/Graphic3d/Graphic3d_ClipPlane.cxx
@@ -69,7 +69,8 @@ Graphic3d_ClipPlane::Graphic3d_ClipPlane(const Equation& theEquation)
 // purpose  :
 // =======================================================================
 Graphic3d_ClipPlane::Graphic3d_ClipPlane(const Graphic3d_ClipPlane& theOther)
-: myEquation (theOther.myEquation),
+: Standard_Transient(theOther),
+  myEquation (theOther.myEquation),
   myIsOn (theOther.myIsOn),
   myIsCapping (theOther.myIsCapping),
   myMaterial (theOther.myMaterial),
diff --git a/src/Standard/Standard_Failure.cxx b/src/Standard/Standard_Failure.cxx
index 4ec1917948..622dbe1041 100644
--- a/src/Standard/Standard_Failure.cxx
+++ b/src/Standard/Standard_Failure.cxx
@@ -78,9 +78,10 @@ Standard_Failure::Standard_Failure (const Standard_CString AString)
   myMessage = allocate_message(AString);
 }
 
-Standard_Failure::Standard_Failure (const Standard_Failure& aFailure) 
+Standard_Failure::Standard_Failure (const Standard_Failure& theFailure) 
+: Standard_Transient(theFailure)
 {
-  myMessage = copy_message(aFailure.myMessage);
+  myMessage = copy_message(theFailure.myMessage);
 }
 
 void Standard_Failure::Destroy()