0028361: Visualization, TKV3d - buggy behavior of Transformation Persistence compiled...

The patch fixes transformation persistence for various set of GCC compilers.
1) Optimized template-specialized operator /= for division (causes bugs)
   of NCollection_Vec4 was replaced with non-specialized version.
2) NCollection_Vec4::xyz() is not used since compiler uses modifiable-reference
   returning version, which invokes warning of possible strict-aliasing rules
   violation and leads to incorrect behavior of the reference.

diff --git a/src/Graphic3d/Graphic3d_TransformPers.hxx b/src/Graphic3d/Graphic3d_TransformPers.hxx
index 0588c7c8a90dbae018181e3593e37438a1b0dd1e..4f3ba60e8bdc4037b90ac48c1011863d99258060 100644 (file)
--- a/src/Graphic3d/Graphic3d_TransformPers.hxx
+++ b/src/Graphic3d/Graphic3d_TransformPers.hxx
@@ -510,8 +510,8 @@ void Graphic3d_TransformPers::Apply (const Handle(Graphic3d_Camera)& theCamera,
   {
     typename BVH_Box<T, 4>::BVH_VecNt& aCorner = anArrayOfCorners[anIt];
     aCorner  = aTPers * aCorner;
-    aCorner /= aCorner.w();
-    theBoundingBox.Add (aCorner.xyz());
+    aCorner = aCorner / aCorner.w();
+    theBoundingBox.Add (typename BVH_Box<T, 3>::BVH_VecNt (aCorner.x(), aCorner.y(), aCorner.z()));
   }
 }
 

diff --git a/tests/bugs/vis/bug28361 b/tests/bugs/vis/bug28361
new file mode 100644 (file)
index 0000000..c4c2465
--- /dev/null
+++ b/tests/bugs/vis/bug28361
@@ -0,0 +1,14 @@
+puts "============"
+puts "OCC28361 Visualization, TKV3d - buggy behavior of Transformation Persistence compiled on several Linux platforms in optimized mode"
+puts "============"
+puts ""
+
+vclear
+vinit View1
+pload MODELING VISUALIZATION
+box b 10 10 10
+vdisplay b -trsfPers zoomRotate -trsfPersPos 90 90 90
+vmoveto 266 164
+if { [vreadpixel 256 174 rgb name] != "CYAN1" } { puts "Error: the box is not highlighted" }
+
+vdump $imagedir/${casename}.png