0030985: Modeling Algorithms - heap-use-after-free reported by Clang address sanitize...

Code is corrected to avoid use of reference to a shape removed from the list after that removal

diff --git a/src/TopOpeBRepTool/TopOpeBRepTool_REGUW.cxx b/src/TopOpeBRepTool/TopOpeBRepTool_REGUW.cxx
index a03315b991d4619f092eef0b8f68280b3f05a8ba..38bd6ba383d9efdbb1a42ce52a846caef72da0c8 100644 (file)
--- a/src/TopOpeBRepTool/TopOpeBRepTool_REGUW.cxx
+++ b/src/TopOpeBRepTool/TopOpeBRepTool_REGUW.cxx
@@ -447,8 +447,8 @@ Standard_Boolean TopOpeBRepTool_REGUW::InitBlock()
     const TopOpeBRepTool_connexity& cmu = mymapvEds.FindFromKey(vmu);
     Standard_Boolean mult = cmu.IsMultiple();
     if (!mult) {
-      myListVmultiple.Remove(itmu);
       mymapvmultiple.Remove(vmu);
+      myListVmultiple.Remove(itmu);
     }
     else itmu.Next();
   }