0031455: Modeling Algorithms - useless pointer casts in BRepAlgoAPI classes

Useless casts are removed.

Off-topic: corrected description of constructor of TCollection_HAsciiString class from TCollection_HExtendedString for the case when input string contains non-Ascii character.

diff --git a/src/BRepAlgoAPI/BRepAlgoAPI_Common.cxx b/src/BRepAlgoAPI/BRepAlgoAPI_Common.cxx
index 5f58b093abf671b2885de1e9f82713f068b25ada..12f7f53b0a2f6bd4f92e1d93518ca33ea50b5fc7 100644 (file)
--- a/src/BRepAlgoAPI/BRepAlgoAPI_Common.cxx
+++ b/src/BRepAlgoAPI/BRepAlgoAPI_Common.cxx
@@ -55,9 +55,7 @@ BRepAlgoAPI_Common::BRepAlgoAPI_Common(const TopoDS_Shape& S1,
                                        const TopoDS_Shape& S2)
 : BRepAlgoAPI_BooleanOperation(S1, S2, BOPAlgo_COMMON)
 {
-  BRepAlgoAPI_BooleanOperation* pBO=
-    (BRepAlgoAPI_BooleanOperation*) (void*) this;
-  pBO->Build();
+  Build();
 }
 //=======================================================================
 //function : BRepAlgoAPI_Common
@@ -68,9 +66,7 @@ BRepAlgoAPI_Common::BRepAlgoAPI_Common(const TopoDS_Shape& S1,
                                        const BOPAlgo_PaveFiller& aDSF)
 : BRepAlgoAPI_BooleanOperation(S1, S2, aDSF, BOPAlgo_COMMON)
 {
-  BRepAlgoAPI_BooleanOperation* pBO=
-    (BRepAlgoAPI_BooleanOperation*) (void*) this;
-  pBO->Build();
+  Build();
 }
 
 

diff --git a/src/BRepAlgoAPI/BRepAlgoAPI_Cut.cxx b/src/BRepAlgoAPI/BRepAlgoAPI_Cut.cxx
index db411e8abc0e4b510a6525b06acbe1a546a0f0fd..f2a3d4fdd1ab19dc4fcb34e160966a10ff3243cb 100644 (file)
--- a/src/BRepAlgoAPI/BRepAlgoAPI_Cut.cxx
+++ b/src/BRepAlgoAPI/BRepAlgoAPI_Cut.cxx
@@ -56,9 +56,7 @@ BRepAlgoAPI_Cut::BRepAlgoAPI_Cut(const TopoDS_Shape& S1,
 :
   BRepAlgoAPI_BooleanOperation(S1, S2, BOPAlgo_CUT)
 {
-  BRepAlgoAPI_BooleanOperation* pBO=
-    (BRepAlgoAPI_BooleanOperation*) (void*) this;
-  pBO->Build();
+  Build();
 }
 //=======================================================================
 //function : BRepAlgoAPI_Cut
@@ -72,7 +70,5 @@ BRepAlgoAPI_Cut::BRepAlgoAPI_Cut(const TopoDS_Shape& S1,
   BRepAlgoAPI_BooleanOperation(S1, S2, aDSF, 
                                (bFWD) ? BOPAlgo_CUT : BOPAlgo_CUT21)
 {
-  BRepAlgoAPI_BooleanOperation* pBO=
-    (BRepAlgoAPI_BooleanOperation*) (void*) this;
-  pBO->Build();
+  Build();
 }

diff --git a/src/BRepAlgoAPI/BRepAlgoAPI_Fuse.cxx b/src/BRepAlgoAPI/BRepAlgoAPI_Fuse.cxx
index 6bff3dd14d749c23a8af4ec030780517536df870..1e24153be7ba79cf6eabb73877445cb3a16f7ff0 100644 (file)
--- a/src/BRepAlgoAPI/BRepAlgoAPI_Fuse.cxx
+++ b/src/BRepAlgoAPI/BRepAlgoAPI_Fuse.cxx
@@ -56,9 +56,7 @@ BRepAlgoAPI_Fuse::BRepAlgoAPI_Fuse(const TopoDS_Shape& S1,
 : 
   BRepAlgoAPI_BooleanOperation(S1, S2, BOPAlgo_FUSE)
 {
-  BRepAlgoAPI_BooleanOperation* pBO=
-    (BRepAlgoAPI_BooleanOperation*) (void*) this;
-  pBO->Build();
+  Build();
 }
 //=======================================================================
 //function : BRepAlgoAPI_Fuse
@@ -70,7 +68,5 @@ BRepAlgoAPI_Fuse::BRepAlgoAPI_Fuse(const TopoDS_Shape& S1,
 : 
   BRepAlgoAPI_BooleanOperation(S1, S2, aDSF, BOPAlgo_FUSE)
 {
-  BRepAlgoAPI_BooleanOperation* pBO=
-    (BRepAlgoAPI_BooleanOperation*) (void*) this;
-  pBO->Build();
+  Build();
 }

diff --git a/src/TCollection/TCollection_HAsciiString.hxx b/src/TCollection/TCollection_HAsciiString.hxx
index 0225cc73836dc0ff2ccf01bb7b7e47f96e1d807f..dca81162097c4f2f4bb584740e95d9dce0d4f349 100644 (file)
--- a/src/TCollection/TCollection_HAsciiString.hxx
+++ b/src/TCollection/TCollection_HAsciiString.hxx
@@ -72,17 +72,16 @@ public:
   //! Initializes a HAsciiString with a real value
   Standard_EXPORT TCollection_HAsciiString(const Standard_Real value);
   
-  //! Initializes a HAsciiString with a HAsciiString.
+  //! Initializes a HAsciiString with a AsciiString.
   Standard_EXPORT TCollection_HAsciiString(const TCollection_AsciiString& aString);
   
   //! Initializes a HAsciiString with a HAsciiString.
   Standard_EXPORT TCollection_HAsciiString(const Handle(TCollection_HAsciiString)& aString);
   
-  //! Initializes a HAsciiString with a HAsciiString.
+  //! Initializes a HAsciiString with a HExtendedString.
   //! If replaceNonAscii is non-null charecter, it will be used
   //! in place of any non-ascii character found in the source string.
-  //! Otherwise, raises OutOfRange exception if at least one character
-  //! in the source string is not in the "Ascii range".
+  //! Otherwise, creates UTF-8 unicode string.
   Standard_EXPORT TCollection_HAsciiString(const Handle(TCollection_HExtendedString)& aString, const Standard_Character replaceNonAscii);
   
   //! Appends <other>  to me.