0023533: Unitialized variables used, IntTools_TopolTool.cxx

Also contains fixes for:

0023534: Unitialized variables used, ShapeAnalysis_TransferParameters.cxx
0023537: Uninitialized variable: MaxUserColor
0023538: Memory leak: cdata
0023557: V547 Expression 'as1.ToCString() != ""' is always true. To compare strings you should use strcmp() function. qabugs_3.cxx,
DRAW command for test bugs fclasses buc60724 corrected; test is OK now

diff --git a/src/IntTools/IntTools_TopolTool.cxx b/src/IntTools/IntTools_TopolTool.cxx
index 4ad56f7ed115dadce0a64a49d21633587993a0f8..ad4461283c7530cb39d764c9c6de65c7bb686698 100755 (executable)
--- a/src/IntTools/IntTools_TopolTool.cxx
+++ b/src/IntTools/IntTools_TopolTool.cxx
@@ -111,7 +111,7 @@ void IntTools_TopolTool::ComputeSamplePoints()
   myU0 = uinf;
   myV0 = vinf;
 
-  Standard_Integer nbsu,nbsv;
+  Standard_Integer nbsu = 0,nbsv = 0;
   GeomAbs_SurfaceType typS = myS->GetType();
 
   switch(typS) {

diff --git a/src/QABugs/QABugs_3.cxx b/src/QABugs/QABugs_3.cxx
index 0624b61dbae14756fc3928c1608bdad75eab4f30..498994205167a53edf4d599da2588868da4a134b 100644 (file)
--- a/src/QABugs/QABugs_3.cxx
+++ b/src/QABugs/QABugs_3.cxx
@@ -1003,11 +1003,11 @@ static Standard_Integer BUC60724(Draw_Interpretor& di, Standard_Integer /*argc*/
 {
   TCollection_AsciiString as1("");
   TCollection_AsciiString as2('\0');
-  if((as1.ToCString()!=NULL) || (as1.ToCString() != ""))
-    di << "Faulty : the first string is not zero string : " << as1.ToCString() << "\n";
+  if(as1.ToCString() == NULL || as1.Length() != 0 || as1.ToCString()[0] != '\0')
+    di << "Error : the first string is not zero string : " << as1.ToCString() << "\n";
 
-  if((as2.ToCString()!=NULL) || (as2.ToCString() != ""))
-    di << "Faulty : the second string is not zero string : " << as2.ToCString() << "\n";
+  if(as2.ToCString() == NULL || as2.Length() != 0 || as2.ToCString()[0] != '\0')
+    di << "Error : the second string is not zero string : " << as2.ToCString() << "\n";
   
   return 0;
 }

diff --git a/src/ShapeAnalysis/ShapeAnalysis_TransferParameters.cxx b/src/ShapeAnalysis/ShapeAnalysis_TransferParameters.cxx
index e250c2272c81faa852c8e583a778320d40df89d2..5c38e1a89de56e0545d60e3ade0a8d228384c34a 100755 (executable)
--- a/src/ShapeAnalysis/ShapeAnalysis_TransferParameters.cxx
+++ b/src/ShapeAnalysis/ShapeAnalysis_TransferParameters.cxx
@@ -57,7 +57,7 @@ void ShapeAnalysis_TransferParameters::Init(const TopoDS_Edge& E, const TopoDS_F
 {
   myScale = 1.;
   myShift = 0.;
-  Standard_Real l,f,l2d,f2d;
+  Standard_Real l,f,l2d = 0.0,f2d = 0.0;
   TopLoc_Location L;
   myEdge = E;
   ShapeAnalysis_Edge sae;

diff --git a/src/Xw/Xw_ColorMap.cxx b/src/Xw/Xw_ColorMap.cxx
index 543015fb3c7998c6900ba73ac10c6e79c3626d2a..55e9244933f065009bc57b3fb05e49ace4f3ead0 100755 (executable)
--- a/src/Xw/Xw_ColorMap.cxx
+++ b/src/Xw/Xw_ColorMap.cxx
@@ -308,7 +308,7 @@ int MaxColor,BasePixel,MaxUserColor,MaxDefineColor,FirstFreeColorIndex,visualid
 Standard_Integer Xw_ColorMap::MaxOverlayColors( ) const {
 Aspect_Handle *VisualInfo ;
 Xw_TypeOfVisual VisualClass ;
-int MaxColor,BasePixel,MaxUserColor,MaxDefineColor,FirstFreeColorIndex,visualid ;
+int MaxColor,BasePixel,MaxDefineColor,FirstFreeColorIndex,visualid, MaxUserColor = 0;
 
        status = XW_ERROR;
        if( MyExtendedOverlayColorMap ) {

diff --git a/src/Xw/Xw_open_image.cxx b/src/Xw/Xw_open_image.cxx
index f6fa9322409b00164722d3d7b05ccf9698e041d0..ac0e8ecbe262e3619db1954e92bdf0532aadb1eb 100755 (executable)
--- a/src/Xw/Xw_open_image.cxx
+++ b/src/Xw/Xw_open_image.cxx
@@ -64,8 +64,8 @@ XW_EXT_WINDOW *pwindow = (XW_EXT_WINDOW*)awindow;
 XW_EXT_IMAGEDATA *pimage ;
 XW_EXT_COLORMAP *pcolormap ;
 //int i,pad ;
-int pad ;
-char *cdata ;
+int pad = 0;
+char *cdata = NULL;
 
     if( !Xw_isdefine_window(pwindow) ) {
         /*ERROR*Bad EXT_WINDOW Address*/
@@ -100,8 +100,10 @@ char *cdata ;
         return (NULL) ;
     }
 
-    if( !(pimage = Xw_add_imagedata_structure(sizeof(XW_EXT_IMAGEDATA))) ) 
-                                                               return (NULL) ;
+    if( !(pimage = Xw_add_imagedata_structure(sizeof(XW_EXT_IMAGEDATA))) ) {
+        Xw_free(cdata);
+        return (NULL) ;
+    }
 
     pimage->pimageinfo = aimageinfo ;
     pimage->pcolormap = pcolormap = _COLORMAP ;

diff --git a/tests/bugs/fclasses/buc60724 b/tests/bugs/fclasses/buc60724
index a3ac3be7de81ec6ad9bd5a9a871b65c2ffb5a7f8..cc9314f4a2249634b27de4626350287039c8b53b 100755 (executable)
--- a/tests/bugs/fclasses/buc60724
+++ b/tests/bugs/fclasses/buc60724
@@ -1,6 +1,3 @@
-puts "TODO OCC12345 ALL: Faulty : the first string is not zero string :"
-puts "TODO OCC12345 ALL: Faulty : the second string is not zero string :"
-
 puts "=========="
 puts "BUC60724"
 puts "=========="