Corrections made for OCCT 6.9.1.beta

- Graphic3d_Camera: comparison of real to zero by == is replaced by safer check against FLT_MIN (#25760)
- BRepBuilderAPI_Copy: new option copyMesh (#26458) is documented and made combinable with copyGeom

diff --git a/src/BRepBuilderAPI/BRepBuilderAPI_Copy.cxx b/src/BRepBuilderAPI/BRepBuilderAPI_Copy.cxx
index b84d53ca2cc3490bae8878015efffaa3953594c7..98a20defff45ba28eb3ee635fd36be31ab50bd2c 100644 (file)
--- a/src/BRepBuilderAPI/BRepBuilderAPI_Copy.cxx
+++ b/src/BRepBuilderAPI/BRepBuilderAPI_Copy.cxx
@@ -26,12 +26,14 @@
 #include <TopoDS_Vertex.hxx>
 #include <Poly_Triangulation.hxx>
 
+namespace {
+
 //! Tool class implementing necessary functionality for copying geometry
 class BRepBuilderAPI_Copy_Modification : public BRepTools_Modification 
 {
 public:
   BRepBuilderAPI_Copy_Modification (const Standard_Boolean copyGeom,
-                                    const Standard_Boolean copyMesh = Standard_False)
+                                    const Standard_Boolean copyMesh)
     : myCopyGeom(copyGeom),
       myCopyMesh(copyMesh)
   {
@@ -66,7 +68,8 @@ public:
     if (T.IsNull())
       return Standard_False;
 
-    T = T->Copy();
+    if (myCopyGeom)
+      T = T->Copy();
     return Standard_True;
   }
 
@@ -143,6 +146,7 @@ private:
 
 DEFINE_STANDARD_HANDLE(BRepBuilderAPI_Copy_Modification, BRepTools_Modification)
 
+} // anonymous namespace
 
 //=======================================================================
 //function : BRepBuilderAPI_Copy
@@ -151,7 +155,7 @@ DEFINE_STANDARD_HANDLE(BRepBuilderAPI_Copy_Modification, BRepTools_Modification)
 
 BRepBuilderAPI_Copy::BRepBuilderAPI_Copy ()
 {
-  myModification = new BRepBuilderAPI_Copy_Modification(Standard_True);
+  myModification = new BRepBuilderAPI_Copy_Modification(Standard_True, Standard_False);
 }
 
 

diff --git a/src/BRepBuilderAPI/BRepBuilderAPI_Copy.hxx b/src/BRepBuilderAPI/BRepBuilderAPI_Copy.hxx
index 9c5ada626137c0291490603dd5eafee44d7d8d4e..3dc9c5f58101b11f565c8076e84c139381bdbaf9 100644 (file)
--- a/src/BRepBuilderAPI/BRepBuilderAPI_Copy.hxx
+++ b/src/BRepBuilderAPI/BRepBuilderAPI_Copy.hxx
@@ -22,9 +22,8 @@
 #include <Standard_Handle.hxx>
 
 #include <BRepBuilderAPI_ModifyShape.hxx>
-#include <Standard_Boolean.hxx>
-class TopoDS_Shape;
 
+class TopoDS_Shape;
 
 //! Duplication of a shape.
 //! A Copy object provides a framework for:
@@ -36,7 +35,6 @@ class BRepBuilderAPI_Copy  : public BRepBuilderAPI_ModifyShape
 public:
 
   DEFINE_STANDARD_ALLOC
-
   
   //! Constructs an empty copy framework. Use the function
   //! Perform to copy shapes.
@@ -44,39 +42,22 @@ public:
   
   //! Constructs a copy framework and copies the shape S.
   //! Use the function Shape to access the result.
-  //! If copyGeom is False, only topological objects will be copied, while
-  //! geometry will be shared with original shape.
+  //! If copyMesh is True, triangulation contained in original shape will be 
+  //! copied along with geometry (by default, triangulation gets lost).
+  //! If copyGeom is False, only topological objects will be copied, while 
+  //! geometry and triangulation will be shared with original shape.
   //! Note: the constructed framework can be reused to copy
   //! other shapes: just specify them with the function Perform.
   Standard_EXPORT BRepBuilderAPI_Copy(const TopoDS_Shape& S, const Standard_Boolean copyGeom = Standard_True, const Standard_Boolean copyMesh = Standard_False);
   
   //! Copies the shape S.
   //! Use the function Shape to access the result.
-  //! If copyGeom is False, only topological objects will be copied, while
-  //! geometry will be shared with original shape.
+  //! If copyMesh is True, triangulation contained in original shape will be 
+  //! copied along with geometry (by default, triangulation gets lost).
+  //! If copyGeom is False, only topological objects will be copied, while 
+  //! geometry and triangulation will be shared with original shape.
   Standard_EXPORT void Perform (const TopoDS_Shape& S, const Standard_Boolean copyGeom = Standard_True, const Standard_Boolean copyMesh = Standard_False);
 
-
-
-
-protected:
-
-
-
-
-
-private:
-
-
-
-
-
 };
 
-
-
-
-
-
-
 #endif // _BRepBuilderAPI_Copy_HeaderFile

diff --git a/src/Graphic3d/Graphic3d_Camera.cxx b/src/Graphic3d/Graphic3d_Camera.cxx
index 7b38769e6711fb21fb7af33ae9f76292380e772d..f6c043c5340dccc798cce7844d15b9266786a804 100644 (file)
--- a/src/Graphic3d/Graphic3d_Camera.cxx
+++ b/src/Graphic3d/Graphic3d_Camera.cxx
@@ -50,11 +50,12 @@ namespace
   // relative z-range tolerance compatible with for floating point.
   static Standard_Real zEpsilon (const Standard_Real theValue)
   {
-    if (theValue == 0)
+    Standard_Real anAbsValue = Abs (theValue);
+    if (anAbsValue <= (double)FLT_MIN)
     {
-      return FLT_EPSILON;
+      return FLT_MIN;
     }
-    Standard_Real aLogRadix = Log10 (Abs (theValue)) / Log10 (FLT_RADIX);
+    Standard_Real aLogRadix = Log10 (anAbsValue) / Log10 (FLT_RADIX);
     Standard_Real aExp = Floor (aLogRadix);
     return FLT_EPSILON * Pow (FLT_RADIX, aExp);
   };