jgv [Mon, 20 Jul 2020 16:15:17 +0000 (19:15 +0300)]
Change in BRepOffset_Tool::EnLargeFace: new mode of extension
ika [Thu, 4 Apr 2019 11:40:35 +0000 (14:40 +0300)]
Fix visualization of shape with mirror transformation.
ika [Mon, 30 Oct 2017 15:04:12 +0000 (18:04 +0300)]
0029282: Data Exchange - UpdateAssemblies is not working for located root assemblies
Add check for located root assemblies.
ssv [Thu, 19 Jan 2017 13:22:32 +0000 (16:22 +0300)]
0028055: Add UpdateAssemblies() method for top-down update of assembly compounds
- Implement top-down update for assemblies in XCAFDoc_ShapeTool
- Get rid of UpdateAssembly() method used for partial (parent-only) update
- Adjust STEP and IGES translators to use the top-down update after filling OCAF
- Implement XUpdateAssemblies Draw command
- Add test cases bug28055_1 and bug28055_2 for component removal and part update
- Update XDE documentation to mention the new UpdateAssemblies() method
Correction for issue CR28055
Adjusting of test case bugs/fclasses/bug28217
jgv [Mon, 3 Sep 2018 09:14:47 +0000 (12:14 +0300)]
0030560: Modeling Algorithms - Improvement of the method BRepTools::DetectClosedness
1. Rewrite the method BRepTools::DetectClosedness.
2. Correct the method BRepOffset_Tool::EnLargeFace to process properly non-periodic but closed faces.
kgv [Tue, 19 Sep 2017 07:02:37 +0000 (10:02 +0300)]
0029062: Visualization, SelectMgr_ViewerSelector - add NULL-check within ::checkOverlap() method
jgv [Mon, 3 Sep 2018 09:14:47 +0000 (12:14 +0300)]
0030391: Improvement of the method BRepOffset_Tool::EnLargeFace
Add options to set the length of enlargement for each of 4 directions.
Add restriction of enlargement in the case of singularity on the surface.
san [Wed, 6 Jun 2018 16:58:10 +0000 (19:58 +0300)]
0029844: Volume Rendering - NVIDIA graphic driver timeout errors with callback enabled
An attempt to resolve CPU-GPU synchronization issues using glFinish()
ika [Tue, 8 May 2018 10:22:01 +0000 (13:22 +0300)]
Bug #297 Fix IsSubShape method in ShapeTool
Pick a part of commit for
0029599
kgv [Fri, 13 Jan 2017 17:24:11 +0000 (20:24 +0300)]
0027585: It is not possible to store OCAF documents to paths with special characters in their names
TCollection_AsciiString - fixed inproper convertion from UTF-16 string.
apn [Thu, 5 Apr 2018 13:01:53 +0000 (16:01 +0300)]
Modify installation procedure using OCCT_INSTALL_BIN_LETTER (bind/bini/lib/libi in Debug and RelWithDebInfo modes).
jgv [Fri, 2 Feb 2018 12:02:50 +0000 (15:02 +0300)]
Improvements in the class BRepOffset_Tool:
- Fix wrong building of extended face on a closed surface.
- Add new public static method BRepOffset_Tool::DetectClosedness(), which checks whether a face is closed in U and V directions.
msv [Mon, 5 Mar 2018 17:09:08 +0000 (20:09 +0300)]
Pick commit from master to eliminate false error reporting about unclosed wires.
jgv [Tue, 13 Feb 2018 14:34:34 +0000 (17:34 +0300)]
Pick commit from master to get rid of draw console problem in Emacs.
snn [Fri, 16 Mar 2018 09:19:08 +0000 (12:19 +0300)]
BRep history added for hidden faces remove tool support
gka [Mon, 26 Feb 2018 13:27:46 +0000 (16:27 +0300)]
0029526: Test Harness command "ReadIges" does not support "read.iges.onlyvisible" mode
In the Test Harness command "ReadIges" there is added taking into account value of the parameter "read.only.visible"
gka [Mon, 26 Feb 2018 13:27:46 +0000 (16:27 +0300)]
Bug#209: Some IGES Files do not import correctly to OCCT 7.1
To read only visible roots from IGES file in the XCAF document Test Harness command "ReadIges" was modified to take into account value of the Test Harness parameter "read.iges.onlyvisible".
snn [Mon, 26 Feb 2018 12:16:18 +0000 (15:16 +0300)]
Semantic name Get/Set functions added to XCAFDimTolObjects_*Object classes. Added XGetGDTSemanticName/XSetGDTSemanticName draw commands.
kgv [Fri, 16 Feb 2018 14:29:17 +0000 (17:29 +0300)]
Compatibility with obsolete MSVC compilers - added PRId64 macros
jgv [Mon, 14 Aug 2017 11:48:07 +0000 (14:48 +0300)]
Support of implementation of the algorithm for replacing faces in shape with new faces based on other surfaces - PatchFaces. For that:
- Add the flag UseInfini in the method BRepOffset_Tool::EnLargeFace, defining whether it is needed to use infinite enlarge of a face or not.
- Add the method TopExp::MapShapesAndUniqueAncestors().
- Increase the value of extension in EnlargeGeometry to provide proper intersection of adjacent faces.
nbv [Mon, 13 Mar 2017 13:03:07 +0000 (16:03 +0300)]
0028492: Boolean common does not produce expected result
Generation of 3D-steps shorter than 3D tolerance has been allowed in the fix to build Walking-line.
Now, 3D-step is limited by Precision::Confusion value.
ika [Wed, 22 Mar 2017 07:31:58 +0000 (10:31 +0300)]
0028449: Data Exchange - Wrong orientation of Annotation Plane in GD&T
Fix orientation.
update test cases
ika [Mon, 4 Dec 2017 08:05:02 +0000 (11:05 +0300)]
0029362: Data Exchange - Crash during reading step file
Additional check for wires into searching of attached shapes,
Fix Dimension value processing,
Update test cases.
kgv [Wed, 25 Oct 2017 14:27:23 +0000 (17:27 +0300)]
0029262: Visualization - AIS_InteractiveContext::Load() does not register Object in the Viewer
AIS_InteractiveContext::Load() now loads the object regardless specified selection mode and decomposition flag.
AIS_InteractiveContext::Load() and ::KeepTemporary() now register object in the Viewer
in the same way as ::Display() does.
Draw Harness command vdisplay has been extended with new flag -erased to load object into context in erased state.
kgv [Mon, 28 Aug 2017 18:10:28 +0000 (21:10 +0300)]
0029067: Visualization, AIS_ColoredShape - visibility of sub-shapes is ignored by ComputeSelection()
ssv [Fri, 14 Apr 2017 07:42:30 +0000 (10:42 +0300)]
Add specific key for two-sided coloring of AIS shape in vdisplay command
ika [Thu, 30 Mar 2017 09:39:05 +0000 (12:39 +0300)]
0028444: Data Exchange - Missed text blocks in Saved Views
Add new STEP entity to connect dimension semantic with presentation.
Fix number of GDTs in Saved View.
ika [Wed, 28 Dec 2016 11:05:01 +0000 (14:05 +0300)]
0028315: Data Exchange - Import/Export GD&Ts without semantic
Implement import/export of Dimensions without semantic.
Add new type of dimension for GDTs with presentation and connecting to shapes.
Update test cases.
apn [Thu, 29 Dec 2016 17:24:44 +0000 (20:24 +0300)]
Fix compilation error on vc12 (MSVC++ 12.0)
apn [Thu, 29 Dec 2016 17:02:35 +0000 (20:02 +0300)]
Corrections for MacOS genproj.tcl (branch CR26866)
kgv [Wed, 28 Dec 2016 16:10:24 +0000 (19:10 +0300)]
0028312: Configuration, genproj.tcl - support CSF_ZLIB and CSF_LIBLZMA within project generator
Added CSF_ZLIB for searching zlib library, CSF_LIBLZMA for liblzma library
and CSF_FFmpeg for FFmpeg framework.
Unused CSF_AviLibs has been dropped.
emv [Thu, 29 Dec 2016 12:42:08 +0000 (15:42 +0300)]
0028189: Result of Boolean operation is non-manifold wire
1. The result of Boolean operation on the arguments of collection type, containers WIRE/SHELL/COMPSOLID, is also a collection.
The containers of type WIRE included into result should now also (as the SHELLs) have coherent orientation of its sub-shapes.
For that the new method has been implemented (BOPTools_AlgoTools::OrientEdgesOnWire(TopoDS_Shape&)) which reorients edges for correct ordering.
The duplicating containers, i.e. containers with the contents completely included in other containers, are now avoided in the result of BOP.
2. The result of Fuse operation on Compsolids is now also will be Compsolid.
3. Documentation has been updated.
4. New test cases for the issue.
5. Adjusting test cases to current behavior.
Correction of test case bugs/modalg_4/bug726_2 according to the new behavior
ika [Tue, 20 Dec 2016 12:12:09 +0000 (15:12 +0300)]
0028235: Data Exchange - DG&T datum XCAF object has incomplete list of shape references
Update STEP import and export of datums.
Update test cases.
ski [Thu, 22 Dec 2016 17:54:00 +0000 (20:54 +0300)]
0026866: Configuration, genproj - ensure consistency between FILES and actual content of inc and src folders
Added check of consistency between FILES and actual content of inc and src folders in genproj procedure.
ski [Thu, 15 Dec 2016 09:44:36 +0000 (12:44 +0300)]
0028197: Configuration - support Eigen template library as external dependency
Supporting of "Eigen" third party was added to CMake build procedure.
vpa [Wed, 28 Dec 2016 12:52:31 +0000 (15:52 +0300)]
0028047: Visualization - support objects with customized highlighting in AIS_InteractiveContext
- SelectMgr_SelectableObject::ClearHighlighted method is added to remove dynamic highlight data;
- interactive context will pass processing of dynamic highlight erase to the object if the owner returns false in SelectMgr_EntityOwner::IsAutoHilight;
- if owner returns true in SelectMgr_EntityOwner::IsForcedHilight, selection presentation will be re-highlighted at each ::Select call;
- redundant logic related to old object-oriented highlight mechanism was removed from AIS_InteractiveContext::MoveTo.
emv [Fri, 23 Dec 2016 13:04:25 +0000 (16:04 +0300)]
0028273: Inefficient implementation of the BRepOffset_MakeOffset::BuildSplitsOfFace function
The method for building splits of the face BRepOffset_MakeOffset::BuildSplitsOfFace has been redesigned to use the BOPAlgo_BuilderFace algorithm directly.
The methods FindInvalidFaces and TrimNewIntersectionEdges have been corrected to avoid possible instabilities.
The filtering of invalid edges by existing bounding edges has been corrected to avoid removal of valid splits.
The method BRepOffset_Analyse::Correct2dPoint has been modified to avoid unnecessary initialization of BRepAdaptor_Surface.
Adjustment of the test cases.
Test case bugs modalg_6 bug26513 has been modified to unify faces of the input shape before operation.
msv [Mon, 26 Dec 2016 12:31:14 +0000 (15:31 +0300)]
0028283: The command bopcheck crashes on the given shape
BOPAlgo_CheckerSI crashed due to building of pcurve for an edge not lying on surface. The fix avoids building of pcurves in this algorithm.
The new flag has been added in BOPAlgo_PaveFiller class (method SetAvoidBuildPCurve). It tells whether to avoid building pcurves. It is worth to set if the result is not used to create splits of faces, as in example with BOPAlgo_CheckerSI.
abv [Thu, 29 Dec 2016 11:37:42 +0000 (14:37 +0300)]
0028217: Error handling is not thread safe and causing memory corruption and sporadic crashes
Static variable holding handle to the last raised exception is made thread-local on compilers that support C++11 keyword thread_local (MCVC++ 14+, GCC 4.8+, ICC 14+, CLang).
Test bugs fclasses bug28217 is added (BAD on vc < 14 and gcc < 4.8).
Test case tuning bugs/fclasses/bug28217
isk [Tue, 27 Dec 2016 08:19:21 +0000 (11:19 +0300)]
0028285: Configuration - add missing macro Standard_EXPORT to OpenGl_StateInterface subclasses
kgv [Sun, 25 Dec 2016 17:07:39 +0000 (20:07 +0300)]
0028281: Draw Harness - remove unused command vperf
kgv [Fri, 23 Dec 2016 18:21:00 +0000 (21:21 +0300)]
0028276: Visualization, Graphic3d_ArrayOfPrimitives - fix usage of 16-bit indices
Graphic3d_ArrayOfPrimitives now check the amount of vertex data rather than amount of indices.
ski [Mon, 14 Nov 2016 11:31:00 +0000 (14:31 +0300)]
0028110: Configuration - specify Unicode charset instead of multibyte in project files for Visual Studio
Eliminated usage of ANSI methods.
All Visual Studio projects generated by genproj or CMake use Unicode character set.
Draw Harness now handles Unicode input on Windows.
Tcl test scripts are now expected in UTF-8 encoding by default.
ifv [Fri, 16 Dec 2016 11:26:42 +0000 (14:26 +0300)]
0028223: Projection of closed curve onto cylinder is wrong
Algorithm of calculation UV bounds of projected curve for periodic surfaces is modified.
ski [Wed, 21 Dec 2016 10:41:04 +0000 (13:41 +0300)]
0028135: Configuration - adopt building script for using built-in Android cross-compiling support in CMake 3.7
Added toolchain file for using built-in Android cross-compiling support in CMake 3.7
Added variable CMAKE_ANDROID_STL_TYPE for Android platform build via CMake.
Updated documentation about building of occt for UWP and Android via CMake.
Eliminated CMake warning CMP0054 for Android platform build.
apn [Fri, 23 Dec 2016 07:10:55 +0000 (10:10 +0300)]
Warnings on vc14 were eliminated
isk [Thu, 22 Dec 2016 09:53:46 +0000 (12:53 +0300)]
0028244: Visualization - AIS_AngleDimension throws exception for 180 degree
Small correction of test case for issue CR28244
ika [Tue, 20 Dec 2016 10:25:02 +0000 (13:25 +0300)]
0028250: Data Exchange - Wrong number of geometric tolerance modifiers.
fix some copy paste mistakes,
update test cases.
kgv [Sun, 18 Dec 2016 07:18:55 +0000 (10:18 +0300)]
0028232: Visualization, StdPrs_ShadedShape - create WireFrame presentation for sole Vertex / Edge / Wire
kgv [Thu, 22 Dec 2016 09:48:16 +0000 (12:48 +0300)]
0028180: Visualization, TKOpenGl - Performance of Shaded presentation dropped due to FFP disabled by default
FFP state management (light sources, matrices, clipping planes) has been
moved to OpenGl_ShaderManager for consistency with Programmable Pipeline.
OpenGl_Context::BindProgram() does not re-bind already active Program.
OpenGl_PrimitiveArray::Render() does not reset active Program at the end.
OpenGl_Context::ApplyModelViewMatrix() now checks if matrix differs
from already set one before modifying state in Shader Manager.
This allows avoing redundant state changes, matrix uploads onto GPU
and re-computation of inversed matrices.
NCollection_Mat4 has been extended with equality check operators for proper comparison.
OpenGl_ShaderManager - the tracking Material state has been added.
Removed unreachable states OPENGL_NS_RESMAT, OPENGL_NS_TEXTURE and OPENGL_NS_WHITEBACK.
Fixed resetting FFP material state after displaying GL_COLOR_ARRAY vertices;
the Material state within Shader Manager is now
invalidated within OpenGl_VertexBuffer::unbindFixedColor().
OpenGl_Workspace::ApplyAspectFace() - fixed invalidating Material State
when only Highlighting style is changing.
isk [Fri, 9 Dec 2016 10:50:40 +0000 (13:50 +0300)]
0028205: Visualization - add functionality for dumping results of detection algorithms into image
StdSelect_ViewerSelector3d::ToPixMap() - added new method for dumping
detection results into an image.
dbp [Mon, 19 Dec 2016 11:00:09 +0000 (14:00 +0300)]
0028241: Visualization, Path tracing - shader compilation error on Radeon 290
msv [Thu, 22 Dec 2016 09:43:48 +0000 (12:43 +0300)]
0028221: General Fuse operation error
The method BOPTools_AlgoTools2D::AttachExistingPCurve has been corrected so that
to call BRepLib::SameParameter not on the target edge with the whole set of pcurves,
but rather on a temporary edge with 3D curve and copied pcurve only.
After that the updated pcurve is transferred to the target edge.
Small correction of test case for issue CR28221
abv [Sun, 18 Dec 2016 06:21:54 +0000 (09:21 +0300)]
0028240: Avoid redundant search for span index in evaluation of BSpline cache
ski [Thu, 22 Dec 2016 09:40:55 +0000 (12:40 +0300)]
0028204: TopoTools_ShapeSet::Dump() does not show flag Locked
Corrected command dump to show flag Locked for shapes in DRAW.
Test case for issue CR28204
Updated test case.
kgv [Thu, 22 Dec 2016 09:39:13 +0000 (12:39 +0300)]
0028004: Visualization, AIS_ColorScale - allow defining labels list not equal to intervals list
Cosmetics, code clean up.
AIS_ColorScale now draw labels using Graphic3d_VTA_CENTER
vertical alignment flag, instead of incorrect own alignment logic.
The color bar now adds margin on the top simmetrical to the bottom.
AIS_ColorScale::SetSmoothTransition() - added new property
for displaying colorscale with smooth transition between color intervals.
AIS_ColorScale::SetHueRange() - added new property defining the hue angles
corresponding to minimal and maximum values on the color scale.
AIS_ColorScale::SetLabels() now allows setting the sequence of free labels,
which number does not match the number of intervals.
In this case the labels will be displayed at positions of virtual
intervals corresponding to the number of labels.
msv [Wed, 14 Dec 2016 07:09:38 +0000 (10:09 +0300)]
0028183: Modeling - BRepExtrema_DistShapeShape does not find all solutions
Disable SetSingleSolutionFlag when calling algorithm of curve-curve Extrema.
Now DistShapeShape will find all solutions, even if they are located on the same pair of edges.
The fix brings the speed down for the cases of coinciding curves.
msv [Fri, 16 Dec 2016 14:13:07 +0000 (17:13 +0300)]
0028233: lvarpop is needed for correct work of lmatch defined in StandardCommands.tcl
The proc lvarpop has been implemented.
apn [Fri, 16 Dec 2016 09:20:05 +0000 (12:20 +0300)]
Added procedure lmatch for test case in branch CR28196_1
apn [Fri, 16 Dec 2016 09:17:19 +0000 (12:17 +0300)]
Warnings is IntPatch_ImpImpIntersection_4.gxx on unix platforms and in ViewerTest.cxx on win32 vc14 were eliminated
msv [Fri, 16 Dec 2016 08:59:13 +0000 (11:59 +0300)]
0028017: Unexpected result of General Fuse operation
Several improvements have been made in BO code to fix the bug:
- Create empty edge-edge interference if intersection is close to an end vertex. This will help to avoid creation of unnecessary edge-face intersections.
- Improve PutPaveOnCurve() method to join nearly located vertices when they are put on the same section curve.
- Add processing of same-domain vertices for section edges in UpdatePaveBlocks() method.
- Improve the method CorrectWires() in order to not increase vertex tolerance if it will cover the major part of an edge.
- Replace vertices of section edges by same-domain equivalents.
- In the algorithm BOPAlgo_WireSplitter, correct angles computation and evaluation, taking into account periodicity.
- Modify PostTreatFF to properly take into account the orientations of coinciding section edges.
- In IntTools_Context::ComputePE, check distance from the point to vertices of the edge if the projection to the curve is failure.
Tests update:
- test offset\faces_type_i\C9 has been updated; now instead of returning bad shape it returns null result.
Notes for porting:
- Modify BopAlgo_PaveFiller so that on output each interference refers to the new vertex that will hit in the result (same-domain of the initial new vertex).
- Make the method BOPDS_DS::Index() returning valid index for new shapes.
// eliminate compile warning on VC14
abk [Tue, 6 Dec 2016 18:42:11 +0000 (21:42 +0300)]
Test for
0028196: Algorithm 'Extrema_GenLocateExtPS' failed to find the extremum in a case
Draw command 'proj' has been improved:
- Add possibility to pass the starting point. If it is passed than the algorithm Extrema_GenLocateExtPS is used instead of standard projection.
- Make the output of the command more clear.
Test case bugs/moddata_3/bug28196 has been added.
kgv [Wed, 2 Nov 2016 14:36:18 +0000 (17:36 +0300)]
0025695: Visualization, AIS_InteractiveContext - define default HilightMode
AIS_InteractiveContext - removed the following unused properties:
- PreSelectionColor(), DefaultColor(), WasCurrentTouched(), ZDetection().
AIS_InteractiveObject - removed unused property SelectionPriority().
Prs3d_Drawer - removed properties HighlightStyle() and SelectionStyle().
Graphic3d_HighlightStyle has been superseded by Prs3d_Drawer
inheriting from new class Graphic3d_PresentationAttributes.
Graphic3d_PresentationAttributes (as Graphic3d_HighlightStyle replacement)
has been extended with new properties:
- ZLayer() defining Z-Layer for highlighting presentation.
- DisplayMode() defining display mode for highlighting.
StdSelect_BRepSelectionTool methods have been corrected to take
SelectMgr_EntityOwner instead of StdSelect_BRepOwner.
StdSelect_Shape - duplicated field myDrawer has been dropped.
AIS_InteractiveObject - myDrawer->Color() is now used instead of myOwnColor,
myDrawer->Transparency() instead of myTransparency
and myDrawer->ZLayer() instead of myZLayer.
PrsMgr_PresentationManager::Unhighlight() now unhighlight all modes.
The method taking Mode as argument has been marked deprecated.
New enumeration Prs3d_TypeOfHighlight has been introduced
defining different highlight types.
AIS_InteractiveObject::HighlightStyle() now takes enumeration argument
and defines different styles for Global and Local selection.
ComesFromDecomposition() property has been moved
from StdSelect_BRepOwner to SelectMgr_EntityOwner.
isk [Mon, 28 Nov 2016 09:11:43 +0000 (12:11 +0300)]
0028162: Draw Harness - eliminate usage of deprecated Local Context
Create a general draw command 'VRelation' and drop the old 'relation' commands.
Add test cases for new draw command "vrelation".
Add two new methods: Activate and Deactivate which activate/deactivate the given selection mode for all displayed objects.
Eliminate deprecated local context methods in ObjectCommands, QABugs.
Eliminate deprecated local context methods in mfc standard sample and qt samples.
kgv [Mon, 12 Dec 2016 09:54:25 +0000 (12:54 +0300)]
0028213: Visualization, StdPrs_ShadedShape - compute face edges for triangulation-only Faces
kgv [Tue, 13 Dec 2016 09:36:41 +0000 (12:36 +0300)]
0028215: Visualization - define EMPTY type line for consistenct with Interior Style
Added new values Aspect_TOL_EMPTY (line type) and Aspect_TOM_EMPTY (marker type).
aml [Thu, 15 Dec 2016 13:32:52 +0000 (16:32 +0300)]
0028175: Bad result of curve-curve extrema
Extrema between curves has been made producing correct result for the cases of solution located near bounds.
- Class math_GlobOptMin has been improved to use lower order methods of local optimization when high-order methods are failed.
- Add support of conditional optimization (in bounds) in the classes math_BFGS and math_BracketMinimum.
- Turn on conditional optimization in the case of usage of math_BFGS in the class math_GlobOptMin.
- Correct mistake in distmini command, which caused incorrect reading of deflection parameter.
- To avoid possible FPE signals, ensure initialization of fields in the class math/math_BracketMinimum.
- In the algorithms math_BFGS, math_Powell and math_FRPR, take into account that the function math_MultipleVarFunction can return failure status (e.g. when computing D0 out of bounds).
New test cases have been added.
Tests cases are updated.
// correct test case
vpa [Tue, 15 Nov 2016 18:05:52 +0000 (21:05 +0300)]
0028107: Visualization - provide a flexible interface to set custom hatch styles
- class Graphic3d_HatchStyle is added to provide a possibility to set up custom and predefined hatching;
- added the ability to set custom hatch patterns through bitmaps;
- test case for issue #28107
aml [Fri, 9 Dec 2016 15:15:58 +0000 (18:15 +0300)]
0028201: Add square PConfusion() method to the Precision class
Method SquarePConfusion has been added to simplify code.
nbv [Thu, 24 Nov 2016 12:07:52 +0000 (15:07 +0300)]
0025187: Document the algorithm used in the fixes for issues ##
0024915 and 25194
1. Algorithm of orthogonalize of the transformation matrix (in gp_Trsf(2d) classes) has been documented.
2. Algorithm of computation of intersection line in case of two intersected cylinders (implemented in the fix for issue #24915) has been documented. Additionally, I would like to tell about some advantages of new algorithm in compare with old one.
2.1. Both algorithm generates intersection points for Walking-line (WL), which will be approximated to B-spline curve(s) in the future. At that, new algo (in compare with old one) uses another method for step computation. It based on attempts to provide equal steps (if it is possible) along V-direction (instead of U-direction used in old algorithm). It allows obtaining set of points, which are more uniform distributed in compare with old algo (this problem is the main reason why case #24915 was failed). Of course, we will get non-uniform distribution along U-direction. However, it can be compensated by small range (its length is less or equal 2*PI) of U-parameter change, whereas range of V-parameter can be very big.
2.2. More simple estimation of curvature "jump". New algo aims at provide equidistant distribution of points along V-direction. If it requires "jump" of U-parameter then we have "jump" of curvature in this point. This check is implemented in function AddPointIntoWL(...) (see place where SeekAdditionalPoints(...) is called).
However, in OCCT 7.1.0, curvature jumping is analyzed (it was not earlier, when the bug #24915 was fixed) - see fix for issue #27431.
2.3. New algorithm allows obtaining 7D-intersection point immediately. At that, old algorithm computed only 2D-intersection point (on some one surface). After that, it computed 3D-intersection point and, finally, projected(!) 3D-point to the second surface in order to obtain second 2D-intersection point. This second projection results in some problems. One problem is described in the issue #27968 (see message ~
0058807). Second problem is the process of cases with singularity (significant improvement in this direction has been made in the fix #27431). Third problem is difficulties in projection itself (e.g. if we project point to a sphere when V-coordinate of the projection is near to PI/2 - projection point is found but not precise; the reason is not singularity but small radius of V-isoline).
Method used in new algorithm allows avoiding these problems. However, at present, it is implemented for case of two cylinders intersection (where most of these problems are not actual).
2.4. Algorithm of search of intersection point on surface boundary(ies) has been changed, too. Old algorithm sought point on boundary irrespective of intersection line. It resulted in problems described in the issue #27252 and related. New algorithm looks for intersection point of intersection line with surface boundary. It requires rectangular domain. However, it is not problem for current OCCT-version.
kgv [Thu, 8 Dec 2016 15:16:14 +0000 (18:16 +0300)]
0028202: Coding rules - eliminate compiler warnings on HLRAlgo.hxx
Redundant forward declarations have been removed from HLRAlgo.hxx.
aml [Fri, 9 Dec 2016 10:11:34 +0000 (13:11 +0300)]
Warnings in BRepOffset_SimpleOffset.cxx on vc14 were eliminated
kgv [Mon, 5 Dec 2016 09:57:27 +0000 (12:57 +0300)]
0028186: Foundation Classes, NCollection_List - methods "Remove" and "Contains" prevent template usage
::Remove() and ::Contains() are now defined as template methods
to allow using NCollection_List with types without quality operator.
aka [Tue, 6 Dec 2016 09:06:15 +0000 (12:06 +0300)]
0028193: missing "Standard_EXPORT"
missing "Standard_EXPORT" for "SetFuzzyValue" and "FuzzyValue" in IntTools_FaceFace was added
emv [Tue, 6 Dec 2016 08:12:22 +0000 (11:12 +0300)]
0028191: Inefficient implementation of the BRepOffset_Tool::HasCommonShapes() method
The method to find common Vertices and Edges between faces
BRepOffset_Tool::HasCommonShapes(const TopoDS_Face&,
const TopoDS_Face&,
TopTools_ListOfShape&,
TopTools_ListOfShape&)
has been re-implemented using maps and renamed to BRepOffset_Tool::FindCommonShapes.
The new method
BRepOffset_Tool::FindCommonShapes(const TopoDS_Shape&,
const TopoDS_Shape&,
const TopAbs_ShapeEnum,
TopTools_ListOfShape&)
has been implemented to look for the common shapes of given type.
emv [Mon, 5 Dec 2016 12:52:36 +0000 (15:52 +0300)]
0028187: Add possibility to avoid creation of Internal parts in the result of Volume maker algorithm
1. The possibility to prevent addition of internal parts has been added into the following algorithms:
- BOPAlgo_BuilderFace;
- BOPAlgo_BuilderSolid;
- BOPAlgo_MakerVolume.
Setting the option to avoid internal parts for MakerVolume algorithm guarantees that the result solids
will be manifold and not contain any internal parts. But it does not prevent from occurrence
of the internal edges or vertices in the faces.
2. The Set/Get methods of the BOPAlgo_BuilderArea class have been made inline.
3. Draw command mkvolume has been updated to take into account the new option.
4. BRepOffset_MakeOffset::BuildShellsCompleteInter() has been modified to use the new option of BOPAlgo_MakerVolume
to speed up the construction of the final result solid.
5. Documentation has been updated with new section dedicated to BOPAlgo_MakerVolume algorithm.
6. Test case for the issue.
kgv [Mon, 5 Dec 2016 10:53:37 +0000 (13:53 +0300)]
0028181: Documentation - update porting note with missing information
Added information about removed classes StdPrs_WFDeflectionShape,
Prs3d_WFShape, StdPrs_ToolShadedShape and removed property
AIS_InteractiveObject::SelectionMode().
emv [Wed, 30 Nov 2016 10:29:37 +0000 (13:29 +0300)]
0028165: Improve performance of Boolean Operations
1. Unification of the usage of the BRepAdaptor_Surface in Boolean Operations algorithm.
For each face when it is necessary the Adaptor is initialized only once and stored in Context.
For that purpose the new IntTools_Context::SurfaceAdaptor(const TopoDS_Face&) method has been implemented.
To provide possibility to take the Adaptor from the context, the context has been added as
a parameter in following methods:
BOPTools_AlgoTools::MakePCurve()
BOPTools_AlgoTools::Sence()
BOPTools_AlgoTools2D::BuildPCurveForEdgeOnFace()
BOPTools_AlgoTools2D::PointOnSurface
BOPTools_AlgoTools2D::CurveOnSurface
BOPTools_AlgoTools2D::AdjustPCurveOnFace
BOPTools_AlgoTools2D::Make2D
BOPTools_AlgoTools2D::MakePCurveOnFace
BOPTools_AlgoTools3D::GetNormalToFaceOnEdge
It is also possible now to pass the context into BOPAlgo_WireSplitter algorithm.
Also, the new IntTools_Context::UVBounds(const TopoDS_Face&) method
has been implemented to get the UV bounds of a face.
2. Additional improvement is a calculation of reduced intersection range only for the intersection
type VERTEX during computation of Edge/Face interference.
3. The methods IntTools_EdgeFace::Prepare() and IntTools_EdgeFace::FindProjectableRoot()
and the fields IntTools_EdgeFace::myProjectableRanges and IntTools_EdgeFace::myFClass2d
have been removed as obsolete.
4. Test cases for the issue.
emv [Thu, 8 Dec 2016 13:49:29 +0000 (16:49 +0300)]
0027878: Development of the Gluing operations based on the new Boolean component
The Gluing operation is an additional option for the algorithms in the Boolean Component
such as General Fuse, Boolean operations, Section operation, Maker Volume and Cells Builder algorithms.
The Gluing options have been designed to speed up the computation of the interference among arguments of the operations on special cases,
in which the arguments may be overlapping but do not have real intersections between their sub-shapes.
This option cannot be used on the shapes having real intersections, like intersection vertex between edges,
or intersection vertex between edge and a face or intersection line between faces.
The Gluing option is an enumeration implemented in BOPAlgo_GlueEnum.hxx. There are following items in the enum:
* BOPAlgo_GlueOff - default value for the algorithms, Gluing is switched off;
* BOPAlgo_GlueShift - Glue option for shapes with partial coincidence;
* BOPAlgo_GlueFull - Glue option for shapes with full coincidence.
For setting the Gluing options for the algorithm it is just necessary to call the SetGlue(BOPAlgo_GlueEnum) method with appropriate Glue value.
For using this option in DRAW the command bglue has been implemented:
* 0 - default value, Gluing is off;
* 1 - for partial coincidence;
* 2 - for full coincidence
Elimination of the warnings.
dbp [Fri, 18 Nov 2016 08:13:29 +0000 (11:13 +0300)]
0028126: Visualization, Path tracing - Provide ability to use two-sided scattering models
aka [Thu, 8 Dec 2016 13:33:47 +0000 (16:33 +0300)]
0027434: Wrong result of classification of the point in "infinity"
In the case of infinite point due to not enough machine precision the distance from the point to each edge of the face is computed the same, and the algorithm cannot correctly select the nearest edge. To solve this problem checking of point was added, if the point is located too far from the bounding box of the face, then it will be replaced with another point located on the line between the point and the center of the bounding box.
The new point has the same state as initial one but its state can be resolved without ambiguity.
Corrections in CheckPoint method
Small correction of test case for issue CR27434
aml [Thu, 8 Dec 2016 13:30:24 +0000 (16:30 +0300)]
0027954: Create topology-preserving offset computation algorithm
New topology-preserving offset algorithm has been added. It allows to construct offset shape of build solid.
test cases have been added.
Documentation has been updated to be up to date.
Minor corrections.
Grid is renamed for simplification purposes.
Old constructors are restored with Standard_DEPRECATED macros.
emv [Fri, 18 Nov 2016 07:06:50 +0000 (10:06 +0300)]
0028163: 3D Offset algorithm produces incorrect result on attached shape in mode Complete Intersection
1. Correct building of the lists of intersection faces connected to the same vertex.
2. For the artificially invalid cases with only one invalid face avoid usage of the edges having same origins as invalid edges.
3. Test cases for the issue.
4. Test cases offset shape_type_i_c XM1, ZW*,ZX*,ZY* have been modified to provide more clear result.
5. TODO statements have been removed from the test case offset shape_type_i_c XE6 as it is OK.
6. Test case offset shape_type_i_c ZZ2 is improvement.
anv [Thu, 8 Dec 2016 13:24:34 +0000 (16:24 +0300)]
0026026: XtControl_Reader hangs when processing specific data
Small fix for a specific case (was missing).
aka [Thu, 8 Dec 2016 13:22:13 +0000 (16:22 +0300)]
0027674: BRepOffsetAPI_ThruSections make invalid shape if sections are connected at ends
The edge which will be created between same vertexes should be degenerated and without 3d curve.
Small correction of test case for issue CR27674
apn [Thu, 8 Dec 2016 13:19:55 +0000 (16:19 +0300)]
Change OCCT version to 7.1.1 and define OCC_VERSION_DEVELOPMENT to "dev"
msv [Fri, 25 Nov 2016 09:40:25 +0000 (12:40 +0300)]
0027033: Modeling -- ensure stable result of area calculation
The method BRepGProp_Face::LKnots has been corrected to make proper initialization of the output data for the case of a circle.
Added test case bugs/modalg_6/bug27033
ski [Wed, 23 Nov 2016 07:24:20 +0000 (10:24 +0300)]
0025362: Samples - Conversion to B-Spline doesn't show bspline surface on Windows 8
Added constants WM_MOUSEFIRST and WM_PAINT in WaitForInput method for correct handling of system messages.
apn [Thu, 24 Nov 2016 09:00:58 +0000 (12:00 +0300)]
Fix warning on vc14
apn [Thu, 24 Nov 2016 08:57:08 +0000 (11:57 +0300)]
Modify test case bugs/mesh/bug28118
apn [Wed, 23 Nov 2016 16:35:15 +0000 (19:35 +0300)]
Incrementation of OCCT version up to 7.1.0
apn [Wed, 23 Nov 2016 16:33:47 +0000 (19:33 +0300)]
Modify test cases according using imagedir folder for saving tmp files
gka [Wed, 23 Nov 2016 16:31:02 +0000 (19:31 +0300)]
0028118: Mesh generation hangs then crashes
Protection against hangs of mesh and crash(made by epa)
Added test case bugs/mesh/bug28118
Tests mesh* standard_* W7 are corrected (TODO removed)
apn [Wed, 23 Nov 2016 15:07:21 +0000 (18:07 +0300)]
0026450: Boolean operation is running endless
Added test case bugs/modalg_6/bug26450
kgv [Wed, 23 Nov 2016 12:53:48 +0000 (15:53 +0300)]
0028147: Data Exchange - NULL dereference while reading color from STEP file
StepVisual_StyledItem::Item() now does not call IsKind() on NULL object.
Add several checks for NULL to import/export.
Add test case bugs/step/bug28147
msv [Mon, 21 Nov 2016 08:24:23 +0000 (11:24 +0300)]
0025920: BRepAlgoAPI_Fuse makes invalid result
The command OCC426 for test case bugs modalg_2 bug426 has been modified in order to make the test passed. The modification concerns only the old Boolean operation branch (BRepAlgo_Fuse).
gka [Tue, 22 Nov 2016 13:20:36 +0000 (16:20 +0300)]
0028143: In the method ShapeFix_Edge::FixAddPCurve initialized by face location of face is not taking into account.
Class ShapeAnalysis::Surface is initialized by transformed surface in the method
ShapeFix_Edge::FixAddPCurve (const TopoDS_Edge& edge,const TopoDS_Face& face, const Standard_Boolean isSeam, const Standard_Real prec) in the case when face has location.
ski [Fri, 11 Nov 2016 14:00:25 +0000 (17:00 +0300)]
0028077: Add option for genproj to generate UWP projects
Ability to generate UWP solution was added to genproj command, applied when VC version set to "vc14-uwp".
Environment variables are used to find installed Microsoft SDKs.
Visual Studio project option "Use precompiled headers" is set to "Not Using" by default.
Character set option of VS project Unicode is used instead of preprocessor definitions for UWP projects.
mkv [Tue, 22 Nov 2016 16:22:56 +0000 (19:22 +0300)]
0028146: Data files with the same content in test cases
Names of used shapes were corrected in test cases
aiv [Mon, 21 Nov 2016 15:23:28 +0000 (18:23 +0300)]
0028038: Incorrect documentation generated for "user guides/BRep Format"
References to external MathJax.js library were changed from HTTP to HTTPS alternative.