16 months ago0030682: Configuration, qmake - all warnings are suppressed on macOS target
kgv [Mon, 29 Apr 2019 15:24:36 +0000]
0030682: Configuration, qmake - all warnings are suppressed on macOS target

Fixed inconsistency of compiler flags with genproj.
warn_on+QMAKE_CXXFLAGS_WARN_ON is now used instead of warn_off+QMAKE_CXXFLAGS.
Added No_Exception to DEFINES.

16 months ago0030681: Configuration - suppress OpenGL deprecation warning on macOS 10.14
kgv [Mon, 29 Apr 2019 15:43:14 +0000]
0030681: Configuration - suppress OpenGL deprecation warning on macOS 10.14

Define GL_SILENCE_DEPRECATION to suppress warnings.

16 months ago0030672: Visualization - AIS_InteractiveContext::SetLocation() sets invalid selection... IR-2019-04-26
kgv [Wed, 24 Apr 2019 06:16:19 +0000]
0030672: Visualization - AIS_InteractiveContext::SetLocation() sets invalid selection BVH flag to removed object

SelectMgr_SelectionManager::Remove() now deactivates selection before removal.

16 months ago0030669: Visualization - AIS_Manipulator ignores parent transformation IR-WEEK17
kgv [Wed, 24 Apr 2019 15:50:29 +0000]
0030669: Visualization - AIS_Manipulator ignores parent transformation

AIS_Manipulator::Transform() now considers object parent transformation.

Added new command vchild for easier testing of low-level connections between presentations.

16 months ago0030674: Visualization, AIS_InteractiveObject - fix accessibility of several properties
kgv [Thu, 4 Apr 2019 06:44:16 +0000]
0030674: Visualization, AIS_InteractiveObject - fix accessibility of several properties

- added missing getters;
- removed redundant private sections;
- improved documentation;
- AIS_InteractiveObject::Compute() marked as pure interface;
- methods within this hierarchy have been moved to the base class, when reasonable.

Removed redundant typedefs to pointers (PrsMgr_PresentationPointer, PrsMgr_PresentableObjectPointer).

16 months ago0030652: Configuration, genproj - reuse PRODUCTS_PATH within generated custom.bat
kgv [Tue, 16 Apr 2019 19:46:43 +0000]
0030652: Configuration, genproj - reuse PRODUCTS_PATH within generated custom.bat

genconfdeps.tcl now puts %PRODUCTS_PATH%/$PRODUCTS_PATH into generated custom.bat/custom.sh scripts.
Added missing CSF_winmm definition to OccToolkit.pri

16 months ago0030645: Modeling Algorithms - B-spline segmentation produces wrong parametrization
azv [Sat, 13 Apr 2019 11:57:39 +0000]
0030645: Modeling Algorithms - B-spline segmentation produces wrong parametrization

Method Segment() of B-spline curve and surface has been extended by parameter theTolerance (theUTolerance and theVTolerance for surface), which defines the proximity between knots of a NURBS and boundaries of cutting segment. The default value of the tolerance is Precision::PConfusion().
Test cases have been added to check segmenting of B-spline surface and curves both 2D and 3D.

16 months ago0030621: Implementation of building U-periodical surfaces.
ifv [Fri, 29 Mar 2019 12:20:27 +0000]
0030621: Implementation of building U-periodical surfaces.

draw_test_harness.md - description of new options in Draw commands

AppDef_BSplineCompute.hxx, BRepApprox_TheComputeLineOfApprox.hxx, GeomInt_TheComputeLineOfWLApprox.hxx, Approx_BSplComputeLine.gxx - implementation of method SetPeriodic(...) and implementation periodic boundary conditions for multiline in order to get periodic multicurve.

GeomAPI_PointsToBSplineSurface.hxx, GeomAPI_PointsToBSplineSurface.cxx - adding new parameter for methods Init(...) and Interpolate(...), implementation of building periodic tangents for first and last AppDef_MultiPointConstraint of multiline for U direction of surface.

GeometryTest_APICommands.cxx - implementation of new functionality in Draw command surfapp and surfint

Fixing problem with bugs modalg_3 bug606_2

16 months ago0030592: Draw Harness, ViewerTest - provide vbackground command unifying vsetbg,...
tiv [Mon, 22 Apr 2019 07:51:22 +0000]
0030592: Draw Harness, ViewerTest - provide vbackground command unifying vsetbg, vsetbgmode, vsetgradientbg, vsetgrbgmode, vsetcolorbg

A new command vbackground is created. Old background commands are made aliases for the newly created command (including vsetdefaultbg).
Tests are modified using newly added command vbackground.

16 months ago0030663: Visualization - synthesize italic style for a font having no italic style
vro [Fri, 19 Apr 2019 06:17:57 +0000]
0030663: Visualization - synthesize italic style for a font having no italic style

Font_FTFont now defines shear transformation to synthesize italic style for fonts having no such style.
Font_FontMgr::FindFont() and command "vfont -find" have been extended with -strict option
to check whether the given font is actually registered or not.
Font_FTFont::Init() - added constructor from memory buffer.
Second Font_FTFont::Init() override has been renamed to Font_FTFont::FindAndInit()
to avoid ambiguity between two similar methods taking full font path and font name as string.

17 months ago0030435: Improving performance of Approx_ComputeCLine
ifv [Thu, 10 Jan 2019 10:07:01 +0000]
0030435: Improving performance of Approx_ComputeCLine

1. Approx_ComputeCLine.gxx, Approx_FitAndDivide.hxx, Approx_FitAndDivide2d.hxx, BRepFill_ComputeCLine.hxx
It is base modification, which allows improve performance of approximation with help of Approx_ComputeCLine. The main idea of improvement is using degree selection by inverse order - from maxdegree to mindegree. If tolerance for maxdegree is not reached, there is no sense to make approximation for current number of knots with lower degree, it is necessary to cut parametric interval.

2. ProjLib_ComputeApprox, ProjLib_ComputeApproxOnPolarSurface, ProjLib_ComputeApproxOnPolarSurface, ProjLib_ProjectOnPlane
It is additional modification of methods using Approx_ComputeCLine.
Mainly, modifications concern to more optimal choosing parameters for approximation algorithm.

3. BRepCheck_Face
Small improvement of method Intersect(...), which intersects two wires on face.

4. BRepTopAdaptor_FClass2d
Impovement of treatment infinitely narrow faces.

5. ChFi3d/ChFi3d_Builder_6.cxx
Small improvement, which forbids extension of singular boundary of surface.
It was TODO problem in tests/bugs/modalg_7/bug27711_3

6. IntTools_EdgeEdge.cxx
Improvement of performance for cases of searching common parts between line  and analytical curve

7. GeomliteTest_CurveCommands.cxx
Adding Draw command fitcurve. This command is analog of approxcurve, but uses Approx_FitAndDivide algorithm.
Mainly to have direct draw command for testing Approx_ComputeCLine.

8. Extrema_ExtElC.cxx

Treatment of case "infinite solutions" for extrema line-ellipse

9. Modification of some tests according to new behavior of algorithm.

10. tests/perf/moddata/bug30435
Test for new improved algorithm.

11. Implementation QAcommand OCC30435 in QABugs_20.cxx used in test bug30435

17 months ago0030657: Visualization - misprint in Graphic3d_ZLayerSettings::SetOrigin() IR-2019-04-19
kgv [Wed, 17 Apr 2019 19:23:51 +0000]
0030657: Visualization - misprint in Graphic3d_ZLayerSettings::SetOrigin()

Add missing initialization of Geom_Transformation object.

17 months ago0030644: Coding - inline trivial methods of V3d_View class
kgv [Wed, 17 Apr 2019 11:58:35 +0000]
0030644: Coding - inline trivial methods of V3d_View class

17 months ago0030550: Coding - Integer overflow in Standard_CString HashCodes IR-WEEK16-1
tiv [Thu, 28 Mar 2019 09:42:41 +0000]
0030550: Coding - Integer overflow in Standard_CString HashCodes
0030551: Foundation Classes - Integer overflow in NCollection_CellFilter HashCode

Signed integers are not used in hash code functions now to prevent undefined behavior on left shift operations with signed integers.
A possibility of negative values of hash codes is eliminated.
INT_MAX → IntegerLast() in hash code functions.
All found hash code functions behaves uniformly now: they return a value in the range [1, theUpperBound]. Relevant comments are added to such functions.

17 months ago0030647: Geom2dGcc_Circ2d2TanRad not giving all the solutions
ifv [Mon, 15 Apr 2019 09:47:08 +0000]
0030647: Geom2dGcc_Circ2d2TanRad not giving all the solutions

Method for calculation of correct number of sampling points is added for
Now number of sampling points correspond with similar method for
Geom2dAdaptor_Curve for curve type GeomAbs_OffsetCurve
Test case added

17 months ago0030623: Draw Harness - support hex color codes within ViewerTest::ParseColor() IR-2019-04-13
tiv [Fri, 12 Apr 2019 07:45:25 +0000]
0030623: Draw Harness - support hex color codes within ViewerTest::ParseColor()

ViewerTest::ParseColor() function is improved to be able to parse the following set of input arguments:
  - "Red Green Blue [Alpha]", where Red, Green, Blue, Alpha must be integers within the range [0, 255] or reals within the range [0.0, 1.0]. Note that "0 0 1" triple is parsed as "0.0 0.0 1.0" and will be interpreted as a blue color.
  - "ColorName [Alpha]", where ColorName is one of WHITE, BLACK, RED, GREEN, BLUE, etc. (look at Quantity_NameOfColor enumeration for all possible variants). Alpha may be integer or real, as described at the previous list item.
  - #HHH, [#]HHH[H], [#]HHHHHH[HH], where H is a hexadecimal digit (0 .. 9, a .. f, or A .. F). There are a short hexadecimal RGB, RGBA formats, and a usual RGB[A], respectively.

17 months ago0030597: BRepOffsetAPI_MakePipeShell raises Standard_RangeError
jgv [Tue, 2 Apr 2019 11:14:00 +0000]
0030597: BRepOffsetAPI_MakePipeShell raises Standard_RangeError

Constructor of GeomFill_SectionPlacement has been corrected: add correction of boundaries of curve to avoid mistake of LocateU in the case when the curve is BSpline.

17 months ago0030643: Visualization, Ray-Tracing - shader compilation errors are not properly...
kgv [Tue, 9 Apr 2019 13:25:29 +0000]
0030643: Visualization, Ray-Tracing - shader compilation errors are not properly logged

OpenGl_View::initShader() now uses OpenGl_ShaderObject::LoadAndCompile().

17 months ago0030612: Visualization - provide texture map with video as image source
kgv [Wed, 27 Mar 2019 21:57:17 +0000]
0030612: Visualization - provide texture map with video as image source

Introduced package Media wrapping FFmpeg structures.
Media_PlayerContext class manages video decoding into Media_IFrameQueue interface.
Graphic3d_MediaTextureSet implements Media_IFrameQueue interface and can be used as texture source.
AIS_MediaPlayer implements simple AIS object displaying video.

17 months ago0030638: Visualization, TKOpenGl - load OpenGL 4.5 functions within OpenGl_Context
kgv [Mon, 8 Apr 2019 15:03:34 +0000]
0030638: Visualization, TKOpenGl - load OpenGL 4.5 functions within OpenGl_Context

17 months ago0030635: Visualization - move OpenGl_Layer to Graphic3d_Layer
kgv [Mon, 8 Apr 2019 13:22:20 +0000]
0030635: Visualization - move OpenGl_Layer to Graphic3d_Layer

Renamed classes (moved from TKOpenGl to TKV3d):
- OpenGl_Layer -> Graphic3d_Layer;
- OpenGl_BVHClipPrimitiveSet -> Graphic3d_BvhCStructureSet;
- OpenGl_BVHClipPrimitiveTrsfPersSet -> Graphic3d_BvhCStructureSetTrsfPers;
- OpenGl_BVHTreeSelector -> Graphic3d_CullingTool.

Method OpenGl_Layer::Render() has been moved to OpenGl_LayerList::renderLayer().

Standard Z-layers list definition has been moved
from OpenGl_GraphicDriver to base class Graphic3d_GraphicDriver.

17 months ago0030636: Configuration, qmake - unable to build using VS2017
kgv [Mon, 8 Apr 2019 13:55:12 +0000]
0030636: Configuration, qmake - unable to build using VS2017

17 months ago0030629: Modeling Algorithms - Invalid result of fuse operation
emv [Thu, 4 Apr 2019 06:59:24 +0000]
0030629: Modeling Algorithms - Invalid result of fuse operation

Plane/Torus intersection: take into account the Plane-Torus distance sign to compute the correct location of the section curve.

Test case for the issue.

17 months ago0030618: Modeling Algorithms, BOPTools_Parallel - avoid using map for thread-local...
kgv [Thu, 28 Mar 2019 21:14:36 +0000]
0030618: Modeling Algorithms, BOPTools_Parallel - avoid using map for thread-local contexts without TBB

OSD_Parallel::ToUseOcctThreads() - new flag allowing to use OCCT threads implementation even when compiled with TBB (for testing).
Added new command dparallel for managing default Thread Pool.
OSD_Parallel::For() now avoid creation of universal iterator in simplest case.

BOPTools_Parallel - eliminated redundant typedefs/explicit instantiations of templates.
Added functor using array of per-thread context instead of a map.

17 months ago0030339: Configuration - add project files for qmake IR-2019-04-05
kgv [Mon, 1 Apr 2019 20:44:20 +0000]
0030339: Configuration - add project files for qmake

Added adm/qmake/Occt.pro for building OCCT using Qt Creator.
genproj/genconf scripts have been extended with an option defining project format.

Draw_Appli now tries resolving CASROOT/DRAWDEFAULT/CSF_OCCTResourcePath/CSF_OCCTSamplesPath
locations within usual OCCT development/installation environment.
Added missing TKShHealing dependency to TKDraw/DRAWEXE (inherited from TKMesh).
OSD_Process::ExecutableFolder() - added method returning executable folder.

17 months ago0030626: Visualization - manipulator crashes when is attached with scaling mode disabled IR-WEEK14
iko [Tue, 2 Apr 2019 10:58:32 +0000]
0030626: Visualization - manipulator crashes when is attached with scaling mode disabled

AIS_Manipulator crashes on SetPart method when 2 inputs (AIS_ManipulatorMode, Standard_Boolean) has been fixed up.
Test case for this bug has been added.

17 months ago0030616: Crash on reading STEP file
gka [Thu, 28 Mar 2019 15:25:20 +0000]
0030616: Crash on reading STEP file

Added protections to avoid exceptions for null objects.
For reading entity StepShape_ToleranceValue was added reading lower and upper bounds represented by entities "StepRepr_ReprItemAndMeasureWithUnit" or "StepRepr_MeasureRepresentationItem"

17 months ago0030622: Visualization, TKOpenGl - Path Tracing fails on macOS
kgv [Fri, 29 Mar 2019 17:46:39 +0000]
0030622: Visualization, TKOpenGl - Path Tracing fails on macOS

Fixed usage of non-existing function texture2D().

17 months ago0030619: Draw Harness, ViewerTest - add continuous rendering option to vrepaint command
kgv [Thu, 28 Mar 2019 15:36:54 +0000]
0030619: Draw Harness, ViewerTest - add continuous rendering option to vrepaint command

Aspect_Window::InvalidateContent() - added new virtual method for invalidating window content using platform-specific API.

TKDraw, tkLoop() on Window platform has been changed so that to prevent
continuous input window events blocking terminal input
(e.g. in case if processing events is not fast enough or
if another continuously sends new events).

TKViewerTest, on X11 platform has been fixed a message processing
so that to avoid messages being not processed.
Added aggregation of Exposer and ConfigureNotify events.
Fixed aggregation MotionNotify events.

17 months ago0030611: Coding Rules - eliminate GCC compiler warnings -Wcatch-value
kgv [Sun, 31 Mar 2019 20:38:14 +0000]
0030611: Coding Rules - eliminate GCC compiler warnings -Wcatch-value

Add missing const& to catch statements.

17 months ago0030579: Draw Harness, Draw_Interpretor - catch exceptions other than Standard_Failure IR-2019-03-29 IR-WEEK13
kgv [Fri, 15 Mar 2019 10:15:18 +0000]
0030579: Draw Harness, Draw_Interpretor - catch exceptions other than Standard_Failure

17 months ago0030574: Configuration, genproj - CSF_DEFINES is not reset at the beginning of env.bat
kgv [Thu, 14 Mar 2019 19:17:19 +0000]
0030574: Configuration, genproj - CSF_DEFINES is not reset at the beginning of env.bat

env.bat now resets %CSF_DEFINES% variable to empty state
and append optional %CSF_DEFINES_EXTRA% external value.

17 months ago0030556: Coding - IGESData_GlobalSection missing member initialization in default...
kgv [Tue, 12 Mar 2019 01:51:41 +0000]
0030556: Coding - IGESData_GlobalSection missing member initialization in default constructor

IGESData_GlobalSection now initializes class fields.

17 months ago0030505: Volume Rendering - Deferred lighting
iko [Wed, 20 Mar 2019 09:30:48 +0000]
0030505: Volume Rendering - Deferred lighting

Missing getter for OpenGl_Texture::mySizedFormat has been added.

18 months ago0030522: Modeling Algorithms - BRepBuilderAPI_MakeWire produces different wires depen... IR-2019-03-22
emv [Tue, 26 Feb 2019 11:06:30 +0000]
0030522: Modeling Algorithms - BRepBuilderAPI_MakeWire produces different wires depending on the order of parameters

The following improvements have been implemented in BRepLib_MakeWire class to make it more reliable:
1. Quit adding edges of a wire into result if the current edges have not been added. Return NotDone status.
2. Allow merging not only bounding vertices (connected to only one edge) but also the middle ones, so the multi-connected vertices may appear in the result.

Test case for the issue.

18 months ago0030582: Coding - avoid defining references to properties of NULL objects
kgv [Fri, 15 Mar 2019 15:06:04 +0000]
0030582: Coding - avoid defining references to properties of NULL objects

Approx_SweepApproximation::Perform() now creates empty arrays.
GeomAdaptor_SurfaceOfRevolution::UTrim() - fixed No_Exception misuse.
StdPrs_ShadedShape - fixed defining an invalid reference to Poly_Triangulation::UVNodes().

BSplCLib::MovePoint() and BSplCLib::MovePointAndTangent() now take optional
weights parameter as pointer consistent to other methods like BSplCLib::BuildEval().

18 months ago0030489: Modeling Algorithms - BRepBuilderAPI_GTransform hangs
ifv [Tue, 12 Mar 2019 13:47:21 +0000]
0030489: Modeling Algorithms - BRepBuilderAPI_GTransform hangs

Approx_ComputeCLine.gxx - criterium to stop interval cutting is increased.
ProjLib_ProjectedCurve.cxx - fix regression for bugs modalg_5 bug25886
Other tests are modified according to current state of algorithm

18 months ago0030593: Modeling Algorithms - ShapeUpgrade_ShapeDivide::Perform() throws Standard_No...
kgv [Tue, 19 Mar 2019 08:24:21 +0000]
0030593: Modeling Algorithms - ShapeUpgrade_ShapeDivide::Perform() throws Standard_NoMoreObject

Added missing TopExp_Explorer::More() checks to ShapeUpgrade_ShapeDivide::Perform() and BRepCheck_Analyzer::Perform().

18 months ago0027316: Draw Harness - access violation on passing non-existing shape to XAddShape
kgv [Wed, 20 Mar 2019 05:53:41 +0000]
0027316: Draw Harness - access violation on passing non-existing shape to XAddShape

Add NULL check to XAddShape command.
Removed broken test case bugs/step/bug27316.

18 months ago0030583: Draw Harness - ignore cpulimit when Debugger is attached on Windows platform
kgv [Sat, 16 Mar 2019 08:25:47 +0000]
0030583: Draw Harness - ignore cpulimit when Debugger is attached on Windows platform

cpulimit now omits ExitProcess() when IsDebuggerPresent() returns TRUE.

18 months ago0030594: Data Exchange - access violation within IGESGeom_BSplineCurve constructor
kgv [Wed, 20 Mar 2019 06:50:52 +0000]
0030594: Data Exchange - access violation within IGESGeom_BSplineCurve constructor

Added NULL check.

18 months ago0023838: Modeling Data - Standard_OutOfRange in Geom_OffsetSurface::LocalDN (called...
kgv [Sat, 16 Mar 2019 13:08:27 +0000]
0023838: Modeling Data - Standard_OutOfRange in Geom_OffsetSurface::LocalDN (called by BRepFill_PipeShell)

Fixed incorrect array allocation within GeomEvaluator_OffsetSurface::CalculateDN()
and protection against assigning out-of-range values in case of non-square
number of U and V derivatives on surface.

18 months ago0030588: Coding - avoid calling operator->() on NULL Handle
kgv [Sat, 16 Mar 2019 15:55:36 +0000]
0030588: Coding - avoid calling operator->() on NULL Handle

Use .get() method instead of operator->() where result can be NULL.
STEPCAFControl_Reader::ReadLayers(), XCAFDoc_ColorTool,
XCAFDoc_LayerTool::SetVisibility() - fixed static functions syntax.

18 months ago0030558: Coding - replace math_SingleTab with NCollection_LocalArray
kgv [Tue, 12 Mar 2019 03:05:21 +0000]
0030558: Coding - replace math_SingleTab with NCollection_LocalArray

math_Vector::Multiplied() - fixed modification of original array.

math_SVD::Solve(), math_SVD::PseudoInverse(), GeomFill_LocationGuide::InitX() - removed incorrect constness.

math_Vector, math_IntegerVector - math_SingleTab has been replaced by NCollection_LocalArray+NCollection_Array1.
Added accessors returning const value.

18 months ago0030536: Foundation Classes - TCollection_ExtendedString::StartsWith() and EndsWith...
vro [Mon, 18 Mar 2019 07:16:40 +0000]
0030536: Foundation Classes - TCollection_ExtendedString::StartsWith() and EndsWith() have a mistake

Draw-commands StartsWith and EndsWith are renamed to QAStartsWith and QAEndsWith.
The test script bug30536 was corrected.

18 months ago0030544: Data Exchange - IGES import fails on specific file
abv [Mon, 11 Mar 2019 18:28:52 +0000]
0030544: Data Exchange - IGES import fails on specific file

Method IGESToBRep_BRepEntity::TransferEdge() is fixed to record result even if it is wire rather than edge.
This allows translation of EdgeLoop entities referring to CompositeCurve items in EdgeList entities.
Curves that fail to translate are recorded in result as Null shapes (rather than skipping them) to keep indexation of curves in EdgeList valid for remaining ones.

Method IGESToBRep_BRepEntity::TransferLoop() is improved to skip failed edges thus avoiding exception and allowing translation to complete for transferable entities.

Warning messages are corrected to be more meaningful.
Added test bugs iges bug30544

18 months ago0030569: Foundation Classes - NCollection_Shared lacks inclusion of NCollection_Defin...
kgv [Wed, 13 Mar 2019 13:53:16 +0000]
0030569: Foundation Classes - NCollection_Shared lacks inclusion of NCollection_DefineAlloc.hxx

Add missing includes.

18 months ago0030584: Modeling Algorithms, BRepFill_OffsetWire - access violation on Face having...
kgv [Sat, 16 Mar 2019 10:22:47 +0000]
0030584: Modeling Algorithms, BRepFill_OffsetWire - access violation on Face having no boundaries

Added missing NULL and empty result checks.
Updated test cases using offset_wire_092.brep shape containing all Edges
with TopAbs_INTERNAL orientation (hense no boundary to make offset).

18 months ago0030581: Modeling Data - Standard_OutOfRange within Geom_BSplineSurface::LocateV()
kgv [Sat, 16 Mar 2019 06:33:37 +0000]
0030581: Modeling Data - Standard_OutOfRange within Geom_BSplineSurface::LocateV()

Geom2d_BSplineCurve::LocateU(),Geom_BSplineCurve::LocateU, Law_BSpline::LocateU()
Geom_BSplineSurface::LocateU() and Geom_BSplineSurface::LocateV()
have been corrected with missing range checks.
BSplCLib::Hunt() documentation has been corrected to reflect its actual implementation.

18 months ago0030571: Visualization, TKOpenGl - mapped texture is ignored while drawing points IR-2019-03-15
kgv [Sat, 16 Mar 2019 13:47:33 +0000]
0030571: Visualization, TKOpenGl - mapped texture is ignored while drawing points

OpenGl_AspectsTextureSet now appends Sprite texture to the end of texture set.
OpenGl_Context::init() - fixed usage of GL_MAX_COMBINED_TEXTURE_IMAGE_UNITS on too old GL context.

Default sampler names occSampler0, occActiveSampler and occSamplerBaseColor
are now excluded from header with common declarations for build-in GLSL programs.

OpenGl_ShaderObject::LoadAndCompile() and OpenGl_ShaderProgram::Link()
now includes program Id within error log.

OpenGl_ShaderManager now supports mapping texture onto point primitive within built-in programs
(texture transformation is ignored).

18 months ago0030511: Mesh - too long meshing of assembly containing single solid (shared)
oan [Mon, 4 Mar 2019 06:41:34 +0000]
0030511: Mesh - too long meshing of assembly containing single solid (shared)

Added test case.

18 months ago0030573: OSD_Parallel_TBB: limit number of execution threads using settings of OSD_Th...
oan [Thu, 14 Mar 2019 16:22:04 +0000]
0030573: OSD_Parallel_TBB: limit number of execution threads using settings of OSD_ThreadPool::DefaultPool()

Add tbb::task_scheduler_init to OSD_Parallel::forEach().

18 months ago0030575: Tests - v3d/materials unstable image screenshots of alpha-blending on GeForc...
kgv [Thu, 14 Mar 2019 21:12:12 +0000]
0030575: Tests - v3d/materials unstable image screenshots of alpha-blending on GeForce with MSAA

testdiff now looks for "IMAGE_COLOR_TOLERANCE: Tol" statements in log
to execute diffimage with -toleranceOfColor Tol parameter.

Image difference is first performed with 0 tolerance and then optionally with non-zero tolerance,
so that the log always includes information that some images are different,
but with two different messages:
- "IMAGE differs" for images failed comparison;
- "IMAGE is similar" for images passed comparison only with non-zero tolerance.

v3d/materials - disabled MSAA and removed duplicate.
demo/samples/materials - compare screenshots with 0.8% color tolerance (2/255).

18 months ago0030580: Configuration, CMake - introduce BUILD_RELEASE_DISABLE_EXCEPTIONS option...
kgv [Fri, 15 Mar 2019 11:24:15 +0000]
0030580: Configuration, CMake - introduce BUILD_RELEASE_DISABLE_EXCEPTIONS option managing No_Exception macros

18 months ago0030560: Modeling Algorithms - Improvement of the method BRepTools::DetectClosedness
jgv [Thu, 14 Mar 2019 09:38:09 +0000]
0030560: Modeling Algorithms - Improvement of the method BRepTools::DetectClosedness

1. Rewrite the method BRepTools::DetectClosedness.
2. Correct the method BRepOffset_Tool::EnLargeFace to process properly non-periodic but closed faces.

18 months ago0030570: Visualization, TKOpenGl - OpenGl_AspectFace ignores texture revision on...
kgv [Wed, 13 Mar 2019 18:46:24 +0000]
0030570: Visualization, TKOpenGl - OpenGl_AspectFace ignores texture revision on recompute

Added revision check to one more branch within OpenGl_AspectsTextureSet::build().

18 months ago0030564: Coding - math_Gauss uninitialized 'Singular' member variable
kgv [Wed, 13 Mar 2019 04:49:59 +0000]
0030564: Coding - math_Gauss uninitialized 'Singular' member variable

Removed unused class field Singular.

18 months ago0030562: Coding - TopOpeBRepBuild_Builder use of null pointer
kgv [Tue, 12 Mar 2019 17:22:26 +0000]
0030562: Coding - TopOpeBRepBuild_Builder use of null pointer

TopOpeBRepBuild_Builder::Clear() - added NULL check.

18 months ago0030124: Visualization, AIS_InteractiveObject - clean up confusing Presentation inval...
mnv [Thu, 7 Mar 2019 17:45:58 +0000]
0030124: Visualization, AIS_InteractiveObject - clean up confusing Presentation invalidation logic

Removed excess mechanism for invalidating presentations AIS_InteractiveObject::myRecomputeEveryPrs.
PrsMgr_PresentableObject::Update() has been deprecated and replaced by PrsMgr_PresentableObject::UpdatePresentations()
recomputing only explicitly invalidated presentations.

18 months ago0030554: Coding - ChFiDS_CommonPoint uninitialized member traarc
kgv [Mon, 11 Mar 2019 20:35:14 +0000]
0030554: Coding - ChFiDS_CommonPoint uninitialized member traarc

Added missing initialization to ChFiDS_CommonPoint constructor.

18 months ago0030553: Coding - TopOpeBRepDS_Surface missing default initalizations
kgv [Mon, 11 Mar 2019 20:20:44 +0000]
0030553: Coding - TopOpeBRepDS_Surface missing default initalizations

All class fields are now initialized within every TopOpeBRepDS_Surface constructor.

18 months ago0030545: Documentation - methods marked with Standard_DEPRECATED has ill-formed Doxyg...
kgv [Fri, 8 Mar 2019 12:52:08 +0000]
0030545: Documentation - methods marked with Standard_DEPRECATED has ill-formed Doxygen output

Doxygen option PREDEFINED has been extended by Standard_DEPRECATED declaration.

18 months ago0030547: Foundation Classes - NCollection_DoubleMap lacks Seek() method
kgv [Fri, 8 Mar 2019 23:32:11 +0000]
0030547: Foundation Classes - NCollection_DoubleMap lacks Seek() method

Added Seek1() and Seek2() methods to NCollection_DoubleMap class.

18 months ago0030149: BRepMesh_Delaun: free triangle is left in the mesh after cleanup of auxiliar... IR-2019-03-07
oan [Wed, 6 Mar 2019 11:29:57 +0000]
0030149: BRepMesh_Delaun: free triangle is left in the mesh after cleanup of auxiliary items

Remove free triangles connected to triangles over nodes of super triangle.
Modification of improved test case.

18 months ago0029570: Visualization, Graphic3d_Aspect - merge Graphic3d_Group aspects
kgv [Sun, 3 Mar 2019 18:07:55 +0000]
0029570: Visualization, Graphic3d_Aspect - merge Graphic3d_Group aspects

Graphic3d_AspectFillArea3d, Graphic3d_AspectLine3d, Graphic3d_AspectMarker3d
and Graphic3d_AspectText3d have been merged into new class Graphic3d_Aspects.
The old classes are preserved as dummy sub-classes of Graphic3d_Aspects
preserving different per-aspect defaults.

Methods IsGroupPrimitivesAspectSet(), GroupPrimitivesAspect(), FillAreaAspect(),
LineAspect() and MarkerAspect() have been removed from Graphic3d_Group.
Instead, a new method Graphic3d_Group::ReplaceAspects() has been introduced
for replacing existing group aspects.

AIS_Shape now uses new method AIS_InteractiveObject::replaceAspects()
for updating computed groups with new aspects without presentation recomputation
in places where SynchronizeAspects() is not applicable.

OpenGl_AspectFace, OpenGl_AspectLine, OpenGl_AspectMarker
and OpenGl_AspectText have been merged into new class OpenGl_Aspects.

ViewerTest::parseColor() - fix uninitialized alpha component.
Graphic3d_AspectText3d/Prs3d_TextAspect - removed unused properties Space, ExpansionFactor, Angle.
Remove getters Values() deprecated since OCCT 7.1.0.

18 months ago0030470: Modeling Algorithms - Invalid result of offset operation in mode "Complete...
emv [Tue, 5 Feb 2019 11:58:41 +0000]
0030470: Modeling Algorithms - Invalid result of offset operation in mode "Complete" with join type "Intersection"

The fix is intended to obtain the correct result of offset operation in which the result contained only the small inverse part of the shape, which clearly should not have been included in the result at all.

The fix adds treatment of the inverted edges while removing the inside faces (collapsed ones) - RemoveInsideFaces method:
- Removing the invalid hanging blocks containing the inverted edges.
- Considering the face containing the inverted edges as the invalid one.

Test cases for the issue.

18 months ago0030523: Visualization - Highlighting does not work anymore
Benjamin Bihler [Wed, 6 Mar 2019 12:02:29 +0000]
0030523: Visualization - Highlighting does not work anymore

Added hints about ZLayer consideration and changing highlight colors to documentation
of AIS_InteractiveContext::SetHighlightStyle() method.

AIS_InteractiveContext::MoveTo() now checks if highlighting style does not use immediate layer
and performs full Redraw() instead of RedrawImmediate().

Improved parsing of ZLayer names within vdisplay, vzlayer and vselprops commands.
vreadpixel now reports syntax errors on wrong input.

18 months ago0030535: Draw Harness - add size argument to vgrid command
vro [Wed, 6 Mar 2019 09:33:53 +0000]
0030535: Draw Harness - add size argument to vgrid command

vgrid command has been revised and extended with new argument -size.

18 months ago0030532: Visualization - Manipulator for dragging within a plane
anv [Thu, 21 Feb 2019 09:32:33 +0000]
0030532: Visualization - Manipulator for dragging within a plane

Added dragging sectors to Manipulator presentation.
Test added.

18 months ago0030490: Modeling Algorithms - Incomplete result of Cut operation
emv [Mon, 25 Feb 2019 12:53:27 +0000]
0030490: Modeling Algorithms - Incomplete result of Cut operation

The problem is fixed by the fix for the issue #0027448, thus integrating the test case only.

18 months ago0030182: Visualization, Image_AlienPixMap - support reading encoded image from memory... IR-2019-03-01
kgv [Thu, 28 Feb 2019 22:26:20 +0000]
0030182: Visualization, Image_AlienPixMap - support reading encoded image from memory buffer

Added two new Image_AlienPixMap::Load() methods, taking std::istream
and memory buffer (pointer, length) arguments.
This allows reading image from application memory or from file with non-zero offset.

Added Image_AlienPixMap::IsTopDownDefault() static property allowing to query rows order used by linked image library,
so that application might generate UV texture coordinates accordingly.

Added missing Release() to IWICImagingFactory instance.

18 months ago0030533: Data Exchange - Crash during STEP import.
ika [Thu, 28 Feb 2019 14:56:47 +0000]
0030533: Data Exchange - Crash during STEP import.

Add Null checks to avoid crash during reading faces without bounds.

18 months ago0024437: Visualization - silhouette edges based on OpenGL IR-WEEK9
asl [Wed, 27 Feb 2019 22:36:32 +0000]
0024437: Visualization - silhouette edges based on OpenGL

Added new flag Graphic3d_AspectFillArea3d::ToDrawSilhouette() activating silhouette (outline) rendering.

The new feature can simulate fake HLR look-n-feel,
when combined with Aspect_IS_HIDDENLINE interior style (filling object with background color),
face boundary edges (with most continuity flag set to c2 or lower).

Silhouette GLSL program is very simple - it displaces model alongside vertex normal,
so that it is applicable only to smooth surfaces and closed volumes,
and produces visual artifacts at sharp corners, especially when face boundary is disabled.

OpenGl_SetOfShaderPrograms has been modified so that to reduce
dimensions of the grid of static size based on amount of program combinations.

OpenGl_PrimitiveArray no more allocates VBO resources if primitive array
is marked to be not drawn via interior style / line type / marker type.

18 months ago0030497: [REGRESSION] Mesh - wrong Poly_Polygon3D within local selection of located...
nds [Thu, 28 Feb 2019 06:55:53 +0000]
0030497: [REGRESSION] Mesh - wrong Poly_Polygon3D within local selection of located shape

The previous code has a condition to avoid processing the same faces if the face has a location.
The similar condition should be applied during the edges processing.
If not doing this, in the previous implementation, IMeshData_Edge instances are created for all edges(even located), but edges of faces located are not filled with curves.
As a result we had wrong local selection of edges.

Limit addition of edges to data model by ones with unique TShape and location using edges map already available in BRepMesh_ShapeVisitor.

18 months ago0030356: Data Exchange - IGES model after importing into document has location issues
pdn [Wed, 27 Feb 2019 14:02:37 +0000]
0030356: Data Exchange - IGES model after importing into document has location issues

18 months ago0029787: Visualization - Avoid in presentation edges of certain continuity class
asl [Wed, 27 Feb 2019 16:39:08 +0000]
0029787: Visualization - Avoid in presentation edges of certain continuity class

A new flag Prs3d_Drawer::FaceBoundaryUpperContinuity() has been introduced
handled by StdPrs_ShadedShape::FillFaceBoundaries() method to exclude edges
of higher continuity class (e.g. to skip seam edges).

Draw Harness command vshowfaceboundary has been replaced by vaspects:
> vaspects -setFaceBoundaryDraw 1 -setFaceBoundaryColor RED -setFaceBoundaryType DASH.

18 months ago0030448: Coding - add typo detection to derivation creation methods using Standard_NO...
Benjamin Bihler [Mon, 25 Feb 2019 09:52:01 +0000]
0030448: Coding - add typo detection to derivation creation methods using Standard_NODISCARD attribute

Added macro Standard_NODISCARD equivalent to C++17 attribute [[nodiscard]] for compilers that support this.
Using Standard_NODISCARD macro for methods that create new object in gp, math, Geom, Bnd packages.
Marked equivalent operators with Standard_NODISCARD, if they are defined close to relevant methods.

Corrected code where warnings on unused result of calls to methods creating new objects are generated.
In most cases it looks like spelling errors (e.g. Normalised() instead of Normalise())

18 months ago0030493: Draw, ViewerTest - minor improvement of vdisplay command
kgv [Tue, 12 Feb 2019 09:22:26 +0000]
0030493: Draw, ViewerTest - minor improvement of vdisplay command

vdisplay no longer opens BREP file in case if Draw variable is not found.

Draw::Get() unused Complain argument has been removed from method definition.
Added Draw::GetExisting() and DBRep::GetExisting() commands never performing picking.

18 months ago0029810: Visualization - Tool for debugging shaders
asl [Tue, 26 Feb 2019 10:56:03 +0000]
0029810: Visualization - Tool for debugging shaders

A new tool for debugging shaders has been introduced.
The new method OpenGl_ShaderProgram::UpdateDebugDump() allows dynamically
dumping/restoring certain shader program (vertex and fragment shaders) to/from external file.

The file name is generated from the program's name with suffix ".vs" or ".fs" for shader type.
The environment variable CSF_ShadersDirectoryDump specifies the folder for dumps.

If the file does not exist (first frame), then it is automatically saved.
When the file date/time is changed in comparison with recent cached date,
then the file will be automatically loaded from external file,
thus this file can be modified in any editor.

OpenGl_ShaderManager now generates a human-readable resource ids for standard GLSL programs.

Draw Harness command vshader has been extended with arguments -list,-dump and -reload
for debugging shaders within OpenGl_Context.

18 months ago0030520: VIS - IVtkTools_ShapePicker::GetPickPosition() returns incorrect point
kgv [Tue, 26 Feb 2019 05:17:19 +0000]
0030520: VIS - IVtkTools_ShapePicker::GetPickPosition() returns incorrect point

vmoveto and ivtkmoveto commands now print topmost picked 3D point.

18 months ago0029996: Porting to VC 2017: memory leak reported in visualisation
abv [Tue, 26 Feb 2019 10:07:09 +0000]
0029996: Porting to VC 2017: memory leak reported in visualisation

Tests for memory leaks on display / erase cycles are performed with VBO disabled to avoid false memory leaks reported on NVidia graphics

18 months ago0029076: Visualization - implement element shrinking Shader IR-2019-02-22
mnv [Wed, 1 Aug 2018 15:09:37 +0000]
0029076: Visualization - implement element shrinking Shader

Aspect_IS_HOLLOW now an alias to Aspect_IS_EMPTY and Aspect_IS_HIDDENLINE does not implicitly enables mesh edges,
so that Graphic3d_AspectFillArea3d::SetDrawEdges() should be set independently.

OpenGl_ShaderManager now provides built-in GLSL programs for drawing mesh edges
in single pass (and on OpenGL ES which does not provide glPolygonMode()).

Graphic3d_RenderingParams::ToEnableAlphaToCoverage is now enabled by default
and properly handled at TKOpenGl level - enables coverage for Graphic3d_AlphaMode_Mask primitives.

OpenGl_PrimitiveArray now uses GLSL programs instead of glPolygonMode() by default,
which can be managed by OpenGl_Caps::usePolygonMode flag (desktop OpenGL only).
glPolygonMode() is also used as fallback regardless OpenGl_Caps::usePolygonMode flag
when GLSL programs are not supported (Geometry Shaders are required)
or stipple line style is required (not implemented within Face GLSL).

vaspects command has been extended by -setInterior -setDrawEdges -setEdgeColor -setEdgeType -setEdgeWidth
arguments replacing vsetinteriorstyle/vsetedgetype/vunsetedgetype commands.
vaspects now accepts arguments without "set" prefix.
ViewerTest::ParseColor() now parses RGBA color.

Redundant command BUC60738 has been removed.
AIS_ColorScale - fixed usage of uninitialized FillArea aspects.

18 months ago0030510: Application Framework - add missing NULL check within TDataStd_RealArray...
jfa [Thu, 21 Feb 2019 09:49:05 +0000]
0030510: Application Framework - add missing NULL check within TDataStd_RealArray::ChangeArray()

18 months ago0030384: Visualization - Won't display line with dot and dash style on Android
kgv [Wed, 20 Feb 2019 21:23:19 +0000]
0030384: Visualization - Won't display line with dot and dash style on Android

Fix misprint leading to double semicolon in GLSL code.

19 months ago0030498: Warnings of building documentation
apn [Mon, 18 Feb 2019 11:59:32 +0000]
0030498: Warnings of building documentation

Fix warning 'Reached end of file while still insided a (nested) comment in Markdown' for old versions of doxygen

19 months ago0030476: Visualization, Path Tracing - Adaptive Screen Sampling leads to unstable... IR-2019-02-15
kgv [Mon, 11 Feb 2019 15:00:35 +0000]
0030476: Visualization, Path Tracing - Adaptive Screen Sampling leads to unstable results

OpenGl_View::runPathtrace() has been extended with alternative multi-pass
Adaptive Screen Sampling mode, not relying on atomic floating point operations.
Although atomic operations on floats allows single-pass rendering,
such operations leads to instability in case of different calculation order.
Atomic float operations are also currently supported only by single GPU vendor.

Fixed GLSL compilation on Intel drivers (follow ARB_shader_image_load_store
specs rather than EXT_shader_image_load_store).

Graphic3d_RenderingParams::AdaptiveScreenSamplingAtomic option has been added
to activate 1-pass Adaptive Screen Sampling mode when supported by hardware.

vfps command has been extended with -duration argument allowing to limit command execution time.
vactivate command has been extended with -noUpdate argument.

19 months ago0030483: Visualization, Path Tracing - make Tile Size configurable
kgv [Wed, 6 Feb 2019 16:21:23 +0000]
0030483: Visualization, Path Tracing - make Tile Size configurable

OpenGl_TileSampler has been refactored to better describe its logic:
- Offset image now defines tile index instead of offset to tile origin.
- Added 2D array defining the number of times to sample tile for straight-forward debugging.

Graphic3d_RenderingParams has been extended with property
RayTracingTileSize for testing various tile configurations.
Default behavior is the following:
- Target number of tiles (e.g. upper limit per frame): 256
- Tile size: 32x32.

OpenGl_View::runPathtrace() has been split into two methods per rendering stage.
OpenGl_Texture::Init() now returns FALSE immediately on 0 input dimensions.

Added Image_PixMapTypedData template class allowing to work with image data of known pixel format.

19 months ago0028488: VIS - fix compilation with VTK 8.2
kgv [Fri, 15 Feb 2019 08:27:15 +0000]
0028488: VIS - fix compilation with VTK 8.2

Occurrences of removed method vtkDataArray::InsertNextTupleValue() have been replaced by InsertNextTypedTuple().
Fixed misprint in vtkTypeMacro usage for class IVtkTools_ShapeObject.
Patch #0030452 (SelectMgr_ViewerSelector::Deactivate() raises exception when called twice) has been propagated to IVtkOCC_ViewerSelector.

19 months ago0030486: Visualization - Rubber-band selection does not work with disabled overlap... IR-WEEK7
kgv [Fri, 8 Feb 2019 22:38:28 +0000]
0030486: Visualization - Rubber-band selection does not work with disabled overlap detection

SelectMgr_RectangularFrustum::Overlaps() now treats degenerated polygon as point instead of returning FALSE.

19 months ago0030477: Visualization - crash in AIS_Manipulator::ObjectTransformation after using...
kgv [Mon, 11 Feb 2019 09:01:40 +0000]
0030477: Visualization - crash in AIS_Manipulator::ObjectTransformation after using V3d_View::SetProj(V3d_Zpos)

19 months ago0030488: Visualization, Ray Tracing - empty error message on GLSL program compilation
kgv [Thu, 7 Feb 2019 14:24:47 +0000]
0030488: Visualization, Ray Tracing - empty error message on GLSL program compilation

OpenGl_ShaderObject::LoadAndCompile() - added method combining Load() and Compile() with optional error logging.
OpenGl_ShaderProgram::Link() now logs failures by default.

19 months ago0030478: Foundation Classes, NCollection_Array2 - provide Resize/Move methods consist...
kgv [Wed, 6 Feb 2019 09:29:21 +0000]
0030478: Foundation Classes, NCollection_Array2 - provide Resize/Move methods consistent to NCollection_Array1

19 months ago0030494: Coding Rules - eliminate declaration of OpenGl_Workspace::IsCullingEnabled()
kgv [Tue, 12 Feb 2019 06:37:30 +0000]
0030494: Coding Rules - eliminate declaration of OpenGl_Workspace::IsCullingEnabled()

19 months ago0030129: With newest doxygen 1.8.14 generation of overview gives warnings
abv [Fri, 8 Feb 2019 14:29:55 +0000]
0030129: With newest doxygen 1.8.14 generation of overview gives warnings

Doxygen configuration scripts are corrected to avoid '\n' symbols in the end of the @figure alias that caused multiple warning messages.
Other Doxygen warnings in Markdown files are eliminated.
In CMake builds the format of Doxygen warnings is set to use the style recognized by Visual Studio when compiler is MSVC.

19 months ago0030480: Visualization - Clear of Select3D_SensitiveGroup does not update internal... IR-2019-02-08
nds [Wed, 6 Feb 2019 17:20:47 +0000]
0030480: Visualization - Clear of Select3D_SensitiveGroup does not update internal container

19 months ago0028936: Draw freezes while making a 3d representation
bugmaster [Wed, 6 Feb 2019 12:02:48 +0000]
0028936: Draw freezes while making a 3d representation

Adding testing case

19 months ago0030329: Move BRepMesh_IncAllocator to NCollection package
kgv [Mon, 4 Feb 2019 09:21:14 +0000]
0030329: Move BRepMesh_IncAllocator to NCollection package

NCollection_IncAllocator has been extended with optional mutex allocation (disabled by default).

19 months ago0030474: Visualization - fallback font is ignored for missing font alias within Font_...
kgv [Mon, 4 Feb 2019 11:04:21 +0000]
0030474: Visualization - fallback font is ignored for missing font alias within Font_FontMgr::FindFont()

19 months ago0030469: Visualization - Draw crashes when 3D view is minimized
kgv [Fri, 1 Feb 2019 13:20:24 +0000]
0030469: Visualization - Draw crashes when 3D view is minimized

OpenGl_View::Redraw() - avoid rendering into window of zero size (leading to FPE and other issues).

19 months ago0030366: Coding Rules - GeometryTest_API2dCommands.cxx seems to be excess
kgv [Fri, 1 Feb 2019 14:49:08 +0000]
0030366: Coding Rules - GeometryTest_API2dCommands.cxx seems to be excess