kgv [Thu, 14 Mar 2019 21:12:12 +0000 (00:12 +0300)]
0030575: Tests - v3d/materials unstable image screenshots of alpha-blending on GeForce with MSAA
testdiff now looks for "IMAGE_COLOR_TOLERANCE: Tol" statements in log
to execute diffimage with -toleranceOfColor Tol parameter.
Image difference is first performed with 0 tolerance and then optionally with non-zero tolerance,
so that the log always includes information that some images are different,
but with two different messages:
- "IMAGE differs" for images failed comparison;
- "IMAGE is similar" for images passed comparison only with non-zero tolerance.
v3d/materials - disabled MSAA and removed duplicate.
demo/samples/materials - compare screenshots with 0.8% color tolerance (2/255).
kgv [Fri, 15 Mar 2019 11:24:15 +0000 (14:24 +0300)]
0030580: Configuration, CMake - introduce BUILD_RELEASE_DISABLE_EXCEPTIONS option managing No_Exception macros
jgv [Thu, 14 Mar 2019 09:38:09 +0000 (12:38 +0300)]
0030560: Modeling Algorithms - Improvement of the method BRepTools::DetectClosedness
1. Rewrite the method BRepTools::DetectClosedness.
2. Correct the method BRepOffset_Tool::EnLargeFace to process properly non-periodic but closed faces.
kgv [Wed, 13 Mar 2019 18:46:24 +0000 (21:46 +0300)]
0030570: Visualization, TKOpenGl - OpenGl_AspectFace ignores texture revision on recompute
Added revision check to one more branch within OpenGl_AspectsTextureSet::build().
kgv [Wed, 13 Mar 2019 04:49:59 +0000 (07:49 +0300)]
0030564: Coding - math_Gauss uninitialized 'Singular' member variable
Removed unused class field Singular.
kgv [Tue, 12 Mar 2019 17:22:26 +0000 (20:22 +0300)]
0030562: Coding - TopOpeBRepBuild_Builder use of null pointer
TopOpeBRepBuild_Builder::Clear() - added NULL check.
mnv [Thu, 7 Mar 2019 17:45:58 +0000 (20:45 +0300)]
0030124: Visualization, AIS_InteractiveObject - clean up confusing Presentation invalidation logic
Removed excess mechanism for invalidating presentations AIS_InteractiveObject::myRecomputeEveryPrs.
PrsMgr_PresentableObject::Update() has been deprecated and replaced by PrsMgr_PresentableObject::UpdatePresentations()
recomputing only explicitly invalidated presentations.
kgv [Mon, 11 Mar 2019 20:35:14 +0000 (23:35 +0300)]
0030554: Coding - ChFiDS_CommonPoint uninitialized member traarc
Added missing initialization to ChFiDS_CommonPoint constructor.
kgv [Mon, 11 Mar 2019 20:20:44 +0000 (23:20 +0300)]
0030553: Coding - TopOpeBRepDS_Surface missing default initalizations
All class fields are now initialized within every TopOpeBRepDS_Surface constructor.
kgv [Fri, 8 Mar 2019 12:52:08 +0000 (15:52 +0300)]
0030545: Documentation - methods marked with Standard_DEPRECATED has ill-formed Doxygen output
Doxygen option PREDEFINED has been extended by Standard_DEPRECATED declaration.
kgv [Fri, 8 Mar 2019 23:32:11 +0000 (02:32 +0300)]
0030547: Foundation Classes - NCollection_DoubleMap lacks Seek() method
Added Seek1() and Seek2() methods to NCollection_DoubleMap class.
oan [Wed, 6 Mar 2019 11:29:57 +0000 (14:29 +0300)]
0030149: BRepMesh_Delaun: free triangle is left in the mesh after cleanup of auxiliary items
Remove free triangles connected to triangles over nodes of super triangle.
Modification of improved test case.
kgv [Sun, 3 Mar 2019 18:07:55 +0000 (21:07 +0300)]
0029570: Visualization, Graphic3d_Aspect - merge Graphic3d_Group aspects
Graphic3d_AspectFillArea3d, Graphic3d_AspectLine3d, Graphic3d_AspectMarker3d
and Graphic3d_AspectText3d have been merged into new class Graphic3d_Aspects.
The old classes are preserved as dummy sub-classes of Graphic3d_Aspects
preserving different per-aspect defaults.
Methods IsGroupPrimitivesAspectSet(), GroupPrimitivesAspect(), FillAreaAspect(),
LineAspect() and MarkerAspect() have been removed from Graphic3d_Group.
Instead, a new method Graphic3d_Group::ReplaceAspects() has been introduced
for replacing existing group aspects.
AIS_Shape now uses new method AIS_InteractiveObject::replaceAspects()
for updating computed groups with new aspects without presentation recomputation
in places where SynchronizeAspects() is not applicable.
OpenGl_AspectFace, OpenGl_AspectLine, OpenGl_AspectMarker
and OpenGl_AspectText have been merged into new class OpenGl_Aspects.
ViewerTest::parseColor() - fix uninitialized alpha component.
Graphic3d_AspectText3d/Prs3d_TextAspect - removed unused properties Space, ExpansionFactor, Angle.
Remove getters Values() deprecated since OCCT 7.1.0.
emv [Tue, 5 Feb 2019 11:58:41 +0000 (14:58 +0300)]
0030470: Modeling Algorithms - Invalid result of offset operation in mode "Complete" with join type "Intersection"
The fix is intended to obtain the correct result of offset operation in which the result contained only the small inverse part of the shape, which clearly should not have been included in the result at all.
The fix adds treatment of the inverted edges while removing the inside faces (collapsed ones) - RemoveInsideFaces method:
- Removing the invalid hanging blocks containing the inverted edges.
- Considering the face containing the inverted edges as the invalid one.
Test cases for the issue.
Benjamin Bihler [Wed, 6 Mar 2019 12:02:29 +0000 (15:02 +0300)]
0030523: Visualization - Highlighting does not work anymore
Added hints about ZLayer consideration and changing highlight colors to documentation
of AIS_InteractiveContext::SetHighlightStyle() method.
AIS_InteractiveContext::MoveTo() now checks if highlighting style does not use immediate layer
and performs full Redraw() instead of RedrawImmediate().
Improved parsing of ZLayer names within vdisplay, vzlayer and vselprops commands.
vreadpixel now reports syntax errors on wrong input.
vro [Wed, 6 Mar 2019 09:33:53 +0000 (12:33 +0300)]
0030535: Draw Harness - add size argument to vgrid command
vgrid command has been revised and extended with new argument -size.
anv [Thu, 21 Feb 2019 09:32:33 +0000 (12:32 +0300)]
0030532: Visualization - Manipulator for dragging within a plane
Added dragging sectors to Manipulator presentation.
Test added.
emv [Mon, 25 Feb 2019 12:53:27 +0000 (15:53 +0300)]
0030490: Modeling Algorithms - Incomplete result of Cut operation
The problem is fixed by the fix for the issue #
0027448, thus integrating the test case only.
kgv [Thu, 28 Feb 2019 22:26:20 +0000 (01:26 +0300)]
0030182: Visualization, Image_AlienPixMap - support reading encoded image from memory buffer
Added two new Image_AlienPixMap::Load() methods, taking std::istream
and memory buffer (pointer, length) arguments.
This allows reading image from application memory or from file with non-zero offset.
Added Image_AlienPixMap::IsTopDownDefault() static property allowing to query rows order used by linked image library,
so that application might generate UV texture coordinates accordingly.
Added missing Release() to IWICImagingFactory instance.
ika [Thu, 28 Feb 2019 14:56:47 +0000 (17:56 +0300)]
0030533: Data Exchange - Crash during STEP import.
Add Null checks to avoid crash during reading faces without bounds.
asl [Wed, 27 Feb 2019 22:36:32 +0000 (01:36 +0300)]
0024437: Visualization - silhouette edges based on OpenGL
Added new flag Graphic3d_AspectFillArea3d::ToDrawSilhouette() activating silhouette (outline) rendering.
The new feature can simulate fake HLR look-n-feel,
when combined with Aspect_IS_HIDDENLINE interior style (filling object with background color),
face boundary edges (with most continuity flag set to c2 or lower).
Silhouette GLSL program is very simple - it displaces model alongside vertex normal,
so that it is applicable only to smooth surfaces and closed volumes,
and produces visual artifacts at sharp corners, especially when face boundary is disabled.
OpenGl_SetOfShaderPrograms has been modified so that to reduce
dimensions of the grid of static size based on amount of program combinations.
OpenGl_PrimitiveArray no more allocates VBO resources if primitive array
is marked to be not drawn via interior style / line type / marker type.
nds [Thu, 28 Feb 2019 06:55:53 +0000 (09:55 +0300)]
0030497: [REGRESSION] Mesh - wrong Poly_Polygon3D within local selection of located shape
The previous code has a condition to avoid processing the same faces if the face has a location.
The similar condition should be applied during the edges processing.
If not doing this, in the previous implementation, IMeshData_Edge instances are created for all edges(even located), but edges of faces located are not filled with curves.
As a result we had wrong local selection of edges.
Limit addition of edges to data model by ones with unique TShape and location using edges map already available in BRepMesh_ShapeVisitor.
pdn [Wed, 27 Feb 2019 14:02:37 +0000 (17:02 +0300)]
0030356: Data Exchange - IGES model after importing into document has location issues
asl [Wed, 27 Feb 2019 16:39:08 +0000 (19:39 +0300)]
0029787: Visualization - Avoid in presentation edges of certain continuity class
A new flag Prs3d_Drawer::FaceBoundaryUpperContinuity() has been introduced
handled by StdPrs_ShadedShape::FillFaceBoundaries() method to exclude edges
of higher continuity class (e.g. to skip seam edges).
Draw Harness command vshowfaceboundary has been replaced by vaspects:
> vaspects -setFaceBoundaryDraw 1 -setFaceBoundaryColor RED -setFaceBoundaryType DASH.
Benjamin Bihler [Mon, 25 Feb 2019 09:52:01 +0000 (12:52 +0300)]
0030448: Coding - add typo detection to derivation creation methods using Standard_NODISCARD attribute
Added macro Standard_NODISCARD equivalent to C++17 attribute [[nodiscard]] for compilers that support this.
Using Standard_NODISCARD macro for methods that create new object in gp, math, Geom, Bnd packages.
Marked equivalent operators with Standard_NODISCARD, if they are defined close to relevant methods.
Corrected code where warnings on unused result of calls to methods creating new objects are generated.
In most cases it looks like spelling errors (e.g. Normalised() instead of Normalise())
kgv [Tue, 12 Feb 2019 09:22:26 +0000 (12:22 +0300)]
0030493: Draw, ViewerTest - minor improvement of vdisplay command
vdisplay no longer opens BREP file in case if Draw variable is not found.
Draw::Get() unused Complain argument has been removed from method definition.
Added Draw::GetExisting() and DBRep::GetExisting() commands never performing picking.
asl [Tue, 26 Feb 2019 10:56:03 +0000 (13:56 +0300)]
0029810: Visualization - Tool for debugging shaders
A new tool for debugging shaders has been introduced.
The new method OpenGl_ShaderProgram::UpdateDebugDump() allows dynamically
dumping/restoring certain shader program (vertex and fragment shaders) to/from external file.
The file name is generated from the program's name with suffix ".vs" or ".fs" for shader type.
The environment variable CSF_ShadersDirectoryDump specifies the folder for dumps.
If the file does not exist (first frame), then it is automatically saved.
When the file date/time is changed in comparison with recent cached date,
then the file will be automatically loaded from external file,
thus this file can be modified in any editor.
OpenGl_ShaderManager now generates a human-readable resource ids for standard GLSL programs.
Draw Harness command vshader has been extended with arguments -list,-dump and -reload
for debugging shaders within OpenGl_Context.
kgv [Tue, 26 Feb 2019 05:17:19 +0000 (08:17 +0300)]
0030520: VIS - IVtkTools_ShapePicker::GetPickPosition() returns incorrect point
vmoveto and ivtkmoveto commands now print topmost picked 3D point.
abv [Tue, 26 Feb 2019 10:07:09 +0000 (13:07 +0300)]
0029996: Porting to VC 2017: memory leak reported in visualisation
Tests for memory leaks on display / erase cycles are performed with VBO disabled to avoid false memory leaks reported on NVidia graphics
mnv [Wed, 1 Aug 2018 15:09:37 +0000 (18:09 +0300)]
0029076: Visualization - implement element shrinking Shader
Aspect_IS_HOLLOW now an alias to Aspect_IS_EMPTY and Aspect_IS_HIDDENLINE does not implicitly enables mesh edges,
so that Graphic3d_AspectFillArea3d::SetDrawEdges() should be set independently.
OpenGl_ShaderManager now provides built-in GLSL programs for drawing mesh edges
in single pass (and on OpenGL ES which does not provide glPolygonMode()).
Graphic3d_RenderingParams::ToEnableAlphaToCoverage is now enabled by default
and properly handled at TKOpenGl level - enables coverage for Graphic3d_AlphaMode_Mask primitives.
OpenGl_PrimitiveArray now uses GLSL programs instead of glPolygonMode() by default,
which can be managed by OpenGl_Caps::usePolygonMode flag (desktop OpenGL only).
glPolygonMode() is also used as fallback regardless OpenGl_Caps::usePolygonMode flag
when GLSL programs are not supported (Geometry Shaders are required)
or stipple line style is required (not implemented within Face GLSL).
vaspects command has been extended by -setInterior -setDrawEdges -setEdgeColor -setEdgeType -setEdgeWidth
arguments replacing vsetinteriorstyle/vsetedgetype/vunsetedgetype commands.
vaspects now accepts arguments without "set" prefix.
ViewerTest::ParseColor() now parses RGBA color.
Redundant command BUC60738 has been removed.
AIS_ColorScale - fixed usage of uninitialized FillArea aspects.
jfa [Thu, 21 Feb 2019 09:49:05 +0000 (12:49 +0300)]
0030510: Application Framework - add missing NULL check within TDataStd_RealArray::ChangeArray()
kgv [Wed, 20 Feb 2019 21:23:19 +0000 (00:23 +0300)]
0030384: Visualization - Won't display line with dot and dash style on Android
Fix misprint leading to double semicolon in GLSL code.
apn [Mon, 18 Feb 2019 11:59:32 +0000 (14:59 +0300)]
0030498: Warnings of building documentation
Fix warning 'Reached end of file while still insided a (nested) comment in Markdown' for old versions of doxygen
kgv [Mon, 11 Feb 2019 15:00:35 +0000 (18:00 +0300)]
0030476: Visualization, Path Tracing - Adaptive Screen Sampling leads to unstable results
OpenGl_View::runPathtrace() has been extended with alternative multi-pass
Adaptive Screen Sampling mode, not relying on atomic floating point operations.
Although atomic operations on floats allows single-pass rendering,
such operations leads to instability in case of different calculation order.
Atomic float operations are also currently supported only by single GPU vendor.
Fixed GLSL compilation on Intel drivers (follow ARB_shader_image_load_store
specs rather than EXT_shader_image_load_store).
Graphic3d_RenderingParams::AdaptiveScreenSamplingAtomic option has been added
to activate 1-pass Adaptive Screen Sampling mode when supported by hardware.
vfps command has been extended with -duration argument allowing to limit command execution time.
vactivate command has been extended with -noUpdate argument.
kgv [Wed, 6 Feb 2019 16:21:23 +0000 (19:21 +0300)]
0030483: Visualization, Path Tracing - make Tile Size configurable
OpenGl_TileSampler has been refactored to better describe its logic:
- Offset image now defines tile index instead of offset to tile origin.
- Added 2D array defining the number of times to sample tile for straight-forward debugging.
Graphic3d_RenderingParams has been extended with property
RayTracingTileSize for testing various tile configurations.
Default behavior is the following:
- Target number of tiles (e.g. upper limit per frame): 256
- Tile size: 32x32.
OpenGl_View::runPathtrace() has been split into two methods per rendering stage.
OpenGl_Texture::Init() now returns FALSE immediately on 0 input dimensions.
Added Image_PixMapTypedData template class allowing to work with image data of known pixel format.
kgv [Fri, 15 Feb 2019 08:27:15 +0000 (11:27 +0300)]
0028488: VIS - fix compilation with VTK 8.2
Occurrences of removed method vtkDataArray::InsertNextTupleValue() have been replaced by InsertNextTypedTuple().
Fixed misprint in vtkTypeMacro usage for class IVtkTools_ShapeObject.
Patch #
0030452 (SelectMgr_ViewerSelector::Deactivate() raises exception when called twice) has been propagated to IVtkOCC_ViewerSelector.
kgv [Fri, 8 Feb 2019 22:38:28 +0000 (01:38 +0300)]
0030486: Visualization - Rubber-band selection does not work with disabled overlap detection
SelectMgr_RectangularFrustum::Overlaps() now treats degenerated polygon as point instead of returning FALSE.
kgv [Mon, 11 Feb 2019 09:01:40 +0000 (12:01 +0300)]
0030477: Visualization - crash in AIS_Manipulator::ObjectTransformation after using V3d_View::SetProj(V3d_Zpos)
kgv [Thu, 7 Feb 2019 14:24:47 +0000 (17:24 +0300)]
0030488: Visualization, Ray Tracing - empty error message on GLSL program compilation
OpenGl_ShaderObject::LoadAndCompile() - added method combining Load() and Compile() with optional error logging.
OpenGl_ShaderProgram::Link() now logs failures by default.
kgv [Wed, 6 Feb 2019 09:29:21 +0000 (12:29 +0300)]
0030478: Foundation Classes, NCollection_Array2 - provide Resize/Move methods consistent to NCollection_Array1
kgv [Tue, 12 Feb 2019 06:37:30 +0000 (09:37 +0300)]
0030494: Coding Rules - eliminate declaration of OpenGl_Workspace::IsCullingEnabled()
abv [Fri, 8 Feb 2019 14:29:55 +0000 (17:29 +0300)]
0030129: With newest doxygen 1.8.14 generation of overview gives warnings
Doxygen configuration scripts are corrected to avoid '\n' symbols in the end of the @figure alias that caused multiple warning messages.
Other Doxygen warnings in Markdown files are eliminated.
In CMake builds the format of Doxygen warnings is set to use the style recognized by Visual Studio when compiler is MSVC.
nds [Wed, 6 Feb 2019 17:20:47 +0000 (20:20 +0300)]
0030480: Visualization - Clear of Select3D_SensitiveGroup does not update internal container
bugmaster [Wed, 6 Feb 2019 12:02:48 +0000 (15:02 +0300)]
0028936: Draw freezes while making a 3d representation
Adding testing case
kgv [Mon, 4 Feb 2019 09:21:14 +0000 (12:21 +0300)]
0030329: Move BRepMesh_IncAllocator to NCollection package
NCollection_IncAllocator has been extended with optional mutex allocation (disabled by default).
kgv [Mon, 4 Feb 2019 11:04:21 +0000 (14:04 +0300)]
0030474: Visualization - fallback font is ignored for missing font alias within Font_FontMgr::FindFont()
kgv [Fri, 1 Feb 2019 13:20:24 +0000 (16:20 +0300)]
0030469: Visualization - Draw crashes when 3D view is minimized
OpenGl_View::Redraw() - avoid rendering into window of zero size (leading to FPE and other issues).
kgv [Fri, 1 Feb 2019 14:49:08 +0000 (17:49 +0300)]
0030366: Coding Rules - GeometryTest_API2dCommands.cxx seems to be excess
kgv [Thu, 31 Jan 2019 11:52:19 +0000 (14:52 +0300)]
0030464: Visualization - unable to set sub-shape transparency using vaspects command
Added AIS_ColoredShape::SetCustomTransparency() for simple way for assigning sub-shape transparency.
kgv [Mon, 21 Jan 2019 12:31:02 +0000 (15:31 +0300)]
0030452: Visualization - SelectMgr_ViewerSelector::Deactivate() raises exception when called twice
Removed unused SelectMgr_SOS_Sleeping enumeration value.
SelectMgr_ViewerSelector::Deactivate() now checks activation status before updating tolerance map.
kgv [Mon, 21 Jan 2019 08:57:22 +0000 (11:57 +0300)]
0030450: Visualization - AIS_InteractiveContext::MoveTo() never uses V3d_View::ImmediateRedraw()
AIS_InteractiveContext::MoveTo() now calls V3d_View::ImmediateRedraw() when applicable.
AIS_Trihedron::HilightOwnerWithColor() - added missing ZLayer setup.
gka [Wed, 23 Jan 2019 15:37:23 +0000 (18:37 +0300)]
0030405: Presentations of PMI are incorrectly scaled after change of units
Corrected search of the entity StepShape_ShapeDimensionRepresentation defining used units in the method readConnectionPoints
vro [Tue, 22 Jan 2019 10:47:09 +0000 (13:47 +0300)]
0030451: Selection mode of TPrsStd_AISPresentation attribute is restricted to one value
Two classes TDataXtd_Presentation and TPrsStd_AISPresentation were improved so that they accept a list of selection modes.
A new non-regression test is added: caf presentation N1
mahaidong [Fri, 18 Jan 2019 08:00:30 +0000 (11:00 +0300)]
0030429: Samples - add simple glfw 3D Viewer sample
Aspect_DisplayConnection now provides constructor wrapping existing X Display connection.
kgv [Thu, 10 Jan 2019 20:10:51 +0000 (23:10 +0300)]
0030439: Visualization - extend fonts search within Font_FontMgr::FindFont() on Linux
Font_FontMgr has been redesigned to:
- Store fonts in a map instead a list.
- Allow mapping multiple fonts to a single alias.
- Log informative message about usage of non-requested font (fallback).
- Register all font files within standard folders on Linux when "fonts.dir" is not found.
- Prefer specific alias ("serif") as default fallback font instead of arbitrary one in a system.
A couple of obsolete and broken font aliases have been removed;
instead, new aliases of fonts popular on Linux platform have been added.
Font_NameOfFont.hxx has been extended with more neutral aliases
"monospace", "serif", "sans-serif", "cjk" and "korean".
Font_FontAspect enumeration values have been renamed Font_FA_ -> Font_FontAspect_
with old values preserved as alias.
Font_SystemFont has been extended with a list of paths to Font_FontAspect styles,
so that entire Font Family is now defined within a single Font_SystemFont instance.
Non-resizable fonts are now ignored by Font Manager.
kgv [Thu, 10 Jan 2019 12:36:23 +0000 (15:36 +0300)]
0029670: Draw Harness - vtrihedron xaxis zaxis is wrong
Fixed gp_Ax2 initialization by two vectors.
Fixed -labels arguments number check.
osa [Thu, 10 Jan 2019 14:25:48 +0000 (17:25 +0300)]
0030437: Visualization, TKV3d - add Draw command to print rendering statistics
Add new command "vstatprofiler" to manage rendering parameters and print them.
If there are some input parameters - print corresponding statistic counters values,
else - print all performance counters set previously.
osa [Wed, 9 Jan 2019 14:01:18 +0000 (17:01 +0300)]
0030434: Visualization, TKV3d - add "NoUpdate" state of frustum culling optimization
Frustum culling is now managed by Graphic3d_RenderingParams::FrustumCullingState flag
and can be switched into Graphic3d_RenderingParams::FrustumCulling_NoUpdate state
useful for debugging the algorithm.
Draw Harness command vrustumculling has been replaced by vrenderparams -frustumCulling.
osa [Mon, 17 Dec 2018 09:01:17 +0000 (12:01 +0300)]
0030412: Visualization, TKV3d - add presentation of camera frustum
1) Added method Graphic3d_Camera::FrustumPoints() returning corner points of camera frustum.
2) Refactored methods OpenGl_BVHTreeSelector::isFullOut(...) and OpenGl_BVHTreeSelector::CacheClipPtsProjections()
3) Changed computation algorithm of frustum planes (build them by corner points)
4) Added interactive object AIS_CameraFrustum to draw camera frustum.
5) Extended Draw command "vcamera" with option displaying camera frustum.
nds [Wed, 7 Nov 2018 15:30:21 +0000 (18:30 +0300)]
0030349: Coding - add usage of Standard_EXPORT for some not inline methods in Select3D
abv [Thu, 10 Jan 2019 05:17:04 +0000 (08:17 +0300)]
0030430: Draw - command testgrid in parallel mode hangs if DRAW is launched without GUI
Ensure that initialization of Tcl interpretor is performed in the same thread where commands are evaluated.
Added test demo draw bug30430
abv [Sun, 18 Nov 2018 16:53:10 +0000 (19:53 +0300)]
0030377: DRAW, Windows - command executed via option -c fails on puts
When DRAW on Windows is launched with option -c, the command is now properly transferred to Tcl thread (separate thread that runs Tcl interpretor on Windows except when DRAW is run in batch mode) for execution, instead of being evaluated in the main thread.
Execution of DRAW in batch mode (option -b) is fixed by enabling proper initialization of the Tcl interpretor and replacement of backslashes in path to startup script by straight slashes on Windows in that mode.
Declaration of global variables used for communication of console command between threads is moved to Draw_Window.hxx to ensure consistency.
Function wscpy_s is used instead of memcpy to avoid possible buffer overrun.
kgv [Sat, 29 Dec 2018 12:41:54 +0000 (15:41 +0300)]
0030428: Modeling Algorithms - BRepBndLib::AddOBB() throws exception on empty Compound
Added missing Bnd_Box::IsVoid() check.
kgv [Tue, 25 Dec 2018 17:25:55 +0000 (20:25 +0300)]
0030424: C# wrapper - implement IEnumerable interface by NCollection classes
TopExp_Explorer::Value() - added Current() alias for providing interface consistent to other OCCT Iterators.
ifv [Mon, 10 Dec 2018 12:48:55 +0000 (15:48 +0300)]
0030346: Modeling Algorithms - BRepPrimAPI_MakeRevol throws "BRepSweep_Translation::MakeEmptyVertex"
Implementation of method "IsDeleted(...)" for MakeRevol and MakePrism algorithms.
Problem (exception) occurs during history building and was caused by an attempt to obtain generated shape for subshape, which was really "deleted" by algorithm - this input subshape and its possible generated shape was not used in result.
kgv [Mon, 12 Nov 2018 12:46:40 +0000 (15:46 +0300)]
0030364: Visualization, TKOpenGl - allow initializing a Surface-less EGL context
OpenGl_Context::MakeCurrent()/OpenGl_Context::IsCurrent() have been modified to NOT fail
in case if myWindow is EGL_NO_SURFACE (valid off-screen rendering case within EGL).
OpenGl_GraphicDriver::InitEglContext() now finds EGL surface config in case if it has not been passed by argument.
OpenGl_Window constructor now allows wrapping an off-screen rendering surface EGL_NO_SURFACE.
However, it still creates a dummy surface eglCreatePbufferSurface() to workaround bugs in some GLES drivers (Vivante GC2000).
V3d_View::SetWindow()/V3d_View::MustBeResized()/V3d_Viewer::SetViewOn() have been modified
to avoid implicit View redraw (leading to undefined behavior/crashes in case if rendering
should be done into default FBO defined right after V3d_View initialization).
msv [Thu, 20 Dec 2018 14:10:00 +0000 (17:10 +0300)]
0030396: Infinite recursion during ShapeFix after BRepAlgoAPI_Cut
Two test cases are added. One for Boolean operation (it is good, because BO has been fixed already), and another for fixshape operation (it causes Draw crash).
oan [Tue, 13 Nov 2018 10:08:37 +0000 (13:08 +0300)]
0029964: Bad arc discretization
Added test cases.
nbv [Thu, 29 Nov 2018 07:02:14 +0000 (10:02 +0300)]
0027976: Unstable work of 2d intersection algorithm for two lines
1. Test case for the issue has been created.
The problem is still reproduced on MASTER.
2. Some test cases have been moved to lowalgos/2dinter grid.
msv [Mon, 17 Dec 2018 12:16:55 +0000 (15:16 +0300)]
0030416: Incorrect implementation of the method Bnd_OBB::SquareExtent
The method Bnd_OBB::SquareExtent has been corrected.
kgv [Thu, 13 Dec 2018 07:32:45 +0000 (10:32 +0300)]
0030411: Data Exchange - attached model is exported as empty JT and VRML file
VrmlData_ShapeConvert::ConvertDocument() now handles reference labels within free shapes in the document.
kgv [Thu, 13 Dec 2018 07:45:14 +0000 (10:45 +0300)]
0030409: Data Exchange - exception during VRML file export
VrmlData_ShapeConvert::addShape() - handle case when parent node is NULL.
kgv [Thu, 13 Dec 2018 12:20:48 +0000 (15:20 +0300)]
0030413: Tests - increase counters within perf/ncollection/A1
skl [Mon, 10 Dec 2018 11:08:09 +0000 (14:08 +0300)]
0030402: Data Exchange - exported VRML file has broken location information
osa [Tue, 11 Dec 2018 10:40:40 +0000 (13:40 +0300)]
0030223: Visualization, TKOpenGl - frustum culling does not clip objects within perspective camera.
Fixed multiplication order of Projection and WorldView matrices
emv [Wed, 12 Dec 2018 05:07:29 +0000 (08:07 +0300)]
0030395: DRAW bop: Some sub-shapes of some of the argument become connected through other shapes and the argument became self-interfered.
Integrating only test case for the issue as it is not reproduced any more.
kgv [Sat, 8 Dec 2018 11:20:17 +0000 (14:20 +0300)]
0030400: Configuration - specify external dependencies user32 and shell32 explicitly
jgv [Mon, 3 Dec 2018 10:58:20 +0000 (13:58 +0300)]
0030391: Improvement of the method BRepOffset_Tool::EnLargeFace
Add options to set the length of enlargement for each of 4 directions.
Add restriction of enlargement in the case of singularity on the surface.
oan [Mon, 3 Dec 2018 12:46:48 +0000 (15:46 +0300)]
0029702: Foundation Classes - Introduce possibility to control parallel execution of BVH tools
Methods IsParallel() and SetParallel() have been added to BVH_Sorter, BVH_DistanceField and BVH_BuilderTransient to control parallel execution on low-level.
Fix compilation errors for old compilers without support of c++11 (std::begin, std::end)
oan [Wed, 18 Apr 2018 08:21:00 +0000 (11:21 +0300)]
0029177: Foundation Classes - Adapt BVH package for use of OSD_Parallel
Explicit calls to TBB in BVH_DistanceField, BVH_LinearBuilder and BVH_RadixSorter have been replaced.
Task functors have been separated on execution and state parts for the sake of usage by OSD_Parallel.
emv [Wed, 5 Dec 2018 07:52:38 +0000 (10:52 +0300)]
0030394: Modeling Algorithms - Empty result of offset operation (mode "Complete", join type - "Intersection")
The following changes have been made for improving the offset algorithm:
1. Multi-connexity support - intersection of the faces connected to the edge belonging to more than two faces is now performed.
2. Avoid intersection of the faces connected through internal edge.
3. Filling gaps (holes) in the splits of the created offset faces to increase possibility of creation of the closed volume from these splits.
Test cases for the issue.
emv [Thu, 12 Apr 2018 13:22:34 +0000 (16:22 +0300)]
0029692: Add functionality to make the group of touching same-dimensional shapes connected
Implementation of the new class *BOPAlgo_MakeConnected* for making the group of touching same-dimensional shapes connected.
Provide the material association for the first sub-elements of the input shapes.
Provide possibility to make the connected shape periodic.
Draw commands for new algorithm:
* makeconnected - make the input shapes connected or glued, performs material associations;
* cmaterialson - returns the materials located on the requested side of a shape;
* cmakeperiodic - makes the connected shape periodic in requested directions;
* crepeatshape - repeats the periodic connected shape in requested directions requested number of times;
* cperiodictwins - returns all periodic twins for the shape;
* cclearrepetitions - clears all previous repetitions of the periodic shape, keeping the shape periodic.
Documentation & test cases for the new algorithm.
emv [Mon, 19 Mar 2018 04:50:06 +0000 (07:50 +0300)]
0029683: Add functionality to make the TopoDS_Shape periodic in 3D space
Implementation of the new class *BOPAlgo_MakePeriodic* for making the shape periodic in 3D space.
Periodicity of the shape means that the shape can be repeated in any periodic direction any number of times without creation of the new geometry or splits.
The idea of this algorithm is to make the shape look similarly on the opposite sides or on the period bounds of periodic directions.
It does not mean that the opposite sides of the shape will be mirrored. It just means the the opposite sides of the shape should be split by each other and obtain the same geometry on opposite sides.
Such approach will allow repeating the shape, i.e. translating the copy of a shape on the period, without creation of new geometry because there will be no coinciding parts of different dimension.
Draw commands for the new algorithm:
* makeperiodic - makes the shape periodic in required directions;
* repeatshape - repeats the periodic shape in requested periodic direction;
* periodictwins - returns the periodic twins for the shape;
* clearrepetitions - clears all previous repetitions of the periodic shape.
Documentation & test cases for the algorithm.
jgv [Thu, 15 Nov 2018 12:36:22 +0000 (15:36 +0300)]
0030363: BRepLib::SameParameter with option "forced" corrupts valid shape
Method BRepLib::SameParameter has been corrected to synchronize check of resulting tolerance with BRepCheck.
nbv [Thu, 15 Nov 2018 09:00:58 +0000 (12:00 +0300)]
0029149: BRepMesh produces invalid mesh on the bound of adjacent faces
1. Test case for the issue has been created. The issue is fixed by the patch #26106.
2. Since now, "tricheck" command uses edge tolerance instead of edge deflection to check cross-face-errors (set of nodes of the edge on 1st face must be equal to set of nodes of the same edge on 2nd face).
oan [Mon, 19 Nov 2018 09:41:55 +0000 (12:41 +0300)]
0025594: Valid shape is not visualize in shading mode.
Added test case.
oan [Fri, 16 Nov 2018 11:20:54 +0000 (14:20 +0300)]
0025628: BRepMesh fails to mesh face with open wire, considered as correct by checkshape
Do not check status for "UnorientedWire", but check number of triangles instead.
oan [Fri, 16 Nov 2018 11:03:51 +0000 (14:03 +0300)]
0028719: Mesh - Display issue for special model
Clean existing triangulation before meshing.
ika [Fri, 19 Oct 2018 13:45:18 +0000 (16:45 +0300)]
0030273: Modeling Algorithms - Crash in postprocessing of imported shape.
Now end points of intervals calculated in GeomAdapter_Curve are not replaced by GeomAdapter_Surface.
Left bound of periodic curve less than UMin is not corrupted by LocateParameter during intervals calculating.
emv [Thu, 29 Nov 2018 07:20:23 +0000 (10:20 +0300)]
0030389: Data Exchange - StlAPI_Writer does not check if the face has triangulation
When merging triangulation of the faces skip those having no triangulation.
Test case for the issue.
apn [Tue, 27 Nov 2018 12:13:47 +0000 (15:13 +0300)]
0030385: Samples - Warnings during generation of projects from .pro files
Define variables ARCH and VCVER in .pro files in qt samples.
abv [Sat, 17 Nov 2018 09:51:26 +0000 (12:51 +0300)]
0027620: Test perf bop boxholes crashes DRAW
Implementation of capturing of output to standard streams in DRAW (see command dlog) is revised to avoid problems with command "test" executing long test scripts:
1. Method OSD_File::Capture() is removed: on Windows it was allocating a C file descriptor for a file opened using WinAPI, and never released that descriptor (once allocated, it cannot be released separately from WinAPI file handle). Direct calls to dup/dup2 are used instead.
2. In Draw_Window.cxx the standard Tcl channels are initialized manually using corrected version of Tcl internal function. This works around a problem with Tcl channels on Windows being bound to OS device handle owned by the system which can get invalidated as result of calls to dup2() (used to capture output to standard streams).
3. Temporary file for capturing is opened once and used to store whole log, thus the need to collect log in the string stream in memory is avoided
4. Possible errors of dup() and dup2() are checked and reported
Test demo draw dlog is added
Off-topic changes:
- Test demo draw getsource is corrected for VS2017 which generates file name in lowercase
- Field myFaceBounds is initialized in constructor of the class BRepAlgo_NormalProjection to avoid undefined behavior
- Test bugs modalg_5 bug24012 is corrected to use command nproject instead of custom one, and to check propertes of the resulting shape
nbv [Tue, 20 Nov 2018 13:34:27 +0000 (16:34 +0300)]
0030380: Exception while reading Step-file
Incorrect initialization of array (when upper bound is less than lower bound) has been avoided in some places.
kgv [Thu, 22 Nov 2018 19:51:37 +0000 (22:51 +0300)]
0030382: Draw Harness, ViewerTest - command vdir doesn't work anymore
jgv [Wed, 14 Jun 2017 13:28:15 +0000 (16:28 +0300)]
0028828: Modeling Algorithms - New functionalities of BRepFilletAPI_MakeChamfer algorithm
Two new functionalities have been added in BRepFilletAPI_MakeChamfer:
- constant throat (the section of chamfer is isosceles triangle, its height is constant in all sections - this is the "throat" of the weld);
- constant throat with penetration(the section of chamfer is right-angled triangle, the first of two surfaces (where is the top of the chamfer) is virtually moved inside the solid by offset operation, the apex of the section is on the intersection curve between moved surface and second surface, right angle is at the top of the chamfer, the length of the leg from apex to top is constant - this is the "throat" of the weld).
- New abstract classes BlendFunc_GenChamfer and BlendFunc_GenChamfInv have been added;
- Class BlendFunc_Chamfer is now descended from BlendFunc_GenChamfer, class BlendFunc_ChamfInv is now descended from BlendFunc_GenChamfInv.
- New class BlendFunc_ConstThroat is descended from BlendFunc_GenChamfer, new class BlendFund_ConstThroatInv is descended from BlendFunc_GenChamfInv.
- New class BlendFunc_ConstThroatWithPenetration is descended from BlendFunc_GenChamfer, new class BlendFund_ConstThroatWithPenetrationInv is descended from BlendFunc_GenChamfInv.
- Class ChFi3d_ChBuilder has now mode of chamfer that can be ClassicChamfer, ConstThroatChamfer and ConstThroatWithPenetrationChamfer.
- Two new DRAW Test Harness commands "chamf_throat" ant "chamf_throat_with_penetration" have been added for the second mode of ChBuilder.
- The interface of DRAW Test Harness command "chamf" changed for symmetric case.
nbv [Fri, 2 Nov 2018 07:06:26 +0000 (10:06 +0300)]
0025950: Bad performance of intersection algorithm.
1. Test case has been created.
2. Minor correction in DrawTrSurf.cxx file.
kgv [Wed, 14 Nov 2018 12:15:04 +0000 (15:15 +0300)]
0030374: Visualization, TKOpenGl - activate texture unit Graphic3d_TextureUnit_1 after OpenGl_LayerList::renderTransparent()
ika [Thu, 8 Nov 2018 12:16:12 +0000 (15:16 +0300)]
0030362: Data Exchange - Writing dimensions with inches produced invalid file.
Writing dimensions into STEP files in inches not produce invalid references between STEP entities.
nbv [Fri, 9 Nov 2018 07:22:55 +0000 (10:22 +0300)]
0030354: BOP Cut doesn't modify the attached face
The reason of this problem is in wrong work of classifier algorithm (see the message ~
0080992 to the issue #30354). Therefore, the algorithm of IntTools_FClass2d class has been improved. Namely, now orientation of the polygon is computed from area-criterion instead of angle. As result, some simplification of the method IntTools_FClass2d::Init(...) has been made.
<!break>
1. New constructor has been added to the class CSLib_Class2d. It allows applying TColgp_SequenceOfPnt2d.
2. DRAW-commands "addpolygonnode" and "polygonprops" have been created. They are covered by the test case "tests/geometry/2dpolygon/A1".
3. New method Poly::PolygonProperties(...) has been created. See help for detailed information.
4. New testgrid "lowalgos classifier" has been created.
oan [Fri, 2 Nov 2018 13:50:47 +0000 (16:50 +0300)]
0028379: BRepMesh produces mangled mesh for a cone
Split seam edge of a cone according to the specified parameters.
Seam edge functor is called before check of triangulation consistency in order to keep face status consistent.
The cause is that split seam edge can set Outdated flag when Reused is set by another functor without reset which can lead to refusement of such face by triangulation procedure.
Fix compilation error on VS2008