ika [Wed, 22 Mar 2017 07:31:58 +0000 (10:31 +0300)]
0028449: Data Exchange - Wrong orientation of Annotation Plane in GD&T
Fix orientation.
update test cases
imn [Fri, 24 Mar 2017 09:25:37 +0000 (12:25 +0300)]
Elimination of compiler warnings
emv [Tue, 21 Mar 2017 12:47:34 +0000 (15:47 +0300)]
0028577: Get rid of the TopOpeBRep* algorithms in TKOffset toolkit
The TKOffset toolkit has been cleared from the usage of the obsolete TopOpeBRep* classes.
emv [Mon, 20 Mar 2017 09:09:36 +0000 (12:09 +0300)]
0028573: Get rid of the old Boolean Operations in QA commands
The QA commands have been modified to use new Boolean operations instead of old.
emv [Mon, 20 Mar 2017 13:54:37 +0000 (16:54 +0300)]
0028576: Get rid of the TopOpeBRep* algorithms in TKFeat toolkit
The TKFeat toolkit has been cleared from the usage of TopOpeBRep* classes.
emv [Fri, 10 Mar 2017 12:13:48 +0000 (15:13 +0300)]
0028508: Make the CellsBuilder algorithm to work with multi-dimensional arguments
1. The CellsBuilder algorithm has been extended to work with multi-dimensional arguments.
It has become possible not only simulate Boolean expressions, but also perform non-supported
Boolean operations, like cutting face from solid, or fusing face with edge.
2. Test cases with multi-dimensional input shapes have been created.
3. Documentation has been updated.
nbv [Tue, 21 Mar 2017 15:30:03 +0000 (18:30 +0300)]
0028580: Misprint in IntPatch_WLineTool.cxx file
Code correction.
emv [Fri, 17 Mar 2017 11:33:50 +0000 (14:33 +0300)]
0028567: Get rid of the unused DRAW commands based on old Boolean Operations (BRepAlgo)
1. Removal of the traces of the usage of old Boolean operations in BRepFeat package.
2. The DRAW commands *fubl* and *cubl* based on old Boolean operations have been removed.
The alternative for these commands are the commands *bfuseblend* and *bcutblend* respectively.
The last two commands are based on the modern Boolean operations.
3. The DRAW command *ksection* based on old Boolean operations has been removed.
The command *bsection* should be used as alternative.
Test cases which have been using the *ksection* command have been modified to use the *bsection* command.
4. The class QANewBRepNaming_BooleanOperation has been modified to use modern Boolean operations.
The class QANewBRepNaming_BooleanOperation has been removed as not used.
The class QANewBRepNaming_BooleanOperationFeat has been renamed to QANewBRepNaming_BooleanOperation as it has nothing to do with Feat algorithm.
emv [Fri, 17 Mar 2017 08:34:21 +0000 (11:34 +0300)]
0028562: Replacement of old Boolean operations (BRepAlgo) with new ones (BRepAlgoAPI) in BRepAlgo_NormalProjection
The usage of the old Boolean operations (implemented in the class BRepAlgo_BooleanOperations) in the
BRepAlgo_NormalProjection algorithm has been replaced with the usage of new Boolean operations
(implemented in the class BRepAlgoAPI_BooleanOperations).
emv [Wed, 15 Mar 2017 06:15:46 +0000 (09:15 +0300)]
0028556: Invalid result of Fuse operation in the test case bugs moddata_2 bug469
1. Using appropriate intersection tolerance for splitting the degenerated edges in Boolean operations (void BOPAlgo_PaveFiller::FillPaves()).
2. Avoid creation of the wires consisting of degenerated edges only (BOPAlgo_WireSplitter).
3. Test case bugs/moddata_2/bug469 has been corrected to obtain valid result of operation. TODO statements have been removed from the case.
msv [Tue, 14 Mar 2017 14:33:46 +0000 (17:33 +0300)]
0028553: Incorrect result of the ShapeUpgrade_ShapeDivideContinuity algorithm
The cause of the bug was computation of incorrect UVBounds in the method ShapeAnalysis::GetFaceUVBounds. In this patch the computation of a box for a 2D curve in the method ShapeAnalysis_Curve::FillBndBox() has been improved taking into account intervals of C2 continuity.
Also the fix makes little extension of bounds when making the new surface in ShapeUpgrade_FaceDivide::SplitSurface(), so that all p-curves were fully inside.
Test case for issue CR28553
ski [Thu, 9 Mar 2017 15:15:00 +0000 (18:15 +0300)]
0028507: Extension of CShapr Wrapper 7.1.0 to support additional set of OCCT classes
Using of DEFINE_STANDARD_HANDLE macro was added to AIS_ColorScale class.
ika [Tue, 17 Jan 2017 09:18:42 +0000 (12:18 +0300)]
0028427: Data Exchange - Update Reference Manual for STEP format
- Update STEP manual
- Fix code style in several files
imn [Thu, 9 Mar 2017 16:20:43 +0000 (19:20 +0300)]
0028226: Incorrect history support in ShapeUpgrade_UnifySameDomain algorithm
- The methods "Modified" and "IsDeleted" have been added for history support in "ShapeUpgrade_UnifySameDomain" class.
- The new Draw commands "unifysamedommod" and "unifysamedomisdel" have been added.
- Adoption of other algorithms using this one to its new behavior.
Removing code duplication
Correcting regressions
Correcting remarks
mpa [Fri, 3 Mar 2017 10:57:36 +0000 (13:57 +0300)]
0026682: TopExp::MapShapesAndAncestors() will build map with duplicated ancestors.
The new method TopExp::MapShapesAndUniqueAncestors has been implemented, which excludes duplication of ancestors in the list items. The optional Boolean argument 'useOrientation' of this method points whether two same shapes with different orientation will be considered equal.
OCCT code has been inspected and MapShapesAndAncestors has been replaced with MapShapesAndUniqueAncestors where it is necessary.
abk [Mon, 13 Mar 2017 10:28:32 +0000 (13:28 +0300)]
0028537: Extend 'Draw' procedure 'checkprops' to specify the relative precision to compare corresponding values
'Draw' procedure 'checkprops' was extended by an option to set the relative precision to compare corresponding values.
nbv [Mon, 13 Mar 2017 13:03:07 +0000 (16:03 +0300)]
0028492: Boolean common does not produce expected result
Generation of 3D-steps shorter than 3D tolerance has been allowed in the fix to build Walking-line.
Now, 3D-step is limited by Precision::Confusion value.
jgv [Wed, 15 Mar 2017 13:36:47 +0000 (16:36 +0300)]
0028558: Test bugs modalg_6 bug26150_17 is failed with FPE switched on
Avoid division by zero in the method BRepFill_CompatibleWires::SameNumberByACR.
emv [Fri, 3 Mar 2017 12:58:11 +0000 (15:58 +0300)]
0026874: Implementation of the Partition operator in OCCT
1. The partition operation allows splitting an arbitrary number of shapes of an arbitrary dimension
by other arbitrary shapes. The algorithm has been implemented in the class BOPAlgo_Splitter.
The API operator Splitter has been implemented in the class BRepAlgoAPI_Splitter.
2. The draw commands for usage the new algorithm have been implemented - bsplit and bapisplit.
The commands are identical, but one uses the BOPAlgo_Splitter, the other uses BRepAlgoAPI_Splitter.
Both commands should be used after Pave Filler is filled.
3. Test cases for the new algorithm.
4. Documentation has been updated.
Small corrections.
emv [Thu, 2 Mar 2017 11:29:53 +0000 (14:29 +0300)]
0028501: Incomplete result of offset operation in mode Complete with Join type intersection
1. The algorithm BOPAlgo_ShellSplitter has been improved for the cases with multi-connected edges
to produce as many shells as possible from the given input faces.
2. Building tool prism in BRepFeat_MakePrism has been changed in order to avoid self-intersections
in the cases when the limiting faces are intersecting.
3. Test cases for the issue.
4. Test cases boolean/bcut_complex/N9 and boolean/gdml_private/ZH3 are improvements.
5. Test cases boolean/volumemaker/C5 and boolean/volumemaker/C6 has been marked as BAD due to found problem in intersection algorithm.
The results in these cases obtained on the branch are better than on master, but still not complete.
Adjusting test case bugs/moddata_2/bug469 for its current behavior.
nbv [Fri, 10 Mar 2017 12:56:19 +0000 (15:56 +0300)]
0028535: BOP Fuse reports "ErrorStatus : 11" on two attached faces
The reason of exception has been eliminated.
jgv [Mon, 6 Mar 2017 11:16:09 +0000 (14:16 +0300)]
0028468: Sweep with different sections raises Standard_NoSuchObject: BRep_Tool:: no parameter on edge
Method BRepFill_SectionPlacement::Perform is modified to operate vertices and edges of path correct.
Add two test cases.
Minor correction.
kgv [Fri, 17 Feb 2017 09:35:13 +0000 (12:35 +0300)]
0028470: Foundation Classes, NCollection_Array1 - add Resize() method for re-allocating array with new limits
NCollection_Array1 now provides method Resize() for re-allocating array to new bounds.
Added Move Constructor and Move Assignment operator.
Added empty constructor defining array of zero size.
Poly_Triangulation, dropped duplicating fields myNbNodes and myNbTriangles.
Removed unused file Poly_Triangulation.lxx.
Use std::move within NCollection_Array1::operator=() [fix for
0028470]
emv [Tue, 21 Feb 2017 08:39:29 +0000 (11:39 +0300)]
0028486: Fuse of several solids fails due to presence of common zones between faces
1. Exception in intersection of two analytical faces has been fixed by adding a simple check on number of vertices
in the resulting analytical curve;
2. Projection of the Circle on the Cone now checks if the Circle's normal direction is parallel to the Cone direction.
If it is not, the different, more advanced, algorithm will be used for projection - ProjLib_ComputeApprox;
3. Intersection of the Edge with the Face (IntTools_EdgeFace algorithm) in QuickCoincidenceCheck mode has been fixed to
avoid the checking of the type of the intersection result if the coincidence check gives the positive result;
4. All common IN edges of the intersecting faces has been added for intersection with section edges to avoid self-intersection in the result;
5. Post treatment of the section edges in Boolean operations has been improved with the new stage which treats the possible
common zones, not detected by the intersection algorithm, between faces by intersecting each section edge with all faces,
not participated in its creation, and in case of coincidence putting it as IN edge into FaceInfo structure of the face.
The new function has been implemented for that - BOPAlgo_PaveFiller::PutSEInOtherFaces().
6. Checking for the SameDomain splits of faces in Boolean Operations has been modified to process the pairs of faces in
which both the section curves and common zones are present.
7. Adjustment of the test case boolean gdml_private ZH3 as improvement.
8. Test cases for the issue.
9. Test cases for the parent issue -
0026789.
abk [Wed, 1 Mar 2017 11:22:51 +0000 (14:22 +0300)]
0028495: The maximal depth of the tree is used implicitly in type 'BVH_PrimitiveSet'
Type 'BVH_PrimitiveSet' was extended by a static constant to access the maximal depth of the tree.
emv [Thu, 2 Mar 2017 12:43:48 +0000 (15:43 +0300)]
0028496: BOP Cut failed on two attached faces with error "ErrorStatus : 191"
While checking the SurfaceOfExtrusion on closeness (GeomLib::IsClosed())
it is necessary to take into account that the basis curve may be not trimmed.
Test case for the issue.
emv [Mon, 20 Feb 2017 07:54:22 +0000 (10:54 +0300)]
0028473: Incorrect result of 3D offset operation in mode Complete, Join type Intersection (spike is created)
Looking for inverted edges among the neutral ones while checking the offset edges on validity (BRepOffset_MakeOffset_1::FindInvalidEdges).
Test cases for the issue.
bugmaster [Thu, 2 Mar 2017 13:15:00 +0000 (16:15 +0300)]
0012567: Swapped first/last vertices or incorrect curve orientation after reading IGES file
Adding test case
apn [Thu, 2 Mar 2017 11:08:59 +0000 (14:08 +0300)]
0028502: Compilation error on Arch Linux (clang compiler)
nbv [Tue, 28 Feb 2017 07:45:51 +0000 (10:45 +0300)]
0028491: Incomplete section curve
The main idea of the fix is to forbid check if intersection curve lies in the some face (with input tolerance) if we have 2D-intersection curve on this face (we consider that necessary tolerance has been computed in intersection algorithm honestly). If we do not have 2D-curve on this face then we need check as before.
New algorithm is implemented in IntTools_Context::IsValidBlockForFaces(...) method.
------
src\Extrema\Extrema_GenExtPS.cxx
No principled changes have been made.
imn [Thu, 22 Dec 2016 15:55:55 +0000 (18:55 +0300)]
0028228: Provide possibility to keep the given edges during unification of faces in ShapeUpgrade_UnifySameDomain algorithm
- Added methods "KeepShape" and "KeepShapes" for "ShapeUpgrade_UnifySameDomain" class
- Updated "unifysamedom" command in Draw
Remarks correction
Additional remarks correction
Removed redundant checks
Removing compilation warning
jgv [Tue, 24 Jan 2017 13:27:13 +0000 (16:27 +0300)]
0026150: BRepOffsetAPI_ThruSections doesn't implement history method Generated().
Virtual method Generated is redefined. Now it returns:
- chain of generated faces for sub-edge of a profile;
- chain of generated edges for sub-vertex of a profile;
- bunch of chains of generated edges for start or end vertex if it is degenerated section.
Correction according to the remarks.
Fix compiler's warnings and add 4 new test cases.
Correction of mistake.
Compilation warnings are gone.
kgv [Thu, 23 Feb 2017 17:50:42 +0000 (20:50 +0300)]
0028487: Visualization, TKOpenGl - add option for rendering with lower resolution
Graphic3d_RenderingParams::RenderResolutionScale - added new option
defining scale factor for allocating off-screen rendering buffers
relative to native resolution of window buffer.
Scale factor can be below 1.0 (lower resolution) or higher (as analog of super sampling),
but can not be combined with MSAA settings.
Draw Harness command vrenderparams has been extended with option -rendScale
managing introduced option Graphic3d_RenderingParams::RenderResolutionScale.
vcaps has been extended with option -useWindowBuffer for managing
OpenGl_Caps::useSystemBuffer option.
vrepaint has been extended with option -immediate
for testing immediate layer redraw
OpenGl_View::blitBuffers() - eliminate compiler warning on Android
dbp [Fri, 18 Nov 2016 14:53:10 +0000 (17:53 +0300)]
0028218: Visualization, Path Tracing - Redesign path tracing materials to support two-layered model
Existing OCCT path tracing engine used very simple additive material (BSDF) model, so it was possible to reproduce
behavior only of very basic materials such as metal, glass, or plastic. However, some important in CAD industry
materials like car paint or ceramic could not be modeled well. In this patch, OCCT BSDF was significantly improved
by replacing additive model with two-layered scattering model. Therefore, we have base diffuse, glossy, or transmissive
layer, covered by one glossy/specular coat. The layers themselves have no thickness; they can simply reflect light or
transmits it to the layer under it. Balancing different combinations of layer properties can produce a wide range of
different effects. At the same time, disabling the first (coat) layer allows to keep full compatibility with previously
supported scattering model. All new parameters are available via 'vbsdf' command.
Location of new sample for few material examples:
samples\tcl\pathtrace_materials.tcl
Fix shader compilation issue.
Fix test case sample_ball_alpha.
Shaders_PathtraceBase_fs.pxx - regenerate resource from origin
kgv [Sun, 5 Feb 2017 10:47:27 +0000 (13:47 +0300)]
0028441: Coding Rules - move out nested Image_PixMap::ImgFormat enumeration to dedicated enum Image_Format
Enumeration Image_PixMap::ImgFormat, previously declared as nested
enumeration within class *Image_PixMap*,
has been moved to global namespace as Image_Format following OCCT coding rules.
The enumeration values have suffix Image_Format_ and preserve
previous name scheme for easy renaming of old values.
E.g. Image_PixMap::ImgGray become Image_Format_Gray.
Old definitions are preserved as depreacated aliases to the new ones.
bugmaster [Wed, 1 Mar 2017 13:56:42 +0000 (16:56 +0300)]
0021750: Intersection of two cylindrical surfaces fails
Adding test case
bugmaster [Tue, 28 Feb 2017 12:02:55 +0000 (15:02 +0300)]
0026796: The result of General Fuse operation is self-intersecting shape
Adding test case
bugmaster [Tue, 28 Feb 2017 13:02:37 +0000 (16:02 +0300)]
0027615: [regression] Boolean operation returns invalid shape in 64 bit mode and valid shape in 32 bit mode
Adding test case
kgv [Fri, 17 Feb 2017 08:30:42 +0000 (11:30 +0300)]
0028469: Visualization, StdPrs_ShadedShape - do not create redundant copy of normal array
kgv [Thu, 16 Feb 2017 21:24:17 +0000 (00:24 +0300)]
0028466: Visualization, OpenGl_Context - read GPU memory using WGL_AMD_gpu_association extension
ifv [Tue, 21 Feb 2017 14:38:52 +0000 (17:38 +0300)]
0028458: Some faces are missing when loading a specific CAD. This is a regression from OCCT 7.0 and Express Mesh 7.0.
Function ACos and ASin are modified to avoid exception when argument is +-(1. + Epsilon(1.)) because of "numerical noise"
jgv [Fri, 17 Feb 2017 15:23:18 +0000 (18:23 +0300)]
0027998: Self-intersection is not detected
New method CheckFaceSelfIntersection has been added to BOPAlgo_CheckerSI: now self-intersection of each face is found as well as pairs of intersecting faces;
-method IntPatch_Intersection::Perform(S1,D1,TolArc,TolTang) is modified for more effective search of self-interasections in case of Surface Of Extrusion;
-method IntCurve_IntPolyPolyGen::Perform(C1,D1,TolConf,Tol,NbIter) is modified to detect segments of intersections.
Small correction.
Test cases are corrected.
Correction of compiler error
Fix of regressions
Names of shapes correction
msv [Fri, 17 Feb 2017 15:59:49 +0000 (18:59 +0300)]
0028471: ShapeUpgrade_RemoveLocations breaks sharing of sub-shapes
- Add option 'remove_level' to the command 'removeloc'.
- Add test case.
Minor correction of test case
emv [Thu, 9 Feb 2017 05:57:49 +0000 (08:57 +0300)]
0028442: Incorrect result of 3D offset operation in mode Complete, Join type - Intersection
1. For the support of the new configurations of the input shapes for the 3D offset algorithm
(shapes containing the faces with holes, which are growing during offset operation and
sometimes (depending on the offset value) even kill the faces themselves) the new function
*FindFacesInsideHoleWires* has been implemented. This new function looks for the splits of
the offset face located inside the new hole wire built from offset edges of the edges of the
hole wires of the original face. All found splits are simply removed.
2. Test cases for the issue.
vro [Thu, 16 Feb 2017 13:03:56 +0000 (16:03 +0300)]
0028463: OCAF loses an interactive object after copying
mpv [Thu, 2 Feb 2017 15:31:59 +0000 (18:31 +0300)]
0028428: BinMNaming_NamedShapeDriver fails if there are no nodes in NamedShape
Unit test and additional parsing rule for tests are added as well as a minor fix of the draw command for bug24164_2 unit test (in reference array it was impossible to set only one value).
Added the exception for the checking in issue 2269, when bad document is read.
It checks that there is no crash, but just an error message. If crash is appeared, this test will not skipped anyway.
Correction of test for bug2269 and parse.rules
kgv [Thu, 16 Feb 2017 11:42:18 +0000 (14:42 +0300)]
0028460: Visualization - V3d_View::SetZoom() performs checks which then ignored
Fixed variables misuse.
kgv [Sun, 5 Feb 2017 08:33:39 +0000 (11:33 +0300)]
0028405: Visualization, V3d_Viewer - changes to Grid immediately updates view
V3d_Viewer methods ActivateGrid, DeactivateGrid, SetRectangularGridValues, SetCircularGridValues,
RectangularGridGraphicValues, CircularGridGraphicValues, SetPrivilegedPlane, DisplayPrivilegedPlane
do not redraw viewer anymore.
emv [Mon, 21 Mar 2016 10:14:20 +0000 (13:14 +0300)]
0027182: Wrong result of General Fuse operation for two spheres
1. The static method Standard_Real MinStep3D(...) in the class BOPTools_AlgoTools is
now checks if the computed 3D step is too big (relatively UV range of the faces)
for any of the faces.
2. The method PointInFace(...) of the class BOPTools_AlgoTools3D has been redesigned.
The new PointInFace(...) methods have been implemented to add possibility for looking the point
inside the face in necessary direction and distance from the edge of the face.
Note: old implementation is also functional.
3. Make methods for finding points near edges and computing normal directions on faces
return error status (0 in case of success).
4. Test case for the issue.
5. Test cases offset shape_type_i_c XJ2,XJ4,XJ5,XJ6 are improvements.
Removing useless file
dbv [Thu, 9 Feb 2017 11:50:17 +0000 (14:50 +0300)]
0028425: Open/save NamedShape changes order of shapes
Changed order of shapes when reading from bin and xml document.
Small correction of test case for issue CR28425
abv [Thu, 9 Feb 2017 12:32:24 +0000 (15:32 +0300)]
0028440: Documentation - Doxygen errors on Linux
Extensions of PNG files is corrected to be lowercase
Duplicate subsection tag is corrected in Draw user guide
abv [Sun, 5 Feb 2017 08:59:29 +0000 (11:59 +0300)]
0028431: Coding, Graphic3d - Eliminate GCC warning -Wstrict-overflow
Code amended to avoid warning issued by GCC optimizer
ika [Tue, 7 Feb 2017 12:20:29 +0000 (15:20 +0300)]
0028445: Data Exchange - Opening specific STEP file leads to application crash
Add check for null vertex during translation from STEP.
kgv [Thu, 9 Feb 2017 12:52:59 +0000 (15:52 +0300)]
0028439: Configuration - compilation error when using thread_local within XCode 7 or earlier
__has_feature(cxx_thread_local) check has been added
for using thread_local keyword within CLang.
ika [Wed, 1 Feb 2017 16:17:48 +0000 (19:17 +0300)]
0028444: Data Exchange - Missed text blocks in Saved Views
Add new STEP entity to connect dimension semantic with presentation.
Fix number of GDTs in Saved View.
emv [Fri, 3 Feb 2017 11:24:28 +0000 (14:24 +0300)]
0028426: Implementation of the EdgesToFaces function
1. The two new methods have been implemented:
a. BOPAlgo_Tools::EdgesToWires - allows creating planar wires from edges.
The input edges may be not shared, but the output wires will be sharing the coinciding vertices and edges.
It is possible to skip the sharing if the input edges are already shared by passing the corresponding flag into the method.
The input edges are expected to be planar, but the method does not check it. Thus, if the input edges are not planar, the output wires will also be not planar.
In general, the output wires will be non-manifold and may contain free vertices.
b. BOPAlgo_Tools::WiresToFaces - allows creating planar faces from the planar wires.
In general, the input wires are non-manifold and may be not closed, but should share the coinciding parts.
The wires located in the same plane and completely included into other wires will create holes in the faces built from bigger wires
These two methods combined allow building faces from set of edges randomly located in 3D space.
2. The DRAW command *edgestofaces* has been implemented.
3. The documentation has been updated with the new section in Modeling Algorithms - Topological Tools.
4. Test cases for the issue.
aba [Fri, 3 Feb 2017 08:59:51 +0000 (11:59 +0300)]
0028239: PMIVis - defined positions and number of places are not loaded properly in some cases
Corrected 'addTolModif' test command
abv [Thu, 9 Feb 2017 12:45:51 +0000 (15:45 +0300)]
0028392: Shape Processing - some checks have no option to switch off
Added option ShapeFix_Solid::FixShellOrientationMode allowing to switch off analysis and fixing of orientations of shell(s) in solid.
Options FixVertexToleranceMode, FixShellOrientationMode, FixFaceOrientationMode are added to Shepe Processing resource file so that they can be manipulated.
msv [Thu, 9 Feb 2017 12:44:06 +0000 (15:44 +0300)]
0027894: Crash when calling ShapeUpgrade_UnifySameDomain
- Avoid getting pcurve of edge on not connected face.
- Avoid building wire of empty set of edges.
Small correction of test case for issue CR27894
msv [Thu, 9 Feb 2017 12:33:48 +0000 (15:33 +0300)]
0028326: Checking invariant shapes in revolve is incomplete
Check for bspline and bezier curves coinciding with the axis of rotation.
Minor correction of test case bugs/modalg_6/bug28003
msv [Mon, 9 Jan 2017 07:11:01 +0000 (10:11 +0300)]
0028333: Draw Harness - whatis command hangs when selection is activated with no opened view
Added new method Draw_Window::IsMapped() for checked window state.
Draw_Window using XLib now does not exit application on closing window.
The method Draw_Viewer::Select() (called by whatis command)
has been corrected so as not to enter the loop if no views are initialized.
duv [Fri, 3 Feb 2017 09:13:43 +0000 (12:13 +0300)]
0028360: Draw Harness - access for DRAW TCL interpreter needed for custom applications
Components of DRAW now use interpreter with static method Draw::GetInterpretor() instead of shared global variable
msv [Wed, 1 Feb 2017 08:35:50 +0000 (11:35 +0300)]
0028327: BSplCLib can cause memory corruption in degenerated cases
The code of the methods BSplCLib::KnotForm and BSplCLib::MultForm has been made safe by giving up using of address of array item for iteration on the Array1. Also the checking for degenerated case has been added to prevent out of bounds exception.
apn [Fri, 3 Feb 2017 08:57:09 +0000 (11:57 +0300)]
Warnings on vc14 were eliminated
apn [Thu, 2 Feb 2017 16:01:54 +0000 (19:01 +0300)]
Warning on windows in QABugs_11.cxx was eliminated
abv [Sun, 29 Jan 2017 20:23:49 +0000 (23:23 +0300)]
0028404: DRAW - avoid useless preparation of display data when shape is not shown
Class DBRep_DrawableShape is changed to postpone generation of display data until the shape is actually displayed (for the first time).
Test perf draw bug28404 is added.
ski [Thu, 2 Feb 2017 13:35:21 +0000 (16:35 +0300)]
0026937: Eliminate NO_CXX_EXCEPTION macro support
Macro NO_CXX_EXCEPTION was removed from code.
Method Raise() was replaced by explicit throw statement.
Method Standard_Failure::Caught() was replaced by normal C++mechanism of exception transfer.
Method Standard_Failure::Caught() is deprecated now.
Eliminated empty constructors.
Updated samples.
Eliminate empty method ChangeValue from NCollection_Map class.
Removed not operable methods from NCollection classes.
ika [Wed, 25 Jan 2017 11:13:45 +0000 (14:13 +0300)]
0028389: Data Exchange - Import of STEP Saved Views and Clipping Planes
- new STEP entities for Saved Views
- import of STEP Saved Views
- new XCAF tool for clipping planes
- new draw commands
- update test
kgv [Mon, 30 Jan 2017 10:09:22 +0000 (13:09 +0300)]
0028407: Visualization - remove ::UpdateMode() from Graphic3d_StructureManager
abv [Thu, 2 Feb 2017 13:22:33 +0000 (16:22 +0300)]
0028403: Avoid useless calls to BRepTools::Write()
Useless writes of intermediate shapes to hardcoded paths are removed in samples\mfc\standard\02_Modeling\src\ModelingDoc.cpp
Methods IGESBRep::WriteShape(), XSControl_Utils::WriteShape() are deleted; BRepTools::Write() can be used instead.
Method TopOpeBRepBuild_Tools::DumpMapOfShapeWithState() is moved to where it is used -- TopOpeBRepBuild_Builder1_1.cxx as static function (commented out).
Unused DRAW command OCC18612 is removed.
Upgrade Guide is corrected to avoid Doxygen warnings.
kgv [Thu, 19 Jan 2017 16:29:59 +0000 (19:29 +0300)]
0028376: Visualization, AIS_ColoredShape - fix endless recursion due to misprint
kgv [Fri, 27 Jan 2017 15:16:50 +0000 (18:16 +0300)]
0028400: Visualization, Graphic3d_MaterialAspect - remove undocumented and unsupported flag EnvReflexion()
ski [Thu, 6 Nov 2014 09:39:12 +0000 (12:39 +0300)]
0023551: Move data models contained in samples subfolder of OCCT repository to common data folder
Data files from mfc samples were moved to $CASROOT/data directory.
ski [Fri, 9 Dec 2016 08:38:28 +0000 (11:38 +0300)]
0027737: Remove hardcoded paths to data folders in mfc samples
Data shapes (used in samples) were moved into CSF_OCCTDataPath location.
emv [Thu, 26 Jan 2017 05:23:51 +0000 (08:23 +0300)]
0028387: Empty result of 3D Offset operation in mode Complete JoinType Intersection
1. The smarter conditions for removing the invalid faces with inverted edges have been implemented
(BRepOffset_MakeOffset::RemoveInvalidSplitsByInvertedEdges).
2. Avoid removed (completely inside) edges in the filtering of invalid faces
(BRepOffset_MakeOffset::FilterInvalidFaces).
3. Test cases for the issue.
apl [Thu, 26 Jan 2017 09:54:30 +0000 (12:54 +0300)]
0028361: Visualization, TKV3d - buggy behavior of Transformation Persistence compiled on several Linux platforms in optimized mode
The patch fixes transformation persistence for various set of GCC compilers.
1) Optimized template-specialized operator /= for division (causes bugs)
of NCollection_Vec4 was replaced with non-specialized version.
2) NCollection_Vec4::xyz() is not used since compiler uses modifiable-reference
returning version, which invokes warning of possible strict-aliasing rules
violation and leads to incorrect behavior of the reference.
nbv [Mon, 30 Jan 2017 11:01:24 +0000 (14:01 +0300)]
0028394: Not precise extrema solution of line and circle lying in the same plane
If the line is in the circle-plane completely (or parallel to the circle-plane) then extremas and intersections in 2D-space are looked for. These case are pure analytical and solutions will be found precisely.
msv [Wed, 25 Jan 2017 15:12:18 +0000 (18:12 +0300)]
0028375: Regressions after enabling floating point signals handling in DRAW
In Bisector_BisecCC.cxx avoid division by zero when the variable N1P2P1==0.
In Bisector_BisecPC.cxx avoid creation of gp_Dir2d with zero components.
vsv [Mon, 30 Jan 2017 13:05:19 +0000 (16:05 +0300)]
0028401: Configuration - unresolved symbol OpenGl_VertexBuffer::unbindFixedColor()
nds [Thu, 26 Jan 2017 14:16:09 +0000 (17:16 +0300)]
0028365: Visualization, AIS_InteractiveContext - apply selection filter in AddOrRemoveSelected at Neutral point
kgv [Wed, 25 Jan 2017 17:26:27 +0000 (20:26 +0300)]
0028257: XCAFPrs_Style - uninitialized memory usage within ::HashCode()
XCAFPrs_Style::HashCode() function has been corrected.
XCAFPrs_Style::SetVisibility() does not reset assigned colors anymore.
abv [Thu, 2 Feb 2017 13:00:28 +0000 (16:00 +0300)]
0028371: Configuration - update system requirements page
Table of supported operating systems with versions is removed, in favor of more general statement with simple list of supported OS and architectures.
Outdated list of tested graphic cards has been dropped.
msv [Thu, 2 Feb 2017 12:57:58 +0000 (15:57 +0300)]
0028313: Extend Draw functionality with some new useful commands and features
1) In Views menu the check button item "Extended view commands" has been added. Pressing on it shows/hides the set of buttons in the main window that allow manipulating of view zoom/pan/rotate by mouse.
2) New category of commands "Vector and measurement Commands" has been added. The commands in this category allow simple calculations using 2D and 3D vectors, such as cross and dot products, computation of distances of points to other objects, and other functions.
3) The new command "pickf" has been added in "DRAW Variables management" category. It allows extracting a picked with mouse face included in some shape as a new variable.
4) New commands "del" and "era" have been added in "DRAW Variables management" category. They allow deleting (destructing) or erasing (from view) variables matched by glob pattern.
5) Missing help for some commands like "don", "disp" and others has been added.
kgv [Wed, 25 Jan 2017 14:51:03 +0000 (17:51 +0300)]
0028391: Foundation Classes - OSD_Directory returns incorrect protection flags for shared directory on Windows
Redirect Folder reading flags to File reading flags when Folder flags are not found.
apn [Thu, 26 Jan 2017 17:05:11 +0000 (20:05 +0300)]
Correct warning on vc 14 (caused by #26007)
apn [Thu, 26 Jan 2017 13:51:00 +0000 (16:51 +0300)]
Add new package XCAFView to UDLIST (issue #28044)
akz [Fri, 11 Nov 2016 14:59:23 +0000 (17:59 +0300)]
0026007: Standard attribute for surface meshes in TDataStd
nbv [Wed, 25 Jan 2017 08:14:41 +0000 (11:14 +0300)]
0026745: Boolean Cut produces invalid result
Creation of test cases for issues #26745 and #26748
emv [Mon, 9 Jan 2017 06:50:03 +0000 (09:50 +0300)]
0028284: Avoid classification of sub-shapes of arguments of BOPs relatively solids during Intersection phase
1. The methods PerformVZ, PerformEZ, PerformFZ and PerformZZ have been transferred from BOPAlgo_PaveFiller to BOPAlgo_CheckerSI class
to perform intersection of sub-shapes with solids only in self-intersection mode.
2. The checks for solids built from the same (shared) faces have been added into methods building the result of Boolean operations -
BOPAlgo_BOP::BuildRC() and BOPAlgo_BOP::BuildSolid().
3. Since the NonDestructive mode is now natively supported by the BOPAlgo_PaveFiller the methods providing the support of this mode by CheckerSI
(BOPAlgo_CheckerSI::PrepareCopy() and BOPAlgo_CheckerSI::PostTreatCopy()) are not needed and have been removed.
4. The pairs of sub-shapes with interfering bounding boxes are now sorted before real intersection to guarantee the constant order of
intersection of sub-shapes and produce more stable result. The class BOPDS_PassKey has been replaced with simpler class BOPDS_Pair.
5. The class BOPDS_SubIterator has been refactored.
6. Test cases for the issue.
7. Adjustment of the test case boolean volumemaker D2.
nbv [Thu, 26 Jan 2017 10:33:50 +0000 (13:33 +0300)]
0027252: Implicit-implicit intersection (Cylinder-Plane) loses intersection curve
1. Earlier we could not put any IntPatch_Point to the intersection curve. The fix makes the algorithm of IntPatch_Points searching more precise. It is achieved by redetermination of earlier found vertices with help of minimization the distance between boundary of one intersection argument and another intersection argument (surface).
2. Additional check has been added, if IntPatch_Point adjusted to the domain boundary is true intersection point.
3. Method Contap_ArcFunction::Surface() has been added.
4. Method LastComputedPoint() has been added for IntPatch_ArcFunction and Contap_ArcFunction classes.
5. Correction in FindMaxDistance() method (see IntTools_FaceFace.cxx file) according to pure Golden-ratio minimization algorithm. Earlier this function worked wrong with small searching intervals.
6. Insignificant correction in math_BrentMinimum.cxx file (elimination of "defines").
Creation of test case for issues #27221 an #27252.
Adjusting some test cases according to their new behavior.
Correction according to the last remarks.
Small correction of shape names for issue CR27252
Test case for issue 28210
Small correction of test case for issue 28210
ski [Tue, 24 Jan 2017 09:52:41 +0000 (12:52 +0300)]
0028384: Add FPE signals enabling from MSVC
Variable CSF_FPE was added to the file adm/templates/DRAWEXE.vcxproj.user.in
ika [Wed, 19 Oct 2016 15:31:56 +0000 (18:31 +0300)]
0028044: Data Exchange - implement data structures for Saved Views
Add new root label in Document for Views.
Add new attribute to store View in XDE.
Add object and tool to process Views.
Add new Draw commands for Views.
kgv [Wed, 18 Jan 2017 07:59:35 +0000 (10:59 +0300)]
0028367: Draw Harness - XSave should print an error on store failure
ifv [Thu, 26 Jan 2017 10:19:20 +0000 (13:19 +0300)]
0028261: Chamfer fails on edge connected to cone's seam
Method GetType() of class GeomAdaptor_SurfaceOfRevolution was modified to create plane instead Cone or SurfaceOfRevolution for "plane like" within Precision::Confusion() restricted object.
For infinite objects Cone with semiangle > PI/2 - eps is replaced by SurfaceOfRevolution for eps < Precision::Confusion()
Tests cases are added
Small correction of shape names for issue CR28261_28266
nbv [Mon, 23 Jan 2017 08:05:16 +0000 (11:05 +0300)]
0028381: Draw Harness - DRAWEXE hangs up immediatly when redirecting input stream on Windows
dbp [Thu, 26 Jan 2017 09:56:13 +0000 (12:56 +0300)]
0028129: Visualization, Path Tracing - Improve interactivity in "steady" rendering mode
Re-basing the patch on current master.
nbv [Fri, 20 Jan 2017 08:15:23 +0000 (11:15 +0300)]
0028373: Incomplete section between cylinder and plane
Test case has been created.
ifv [Thu, 26 Jan 2017 09:51:09 +0000 (12:51 +0300)]
0028230: Convert C0 2d curve to C1 raises exception
The treatment of small curves (length of curves is less then tolerance used for checking G1) is added in
Geom2dConvert_CompCurveToBSplineCurve.cxx
azv [Tue, 15 Nov 2016 09:17:45 +0000 (12:17 +0300)]
0027383: Modeling - improve handling of regularity on edges
1. There has been implemented calculation of all possible types of continuity for shared edges:
* G1 is set if tangential planes are the same for connected faces in each control points through the edge;
* C1 is set in addition to G1 conditions if derivatives, orthogonal to the edge on each face, are equal vectors;
* G2 is set in addition to G1 if the centers of principal curvatures are the same for connected faces in each control points through the edge;
* C2 is set in addition to C1 and G2 if directions of principal curvatures are equal;
* CN continuity is set only if both connected faces are based on elementary surfaces (the conditions for this case are similar to C2 continuity).
2. ShapeFix::EncodeRegularity() is merged into BRepLib::EncodeRegularity().
3. Implemented several test cases to check correct handling of regularity.
4. Fix incorrect usage of BRepLib::EncodeRegularity() in BRepBuilderAPI_Sewing.
5. Implement a method for calculation of regularity on the given list of edges.
6. Documentation updates
kgv [Thu, 29 Dec 2016 17:39:28 +0000 (20:39 +0300)]
0028263: Coding Rules - clean up definition of the class Graphic3d_MaterialAspect
Fixed uninitialized fields in several classes.
Body of trivial methods have been moved to class definition (header file).
Ensure that non-primitive types are returned by reference, when possible.
Removed unused class Prs3d_PlaneSet.