2 years ago0030337: Draw Harness, ViewerTest - do not restrict vtexture to AIS_Shape
kgv [Fri, 2 Nov 2018 15:40:51 +0000 (18:40 +0300)]
0030337: Draw Harness, ViewerTest - do not restrict vtexture to AIS_Shape

2 years ago0026820: bsection returns single vertex instead of curve
nbv [Fri, 2 Nov 2018 07:57:48 +0000 (10:57 +0300)]
0026820: bsection returns single vertex instead of curve

Test case has been created only because the problem is not reproduced on current MASTER.

2 years ago0021494: Intersection between cone and sphere fails IR-2018-11-02
nbv [Mon, 29 Oct 2018 10:34:21 +0000 (13:34 +0300)]
0021494: Intersection between cone and sphere fails

The condition (workaround), which forbid to return the intersection curve, has been removed.

2 years ago0025082: bopcommon returns different result on Windows and Linux system
nbv [Thu, 1 Nov 2018 11:32:08 +0000 (14:32 +0300)]
0025082: bopcommon returns different result on Windows and Linux system

Test cases have been created because the problem is not reproduced on current MASTER

2 years ago0030322: Remove DRAW-command "mesh" as useless
nbv [Wed, 31 Oct 2018 11:29:28 +0000 (14:29 +0300)]
0030322: Remove DRAW-command "mesh" as useless

In fact, the DRAW-command "mesh" is duplicate of "incmesh".

The difference is that the "mesh" creates DRAW-object MeshTest_DrawableMesh. However, this object is currently not applicable (e.g. we cannot display it).

DRAW-commands "mesh", "addshape", "smooth", "edges", "vertices", "medge", "mvertex", "triangle", "dumpvertex", "dumpedge", "dumptriangle" and "onetriangulation" have been removed.

The class MeshTest_DrawableMesh has been removed as useless.

Testgrids "mesh standard_mesh" and "mesh advanced_mesh" have been removed.

2 years ago0030305: Strange logic in BRepMesh_Deflection::ComputeDeflection(...) method
nbv [Thu, 25 Oct 2018 12:21:34 +0000 (15:21 +0300)]
0030305: Strange logic in BRepMesh_Deflection::ComputeDeflection(...) method

Before the fix, angular deflection was scaled to some coefficient in the method BRepMesh_Deflection::ComputeDeflection(...). Now, angular deflection is constant.

2 years ago0030008: BRepMesh does not respect angular deflection in internal area of bspline...
nbv [Fri, 19 Oct 2018 13:38:02 +0000 (16:38 +0300)]
0030008: BRepMesh does not respect angular deflection in internal area of bspline surface

1. Check whether the mesh satisfies the required angular deflection has been amended. Namely normals (to the surface) in the ends of any not "frontier" link are made collinear (with the given angular tolerance).

2. New parameters AngleInterior and DeflectionInterior have been added in IMeshTools_Parameters structure.

3. In case of thin long faces with internal edges, add points of internal edges to control parameters using grabParamsOfInternalEdges() in order to avoid aberrations on its ends. Disable addition of parameters from boundary edges in case of BSpline surface. Deviation can be controlled through the deflection parameter.

4. Grab parameters from edges in case if there is just a single interval on BSpline surface along U and V direction.

2 years ago0026106: BRepMesh - revision of data model
oan [Mon, 9 Oct 2017 10:04:54 +0000 (13:04 +0300)]
0026106: BRepMesh - revision of data model

Removed tight connections between data structures, auxiliary tools and algorithms in order to create extensible solution, easy for maintenance and improvements;
Code is separated on several functional units responsible for specific operation for the sake of simplification of debugging and readability;
Introduced new data structures enabling possibility to manipulate discrete model of particular entity (edge, wire, face) in order to perform computations locally instead of processing an entire model.

The workflow of updated component can be divided on six parts:
* Creation of model data structure: source TopoDS_Shape passed to algorithm is analyzed and exploded on faces and edges. For each topological entity corresponding reflection is created in data model. Note that underlying algorithms use data model as input and access it via common interface which allows user to create custom data model with necessary dependencies between particular entities;
* Discretize edges 3D & 2D curves: 3D curve as well as associated set of 2D curves of each model edge is discretized in order to create coherent skeleton used as a base in faces meshing process. In case if some edge of source shape already contains polygonal data which suites specified parameters, it is extracted from shape and stored to the model as is. Each edge is processed separately, adjacency is not taken into account;
* Heal discrete model: source TopoDS_Shape can contain problems, such as open-wire or self-intersections, introduced during design, exchange or modification of model. In addition, some problems like self-intersections can be introduced by roughly discretized edges. This stage is responsible for analysis of discrete model in order to detect and repair faced problems or refuse model’s part for further processing in case if problem cannot be solved;
* Preprocess discrete model: defines actions specific for implemented approach to be performed before meshing of faces. By default, iterates over model faces and checks consistency of existing triangulations. Cleans topological faces and its adjacent edges from polygonal data in case of inconsistency or marks face of discrete model as not required for computation;
* Discretize faces: represents core part performing mesh generation for particular face based on 2D discrete data related to processing face. Caches polygonal data associated with face’s edges in data model for further processing and stores generated mesh to TopoDS_Face;
* Postprocess discrete model: defines actions specific for implemented approach to be performed after meshing of faces. By default, stores polygonal data obtained on previous stage to TopoDS_Edge objects of source model.

Component is now spread over IMeshData, IMeshTools, BRepMeshData and BRepMesh units.


1. Extend "tricheck" DRAW-command in order to find degenerated triangles.

2. Class BRepMesh_FastDiscret::Parameters has been declared as deprecated.

3. NURBS range splitter: do not split intervals without necessity. Intervals are split only in case if it is impossible to compute normals directly on intervals.

4. Default value of IMeshTools_Parameters::MinSize has been changed. New value is equal to 0.1*Deflection.

5. Correction of test scripts:

1) perf mesh bug27119: requested deflection is increased from 1e-6 to 1e-5 to keep reasonable performance (but still reproducing original issue)
2) bugs mesh bug26692_1, 2: make snapshot of triangulation instead of wireframe (irrelevant)

Correction in upgrade guide.

2 years ago0030281: Regression to 7.2.0: Modeling Algorithms - Wrong result of CUT operation
emv [Wed, 24 Oct 2018 06:12:26 +0000 (09:12 +0300)]
0030281: Regression to 7.2.0: Modeling Algorithms - Wrong result of CUT operation

Boolean Operations - Force the face with internal edges to be treated by the BuilderFace algorithm. It is needed for the cases when internal edges of the face go from side to side and should really split the face.
Test case for the issue.

2 years ago0030174: ShapeUpgrade_UnifySameDomain does not unify cylindrical faces
jgv [Thu, 25 Oct 2018 13:30:56 +0000 (16:30 +0300)]
0030174: ShapeUpgrade_UnifySameDomain does not unify cylindrical faces

Hotfix for issue 27271 (avoiding potential seam edges) is deleted.

Correction of test case

2 years ago0029673: Exception while Face-Face intersection
nbv [Fri, 26 Oct 2018 08:37:00 +0000 (11:37 +0300)]
0029673: Exception while Face-Face intersection

If 2D-curves are requested in intersection result but they cannot be created (by some reason) then the full set of curves (3D and two 2D) is rejected from the intersection result.

2 years ago0028493: [Regression vs 7.0.0] Intersection algorithm produces curve with loop
nbv [Fri, 26 Oct 2018 11:06:28 +0000 (14:06 +0300)]
0028493: [Regression vs 7.0.0] Intersection algorithm produces curve with loop

1. New testgrid "lowalgos/intss" has been created. It will contain all test cases on geometrical intersection of two surfaces ("intersect" DRAW-command) and two faces ("bopcurves" DRAW-command).

2. New test case for the issue #28493 has been created because the problem is not reproduced on MASTER.

3. Test case (lowalgos/intss/bug24472) for the issue #29501 has been modified in order to check loops of the resulting intersection curves.

2 years ago0030315: Data Exchange - Crash reading views during STEP import.
ika [Fri, 26 Oct 2018 15:04:10 +0000 (18:04 +0300)]
0030315: Data Exchange - Crash reading views during STEP import.

Add NULL check to protect against crash.

2 years ago0024676: Wrong result done by intersection algorithm IR-2018-10-26
nbv [Thu, 25 Oct 2018 14:14:21 +0000 (17:14 +0300)]
0024676: Wrong result done by intersection algorithm

Only test case has been created because the problem is not reproduced on the current MASTER

2 years ago0030291: Visualization - manipulator crashes when is attached with scaling mode disabled
aba [Wed, 24 Oct 2018 16:25:12 +0000 (19:25 +0300)]
0030291: Visualization - manipulator crashes when is attached with scaling mode disabled

- in ComputeSelection() method checks are added to avoid taking triangulation of manipulator parts that are not computed

2 years ago0026509: Intersection algorithm produces set of curves providing closed contour in...
nbv [Tue, 23 Oct 2018 13:58:59 +0000 (16:58 +0300)]
0026509: Intersection algorithm produces set of curves providing closed contour in 3D-space and not closed contour in 2D-space

Test cases have been created. No fix is needed because the described problem has not to be cause of failing of high-level OCCT-algorithms.
See the message ~80300 (issue #26509) for detail information.

2 years ago0030270: Modeling Algorithms - BRepBndLib should provide an option for skipping infin...
kgv [Tue, 23 Oct 2018 14:39:36 +0000 (17:39 +0300)]
0030270: Modeling Algorithms - BRepBndLib should provide an option for skipping infinite entities

Bnd_Box now keeps calculating of finite part of bounding box after specifying it to be Open in some direction.
The finite part can be retrieved using new method Bnd_Box::FinitePart().

Prs3d::GetDeflection() now uses Bnd_Box::FinitePart() when applying relative deflection.

Draw Harness command bounding has been extended with option -finite returing a finite part of AABB.

2 years ago0030214: Application Framework, TPrsStd_AISPresentation - Hidden Presentations Cannot...
vro [Wed, 24 Oct 2018 11:04:57 +0000 (14:04 +0300)]
0030214: Application Framework, TPrsStd_AISPresentation - Hidden Presentations Cannot Be Removed

2 years ago0024905: Boolean cut produced invalid result
nbv [Tue, 23 Oct 2018 11:07:11 +0000 (14:07 +0300)]
0024905: Boolean cut produced invalid result

The method BOPAlgo_PaveFiller::PutClosingPaveOnCurve(...) has been improved in order to take into account extended vertex tolerance.

2 years ago0030280: Data Exchange - broken VRML output due to unescaped symbols starting comment...
skl [Tue, 23 Oct 2018 04:50:33 +0000 (07:50 +0300)]
0030280: Data Exchange - broken VRML output due to unescaped symbols starting comment block

2 years ago0030203: ProjLib_ComputeApproxOnPolarSurface::BuildInitialCurve2d array out of bound
ifv [Tue, 16 Oct 2018 14:10:44 +0000 (17:10 +0300)]
0030203: ProjLib_ComputeApproxOnPolarSurface::BuildInitialCurve2d array out of bound

Bug fixing: avoiding calculation if tPp == NbOfPnts

2 years ago0030199: Extrema Point<->Curve gives inaccurate result
ifv [Mon, 15 Oct 2018 12:38:00 +0000 (15:38 +0300)]
0030199: Extrema Point<->Curve gives inaccurate result

Special treatment of bspline curve of first degree is implemented in Extrema_GExtPC.gxx
Test case is added
Some test cases are modified according to actual state of algorithm

2 years ago0030119: Visualization, OpenGl_ShaderManager - implement mechanism generating in...
mnv [Fri, 7 Sep 2018 07:18:46 +0000 (10:18 +0300)]
0030119: Visualization, OpenGl_ShaderManager - implement mechanism generating in/out section of shader programs

Added functionality which generate in/out part of shaders source code from prepared list of variables.

2 years ago0030269: Modeling Algorithms - unhandled Standard_NullObject within BRepBndLib::Add()
kgv [Fri, 19 Oct 2018 08:06:41 +0000 (11:06 +0300)]
0030269: Modeling Algorithms - unhandled Standard_NullObject within BRepBndLib::Add()

Added BRep_Tool::IsGeometric() check before every BRepAdaptor_Curve::Initialize().

2 years ago0030278: Foundation Classes - make IndexedMapNode as protected inside of NCollection_...
osa [Mon, 22 Oct 2018 08:32:46 +0000 (11:32 +0300)]
0030278: Foundation Classes - make IndexedMapNode as protected inside of NCollection_IndexedMap

2 years ago0030204: BRepOffsetAPI_MakePipeShell crash IR-2018-10-19
jgv [Fri, 12 Oct 2018 10:02:34 +0000 (13:02 +0300)]
0030204: BRepOffsetAPI_MakePipeShell crash

Add protection from type mismatch while ensuring Same Parameter on U-edges

2 years ago0030169: Application Framework - Document format version management improvement
szy [Tue, 9 Oct 2018 14:30:10 +0000 (17:30 +0300)]
0030169: Application Framework - Document format version management improvement

2 years ago0030248: Volume Rendering - importing volume with default parameters leads to crashes...
kgv [Wed, 17 Oct 2018 11:01:30 +0000 (14:01 +0300)]
0030248: Volume Rendering - importing volume with default parameters leads to crashes within OpenGl_Texture::Init3D()

2 years ago0030230: An optimal bounding box of a face is too large
ifv [Thu, 11 Oct 2018 12:52:48 +0000 (15:52 +0300)]
0030230: An optimal bounding box of a face is too large

Bug fixing
Test case added

2 years ago0030241: Test system - create option to exclude test groups from testgrid command PERF-NS
apn [Tue, 16 Oct 2018 17:24:46 +0000 (20:24 +0300)]
0030241: Test system - create option to exclude test groups from testgrid command

Add option "-exclude" to testgrid command.
It's possible to exclude groups, grids and test cases from test execution.
Add possibility to exclude subgroups from executed groups and test cases from executed subgroups\groups.

2 years ago0030215: Application Framework, TPrsStd_AISPresentation - Enable Lazy Presentation...
vro [Mon, 15 Oct 2018 12:07:52 +0000 (15:07 +0300)]
0030215: Application Framework, TPrsStd_AISPresentation - Enable Lazy Presentation Updates

2 years ago0030076: Visualization, TKV3d - API to update certain vertex attribute(s) without...
asl [Tue, 16 Oct 2018 20:17:47 +0000 (23:17 +0300)]
0030076: Visualization, TKV3d - API to update certain vertex attribute(s) without recomputing a presentation

Graphic3d_Buffer can be now optionally initialized as non-interleaved array of vertex attributes
and provides an interface to invalidate buffer sub-range tracked by OpenGl_PrimitiveArray.

2 years ago0030239: Visualization, Graphic3d_ArrayOfPrimitives - pass Graphic3d_ArrayFlags bitma...
kgv [Sun, 14 Oct 2018 11:00:46 +0000 (14:00 +0300)]
0030239: Visualization, Graphic3d_ArrayOfPrimitives - pass Graphic3d_ArrayFlags bitmask instead of dedicated Boolean flags to constructor

2 years ago0030194: Modeling Algorithms - Intersection points between line and torus are not...
ifv [Thu, 4 Oct 2018 13:06:54 +0000 (16:06 +0300)]
0030194: Modeling Algorithms - Intersection points between line and torus are not found

Calling numerical solution is implemented if analytical algorithm fails

2 years ago0030150: Modeling Algorithms - Removal of BRepAlgo_BooleanOperations and BRepAlgo_DSA...
emv [Fri, 21 Sep 2018 08:29:23 +0000 (11:29 +0300)]
0030150: Modeling Algorithms - Removal of BRepAlgo_BooleanOperations and BRepAlgo_DSAccess classes

Replacing usage of BRepAlgo_DSAccess with usage of modern Boolean operations algorithms in BRepFill_Draft.
Removing BRepAlgo_BooleanOperations and BRepAlgo_DSAccess classes.

The following classes have been removed as unused:
* BRepAlgo_DataMapOfShapeBoolean
* BRepAlgo_DataMapOfShapeInterference
* BRepAlgo_EdgeConnector
* BRepAlgo_SequenceOfSequenceOfInteger

2 years ago0030240: Visualization, OpenGl_FrameStatsPrs - chart cannot be erased
kgv [Mon, 15 Oct 2018 11:19:01 +0000 (14:19 +0300)]
0030240: Visualization, OpenGl_FrameStatsPrs - chart cannot be erased

2 years ago0030232: Visualization, StdPrs_BndBox - support Bnd_OBB in addition to Bnd_Box IR-2018-10-12
kgv [Thu, 11 Oct 2018 13:05:32 +0000 (16:05 +0300)]
0030232: Visualization, StdPrs_BndBox - support Bnd_OBB in addition to Bnd_Box

2 years ago0030144: Visualization, TKOpenGl - extend OpenGl_FrameStats with frame timers
kgv [Mon, 17 Sep 2018 15:11:05 +0000 (18:11 +0300)]
0030144: Visualization, TKOpenGl - extend OpenGl_FrameStats with frame timers

2 years ago0030221: Data Exchange - VRML is exported with inversed normals
skl [Tue, 9 Oct 2018 07:57:42 +0000 (10:57 +0300)]
0030221: Data Exchange - VRML is exported with inversed normals

Added test case bugs/xde/bug30221

2 years ago0030218: Visualization - custom selection presentation is not updated within SelectMg...
kgv [Mon, 8 Oct 2018 16:16:06 +0000 (19:16 +0300)]
0030218: Visualization - custom selection presentation is not updated within SelectMgr_SelectableObject::UpdateTransformation()

SelectMgr_SelectableObject now assigns transformation to mySelectionPrs and myHilightPrs presentations.
Removed confusing method PrsMgr_PresentableObject::UpdateTransformation() with presentation as argument.

2 years ago0030166: Visualization, TKOpenGl - add option OpenGl_Caps::glslDumpLevel dumping...
mnv [Thu, 27 Sep 2018 13:30:48 +0000 (16:30 +0300)]
0030166: Visualization, TKOpenGl - add option OpenGl_Caps::glslDumpLevel dumping the source code of the shader program

Added new option -glslcode for vgldebug command with the following values:
- off   disables glsl source code dump;
- short to dump glsl source code in short format (except common declarations);
- full  to dump glsl source code in full format.

2 years ago0030198: Regression to 7.1.0: BRepAlgoAPI_Fuse unlimited memory usage
emv [Thu, 4 Oct 2018 10:25:06 +0000 (13:25 +0300)]
0030198: Regression to 7.1.0: BRepAlgoAPI_Fuse unlimited memory usage

When refining the mesh to achieve required deflection (IntPolyh_Triangle::MultipleMiddleRefinement) limit the number of new triangles to avoid infinite loop.
Test case for the issue.

2 years ago0030207: ChFi3d_KParticular stack-use-after-scope
nbv [Mon, 8 Oct 2018 09:12:07 +0000 (12:12 +0300)]
0030207: ChFi3d_KParticular stack-use-after-scope

References to temporary objects have been eliminated.

2 years ago0030202: IntPatch_WLineTool::JoinWLines array out of bounds
nbv [Fri, 5 Oct 2018 07:50:51 +0000 (10:50 +0300)]
0030202: IntPatch_WLineTool::JoinWLines array out of bounds

The main idea of the fix is that the creation of WLine with one point is forbidden.

2 years ago0030133: Modeling Data - Crash during visualization of invalid part
ifv [Mon, 17 Sep 2018 14:13:44 +0000 (17:13 +0300)]
0030133: Modeling Data - Crash during visualization of invalid part

Control of number of recursive calls is implemented to avoid stack overflow.

2 years ago0029020: Visualization, V3d_View - workaround image dump issue on Intel OpenGL driver IR-2018-10-05
mnv [Mon, 1 Oct 2018 10:53:37 +0000 (13:53 +0300)]
0029020: Visualization, V3d_View - workaround image dump issue on Intel OpenGL driver

Implemented workaround for dump images with width >= 5462 pix on Intel OpenGl driver.
Changes according to OpenGl_Context::myVendor field in lowercase.

2 years ago0030176: Modeling Algorithms - Infinite loop in IntWalk_PWalking::Perform()
nbv [Wed, 3 Oct 2018 14:02:44 +0000 (17:02 +0300)]
0030176: Modeling Algorithms - Infinite loop in IntWalk_PWalking::Perform()

Currently resetting of counter LevelOfIterWithoutAppend is enabled only if additional iterations have taken some positive effect.

2 years ago0030189: Data Exchange - Wrong export to STEP of located root.
ika [Tue, 2 Oct 2018 15:29:40 +0000 (18:29 +0300)]
0030189: Data Exchange - Wrong export to STEP of located root.

Now roots-references in XCAF Document can be exported to STEP without losing structure of assembly/sharing/metadata of this root. New auxiliary root assembly with each root-reference is created to save all necessary data.

2 years ago0030145: Modeling Algorithms - Boolean Operations on open solids
emv [Fri, 7 Sep 2018 12:24:49 +0000 (15:24 +0300)]
0030145: Modeling Algorithms - Boolean Operations on open solids

Provide possibility to perform Boolean operations on open solids.

Implementation of the new method *BOPAlgo_Builder::BuildBOP* performing the construction of the result shape for the given type of Boolean operation.
This approach does not rely on the splits of solid to be correct and looks for the faces with necessary state relatively opposite solids to build the result solid.
The call to this method is performed from BOP algorithm in case there were open solids in the arguments.

Implementation of the draw command *buildbop* performing a call to the method above.

2 years ago0030154: [REGRESSION] Modeling Algorithms - Boolean Operation on planar geometry... IR-2018-09-28
emv [Fri, 21 Sep 2018 13:22:37 +0000 (16:22 +0300)]
0030154: [REGRESSION] Modeling Algorithms - Boolean Operation on planar geometry hangs inside BRepLib::FindValidRange()

Do not allow the precision with which the valid range is found to be less than the epsilon of the max parameter of the edge's range.
Test cases for the issue.

2 years ago0030115: Implementation of import from XCAF to VRML.
skl [Thu, 6 Sep 2018 08:18:13 +0000 (11:18 +0300)]
0030115: Implementation of import from XCAF to VRML.

2 years ago0030153: Visualization, TKOpenGl - AIS_ColoredShape::SynchronizeAspects() doesn't...
mnv [Mon, 24 Sep 2018 08:53:12 +0000 (11:53 +0300)]
0030153: Visualization, TKOpenGl - AIS_ColoredShape::SynchronizeAspects() doesn't update all aspects

AIS_InteractiveObject::SynchronizeAspects() now propagates event
to OpenGl_Group::SynchronizeAspects() which properly handles
all aspects defined within the group.

2 years ago0030156: Visualization, TKV3d - Triangles outside of selection volume are selected
asl [Mon, 24 Sep 2018 08:00:18 +0000 (11:00 +0300)]
0030156: Visualization, TKV3d - Triangles outside of selection volume are selected

The addition of elements to map is put under correct condition that element overlaps with selection volume

2 years ago0030157: Draw Harness - xwd image dump should not be limited by desktop size within...
kgv [Mon, 24 Sep 2018 08:31:40 +0000 (11:31 +0300)]
0030157: Draw Harness - xwd image dump should not be limited by desktop size within batch testing

DrawWindow now uses SWP_NOSENDCHANGING flag within batch mode to ensure
that created window is not clipped in size by desktop dimensions.

2 years ago0028949: BRepOffsetAPI_MakePipe Generated() method produces no result for spine edges
jgv [Thu, 13 Sep 2018 13:17:21 +0000 (16:17 +0300)]
0028949: BRepOffsetAPI_MakePipe Generated() method produces no result for spine edges

Add history for subshapes of spine: edges and vertices. Each edge of spine generates a shell. Each vertex of spine generates a set of edges and, possibly, faces (in the case of Round Corner).

2 years ago0030146: Visualization - exception during attempt to display Edge without geometry
kgv [Thu, 20 Sep 2018 08:40:19 +0000 (11:40 +0300)]
0030146: Visualization - exception during attempt to display Edge without geometry

StdPrs_ToolRFace no skips curves with NULL curves.
Code has been cleaned up from duplicated checks, redundant casts
and dummy Adaptor2d_Curve2dPtr typedef.

StdSelect_BRepSelectionTool::GetSensitiveForFace() now catches
Standard_NullObject exception to skip invalid Edges.

2 years ago0030136: Visualization, TKOpenGl - Graphic3d_TOSM_FACET does not work on mobile devices
mnv [Thu, 13 Sep 2018 14:47:51 +0000 (17:47 +0300)]
0030136: Visualization, TKOpenGl - Graphic3d_TOSM_FACET does not work on mobile devices

Added new type of graphic3d limit Graphic3d_TypeOfLimit_HasFlatShading.
Added workaround for unexpected behaviour of mobile devices with Adreno GPU.
Added new complex flag hasFlatShading to OpenGl_Context for indicating support of flat shading.

2 years ago0030142: Application Framework, TPrsStd_AISPresentation - Hidden Presentations Are...
vro [Tue, 18 Sep 2018 13:24:06 +0000 (16:24 +0300)]
0030142: Application Framework, TPrsStd_AISPresentation - Hidden Presentations Are Computed During Document Retrieval

2 years ago0030140: Modeling Algorithms - Access Null Pointer
nbv [Tue, 18 Sep 2018 08:10:19 +0000 (11:10 +0300)]
0030140: Modeling Algorithms - Access Null Pointer

The array TabP has been allocated correctly.

2 years ago0030143: Foundation Classes - provide operator[] alias for NCollection_Array1, NColle...
kgv [Mon, 17 Sep 2018 10:14:00 +0000 (13:14 +0300)]
0030143: Foundation Classes - provide operator[] alias for NCollection_Array1, NCollection_Vector

2 years ago0030135: Visualization, TKOpenGl - frame statistics do not include information about... IR-2018-09-14 OCCT_VC2017_73
kgv [Thu, 13 Sep 2018 14:34:08 +0000 (17:34 +0300)]
0030135: Visualization, TKOpenGl - frame statistics do not include information about instanced structures

OpenGl_FrameStats now takes into account OpenGl_Structure::InstancedStructure().
OpenGl_View::renderStructs() - fixed resetting non-culled structure counters.

2 years ago0030130: Coding Rules - MSVC 2017 gives warnings about using of std::fpos::seekpos...
abv [Wed, 12 Sep 2018 19:38:38 +0000 (22:38 +0300)]
0030130: Coding Rules - MSVC 2017 gives warnings about using of std::fpos::seekpos() within RWStl

Use of deprecated method std::fpos::seekpos() is avoided with MSVC 11 (Visual Studio 2012) and above.

2 years ago0030131: Foundation Classes - support of Linear builder for 2D BVH trees
osa [Tue, 11 Sep 2018 18:56:14 +0000 (21:56 +0300)]
0030131: Foundation Classes - support of Linear builder for 2D BVH trees

BVH_LinearBuilder and BVH_RadixSorter now accept N==2.
NCollection_Vec2/3/4 - added missing division by vec operators.

2 years ago0029988: AIS_Shape - SetWidth() and SetColor() has no effect for FaceBoundary
kgv [Mon, 10 Sep 2018 15:44:17 +0000 (18:44 +0300)]
0029988: AIS_Shape - SetWidth() and SetColor() has no effect for FaceBoundary

AIS_Shape SetWidth and SetColor methods now propagate modifications to FaceBoundary aspect.

2 years ago0030118: Draw Harness - extend vcomputehlr command with HLR algo type
kgv [Mon, 10 Sep 2018 09:25:29 +0000 (12:25 +0300)]
0030118: Draw Harness - extend vcomputehlr command with HLR algo type

vcomputehlr has been extended with -algoType argument
and sets result as DBRep shape in addition to displaying AIS_Shape.

2 years ago0030092: Modeling Algorithms - Invalid result of Section operation
emv [Wed, 29 Aug 2018 08:51:43 +0000 (11:51 +0300)]
0030092: Modeling Algorithms - Invalid result of Section operation

The following improvements have been made in Boolean operations algorithm in order to fix the problem:
1. Initialization of the pave blocks which vertices have acquired the SD ones.
2. Removing from Data Structure the small edges having the same vertices on both ends (either initially or acquired).
3. Avoid adding empty SD connections when one vertex points to itself.

Test case for the issue.

2 years ago0029986: Configuration - environment scripts generated by CMake on Linux do not allow...
apn [Wed, 29 Aug 2018 09:40:35 +0000 (12:40 +0300)]
0029986: Configuration - environment scripts generated by CMake on Linux do not allow starting DRAW from build folder

Correct launching custom.sh in env.sh.in.
Correct definition of FFMPEG_DIR in custom.build.bat/sh.in and generation of custom_*.sh (variables CSF_OCCTBinPath and CSF_OCCTLibPath are not empty on the first run)

2 years ago0030091: Configuration - allow cross-compilation from Linux (case sensitive filesyste...
abv [Thu, 6 Sep 2018 15:59:19 +0000 (18:59 +0300)]
0030091: Configuration - allow cross-compilation from Linux (case sensitive filesystem) to x86_64-w64-mingw32

Names of Windows header files are corrected to be lower case to match their actual names on Windows (except Windows.h) and MinGW.
Files COMMANDWINDOW.h and MAINWINDOW.h in Draw package are renamed to CamelCase according to names of corresponding CXX files.

2 years ago0030026: Configuration, CMake - not clear description of some fields
mnv [Thu, 9 Aug 2018 09:27:10 +0000 (12:27 +0300)]
0030026: Configuration, CMake - not clear description of some fields

Updated description for 3RDPARTY_FREETYPE_INCLUDE_DIR_freetype2 and 3RDPARTY_FREETYPE_INCLUDE_DIR_ft2build fields.

2 years ago0030094: Modeling Algorithms - Defeaturing does not work on the attached shape due...
emv [Fri, 31 Aug 2018 07:17:47 +0000 (10:17 +0300)]
0030094: Modeling Algorithms - Defeaturing does not work on the attached shape due to incorrect extension of the torus

BRepLib::ExtendFace method when working with analytical and periodic faces now takes into account the possible closeness of the result face.
Test cases for the issue.

2 years ago0030100: Modeling Algorithms - ShapeUpgrade_UnifySameDomain is unable to unify faces...
emv [Fri, 31 Aug 2018 07:07:05 +0000 (10:07 +0300)]
0030100: Modeling Algorithms - ShapeUpgrade_UnifySameDomain is unable to unify faces based on the same toroidal surface

When performing intersection of toroidal faces check first if they are based on the same surface.
Test cases for the issue.

2 years ago0029972: Intersection curve has a weird gap in the middle of it
nbv [Mon, 23 Jul 2018 11:00:16 +0000 (14:00 +0300)]
0029972: Intersection curve has a weird gap in the middle of it

1. The condition of WLine breaking (in IntWalk_IWalking algorithm) has become more independent of the input tolerance.

2. Currently the algorithm of IntPatch_Points of WLine processing depends on the algorithm of obtaining the WLine.

3. The methods IntSurf_LineOn2S::Add(...) and IntSurf_LineOn2S::SetUV(...) have become not inline (see the message ~0077431 in the issue #29866).

2 years ago0030087: Invalid result of the translation of the assembly when relating and related...
gka [Fri, 24 Aug 2018 16:08:38 +0000 (19:08 +0300)]
0030087: Invalid result of the translation of the assembly when relating and related products are mixed in the SRR entity

Detection of specific case of error in the definition of transformation matrix describing position of the component within assembly, when it has Axis Placements swapped, is corrected to handle the case when one of these Axis Placements is contained in both Shape Representations (of the assembly and its component).
This allows the problematic STEP file to be translated correctly.

Added test bugs step bug30087

2 years ago0030102: Visualization, TKOpenGl - Graphic3d_TOSM_FACET shading is incorrect in some...
mnv [Fri, 31 Aug 2018 12:14:49 +0000 (15:14 +0300)]
0030102: Visualization, TKOpenGl - Graphic3d_TOSM_FACET shading is incorrect in some casesn

gl_FrontFacing is now considered within Normal computation.

2 years ago0030093: Test system - Incorrect parsing of the regular expression
apn [Mon, 3 Sep 2018 08:52:00 +0000 (11:52 +0300)]
0030093: Test system - Incorrect parsing of the regular expression

Add "\-" to regular expression (which contained only literal, numeric and underscore character).

2 years ago0030090: Modeling Algorithms - BRepLib::FindValidRange does not find valid range...
emv [Tue, 28 Aug 2018 09:22:01 +0000 (12:22 +0300)]
0030090: Modeling Algorithms - BRepLib::FindValidRange does not find valid range for the edge

BRepLib::FindValidRange - check each sampling point to be out of tolerance sphere of the vertex.
Test case for the issue.

2 years ago0027928: BOP common produces empty compound
emv [Wed, 29 Aug 2018 06:08:13 +0000 (09:08 +0300)]
0027928: BOP common produces empty compound

BOPTools_AlgoTools::ComputeState - increase the chance of correct classification of the face relatively solid by classifying the point located inside that face instead of the point taken near the edge of that face.
Test case for the issue.

2 years ago0030082: Intersection algorithm returns curve with big tolerance value
nbv [Thu, 23 Aug 2018 13:37:59 +0000 (16:37 +0300)]
0030082: Intersection algorithm returns curve with big tolerance value

The fix inserts new points at the end of the WLine in case when the direction of the intersection curve is significantly changed.

2 years ago0030058: Visualization, Select3D_SensitivePrimitiveArray - the selection is not fast...
kgv [Fri, 17 Aug 2018 12:00:11 +0000 (15:00 +0300)]
0030058: Visualization, Select3D_SensitivePrimitiveArray - the selection is not fast enough

Select3D_SensitiveSet::Matches() has been improved to check if BVH node is fully included by selection volume
and pass this information to overlapsElement()/elementIsInside() interfaces
to avoid expensive partial overlapping checks for individual elements.
Select3D_SensitivePrimitiveArray implements this new interface to improve partial overlapping performance.
Select3D_SensitivePrimitiveArray::Matches() now handles rectangle selection for sub-elements when Elements map is defined.
Added missing const to SelectMgr_BaseFrustum::Overlaps() methods.

AIS_PointCloud has been extended with new selection mode for collecting selected nodes

Draw Harness command vdrawparray has been extended with an option -shape
allowing to create a triangulation from tessellated shape.

2 years ago0029881: Data Exchange - PMI entities ignore length Units
skl [Tue, 21 Aug 2018 14:33:03 +0000 (17:33 +0300)]
0029881: Data Exchange - PMI entities ignore length Units

2 years ago0030081: Visualization - selection does not work when two clipping planes cut object...
kgv [Thu, 23 Aug 2018 13:26:12 +0000 (22:26 +0900)]
0030081: Visualization - selection does not work when two clipping planes cut object from opposite sides

Fixed combining independent clipping planes into single range within SelectMgr_RectangularFrustum::computeClippingRange().

2 years ago0028694: IGES reader produces too small edge covered by its vertices
skl [Thu, 9 Aug 2018 09:26:20 +0000 (12:26 +0300)]
0028694: IGES reader produces too small edge covered by its vertices

Methods IsUClosed() and IsVClosed() are changed (check distance to middle point is added).

2 years ago0030068: Documentation - V3d_View::ToPixMap() description should clarify that method...
kgv [Wed, 15 Aug 2018 18:08:00 +0000 (21:08 +0300)]
0030068: Documentation - V3d_View::ToPixMap() description should clarify that method will redraw the View content before dump

2 years ago0030071: Tests - locate_data_file does not skip .git folders
kgv [Thu, 16 Aug 2018 11:42:30 +0000 (14:42 +0300)]
0030071: Tests - locate_data_file does not skip .git folders

Regexp is now applied to subfolder name to filter folders starting with dot.

2 years ago0029782: Shape Healing - Reading of invalid shape
skl [Mon, 13 Aug 2018 13:34:26 +0000 (16:34 +0300)]
0029782: Shape Healing - Reading of invalid shape

2 years agoAdjusting testing cases for VC 2017 IR-2018-08-09 JT-12-WEEK32
bugmaster [Wed, 8 Aug 2018 15:33:16 +0000 (18:33 +0300)]
Adjusting testing cases for VC 2017

2 years ago0029910: Porting to Debian80-64 : Regressions in Modeling Algorithms
nbv [Mon, 16 Jul 2018 12:32:23 +0000 (15:32 +0300)]
0029910: Porting to Debian80-64 : Regressions in Modeling Algorithms

Adjusting test cases.
Creation of new test cases.

2 years ago0030015: Documentation - Correct warnings in OCCT and PRODUCTS documentation
apn [Mon, 6 Aug 2018 13:58:02 +0000 (16:58 +0300)]
0030015: Documentation - Correct warnings in OCCT and PRODUCTS documentation

Fix warning multiple use of section label 'upgrade_740_extremaalgo' in the file upgrade.md

2 years ago0029978: Data Exchange, macOS - the result of reading some entity from STEP looks odd IR-2018-08-03 JT-12-WEEK31
abv [Thu, 26 Jul 2018 07:36:12 +0000 (10:36 +0300)]
0029978: Data Exchange, macOS - the result of reading some entity from STEP looks odd

On Apple with XCode 9.4.1 and onwards, the compiler optimization is disabled for method gp_Mat::Transpose() as optimizer generates invalid code when that method is used.
Some refactoring of the code affected by this bug.

2 years ago0029938: Visualization - SelectMgr_ViewerSelector::PickedPoint() should return point...
mnv [Mon, 23 Jul 2018 12:08:01 +0000 (15:08 +0300)]
0029938: Visualization - SelectMgr_ViewerSelector::PickedPoint() should return point lying on an object

Extended SelectBasics_PickResult structure by myObjPickedPnt field, which contained the value of the 3d point on the selected object.
Changed all Overlaps methods. Parameter theDepth replaced on object of the structure SelectBasics_PickResult. This approach will be able to add new fields to SelectBasics_PickResult structure without big changes in modules which contained Overlaps method.

2 years ago0030005: Visualization, OpenGl_Context - replace NCollection_SparseArray with NCollec...
kgv [Tue, 31 Jul 2018 19:12:04 +0000 (22:12 +0300)]
0030005: Visualization, OpenGl_Context - replace NCollection_SparseArray with NCollection_Array1 for myDrawBuffers

2 years ago0030004: Visualization, AIS_Manipulator - disable detection of Rotating circle when...
kgv [Tue, 31 Jul 2018 14:37:49 +0000 (17:37 +0300)]
0030004: Visualization, AIS_Manipulator - disable detection of Rotating circle when picking ray lies on its plane

2 years ago0029915: Porting to VC 2017 : Regressions in Modeling Algorithms on VC 2017
jgv [Tue, 17 Jul 2018 18:16:35 +0000 (21:16 +0300)]
0029915: Porting to VC 2017 : Regressions in Modeling Algorithms on VC 2017

Methods GeomConvert::ConcatG1, GeomConvert::ConcatC1, Geom2dConvert::ConcatG1, Geom2dConvert::ConcatC1 are corrected to prevent exceeding maximum degree of BSpline curve in case of closed contour.

2 years ago0029940: The method TPrsStd_AISPresentation::SetSelectionMode() seems useless for...
vro [Tue, 10 Jul 2018 11:58:08 +0000 (14:58 +0300)]
0029940: The method TPrsStd_AISPresentation::SetSelectionMode() seems useless for transactions

A boolean parameter is added with a default value to the method TPrsStd_AISPresentation::SetSelectionMode().
By default, behavior of the method is not changed. But if the parameter's value is changed to FALSE, change of selection mode for the object will not influence the transaction. In other words, the attribute will not set modified and will not put into transaction delta. This behavior suits the usual notion of the object in an application: the object has color, material, transparency, but selection mode is not a property of the object. It is a property of an operation involving the object. Therefore, it has sense to remove the method SetSelectionMode() from TPrsStd_AISPresentation. For a while, it is marked as obsolete.

2 years ago0029994: Misprint in IntWalk_PWalking::Perform(...) method
nbv [Fri, 27 Jul 2018 13:29:55 +0000 (16:29 +0300)]
0029994: Misprint in IntWalk_PWalking::Perform(...) method

In the fragment

        if (aNewPnt[0] < u1min || aNewPnt[0] > u1max ||
            aNewPnt[1] < v1min || aNewPnt[1] > v1max ||
            aNewPnt[2] < u2min || aNewPnt[2] > u2max ||
            aNewPnt[3] < v2min || aNewPnt[3] > v2max)
          break; // Out of borders, handle this later.

the parameters are compared with values obtained by IntPolyh_MaillageAffinage algorithm and do not have any relations to the domain boundaries.

This misprint has been eliminated.

2 years ago0028085: Incorrect result of CUT operation
nbv [Tue, 17 Jul 2018 09:32:14 +0000 (12:32 +0300)]
0028085: Incorrect result of CUT operation

Before the fix, small arc of circle returned as intersection result. It was connected with the fact that the circle always was limited in 0 and 2*PI points. Currently the bounds of the circle (retrieved as an intersection curve) are computed from the real domain of the arguments (there is not a snap to the fixed 0 and 2*PI points).

2 years ago0029997: Coding Rules - eliminate GCC compiler warnings -Wmaybe-uninitialized in...
kgv [Sat, 28 Jul 2018 18:18:05 +0000 (21:18 +0300)]
0029997: Coding Rules - eliminate GCC compiler warnings -Wmaybe-uninitialized in Select3D_InteriorSensitivePointSet.cxx

2 years ago0029573: ConcatenateWireC0 crashes on two edges wire
ifv [Fri, 27 Jul 2018 07:21:43 +0000 (10:21 +0300)]
0029573: ConcatenateWireC0 crashes on two edges wire

Wrong setting first/last vertices is fixed
Test case added

2 years ago0029911: Porting to Debian80-64 : Regressions in Foundation Classes IR-2018-07-27 JT-12-WEEK30
abv [Tue, 24 Jul 2018 14:45:15 +0000 (17:45 +0300)]
0029911: Porting to Debian80-64 : Regressions in Foundation Classes

Test for handles is updated according to behavior expected from modern compilers.

Performance test perf ncollection A1 is updated (valid range extended) according to measurements made on Debian 8 with GCC 4.9 and on Ubuntu 16.04 with CLang 3.8 and 6.0 and GCC 4.7, 4.9, and 5.0.

2 years ago0029859: Coding - GCC compiler warning -Warray-bounds in IntPatch_InterferencePolyhed...
abv [Thu, 26 Jul 2018 04:48:56 +0000 (07:48 +0300)]
0029859: Coding - GCC compiler warning -Warray-bounds in IntPatch_InterferencePolyhedron.cxx