msv [Wed, 1 Feb 2017 08:35:50 +0000 (11:35 +0300)]
0028327: BSplCLib can cause memory corruption in degenerated cases
The code of the methods BSplCLib::KnotForm and BSplCLib::MultForm has been made safe by giving up using of address of array item for iteration on the Array1. Also the checking for degenerated case has been added to prevent out of bounds exception.
apn [Fri, 3 Feb 2017 08:57:09 +0000 (11:57 +0300)]
Warnings on vc14 were eliminated
apn [Thu, 2 Feb 2017 16:01:54 +0000 (19:01 +0300)]
Warning on windows in QABugs_11.cxx was eliminated
abv [Sun, 29 Jan 2017 20:23:49 +0000 (23:23 +0300)]
0028404: DRAW - avoid useless preparation of display data when shape is not shown
Class DBRep_DrawableShape is changed to postpone generation of display data until the shape is actually displayed (for the first time).
Test perf draw bug28404 is added.
ski [Thu, 2 Feb 2017 13:35:21 +0000 (16:35 +0300)]
0026937: Eliminate NO_CXX_EXCEPTION macro support
Macro NO_CXX_EXCEPTION was removed from code.
Method Raise() was replaced by explicit throw statement.
Method Standard_Failure::Caught() was replaced by normal C++mechanism of exception transfer.
Method Standard_Failure::Caught() is deprecated now.
Eliminated empty constructors.
Updated samples.
Eliminate empty method ChangeValue from NCollection_Map class.
Removed not operable methods from NCollection classes.
ika [Wed, 25 Jan 2017 11:13:45 +0000 (14:13 +0300)]
0028389: Data Exchange - Import of STEP Saved Views and Clipping Planes
- new STEP entities for Saved Views
- import of STEP Saved Views
- new XCAF tool for clipping planes
- new draw commands
- update test
kgv [Mon, 30 Jan 2017 10:09:22 +0000 (13:09 +0300)]
0028407: Visualization - remove ::UpdateMode() from Graphic3d_StructureManager
abv [Thu, 2 Feb 2017 13:22:33 +0000 (16:22 +0300)]
0028403: Avoid useless calls to BRepTools::Write()
Useless writes of intermediate shapes to hardcoded paths are removed in samples\mfc\standard\02_Modeling\src\ModelingDoc.cpp
Methods IGESBRep::WriteShape(), XSControl_Utils::WriteShape() are deleted; BRepTools::Write() can be used instead.
Method TopOpeBRepBuild_Tools::DumpMapOfShapeWithState() is moved to where it is used -- TopOpeBRepBuild_Builder1_1.cxx as static function (commented out).
Unused DRAW command OCC18612 is removed.
Upgrade Guide is corrected to avoid Doxygen warnings.
kgv [Thu, 19 Jan 2017 16:29:59 +0000 (19:29 +0300)]
0028376: Visualization, AIS_ColoredShape - fix endless recursion due to misprint
kgv [Fri, 27 Jan 2017 15:16:50 +0000 (18:16 +0300)]
0028400: Visualization, Graphic3d_MaterialAspect - remove undocumented and unsupported flag EnvReflexion()
ski [Thu, 6 Nov 2014 09:39:12 +0000 (12:39 +0300)]
0023551: Move data models contained in samples subfolder of OCCT repository to common data folder
Data files from mfc samples were moved to $CASROOT/data directory.
ski [Fri, 9 Dec 2016 08:38:28 +0000 (11:38 +0300)]
0027737: Remove hardcoded paths to data folders in mfc samples
Data shapes (used in samples) were moved into CSF_OCCTDataPath location.
emv [Thu, 26 Jan 2017 05:23:51 +0000 (08:23 +0300)]
0028387: Empty result of 3D Offset operation in mode Complete JoinType Intersection
1. The smarter conditions for removing the invalid faces with inverted edges have been implemented
(BRepOffset_MakeOffset::RemoveInvalidSplitsByInvertedEdges).
2. Avoid removed (completely inside) edges in the filtering of invalid faces
(BRepOffset_MakeOffset::FilterInvalidFaces).
3. Test cases for the issue.
apl [Thu, 26 Jan 2017 09:54:30 +0000 (12:54 +0300)]
0028361: Visualization, TKV3d - buggy behavior of Transformation Persistence compiled on several Linux platforms in optimized mode
The patch fixes transformation persistence for various set of GCC compilers.
1) Optimized template-specialized operator /= for division (causes bugs)
of NCollection_Vec4 was replaced with non-specialized version.
2) NCollection_Vec4::xyz() is not used since compiler uses modifiable-reference
returning version, which invokes warning of possible strict-aliasing rules
violation and leads to incorrect behavior of the reference.
nbv [Mon, 30 Jan 2017 11:01:24 +0000 (14:01 +0300)]
0028394: Not precise extrema solution of line and circle lying in the same plane
If the line is in the circle-plane completely (or parallel to the circle-plane) then extremas and intersections in 2D-space are looked for. These case are pure analytical and solutions will be found precisely.
msv [Wed, 25 Jan 2017 15:12:18 +0000 (18:12 +0300)]
0028375: Regressions after enabling floating point signals handling in DRAW
In Bisector_BisecCC.cxx avoid division by zero when the variable N1P2P1==0.
In Bisector_BisecPC.cxx avoid creation of gp_Dir2d with zero components.
vsv [Mon, 30 Jan 2017 13:05:19 +0000 (16:05 +0300)]
0028401: Configuration - unresolved symbol OpenGl_VertexBuffer::unbindFixedColor()
nds [Thu, 26 Jan 2017 14:16:09 +0000 (17:16 +0300)]
0028365: Visualization, AIS_InteractiveContext - apply selection filter in AddOrRemoveSelected at Neutral point
kgv [Wed, 25 Jan 2017 17:26:27 +0000 (20:26 +0300)]
0028257: XCAFPrs_Style - uninitialized memory usage within ::HashCode()
XCAFPrs_Style::HashCode() function has been corrected.
XCAFPrs_Style::SetVisibility() does not reset assigned colors anymore.
abv [Thu, 2 Feb 2017 13:00:28 +0000 (16:00 +0300)]
0028371: Configuration - update system requirements page
Table of supported operating systems with versions is removed, in favor of more general statement with simple list of supported OS and architectures.
Outdated list of tested graphic cards has been dropped.
msv [Thu, 2 Feb 2017 12:57:58 +0000 (15:57 +0300)]
0028313: Extend Draw functionality with some new useful commands and features
1) In Views menu the check button item "Extended view commands" has been added. Pressing on it shows/hides the set of buttons in the main window that allow manipulating of view zoom/pan/rotate by mouse.
2) New category of commands "Vector and measurement Commands" has been added. The commands in this category allow simple calculations using 2D and 3D vectors, such as cross and dot products, computation of distances of points to other objects, and other functions.
3) The new command "pickf" has been added in "DRAW Variables management" category. It allows extracting a picked with mouse face included in some shape as a new variable.
4) New commands "del" and "era" have been added in "DRAW Variables management" category. They allow deleting (destructing) or erasing (from view) variables matched by glob pattern.
5) Missing help for some commands like "don", "disp" and others has been added.
kgv [Wed, 25 Jan 2017 14:51:03 +0000 (17:51 +0300)]
0028391: Foundation Classes - OSD_Directory returns incorrect protection flags for shared directory on Windows
Redirect Folder reading flags to File reading flags when Folder flags are not found.
apn [Thu, 26 Jan 2017 17:05:11 +0000 (20:05 +0300)]
Correct warning on vc 14 (caused by #26007)
apn [Thu, 26 Jan 2017 13:51:00 +0000 (16:51 +0300)]
Add new package XCAFView to UDLIST (issue #28044)
akz [Fri, 11 Nov 2016 14:59:23 +0000 (17:59 +0300)]
0026007: Standard attribute for surface meshes in TDataStd
nbv [Wed, 25 Jan 2017 08:14:41 +0000 (11:14 +0300)]
0026745: Boolean Cut produces invalid result
Creation of test cases for issues #26745 and #26748
emv [Mon, 9 Jan 2017 06:50:03 +0000 (09:50 +0300)]
0028284: Avoid classification of sub-shapes of arguments of BOPs relatively solids during Intersection phase
1. The methods PerformVZ, PerformEZ, PerformFZ and PerformZZ have been transferred from BOPAlgo_PaveFiller to BOPAlgo_CheckerSI class
to perform intersection of sub-shapes with solids only in self-intersection mode.
2. The checks for solids built from the same (shared) faces have been added into methods building the result of Boolean operations -
BOPAlgo_BOP::BuildRC() and BOPAlgo_BOP::BuildSolid().
3. Since the NonDestructive mode is now natively supported by the BOPAlgo_PaveFiller the methods providing the support of this mode by CheckerSI
(BOPAlgo_CheckerSI::PrepareCopy() and BOPAlgo_CheckerSI::PostTreatCopy()) are not needed and have been removed.
4. The pairs of sub-shapes with interfering bounding boxes are now sorted before real intersection to guarantee the constant order of
intersection of sub-shapes and produce more stable result. The class BOPDS_PassKey has been replaced with simpler class BOPDS_Pair.
5. The class BOPDS_SubIterator has been refactored.
6. Test cases for the issue.
7. Adjustment of the test case boolean volumemaker D2.
nbv [Thu, 26 Jan 2017 10:33:50 +0000 (13:33 +0300)]
0027252: Implicit-implicit intersection (Cylinder-Plane) loses intersection curve
1. Earlier we could not put any IntPatch_Point to the intersection curve. The fix makes the algorithm of IntPatch_Points searching more precise. It is achieved by redetermination of earlier found vertices with help of minimization the distance between boundary of one intersection argument and another intersection argument (surface).
2. Additional check has been added, if IntPatch_Point adjusted to the domain boundary is true intersection point.
3. Method Contap_ArcFunction::Surface() has been added.
4. Method LastComputedPoint() has been added for IntPatch_ArcFunction and Contap_ArcFunction classes.
5. Correction in FindMaxDistance() method (see IntTools_FaceFace.cxx file) according to pure Golden-ratio minimization algorithm. Earlier this function worked wrong with small searching intervals.
6. Insignificant correction in math_BrentMinimum.cxx file (elimination of "defines").
Creation of test case for issues #27221 an #27252.
Adjusting some test cases according to their new behavior.
Correction according to the last remarks.
Small correction of shape names for issue CR27252
Test case for issue 28210
Small correction of test case for issue 28210
ski [Tue, 24 Jan 2017 09:52:41 +0000 (12:52 +0300)]
0028384: Add FPE signals enabling from MSVC
Variable CSF_FPE was added to the file adm/templates/DRAWEXE.vcxproj.user.in
ika [Wed, 19 Oct 2016 15:31:56 +0000 (18:31 +0300)]
0028044: Data Exchange - implement data structures for Saved Views
Add new root label in Document for Views.
Add new attribute to store View in XDE.
Add object and tool to process Views.
Add new Draw commands for Views.
kgv [Wed, 18 Jan 2017 07:59:35 +0000 (10:59 +0300)]
0028367: Draw Harness - XSave should print an error on store failure
ifv [Thu, 26 Jan 2017 10:19:20 +0000 (13:19 +0300)]
0028261: Chamfer fails on edge connected to cone's seam
Method GetType() of class GeomAdaptor_SurfaceOfRevolution was modified to create plane instead Cone or SurfaceOfRevolution for "plane like" within Precision::Confusion() restricted object.
For infinite objects Cone with semiangle > PI/2 - eps is replaced by SurfaceOfRevolution for eps < Precision::Confusion()
Tests cases are added
Small correction of shape names for issue CR28261_28266
nbv [Mon, 23 Jan 2017 08:05:16 +0000 (11:05 +0300)]
0028381: Draw Harness - DRAWEXE hangs up immediatly when redirecting input stream on Windows
dbp [Thu, 26 Jan 2017 09:56:13 +0000 (12:56 +0300)]
0028129: Visualization, Path Tracing - Improve interactivity in "steady" rendering mode
Re-basing the patch on current master.
nbv [Fri, 20 Jan 2017 08:15:23 +0000 (11:15 +0300)]
0028373: Incomplete section between cylinder and plane
Test case has been created.
ifv [Thu, 26 Jan 2017 09:51:09 +0000 (12:51 +0300)]
0028230: Convert C0 2d curve to C1 raises exception
The treatment of small curves (length of curves is less then tolerance used for checking G1) is added in
Geom2dConvert_CompCurveToBSplineCurve.cxx
azv [Tue, 15 Nov 2016 09:17:45 +0000 (12:17 +0300)]
0027383: Modeling - improve handling of regularity on edges
1. There has been implemented calculation of all possible types of continuity for shared edges:
* G1 is set if tangential planes are the same for connected faces in each control points through the edge;
* C1 is set in addition to G1 conditions if derivatives, orthogonal to the edge on each face, are equal vectors;
* G2 is set in addition to G1 if the centers of principal curvatures are the same for connected faces in each control points through the edge;
* C2 is set in addition to C1 and G2 if directions of principal curvatures are equal;
* CN continuity is set only if both connected faces are based on elementary surfaces (the conditions for this case are similar to C2 continuity).
2. ShapeFix::EncodeRegularity() is merged into BRepLib::EncodeRegularity().
3. Implemented several test cases to check correct handling of regularity.
4. Fix incorrect usage of BRepLib::EncodeRegularity() in BRepBuilderAPI_Sewing.
5. Implement a method for calculation of regularity on the given list of edges.
6. Documentation updates
kgv [Thu, 29 Dec 2016 17:39:28 +0000 (20:39 +0300)]
0028263: Coding Rules - clean up definition of the class Graphic3d_MaterialAspect
Fixed uninitialized fields in several classes.
Body of trivial methods have been moved to class definition (header file).
Ensure that non-primitive types are returned by reference, when possible.
Removed unused class Prs3d_PlaneSet.
apn [Thu, 19 Jan 2017 16:38:41 +0000 (19:38 +0300)]
Correct QAcommand OCC28310 according to changes in CR28088_3
Benjamin Bihler [Thu, 19 Jan 2017 13:48:08 +0000 (16:48 +0300)]
0028355: Stating wrong parent class in DEFINE_STANDARD_RTTIEXT is not recognized during compilation
Added compile-time checks (static_assert) in DEFINE_STANDARD_RTTI*(A,B) macros to check that A is actually the class being defined, and B is its base class.
For GCC compiler version 4.7 and later on, check ensures that B is direct base class of A.
Fixed dubious RTTI definitions.
dbp [Wed, 18 Jan 2017 08:30:08 +0000 (11:30 +0300)]
0028368: TKMath, BVH -- Fix invalid tree height in QBVH
dbp [Wed, 18 Jan 2017 11:24:13 +0000 (14:24 +0300)]
0028369: Visualization, Path Tracing - Expose radiance clamping setting in path tracing mode
New parameter was added in the vrenderparams command:
vrenderparams -maxrad <value>
ski [Tue, 13 Dec 2016 12:30:45 +0000 (15:30 +0300)]
0028198: Add FPE signals enabling from CMake
CMake variable BUILD_ENABLE_FPE_SIGNAL_HANDLER was added to enable FPE signals during runtime.
Updated description of BUILD_ENABLE_FPE_SIGNAL_HANDLER_DESCR variable.
apl [Wed, 18 Jan 2017 11:20:51 +0000 (14:20 +0300)]
0028310: Visualization - crash on iteration through detected interactive objects
AIS_InteractiveContext::Remove (anIObj, ...) removes object from sequence of detected owners.
Therefore further iteration on detected will not require updating this list with ::MoveTo().
Additional modification includes incrementing properly the iterator of CurrentDetectedObject
and resets iterator of Highlighted detected objects, because nothing is really highlighted after that.
abv [Mon, 7 Nov 2016 12:06:32 +0000 (15:06 +0300)]
0028058: TObj_Object::Clone() does not copy TagSource attributes of children of second level
Handling of children objects located on sub-labels of the main child label is enabled in method CopyChildren(); TagSource attributes for such children are copied in method Clone()
ski [Thu, 19 Jan 2017 13:31:17 +0000 (16:31 +0300)]
0027691: Remove dchrono from all test cases and move its to perf group
Remove performance comparing with hardcoded value.
Test cases for performance of some commands were moved to perf group.
Updated documentation.
aan [Thu, 29 Dec 2016 14:44:07 +0000 (17:44 +0300)]
0028324: Configuration, genproj.tcl - compilation error while targeting OS X 10.8 or lower in XCode
Specify libc++ as C++ library compatible with C++11 instead of libstdc++ which is no more updated within XCode.
kgv [Tue, 3 Jan 2017 13:58:41 +0000 (16:58 +0300)]
0028306: Visualization - viewer crashes if style for shaded display is set to HATCH
Fixed NULL-dereference in OpenGl_Context::SetPolygonHatchStyle().
ssv [Thu, 19 Jan 2017 13:22:32 +0000 (16:22 +0300)]
0028055: Add UpdateAssemblies() method for top-down update of assembly compounds
- Implement top-down update for assemblies in XCAFDoc_ShapeTool
- Get rid of UpdateAssembly() method used for partial (parent-only) update
- Adjust STEP and IGES translators to use the top-down update after filling OCAF
- Implement XUpdateAssemblies Draw command
- Add test cases bug28055_1 and bug28055_2 for component removal and part update
- Update XDE documentation to mention the new UpdateAssemblies() method
Correction for issue CR28055
Adjusting of test case bugs/fclasses/bug28217
kgv [Sun, 15 Jan 2017 11:43:41 +0000 (14:43 +0300)]
0028350: Draw Harness - DRAWEXE hangs up immediatly when redirecting input stream on Windows
Fallback using fgetws() instead of ReadConsoleW() for reading input from a pipe.
kgv [Fri, 13 Jan 2017 17:24:11 +0000 (20:24 +0300)]
0027585: It is not possible to store OCAF documents to paths with special characters in their names
TCollection_AsciiString - fixed inproper convertion from UTF-16 string.
Benjamin Bihler [Fri, 13 Jan 2017 12:29:58 +0000 (13:29 +0100)]
0028353: Samples - IESample cannot write files to paths with special characters
Changed charcode conversion to UTF-8.
emv [Thu, 12 Jan 2017 12:08:27 +0000 (15:08 +0300)]
0028343: Modeling: ShapeUpgrade_UnifySameDomain algorithm produces invalid shape
Check coincidence of the normal directions of the adjacent faces to understand if the merging of these faces is possible.
Test cases for the issue.
ika [Thu, 19 Jan 2017 13:05:09 +0000 (16:05 +0300)]
0028315: Data Exchange - Import/Export GD&Ts without semantic
Implement import/export of Dimensions without semantic.
Add new type of dimension for GDTs with presentation and connecting to shapes.
Update test cases.
Small corrections for issue CR28315
nbv [Thu, 19 Jan 2017 13:02:29 +0000 (16:02 +0300)]
0028214: Make the class GeomPlate_BuildPlateSurface accept Adaptor3d_HCurve instead of Adaptor3d_HCurveOnSurface
Now, GeomPlate_BuildPlateSurface accepts base class Adaptor3d_HCurve and of course array of Adaptor3d_HCurve.
Classes GeomPlate_Array1OfHCurveOnSurface and GeomPlate_HArray1OfHCurveOnSurface have been renamed to GeomPlate_Array1OfHCurve and GeomPlate_HArray1OfHCurve correspondingly.
Documentation has been updated.
Correction in documentation.
isk [Tue, 27 Dec 2016 10:24:08 +0000 (13:24 +0300)]
0028088: Visualization, AIS_InteractiveContext - drop default value for Update Viewer parameter
apn [Thu, 29 Dec 2016 17:24:44 +0000 (20:24 +0300)]
Fix compilation error on vc12 (MSVC++ 12.0)
apn [Thu, 29 Dec 2016 17:02:35 +0000 (20:02 +0300)]
Corrections for MacOS genproj.tcl (branch CR26866)
kgv [Wed, 28 Dec 2016 16:10:24 +0000 (19:10 +0300)]
0028312: Configuration, genproj.tcl - support CSF_ZLIB and CSF_LIBLZMA within project generator
Added CSF_ZLIB for searching zlib library, CSF_LIBLZMA for liblzma library
and CSF_FFmpeg for FFmpeg framework.
Unused CSF_AviLibs has been dropped.
emv [Thu, 29 Dec 2016 12:42:08 +0000 (15:42 +0300)]
0028189: Result of Boolean operation is non-manifold wire
1. The result of Boolean operation on the arguments of collection type, containers WIRE/SHELL/COMPSOLID, is also a collection.
The containers of type WIRE included into result should now also (as the SHELLs) have coherent orientation of its sub-shapes.
For that the new method has been implemented (BOPTools_AlgoTools::OrientEdgesOnWire(TopoDS_Shape&)) which reorients edges for correct ordering.
The duplicating containers, i.e. containers with the contents completely included in other containers, are now avoided in the result of BOP.
2. The result of Fuse operation on Compsolids is now also will be Compsolid.
3. Documentation has been updated.
4. New test cases for the issue.
5. Adjusting test cases to current behavior.
Correction of test case bugs/modalg_4/bug726_2 according to the new behavior
ika [Tue, 20 Dec 2016 12:12:09 +0000 (15:12 +0300)]
0028235: Data Exchange - DG&T datum XCAF object has incomplete list of shape references
Update STEP import and export of datums.
Update test cases.
ski [Thu, 22 Dec 2016 17:54:00 +0000 (20:54 +0300)]
0026866: Configuration, genproj - ensure consistency between FILES and actual content of inc and src folders
Added check of consistency between FILES and actual content of inc and src folders in genproj procedure.
ski [Thu, 15 Dec 2016 09:44:36 +0000 (12:44 +0300)]
0028197: Configuration - support Eigen template library as external dependency
Supporting of "Eigen" third party was added to CMake build procedure.
vpa [Wed, 28 Dec 2016 12:52:31 +0000 (15:52 +0300)]
0028047: Visualization - support objects with customized highlighting in AIS_InteractiveContext
- SelectMgr_SelectableObject::ClearHighlighted method is added to remove dynamic highlight data;
- interactive context will pass processing of dynamic highlight erase to the object if the owner returns false in SelectMgr_EntityOwner::IsAutoHilight;
- if owner returns true in SelectMgr_EntityOwner::IsForcedHilight, selection presentation will be re-highlighted at each ::Select call;
- redundant logic related to old object-oriented highlight mechanism was removed from AIS_InteractiveContext::MoveTo.
emv [Fri, 23 Dec 2016 13:04:25 +0000 (16:04 +0300)]
0028273: Inefficient implementation of the BRepOffset_MakeOffset::BuildSplitsOfFace function
The method for building splits of the face BRepOffset_MakeOffset::BuildSplitsOfFace has been redesigned to use the BOPAlgo_BuilderFace algorithm directly.
The methods FindInvalidFaces and TrimNewIntersectionEdges have been corrected to avoid possible instabilities.
The filtering of invalid edges by existing bounding edges has been corrected to avoid removal of valid splits.
The method BRepOffset_Analyse::Correct2dPoint has been modified to avoid unnecessary initialization of BRepAdaptor_Surface.
Adjustment of the test cases.
Test case bugs modalg_6 bug26513 has been modified to unify faces of the input shape before operation.
msv [Mon, 26 Dec 2016 12:31:14 +0000 (15:31 +0300)]
0028283: The command bopcheck crashes on the given shape
BOPAlgo_CheckerSI crashed due to building of pcurve for an edge not lying on surface. The fix avoids building of pcurves in this algorithm.
The new flag has been added in BOPAlgo_PaveFiller class (method SetAvoidBuildPCurve). It tells whether to avoid building pcurves. It is worth to set if the result is not used to create splits of faces, as in example with BOPAlgo_CheckerSI.
abv [Thu, 29 Dec 2016 11:37:42 +0000 (14:37 +0300)]
0028217: Error handling is not thread safe and causing memory corruption and sporadic crashes
Static variable holding handle to the last raised exception is made thread-local on compilers that support C++11 keyword thread_local (MCVC++ 14+, GCC 4.8+, ICC 14+, CLang).
Test bugs fclasses bug28217 is added (BAD on vc < 14 and gcc < 4.8).
Test case tuning bugs/fclasses/bug28217
isk [Tue, 27 Dec 2016 08:19:21 +0000 (11:19 +0300)]
0028285: Configuration - add missing macro Standard_EXPORT to OpenGl_StateInterface subclasses
kgv [Sun, 25 Dec 2016 17:07:39 +0000 (20:07 +0300)]
0028281: Draw Harness - remove unused command vperf
kgv [Fri, 23 Dec 2016 18:21:00 +0000 (21:21 +0300)]
0028276: Visualization, Graphic3d_ArrayOfPrimitives - fix usage of 16-bit indices
Graphic3d_ArrayOfPrimitives now check the amount of vertex data rather than amount of indices.
ski [Mon, 14 Nov 2016 11:31:00 +0000 (14:31 +0300)]
0028110: Configuration - specify Unicode charset instead of multibyte in project files for Visual Studio
Eliminated usage of ANSI methods.
All Visual Studio projects generated by genproj or CMake use Unicode character set.
Draw Harness now handles Unicode input on Windows.
Tcl test scripts are now expected in UTF-8 encoding by default.
ifv [Fri, 16 Dec 2016 11:26:42 +0000 (14:26 +0300)]
0028223: Projection of closed curve onto cylinder is wrong
Algorithm of calculation UV bounds of projected curve for periodic surfaces is modified.
ski [Wed, 21 Dec 2016 10:41:04 +0000 (13:41 +0300)]
0028135: Configuration - adopt building script for using built-in Android cross-compiling support in CMake 3.7
Added toolchain file for using built-in Android cross-compiling support in CMake 3.7
Added variable CMAKE_ANDROID_STL_TYPE for Android platform build via CMake.
Updated documentation about building of occt for UWP and Android via CMake.
Eliminated CMake warning CMP0054 for Android platform build.
apn [Fri, 23 Dec 2016 07:10:55 +0000 (10:10 +0300)]
Warnings on vc14 were eliminated
isk [Thu, 22 Dec 2016 09:53:46 +0000 (12:53 +0300)]
0028244: Visualization - AIS_AngleDimension throws exception for 180 degree
Small correction of test case for issue CR28244
ika [Tue, 20 Dec 2016 10:25:02 +0000 (13:25 +0300)]
0028250: Data Exchange - Wrong number of geometric tolerance modifiers.
fix some copy paste mistakes,
update test cases.
kgv [Sun, 18 Dec 2016 07:18:55 +0000 (10:18 +0300)]
0028232: Visualization, StdPrs_ShadedShape - create WireFrame presentation for sole Vertex / Edge / Wire
kgv [Thu, 22 Dec 2016 09:48:16 +0000 (12:48 +0300)]
0028180: Visualization, TKOpenGl - Performance of Shaded presentation dropped due to FFP disabled by default
FFP state management (light sources, matrices, clipping planes) has been
moved to OpenGl_ShaderManager for consistency with Programmable Pipeline.
OpenGl_Context::BindProgram() does not re-bind already active Program.
OpenGl_PrimitiveArray::Render() does not reset active Program at the end.
OpenGl_Context::ApplyModelViewMatrix() now checks if matrix differs
from already set one before modifying state in Shader Manager.
This allows avoing redundant state changes, matrix uploads onto GPU
and re-computation of inversed matrices.
NCollection_Mat4 has been extended with equality check operators for proper comparison.
OpenGl_ShaderManager - the tracking Material state has been added.
Removed unreachable states OPENGL_NS_RESMAT, OPENGL_NS_TEXTURE and OPENGL_NS_WHITEBACK.
Fixed resetting FFP material state after displaying GL_COLOR_ARRAY vertices;
the Material state within Shader Manager is now
invalidated within OpenGl_VertexBuffer::unbindFixedColor().
OpenGl_Workspace::ApplyAspectFace() - fixed invalidating Material State
when only Highlighting style is changing.
isk [Fri, 9 Dec 2016 10:50:40 +0000 (13:50 +0300)]
0028205: Visualization - add functionality for dumping results of detection algorithms into image
StdSelect_ViewerSelector3d::ToPixMap() - added new method for dumping
detection results into an image.
dbp [Mon, 19 Dec 2016 11:00:09 +0000 (14:00 +0300)]
0028241: Visualization, Path tracing - shader compilation error on Radeon 290
msv [Thu, 22 Dec 2016 09:43:48 +0000 (12:43 +0300)]
0028221: General Fuse operation error
The method BOPTools_AlgoTools2D::AttachExistingPCurve has been corrected so that
to call BRepLib::SameParameter not on the target edge with the whole set of pcurves,
but rather on a temporary edge with 3D curve and copied pcurve only.
After that the updated pcurve is transferred to the target edge.
Small correction of test case for issue CR28221
abv [Sun, 18 Dec 2016 06:21:54 +0000 (09:21 +0300)]
0028240: Avoid redundant search for span index in evaluation of BSpline cache
ski [Thu, 22 Dec 2016 09:40:55 +0000 (12:40 +0300)]
0028204: TopoTools_ShapeSet::Dump() does not show flag Locked
Corrected command dump to show flag Locked for shapes in DRAW.
Test case for issue CR28204
Updated test case.
kgv [Thu, 22 Dec 2016 09:39:13 +0000 (12:39 +0300)]
0028004: Visualization, AIS_ColorScale - allow defining labels list not equal to intervals list
Cosmetics, code clean up.
AIS_ColorScale now draw labels using Graphic3d_VTA_CENTER
vertical alignment flag, instead of incorrect own alignment logic.
The color bar now adds margin on the top simmetrical to the bottom.
AIS_ColorScale::SetSmoothTransition() - added new property
for displaying colorscale with smooth transition between color intervals.
AIS_ColorScale::SetHueRange() - added new property defining the hue angles
corresponding to minimal and maximum values on the color scale.
AIS_ColorScale::SetLabels() now allows setting the sequence of free labels,
which number does not match the number of intervals.
In this case the labels will be displayed at positions of virtual
intervals corresponding to the number of labels.
msv [Wed, 14 Dec 2016 07:09:38 +0000 (10:09 +0300)]
0028183: Modeling - BRepExtrema_DistShapeShape does not find all solutions
Disable SetSingleSolutionFlag when calling algorithm of curve-curve Extrema.
Now DistShapeShape will find all solutions, even if they are located on the same pair of edges.
The fix brings the speed down for the cases of coinciding curves.
msv [Fri, 16 Dec 2016 14:13:07 +0000 (17:13 +0300)]
0028233: lvarpop is needed for correct work of lmatch defined in StandardCommands.tcl
The proc lvarpop has been implemented.
apn [Fri, 16 Dec 2016 09:20:05 +0000 (12:20 +0300)]
Added procedure lmatch for test case in branch CR28196_1
apn [Fri, 16 Dec 2016 09:17:19 +0000 (12:17 +0300)]
Warnings is IntPatch_ImpImpIntersection_4.gxx on unix platforms and in ViewerTest.cxx on win32 vc14 were eliminated
msv [Fri, 16 Dec 2016 08:59:13 +0000 (11:59 +0300)]
0028017: Unexpected result of General Fuse operation
Several improvements have been made in BO code to fix the bug:
- Create empty edge-edge interference if intersection is close to an end vertex. This will help to avoid creation of unnecessary edge-face intersections.
- Improve PutPaveOnCurve() method to join nearly located vertices when they are put on the same section curve.
- Add processing of same-domain vertices for section edges in UpdatePaveBlocks() method.
- Improve the method CorrectWires() in order to not increase vertex tolerance if it will cover the major part of an edge.
- Replace vertices of section edges by same-domain equivalents.
- In the algorithm BOPAlgo_WireSplitter, correct angles computation and evaluation, taking into account periodicity.
- Modify PostTreatFF to properly take into account the orientations of coinciding section edges.
- In IntTools_Context::ComputePE, check distance from the point to vertices of the edge if the projection to the curve is failure.
Tests update:
- test offset\faces_type_i\C9 has been updated; now instead of returning bad shape it returns null result.
Notes for porting:
- Modify BopAlgo_PaveFiller so that on output each interference refers to the new vertex that will hit in the result (same-domain of the initial new vertex).
- Make the method BOPDS_DS::Index() returning valid index for new shapes.
// eliminate compile warning on VC14
abk [Tue, 6 Dec 2016 18:42:11 +0000 (21:42 +0300)]
Test for
0028196: Algorithm 'Extrema_GenLocateExtPS' failed to find the extremum in a case
Draw command 'proj' has been improved:
- Add possibility to pass the starting point. If it is passed than the algorithm Extrema_GenLocateExtPS is used instead of standard projection.
- Make the output of the command more clear.
Test case bugs/moddata_3/bug28196 has been added.
kgv [Wed, 2 Nov 2016 14:36:18 +0000 (17:36 +0300)]
0025695: Visualization, AIS_InteractiveContext - define default HilightMode
AIS_InteractiveContext - removed the following unused properties:
- PreSelectionColor(), DefaultColor(), WasCurrentTouched(), ZDetection().
AIS_InteractiveObject - removed unused property SelectionPriority().
Prs3d_Drawer - removed properties HighlightStyle() and SelectionStyle().
Graphic3d_HighlightStyle has been superseded by Prs3d_Drawer
inheriting from new class Graphic3d_PresentationAttributes.
Graphic3d_PresentationAttributes (as Graphic3d_HighlightStyle replacement)
has been extended with new properties:
- ZLayer() defining Z-Layer for highlighting presentation.
- DisplayMode() defining display mode for highlighting.
StdSelect_BRepSelectionTool methods have been corrected to take
SelectMgr_EntityOwner instead of StdSelect_BRepOwner.
StdSelect_Shape - duplicated field myDrawer has been dropped.
AIS_InteractiveObject - myDrawer->Color() is now used instead of myOwnColor,
myDrawer->Transparency() instead of myTransparency
and myDrawer->ZLayer() instead of myZLayer.
PrsMgr_PresentationManager::Unhighlight() now unhighlight all modes.
The method taking Mode as argument has been marked deprecated.
New enumeration Prs3d_TypeOfHighlight has been introduced
defining different highlight types.
AIS_InteractiveObject::HighlightStyle() now takes enumeration argument
and defines different styles for Global and Local selection.
ComesFromDecomposition() property has been moved
from StdSelect_BRepOwner to SelectMgr_EntityOwner.
isk [Mon, 28 Nov 2016 09:11:43 +0000 (12:11 +0300)]
0028162: Draw Harness - eliminate usage of deprecated Local Context
Create a general draw command 'VRelation' and drop the old 'relation' commands.
Add test cases for new draw command "vrelation".
Add two new methods: Activate and Deactivate which activate/deactivate the given selection mode for all displayed objects.
Eliminate deprecated local context methods in ObjectCommands, QABugs.
Eliminate deprecated local context methods in mfc standard sample and qt samples.
kgv [Mon, 12 Dec 2016 09:54:25 +0000 (12:54 +0300)]
0028213: Visualization, StdPrs_ShadedShape - compute face edges for triangulation-only Faces
kgv [Tue, 13 Dec 2016 09:36:41 +0000 (12:36 +0300)]
0028215: Visualization - define EMPTY type line for consistenct with Interior Style
Added new values Aspect_TOL_EMPTY (line type) and Aspect_TOM_EMPTY (marker type).
aml [Thu, 15 Dec 2016 13:32:52 +0000 (16:32 +0300)]
0028175: Bad result of curve-curve extrema
Extrema between curves has been made producing correct result for the cases of solution located near bounds.
- Class math_GlobOptMin has been improved to use lower order methods of local optimization when high-order methods are failed.
- Add support of conditional optimization (in bounds) in the classes math_BFGS and math_BracketMinimum.
- Turn on conditional optimization in the case of usage of math_BFGS in the class math_GlobOptMin.
- Correct mistake in distmini command, which caused incorrect reading of deflection parameter.
- To avoid possible FPE signals, ensure initialization of fields in the class math/math_BracketMinimum.
- In the algorithms math_BFGS, math_Powell and math_FRPR, take into account that the function math_MultipleVarFunction can return failure status (e.g. when computing D0 out of bounds).
New test cases have been added.
Tests cases are updated.
// correct test case
vpa [Tue, 15 Nov 2016 18:05:52 +0000 (21:05 +0300)]
0028107: Visualization - provide a flexible interface to set custom hatch styles
- class Graphic3d_HatchStyle is added to provide a possibility to set up custom and predefined hatching;
- added the ability to set custom hatch patterns through bitmaps;
- test case for issue #28107
aml [Fri, 9 Dec 2016 15:15:58 +0000 (18:15 +0300)]
0028201: Add square PConfusion() method to the Precision class
Method SquarePConfusion has been added to simplify code.
nbv [Thu, 24 Nov 2016 12:07:52 +0000 (15:07 +0300)]
0025187: Document the algorithm used in the fixes for issues ##
0024915 and 25194
1. Algorithm of orthogonalize of the transformation matrix (in gp_Trsf(2d) classes) has been documented.
2. Algorithm of computation of intersection line in case of two intersected cylinders (implemented in the fix for issue #24915) has been documented. Additionally, I would like to tell about some advantages of new algorithm in compare with old one.
2.1. Both algorithm generates intersection points for Walking-line (WL), which will be approximated to B-spline curve(s) in the future. At that, new algo (in compare with old one) uses another method for step computation. It based on attempts to provide equal steps (if it is possible) along V-direction (instead of U-direction used in old algorithm). It allows obtaining set of points, which are more uniform distributed in compare with old algo (this problem is the main reason why case #24915 was failed). Of course, we will get non-uniform distribution along U-direction. However, it can be compensated by small range (its length is less or equal 2*PI) of U-parameter change, whereas range of V-parameter can be very big.
2.2. More simple estimation of curvature "jump". New algo aims at provide equidistant distribution of points along V-direction. If it requires "jump" of U-parameter then we have "jump" of curvature in this point. This check is implemented in function AddPointIntoWL(...) (see place where SeekAdditionalPoints(...) is called).
However, in OCCT 7.1.0, curvature jumping is analyzed (it was not earlier, when the bug #24915 was fixed) - see fix for issue #27431.
2.3. New algorithm allows obtaining 7D-intersection point immediately. At that, old algorithm computed only 2D-intersection point (on some one surface). After that, it computed 3D-intersection point and, finally, projected(!) 3D-point to the second surface in order to obtain second 2D-intersection point. This second projection results in some problems. One problem is described in the issue #27968 (see message ~
0058807). Second problem is the process of cases with singularity (significant improvement in this direction has been made in the fix #27431). Third problem is difficulties in projection itself (e.g. if we project point to a sphere when V-coordinate of the projection is near to PI/2 - projection point is found but not precise; the reason is not singularity but small radius of V-isoline).
Method used in new algorithm allows avoiding these problems. However, at present, it is implemented for case of two cylinders intersection (where most of these problems are not actual).
2.4. Algorithm of search of intersection point on surface boundary(ies) has been changed, too. Old algorithm sought point on boundary irrespective of intersection line. It resulted in problems described in the issue #27252 and related. New algorithm looks for intersection point of intersection line with surface boundary. It requires rectangular domain. However, it is not problem for current OCCT-version.
kgv [Thu, 8 Dec 2016 15:16:14 +0000 (18:16 +0300)]
0028202: Coding rules - eliminate compiler warnings on HLRAlgo.hxx
Redundant forward declarations have been removed from HLRAlgo.hxx.
aml [Fri, 9 Dec 2016 10:11:34 +0000 (13:11 +0300)]
Warnings in BRepOffset_SimpleOffset.cxx on vc14 were eliminated