kgv [Tue, 1 Nov 2016 18:36:24 +0000 (21:36 +0300)]
0028036: Visualization, AIS_ColoredShape - handle correctly nested compounds within Shaded display mode
AIS_ColoredShape::Compute() now parses nested compounds in two passes
to handle complex cases with compounds used for grouping styles.
msv [Mon, 7 Nov 2016 12:49:54 +0000 (15:49 +0300)]
0028053: Regressions in HLR when FPE signals are enabled
Protect Contap_Contour from creation of null-length curves.
nbv [Mon, 7 Nov 2016 15:48:37 +0000 (18:48 +0300)]
0028054: Regression: Class BRepProj_Projection gives invalid result after projection edge based on the line on the conical surface
Problem of projection of line on the cone in the special case when starting point of the line coincides with the cone apex is fixed (by shifting this point along the source line).
kgv [Tue, 8 Nov 2016 09:30:31 +0000 (12:30 +0300)]
0028072: Samples - remove deprecated vector export from MFC sample
ski [Tue, 8 Nov 2016 14:26:23 +0000 (17:26 +0300)]
0028068: Samples - Add dimension functionality shows incorrect tip for an Edge in mfc Viewer3d
Warning message was updated to show actual information.
Additional checking of type of shape was added to prevent exceptions for Add Dimension functionality.
abv [Tue, 8 Nov 2016 04:22:06 +0000 (07:22 +0300)]
0028066: Samples - mfc ocaf sample could not read/save any document without environment variables
Persistence libs are loaded using DefineFormat() in OCAF sample
msv [Mon, 7 Nov 2016 17:05:58 +0000 (20:05 +0300)]
0028065: [Regression to 7.0] The method HLRAppli_ReflectLines::GetResult must be const
ski [Tue, 8 Nov 2016 11:57:46 +0000 (14:57 +0300)]
0028064: Samples - Raytracing does not work in Qt samples
QAction signal activated() was changed to signal triggered() to support Qt5.
kgv [Tue, 8 Nov 2016 09:30:31 +0000 (12:30 +0300)]
0028060: Samples - Objects in Geometry/Viewer2d have incorrect color
Broken custom presentations Sample2D_Text and ISession_Text
have been replaced by AIS_TextLabel.
ISession2D_Curve::Compute() - fixed defining the group without presentation aspects.
GeomSources - fixed assigning custom attributes.
msv [Tue, 8 Nov 2016 15:43:09 +0000 (18:43 +0300)]
0028059: Correction of upgrade guide for 7.1
Correction of upgrade guide for 7.1
// minor corrections
emv [Thu, 3 Nov 2016 09:58:25 +0000 (12:58 +0300)]
0028050: Empty result of offset operation in mode complete join type intersection
1. BRepOffset_Inter3d::ConnexIntByInt
Create unique offset edge for each localized part shared between pair of faces of the input shape.
2. Test cases for the issue.
emv [Tue, 8 Nov 2016 15:04:28 +0000 (18:04 +0300)]
0026917: 3D Offset algorithm produces incorrect result
Extension on the 3D Offset algorithm (Mode="Complete", Join Type = "Intersection")
for colliding cases to add support for new configurations of the shapes.
In the previous approach the result of the offset operation was build from
the offset faces using MakerVolume algorithm, without checking of the validity of these faces.
The new extension is based on this approach, but now the offset faces are being checked
on invalidity and rebuild in case of any. This allows (in case of successful rebuilding) to avoid creation
of the unforeseen parts such as dangling parts, spikes, inverted faces in the result of offset operation.
The main criteria for the validity of the faces is the coincidence of the normal
direction of the offset face with the normal direction of the original face.
Check for removal of invalid faces has been removed as obsolete.
BRepOffset_Inter2D: Avoid excess trimming of the edges due to coincidence with other edges.
BRepOffset_Inter3D: Careful treatment of the intersection of the faces connected only through vertices.
Eliminating the compiler warning.
Small corrections of test cases for issue CR26917
dbp [Thu, 20 Oct 2016 09:10:47 +0000 (12:10 +0300)]
0027974: Visualization, ray tracing - Improve ray tracing engine
* Multiple importance sampling for path tracing
* Improved light sources sampling (better handling several light sources)
* Fixed issues in light source intersection (light distance is taken into account)
* Add new TCL sample - OCCT Ball model for demonstrating physically-based materials
* Fix potential issue on NVIDIA GPUs ("Error: Failed to upload light source buffer")
* Path tracing materials reviewed; directional light source was smoother by default
msv [Tue, 8 Nov 2016 12:20:42 +0000 (15:20 +0300)]
0026738: Make Boolean operations safely treating arguments when running with fuzzy option
When fuzzy option is in force prevent increasing tolerance of input shapes. Instead pass increased by fuzzy value the tolerances of sub-shapes everywhere where it is needed by intersection algorithms.
The following changes in API have been made:
- The methods SetFuzzyValue and FuzzyValue have been moved from the classes BOPAlgo_ArgumentAnalyzer, BOPAlgo_Builder, and BOPAlgo_PaveFiller to the base class BOPAlgo_Algo.
- The public method BOPDS_DS::VerticesOnIn has been renamed to SubShapesOnIn, and the new output parameter theCommonPB has been added.
- In BOPTools_AlgoTools, a new argument "theFuzzyValue" has been added in the methods ComputeVV and AreFacesSameDomain.
- In IntTools_Context, a new argument "theFuzzyValue" has been added in the methods ComputeVE and ComputeVF.
- The methods SetFuzzyValue and FuzzyValue have been added in the classes IntTools_EdgeEdge, IntTools_FaceFace.
- In the class IntTools_EdgeFace, the methods SetTolE, SetTolF, TolE, TolF have been removed, and the methods SetFuzzyValue, FuzzyValue have been added.
- The new argument "theTol" has been added in the method IntTools_WLineTool::DecompositionOfWLine.
Some improvements in algorithms have been made during fighting with regressions:
- Correct initialization of pave blocks for degenerated edges.
- In BOPAlgo_PaveFiller::MakeBlocks(), filter out paves on intersection curve that were put on the curve accidentally due to wide range of E-F intersection vertex.
- In the method IntTools_Tools::ComputeTolerance the margin added to the computed tolerance has been increased up to 0.001%.
- The method BOPAlgo_PaveFiller::PutPaveOnCurve has been corrected in order to use the original vertex tolerance instead of the value increased during putting it on other curves.
- The new method BOPDS_PaveBlock::RemoveExtPave has been added.
- The vertex tolerance computation in BOPTools_AlgoTools::CorrectCurveOnSurface has been improved, taking into account intersection segments between p-curves (to avoid regression on "bugs modalg_6 bug22794").
- Improve IsExistingPaveBlock to make more stable catching of coincidence of common block with section curve (against regression "bugs modalg_4 bug697_2" on Linux).
Test case for the bug has been added.
The following test cases have been updated as improvements:
boolean gdml_private ZH2 ZI7 ZJ7
boolean volumemaker C4
The test case bugs/modalg_4/pro19653 has been corrected to make it stable. See comment inside the script for details.
The test case bugs/modalg_6/bug25880 has been corrected to suppress wrong bfuse commands.
The test bugs/modalg_6/bug26954_3 has been corrected to compare the result with more precise reference value.
The "faulty" TODO in boolean/volumemaker/A8 has been made actual for Linux as well.
//Eliminate compilation error on Linux.
ski [Mon, 31 Oct 2016 08:54:54 +0000 (11:54 +0300)]
0028027: Configuration - option BUILD_RESOURCES does not work on CMake 2.8
CMake command "string (APPEND ...)" was replaced by SET equivalent to support CMake 2.8
msv [Wed, 2 Nov 2016 07:59:39 +0000 (10:59 +0300)]
0027802: [Regression to 7.0] Solid classifier raises exception ConstructionError
Test case has been created.
ski [Wed, 12 Oct 2016 15:02:55 +0000 (18:02 +0300)]
0024788: Foundation Classes - remove Dico_Dictionary
Class Dico_Dictionary was replaced by NCollection_DataMap/NCollection_IndexedDataMap classes.
Changed argument name in template class NCollection_Datamap to eliminate redefinitions of static members in dependent code.
kgv [Wed, 2 Nov 2016 09:50:02 +0000 (12:50 +0300)]
0028039: Coding rules, TObj - pass file name by reference
azv [Sat, 29 Oct 2016 08:23:05 +0000 (11:23 +0300)]
0028028: Solid becomes invalid after scaling
The shape after scaling contains PCurves with incorrect parametrization, because of too large tolerance given.
1. Set Precision::PConfution() as a tolerance for GeomLib::SameRange.
2. Do not take into account tolerances of vertices while calculating tolerance of transformed PCurve for edge.
3. Test case bugs/modalg_6/bug28028
kgv [Tue, 1 Nov 2016 12:14:35 +0000 (15:14 +0300)]
0028035: Visualization - V3d_Trihedron::compute() endlessly creates new graphic groups
V3d_Trihedron::compute() now reuses existing groups in the structure
and resets the flag myToCompute.
ifv [Mon, 7 Nov 2016 13:38:53 +0000 (16:38 +0300)]
0028030: Algorith GeomLib_CheckCurveOnSurface takes too much time for Bspline curves with big number of knots
Checking of number of knots is added. If number of knots more then allowed value, algorithm does not search distance between curves for each knot interval, but uses predefined sample point distribution.
This change was born in the scope of work on the issue 26329, but does not have direct connection to it. Therefore it has been postponed to be integrated later in its own context.
Test case for issue #28030
pdn [Tue, 1 Nov 2016 10:43:56 +0000 (13:43 +0300)]
0028034: Application Framework - stack overflow in LDOM destructor
nbv [Fri, 28 Oct 2016 06:37:38 +0000 (09:37 +0300)]
0027896: Prm-Prm intersection algo returns wrong result if it is called with start intersection point, which lies in the domain boundary
Purger has been disabled (in IntPatch_PrmPrmIntersection algorithm) if some points have been added in the Walking line (it is stupidly, first, to insert some points in the line and, after that, to delete points from this line).
Some improvements in IntWalk_PWalking::SeekPointOnBoundary(...) method have been made (see comments in the code for detail information).
Some test cases have been adjusted according to their new behavior.
vpa [Mon, 31 Oct 2016 13:34:15 +0000 (16:34 +0300)]
0027868: Visualization - AIS_InteractiveContext::Remove() might keep removed object in selection list
- AIS_InteractiveContext::unhighlightOwners is corrected to handle all objects in selection regardless of owner's selection state
apn [Thu, 3 Nov 2016 11:20:04 +0000 (14:20 +0300)]
Fixed compilation warnings on vc14 caused by CR27431_5
jgv [Mon, 17 Oct 2016 10:59:58 +0000 (13:59 +0300)]
0027386: BRepOffsetAPI_MakePipeShell does not provide history of generations
The method BRepOffsetAPI_MakePipeShell::Generated now returns generated shapes for sub-edges and sub-vertices of sections.
The method BRepFill_PipeShell::BuildHistory is redesigned: now it builds generated shapes for sub-edges and sub-vertices of sections.
New Draw command "gensweep" is added to sweep commands for testing of history building.
abk [Wed, 5 Oct 2016 10:49:44 +0000 (13:49 +0300)]
0027870: Modeling - refactoring of HLR algorithms
Toolkit 'TKHLR' was fully refactored for 'Standard_Address' and macros except about half of package 'HLRBREP' there 'Standard_Address' is used through the 'generic' mechanism.
ika [Fri, 28 Oct 2016 12:51:58 +0000 (15:51 +0300)]
0028014: PMIVis - some tolerances are attached to points out of the models
Fix a misprint.
osa [Mon, 31 Oct 2016 14:08:37 +0000 (17:08 +0300)]
0028031: Visualization, TKV3d - do not use height/width ratio of window during V3d_View::FitAll()
isk [Fri, 14 Oct 2016 06:17:36 +0000 (09:17 +0300)]
0028010: Visualization, Prs3d_Arrow - add Shading presentation builder
StdPrs_ToolCylinder, StdPrs_ToolDisk, StdPrs_ToolQuadric and StdPrs_ToolSphere
have been moved from StdPrs package to Prs3d.
vpa [Fri, 28 Oct 2016 12:03:38 +0000 (15:03 +0300)]
0027008: Visualization - polygonal selection algorithm does not work with MeshVS_Mesh
- correct calculation of normals for SelectMgr_TriangularFrustum;
- test case for issue #27008
anv [Wed, 2 Nov 2016 12:46:52 +0000 (15:46 +0300)]
0028012: Exception while intersecting two surfaces
Test case for issue CR28012
msv [Fri, 28 Oct 2016 15:20:03 +0000 (18:20 +0300)]
0026673: BOPTools_AlgoTools::ComputeVV incorrectly checks two vertices for intersection
Test case has been created.
msv [Wed, 2 Nov 2016 12:43:50 +0000 (15:43 +0300)]
0024932: addsweep does not check if the supplied variable contains a shape
Check for null shape has been added in the command addsweep implementation.
// eliminate warning
Test case for issue CR24932
Test case has been corrected.
vpa [Thu, 27 Oct 2016 11:29:27 +0000 (14:29 +0300)]
0027530: Visualization - AIS_InteractiveContext::HilightNextDetected() doesn't work in Neutral Point
- added implementation of mentioned methods for neutral point;
- sequence of detected objects was replaced by sequence of detected owner's indexes in AIS_InteractiveContext;
- commands vselnext and vselprev were corrected to update viewer properly;
- test case for issue #27530.
nbv [Wed, 2 Nov 2016 12:39:37 +0000 (15:39 +0300)]
0028009: [Regression vs OCCT7.0.0] Cut produces not valid shape
The algorithm in WorkWithBoundaries::BoundaryEstimation(...) did not take into account opposite directions of cylindrical axes (when the angle between them is obtuse). After the fix it does it.
Small correction of test cases for issue CR28009
nbv [Wed, 2 Nov 2016 12:25:36 +0000 (15:25 +0300)]
0027431: [Regression to 6.9.1] Huge tolerance obtained during intersection of cylinder and sphere
The root of the problem is incorrect processing of cases when intersection line goes through the apex(es) of sphere. The fix improves this situation. The algorithm is taken from DecomposeResult(...) function (see IntPatch_ImpPrmIntersection.cxx file). Before the fix, faltering steps were done to solve this problem. As result, it worked in some particular cases. Now, its possibilities have been extended significantly.
Following changes have been made in the fix:
1. Class IntPatch_ALineToWLine has been rewritten cardinally. It touches as interfaces of existing methods as adding/removing some methods/fields. Correction touches both cases: going through seam of Cone/Sphere and through pole(s) of sphere. Old interface did not allow making some actions with analytical line (ALine), e.g. splitting it on several Walking-lines (WLine).
2. Restriction-line support has been removed from Implicit-Implicit intersection result (see IntPatch_Intersection::GeomGeomPerfom(...) method). It connects with the fact that the intersection algorithm itself returns precise intersection line in analytical cases (in compare with parametric intersector). Therefore, we do not need in additional (restriction) line.
3. New class IntPatch_SpecialPoints has been added. This class contains methods to add some special points (such as apex of cone, pole of sphere, point on surface boundary etc.) in intersection line (IntPatch_PointLine). It is based on the static functions, which already exist in IntPatch_ImpPrmIntersection.cxx file (these functions have been moved to the new class).
4. Method IntPatch_WLineTool::ExtendTwoWlinesToEachOther(...) has been renamed to IntPatch_WLineTool::ExtendTwoWLines(...). It is connected with changing main idea of the method. Now it allows extending WLine to the surface boundary or to the singular point (if it is possible): cone apex, sphere pole etc. Interface of this method has been corrected, too. At that, old functionality (extending to each other) has been kept. For implementation of this algorithm, new enumeration "IntPatchWT_WLsConnectionType" has been created.
5. Method IntPatch_PointLine::CurvatureRadiusOfIntersLine(...) has been added. See IntPatch_PointLine.hxx for detail information. It allows correct step computing depended on the local curvature of the intersection line. This method uses geometrical properties of intersected surfaces to compute local curvature. Therefore, it can be applied in wide range of cases even if the intersection curve is not represented in explicit form (e.g. in case of param-param-intersection).
6. Method IntSurf::SetPeriod(...) has been created.
7. Additional check has been added in Draft_Modification::Perform() method for better choice of correct fragment of intersection line for processing DRAFT operation.
8. New overload method IntPatch_Point::SetValue() has been added.
9. Some refactoring of the code has been made.
Creation of test case for issue #27431.
---------------------------------------------------------------------------------------------
Some test cases have been adjusted according to their new behavior.
tests\bugs\modalg_4\bug62
It is really IMPROVEMENT (but fortuitous).
tests\bugs\modalg_5\bug25838
The behavior of this test has been reverted to the state before fixing the issue #27341. Main problem has not been fixed in #27341. It was fortuitous improvement.
tests\bugs\moddata_2\bug565
Quality of intersection curve was not checked. And the curve is bad on both MASTER and FIX. Input data are really wrong: plane-like-cone. However, on the MASTER, four intersection curves (the quality is insignificant) are expected. On the fix, not empty intersection result is expected simply.
tests\boolean\volumemaker\A8
Differences in images and CPU is expected. Difference in images is expected to be fixed in the issue #26020. Now, we should apply this behavior.
Much CPU time is spent by IntTools_FaceFace::ComputeTolReached3d(...) and GeomInt_IntSS::BuildPCurves(...) methods calling. These methods are not touched by the algorithm. It is the result of change of intersection curve(s) form. However, the new Curve(s) seems to be valid and can be applied. As result, new behavior can be applied, too.
tests\boolean\volumemaker\F8
tests\boolean\volumemaker\F9
tests\boolean\volumemaker\G5
tests\boolean\volumemaker\G6
CPU difference is expected. Much CPU time is spent by IntPatch_PointLine::CurvatureRadiusOfIntersLine(...) method calling. This method is really new (it does not exist on the MASTER) and is really useful. Therefore, we should apply new behavior.
tests\boolean\volumemaker\G1
CPU difference is expected. Much CPU time is spent by IntTools_WLineTool::DecompositionOfWLine(...) and IntTools_FaceFace::ComputeTolReached3d(...) methods calling. These methods are not touched by the algorithm. It is the result of change of intersection curve(s) form. However, the new Curve(s) seems to be valid and can be applied. As result, new behavior can be applied, too.
tests\bugs\modalg_6\bug26619
Differences in images is expected. The test keeps its BAD status on the FIX. But the result on the fix is nearer to expected than on the MASTER. Issue #27014 is still actual. As before, it is not clear, why the number of entities is different. The number of section curves has not been changed. Interfered entities are the same as on the MASTER.
tests\bugs\modalg_5\bug25319_1(2)
The reason is described in the issue #27896.
Small correction in the test case
emv [Wed, 27 Apr 2016 13:28:52 +0000 (16:28 +0300)]
0027441: The method IntTools_Context::IsVertexOnLine incorrectly computes parameter of the point on the curve
Choosing the closest bound to the checking point.
gka [Wed, 26 Oct 2016 16:31:49 +0000 (19:31 +0300)]
0026524: ShapeFix_Face crash when performing fix on an invalid face.
Check that method Context() returns not null handle was added.
ika [Tue, 18 Oct 2016 10:24:29 +0000 (13:24 +0300)]
0027975: Data Exchange - Add possibility to connect DGTs to vertices.
Implement new function to find Product_Definition_Shape entity.
Modify Reader to add possibility of import DGTs, connected to some geometry items.
Update test cases.
kgv [Sat, 22 Oct 2016 15:37:51 +0000 (18:37 +0300)]
0027991: Modeling Algorithms - BRepGProp_Face crashes on face without geometric surface
BRepGProps now ignores faces without geometric surface to avoid access violation.
BRepExtrema_DistShapeShape::DistanceMapMap() now skips comparison between void bounding boxes.
BRepBndLib::Add() now ignores useTriangulation flag for faces without geometric surfaces, and uses triangulation if any for updating of the box.
ski [Fri, 28 Oct 2016 11:29:58 +0000 (14:29 +0300)]
0027258: Configuration - generate built-in replacement for mandatory resource files
Generation of header files from resource files was added to CMake and genproj procedures.
Message_MsgFile has been extended with new method ::LoadFromString()
for loading messages from embedded resources.
Message_MsgFile::LoadFromString() is now a preferred way
for loading message resources by application
as alternative to environment variables.
TObje/TObj.msg is now embedded into TObj_Application.cxx.
TObj_Application now loads its global messages
on instantiation of the first class instance.
UnitsAPI/Lexi_Expr.dat now completely embedded into Units_Lexicon.cxx.
UnitsAPI/Units.dat now embedded into Units_UnitsDictionary.cxx
but can be regenerated from resource file.
The definition of the following units have been removed:
benne à charbon, calorie (diététique).
Unused message files XSMessage/IGES.us and IGES.fr have been removed.
Related code IGESData.cxx has been removed as well.
XSMessage/XSTEP.us is now embedded into Interface_StaticStandards.cxx
and used for fallback initialization in case when file resources
defined by CSF_XSMessage environment variable are missing.
SHMessage/SHAPE.us is now embedded into ShapeExtend.cxx
and used for fallback initialization in case when file resources
defined by CSF_XHMessage environment variable are missing.
Duplicating code has been removed from ShapeProcess_OperLibrary.cxx.
Shaders/Declarations.glsl and Shaders/DeclarationsImpl.glsl
are now embedded into OpenGl_ShaderProgram.cxx.
CSF_ShadersDirectory is no more required for using OCCT 3D Viewer.
Ray-Tracing GLSL programs from Shaders are now embedded into OpenGl_View_Raytrace.cxx.
File resources are still used instead of embedded programs
when CSF_ShadersDirectory is defined, but this functionality
is intended for OCCT development.
Enumeration Graphic3d_ShaderProgram::ShaderName_Phong
demonstrating custom GLSL program usage has been removed.
apn [Fri, 28 Oct 2016 11:28:42 +0000 (14:28 +0300)]
Modify test case v3d/raytrace/bug25221 according to new draw commands.
apn [Thu, 27 Oct 2016 12:50:24 +0000 (15:50 +0300)]
0025792: BRepAlgoAPI_Section fails depending on order of arguments
Added test case bugs/modalg_6/bug25792
emv [Thu, 27 Oct 2016 14:52:34 +0000 (17:52 +0300)]
0027244: Test case with workaround for issue
0027240
Test case for issue CR27404
gka [Thu, 27 Oct 2016 14:50:18 +0000 (17:50 +0300)]
0027404: Data Exchange - access violation when reading STEP file
Added check on the null handle
Test case for issue CR27404
nds [Tue, 11 Oct 2016 05:46:42 +0000 (08:46 +0300)]
0027692: Visualization, AIS_AngleDimension - exterior angle and arrows visibility improvements
Extension of angle presentation to provide this functionality
emv [Wed, 26 Oct 2016 10:00:56 +0000 (13:00 +0300)]
0028002: Invalid result of Boolean Fuse operation
The SolidClassifier algorithm does not take into account the internal parts of the solid and its faces.
But in some cases the parts which are internal on some shapes can be included in other shapes of
the same solid with FORWARD/REVERSED orientation and therefore should be counted as well.
The fix changes the procedure of the initialization of the tree of bounding boxes of the edges and
vertices of the solid in SolidExplorer algorithm to treat the internal/external parts of the solid correctly.
apn [Thu, 27 Oct 2016 11:33:50 +0000 (14:33 +0300)]
0027260: Incorrect result of General Fuse operation
Added test case bugs/modalg_6/bug27260
ski [Wed, 15 Jun 2016 09:29:47 +0000 (12:29 +0300)]
0027514: Configuration, CMake - relative paths are not correctly handled for INSTALL_DIR
Relative path can be used as INSTALL_DIR.
anv [Thu, 20 Oct 2016 15:04:55 +0000 (18:04 +0300)]
0027971: Intersection with degenerated conical surface is translated incorrectly
Added check for infinite surfaces.
kgv [Thu, 13 Oct 2016 17:22:27 +0000 (20:22 +0300)]
0027960: Configuration - fix compilation of OSD_Directory with MinGW-w64
Check _NATIVE_WCHAR_T_DEFINED only within _MSC_VER since it is msvc-specific.
duv [Tue, 25 Oct 2016 08:21:17 +0000 (11:21 +0300)]
0025221: Visualization - Depth test errors in ray-tracing scene containing face outlines
Calculation of polygon offset for ray tracing has been changed.
Issues with wrong data in FBO depth buffer has been resolved.
msv [Tue, 25 Oct 2016 08:54:34 +0000 (11:54 +0300)]
0025214: HLR fails to project edges
Avoid getting non-existing array items. Use reference to array items instead of pointers where it is possible.
Create test case. Before the fix this test raised exception in debug mode.
nbv [Tue, 25 Oct 2016 13:39:13 +0000 (16:39 +0300)]
0027856: Regression vs 6.7.1: General Fuse operation fails to fuse the solids
Method WorkWithBoundaries::BoundaryEstimation(...) has been brought in balance with IsParallel(...) method, which checks if cylinder axes are parallel.
msv [Thu, 27 Oct 2016 14:24:20 +0000 (17:24 +0300)]
0027782: Hidden Line Removal algorithm fails to handle filleted edges
Create test case for the bug.
Minor correction in test case bugs/modalg_6/bug27782
ika [Wed, 15 Jun 2016 11:29:32 +0000 (14:29 +0300)]
0027570: Unacceptable performance during reading large STEP files
Improvement of translating assemblies from STEP.
kgv [Thu, 27 Oct 2016 14:20:38 +0000 (17:20 +0300)]
0027764: Visualization - add functionality for animation of 3D camera and interactive objects
Added classes AIS_Animation, AIS_AnimationCamera, AIS_AnimationObjectLocatio.
Draw Harness command vanimation has been modified to manage animation timeline.
Command vfit has been extended with option -noupdate.
Formatting of vviewparams command output has been improved.
Functionality of commands vlocreset, vlocmove, vloctranslate, vlocrotate,
vlocmirror, vlocscale has been merged into vlocation/vsetlocation.
vlocation now can print the current local transformation of the object.
v3d/ivtk test group does not call vfit anymore.
Fixed misprint in test cases bugs/vis/bug24623_3 and bug25532.
oan [Thu, 27 Oct 2016 14:18:18 +0000 (17:18 +0300)]
0025264: Mesh very slow for Revol shape
Test case added
Small corrections of test case
ski [Thu, 27 Oct 2016 14:16:24 +0000 (17:16 +0300)]
0027339: CMake install should launch generation of overview documentation
Documentation is generated automatically during build/install process
Added check of minimum Doxygen version.
Install process causes generation of Overview documentation (unless already generated) by checking of occt_logo.png file existing.
Overview project regenerates documentation if any source file was changed.
emv [Tue, 25 Oct 2016 05:33:17 +0000 (08:33 +0300)]
0028001: Remove unused BOPCol_VectorOfInteger.hxx
Removing the remains of BOPCol_Array1, which was replaced with BOPCol_NCVector.
kgv [Thu, 20 Oct 2016 09:07:54 +0000 (12:07 +0300)]
0027986: Visualization - AIS_InteractiveContext::SetLocation() does not update dynamic highlighting
AIS_InteractiveContext::SetLocation() - update HilightMode instead of DisplayMode.
PrsMgr_PresentationManager::UpdateHighlightTrsf() - fix accessing NULL presentation.
kgv [Fri, 21 Oct 2016 09:51:26 +0000 (12:51 +0300)]
0027988: Visualization, AIS_InteractiveContext - fix inconsistent methods for setting highlight styles
Methods ::ChangeHighlightStyle() and ::ChangeSelectionStyle() have been
replaced by ::SetHighlightStyle() and ::SetSelectionStyle().
ika [Wed, 5 Oct 2016 14:02:27 +0000 (17:02 +0300)]
0027934: Data Exchange - implement STEP common labels
implement import/export
update test cases
emv [Thu, 20 Oct 2016 08:31:19 +0000 (11:31 +0300)]
0027984: Volume maker algorithm is unable to build all possible solids from the given faces
While checking the section edges between pair of faces on coincidence with the
existing edges use for checking only the edges from these two faces.
Test case for the issue.
vpa [Wed, 19 Oct 2016 16:11:23 +0000 (19:11 +0300)]
0027969: Visualization - add interfaces to access selecting volumes from SelectMgr_SelectingVolumeManager
- getter for selection frustum computed during last run of selection mechanism was added to SelectMgr_SelectingVolumeManager;
- getters for frustum planes were added to SelectMgr_BaseFrustum and its successors;
- an API for applications to get frustum planes was added to SelectBasics_SelectingVolumeManager.
emv [Fri, 21 Oct 2016 08:09:34 +0000 (11:09 +0300)]
0027987: CellsBuilder algorithm does not find shared common parts of the arguments
Treatment of the possibility of shared parts has been added.
nds [Thu, 27 Oct 2016 14:02:00 +0000 (17:02 +0300)]
0027688: Visualization, AIS_Dimension - add possibility to set custom text value
Implementation of custom text in dimension presentation;
Test case is provided for this bug;
Code correction: Standard_EXPORT is removed for inline method.
Minor correction of test case bugs/vis/bug27688
aka [Thu, 27 Oct 2016 13:58:38 +0000 (16:58 +0300)]
0027769: BRepOffsetAPI_MakePipeShell produces a face based on degenerated toroidal surface
method BuildKPart was modified in order to create sphere instead of torus in case of major radius <= tolerance
Minor corrections in test case bugs/modalg_6/bug27769
kgv [Sun, 2 Oct 2016 16:36:14 +0000 (19:36 +0300)]
0024393: Visualization - objects position with enchanced precision
Graphic3d_ZLayerSettings - public fields have been replaced by methods.
Added new property Origin defining local coordinate system for all Layer objects.
Syntax of Draw Harness command VZLayer has been redesigned.
Graphic3d_CStructure now stores bounding box with double precision floats.
OpenGl_BVHTreeSelector - frustum culling now works with double precision floats.
kgv [Mon, 17 Oct 2016 14:39:30 +0000 (17:39 +0300)]
0027972: Visualization - remove unused and not implemented property V3d_View::EnableGLLight()
oan [Thu, 20 Oct 2016 13:34:29 +0000 (16:34 +0300)]
0027959: BRepMesh_Delaun produces mesh with gaps on internal edges
Check both sides of internal link for adjusted triangle and process left and right polygons separately
Small correction of test case for issue CR27959
isk [Fri, 8 Jul 2016 12:01:08 +0000 (15:01 +0300)]
0024291: Visualization - move Z-buffer trihedron presentation from TKOpenGl to TKV3d
Not implemented method V3d_View::TriedronEcho() and enum Aspect_TypeOfTriedronEcho have been removed.
The following methods have been removed from Graphic3d_CView class:
TriedronDisplay(), TriedronErase(), ZBufferTriedronSetup(), TriedronEcho().
New class V3d_Trihedron has been added as replacement of removed OpenGl_Trihedron
which now uses Graphic3d_TMF_TriedronPers persistence.
kgv [Thu, 13 Oct 2016 12:24:23 +0000 (15:24 +0300)]
0027957: Visualization, AIS_InteractiveContext - protect from displaying the same AIS_InteractiveObject within multiple contexts
AIS_InteractiveContext methods adding object to the context now throws Standard_ProgramError exception
if object has been already displayed in another context.
AIS_InteractiveContext::Remove() now NULLifies context assigned to the object.
AIS_InteractiveContext now inherits from Standard_Transient instead of deprecated MMgt_TShared
and defines C++ destructor instead of method Delete().
AIS_InteractiveObject - undocumented property State() has been removed.
Undocumented property Users() has been moved to AIS_IdenticRelation.
Draw Harness command vclose now clear AIS_InteractiveContext content
before nullifying it to ensure that objects have been properly removed.
AIS_MultipleConnectedInteractive now overrides method ::SetContext()
to assign context for children objects.
kgv [Thu, 13 Oct 2016 13:28:34 +0000 (16:28 +0300)]
0027961: Visualization - remove unused and no more working OpenGl_AVIWriter
mpv [Thu, 20 Oct 2016 13:26:25 +0000 (16:26 +0300)]
0027604: Application Framework - memory is not released after closing XBF file
Virtual method *BinLDrivers_DocumentRetrievalDriver::Clear* now allows to Clear a cash data accumulated during a reading.
So, in successor class BinDrivers_DocumentRetrievalDriver this allows clearing the BinMNaming_NamedShapeDriver set of stored shapes when it is not needed anymore.
kgv [Thu, 13 Oct 2016 18:09:51 +0000 (21:09 +0300)]
0027963: Coding Rules - eliminate GCC compiler warnings -Wmissing-field-initializers in OSD_File.cxx
kgv [Thu, 13 Oct 2016 11:01:19 +0000 (14:01 +0300)]
0027945: Visualization - handle correctly view clipping planes within zoom-persistent objects
OpenGl_Structure::Render() and SelectMgr_ViewerSelector::checkOverlap()
now clip entire zoom/rotate persistence object
by checking anchor point with global clipping planes.
Image dump has been added to the new test case.
kgv [Wed, 12 Oct 2016 09:46:48 +0000 (12:46 +0300)]
0027953: Foundation Classes - eliminate global variables from OSD_Path
kgv [Wed, 5 Oct 2016 10:52:48 +0000 (13:52 +0300)]
0027931: Coding rules, Precision.hxx - eliminate dead code within PRECISION_OBSOLETE macros
kgv [Sun, 9 Oct 2016 17:48:16 +0000 (20:48 +0300)]
0027943: Visualization - fix broken shading by positional light for object with local transformation
OpenGl_ShaderManager, per-vertex shading and per-fragment shading
- do not apply model-world matrix on the light sources
which are expected to be defined in world-space.
kgv [Tue, 11 Oct 2016 19:55:25 +0000 (22:55 +0300)]
0027952: Visualization - do not reset RayTracing state on changing structures not in main Z-Layer
anv [Thu, 1 Sep 2016 09:29:14 +0000 (12:29 +0300)]
0027824: Parasolid XMT file generates weird geometry after conversion
Fixed adapter for C0 offsets
nbv [Thu, 13 Oct 2016 10:48:38 +0000 (13:48 +0300)]
0027930: XMT file conversion loops infinitely
Now, the algorithm tries to estimate U- and V-ranges of future intersection curve(s) on the surface. This information is used in stop-criterium of the algorithm instead of full surface range used earlier. It allows reducing dependencies of intersection result on the surface ranges.
Tuning of test case bugs/modalg_6/bug27937_1
aml [Mon, 10 Oct 2016 12:08:36 +0000 (15:08 +0300)]
0027946: Out of range item access in offset algorithm
Out of range access has been eliminated.
vro [Thu, 13 Oct 2016 10:45:03 +0000 (13:45 +0300)]
0027619: Improvement on manuipulation of data by TPrsStd_AISPresentation attribute.
The branch contains a fix on Undo/Redo for TPrsStd_AISPresentation attribute + an opportunity to deselect the interactive object.
getData() now calls FindAttribute(), the field myData disappeared.
A fix of regression on bug73_3.
A cleverer solution.
kgv [Fri, 7 Oct 2016 15:49:34 +0000 (18:49 +0300)]
0027941: Foundation Classes - NCollection_Vector::Iterator::offsetV() does not match NCollection_Vector::end()
kgv [Sun, 9 Oct 2016 18:59:58 +0000 (21:59 +0300)]
0027944: Visualization, V3d_View - filter duplicates within ::AddClipPlane()
ski [Thu, 13 Oct 2016 10:40:12 +0000 (13:40 +0300)]
0027915: Foundation Classes - remove the class NCollection_QuickSort
Class NCollection_QuickSort was removed.
Direction of dimension lines was corrected.
Updated porting notes.
minor corrections in AIS
nbv [Thu, 22 Sep 2016 13:46:12 +0000 (16:46 +0300)]
0027895: Correction in the constructor Extrema_ExtElC::Extrema_ExtElC (const gp_Lin&,const gp_Lin&,const Standard_Real)
Computation algorithm is made more simple.
Adjusting some test cases according to their new behavior.
nbv [Thu, 6 Oct 2016 09:57:25 +0000 (12:57 +0300)]
0026894: Intersection algorithm between two infinite cylinders is hanging
1. VRange of intersection curve has been limited. As result, too oblong intersection curve(s) will be never returned.
2. Now, purger algorithm is not called for lines obtained by Geom-Geom intersection method.
3. New statuses are entered in IntPatch_ImpImpIntersection class. It makes intersection algorithm more informative and flexible for using.
4. Method IntPatch_ImpImpIntersection::GetStatus() has been created.
Tuning of test case bugs modalg_6/bug26894
nbv [Fri, 23 Sep 2016 14:24:52 +0000 (17:24 +0300)]
0023178: Intersection of cylinders fails to produce results
1. Unification of trimmed and not-trimmed cylinders processing (IntPatch_Intersection::GeomGeomPerfomTrimSurf() method has been removed).
2. Interface of IntPatch_ImpImpIntersection::Perform(...) method has been changed.
3. Now, WLine purging is forbidden for Geom-Geom-Intersection.
4. Bnd_Range class has been created. See Bnd_Range.hxx for detail information.
5. Algorithm of AddBoundaryPoint function has been improved in order to obtain intersection points in both boundaries (VFirst and VLast of every surface).
6. Earlier, method Geom2dConvert::ConcatG1(...) increased resulted B-spline degree (in case of not succession of previous iteration). Now increased value has been limited by Geom2d_BSplineCurve::MaxDegree() value (max degree = 25).
7. Algorithm of B-spline closure definition has been changed in the methods Geom2dConvert::C0BSplineToC1BSplineCurve(...) and Geom2dConvert::C0BSplineToArrayOfC1BSplineCurve(...).
Creation of test case for this issue.
Adjusting test cases according to their new behavior.
Small correction in the code according to KGV's remark.
apn [Thu, 6 Oct 2016 09:36:21 +0000 (12:36 +0300)]
0027864: Add vtk support to products java wrapper
Fix redefinition IVtkVTK_EXPORT error during wrapping in products java sample.
Removed defined(__WIN32__)
ski [Thu, 6 Oct 2016 09:30:39 +0000 (12:30 +0300)]
0027905: Visualization - randomly directed arrows on test v3d mesh B7
Behaviour of command meshvectors is stable now.
It shows default vector (0,0,1) for volume entity.
Test cases for issue CR27905
nbv [Wed, 5 Oct 2016 11:36:33 +0000 (14:36 +0300)]
0027929: Methods D0 and D1 for trimmed offset surface return different values if the surface has osculating surface
Using osculating surface is forbidden if the normal to basis (for offset) surface is well defined.
Creation of test case for this issue.
Adjusting test cases according to their new behavior.
nbv [Tue, 27 Sep 2016 14:46:14 +0000 (17:46 +0300)]
0027892: Construction error in offset
Provide proper initialization of the field Geom_OffsetSurface::myOscSurf in the case of creating offset of the trimmed bspline surface.
Adjusting test cases according to their new behavior.
kgv [Mon, 3 Oct 2016 11:41:12 +0000 (14:41 +0300)]
0024073: Coding rules - ambiguous call to overloaded function StdPrs_DeflectionCurve::Match()
Default parameters values have been removed from the methods
StdPrs_DeflectionCurve::Match() to avoid ambiguity.
dbp [Sat, 24 Sep 2016 17:26:33 +0000 (20:26 +0300)]
0027899: Visualization, Ray Tracing - Provide ability to rebuild GLSL shaders on the fly
For debugging and performance analysis it is reasonable to provide the ability to rebuild ray tracing shaders on the fly.
In this way, it will be possible to analyze the impact of different shaders modifications
without re-launching and re-configuring the scene.
This functionality can be used in the following way:
> vrenderparams -rebuild
kgv [Wed, 28 Sep 2016 17:18:25 +0000 (20:18 +0300)]
0027916: Visualization - access violation occurs within AIS_ColoredShape::Compute() for NULL shape
AIS_ColoredShape::Compute() - add NULL shape check.
AIS presentations - removed redundant clearance within ::Compute()
which is always done in advance within PrsMgr_PresentationManager::Update().
kgv [Mon, 26 Sep 2016 08:38:18 +0000 (11:38 +0300)]
0027883: Visualization - AIS_InteractiveContext::IsDisplayed() does not return displayed state for specified Display Mode