8 years ago0023125: Wrong results done by classifier algorithm for a point and a solid.
pkv [Mon, 1 Oct 2012 08:09:47 +0000 (12:09 +0400)]
0023125: Wrong results done by classifier algorithm for a point and a solid.

class :BRepClass3d_SolidExplorer;
   - method:
Standard_Integer BRepClass3d_SolidExplorer::OtherSegment(const gp_Pnt& P,
                               gp_Lin& L,
                               Standard_Real& _Par)

The object of the type Extrema_ExtPS is created using real parametric ranges (U,V) of the surface.

8 years ago0023442: Provide the access to the functionality of Geom2dHatch_Hacher via IntTools_C...
pkv [Fri, 5 Oct 2012 09:45:23 +0000 (13:45 +0400)]
0023442: Provide the access to the functionality of Geom2dHatch_Hacher via IntTools_Context

class IntTools_Context
- the method:
Geom2dHatch_Hatcher& IntTools_Context::Hatcher(const TopoDS_Face& aF)
has been added.
The method returns the reference to 2D hatcher for given face <aF>

class IntTools_Context
- the method: IntTools_Context::~IntTools_Context()
has been modified in terms of I.1.

8 years ago0023423: Test system does not get log if DRAW crashes or gets killed
abv [Fri, 7 Sep 2012 08:33:12 +0000 (12:33 +0400)]
0023423: Test system does not get log if DRAW crashes or gets killed

Avoid using dlog in grid tests (command testgrid), in order to get some output even if DRAW crashes.
Command test now accepts argument echo to get echo immediately (but no log processing).
Test case for checking log processing in case of premature exit of DRAW is added (demo testsystem premature_exit).

8 years ago0023428: Extend OpenGl_Context to use Geometry Shaders extension
osa [Fri, 5 Oct 2012 09:28:57 +0000 (13:28 +0400)]
0023428: Extend OpenGl_Context to use Geometry Shaders extension

8 years ago0023388: Boolean operations hang up trying to build section of two customer's shapes
jgv [Thu, 20 Sep 2012 10:33:48 +0000 (14:33 +0400)]
0023388: Boolean operations hang up trying to build section of two customer's shapes

8 years ago0023425: diffimage generate OSD_Exception during execution
kgv [Thu, 27 Sep 2012 08:43:54 +0000 (12:43 +0400)]
0023425: diffimage generate OSD_Exception during execution

diffimage out-of-image access during border filter execution

Verify neighbor pixel position for out-of-image access
A list of referenced articles and books is added to Image_Diff.hxx file.

Adding test case bugs/vis/CR23425

Image_Diff - fix compilation error on x86_64 target using msvc
There no std::abs for ptrdiff_t in Microsoft STL implementation

Image_PixMap - fixed compilation on gcc 3

Removed extra newlines in TCL script
Image_Diff, move back extra modifications

8 years ago0023316: OpenGl package can not be compiled on RedHat40-64
kgv [Fri, 21 Sep 2012 12:27:23 +0000 (16:27 +0400)]
0023316: OpenGl package can not be compiled on RedHat40-64

OpenGl_Window avoid early unprotected glx.h inclusion
which may cause system glext.h inclusion

8 years ago0023394: Problem with BRepOffset_MakeOffset on a cylindrical face
emv [Thu, 27 Sep 2012 08:29:04 +0000 (12:29 +0400)]
0023394: Problem with BRepOffset_MakeOffset on a cylindrical face

8 years ago0023358: Unitialized variables used.
mkv [Fri, 21 Sep 2012 13:43:13 +0000 (17:43 +0400)]
0023358: Unitialized variables used.

Draw command was fixed

8 years ago0023129: BRepTools::OuterShell() works wrong - it always returns the first shell
pkv [Thu, 27 Sep 2012 08:03:12 +0000 (12:03 +0400)]
0023129: BRepTools::OuterShell() works wrong - it always returns the first shell

8 years ago0023252: Fillet regression
emv [Thu, 20 Sep 2012 04:29:26 +0000 (08:29 +0400)]
0023252: Fillet regression

8 years ago0023433: Compiler warnings in Graphic3d_ArrayOfPrimitives.lxx
abv [Fri, 14 Sep 2012 09:09:39 +0000 (13:09 +0400)]
0023433: Compiler warnings in Graphic3d_ArrayOfPrimitives.lxx

Conversion of color components from real [0,1] to char [0,255] corrected to avoid compiler warnings

8 years ago0023246: TKOpenGl viewer created without depth buffer on some X11 implementations
kgv [Tue, 11 Sep 2012 05:51:12 +0000 (09:51 +0400)]
0023246: TKOpenGl viewer created without depth buffer on some X11 implementations

Apply workaround on Mac OS platforms too
to ensure GL context created with depth buffer.

8 years ago0023327: There are identical sub-expressions to the left and to the right of the...
szy [Fri, 14 Sep 2012 13:53:59 +0000 (17:53 +0400)]
0023327: There are identical sub-expressions to the left and to the right of the '&&' operator

8 years ago0023429: BRepFeat_SplitShape algorithm misses some section edges while building resul...
jgv [Fri, 14 Sep 2012 13:51:20 +0000 (17:51 +0400)]
0023429: BRepFeat_SplitShape algorithm misses some section edges while building result from customer's shape

Adding test case bugs/modalg/CR23429

8 years ago0022888: Wrong shape result imported from IGES file.
apn [Fri, 14 Sep 2012 13:38:41 +0000 (17:38 +0400)]
0022888: Wrong shape result imported from IGES file.

Adding test case bugs/iges/CR22888
Modified test case bugs/iges/CR22888

8 years ago0023389: (OCC 6.5.3 regression) BRepAlgoAPI_Cut returns invalid solid
jgv [Fri, 14 Sep 2012 13:27:38 +0000 (17:27 +0400)]
0023389: (OCC 6.5.3 regression) BRepAlgoAPI_Cut returns invalid solid

Adding test case boolean/bopcut_complex/P8

8 years ago0023414: Remove deprecated classes Xw_PixMap and WNT_PixMap
kgv [Fri, 14 Sep 2012 13:25:19 +0000 (17:25 +0400)]
0023414: Remove deprecated classes Xw_PixMap and WNT_PixMap

8 years ago0023426: Tool to compare two runs of tests on the same station
abv [Tue, 11 Sep 2012 06:37:11 +0000 (10:37 +0400)]
0023426: Tool to compare two runs of tests on the same station

New command testdiff added to compare two logs of test run. Currently only CPU times are compared, comparison of images can be added later.

8 years ago0021977: Unsafe implementation of TNaming_Builder
szy [Fri, 14 Sep 2012 13:20:57 +0000 (17:20 +0400)]
0021977: Unsafe implementation of TNaming_Builder

The code is corrected to create instances of TNaming_Builder class dynamically. Note that they cannot be created as local variables as they should be instantiated only when needed and then reused for the subshapes of the same type in cycle.

Code around is cleaned from tabs and duplicated fragments.

TNaming_Builder class is changed to use Handles instead of C pointers in its fields.
This should protect from possible access to the freed memory if attribute is deleted while instance of TNaming_Builder is still alive.
In addition, method to construct dummy vertex for storing orientation is simplified.

8 years ago0023119: TNaming_Selector::Solve() fails (changes from single face to compound of...
szy [Fri, 14 Sep 2012 13:18:59 +0000 (17:18 +0400)]
0023119: TNaming_Selector::Solve() fails (changes from single face to compound of multiple faces)
Patch for Naming improvement.

1). Added persistence.
2). Removed not supported evolution - Replace.

Fix of QADraw commands.
Modified test case: caf named_shape F6

1). Redesigned DNaming commands: SelectShape & SolveSelection
2). Added 2 new scripts: F8 & F9

Adding test cases caf/named_shape/F8 F9

8 years ago0023086: OCC 6.5.2 DNaming bug
szy [Fri, 14 Sep 2012 12:36:12 +0000 (16:36 +0400)]
0023086: OCC 6.5.2 DNaming bug

The code is corrected to create instances of TNaming_Builder class dynamically. Note that they cannot be created as local variables as they should be instantiated only when needed and then reused for the subshapes of the same type in cycle.
Code around is cleaned from tabs and duplicated fragments.

8 years ago0023214: BOP section operation produces incorrect result.
emv [Fri, 14 Sep 2012 11:37:14 +0000 (15:37 +0400)]
0023214: BOP section operation produces incorrect result.

8 years ago0023407: Draw face outlines for XDE objects
apl [Fri, 14 Sep 2012 10:37:57 +0000 (14:37 +0400)]
0023407: Draw face outlines for XDE objects

FaceOutline aspect and flag added to AIS_Drawer, Prs3d_Drawer.cdl
FaceOutlines computed by StdPrs_ShadedShape and build upon the edge triangulation.
"vshowoutlines" draw command for testing outlines on AIS_Shapes,
"XShowOutlines" draw command for testing outlines on XCAF objects.
remarks corrected:
- FaceOutline renamed to FaceBoundary
- Graphic3d_ArrayOfSegments with edges used instead of Graphic3d_ArrayOfPolylines with bounds.
draw boundaries in separate Graphic3d_Group.
Adding test cases bugs/vis/CR23407_1 CR23407_2

8 years ago0023430: Tests in xcaf group fail in parallel mode
ski [Wed, 12 Sep 2012 14:24:01 +0000 (18:24 +0400)]
0023430: Tests in xcaf group fail in parallel mode

8 years agoCorrected integration.
bugmaster [Thu, 13 Sep 2012 07:56:48 +0000 (11:56 +0400)]
Corrected integration.

8 years agoCorrected integration.
apn [Tue, 11 Sep 2012 12:43:12 +0000 (16:43 +0400)]
Corrected integration.

8 years agoAdjusting xcaf test group
apn [Mon, 10 Sep 2012 13:00:39 +0000 (17:00 +0400)]
Adjusting xcaf test group

8 years ago0023272: Image comparison algorithm
kgv [Mon, 10 Sep 2012 10:30:46 +0000 (14:30 +0400)]
0023272: Image comparison algorithm

A new class Image_Diff for comparison of images
and a draw-command "diffimage", which compares 2 images.

Image_PixMap redesigned to provide interface for low-level image operations.
New Image_AlienPixMap class now intended for Save/Load functionality.

Aspect_PixMap class dropped.
Xw_PixMap and WNT_PixMap classes now do not inherit from Aspect_PixMap and deprecated.

ToPixMap methods now retrieve Image_PixMap as argument.

Remarks applied
Fix compilation (correct merging error)

Eliminated Aspect <-> Image cyclic dependency

Fixed GIF dump in case of BGR32 image format

8 years ago0023196: Porting to the latest version of ftgl library
apl [Fri, 7 Sep 2012 12:50:42 +0000 (16:50 +0400)]
0023196: Porting to the latest version of ftgl library

Use FreeType entities instead of private helper classes from FTGL.
OpenGl package: link freetype.lib and ftgl.lib on Windows with #pragma comment.

8 years ago0023384: Translate sub-shape names between XDE document and STEP
apn [Fri, 7 Sep 2012 09:03:39 +0000 (13:03 +0400)]
0023384: Translate sub-shape names between XDE document and STEP

Sub-shapes naming translation between XDE and STEP implemented as an optional mode of Reader/Writer.
New static variables are now available: write.stepcaf.subshapes.name for Writer and read.stepcaf.subshapes.name for Reader (both have 0 values by default).
XOpen command implemented in scope of XDEDRAW asset.

Added test case bugs xde CR23384

8 years ago0023403: Crash when parsing an expression with lexical error
vsr [Fri, 7 Sep 2012 10:19:09 +0000 (14:19 +0400)]
0023403: Crash when parsing an expression with lexical error

Fix double freeing of memory in case when lexical error is detected by parser:
- revert previous fix, instead nullify the global buffer after its freeing in ExprIntrp_stop_string().

Added new QA command CR23403 and test case

8 years ago0023405: BOP common produces one face instead of a solid
pkv [Fri, 7 Sep 2012 10:11:06 +0000 (14:11 +0400)]
0023405: BOP common produces one face instead of a solid

Modified class :IntTools_FaceFace
   - method: void IntTools_FaceFace::ComputeTolReached3d()
The goal is:
to give more precise definition to the value of tolerance of intersection curves in 3D for the case plane/sphere.

Added test case boolean/bopcommon_complex/M7
Added test case boolean/bopcommon_simple/ZP9 for verified bug CR23374

8 years ago0023409: Tricheck command doesn't report problem when triangulation has unexpected...
oan [Fri, 7 Sep 2012 09:58:12 +0000 (13:58 +0400)]
0023409: Tricheck command doesn't report problem when triangulation has unexpected holes

Tricheck command improvement for checking triangulation holes on free links
More obvious error message
Added test case bugs demo CR23409
Modified test case offset wire_closed_outside_0_005 G7

8 years ago0023410: QA commands don't work properly in new testing system
apn [Thu, 6 Sep 2012 10:24:05 +0000 (14:24 +0400)]
0023410: QA commands don't work properly in new testing system

Comment adding command rename. Add QA test case.
Adjusting bugs test group

8 years ago0023374: BOP Common between a sphere and a box gives wrong result
pkv [Sun, 2 Sep 2012 09:48:03 +0000 (13:48 +0400)]
0023374: BOP Common between a sphere and a box gives wrong result

8 years ago0023357: The 'then' statement is equivalent to the 'else' statement.
mkv [Fri, 24 Aug 2012 13:34:08 +0000 (17:34 +0400)]
0023357: The 'then' statement is equivalent to the 'else' statement.

8 years ago0023412: Integration of test grid "dec" into the new testing system
miv [Fri, 31 Aug 2012 08:05:49 +0000 (12:05 +0400)]
0023412: Integration of test grid "dec" into the new testing system

Integration of test grid "dec" into the new testing system with "xcaf" name

8 years ago0023377: Error in importing a rational spline IGES surface [Type 128, PROP3 = 0]...
sneeraj [Fri, 31 Aug 2012 11:33:33 +0000 (15:33 +0400)]
0023377: Error in importing a rational spline IGES surface [Type 128, PROP3 = 0] into OCCT

Fix to address Rational surface with non-unitary weights at last index
Add new test case folder with test case for bugs

8 years ago0023205: Patch for Naming improvement
szy [Fri, 31 Aug 2012 11:26:23 +0000 (15:26 +0400)]
0023205: Patch for Naming improvement

1). Added persistence.
2) Removed not supported evolution - Replace.
QADraw commands were fixed .
Modified test case: caf named_shape F6

8 years agoIntegration of adjusted testing cases.
bugmaster [Mon, 27 Aug 2012 12:12:38 +0000 (16:12 +0400)]
Integration of adjusted testing cases.

8 years ago0023393: Improve usability of OSD_MAllocHook::CollectBySize
Roman Lygin [Sun, 19 Aug 2012 07:01:32 +0000 (11:01 +0400)]
0023393: Improve usability of OSD_MAllocHook::CollectBySize

Usability of OSD_MAllocHook::CollectBySize was improved:
- fields of OSD_MAllocHook::CollectBySize are made public (not private) to enable access for debugging purposes.
- added field myMaxAllocSize to denote maximum tracked size

8 years ago0023392: Memory leak in OCAF in debug mode
Roman Lygin [Fri, 24 Aug 2012 11:08:50 +0000 (15:08 +0400)]
0023392: Memory leak in OCAF in debug mode

TDF_LabelNode::Destroy() does not free memory for entry strings TCollection_AsciiString myDebugEntry problem was corrected.

8 years ago0023397: Marker aspect doesn't applied to points drawn by Primitive Arrays
kgv [Wed, 22 Aug 2012 07:36:50 +0000 (11:36 +0400)]
0023397: Marker aspect doesn't applied to points drawn by Primitive Arrays

Applying color and point size (marker type currently ignored).

8 years ago0023341: Wrong result done by 2D classifier algorithm for a point and a face.
pkv [Fri, 24 Aug 2012 10:32:10 +0000 (14:32 +0400)]
0023341: Wrong result done by 2D classifier algorithm for a point and a face.

Class classIntCurve_IntConicConic has been changed.
The intersection point that is definitely out of both domains is rejected.
Improving expression on lines 1101-1104 of IntCurve_IntConicConic_1.cxx to be more clear with adding comments.

8 years ago0023373: MSVC++ warnings issued during compilation for 64bits, 'Sparse Arrays'
Pawel [Fri, 24 Aug 2012 10:18:55 +0000 (14:18 +0400)]
0023373: MSVC++ warnings issued during compilation for 64bits, 'Sparse Arrays'

Replaced 'Standard_Integer' with 'Standard_Size' to avoid compiler warning.
Removed redundant casting to 'Standard_Size'.
Removed code checking if a 'Standard_Size' variable is negative.

8 years ago0023385: Bug in AIS_TexturedShape::Compute()
san [Thu, 16 Aug 2012 15:43:26 +0000 (19:43 +0400)]
0023385: Bug in AIS_TexturedShape::Compute()

Mistake in AIS_TexturedShape::Compute() occurred in the patch for issue 22971 corrected

8 years ago0023371: Expression which check of change of square/volume/length in end files doesn...
ski [Mon, 20 Aug 2012 09:33:29 +0000 (13:33 +0400)]
0023371: Expression which check of change of square/volume/length in end files doesn't work properly

Modified END files
Corrected tests cases due to modification of END files

8 years ago0023364: Integration of test grid "cpp" into the new testing system
ski [Tue, 31 Jul 2012 14:10:09 +0000 (18:10 +0400)]
0023364: Integration of test grid "cpp" into the new testing system

Integration of test grid "cpp" (pipe) into the new testing system

8 years ago0023382: Integration of test grid "did" into the new testing system
ski [Wed, 15 Aug 2012 13:16:53 +0000 (17:16 +0400)]
0023382: Integration of test grid "did" into the new testing system

Integration of test grid "did" ( heal tests ) into the new testing system

8 years ago0023369: MSVC++ warnings issued during compilation for 64bits, Materials.cxx
Pawel [Tue, 7 Aug 2012 09:07:28 +0000 (11:07 +0200)]
0023369: MSVC++ warnings issued during compilation for 64bits, Materials.cxx

Replaced 'Standard_Integer' with 'Standard_Size' to avoid compiler warning.

8 years ago0023370: MSVC++ warnings issued during compilation for 64bits, WNT_FontMapEntry.cxx
Pawel [Tue, 7 Aug 2012 12:12:02 +0000 (14:12 +0200)]
0023370: MSVC++ warnings issued during compilation for 64bits, WNT_FontMapEntry.cxx

Replaced 'int' with 'Standard_Size' to avoid compiler warning.

8 years ago0023306: Failures reading some attributes of BinOcaf document
szy [Mon, 20 Aug 2012 08:56:47 +0000 (12:56 +0400)]
0023306: Failures reading some attributes of BinOcaf document

Saving OCAF attribute TColStd_Array1OfExtendedString to binary file is corrected (missing data field written).

8 years agoCorrected integration
bugmaster [Mon, 13 Aug 2012 11:34:43 +0000 (15:34 +0400)]
Corrected integration

8 years ago0023295: A part of conditional expression is always true
Pawel [Tue, 17 Jul 2012 09:34:42 +0000 (11:34 +0200)]
0023295: A part of conditional expression is always true

Checking if curve type is GeomAbs_BSplineCurve.

8 years ago0023349: There are identical sub-expressions 'aS1.ShapeType() != TopAbs_FACE' to...
Pawel [Thu, 26 Jul 2012 09:08:26 +0000 (11:08 +0200)]
0023349: There are identical sub-expressions 'aS1.ShapeType() != TopAbs_FACE' to the left and to the right of the '||' operator.

The same shape was checked twice if it was a face. The other shape was omitted instead.

8 years ago0023296: Not verifying method return flag
Pawel [Tue, 17 Jul 2012 09:37:28 +0000 (11:37 +0200)]
0023296: Not verifying method return flag

Checking the returned flag. If the method fails return.

8 years ago0023294: Identical sub-expression in 'if-clause'
Pawel Kowalski [Fri, 10 Aug 2012 06:45:42 +0000 (10:45 +0400)]
0023294: Identical sub-expression in 'if-clause'

Correcting probable copy-paste bug.
Test case offset shape_type_i D7 was modified

8 years ago0023365: Name collision of global IsEqual() leads to overriding user's definition
Roman Lygin [Wed, 1 Aug 2012 20:14:05 +0000 (00:14 +0400)]
0023365: Name collision of global IsEqual() leads to overriding user's definition

Prevent name collision of global IsEqual()

8 years agoCorrected integration
Pawel Kowalski [Mon, 6 Aug 2012 12:25:17 +0000 (16:25 +0400)]
Corrected integration

8 years ago0023356: Suspicious assignment inside the condition expression of 'if' operator.
Pawel [Thu, 26 Jul 2012 11:06:55 +0000 (13:06 +0200)]
0023356: Suspicious assignment inside the condition expression of 'if' operator.

Changed the assignments in the if-clauses to comparisons.

8 years ago0023347: Expression '(* q == ' ') && (* q == '\t')' is always false. Probably the...
Pawel [Wed, 25 Jul 2012 15:35:26 +0000 (17:35 +0200)]
0023347: Expression '(* q == ' ') && (* q == '\t')' is always false. Probably the '||' operator should be used here.

Replacing '&&' with '||'.

8 years ago0023348: Expression 'ii >= 0' is always true. Unsigned type value is always >= 0.
Pawel Kowalski [Fri, 3 Aug 2012 09:28:27 +0000 (13:28 +0400)]
0023348: Expression 'ii >= 0' is always true. Unsigned type value is always >= 0.

Redesigned the loop to work correctly with unsigned variables.
Treatment of path to source file is rewritten using OSD_Path for more clarity
Command getsourcefile corrected to return its result as Tcl string, and simplified
Error in treatment of optional arguments in substituted puts is fixed in src/DrawResources/TestCommands.tcl
Test case added: demo draw getsource

8 years ago0023350: The null pointer is passed into 'strcmp' function.
Pawel [Thu, 26 Jul 2012 09:18:42 +0000 (11:18 +0200)]
0023350: The null pointer is passed into 'strcmp' function.

The method returns if it gets a NULL pointer.

8 years ago0023353: Graphic3d_NOM_STONE used twice in an if-clause.
Pawel [Thu, 26 Jul 2012 09:54:13 +0000 (11:54 +0200)]
0023353: Graphic3d_NOM_STONE used twice in an if-clause.

Graphic3d_NOM_STONE appeared twice in the if-clause.

8 years ago0023362: Adding DRAW command vsetinteriorstyle
san [Fri, 3 Aug 2012 07:35:36 +0000 (11:35 +0400)]
0023362: Adding DRAW command vsetinteriorstyle

Adding DRAW command vsetinteriorstyle
- Translated French comments to English

8 years ago0023363: [Regression] Lost gradient background when switching to the hollow interior...
san [Fri, 3 Aug 2012 07:16:58 +0000 (11:16 +0400)]
0023363: [Regression] Lost gradient background when switching to the hollow interior style

Calling glPolygonMode() to ensure filled polygon rendering when drawing
the view background
Revert "Calling glPolygonMode() to ensure filled polygon rendering when drawing"

This reverts commit 41d41ab23cb81acb3bcf7e6ad5d10ea0097eecdd.
OpenGl_Workspace::ResetAppliedAspect() method improved in order to
reset GL parameters to default values specified in default aspects.
This method is now called twice during scene rendering:
- At the very beginning by OpenGl_Workspace::Activate()
- After all structures has been drawn but before the auxiliary stuff
(like trihedrons, overlayer, display callbacks)

8 years ago0023298: Integration of test grid "off" into the new testing system
ski [Mon, 30 Jul 2012 12:09:29 +0000 (16:09 +0400)]
0023298: Integration of test grid "off" into the new testing system

8 years agoCorrected integration
bugmaster [Fri, 27 Jul 2012 13:59:22 +0000 (17:59 +0400)]
Corrected integration

8 years ago0023330: Redundant copying in Geom2d_OffsetCurve::Geom2d_OffsetCurve method
abk [Thu, 19 Jul 2012 13:51:32 +0000 (17:51 +0400)]
0023330: Redundant copying in Geom2d_OffsetCurve::Geom2d_OffsetCurve method

Redundant copying of 'C' in Geom2d_OffsetCurve::Geom2d_OffsetCurve(const Handle(Curve)& C, const Standard_Real Offset) method was removed.

8 years ago0023346: MSVC++ Error C2664: 'AIS_InteractiveObject::PolygonOffsets': conversion...
Pawel Kowalski [Fri, 27 Jul 2012 12:52:37 +0000 (16:52 +0400)]
0023346: MSVC++ Error C2664: 'AIS_InteractiveObject::PolygonOffsets': conversion from 'Standard_Real' in 'Standard_ShortReal &'

Changed Standard_Real to Standard_ShortReal.

Modify test case offset shape_type_i D6

8 years ago0023274: MSVC++ warnings issued during compilation for 64bits
Pawel [Thu, 12 Jul 2012 15:24:03 +0000 (17:24 +0200)]
0023274: MSVC++ warnings issued during compilation for 64bits

Replacing Standard_Integer with Standard_Size to avoid warnings.

8 years ago0023332: Expression 'anIndex < 0' is always false. Unsigned type value is never ...
Pawel Kowalski [Fri, 27 Jul 2012 12:08:57 +0000 (16:08 +0400)]
0023332: Expression 'anIndex < 0' is always false. Unsigned type value is never < 0. in Vrmldata_Geometry.cxx

Examining index sign before casting to Standard_Size.

Argument of method VrmlData_ArrayVec3d::Value() changed from Standard_Integer to Standard_Size to be consistent with its use (avoid compiler warnings)

8 years ago0023333: The variable 'i' is being used for this loop and for the outer loop in Vrmld...
Pawel [Fri, 20 Jul 2012 11:07:26 +0000 (13:07 +0200)]
0023333: The variable 'i' is being used for this loop and for the outer loop in Vrmldata_ShapeConvert.cxx

Use separate variable to iterate the inner loop.

8 years ago0023335: Array overrun is possible. The value of 'i' index could reach 200 in Interfa...
Pawel [Fri, 20 Jul 2012 12:16:50 +0000 (14:16 +0200)]
0023335: Array overrun is possible. The value of 'i' index could reach 200 in Interface_MSG.cxx

Iterating from 1 to 199 over the 'buf' in order to avoid an overrun.

8 years ago0023337: The 'strcmp' function returns 0 if corresponding strings are equal. (1)
Pawel [Fri, 20 Jul 2012 13:59:02 +0000 (15:59 +0200)]
0023337: The 'strcmp' function returns 0 if corresponding strings are equal. (1)

Checking if the return value from 'strcmp' is '0'.

8 years ago0023336: The 'strcmp' function returns 0 if corresponding strings are equal.
Pawel [Fri, 20 Jul 2012 12:56:44 +0000 (14:56 +0200)]
0023336: The 'strcmp' function returns 0 if corresponding strings are equal.

Checking if the return value from 'strcmp' is '0'.

8 years ago0023339: The 'strcmp' function returns 0 if corresponding strings are equal. (2)
Pawel [Fri, 20 Jul 2012 14:28:44 +0000 (16:28 +0200)]
0023339: The 'strcmp' function returns 0 if corresponding strings are equal. (2)

Checking if the return value from 'strcmp' is '0'.

8 years ago0023340: The values of different enum types are compared: switch(ENUM_TYPE_A) { case...
Pawel [Fri, 20 Jul 2012 14:56:01 +0000 (16:56 +0200)]
0023340: The values of different enum types are compared: switch(ENUM_TYPE_A) { case ENUM_TYPE_B: ... }. StepToTopoDS.cxx

Corrected the used enumeration type.

8 years ago0023325: Always getting the transparency of the back face
Pawel [Wed, 18 Jul 2012 10:53:47 +0000 (12:53 +0200)]
0023325: Always getting the transparency of the back face

Added the 'breaks' in the affected 'switch' statement.

8 years ago0023319: Typo in AIS_ConcentricRelation.cxx line 156
Pawel [Wed, 18 Jul 2012 10:42:02 +0000 (12:42 +0200)]
0023319: Typo in AIS_ConcentricRelation.cxx line 156

Checking if the 'Vertex2' (NOT 'Vertex1') is on plane in order to project it.

8 years ago0023320: The body of 'OpenCollector' function is fully equivalent to the body of...
Pawel [Wed, 18 Jul 2012 10:43:54 +0000 (12:43 +0200)]
0023320: The body of 'OpenCollector' function is fully equivalent to the body of 'CloseCollector' function

When opening the collector setting the corresponding flag to Standard_False.

8 years ago0023326: The 'aSibling' pointer was utilized before it was verified against nullptr...
Pawel [Wed, 18 Jul 2012 12:50:45 +0000 (14:50 +0200)]
0023326: The 'aSibling' pointer was utilized before it was verified against nullptr. ldom_element.cxx

Verifying pointer against NULL before accessing it.

8 years ago0023317: Using the iteration variable in the inner and outer loop in GGraphic2d_SetOf...
Pawel [Wed, 18 Jul 2012 08:48:50 +0000 (10:48 +0200)]
0023317: Using the iteration variable in the inner and outer loop in GGraphic2d_SetOfCurves.cxx

Replaced the iteration variable for the internal loop.

8 years ago0023318: If statement equal to else statement in AIS_ConcentricRelation.cxx, lines...
Pawel [Wed, 18 Jul 2012 10:40:06 +0000 (12:40 +0200)]
0023318: If statement equal to else statement in AIS_ConcentricRelation.cxx, lines 108-115

Corrected the else-clause.

8 years ago0023277: Buffer underflow using memset in osd_path.cxx
Pawel [Fri, 13 Jul 2012 13:40:22 +0000 (15:40 +0200)]
0023277: Buffer underflow using memset in osd_path.cxx

The parameter used in memset matches the buffer size.

8 years ago0023322: Identical sub-expressions 'MyCView.Orientation.ViewReferencePoint.y != float...
Pawel [Wed, 18 Jul 2012 10:48:11 +0000 (12:48 +0200)]
0023322: Identical sub-expressions 'MyCView.Orientation.ViewReferencePoint.y != float (Y)'

Changed the duplicate 'y' to 'z'.

8 years ago0023315: Duplicate comarison in an if-clause ib Prs2d_ToleranceFrame.cxx
Pawel [Wed, 18 Jul 2012 08:44:57 +0000 (10:44 +0200)]
0023315: Duplicate comarison in an if-clause ib Prs2d_ToleranceFrame.cxx

Testing the length of 'myTxt2'  instead of 'myTxt1' twice.

8 years ago0023342: Changing of OCCT tests according to integration of 23.07.2012
vtn [Mon, 23 Jul 2012 11:53:47 +0000 (15:53 +0400)]
0023342: Changing of OCCT tests according to integration of 23.07.2012

Tests are changed according to current state of OCCT.

8 years ago0023280: Pointer to local array is stored outside the scope of this array.
Pawel [Fri, 13 Jul 2012 14:29:20 +0000 (16:29 +0200)]
0023280: Pointer to local array is stored outside the scope of this array.

Moved the array 'buff' so it can be visible while 'str' still refers to it.

8 years ago0023273: Avoid failures due to datadir commend when data files are not present
vtn [Fri, 20 Jul 2012 13:37:21 +0000 (17:37 +0400)]
0023273: Avoid failures due to datadir commend when data files are not present

Fix for #23273 issue.
Fix for #23273 issue (boolean/013/R9).
Modifications of tests according to #23260 issue.
Attempt to protect against hang-ups due to waiting for standard input
change of behaviour of offset/shape_type_i/D7 case.
Attempt to protect against hang-ups during initialization of menu in batch mode.
increase cpulimit for parallel incmesh.
#23260 is fixed. count_parallel is not needed anymore.
Deleted unused code.
change of behaviour of offset/shape_type_i/D7 case.
The fix was incorrect.
Second attempt to protect against hang-ups during initialization of menu in batch mode
correction of tests in order to awoid instability.
Elapsed time changed to CPU user time is performance tests.
Processing of errors on Windows.
Stop cpulimit killer if armed by test, after the test is completed

8 years ago0023260: Regression: Instability in parallel incmesh on Linux.
dbv [Fri, 20 Jul 2012 13:18:29 +0000 (17:18 +0400)]
0023260: Regression: Instability in parallel incmesh on Linux.

Added protection to the function which may have data race (according to the valgrind report).
Added protection to the BRepMesh_FastDiscretFace::RestoreStructureFromTriangulation function
Slight reordering to optimize use of mutex (lock once)
Now Standard_Mutex::SentryNested are created as named object.
Map inside TopTools_MutexForShapeProvider now store Handle_TopoDS_TShape as a key instead of TopoDS_Shape

8 years ago0023244: Bug of BRepClass_FaceClassifier: it does not take into account the tolerance
jgv [Fri, 20 Jul 2012 13:12:28 +0000 (17:12 +0400)]
0023244: Bug of BRepClass_FaceClassifier: it does not take into account the tolerance

8 years ago0023224: Empty result done by intersection algorithm
ama [Mon, 16 Jul 2012 15:13:20 +0000 (19:13 +0400)]
0023224: Empty result done by intersection algorithm

Remove the cutting of the original surface from IntCurveSurface_Inter to see how much it affects the correctness of the algorithm.

8 years ago0023265: cppcheck warning: Mismatching allocation and deallocation
Pawel [Thu, 12 Jul 2012 09:43:42 +0000 (11:43 +0200)]
0023265: cppcheck warning: Mismatching allocation and deallocation

Use pairs: new - delete (new - delete [] for arrays), malloc - free

8 years ago0023264: cppcheck warning: Logical conjunction always evaluates to false
Pawel [Thu, 12 Jul 2012 08:17:38 +0000 (10:17 +0200)]
0023264: cppcheck warning: Logical conjunction always evaluates to false

Replaced the '&&' operator with '||'. Otherwise the logical conjunction always evaluates to false.

8 years ago0023279: Accessing NULL pointer
Pawel [Fri, 13 Jul 2012 14:14:38 +0000 (16:14 +0200)]
0023279: Accessing NULL pointer

Assuring the pointer is not 'NULL'.

8 years ago0023259: MSVC: C4101 warning - unreferenced local variable
Pawel [Wed, 11 Jul 2012 12:11:56 +0000 (14:11 +0200)]
0023259: MSVC: C4101 warning - unreferenced local variable

Removed unreferenced variables

8 years ago0023278: Buffer underflow using memset in osd_host.cxx
Pawel [Fri, 13 Jul 2012 14:00:52 +0000 (16:00 +0200)]
0023278: Buffer underflow using memset in osd_host.cxx

Zero memory uses the size of the array.

8 years ago0023287: IntPolyh_MaillageAffinage.cxx, line 2217: "identical sub-expressions to...
Pawel [Mon, 16 Jul 2012 10:34:22 +0000 (12:34 +0200)]
0023287: IntPolyh_MaillageAffinage.cxx, line 2217: "identical sub-expressions to the left and to the right of the '-' operator"

Changed the redundant curve type Geom(2d)_BSplineCurve to Geom(2d)_BezierCurve.