occt.git
6 weeks ago0030715: Configuration, CMake - error build with QTANGLE
apn [Tue, 4 Jun 2019 11:20:56 +0000]
0030715: Configuration, CMake - error build with QTANGLE

SEARCH_TEMPLATES was modified to find EGL and GLES2 libraries in different folders (angle-gles, egl-gles, egl, angle, etc).
Find 3rdparty products procedure allows to define 3RDPARTY_LIBRARY_DIR or 3RDPARTY_DLL_DIR manually to find necessary libraries and dlls.

6 weeks ago0030760: Modeling Algorithms - Intersection fails in Occt 7.3.0
emv [Mon, 3 Jun 2019 08:36:18 +0000]
0030760: Modeling Algorithms - Intersection fails in Occt 7.3.0

Use FORWARD orientation of edges and face when attaching pcurve from one edge to another.
Test case for the issue.

7 weeks ago0030656: Modeling Algorithms - Change Boolean Operations algorithm to use BVH tree...
emv [Thu, 18 Apr 2019 12:34:37 +0000]
0030656: Modeling Algorithms - Change Boolean Operations algorithm to use BVH tree instead of UBTree

Switching the Boolean Operations algorithm to use the BVH tree instead of UB tree as selection of the elements from BVH tree is usually faster.

7 weeks ago0030764: Coding - warnings in Image_AlienPixMap.cxx when built with MSVC10
abv [Tue, 4 Jun 2019 06:21:28 +0000]
0030764: Coding - warnings in Image_AlienPixMap.cxx when built with MSVC10

Disable warnings when including system headers (conflict between VS 2010 and Windows SDK definitions).

7 weeks ago0030729: Visualization - TKOpenGl reports OpenGL 4.5 loading functions error on Intel...
kgv [Sun, 26 May 2019 09:46:32 +0000]
0030729: Visualization - TKOpenGl reports OpenGL 4.5 loading functions error on Intel drivers

Make reported error more verbose.

7 weeks ago0028668: Point Cloud Rendering - standard selection API returns invalid values CR0-SCHARP-FH IR-2019-05-31
kgv [Thu, 30 May 2019 07:02:25 +0000]
0028668: Point Cloud Rendering - standard selection API returns invalid values

Added an argument to OpenGl_GraphicDriver::GetSharedContext() for returning only currently bound OpenGL context.
SelectMgr_SelectingVolumeManager::GetMousePosition() - added getter returning mouse coordinates.

7 weeks ago0030756: Visualization, TKOpenGl - capping plane does not work for ZLayer with non... WEEK-22
kgv [Wed, 29 May 2019 12:22:10 +0000]
0030756: Visualization, TKOpenGl - capping plane does not work for ZLayer with non-zero origin

OpenGl_CappingPlaneResource::updateTransform() now takes into account ZLayer origin.

Fixed VT_ProcessKeyPress() passing arbitrary input to Draw::Atoi() leading
to messages in console like "unclosed braces".

7 weeks ago0030745: Visualization, TKOpenGl - fix initialization of GLES3 context
kgv [Sat, 25 May 2019 15:59:17 +0000]
0030745: Visualization, TKOpenGl - fix initialization of GLES3 context

OpenGl_GraphicDriver::InitContext() now tries to initialize GLES3 context
(EGL_CONTEXT_CLIENT_VERSION) and then fallback to GLES2.

7 weeks ago0030698: Volume Rendering - Early clipping of volume object's bounding box
iko [Tue, 7 May 2019 12:44:39 +0000]
0030698: Volume Rendering - Early clipping of volume object's bounding box

Flag to control check of bounding box clipping before drawing has been added.

8 weeks ago0030655: Modeling Data - Provide interfaces for selection of the elements from BVH...
emv [Wed, 17 Apr 2019 14:29:02 +0000]
0030655: Modeling Data - Provide interfaces for selection of the elements from BVH tree

Provide the easy to use interfaces for selection of the elements from BVH tree.
The selection rules should be implemented in the selector class derived from *BVH_Traverse* or in *BVH_PairTraverse* in Reject/Accept methods.

The *BVH_Traverse* is used for selection of the elements from the tree.
The *BVH_PairTraverse* is used for selection of the pairs of elements from two BVH trees.

Auxiliary changes:
- Two methods BVH_Box::IsOut(OtherBox) and BVH_Box::IsOut(Point) have been added;
- Added methods for conversion of Bnd boxes to BVH boxes

Added new class *BVH_Tools* containing useful static methods operating on BVH points and boxes.

The classes BRepExtrema_OverlapTool and BVH_DistanceField have been rebased to use the new traverse methods.

8 weeks ago0030731: Modeling Data - B-Spline should have explicit data check error messages
Benjamin Bihler [Thu, 23 May 2019 12:49:50 +0000]
0030731: Modeling Data - B-Spline should have explicit data check error messages

Error messages have been added in throw statements.

8 weeks ago0030694: Data Exchange - support non-standard GB2312-encoded STEP files IR-2019-05-24
kgv [Mon, 6 May 2019 13:00:16 +0000]
0030694: Data Exchange - support non-standard GB2312-encoded STEP files

STEPCAFControl_Reader::SourceCodePage() - added property defining text encoding
for converting names within STEPCAFControl_Reader::ReadNames() method.
Added associated "read.stepcaf.codepage" parameter,
which default value is Resource_UTF8, preserving current behavior.

Resource_FormatType enumeration has been extended by UTF8 and SystemLocale values.
Resource_Unicode - added conversion methods taking Resource_FormatType as argument.

GetName command has been corrected to NOT replace non-Latin symbols.

8 weeks ago0030702: Configuration, CMake - error for iOS build due to searching macos frameworks
kgv [Fri, 24 May 2019 08:00:35 +0000]
0030702: Configuration, CMake - error for iOS build due to searching macos frameworks

Look for UIKit+OpenGLES on iOS instead of AppKit+OpenGL.

8 weeks ago0030738: Data Exchange - XCAFDoc_ShapeTool::updateComponent() is too long
kgv [Thu, 23 May 2019 19:46:58 +0000]
0030738: Data Exchange - XCAFDoc_ShapeTool::updateComponent() is too long

Cache subshapes list into map instead of re-iterating it multiple times within the loop.
Avoid iteration at all if modified state has been already detected.

XCAFDoc now returns GUIDs by const reference instead of a copy.

8 weeks ago0030590: Wrong result of Boolean Cut algorithm WEEK-21
jgv [Thu, 25 Apr 2019 16:46:14 +0000]
0030590: Wrong result of Boolean Cut algorithm

    Modification in static method BoundedArc of IntStart_SearchOnBoundaries:
    add exact intersection of canonical curve-surface (when Func is IntPatch_ArcFunction).

2 months ago0030727: Data Exchange - Problems in Shape Tool
ika [Wed, 22 May 2019 12:22:54 +0000]
0030727: Data Exchange - Problems in Shape Tool

Add protection from return of not top-level shape by FindShape method.
Add protection against located roots into FindMainShape method.
Add new Draw command for FindMainShape.
Add flag findInstance to Draw command FindShape

2 months ago0030670: Modeling Algorithms - Performance improvement of Boolean Operations algorithm
emv [Tue, 23 Apr 2019 09:31:23 +0000]
0030670: Modeling Algorithms - Performance improvement of Boolean Operations algorithm

The following improvements have been made in Boolean operations algorithm:
1. Added possibility to update FaceInfo structure for many faces at once which helps to avoid nested loops.
2. Improve Point-Face classification procedure by caching the FaceExplorer for a face.

2 months ago0030440: Visualization - Graphic3d_Camera::Frustum() returns wrong planes in portrait...
kgv [Thu, 23 May 2019 09:02:29 +0000]
0030440: Visualization - Graphic3d_Camera::Frustum() returns wrong planes in portrait mode

Graphic3d_Camera::Frustum() now handles window Aspect Ratio < 1.0.

2 months ago0030687: Visualization - remove redundant interfaces SelectBasics_EntityOwner and...
kgv [Tue, 21 May 2019 16:42:15 +0000]
0030687: Visualization - remove redundant interfaces SelectBasics_EntityOwner and SelectBasics_SensitiveEntity

SelectBasics_EntityOwner has been merged into SelectMgr_EntityOwner.
Unused property SelectMgr_EntityOwner::ResetLocation() has been removed.
SelectBasics package has been moved from TKService to TKV3d.

SelectBasics_SensitiveEntity has been merged into Select3D_SensitiveEntity.

2 months ago0030718: Mesh - broken triangulation within 32-bit builds
tiv [Tue, 21 May 2019 13:18:48 +0000]
0030718: Mesh - broken triangulation within 32-bit builds

The problem caused by the changing of HashCode() method of TColStd_PackedMapOfInteger::TColStd_intMapNode class done as a part of 30550 changes is solved.

2 months ago0030680: VIS - IVtkOCC_ShapeMesher displays Isoline wrong
kgv [Sun, 19 May 2019 12:57:54 +0000]
0030680: VIS - IVtkOCC_ShapeMesher displays Isoline wrong

IVtkOCC_ShapeMesher now calls StdPrs_Isolines tool instead of code copy-paste.

2 months ago0030717: Visualization, AIS_InteractiveContext::Erase() - selection presentation...
kgv [Sun, 19 May 2019 06:46:59 +0000]
0030717: Visualization, AIS_InteractiveContext::Erase() - selection presentation in a mode other than the default after hiding an object

AIS_InteractiveContext::EraseGlobal() now erases all object owners
(in the same way as AIS_InteractiveContext::ClearGlobal()).

Removed redundant fields AIS_InteractiveContext::myLastinMain and myWasLastMain.

2 months ago0030713: Visualization, TKOpenGl - stipple line artifacts on Intel UHD Graphics 630
mnv [Thu, 16 May 2019 06:28:28 +0000]
0030713: Visualization, TKOpenGl - stipple line artifacts on Intel UHD Graphics 630

Added workaround for dashed line presentation on Intel UHD Graphics 630.

2 months ago 0030716: Visualization - Set polygon offset units property to 1.0
tiv [Fri, 17 May 2019 09:01:01 +0000]
 0030716: Visualization - Set polygon offset units property to 1.0

The default value of the Units property of the Graphic3d_PolygonOffset class is changed to 1.0f (instead of 0.0f used previously).

2 months ago0030679: Attached model hangs most of OCCT common functionality IR-2019-05-17 WEEK-20
msv [Mon, 13 May 2019 13:19:35 +0000]
0030679: Attached model hangs most of OCCT common functionality

Evaluator of offset surface has been protected against evaluation at infinite parameters. Now it throws exception when evaluating such data.

The methods IsUClosed and IsVClosed of the class ShapeAnalysis_Surface have been corrected to avoid evaluation of the surface at infinite parameters (fighting with regressions "parasolid doc_3 E3" and "parasolid doc_2 A3" in products).

2 months ago0030561: Visualization, PrsMgr_PresentableObject - Keep the current transformation...
asl [Thu, 16 May 2019 08:23:21 +0000]
0030561: Visualization, PrsMgr_PresentableObject - Keep the current transformation for child in AddChild()

New methods AddChildWithCurrentTransformation(), RemoveChildWithRestoreTransformation() are implemented to keep the current global transformation of the object (child).
In DRAW a new command vchild is provided for testing low-level connections between presentations.

2 months ago0030712: Application Framework - Protect binary TriangulationDriver against empty...
msv [Wed, 15 May 2019 09:10:36 +0000]
0030712: Application Framework - Protect binary TriangulationDriver against empty triangulation in the file

The matter is that when the binary OCAF file contained a triangulation with 0 nodes and 0 triangles the method Paste would cause construction error of Poly_Triangulation.
This patch protects this method against exception.

2 months ago0030708: Modeling Data - Exception is raised while initializing TopoDS_Iterator with...
emv [Mon, 13 May 2019 09:32:09 +0000]
0030708: Modeling Data - Exception is raised while initializing TopoDS_Iterator with null shape

Added protection from null shapes to TopoDS_Iterator::Initialize method.

2 months ago0030705: Visualization, TKOpenGl - stipple line GLSL error on using OpenGL 2.1 +...
kgv [Mon, 13 May 2019 08:31:42 +0000]
0030705: Visualization, TKOpenGl - stipple line GLSL error on using OpenGL 2.1 + GL_EXT_gpu_shader4 extension on macOS

Fix compatibility with pure GL_EXT_gpu_shader4 specs by defining "uint" as "unsigned int".

2 months ago0030690: Draw Harness - provide XDisplay command for displaying XDE document
kgv [Fri, 3 May 2019 09:30:02 +0000]
0030690: Draw Harness - provide XDisplay command for displaying XDE document

XDisplay - added new command displaying XDE document in ViewerTest map of object:
> XDisplay Doc [label1 [label2 [...]]] [-explore {on|off}] [-docPrefix {on|off}] [-names {on|off}]
>              [-noupdate] [-dispMode Mode] [-highMode Mode]

vstate - added NULL checks.
vdisplay now prints error on attempt to specify unsupported display mode.
verase, vremove now raise Tcl exception on attempt to hide non-existing object.
verase, vremove, vdir now accept name masks like "verase b*".
vremove and vdir output is now consistent to verase command (space-separated list of removed objects).

2 months ago0030516: Visualization - Pointer to an OpenGl_Structure is deleted and accessed later...
kgv [Thu, 2 May 2019 13:58:06 +0000]
0030516: Visualization - Pointer to an OpenGl_Structure is deleted and accessed later after PrsMgr_Presentation::Highlight()

Do not set IsForHighlight flag for already displayed presentation.

2 months ago0030696: Draw Harness, testgrid - specify encoding in HTML header IR-2019-05-07 IR-WEEK18
kgv [Mon, 6 May 2019 19:44:51 +0000]
0030696: Draw Harness, testgrid - specify encoding in HTML header

2 months ago0030683: Coding Rules - eliminate CLang compiler warnings -Wreturn-std-move
kgv [Mon, 29 Apr 2019 16:51:34 +0000]
0030683: Coding Rules - eliminate CLang compiler warnings -Wreturn-std-move

Added generalized move constructor and assignment operator to initialize TopoDS_Shape by object of this or derived type.
Added move constructor and assignment operator for TopLoc_SListOfItemLocation.
Macro OCCT_NO_RVALUE_REFERENCE is used in Standard_Handle.hxx instead of direct check of compiler version.

2 months ago0029523: Problem with BRepOffsetAPI_MakeEvolved
nbv [Wed, 11 Apr 2018 09:23:29 +0000]
0029523: Problem with BRepOffsetAPI_MakeEvolved

The capabilities of the class BRepOffsetAPI_MakeEvolved have been extended with involving alternate algorithm of resolving the loops in the piped shape. The new option theIsVolume is added for that in the constructor.

New class BRepFill_AdvancedEvolved has been created in order to provide new OCCT-algorithm combining BRepFill_PipeShell and BOPAlgo_MakerVolume.

A change in BOPAlgo_PaveFiller.cxx has been made in order to solve a specific problem of Boolean operation.

The interface of DRAW-command "evolved" has been updated to add the new option. DRAW-command "evolvedsolid" has been deleted. Now it is replaced with DRAW-command "evolved" with the option "-solid".

Testgrid "evolved" has been created.

2 months ago0030684: Coding Rules - eliminate GCC compiler warnings -Wformat-overflow and -Wcatch...
kgv [Mon, 29 Apr 2019 19:31:45 +0000]
0030684: Coding Rules - eliminate GCC compiler warnings -Wformat-overflow and -Wcatch-value

2 months ago0030686: Visualization, SelectMgr_ViewerSelector - sorting issues of transformation...
kgv [Wed, 1 May 2019 09:24:35 +0000]
0030686: Visualization, SelectMgr_ViewerSelector - sorting issues of transformation-persistent objects

SelectMgr_ViewerSelector::updatePoint3d() - added missing Abs() for computed tolerance
and added check to not attempt transforming undefined 3D point.

2 months ago0030433: Checkshape: bad solid, created by revolution, is reported as valid.
ifv [Fri, 15 Mar 2019 13:59:08 +0000]
0030433: Checkshape: bad solid, created by revolution, is reported as valid.

BRepPrimAPI_MakeRevol.cxx, hxx
Insert checking of self-intersecting of generated surfaces in MakeRevol

BRepTest_SweepCommands.cxx
Adjusting command revol to current behavior of MakeRevol algorithm.

2 months ago0030675: Visualization - remove redundant proxy classes in hierarchy of PrsMgr_Presen...
kgv [Wed, 24 Apr 2019 16:53:17 +0000]
0030675: Visualization - remove redundant proxy classes in hierarchy of PrsMgr_Presentation

Removed redundant proxy class Prs3d_Presentation - Graphic3d_Structure now should be used directly.
Removed auxiliary class PrsMgr_ModedPresentation holding Structure and Display Mode index (field has been moved to Structure itself),
so that PrsMgr_Presentations (AIS_InteractiveObject::Presentations()) now holds Structures directly.
PrsMgr_Prs proxy class has been removed, and PrsMgr_Presentation now inherits Graphic3d_Structure.

Graphic3d_Structure, maps declarations have been corrected to use class instead of void*, which allowed to avoid redundant casts.
Several methods have been also modified to avoid creating Handle from this pointer.
AIS package headers have been cleaned up from forward declaration of Prs3d_Presentation class.

Fixed dereference of destroyed presentations within connected and HLR computed objects:
- AIS_InteractiveContext::Disconnect() now erases connected presentation.
- Graphic3d_CView::Clear() now removes destructed structures from Computed list.

- fix inaccessibility of PrsMgr_Presentation methods

2 months ago0030682: Configuration, qmake - all warnings are suppressed on macOS target
kgv [Mon, 29 Apr 2019 15:24:36 +0000]
0030682: Configuration, qmake - all warnings are suppressed on macOS target

Fixed inconsistency of compiler flags with genproj.
warn_on+QMAKE_CXXFLAGS_WARN_ON is now used instead of warn_off+QMAKE_CXXFLAGS.
Added No_Exception to DEFINES.

2 months ago0030681: Configuration - suppress OpenGL deprecation warning on macOS 10.14
kgv [Mon, 29 Apr 2019 15:43:14 +0000]
0030681: Configuration - suppress OpenGL deprecation warning on macOS 10.14

Define GL_SILENCE_DEPRECATION to suppress warnings.

2 months ago0030672: Visualization - AIS_InteractiveContext::SetLocation() sets invalid selection... IR-2019-04-26
kgv [Wed, 24 Apr 2019 06:16:19 +0000]
0030672: Visualization - AIS_InteractiveContext::SetLocation() sets invalid selection BVH flag to removed object

SelectMgr_SelectionManager::Remove() now deactivates selection before removal.

2 months ago0030669: Visualization - AIS_Manipulator ignores parent transformation IR-WEEK17
kgv [Wed, 24 Apr 2019 15:50:29 +0000]
0030669: Visualization - AIS_Manipulator ignores parent transformation

AIS_Manipulator::Transform() now considers object parent transformation.

Added new command vchild for easier testing of low-level connections between presentations.

2 months ago0030674: Visualization, AIS_InteractiveObject - fix accessibility of several properties
kgv [Thu, 4 Apr 2019 06:44:16 +0000]
0030674: Visualization, AIS_InteractiveObject - fix accessibility of several properties

AIS_InteractiveObject/SelectMgr_SelectableObject/PrsMgr_PresentableObject
- added missing getters;
- removed redundant private sections;
- improved documentation;
- AIS_InteractiveObject::Compute() marked as pure interface;
- methods within this hierarchy have been moved to the base class, when reasonable.

Removed redundant typedefs to pointers (PrsMgr_PresentationPointer, PrsMgr_PresentableObjectPointer).

2 months ago0030652: Configuration, genproj - reuse PRODUCTS_PATH within generated custom.bat
kgv [Tue, 16 Apr 2019 19:46:43 +0000]
0030652: Configuration, genproj - reuse PRODUCTS_PATH within generated custom.bat

genconfdeps.tcl now puts %PRODUCTS_PATH%/$PRODUCTS_PATH into generated custom.bat/custom.sh scripts.
Added missing CSF_winmm definition to OccToolkit.pri

3 months ago0030645: Modeling Algorithms - B-spline segmentation produces wrong parametrization
azv [Sat, 13 Apr 2019 11:57:39 +0000]
0030645: Modeling Algorithms - B-spline segmentation produces wrong parametrization

Method Segment() of B-spline curve and surface has been extended by parameter theTolerance (theUTolerance and theVTolerance for surface), which defines the proximity between knots of a NURBS and boundaries of cutting segment. The default value of the tolerance is Precision::PConfusion().
Test cases have been added to check segmenting of B-spline surface and curves both 2D and 3D.

3 months ago0030621: Implementation of building U-periodical surfaces.
ifv [Fri, 29 Mar 2019 12:20:27 +0000]
0030621: Implementation of building U-periodical surfaces.

draw_test_harness.md - description of new options in Draw commands

AppDef_BSplineCompute.hxx, BRepApprox_TheComputeLineOfApprox.hxx, GeomInt_TheComputeLineOfWLApprox.hxx, Approx_BSplComputeLine.gxx - implementation of method SetPeriodic(...) and implementation periodic boundary conditions for multiline in order to get periodic multicurve.

GeomAPI_PointsToBSplineSurface.hxx, GeomAPI_PointsToBSplineSurface.cxx - adding new parameter for methods Init(...) and Interpolate(...), implementation of building periodic tangents for first and last AppDef_MultiPointConstraint of multiline for U direction of surface.

GeometryTest_APICommands.cxx - implementation of new functionality in Draw command surfapp and surfint

GeomFill_NSections.cxx
Fixing problem with bugs modalg_3 bug606_2

3 months ago0030592: Draw Harness, ViewerTest - provide vbackground command unifying vsetbg,...
tiv [Mon, 22 Apr 2019 07:51:22 +0000]
0030592: Draw Harness, ViewerTest - provide vbackground command unifying vsetbg, vsetbgmode, vsetgradientbg, vsetgrbgmode, vsetcolorbg

A new command vbackground is created. Old background commands are made aliases for the newly created command (including vsetdefaultbg).
Tests are modified using newly added command vbackground.

3 months ago0030663: Visualization - synthesize italic style for a font having no italic style
vro [Fri, 19 Apr 2019 06:17:57 +0000]
0030663: Visualization - synthesize italic style for a font having no italic style

Font_FTFont now defines shear transformation to synthesize italic style for fonts having no such style.
Font_FontMgr::FindFont() and command "vfont -find" have been extended with -strict option
to check whether the given font is actually registered or not.
Font_FTFont::Init() - added constructor from memory buffer.
Second Font_FTFont::Init() override has been renamed to Font_FTFont::FindAndInit()
to avoid ambiguity between two similar methods taking full font path and font name as string.

3 months ago0030435: Improving performance of Approx_ComputeCLine
ifv [Thu, 10 Jan 2019 10:07:01 +0000]
0030435: Improving performance of Approx_ComputeCLine

1. Approx_ComputeCLine.gxx, Approx_FitAndDivide.hxx, Approx_FitAndDivide2d.hxx, BRepFill_ComputeCLine.hxx
It is base modification, which allows improve performance of approximation with help of Approx_ComputeCLine. The main idea of improvement is using degree selection by inverse order - from maxdegree to mindegree. If tolerance for maxdegree is not reached, there is no sense to make approximation for current number of knots with lower degree, it is necessary to cut parametric interval.

2. ProjLib_ComputeApprox, ProjLib_ComputeApproxOnPolarSurface, ProjLib_ComputeApproxOnPolarSurface, ProjLib_ProjectOnPlane
It is additional modification of methods using Approx_ComputeCLine.
Mainly, modifications concern to more optimal choosing parameters for approximation algorithm.

3. BRepCheck_Face
Small improvement of method Intersect(...), which intersects two wires on face.

4. BRepTopAdaptor_FClass2d
Impovement of treatment infinitely narrow faces.

5. ChFi3d/ChFi3d_Builder_6.cxx
Small improvement, which forbids extension of singular boundary of surface.
It was TODO problem in tests/bugs/modalg_7/bug27711_3

6. IntTools_EdgeEdge.cxx
Improvement of performance for cases of searching common parts between line  and analytical curve

7. GeomliteTest_CurveCommands.cxx
Adding Draw command fitcurve. This command is analog of approxcurve, but uses Approx_FitAndDivide algorithm.
Mainly to have direct draw command for testing Approx_ComputeCLine.

8. Extrema_ExtElC.cxx

Treatment of case "infinite solutions" for extrema line-ellipse

9. Modification of some tests according to new behavior of algorithm.

10. tests/perf/moddata/bug30435
Test for new improved algorithm.

11. Implementation QAcommand OCC30435 in QABugs_20.cxx used in test bug30435

3 months ago0030657: Visualization - misprint in Graphic3d_ZLayerSettings::SetOrigin() IR-2019-04-19
kgv [Wed, 17 Apr 2019 19:23:51 +0000]
0030657: Visualization - misprint in Graphic3d_ZLayerSettings::SetOrigin()

Add missing initialization of Geom_Transformation object.

3 months ago0030644: Coding - inline trivial methods of V3d_View class
kgv [Wed, 17 Apr 2019 11:58:35 +0000]
0030644: Coding - inline trivial methods of V3d_View class

3 months ago0030550: Coding - Integer overflow in Standard_CString HashCodes IR-WEEK16-1
tiv [Thu, 28 Mar 2019 09:42:41 +0000]
0030550: Coding - Integer overflow in Standard_CString HashCodes
0030551: Foundation Classes - Integer overflow in NCollection_CellFilter HashCode

Signed integers are not used in hash code functions now to prevent undefined behavior on left shift operations with signed integers.
A possibility of negative values of hash codes is eliminated.
INT_MAX → IntegerLast() in hash code functions.
All found hash code functions behaves uniformly now: they return a value in the range [1, theUpperBound]. Relevant comments are added to such functions.

3 months ago0030647: Geom2dGcc_Circ2d2TanRad not giving all the solutions
ifv [Mon, 15 Apr 2019 09:47:08 +0000]
0030647: Geom2dGcc_Circ2d2TanRad not giving all the solutions

Method for calculation of correct number of sampling points is added for
Adaptor2d_OffsetCurve.
Now number of sampling points correspond with similar method for
Geom2dAdaptor_Curve for curve type GeomAbs_OffsetCurve
Test case added

3 months ago0030623: Draw Harness - support hex color codes within ViewerTest::ParseColor() IR-2019-04-13
tiv [Fri, 12 Apr 2019 07:45:25 +0000]
0030623: Draw Harness - support hex color codes within ViewerTest::ParseColor()

ViewerTest::ParseColor() function is improved to be able to parse the following set of input arguments:
  - "Red Green Blue [Alpha]", where Red, Green, Blue, Alpha must be integers within the range [0, 255] or reals within the range [0.0, 1.0]. Note that "0 0 1" triple is parsed as "0.0 0.0 1.0" and will be interpreted as a blue color.
  - "ColorName [Alpha]", where ColorName is one of WHITE, BLACK, RED, GREEN, BLUE, etc. (look at Quantity_NameOfColor enumeration for all possible variants). Alpha may be integer or real, as described at the previous list item.
  - #HHH, [#]HHH[H], [#]HHHHHH[HH], where H is a hexadecimal digit (0 .. 9, a .. f, or A .. F). There are a short hexadecimal RGB, RGBA formats, and a usual RGB[A], respectively.

3 months ago0030597: BRepOffsetAPI_MakePipeShell raises Standard_RangeError
jgv [Tue, 2 Apr 2019 11:14:00 +0000]
0030597: BRepOffsetAPI_MakePipeShell raises Standard_RangeError

Constructor of GeomFill_SectionPlacement has been corrected: add correction of boundaries of curve to avoid mistake of LocateU in the case when the curve is BSpline.

3 months ago0030643: Visualization, Ray-Tracing - shader compilation errors are not properly...
kgv [Tue, 9 Apr 2019 13:25:29 +0000]
0030643: Visualization, Ray-Tracing - shader compilation errors are not properly logged

OpenGl_View::initShader() now uses OpenGl_ShaderObject::LoadAndCompile().

3 months ago0030612: Visualization - provide texture map with video as image source
kgv [Wed, 27 Mar 2019 21:57:17 +0000]
0030612: Visualization - provide texture map with video as image source

Introduced package Media wrapping FFmpeg structures.
Media_PlayerContext class manages video decoding into Media_IFrameQueue interface.
Graphic3d_MediaTextureSet implements Media_IFrameQueue interface and can be used as texture source.
AIS_MediaPlayer implements simple AIS object displaying video.

3 months ago0030638: Visualization, TKOpenGl - load OpenGL 4.5 functions within OpenGl_Context
kgv [Mon, 8 Apr 2019 15:03:34 +0000]
0030638: Visualization, TKOpenGl - load OpenGL 4.5 functions within OpenGl_Context

3 months ago0030635: Visualization - move OpenGl_Layer to Graphic3d_Layer
kgv [Mon, 8 Apr 2019 13:22:20 +0000]
0030635: Visualization - move OpenGl_Layer to Graphic3d_Layer

Renamed classes (moved from TKOpenGl to TKV3d):
- OpenGl_Layer -> Graphic3d_Layer;
- OpenGl_BVHClipPrimitiveSet -> Graphic3d_BvhCStructureSet;
- OpenGl_BVHClipPrimitiveTrsfPersSet -> Graphic3d_BvhCStructureSetTrsfPers;
- OpenGl_BVHTreeSelector -> Graphic3d_CullingTool.

Method OpenGl_Layer::Render() has been moved to OpenGl_LayerList::renderLayer().

Standard Z-layers list definition has been moved
from OpenGl_GraphicDriver to base class Graphic3d_GraphicDriver.

3 months ago0030636: Configuration, qmake - unable to build using VS2017
kgv [Mon, 8 Apr 2019 13:55:12 +0000]
0030636: Configuration, qmake - unable to build using VS2017

3 months ago0030629: Modeling Algorithms - Invalid result of fuse operation
emv [Thu, 4 Apr 2019 06:59:24 +0000]
0030629: Modeling Algorithms - Invalid result of fuse operation

Plane/Torus intersection: take into account the Plane-Torus distance sign to compute the correct location of the section curve.

Test case for the issue.

3 months ago0030618: Modeling Algorithms, BOPTools_Parallel - avoid using map for thread-local...
kgv [Thu, 28 Mar 2019 21:14:36 +0000]
0030618: Modeling Algorithms, BOPTools_Parallel - avoid using map for thread-local contexts without TBB

OSD_Parallel::ToUseOcctThreads() - new flag allowing to use OCCT threads implementation even when compiled with TBB (for testing).
Added new command dparallel for managing default Thread Pool.
OSD_Parallel::For() now avoid creation of universal iterator in simplest case.

BOPTools_Parallel - eliminated redundant typedefs/explicit instantiations of templates.
Added functor using array of per-thread context instead of a map.

3 months ago0030339: Configuration - add project files for qmake IR-2019-04-05
kgv [Mon, 1 Apr 2019 20:44:20 +0000]
0030339: Configuration - add project files for qmake

Added adm/qmake/Occt.pro for building OCCT using Qt Creator.
genproj/genconf scripts have been extended with an option defining project format.

Draw_Appli now tries resolving CASROOT/DRAWDEFAULT/CSF_OCCTResourcePath/CSF_OCCTSamplesPath
locations within usual OCCT development/installation environment.
Added missing TKShHealing dependency to TKDraw/DRAWEXE (inherited from TKMesh).
OSD_Process::ExecutableFolder() - added method returning executable folder.

3 months ago0030626: Visualization - manipulator crashes when is attached with scaling mode disabled IR-WEEK14
iko [Tue, 2 Apr 2019 10:58:32 +0000]
0030626: Visualization - manipulator crashes when is attached with scaling mode disabled

AIS_Manipulator crashes on SetPart method when 2 inputs (AIS_ManipulatorMode, Standard_Boolean) has been fixed up.
Test case for this bug has been added.

3 months ago0030616: Crash on reading STEP file
gka [Thu, 28 Mar 2019 15:25:20 +0000]
0030616: Crash on reading STEP file

Added protections to avoid exceptions for null objects.
For reading entity StepShape_ToleranceValue was added reading lower and upper bounds represented by entities "StepRepr_ReprItemAndMeasureWithUnit" or "StepRepr_MeasureRepresentationItem"

3 months ago0030622: Visualization, TKOpenGl - Path Tracing fails on macOS
kgv [Fri, 29 Mar 2019 17:46:39 +0000]
0030622: Visualization, TKOpenGl - Path Tracing fails on macOS

Fixed usage of non-existing function texture2D().

3 months ago0030619: Draw Harness, ViewerTest - add continuous rendering option to vrepaint command
kgv [Thu, 28 Mar 2019 15:36:54 +0000]
0030619: Draw Harness, ViewerTest - add continuous rendering option to vrepaint command

Aspect_Window::InvalidateContent() - added new virtual method for invalidating window content using platform-specific API.

TKDraw, tkLoop() on Window platform has been changed so that to prevent
continuous input window events blocking terminal input
(e.g. in case if processing events is not fast enough or
if another continuously sends new events).

TKViewerTest, on X11 platform has been fixed a message processing
so that to avoid messages being not processed.
Added aggregation of Exposer and ConfigureNotify events.
Fixed aggregation MotionNotify events.

3 months ago0030611: Coding Rules - eliminate GCC compiler warnings -Wcatch-value
kgv [Sun, 31 Mar 2019 20:38:14 +0000]
0030611: Coding Rules - eliminate GCC compiler warnings -Wcatch-value

Add missing const& to catch statements.

3 months ago0030579: Draw Harness, Draw_Interpretor - catch exceptions other than Standard_Failure IR-2019-03-29 IR-WEEK13
kgv [Fri, 15 Mar 2019 10:15:18 +0000]
0030579: Draw Harness, Draw_Interpretor - catch exceptions other than Standard_Failure

3 months ago0030574: Configuration, genproj - CSF_DEFINES is not reset at the beginning of env.bat
kgv [Thu, 14 Mar 2019 19:17:19 +0000]
0030574: Configuration, genproj - CSF_DEFINES is not reset at the beginning of env.bat

env.bat now resets %CSF_DEFINES% variable to empty state
and append optional %CSF_DEFINES_EXTRA% external value.

3 months ago0030556: Coding - IGESData_GlobalSection missing member initialization in default...
kgv [Tue, 12 Mar 2019 01:51:41 +0000]
0030556: Coding - IGESData_GlobalSection missing member initialization in default constructor

IGESData_GlobalSection now initializes class fields.

3 months ago0030505: Volume Rendering - Deferred lighting
iko [Wed, 20 Mar 2019 09:30:48 +0000]
0030505: Volume Rendering - Deferred lighting

Missing getter for OpenGl_Texture::mySizedFormat has been added.

4 months ago0030522: Modeling Algorithms - BRepBuilderAPI_MakeWire produces different wires depen... IR-2019-03-22
emv [Tue, 26 Feb 2019 11:06:30 +0000]
0030522: Modeling Algorithms - BRepBuilderAPI_MakeWire produces different wires depending on the order of parameters

The following improvements have been implemented in BRepLib_MakeWire class to make it more reliable:
1. Quit adding edges of a wire into result if the current edges have not been added. Return NotDone status.
2. Allow merging not only bounding vertices (connected to only one edge) but also the middle ones, so the multi-connected vertices may appear in the result.

Test case for the issue.

4 months ago0030582: Coding - avoid defining references to properties of NULL objects
kgv [Fri, 15 Mar 2019 15:06:04 +0000]
0030582: Coding - avoid defining references to properties of NULL objects

Approx_SweepApproximation::Perform() now creates empty arrays.
GeomAdaptor_SurfaceOfRevolution::UTrim() - fixed No_Exception misuse.
StdPrs_ShadedShape - fixed defining an invalid reference to Poly_Triangulation::UVNodes().

BSplCLib::MovePoint() and BSplCLib::MovePointAndTangent() now take optional
weights parameter as pointer consistent to other methods like BSplCLib::BuildEval().

4 months ago0030489: Modeling Algorithms - BRepBuilderAPI_GTransform hangs
ifv [Tue, 12 Mar 2019 13:47:21 +0000]
0030489: Modeling Algorithms - BRepBuilderAPI_GTransform hangs

Approx_ComputeCLine.gxx - criterium to stop interval cutting is increased.
ProjLib_ProjectedCurve.cxx - fix regression for bugs modalg_5 bug25886
Other tests are modified according to current state of algorithm

4 months ago0030593: Modeling Algorithms - ShapeUpgrade_ShapeDivide::Perform() throws Standard_No...
kgv [Tue, 19 Mar 2019 08:24:21 +0000]
0030593: Modeling Algorithms - ShapeUpgrade_ShapeDivide::Perform() throws Standard_NoMoreObject

Added missing TopExp_Explorer::More() checks to ShapeUpgrade_ShapeDivide::Perform() and BRepCheck_Analyzer::Perform().

4 months ago0027316: Draw Harness - access violation on passing non-existing shape to XAddShape
kgv [Wed, 20 Mar 2019 05:53:41 +0000]
0027316: Draw Harness - access violation on passing non-existing shape to XAddShape

Add NULL check to XAddShape command.
Removed broken test case bugs/step/bug27316.

4 months ago0030583: Draw Harness - ignore cpulimit when Debugger is attached on Windows platform
kgv [Sat, 16 Mar 2019 08:25:47 +0000]
0030583: Draw Harness - ignore cpulimit when Debugger is attached on Windows platform

cpulimit now omits ExitProcess() when IsDebuggerPresent() returns TRUE.

4 months ago0030594: Data Exchange - access violation within IGESGeom_BSplineCurve constructor
kgv [Wed, 20 Mar 2019 06:50:52 +0000]
0030594: Data Exchange - access violation within IGESGeom_BSplineCurve constructor

Added NULL check.

4 months ago0023838: Modeling Data - Standard_OutOfRange in Geom_OffsetSurface::LocalDN (called...
kgv [Sat, 16 Mar 2019 13:08:27 +0000]
0023838: Modeling Data - Standard_OutOfRange in Geom_OffsetSurface::LocalDN (called by BRepFill_PipeShell)

Fixed incorrect array allocation within GeomEvaluator_OffsetSurface::CalculateDN()
and protection against assigning out-of-range values in case of non-square
number of U and V derivatives on surface.

4 months ago0030588: Coding - avoid calling operator->() on NULL Handle
kgv [Sat, 16 Mar 2019 15:55:36 +0000]
0030588: Coding - avoid calling operator->() on NULL Handle

Use .get() method instead of operator->() where result can be NULL.
STEPCAFControl_Reader::ReadLayers(), XCAFDoc_ColorTool,
XCAFDoc_LayerTool::SetVisibility() - fixed static functions syntax.

4 months ago0030558: Coding - replace math_SingleTab with NCollection_LocalArray
kgv [Tue, 12 Mar 2019 03:05:21 +0000]
0030558: Coding - replace math_SingleTab with NCollection_LocalArray

math_Vector::Multiplied() - fixed modification of original array.

math_SVD::Solve(), math_SVD::PseudoInverse(), GeomFill_LocationGuide::InitX() - removed incorrect constness.

math_Vector, math_IntegerVector - math_SingleTab has been replaced by NCollection_LocalArray+NCollection_Array1.
Added accessors returning const value.

4 months ago0030536: Foundation Classes - TCollection_ExtendedString::StartsWith() and EndsWith...
vro [Mon, 18 Mar 2019 07:16:40 +0000]
0030536: Foundation Classes - TCollection_ExtendedString::StartsWith() and EndsWith() have a mistake

Draw-commands StartsWith and EndsWith are renamed to QAStartsWith and QAEndsWith.
The test script bug30536 was corrected.

4 months ago0030544: Data Exchange - IGES import fails on specific file
abv [Mon, 11 Mar 2019 18:28:52 +0000]
0030544: Data Exchange - IGES import fails on specific file

Method IGESToBRep_BRepEntity::TransferEdge() is fixed to record result even if it is wire rather than edge.
This allows translation of EdgeLoop entities referring to CompositeCurve items in EdgeList entities.
Curves that fail to translate are recorded in result as Null shapes (rather than skipping them) to keep indexation of curves in EdgeList valid for remaining ones.

Method IGESToBRep_BRepEntity::TransferLoop() is improved to skip failed edges thus avoiding exception and allowing translation to complete for transferable entities.

Warning messages are corrected to be more meaningful.
Added test bugs iges bug30544

4 months ago0030569: Foundation Classes - NCollection_Shared lacks inclusion of NCollection_Defin...
kgv [Wed, 13 Mar 2019 13:53:16 +0000]
0030569: Foundation Classes - NCollection_Shared lacks inclusion of NCollection_DefineAlloc.hxx

Add missing includes.

4 months ago0030584: Modeling Algorithms, BRepFill_OffsetWire - access violation on Face having...
kgv [Sat, 16 Mar 2019 10:22:47 +0000]
0030584: Modeling Algorithms, BRepFill_OffsetWire - access violation on Face having no boundaries

Added missing NULL and empty result checks.
Updated test cases using offset_wire_092.brep shape containing all Edges
with TopAbs_INTERNAL orientation (hense no boundary to make offset).

4 months ago0030581: Modeling Data - Standard_OutOfRange within Geom_BSplineSurface::LocateV()
kgv [Sat, 16 Mar 2019 06:33:37 +0000]
0030581: Modeling Data - Standard_OutOfRange within Geom_BSplineSurface::LocateV()

Geom2d_BSplineCurve::LocateU(),Geom_BSplineCurve::LocateU, Law_BSpline::LocateU()
Geom_BSplineSurface::LocateU() and Geom_BSplineSurface::LocateV()
have been corrected with missing range checks.
BSplCLib::Hunt() documentation has been corrected to reflect its actual implementation.

4 months ago0030571: Visualization, TKOpenGl - mapped texture is ignored while drawing points IR-2019-03-15
kgv [Sat, 16 Mar 2019 13:47:33 +0000]
0030571: Visualization, TKOpenGl - mapped texture is ignored while drawing points

OpenGl_AspectsTextureSet now appends Sprite texture to the end of texture set.
OpenGl_Context::init() - fixed usage of GL_MAX_COMBINED_TEXTURE_IMAGE_UNITS on too old GL context.

Default sampler names occSampler0, occActiveSampler and occSamplerBaseColor
are now excluded from header with common declarations for build-in GLSL programs.

OpenGl_ShaderObject::LoadAndCompile() and OpenGl_ShaderProgram::Link()
now includes program Id within error log.

OpenGl_ShaderManager now supports mapping texture onto point primitive within built-in programs
(texture transformation is ignored).

4 months ago0030511: Mesh - too long meshing of assembly containing single solid (shared)
oan [Mon, 4 Mar 2019 06:41:34 +0000]
0030511: Mesh - too long meshing of assembly containing single solid (shared)

Added test case.

4 months ago0030573: OSD_Parallel_TBB: limit number of execution threads using settings of OSD_Th...
oan [Thu, 14 Mar 2019 16:22:04 +0000]
0030573: OSD_Parallel_TBB: limit number of execution threads using settings of OSD_ThreadPool::DefaultPool()

Add tbb::task_scheduler_init to OSD_Parallel::forEach().

4 months ago0030575: Tests - v3d/materials unstable image screenshots of alpha-blending on GeForc...
kgv [Thu, 14 Mar 2019 21:12:12 +0000]
0030575: Tests - v3d/materials unstable image screenshots of alpha-blending on GeForce with MSAA

testdiff now looks for "IMAGE_COLOR_TOLERANCE: Tol" statements in log
to execute diffimage with -toleranceOfColor Tol parameter.

Image difference is first performed with 0 tolerance and then optionally with non-zero tolerance,
so that the log always includes information that some images are different,
but with two different messages:
- "IMAGE differs" for images failed comparison;
- "IMAGE is similar" for images passed comparison only with non-zero tolerance.

v3d/materials - disabled MSAA and removed duplicate.
demo/samples/materials - compare screenshots with 0.8% color tolerance (2/255).

4 months ago0030580: Configuration, CMake - introduce BUILD_RELEASE_DISABLE_EXCEPTIONS option...
kgv [Fri, 15 Mar 2019 11:24:15 +0000]
0030580: Configuration, CMake - introduce BUILD_RELEASE_DISABLE_EXCEPTIONS option managing No_Exception macros

4 months ago0030560: Modeling Algorithms - Improvement of the method BRepTools::DetectClosedness
jgv [Thu, 14 Mar 2019 09:38:09 +0000]
0030560: Modeling Algorithms - Improvement of the method BRepTools::DetectClosedness

1. Rewrite the method BRepTools::DetectClosedness.
2. Correct the method BRepOffset_Tool::EnLargeFace to process properly non-periodic but closed faces.

4 months ago0030570: Visualization, TKOpenGl - OpenGl_AspectFace ignores texture revision on...
kgv [Wed, 13 Mar 2019 18:46:24 +0000]
0030570: Visualization, TKOpenGl - OpenGl_AspectFace ignores texture revision on recompute

Added revision check to one more branch within OpenGl_AspectsTextureSet::build().

4 months ago0030564: Coding - math_Gauss uninitialized 'Singular' member variable
kgv [Wed, 13 Mar 2019 04:49:59 +0000]
0030564: Coding - math_Gauss uninitialized 'Singular' member variable

Removed unused class field Singular.

4 months ago0030562: Coding - TopOpeBRepBuild_Builder use of null pointer
kgv [Tue, 12 Mar 2019 17:22:26 +0000]
0030562: Coding - TopOpeBRepBuild_Builder use of null pointer

TopOpeBRepBuild_Builder::Clear() - added NULL check.

4 months ago0030124: Visualization, AIS_InteractiveObject - clean up confusing Presentation inval...
mnv [Thu, 7 Mar 2019 17:45:58 +0000]
0030124: Visualization, AIS_InteractiveObject - clean up confusing Presentation invalidation logic

Removed excess mechanism for invalidating presentations AIS_InteractiveObject::myRecomputeEveryPrs.
PrsMgr_PresentableObject::Update() has been deprecated and replaced by PrsMgr_PresentableObject::UpdatePresentations()
recomputing only explicitly invalidated presentations.

4 months ago0030554: Coding - ChFiDS_CommonPoint uninitialized member traarc
kgv [Mon, 11 Mar 2019 20:35:14 +0000]
0030554: Coding - ChFiDS_CommonPoint uninitialized member traarc

Added missing initialization to ChFiDS_CommonPoint constructor.

4 months ago0030553: Coding - TopOpeBRepDS_Surface missing default initalizations
kgv [Mon, 11 Mar 2019 20:20:44 +0000]
0030553: Coding - TopOpeBRepDS_Surface missing default initalizations

All class fields are now initialized within every TopOpeBRepDS_Surface constructor.

4 months ago0030545: Documentation - methods marked with Standard_DEPRECATED has ill-formed Doxyg...
kgv [Fri, 8 Mar 2019 12:52:08 +0000]
0030545: Documentation - methods marked with Standard_DEPRECATED has ill-formed Doxygen output

Doxygen option PREDEFINED has been extended by Standard_DEPRECATED declaration.