3 years ago0029764: Foundation Classes, TColStd_MapIteratorOfPackedMapOfInteger - workaround...
kgv [Mon, 14 May 2018 12:33:55 +0000 (15:33 +0300)]
0029764: Foundation Classes, TColStd_MapIteratorOfPackedMapOfInteger - workaround Visual Studio Linker bug with enabled CLI

3 years ago0029768: Visualization, TKOpenGl - structure is entirely clipped by suppressed clipping
kgv [Mon, 14 May 2018 16:25:16 +0000 (19:25 +0300)]
0029768: Visualization, TKOpenGl - structure is entirely clipped by suppressed clipping

OpenGl_Structure::Render(), added missing check for disabled state of the plane.
vclipplane command has been extended with new option -setOverrideGlobal.

3 years ago0029746: Modeling Algoriothms - declare Boolean operation classes in BRepAlgo package...
msv [Thu, 10 May 2018 08:50:03 +0000 (11:50 +0300)]
0029746: Modeling Algoriothms - declare Boolean operation classes in BRepAlgo package as deprecated

The API classes in the package BRepAlgo providing access to old Boolean operations (Fuse, Common, Cut, Section) are marked as deprecated.
Corresponding classes from the package BRepAlgoAPI should be used instead.

3 years ago0026493: BRepProj_Projection failed to project a wire on a shell
emv [Wed, 25 Apr 2018 06:33:50 +0000 (09:33 +0300)]
0026493: BRepProj_Projection failed to project a wire on a shell

Problem is fixed by the fix for the issue #0028599 (porting of the BRepProj_Projection to modern Boolean Operations algorithm)
Thus, only test case is integrated here.

3 years ago0029724: Visualization - add AIS_InteractiveContext::ClearDetected() undoing MoveTo...
kgv [Wed, 25 Apr 2018 08:38:11 +0000 (11:38 +0300)]
0029724: Visualization - add AIS_InteractiveContext::ClearDetected() undoing MoveTo() dynamic highlighting

Introduced new method AIS_InteractiveContext::ClearDetected() allowing
to reset the list of detected objects and clear dynamically highlighted
entity under mouse cursor after previous AIS_InteractiveContext::MoveTo().

vmoveto command has been extended with new argument -reset.

3 years ago0029744: Visualization - SelectMgr_ViewerSelector::PickedPoint() returns wrong 3D...
kgv [Tue, 8 May 2018 12:32:16 +0000 (15:32 +0300)]
0029744: Visualization - SelectMgr_ViewerSelector::PickedPoint() returns wrong 3D point for objects with transformation persistence

SelectMgr_RectangularFrustum::DetectedPoint() now takes into account myScale.

3 years ago0029779: Visualization, SelectMgr_SelectableObject - sensitivity change for object...
nds [Wed, 16 May 2018 14:06:10 +0000 (17:06 +0300)]
0029779: Visualization, SelectMgr_SelectableObject - sensitivity change for object not activated in given mode leads to crash

3 years ago0029743: Samples - Inspector tool - crash by selecting TNaming_UsedShapes tree item
nds [Tue, 8 May 2018 14:55:09 +0000 (17:55 +0300)]
0029743: Samples - Inspector tool - crash by selecting TNaming_UsedShapes tree item

- TNaming_UsedShapes is corrected to do not call methods of empty TopoDS_Shape
- TNaming_NamedShape is corrected to have not NULL TNaming_RefShape even if TopoDS_Shape is NULL(TNaming_Builder::Delete).
- DFBrowserPane presentation tree item for this is corrected in the same way and obsolete methods of processing SortedReferences are removed.

3 years ago0029749: Samples - Inspector tool - remove "modified" column in TNaming_NamedShape...
nds [Thu, 10 May 2018 03:53:15 +0000 (06:53 +0300)]
0029749: Samples - Inspector tool - remove "modified" column in TNaming_NamedShape presentation

3 years ago0029748: Samples - Inspector tool - use recently opened files in TInspectorEXE
nds [Tue, 8 May 2018 17:21:08 +0000 (20:21 +0300)]
0029748: Samples - Inspector tool - use recently opened files in TInspectorEXE

- recently files using in open file dialog
- correction of TInspectorEXE title to show opened file path by Start

3 years ago0029781: Samples - Inspector tool - history tree model is not set into external callb...
nds [Thu, 17 May 2018 06:29:04 +0000 (09:29 +0300)]
0029781: Samples - Inspector tool - history tree model is not set into external callback in VInspector

- AIS_InteractiveContex and VInspector_ViewModelHistory are set into VInspector_CallBack
- minor correction of displaySelectedPresentations () to Hide/Show(by popup menu) any AIS_InteractiveObject, not only AIS_Shape (e.g. AIS_Trihedron)

3 years ago0029747: Samples - Inspector tool - start DFBrowser inside FuncDemo qt sample
nds [Tue, 8 May 2018 16:56:11 +0000 (19:56 +0300)]
0029747: Samples - Inspector tool - start DFBrowser inside FuncDemo qt sample

new Model->DFBrowser action to start Inspector tool with active DFBrowser plugin filled by the sample OCAF application.
To update content of the DFBrowser, use <F5> shortcut.

3 years ago0029735: Draw Harness - command to set 2D mode for viewer in ViewerTest package
nds [Tue, 8 May 2018 16:17:09 +0000 (19:17 +0300)]
0029735: Draw Harness - command to set 2D mode for viewer in ViewerTest package

vinit command has been extended with new option -2d_mode.
Added new command v2dmode to switch On/Off the mode.

3 years ago0029741: Samples - Inspector tool - wide icon size in table of TNamingNamedShape...
nds [Mon, 7 May 2018 12:40:18 +0000 (15:40 +0300)]
0029741: Samples - Inspector tool - wide icon size in table of TNamingNamedShape attribute in DFBrowser plugin

3 years ago0029733: TInspector can't open several cbf files
nds [Tue, 8 May 2018 12:33:20 +0000 (15:33 +0300)]
0029733: TInspector can't open several cbf files

The issue is not reproduced anymore. The integration contains DRAW test for described functionality.

3 years ago0029739: Draw Harness - vdonly does not hide displayed objects
nds [Mon, 7 May 2018 11:20:38 +0000 (14:20 +0300)]
0029739: Draw Harness - vdonly does not hide displayed objects

3 years ago0029737: Data Exchange - Revert optimization in XCAF for format compability
ika [Mon, 7 May 2018 08:51:58 +0000 (11:51 +0300)]
0029737: Data Exchange - Revert optimization in XCAF for format compability

Revert changes from 0029338, which were affected on order of GDT attribute sublabels.

3 years ago0029701: BRepTools::Update(Face) unexpectedly updates UV points of pcurve
emv [Thu, 19 Apr 2018 13:31:19 +0000 (16:31 +0300)]
0029701: BRepTools::Update(Face) unexpectedly updates UV points of pcurve

The method *BRepTools::UpdateFaceUVPoints* has been modified to resets the UV points of the edge to the bounding points of the parametric curve of the edge on the face.

Test cases for the issue.

Adjust test cases heal split_angle_advanced ZC3, ZE6, ZE9 for current behavior as they show less faulty shapes now.
Adjust test case bugs modalg_6 bug21246 as it works correctly now.

3 years ago0029730: OCAF User's Guide correction for case of attributes with User defined GUID
szy [Fri, 27 Apr 2018 12:02:32 +0000 (15:02 +0300)]
0029730: OCAF User's Guide correction for case of attributes with User defined GUID

Added description of attributes usage with User defined GUID

3 years ago0029655: [Regression to 6.9.1] Distance between cylinder and straight line
ifv [Mon, 2 Apr 2018 14:05:51 +0000 (17:05 +0300)]
0029655: [Regression to 6.9.1] Distance between cylinder and straight line

Trimming line by corner points of surface bounding box is added to reduce rang of line
Test case added

3 years ago0029698: Regression vs 7.2.0: Common operation raises FLT_INVALID_OPERATION exception
emv [Mon, 16 Apr 2018 12:21:35 +0000 (15:21 +0300)]
0029698: Regression vs 7.2.0: Common operation raises FLT_INVALID_OPERATION exception

When checking if the split edge is oriented as the original one (BOPTools_AlgoTools::IsSplitToReverse()) the tangent vectors should be computed for both edges at the same point. This point is taken on the split edge and projected on the original edge.
The fix is intended to ensuring that the reference point will be taken inside the valid range of the split edge (i.e. not covered by the tolerance spheres of its bounding vertices) and the projection of this point on the original edge will be successful. Moreover, several sampling points are now taken on the split edge and processed until first valid point is found.

If requested (by a not null pointer) all *BOPTools_AlgoTools::IsSplitToReverse()* methods are now return the error status of the check. Before using the returned flag, the calling program should check this error status. For successful check the error status should be equal to zero.

New warning *BOPAlgo_AlertUnableToOrientTheShape* is now returned in the algorithms in Boolean component in case the check for correct shape orientation failed.

Test case for the issue.

3 years ago0029695: Shape Healing - infinite loop in ShapeFix_IntersectionTool
gka [Mon, 16 Apr 2018 08:58:43 +0000 (11:58 +0300)]
0029695: Shape Healing - infinite loop in ShapeFix_IntersectionTool

Avoid splitting of wrong edge in ShapeFix_IntersectionTool.
Added protection for case when index of edge to be split is out of range.

Added test bugs heal bug29695

3 years agoIncrement of OCCT version up to 7.3.0beta V7_3_0_beta
bugmaster [Fri, 13 Apr 2018 09:37:14 +0000 (12:37 +0300)]
Increment of OCCT version up to 7.3.0beta

3 years ago0029682: Boolean intersection with fuzzy-option hangs
nbv [Mon, 9 Apr 2018 13:05:30 +0000 (16:05 +0300)]
0029682: Boolean intersection with fuzzy-option hangs

Algorithm of step re-computation has been improved.

3 years ago0029604: Uniform mechanism providing History of shape's modifications for OCCT algori...
emv [Wed, 21 Mar 2018 13:59:29 +0000 (16:59 +0300)]
0029604: Uniform mechanism providing History of shape's modifications for OCCT algorithms in DRAW

Implementation of the mechanism for unification of the history commands for all OCCT algorithms.
The following Draw commands should be used to track the history of shapes modifications of any operation:
- modified - to find the shapes modified from the given shape in the given history.
- generated - to find the shapes generated from the given shape in the given history.
- isdeleted - to check if the given shape has been deleted during operation.

The mechanism allows fast & easy enabling of the DRAW history support for the algorithms supporting the history on the API level (i.e. the algorithm should have the methods Modified(), Generated() and IsDeleted()).
To enable the draw history support it is necessary to store the history of the algorithm into the session. For instance:

TopTools_ListOfShape Objects = ...; // Objects
TopTools_ListOfShape Tools = ...; // Tools

BRepAlgoAPI_Cut aCut(Objects, Tools); // Boolean cut operation

BRepTest_Objects::SetHistory(Objects, aCut); // Store the history for the Objects (overwrites the history in the session)
BRepTest_Objects::AddHistory(Tools, aCut);   // Add the history for the Tools

To get the stored history in draw the command "savehistory" should be used. It saves the history kept in session into a Drawable object with the given name:

# perform cut
bcut r s1 s2

# save history of cut
savehistory cut_history

explode s1 f
modified m cut_history s1_1

The Draw History commands of the following algorithms have been removed:
- Boolean Operations;
- Defeaturing;
- Unify same domain;
- Sweep;
- Thrusections;

All these algorithms have been switched to support the new Draw history mechanism.

The Fillet and Blend algorithms have been also enabled to support history commands.

3 years ago0029532: BOPCol containers used in the OCCT 720 do not support in the current develop...
nbv [Fri, 2 Mar 2018 09:03:09 +0000 (12:03 +0300)]
0029532: BOPCol containers used in the OCCT 720 do not support in the current development version.

The file upgrade.dat has been updated.

3 years ago0029639: CMake - rename options for building samples
nds [Thu, 12 Apr 2018 03:24:42 +0000 (06:24 +0300)]
0029639: CMake - rename options for building samples

- sub-folder "mfc" of Samples folder in VStudio for mfc samples
- qt processing of *.ts resource files is corrected to avoid excessive projects creation under Samples folder in VStudio

3 years ago0029684: Configuration: modification of build Inspector tool standalone on occt
nds [Thu, 12 Apr 2018 03:56:58 +0000 (06:56 +0300)]
0029684: Configuration: modification of build Inspector tool standalone on occt

- samples/tools/TStandalone is removed, to build Inspector out of OCCT, CMake should use tools/CMakeLists.txt fileName
- samples/tools/TInspectorEXE is moved to tools/TInspectorEXE
- TInspectorAPI_Version.hxx provides compilation inspector with earlier version of OCCT.

3 years ago0029688: Regression vs 7.2.0: Wrong result of CUT operation
emv [Wed, 11 Apr 2018 09:22:29 +0000 (12:22 +0300)]
0029688: Regression vs 7.2.0: Wrong result of CUT operation

Boolean Operations - when splitting the face by the intersections with other arguments check if the face (e.g. really thin one) can be split by a vertex. In this case avoid simple face reconstruction and use the BuilderFace algorithm to split the face.
Test case for the issue.

3 years ago0029674: Improvements in Inspector tool
nds [Fri, 23 Mar 2018 13:08:11 +0000 (16:08 +0300)]
0029674: Improvements in Inspector tool

- preferences for dock windows geometry, tree view columns and current view projection;
- ViewControl package for common functionality between plugins;
- processing Location and Orientation for external TopoDS_Shape object
- 'F5' key to update content of each plugin
- visibility column in tree view (used now only in ShapeView)
- properties child item for context (presents tree of current Filters of context)

3 years agoRevert "0029369: ShapeFix_Face algorithm does not heal properly the face lying on...
jgv [Wed, 11 Apr 2018 09:28:04 +0000 (12:28 +0300)]
Revert "0029369: ShapeFix_Face algorithm does not heal properly the face lying on a surface of revolution"

This reverts commit 7d13fd8ea30857c226a777879e1302a38f67cf6f.

3 years ago0029651: ViewerTest - vtexture command crashes IR-2018-04-10
san [Tue, 27 Mar 2018 08:54:12 +0000 (11:54 +0300)]
0029651: ViewerTest - vtexture command crashes

Missing null check added

Add test case bugs/vis/bug29651

3 years ago0029452: Application Framework - Failed to read an Ocaf XML document with 1.#QNAN...
szy [Mon, 12 Mar 2018 14:50:08 +0000 (17:50 +0300)]
0029452: Application Framework - Failed to read an Ocaf XML document with 1.#QNAN value.

Method XmlObjMgt::GetReal() is improved to (a) recognize NAN and infinity written by old MSVC runtime (like 1.#QNAN and 1.#INF) and (b) detect situation when there are some trailing non-space symbols after the real value, returning False in such case.

Reading of real-valued attributes (single real, array, list) from OCAF XML format is improved to create valid attribute even if parsing of (some) members fails; warning is generated instead of error in such case.

Added test bugs caf bug29452

3 years ago0029574: Protection of attributes retrieval against zero ID in Ocaf XML.
szy [Mon, 19 Mar 2018 15:43:04 +0000 (18:43 +0300)]
0029574: Protection of attributes retrieval against zero ID in Ocaf XML.

//Impacts attributes supporting user defined IDs.

3 years ago0029680: Tests - command checkprops does not work for negative values
abv [Sun, 8 Apr 2018 15:52:31 +0000 (18:52 +0300)]
0029680: Tests - command checkprops does not work for negative values

DRAW command checkprops is corrected to handle properly negative reference values.

Test case offset faces_face_i E5 is corrected (improvement due to #28903)

3 years ago0029591: Improvements in the class BRepOffset_Tool
jgv [Fri, 23 Mar 2018 13:08:11 +0000 (16:08 +0300)]
0029591: Improvements in the class BRepOffset_Tool

- Add the flag ExtensionMode in the method BRepOffset_Tool::EnLargeFace, defining the mode of extension of the surface of the face. Old behavior is to be remained the default one.

- Fix wrong building of extended face on a closed surface. Now, if the face is closed in U direction (like cylinder) but the seam edge is shifted from 0 position, the resulting extended face has properly connected seam edge.

- Add new public static method BRepTools::DetectClosedness(), which checks whether a face is closed in U and V directions.

3 years ago0029663: Exception in BRepFill_PipeShell algorithm
nbv [Thu, 29 Mar 2018 14:49:54 +0000 (17:49 +0300)]
0029663: Exception in BRepFill_PipeShell algorithm

BRepFill_Sweep algorithm is improved to handle cases when generated revolution surface has degenerated point in the middle.

Added test bugs modalg_7 bug29663

TODO added in test bugs modalg_1 bug1477_11: here two additional self-intersecting faces are now created, previously missing from the result.

3 years ago0029659: Samples - Image is not displayed in Viewer2d MFC sample
kgv [Sun, 8 Apr 2018 09:54:21 +0000 (12:54 +0300)]
0029659: Samples - Image is not displayed in Viewer2d MFC sample

Fixed wrong Display Mode assigned to Sample2D_Image presentation.

3 years ago0029658: Samples - light is not updated while moving mouse within Viewer3d MFC sample
kgv [Sun, 8 Apr 2018 09:43:24 +0000 (12:43 +0300)]
0029658: Samples - light is not updated while moving mouse within Viewer3d MFC sample

Adding missing Viewer redraw calls.

3 years ago0028934: Coding - Eliminate compiler warnings in OCCT samples
nds [Wed, 4 Apr 2018 03:25:02 +0000 (06:25 +0300)]
0028934: Coding - Eliminate compiler warnings in OCCT samples

- covering Qt warnings for compilation under MSVC 2013 and greater
- avoid warning about 'M_PI'(and others) redefinition warning of math.h: includes of QtWidgets should follow after other includes.

3 years ago0029643: Samples: create .bat files for building AndroidQt sample on Windows platform
apn [Mon, 26 Mar 2018 10:10:59 +0000 (13:10 +0300)]
0029643: Samples: create .bat files for building AndroidQt sample on Windows platform

Create environment (genproj.bat, msvc.bat, etc) for building AndroidQt sample on Windows platform (as well as it's done in other OCCT Qt samples)

3 years ago0029668: Configuration: build Inspector aplication independently on BUILD_MODULE_QtSa...
nds [Mon, 2 Apr 2018 11:17:44 +0000 (14:17 +0300)]
0029668: Configuration: build Inspector aplication independently on BUILD_MODULE_QtSamples state

3 years ago0029606: [Regression vs 7.0] BRepClass3d_SolidClassifier classifies the point as...
ifv [Wed, 28 Mar 2018 14:00:50 +0000 (17:00 +0300)]
0029606: [Regression vs 7.0] BRepClass3d_SolidClassifier classifies the point as IN while it is ON

Simple treatment of some analytical cases when curve is parallel or belongs surface is added in curve - face/surface intersection algorithm
Treatment such cases is added in classifier algorithm
Test case added

3 years ago0029667: Visualization, TKV3d - User-defined texture coordinates corrupted by StdPrs_...
san [Fri, 30 Mar 2018 13:38:34 +0000 (16:38 +0300)]
0029667: Visualization, TKV3d - User-defined texture coordinates corrupted by StdPrs_ShadedShape

Add protection in fillTriangles() against void UV range of a face.

3 years ago0029650: Data Exchange - possible exception in shape tool
ika [Tue, 27 Mar 2018 08:17:54 +0000 (11:17 +0300)]
0029650: Data Exchange - possible exception in shape tool

3 years ago0029633: Data Exchange - access violation in StepVisual_PresentationStyleAssignment...
ika [Fri, 23 Mar 2018 15:12:00 +0000 (18:12 +0300)]
0029633: Data Exchange - access violation in StepVisual_PresentationStyleAssignment while translating STEP file

Add several checks for null.

3 years ago0029599: Data Exchange - Incorrect expand compound method in XDE
ika [Fri, 16 Mar 2018 13:18:10 +0000 (16:18 +0300)]
0029599: Data Exchange - Incorrect expand compound method in XDE

Improve processing of subshapes in ShapeTool
Fix sharing and calculating location for subshapes
Switch off autonaming for expand

3 years ago0029525: PMI dimension names
snn [Mon, 26 Feb 2018 12:16:18 +0000 (15:16 +0300)]
0029525: PMI dimension names

Implemented semantic PMI names translation from STEP to XCAF in OCCT:
- [Get/Set]SemanticName functions added to XCAFDimTolObjects_*Object classes
- X[Get/Set]GDTSemanticName draw commands added
- test case added

3 years ago0029660: Misprint in BuildEdge(...) static function of BRepFill_Sweep.cxx file
nbv [Thu, 29 Mar 2018 07:43:30 +0000 (10:43 +0300)]
0029660: Misprint in BuildEdge(...) static function of BRepFill_Sweep.cxx file

Misprint has been eliminated.

3 years ago0029646: Boolean Operations algorithm produces a face with self-intersecting wire
emv [Mon, 26 Mar 2018 12:06:18 +0000 (15:06 +0300)]
0029646: Boolean Operations algorithm produces a face with self-intersecting wire

Boolean operations - Allow repeated intersection of edges to find the coinciding pairs.
Previously, only the edges rejected by bounding boxes classification has been additionally checked on coincidence. The current patch removes this filter allowing all edges with coinciding vertices to be checked on coincidence.

Adjustment of the test cases for current behavior:
1. The following cases are improvements:
boolean volumemaker A8
bugs modalg_1 buc60703_1
bugs modalg_1 buc60703_2
bugs modalg_1 buc60703_4
bugs modalg_6 bug26789_1
bugs modalg_6 bug26789_2
bugs modalg_7 bug26883_4
bugs modalg_7 bug27948

2. bugs modalg_7 bug29580_1 is modified to extend the validity checks.

3 years ago0029394: IESample contains strange STEP reading code
Benjamin Bihler [Tue, 19 Dec 2017 10:12:32 +0000 (11:12 +0100)]
0029394: IESample contains strange STEP reading code

All STEP roots are transferred first and then all shapes are read.
The resulting sequence is not discarded and recreated.

3 years ago0028903: BRepOffset_MakeOffset produces invalid shape (thickshell) in Intersection...
jgv [Tue, 23 Jan 2018 14:54:06 +0000 (17:54 +0300)]
0028903: BRepOffset_MakeOffset produces invalid shape (thickshell) in Intersection mode

1. Method BRepOffset_Tool::Inter3D is modified: now selection of proper edges is performed here, they are not concatenated into one edge if they go through a vertex on a boundary.

2. Method BRepOffset_Inter3d::ConnexIntByInt is modified: selection of edges is eliminated.

3. Method BRepOffset_Inter2d::ConnexIntByInt is corrected to be able to process seam edges correct.

3 years ago0029597: Data Exchange - unable to read VRML2 file
akz [Fri, 5 Aug 2016 08:24:58 +0000 (11:24 +0300)]
0029597: Data Exchange - unable to read VRML2 file

VrmlData_Scene::createNode() now handles Collision item.
VrmlData_ArrayVec3d::ReadArray() now handles a case with omitted brackets.

Added test bugs xde bug29597

3 years ago0027736: Samples - rectangle selection issues within MFC sample Viewer3d
kgv [Sun, 25 Mar 2018 08:53:09 +0000 (11:53 +0300)]
0027736: Samples - rectangle selection issues within MFC sample Viewer3d

CViewer3dView, CAnimationView3D, COCCDemoView now use AIS_RubberBand.

3 years ago0027618: Visualization - selection returns entity overlapped by another entity on...
kgv [Sun, 25 Mar 2018 17:41:41 +0000 (20:41 +0300)]
0027618: Visualization - selection returns entity overlapped by another entity on border cases

SelectMgr_ViewerSelector::updatePoint3d() - scale tolerance according to Camera defintion.
SelectMgr_RectangularFrustum::segmentSegmentDistance() now uses gp::Resolution() instead of Precision::Confusion().

3 years ago0028097: Test system does not recognize 'fail...' messages as errors
apn [Thu, 15 Mar 2018 14:13:16 +0000 (17:13 +0300)]
0028097: Test system does not recognize 'fail...' messages as errors

Test parse rules are improved to recognize messages with word 'fail' or 'failure' as errors.
Test cases are corrected accordingly (TODO or REQUIRED statements added where fail messages were not noticed previously).

3 years ago0029064: Copying of empty NCollection map takes excessive memory
isn [Mon, 15 Jan 2018 17:29:14 +0000 (20:29 +0300)]
0029064: Copying of empty NCollection map takes excessive memory

Avoid resizing of NCollection maps in Assign() methods if source map is empty

3 years ago0029611: Misprint in the formula of Hessian computation in the file GeomLib_CheckCurv...
nbv [Thu, 22 Mar 2018 06:53:48 +0000 (09:53 +0300)]
0029611: Misprint in the formula of Hessian computation in the file GeomLib_CheckCurveOnSurface.cxx

The formula of Hessian computation has been corrected

3 years ago0029526: Test Harness command "ReadIges" does not support "read.iges.onlyvisible...
gka [Tue, 27 Feb 2018 10:50:47 +0000 (13:50 +0300)]
0029526: Test Harness command "ReadIges" does not support "read.iges.onlyvisible" mode

Modification Test Harness command "ReadIges" to take into account value of the parameter "read.iges.onlyvisible" was made.

3 years ago0029631: Samples: build AndroidQt sample together with OCCT on Windows platform IR-2018-03-23
nds [Fri, 23 Mar 2018 07:36:07 +0000 (10:36 +0300)]
0029631: Samples: build AndroidQt sample together with OCCT on Windows platform

- _WIN32 definition provides functionality for sample on Windows
- CMake procedure is changed to have Qt5_FOUND variable defined before compilation modules. Searching of Qt packages is moved into qt.cmake.

3 years ago0029627: BRepOffsetAPI_NormalProjection class changes orientation of the result
emv [Fri, 23 Mar 2018 04:50:13 +0000 (07:50 +0300)]
0029627: BRepOffsetAPI_NormalProjection class changes orientation of the result

The problem is fixed by the fix for the issue #0029234.

3 years ago0029369: ShapeFix_Face algorithm does not heal properly the face lying on a surface...
jgv [Mon, 11 Dec 2017 15:28:07 +0000 (18:28 +0300)]
0029369: ShapeFix_Face algorithm does not heal properly the face lying on a surface of revolution

Add field of class <myCheckMissingEdges> to ShapeFix_Wire to be able not to take into account possibility of missing edges.

3 years ago0029602: Visualization, TKOpenGl - Size Culling is not properly handled within Perspe...
kgv [Thu, 22 Mar 2018 10:05:06 +0000 (13:05 +0300)]
0029602: Visualization, TKOpenGl - Size Culling is not properly handled within Perspective projection

OpenGl_BVHTreeSelector::isTooSmall() now takes into account distance
the distance between camera Eye and object Center
within perspective projection.

3 years ago0029595: Visualization - Wrong validation of Anchor point for Radius Dimension
vsv [Tue, 20 Mar 2018 12:26:28 +0000 (15:26 +0300)]
0029595: Visualization - Wrong validation of Anchor point for Radius Dimension

3 years ago0027732: Visualization - AIS_ConnectedInteractive crashes on NULL handle returned...
kgv [Tue, 13 Mar 2018 14:54:11 +0000 (17:54 +0300)]
0027732: Visualization - AIS_ConnectedInteractive crashes on NULL handle returned by MeshVS_CommonSensitiveEntity::GetConnected()

Added NULL-check to AIS_ConnectedInteractive::ComputeSelection().
Added missing interface methods MeshVS_Mesh::AcceptDisplayMode()
and MeshVS_CommonSensitiveEntity::GetConnected().

3 years ago0029590: Coding - avoid usage of Standard_EXPORT attribute for inline methods
abv [Mon, 19 Mar 2018 07:07:06 +0000 (10:07 +0300)]
0029590: Coding - avoid usage of Standard_EXPORT attribute for inline methods

All occurrences of Standard_EXPORT attached to inline methods in OCCT code are eliminated.
Some unused classes and C++ files producing no code are deleted.

3 years ago0029589: Configuration - allow MFC samples to be built when OCCT is linked statically
abv [Mon, 19 Mar 2018 06:04:17 +0000 (09:04 +0300)]
0029589: Configuration - allow MFC samples to be built when OCCT is linked statically

CMake scripts are corrected to do perform search of libs and dlls of third-party libraries even for static builds of OCCT.
Treatment of errors in this case is relaxed: not found DLLs are reported as warnings, and not found libs as warning for static build, and continuable error for shared build.

Code of samples is corrected to allow building with OCCT linked statically.
Implementation of main application class is corrected to ensure that initialization is done after all global objects are created.
Note however that samples still fails to start for unclear reason (creation of MFC frame window fails).

3 years ago0029571: Samples: build qt samples together with OCCT
nds [Sun, 18 Mar 2018 12:34:17 +0000 (15:34 +0300)]
0029571: Samples: build qt samples together with OCCT

Extending CMake procedure by 'BUILD_MODULE_QtSamples' variable to switch on qt samples build.
Implementation required:
- union of occt_toolkit_tool.cmake and occt_toolkit.cmake files;
- correction of qt samples sources by adding path to Qt 'plugins' folder. It helps to avoid definition of additional variable (QT_QPA_PLATFORM_PLUGIN_PATH) when staring sample.bat for qt samples;
- executable processing is extended in cmake procedure by providing 'EXECUTABLE_PROJECT' variable. Now we need not specify custom processing for DRAWEXE in occt_toolkit.cmake

3 years ago0029580: Regression: invalid result of BOP Fuse
emv [Thu, 15 Mar 2018 14:02:46 +0000 (17:02 +0300)]
0029580: Regression: invalid result of BOP Fuse

Boolean Operation - avoid creation of INTERNAL solid from unclassified faces in Solid Builder algorithm.
Instead warn the user that some of the faces have been unclassified and not used for solids creation.

Adjustment of the test cases.
Test cases for the issue.

3 years ago0028090: Configuration - DRAWHOME environment variable missing in CMake
apn [Thu, 15 Mar 2018 09:12:10 +0000 (12:12 +0300)]
0028090: Configuration - DRAWHOME environment variable missing in CMake

Replace variable DRAWHOME by CSF_OCCTResourcePath for successfully running DFBrowse command in Draw launched from Visual Studio.
Added missed icons of folders, attributes and named shapes used in DFOpenImage command in src\DrawResources\dftree.tcl.

3 years ago0022651: Impossible to build OCC as static library due to using Standard_EXPORT inste...
abv [Thu, 15 Mar 2018 10:07:48 +0000 (13:07 +0300)]
0022651: Impossible to build OCC as static library due to using Standard_EXPORT instead of Standard_API

All library-specific macros for defining export / import properties of symbols on Windows (like Standard_API, __Draw_API, _math_API etc.) are eliminated.
Common macro Standard_EXPORT is used in all places where it is necessary.

New macro OCCT_STATIC_BUILD is defined for disabling Standard_EXPORT, to be used instead of HAVE_NO_DLL, though the latter is still supported as well (for compatibility).

To allow building OCCT in static mode on Windows after these changes:
- Files OSD_WNT_1.hxx and OSD_WNT_BREAK.hxx are removed; useful declarations are moved to OSD_WNT.hxx
- In the class IVtkVTK_ShapeData, static fields ARRNAME_MESH_TYPES and ARRNAME_SUBSHAPE_IDS are converted to static inline functions
- Global array ChoixRef defined in IntImp_ComputeTangence.cxx is converted to static function returning element of the array by index
- Unused class Quantity_Convert is removed (it had static field accessed by inline method)
- Struct Approx_Data defined in the same way in BRepApprox_Approx.hxx and GeomInt_WLApprox.hxx is made private member of these classes to avoid name clash
- Some C++ files producing no object code are removed
- In NCollection_EBTree.hxx and StdLPersistent_Collectio.hxx, definition of template virtual method is moved to class definition to avoid MSVC linker warnings on unused symbols

3 years ago0029582: Coding Rules, Bnd_Range - inconsistent methods pair GetMin()/GetMAX() IR-2018-03-16 IR-2018-03-16-GLES
kgv [Thu, 15 Mar 2018 19:38:19 +0000 (22:38 +0300)]
0029582: Coding Rules, Bnd_Range - inconsistent methods pair GetMin()/GetMAX()

Cosmetics - removed redundant semicolons.
Method ::GetMAX() has been renamed to ::GetMax().
Added method ::Add() taking another Bnd_Range as argument.
Added methods ::IsOut() mimicing a Bnd_Box interface.
Methods ::Shift() and ::Shifted() no more modify Void range.

3 years ago0029576: Coding Rules - remove unused declarations from package Aspect
kgv [Wed, 14 Mar 2018 18:51:11 +0000 (21:51 +0300)]
0029576: Coding Rules - remove unused declarations from package Aspect

The following unused declarations have been removed:
  Aspect_TypeOfPrimitive, Aspect_TypeOfLayer, Aspect_TypeOfEdge,
  Aspect_TypeOfDrawMode, Aspect_TypeOfConstraint,
  Aspect_DriverDefinitionError, Aspect_BadAccess.

3 years ago0029531: Exception on Redo
mpv [Mon, 5 Mar 2018 08:11:52 +0000 (11:11 +0300)]
0029531: Exception on Redo

3 years ago0029310: Coding - multiple compiler warnings in Inspectors
nds [Sun, 4 Mar 2018 16:10:56 +0000 (19:10 +0300)]
0029310: Coding - multiple compiler warnings in Inspectors

1. Added specific header files to disable and restore compiler warnings: Standard_WarningsDisable.hxx, Standard_WarningsRestore.hxx.
   (Currently only MSVC compiler is handled.)
2. Inspector: compiler warnings are disabled for all includes of Qt headers.
3. Inspector: minor code correction to avoid warning due to use of floating point values in integer calculations.

3 years ago0029140: Samples - Viewer is not updated in MFC Modeling and Viewer3D samples
inv [Thu, 15 Mar 2018 15:00:29 +0000 (18:00 +0300)]
0029140: Samples - Viewer is not updated in MFC Modeling and Viewer3D samples

OCC_3dBaseDoc::OnUpdateObjectDisplayall() - allow re-displaying hidden presentation of non-Shape types.
OCC_3dBaseDoc::OnObjectErase() - removed redundant call AIS_InteractiveContext::ClearSelected().

CModelingDoc::OnFuse(),::OnCommon(),::OnExplorer() - removed redundant
viewer updates and add missing ones.

3 years ago0029412: Huge Memory leak since I upgraded to OC 6.9.0
abv [Thu, 15 Mar 2018 07:39:55 +0000 (10:39 +0300)]
0029412: Huge Memory leak since I upgraded to OC 6.9.0

Added non-regression test bugs vis bug29412

3 years ago0029266: CMake install does not copy pdb files in Debug mode due to the changes in...
apn [Wed, 29 Nov 2017 12:46:54 +0000 (15:46 +0300)]
0029266: CMake install does not copy pdb files in Debug mode due to the changes in 0028287

OCCT_INSTALL_BIN_LETTER is used only on Windows (isn't depended on type of generator) because bind/libd/bini/libi folders are not used on Linux (only bin and lib)

3 years ago0029560: Jenkins - Control of license statements and non-ascii characters in integrat...
bugmaster [Tue, 13 Mar 2018 15:32:32 +0000 (18:32 +0300)]
0029560: Jenkins - Control of license statements and non-ascii characters in integrated code

Removing non-ascii characters

3 years ago0029535: Modeling Algorithms - BRepExtrema_DistShapeShape returns only one solution...
ifv [Fri, 2 Mar 2018 13:59:08 +0000 (16:59 +0300)]
0029535: Modeling Algorithms - BRepExtrema_DistShapeShape returns only one solution but the wires have two intersections

The subdivision of long curve is added in algorithm GenExtCC, if length of curves are too different.
Test case added

3 years ago0029515: Foundation Classes, OSD - 'Spawn' contains function that isn't available...
abv [Wed, 14 Mar 2018 08:02:10 +0000 (11:02 +0300)]
0029515: Foundation Classes, OSD - 'Spawn' contains function that isn't available on iOS

Method OSD_Process::Spawn() is removed as useless (not used across OCCT or products).
Note that on Linux, macOS, and Windows standard C function "system()" can be used directly instead, while iOS apparently does not support spawning separate processes at all.

3 years ago0027070: Segfault when transferring HLR-created shapes via STEPControl_Writer
abv [Thu, 8 Mar 2018 06:56:01 +0000 (09:56 +0300)]
0027070: Segfault when transferring HLR-created shapes via STEPControl_Writer

Added protection against null shape on writing: status IFSelect_RetVoid will be returned in such case (instead of access violation)

3 years ago0029129: Incomplete support of MSVS2017
apn [Mon, 12 Mar 2018 13:19:21 +0000 (16:19 +0300)]
0029129: Incomplete support of MSVS2017

MSVC_VERSION is used instead of MSVC10, MSVC11, MSVC12, etc.

3 years ago0029559: Samples - wrong copyright statement in FuncDemo
apn [Tue, 13 Mar 2018 15:16:39 +0000 (18:16 +0300)]
0029559: Samples - wrong copyright statement in FuncDemo

Update FuncDemo sample according to new elasticnodes example in Qt.

3 years ago0029470: Samples - eliminate references to deprecated Local Context from MFC sample
kgv [Sun, 11 Mar 2018 10:21:01 +0000 (13:21 +0300)]
0029470: Samples - eliminate references to deprecated Local Context from MFC sample

AIS_InteractiveContext::MoveTo(), ::Select(), ::ShiftSelect() now throw
an exception on invalid V3d_View argument instead of returning empty results.
AIS_InteractiveContext::DetectedShape() and ::BeginImmediateDraw() now can
be called without opened Local Context.

Draw Harness - removed unused commands vsetam, vunsetam.
Removed unused methods ViewerTest::StandardModeActivation(), ::PickObject(), PickObjects().
Interactive input of Selection modes 0..7 now redirects to vselmode
instead of removed ViewerTest::StandardModeActivation().

3 years ago0029481: Implementation of the Feature Removal algorithm
emv [Tue, 6 Feb 2018 05:48:27 +0000 (08:48 +0300)]
0029481: Implementation of the Feature Removal algorithm

Implementation of the 3D model De-featuring algorithm intended for the removal of the unwanted parts (or features) from the model consisting of solids. The features can be the holes, protrusions, gaps, chamfers, fillets etc.
The algorithm removes all possible requested features from the shape and builds the new shape as a result. The input model is not modified.

On the API level the algorithm is implemented in the class *BRepAlgoAPI_Defeaturing*. The actual features removal is performed by the low-level algorithm *BOPAlgo_RemoveFeatures*.

Documentation of the new classes.
Implementation of the DRAW commands for working with new algorithm.
Test cases for the new functionality.

Changes in other algorithms used by De-featuring algorithm:
- Provide history support for the solids in *ShapeUpgrade_UnifySameDomain* algorithm;
- Implementation of the mechanism to merge History of any Algorithm with standard history methods such as IsDeleted(), Modified() and Generated() into *BRepTools_History*.

3 years ago0026127: Visualization - Default camera is not copied in copy constructor of V3d_View
kgv [Thu, 8 Mar 2018 10:52:01 +0000 (13:52 +0300)]
0026127: Visualization - Default camera is not copied in copy constructor of V3d_View

V3d_View copy constructor now copies DefaultCamera() from specified View.
Draw Harness command vinit - added new argument -cloneActive.

3 years ago0028988: Visualization - AIS_InteractiveContext::SetLocation() does not reset locatio...
kgv [Wed, 7 Mar 2018 18:22:16 +0000 (21:22 +0300)]
0028988: Visualization - AIS_InteractiveContext::SetLocation() does not reset location properly

SelectMgr_SelectionManager - removed broken HasTransformation() checks.

3 years ago0029545: Documentation, visualization.md - article incorrectly specifies that AIS_Con...
kgv [Mon, 5 Mar 2018 13:59:18 +0000 (16:59 +0300)]
0029545: Documentation, visualization.md - article incorrectly specifies that AIS_ConnectedInteractive can define own Material

3 years ago0029356: Modeling Algorithms - GCPnts_TangentialDeflection hangs on specific curve
nds [Mon, 29 Jan 2018 08:19:36 +0000 (11:19 +0300)]
0029356: Modeling Algorithms - GCPnts_TangentialDeflection hangs on specific curve

While UV Iso parameters are obtained in StdPrs_Isolines, UV limits should be applied only if face bounds has infinite values.
In the issue case, the UV values are greater than UVLimits and not infinite. This fix makes possible to have correct Iso lines in presentation without modification of UV limits beforehead.

3 years ago0029544: Regression vs 7.2.0: ShapeUpgrade_UnifySameDomain fails to merge linear...
emv [Mon, 5 Mar 2018 12:55:16 +0000 (15:55 +0300)]
0029544: Regression vs 7.2.0: ShapeUpgrade_UnifySameDomain fails to merge linear edges

When measuring the deviation of the end of the added edge from the resulting edge take the point on the curve, not from the vertex.

Test cases for the issue.

3 years ago0029542: Coding - CMake compiler warnings in Inspector
nds [Sun, 4 Mar 2018 07:33:10 +0000 (10:33 +0300)]
0029542: Coding - CMake compiler warnings in Inspector

Avoid using CMAKE_AUTOMOC, collect header files with Q_OBJECT iterating through a project files.

3 years ago0029547: –°onfiguration, upgrade.dat - include deprecated enums into section [rename]
kgv [Tue, 6 Mar 2018 09:42:12 +0000 (12:42 +0300)]
0029547: –°onfiguration, upgrade.dat - include deprecated enums into section [rename]

Added V3d_TypeOfShadingModel->Graphic3d_TypeOfShadingModel and
V3d_TypeOfLight->Graphic3d_TypeOfLightSource renames.

3 years ago0029529: Volume Rendering - crash on re-displaying the object IR-2018-03-02 IR-2018-03-02-GLES
kgv [Thu, 1 Mar 2018 17:10:46 +0000 (20:10 +0300)]
0029529: Volume Rendering - crash on re-displaying the object

Added missing getters: OpenGl_TextureBufferArb::TextureFormat() and OpenGl_ShaderManager::OitState().

3 years ago0029517: Visualization - introduce AlphaMode property defining alpha value handling...
kgv [Tue, 20 Feb 2018 13:32:52 +0000 (16:32 +0300)]
0029517: Visualization - introduce AlphaMode property defining alpha value handling options

3 years ago0029524: Modeling Algorithms - access violation in HLRBRep_PolyAlgo while computing...
kgv [Thu, 22 Feb 2018 15:42:15 +0000 (18:42 +0300)]
0029524: Modeling Algorithms - access violation in HLRBRep_PolyAlgo while computing HLR for triangulation-only surface

3 years ago0029519: Visualization, TKOpenGl - fallback to Graphic3d_TOSM_FACET from Gouraud...
kgv [Tue, 20 Feb 2018 05:00:01 +0000 (08:00 +0300)]
0029519: Visualization, TKOpenGl - fallback to Graphic3d_TOSM_FACET from Gouraud/Phong when nodal normals are undefined

3 years ago0029097: Visualization - allow picking Graphic3d_TypeOfShadingModel per-object
anv [Thu, 8 Feb 2018 15:41:09 +0000 (18:41 +0300)]
0029097: Visualization - allow picking Graphic3d_TypeOfShadingModel per-object

Graphic3d_AspectFillArea3d has been extended by new property ::ShadingModel(),
which is set to Graphic3d_TOSM_DEFAULT by default.
The new API allows assigning Shading Model to specific Primitive Array groups
instead of entire Viewer, which was the only possibility before.

Graphic3d_TypeOfShadingModel has been extended with Graphic3d_TOSM_DEFAULT value
meaining that Shading Model defined as default for the Viewer should be used.
Graphic3d_TOSM_NONE has been renamed to Graphic3d_TOSM_UNLIT.
Documentation of Shading Models has been improved by more details.

V3d_TypeOfShadingModel enumeration has been merged into Graphic3d_TypeOfShadingModel
avoiding duplicated definitions and confusion.
Old values has been left for compatibility with old code and can be marked deprecated in future.

Draw Harness command vaspects has been extended by new argument -setShadingModel
for testing Shading Models assigned to entire objects.

OpenGl_SetOfShaderPrograms now holds an array of Shading Models.
OpenGl_ShaderManager interface has been modified and now requires enumeration as input
in several places where Boolean flags have been used previously
(methods ::BindFaceProgram(), ::BindLineProgram(), ::BindMarkerProgram()).

OpenGl_Workspace now defines default (undefined) OpenGl_AspectFace as Graphic3d_TOSM_UNLIT
to simplify indication of primitive groups with undefined Fill Area aspects,
and so that Graphic3d_TOSM_UNLIT set as default Shading Model will not make artifacts on Lines and Markers.

AIS_Manipulator::Axis::Compute() - added missing initialization of Fill Area aspects (leading to undefined behavior).

3 years ago0029514: Configuration, CMake - OpenGL ES should be available for Linux
apn [Mon, 19 Feb 2018 09:24:55 +0000 (12:24 +0300)]
0029514: Configuration, CMake - OpenGL ES should be available for Linux

Allow optionally building OCCT with GLESv2 and EGL on Linux

3 years ago0029492: Coding Rules. NCollection_IndexedDataMap - add missing documentation to...
kgv [Thu, 8 Feb 2018 13:16:45 +0000 (16:16 +0300)]
0029492: Coding Rules. NCollection_IndexedDataMap - add missing documentation to method ::Add()