kgv [Tue, 28 Nov 2017 05:42:40 +0000 (08:42 +0300)]
0029349: Foundation Classes, OSD_Timer - add missing theThisThreadOnly constructor option available in OSD_Chronometer
OSD_Timer constructor now has theThisThreadOnly option passed to OSD_Chronometer,
which is FALSE by default.
OSD_Chronometer now provides methods ::UserTimeCPU(), ::SystemTimeCPU() allowing
to fetch CPU times without akward syntax through overloaded ::Show().
ifv [Thu, 9 Nov 2017 14:20:10 +0000 (17:20 +0300)]
0029289: Wrong derivatives in math_TrigonometricFunctionRoots.cxx file
Class MyTrigoFunction is removed from file math_TrigonometricFunctionRoots.cxx.
New class math_TrigonometricEquationFunction with the same functionality is created to provide possibilities
for individual testing.
Expressions for derivatives are corrected.
New Draw command "intconcon" for intersection 2d conic curves is created.
Test command OCC29289 (file QABugs_20.cxx) is created for individual testing math_TrigonometricEquationFunction.
It is used in tests/bugs/modalg_7/bug29289
ika [Thu, 23 Nov 2017 09:40:59 +0000 (12:40 +0300)]
0029338: Data Exchange - Add Planes for Tolerance zones in Geometric tolerances
Add new poles to Geometric Tolerance objects
Some code refactoring in GDT attributes
Add Draw functions for affected plane
mkv [Thu, 26 Oct 2017 08:59:25 +0000 (11:59 +0300)]
Update of tests database
Test for
0023171: Got wrong result after stitching
Test for
0023612: BRepPrimAPI_MakeTorus
Test for
0023610: checkshape command does not detect mismatch of the tolerance values among the sub-shapes of the shape
Test for
0023660: 'bsection' produces result with gap
Test for
0024397: BRepBuilderAPI_Copy works not correct
Test for
0023927: BRepProj_Projection produces Edge with one Vertex outside from curve
Test for
0023902: Cannot build fillet
Test for
0023669: Error in Boolean operations algorithm: section between cylindrical face and prism is incomplete
Test for
0023660: 'bsection' produces result with gap
Test for
0024100: Bad pcurve is built on a face while converting the shape from STEP format.
Test for
0024319: Sewing makes a solid transparent
Test for
0024302: Section operation modifies input argument
Test for
0024397: BRepBuilderAPI_Copy works not correct
Test for
0024418: Wrong section curves when intersecting analytical surfaces
szy [Mon, 20 Nov 2017 14:31:15 +0000 (17:31 +0300)]
0029142: Exception on Redo.
Order of attributes deltas is fixed.
emv [Wed, 22 Nov 2017 13:29:40 +0000 (16:29 +0300)]
0029175: BRepOffsetAPI_MakeOffset problem
The problem is fixed by the fix for the issue #29162.
Creating test case for the issue.
emv [Mon, 13 Nov 2017 13:03:31 +0000 (16:03 +0300)]
0029321: Improve performance of the 3D offset algorithm for the planar cases
Disable additional intersection of the splits of offset faces implemented in method BRepOffset_MakeOffset::Intersection3D() for the mode "Complete" and join type "Intersection".
This method is insufficient, as it does not allow to detect the tangential faces, necessary for this mode.
Intersection is performed in the method BuildShellsCompleteInter() developed for this mode.
emv [Mon, 13 Nov 2017 08:11:27 +0000 (11:11 +0300)]
0029322: Unify faces classification procedures in Boolean Operations
1. Unify the faces classification procedure of the methods BOPAlgo_BuilderSolid::PerformInternalShapes() and BOPAlgo_Builder::FillIn3DParts() using the latter as a base.
The new method BOPAlgo_Tools::ClassifyFaces() has been created for that. Both methods mentioned above have been updated to use the new one.
2. Forced intersection of the edges after enlarge of the tolerance values of their vertices during the operation has been added into BOP's intersection algorithm (BOPAlgo_PaveFiller).
BOPAlgo_Tools::PerformCommonBlocks() method has been updated to avoid loosing faces of the already created Common blocks.
As a result the case "boolean gdml_private ZF6" became more stable, because the intermediate result is no longer invalid.
Additional test cases have been added to verify this improvement (bugs modalg_7 bug29322_*)
3. When building PCurves for edges on faces, check the existing PCurves on its validity for periodic surfaces and adjust PCurves if necessary.
The improvement helps to produce the valid result in the test case "bugs moddata_1 bug152".
4. Avoid creation of empty Edge-Edge interference if the intersection point is lying close to a shared vertex.
The improvement helps obtain the valid result of the "bopcheck" operation in the test case "bugs modalg_7 bug27683".
Adjustment of the test case to current behavior:
- Avoid usage of the self-intersecting torus in the test case "boolean gdml_public A9".
- Fix the input shape in the test case "boolean bopfuse_complex H1" to provide valid result.
- Test cases "bugs moddata_1 bug152_1 bug152_2" have been unified into single test case "bugs moddata_1 bug152". Now, the case rebuilds invalid input data and performs all types of Boolean operations.
- Change the test case "bugs modalg_7 bug22750" to produce valid intermediate results used in subsequent operations as arguments.
- The following test cases are improvements:
- "boolean volumemaker D8"
- "boolean volumemaker G1"
- "bugs modalg_7 bug27683"
aml [Fri, 10 Nov 2017 15:21:21 +0000 (18:21 +0300)]
0025879: result of blend fails the bopcheck
Protection from the zero-length gp_Dir construction is added.
abv [Fri, 15 Sep 2017 07:52:14 +0000 (10:52 +0300)]
0029113: Coding Rules - fix convention to have one header per API type
Paragraph on naming of classes is revised to describe correspondence of names of public types and files.
msv [Fri, 20 Oct 2017 15:59:01 +0000 (18:59 +0300)]
0029234: BRepOffsetAPI_NormalProjection produces INTERNAL edges and vertices
Make the algorithm BRepOffsetAPI_NormalProjection use section operation instead of common to get the edge-result of projection to be in face restrictions.
Correct Boolean operation algorithm to produce correctly oriented result in the case of common between face and edge.
The algorithm ShapeUpgrade_UnifySameDomain has been patched to correctly gather same domain faces in a compound.
The TCL script snowflake.tcl has been corrected to get rid of dependence on the order of edges in the result of Boolean operation.
kgv [Tue, 14 Nov 2017 08:38:31 +0000 (11:38 +0300)]
0029317: Configuration, CMake - CSF_d3d9 should be processed for building TKD3DHost using MinGW
msv [Wed, 8 Nov 2017 15:13:47 +0000 (18:13 +0300)]
0029287: Move package GProp from TKG2d to TKG3d
jgv [Wed, 18 Oct 2017 14:35:58 +0000 (17:35 +0300)]
0029204: BRepOffsetAPI_MakePipeShell produces invalid result and raises exception in Draw
1.The algorithm searching the section in the corner (ChooseSection) is modified to be able to find simple cases with rather big tolerance.
2. The constructor of BRepFill_Section is modified: now it removes locations in the shape of section like it was done in BRepFill_Pipe.
3. Correction of U-edges by Same Parameter has been added to the method BRepFill_Sweep::Build.
aml [Sat, 11 Nov 2017 07:33:45 +0000 (10:33 +0300)]
0025968: boolean returning an invalid shape
Problem is not reproduced on current master.
Testing case was created
emv [Wed, 8 Nov 2017 06:16:35 +0000 (09:16 +0300)]
0029301: Improve performance of Boolean Operations
Improve performance of Boolean operations algorithm by:
- Improving the check of Same Domain faces (BOPAlgo_Builder::FillSameDomainFaces());
- Faster rejection of outer faces for solids using Bounding Box classification first (BOPAlgo_Builder::FillIn3DParts());
- Using IncAllocator for local containers.
Quality improvement has been made in BOPAlgo_PaveFiller class:
1. Method IsExistingPaveBlock() has been corrected to provide the correct edge tolerance and to obtain valid intermediate results in the test case "boolean gdml_private ZH3".
New test case have been added to verify this improvement (bugs modalg_7 bug29301).
2. Method PutClosingPaveOnCurve() has been corrected to use the tolerance of the pave put on the bound for checking curve on closeness.
Additional check for the curve to have valid range after addition of the pave on the other end has been added to prevent considering the small curves (covered by vertex tolerance) as closed ones.
As a result of this modification the test case boolean gdml_public B2 has been fixed (TODO removed).
Adjustment of the test cases to current behavior:
- boolean bopcommon_complex J1 - the produced result was incorrect as it was self-interfered. There should be no common in this case.
- offset shape_type_i_c ZZ1 - the incorrect result is now produced instead of null shape.
aml [Sat, 11 Nov 2017 07:44:41 +0000 (10:44 +0300)]
0025966: Booleans with tangent faces
Problem is not reproduced on current master.
Testing case was created
aml [Thu, 2 Nov 2017 09:08:18 +0000 (12:08 +0300)]
0025104: Prism from BSpline curve can not be chamfered
Protection from zero-length vectors has been added.
msv [Fri, 17 Feb 2017 08:26:25 +0000 (11:26 +0300)]
0028467: Improve UnifySameDomain performance
This patch turns off some not needed modes of fix in the called ShapeFix_Face algorithm.
It stores pcurves on planes in the edges to avoid repeated computation of the same pcurves many times (it is done only when SafeInputMode is false).
It avoids unnecessary replace/apply actions in the modification context.
It removes the code that makes decomposition of surface of the face on several faces.
The new command buildpcurvesonplane has been added, which builds and stores pcurves of edges on planar faces. This is useful for investigations how presence of pcurves on planes influence performance of algorithms.
Make drawing of dimension line in snowflake test independent on the order of vertices in the result.
kgv [Wed, 8 Nov 2017 06:44:27 +0000 (09:44 +0300)]
0028760: Visualization, TKOpenGl - avoid excessive frustum culling traverse within extra OIT rendering pass
Culling traverse is no more called implicitly within OpenGl_Layer::Render().
Instead, all layers are traversed at onces within OpenGl_View::render() beforehand.
OpenGl_BVHTreeSelector methods have been renamed to better reflect their meaning.
Non-persistent culling options has been moved to dedicated structure OpenGl_BVHTreeSelector::CullingContext
so that OpenGl_BVHTreeSelector instance can be used for different Layers without modifying its state.
kgv [Tue, 31 Oct 2017 17:02:13 +0000 (20:02 +0300)]
0029283: Visualization - allow defining more than 8 light sources
OpenGl_ShaderManager now overrides THE_MAX_LIGHTS within built-in shading programs
so that maximum number of lights is now limited only by OpenGL hardware
(e.g. length of GLSL program, number of defined uniforms, result performance, etc.).
THE_MAX_CLIP_PLANES is now also defined by OpenGl_ShaderManager,
so that unused lights and clipping planes do not reserve extra uniforms in GLSL programs.
V3d_View::SetLightOn() does not throw exception anymore, when the number of lights exceeds 8.
Instead, OpenGl_ShaderManager::PushLightSourceState() emits warning
in case of usage of FFP providing consistent behavior with Clipping Planes number limit.
kgv [Thu, 9 Nov 2017 07:18:49 +0000 (10:18 +0300)]
0029304: Draw Harness, DBRep_DrawableShape - fix inappropriate use of unordered map
TColStd_DataMapOfIntegerInteger has been replaced by NCollection_Vector.
kgv [Tue, 7 Nov 2017 14:23:29 +0000 (17:23 +0300)]
0029299: Foundation Classes, NCollection - define explicit empty constructor for map classes
Ambiguous constructors have been marked with explicit keyword for classes
NCollection_DataMap, NCollection_DoubleMap, NCollection_IndexedDataMap, NCollection_IndexedMap,
NCollection_List, NCollection_LocalArray, NCollection_Map, NCollection_Sequence,
NCollection_SparseArray, NCollection_UBTree,
kgv [Wed, 8 Nov 2017 12:25:51 +0000 (15:25 +0300)]
0029302: Foundation Classes, NCollection - optimize iteration of indexed maps
NCollection_IndexedMap and NCollection_IndexedDataMap
now access Key by Index number without computing Hash code.
IndexedMapNode::myNext2 and IndexedDataMapNode::myNext2 fields
have been removed, so that indexed map now may utilize less memory.
TCollection::NextPrimeForMap() has been extended upto
2038431745
(almost full signed 32-bit integer range),
and NCollection_BaseMap::mySaturated property has been removed.
NCollection_IndexedDataMap::RemoveFromIndex(), FindKey(), FindFromIndex(),
ChangeFromIndex() - removed duplicating checks for out of range input.
kgv [Tue, 7 Nov 2017 21:11:57 +0000 (00:11 +0300)]
0029300: Visualization, TKOpenGl - provide depth pre-pass option
OpenGl_LayerList::Render() now handles new option Graphic3d_RenderingParams::ToEnableDepthPrepass
which prepends additional pass to rendering pipeline filling Depth Buffer in advance.
kgv [Thu, 2 Nov 2017 13:29:17 +0000 (16:29 +0300)]
0029292: Coding Rules - remove Graphic3d_Vector duplicating gp_XYZ
Graphic3d_Vector has been replaced by gp_Pnt/gp_XYZ/gp_Dir depending on context.
StdSelect_ViewerSelector3d::ToPixMap() - fixed unsafe float math causing out-of-range color results.
ifv [Thu, 12 Oct 2017 13:54:35 +0000 (16:54 +0300)]
0029162: Geom2dInt_GInter algorithm does not find intersection of ellipse and line
Analytical intersection algorithm is implemented for ellipse-line intersection
abv [Mon, 6 Nov 2017 13:43:34 +0000 (16:43 +0300)]
0029297: [Regression] Configuration - Mingw-w64 build fails for TKOpenGl due to missing link to OpenGl
The order of external libraries is corrected in TKOpenGl/EXTERNLIB so that more higher-level libs are mentioned earlier than low-level libs on which the former depend (e.g. Gl2Ps before OpenGl) to ensure that GCC linker is able to resolve dependencies.
kgv [Sun, 15 Oct 2017 13:08:01 +0000 (16:08 +0300)]
0029258: Foundation Classes - provide move constructors for string classes
New macro OCCT_NO_RVALUE_REFERENCE is introduced to disable methods using move semantics on obsolete compilers that do not support rvalue references.
TCollection_AsciiString, TCollection_ExtendedString, NCollection_UtfString - added method Swap(), move constructor, and move assignment operator.
Draw command QATestArrayMove is added to test for memory corruption if NCollection_Array1<> bound to local C buffer is returned from function by value.
kgv [Sun, 5 Nov 2017 15:07:25 +0000 (18:07 +0300)]
0029295: Visualization, TKOpenGl - provide distance culling option
Graphic3d_ZLayerSettings::CullingDistance() and ::CullingSize() - added
new properties configuring culling of small and distant objects, disabled by default.
OpenGl_BVHTreeSelector now handles size culling and distance culling in addition to frustom culling.
kgv [Thu, 2 Nov 2017 07:04:39 +0000 (10:04 +0300)]
0029285: Visualization, V3d_View::UpdateLights() - eliminate implicit redraw
kgv [Thu, 2 Nov 2017 07:28:01 +0000 (10:28 +0300)]
0029286: Visualization, TKOpenGl - do not update FFP state when OpenGl_Caps::ffpEnable is disabled
emv [Fri, 3 Nov 2017 09:12:34 +0000 (12:12 +0300)]
0029293: Boolean Operations algorithm does not preserve the orientations of the faces
While building splits of faces (BOPAlgo_Builder::FillImagesFaces()) make sure that the orientation of the input face will be passed to its splits.
Extend draw command "normals" with new key "[-print]" which allows printing values of the normal vector.
mnt [Wed, 18 Oct 2017 11:13:35 +0000 (14:13 +0300)]
0029133: Unstable test cases
Adding new and early removed for some reasons test cases
Removing TODO ?
Adding necessary TODO ? on corresponding platforms for OK and BAD cases
ika [Mon, 30 Oct 2017 15:04:12 +0000 (18:04 +0300)]
0029282: Data Exchange - UpdateAssemblies is not working for located root assemblies
Add check for located root assemblies.
emv [Wed, 18 Oct 2017 08:05:24 +0000 (11:05 +0300)]
0029237: Improve performance of Boolean Operations
In order to improve performance of Boolean Operations on the relatively fast cases the following improvements have been made:
1. Initialization of the FaceInfo information for the faces participating in Face/Face interference, even when the gluing is ON, to take into account intersection of their sub-shapes.
2. Code simplification & duplication removal - the methods BOPAlgo_ShellSplitter::MakeConnexityBlocks and BOPAlgo_WireSplitter::MakeConnexityBlocks have been unified into BOPTools_AlgoTools::MakeConnexityBlocks.
3. Avoid unnecessary bounding box computation for solids during DS initialization. The bounding boxes for solids will be computed during the building stage to find faces located inside solids.
For the shape self-interference check (performed by the BOPAlgo_CheckerSI), the bounding box is still computed, as it is necessary to resolve Shape/Solid intersections.
4. Use only three sample points to check coincidence of line and plane.
5. Perform necessity of planes intersection only when the gluing is off.
6. Avoid repeated initialization of 2D classifier while building splits of the faces.
7. Post treat stage:
7.1. Method CorrectWires: Save edge's data (PCurve, parameter of the vertex, range) to avoid its recalculation.
7.2. Method CheckEdge: While checking vertices on edges avoid unnecessary calculation of their location.
8. Provide possibility to disable the classification of the input solids on the inverted status (to be the holes in the space).
9. Avoid building of bounding boxes for faces/solids during splitting of the input arguments for their classification relatively hole faces/shells if there are no holes created.
10. Avoid rebuilding of the faces/solids from arguments which does not acquire any inside parts from other arguments during the operation by using their draft versions as their splits.
Test cases for the issue.
Correction of the test cases boolean gdml_public A9 and bugs modalg_7 bug28485 as they are improvements.
Additional test case for the issue #28485 as it is fixed by the current changes.
aml [Tue, 31 Oct 2017 03:43:57 +0000 (06:43 +0300)]
0027784: Thickness fails on cylinder with draft
Incorrect calculation of intersection in 2D space is fixed.
ski [Tue, 31 Oct 2017 09:07:18 +0000 (12:07 +0300)]
0029277: Configuration, Cmake - remove 3rd-party libraries from INTERFACE_LINK_LIBRARIES property of installed OCCT targets
3rd-party libraries were removed from INTERFACE_LINK_LIBRARIES properties of OCCT targets.
kgv [Tue, 24 Oct 2017 08:21:03 +0000 (11:21 +0300)]
0029249: Configuration - Standard_Failure compilation fails on VS2013 + Intel Compiler due to unavailability of thread_local
Check __INTEL_COMPILER version in combination with _MSC_VER on Windows.
kgv [Wed, 25 Oct 2017 14:27:23 +0000 (17:27 +0300)]
0029262: Visualization - AIS_InteractiveContext::Load() does not register Object in the Viewer
AIS_InteractiveContext::Load() now loads the object regardless specified selection mode and decomposition flag.
AIS_InteractiveContext::Load() and ::KeepTemporary() now register object in the Viewer
in the same way as ::Display() does.
Draw Harness command vdisplay has been extended with new flag -erased to load object into context in erased state.
apn [Tue, 24 Oct 2017 08:00:54 +0000 (11:00 +0300)]
0029250: Configuration, TKIVtk - build failure with VTK 6.3+ due to vtkRenderingFreeTypeOpenGL being removed
Remove vtkRenderingFreeTypeOpenGL from EXTERNLIB if used vtk version is 6.3.0 and above
kgv [Sat, 21 Oct 2017 17:46:59 +0000 (20:46 +0300)]
0029251: Configuration - problem compiling OCCT 7.2 with glibc 2.26
Standard_CLocaleSentry does not include xlocale.h when using glibc anymore.
HAVE_XLOCALE_H has been renamed to OCCT_CLOCALE_POSIX2008 to avoid confusion.
Renamed macros OCC_CHECK_BASE_CLASS -> OCCT_CHECK_BASE_CLASS.
kgv [Tue, 24 Oct 2017 10:55:48 +0000 (13:55 +0300)]
0029255: Configuration, .gitignore - do not track generated files with extensions VC.db, VC.opendb
kgv [Sat, 21 Oct 2017 18:17:14 +0000 (21:17 +0300)]
0029252: Coding rules - eliminate GCC compiler warnings -Wformat-overflow
OSD_DirectoryIterator and OSD_FileIterator now uses TCollection_AsciiString instead of unsafe sprintf.
abv [Thu, 19 Oct 2017 14:12:05 +0000 (17:12 +0300)]
0024574: ICC compiler warnings on Windows
NCollection_UtfString and NCollection_UtfIterator classes are refactored to use methods overloading instead of switches to dispatch implementation depending on character (Unicode code unit) size.
ICC-specific preprocessor directives are added to avoid warnings.
Unused local functions and variables, class methods, unreachable statements, and extra throw() declarations reported by ICC are removed.
Usage of "expl" for name of local variable is avoided as it conflicts with standard C function "expl" defined in math.h as preprocessor macro.
Non-standard (MS-specific) argument envp is removed in definition of main() function on Windows.
Functions _main_ and _WinMain_ are renamed to Draw_Main and Draw_WinMain, respectively, to avoid using names reserved in C++.
Doxygen warning is fixed in XDE User's Guide.
kgv [Thu, 12 Oct 2017 08:31:41 +0000 (11:31 +0300)]
0029214: Application Framework - TPrsStd_AISPresentation::AISUpdate() should not implicitly redraw 3D Viewer
apn [Thu, 19 Oct 2017 09:08:05 +0000 (12:08 +0300)]
0029247: Tests, CheckCommands.tcl - Tcl exception "expected integer but got 3dviewer" in test cases on macOS
Test cases on macOS (using native tcl from /usr/lib) fail when $lst starts with numeral, because upvar guesses that its first parameter is level rather than otherVar.
The fix is to explicitly supply level to 1 (default value if uplevel is omitted) to avoid tcl exception "expected integer but got 3dviewer".
ifv [Fri, 6 Oct 2017 11:52:20 +0000 (14:52 +0300)]
0029183: Result of general fuse of shell and edge produces a shape with too large tolerance
Adjusting parameters on approximation (boundary condition) for case when projected curve is far from surface
Test case is created
msv [Wed, 18 Oct 2017 16:20:30 +0000 (19:20 +0300)]
0029157: Modeling - suspicious pass-through of case labels in switch statements
Suspicious passes through case labels have been resolved either by using Standard_FALLTHROUGH macro or by redesigning the code.
msv [Fri, 6 Oct 2017 14:07:50 +0000 (17:07 +0300)]
0029182: BOPAlgo_PaveFiller sometimes raises exception in parallel mode
Data races have been prevented in the code of BOPAlgo_PaveFiller that makes pcurves of edges on faces. For that:
- Put into treatment only unique edge-face pairs.
- If the same edge is treated with different faces in different threads simultaneously this also causes data races. To avoid this make the edge's copy in each thread and update the copy. The original edge is updated only after finishing parallel processing.
The new method BOPTools_AlgoTools::CopyEdge has been added to make a copy of an edge with vertices.
Big screenshot in the test script tests/bugs/modalg_7/bug28200 has been replaced with a small one.
oan [Thu, 12 Oct 2017 10:47:00 +0000 (13:47 +0300)]
0029186: Move AddTool(), SetTools(), Tools() and other common methods of BOP tools to separate interface class
Methods AddTool(), SetTools(), Tools() have been moved to BOPAlgo_ToolsProvider class;
BOPAlgo_BOP and BOPAlgo_Splitter are now successors of BOPAlgo_ToolsProvider
kgv [Fri, 13 Oct 2017 15:49:18 +0000 (18:49 +0300)]
0029228: Coding Rules - define rule for avoiding header inclusion list pollution
dbv [Sat, 14 Oct 2017 15:14:06 +0000 (18:14 +0300)]
0029229: Crash at Poly_Triangulation::Normal
Fixed creation of returning gp_Dir
emv [Fri, 22 Sep 2017 07:34:29 +0000 (10:34 +0300)]
0028763: Projection of a short line segment on a polar surface causes exception
Test case for the issue.
The problem has been fixed by the fix for the issue
0028150
kgv [Fri, 13 Oct 2017 12:52:51 +0000 (15:52 +0300)]
0029225: Visualization - Font_FTFont::AdvanceX() retrieves kerning value for incorrect characters pair
Fixed FT_Get_Kerning misuse within Font_FTFont::AdvanceX()/Font_FTFont::AdvanceY().
Font_FTFont::loadGlyph() has been corrected to not return TRUE
in case if method called with 0 argument second+ time.
emv [Fri, 6 Oct 2017 06:35:54 +0000 (09:35 +0300)]
0029188: Null shape is produced by 3D offset algorithm (mode="Complete", Join Type="Intersection")
The following improvements have been made in the 3D offset algorithm for mode "Complete" and Join type "Intersection":
- RemoveInsideFaces() - Removal of the invalid parts outside of the solids built from the splits of offset faces is now performed. It helps to avoid their rebuilding and speed-up the computation.
- FindVerticesToAvoid() - Strengthening the criteria for the vertices to be avoided in the new splits.
Test cases for the issue.
Adjustment of the test cases to current behavior.
apv [Thu, 12 Oct 2017 07:57:25 +0000 (10:57 +0300)]
Update of tests database
Test for
0021134: checkshape command does not return faulty shapes.
Test for
0021494: Intersection between cone and sphere fails
Test for
0022642: Refactoring of ShapeFix_Wire::FixIntersectingEdges
Test for
0022732: Reading a STEP file produces invalid shape
abv [Mon, 9 Oct 2017 10:19:20 +0000 (13:19 +0300)]
0029196: Tests - some test cases fail with Intel HD graphics
Test bugs vis bug26357 is revised to check colors in more robust way.
In tests bugs vis bug29091_*, size of produced file is checked to be within range of known valid sizes, rather than hard-coded (per-platform) exact sizes.
FPE signals are disabled for test bugs vis bug29127 to prevent exceptions cause by software OpenGl driver.
File data/occ/Box.brep is removed to avoid confusion with file box.brep in public data files used in tests.
Two additional non-alphabetic-order combinations of complex types are handled in RWStepAP214_ReadWriteModule.cxx
abv [Sat, 7 Oct 2017 16:26:38 +0000 (19:26 +0300)]
0029171: Foundation Classes - C signal handler does not work on MinGW
Setting signal handler is enabled in OSD::SetSignal() for MinGW (works only for SEH builds of MinGW, not for SJLJ builds).
Due to absence of function _set_se_translator(), handler is set using C signal() function and thus is called asynchronously.
Macro OCC_CONVERT_SIGNALS is enabled for MinGW build to support converting signals to C++ exceptions using long jumps (the same as on Linux).
Code raising exceptions in OSD::SetSignal() is corrected to use method Jump() instead of C++ throw.
kgv [Wed, 13 Sep 2017 15:12:57 +0000 (17:12 +0200)]
0029158: Visualization - suspicious pass-through of case labels in switch statements
MeshVS_Mesh::ComputeSelection() - fixed incorrect fall-through
from MeshVS_SMF_Mesh to MeshVS_SMF_Group.
kgv [Wed, 6 Sep 2017 08:14:53 +0000 (11:14 +0300)]
0029081: With Mingw-w64 Unicode Paths Do Not Work
OSD_OpenStream() now uses __gnu_cxx::stdio_filebuf extension for opening UNICODE files on MinGW when using C++ file streams.
Variant accepting filebuf returns bool (true if succeeded and false otherwise).
Checks of ofstream to be opened made via calls to low-level ofstream::rdbuf() are replaced by calls to ofstream::is_open(); state of the stream is also checked (to be good).
Unicode name used for test file in test bugs fclasses bug22125 is described (for possibility to check it).
kgv [Thu, 28 Sep 2017 18:29:22 +0000 (21:29 +0300)]
0029152: Coding Rules - eliminate GCC compiler warnings -Wmisleading-indentation when using MinGW
OSD_File::myFileHandle/myIO pair is now switched within class definition
instead of myFileHandle_is_only_for_Windows/myFileChannel_is_only_for_Linux macros.
OSD_Directory/OSD_Disk/OSD_File methods implementation of WinAPI/non-WinAPI
has been merged within .cxx file and reformatted.
Resolved several inconsistences on handling invalid input
between WinAPI/non-WinAPI implementations.
NCollection_Array1 is now used in several places instead of
raw memory allocation (HeapAlloc()/HeapFree()/new/delete).
TCollection_ExtendedString is used instead of StringCchCopyW.
Unused field OSD_Disk::myQuotaSize and not implemented methods OSD_Disk::*Quota*() have been removed.
Obsolete code fragment "for Visual Age compiler" is removed.
Macro __try is undefined before redefinition on MinGW to avoid warning.
apv [Mon, 2 Oct 2017 12:51:49 +0000 (15:51 +0300)]
Update of tests database
Test for
0028167: Fillet has strange form at its end
Test for
0028168: Exception is raised during Boolean operation
Test for
0028194: BRepMesh - Standard_OutOfRange exception on valid shape
Test for
0028200: Invalid topology of the general fuse result
Test for
0028216: Intersection of a face and a solid is broken up leading to empty result of Boolean common operation
Test for
0028245: Result of Cells Builder algorithm becomes invalid after removal of internal boundaries on faces
Test for
0028247: Effect of minSize parameter of BRepMesh_IncrementalMesh seems to be too strong
Test for
0028274: BOPAlgo_MakerVolume fails to create solid
Test for
0028279: Greater oscillations and higher degree of resulting B-Spline in cylinder-cylinder intersections in 7.1.0
Test for
0028354: Filleting destroys shape if the filleted edge touches a seam edge
Test for
0028366: BOP Common fails with solid and planar face
Test for
0028379: BRepMesh produces mangled mesh for a cone
Test for
0028388: Boolean common of simple face and solid results in empty compound
Test for
0028393: Boolean cut produce wrong result.
Test for
0028402: Modeling - calculation of properties of complex compounds is slow
Test for
0028406: High tolerances after boolean operation on OCCT 6.9.1
Test for
0028694: IGES reader produces too small edge covered by its vertices
Test for
0028719: Mesh - Display issue for special model
Test for
0028108: Sweep fails in "Right Corner" mode
Test for
0028696: Offset 2D algorithm produces micro edges
Test for
0028700: BRepBuilderAPI_Sewing produces too small edge covered by its vertices
Test for
0028722: Conversion of a spherical face to a spline produces an invalid shape
Test for
0028739: Draft on face fails
Test for
0028662: Data Exchange - Exception during reading large STEP file.
Test for
0028768: ShapeFix slighly corrupts the source face
Test for
0028485: Fuse of two shapes using gluing and non-destructive options gives invalid result
Test for
0028500: Artifact in shaded view of the shape
Test for
0028523: Fixshape reverses the orientation of the face
Test for
0028544: Big tolerance value is returned by Implicit-parametric algorithm
Test for
0028571: BRepOffsetAPI_MakeOffset build invalid wire
Test for
0028572: Wrong result of the mkface command
Test for
0028595: Shifting 2d curves for non-periodic surfaces leads to incorrect result.
Test for
0028596: Erroneous fillet
Test for
0028640: BRepBuilderAPI_Transform build invalid shape
Test for
0028656: 3d offset modifies the input shape
Test for
0000077: BUC60866. The BRepFill_Pipe fails.
Test for
0000078: BUC60875. Pipe is created incorrectly on two wires.
Test for
0000082: BUC60908. Incomplete section of shell by plane.
Test for
0000083: BUC60912. Section of simple BSpline surfaces is performed too slow.
Test for
0000862: GeomAPI_ExtremaCurveCurve fails on given curves
Test for
0002442: Error in BRepClass3d_SolidClassifier
Test for
0003936: Face on a surface of extrusion is extended after import to IGES
Test for
0005081: BRepOffset_MakeOffsetShape algorithm does not return valid result.
Test for
0005145: Wrong result of projection of a circle on a sphere.
Test for
0014846: ShapeFix_Wireframe::FixWireGaps() works wrong on a shape with seam edge
Test for
0016424: Exception in reading of attached IGES file
Test for
0010377: Incorrect fuse result when objects tangent by planar face
Test for
0013565: Incorrect result of Common operation
Test for
0013566: Incorrect result of Extrema between a large circle and a line
Test for
0024632: Artifacts during Boolean cut operation on neighboring parts
Test for
0005582: Impossible to make offset on the shape with degenerated edge
emv [Thu, 28 Sep 2017 08:02:05 +0000 (11:02 +0300)]
0029135: 3D Offset algorithm produces a NULL shape
UpdateValidEdges in BRepOffset_MakeOffset_1 - Perform the filtering of splits of the edges in two stages:
1. Separate filtering of the connected blocks using localized bounding edges taken only from the splits of offset faces from the block;
2. Combined treatment of the remaining splits using bounding edges from the splits of all offset faces.
abv [Tue, 19 Sep 2017 10:04:23 +0000 (13:04 +0300)]
0029124: Visualization, Tests - failures when tests are executed via Remote Desktop connection
Protection against accessing null pointer is added in OpenGl_VertexBuffer::Create().
In command vreadpixel OpenGl-related warnings are redirected to cout so that they do not contaminate the command output.
Test grid caf presentation is configured to ignore OpenGl-related warning messages.
Tests in grid tools are configured to report status SKIPPED if tools are not available (OCCT is built without Qt).
anv [Thu, 21 Sep 2017 12:15:12 +0000 (15:15 +0300)]
0029117: Adding translation of Multileader entity
Scaling of width of glyphs is added om Font_FTFont class.
Font "SimSan" is specified as fallback alias for font "NSimSan" (contains Chinese hieroglyphs).
gka [Tue, 3 Oct 2017 14:28:32 +0000 (17:28 +0300)]
0029029: Exception Raised with no Result during reading file 2033zsh1_1.stp
Static function stepstrcmp() in StepData_StepReaderData.cxx is replaced by plain strcmp() to have the full strings compared (stepstrcmp() returned true if one of strings was longer than the other but common part was equal).
Protection is added to avoid exception for cases when representation entities are NULL
imn [Wed, 12 Jul 2017 07:52:41 +0000 (10:52 +0300)]
0028245: Result of Cells Builder algorithm becomes invalid after removal of internal boundaries on faces
When removing internal boundaries between faces of the same material do it once for the whole shape, and at this keep boundaries between areas with different material.
kgv [Wed, 13 Sep 2017 15:12:57 +0000 (17:12 +0200)]
0029184: Visualization - DrawWindow::Save() fails when using WinCodec with PNG codec
DrawWindow::Save() now uses Image_Format_BGR instead of Image_Format_BGR32
for better compatibility with image encoders when dumping WinAPI bitmap.
Zia ul Azam [Wed, 13 Sep 2017 15:12:57 +0000 (17:12 +0200)]
0029109: Visualization, AIS_Trihedron - add option hiding arrows tips
Prs3d_DatumAspect::DrawDatumPart() now handles new flag ToDrawArrows().
vtrihedron - added new option -arrowTip.
Fixed misprint in command description -arrowscolor -> -arrowcolor.
ifv [Tue, 11 Jul 2017 07:15:28 +0000 (10:15 +0300)]
0028909: Algorithm of BO is stuck while fusing shell and edges
Approximation parameters: degmin, degmax, max number of segments, boundary condition, maximal distance of projecting are added in interface of classes ProjLib_ProjectedCurve, ProjLib_ComputeApprox,
ProjLib_ComputeApproxOnPolarSurface
Algorithm of Approx/Approx_ComputeCLine is modified in order to treat maximal number of segments allowed for cutting.
Algorithm of method BOPTools_AlgoTools2D::MakePCurveOnFace(...) is modified in order to manage cases with big edge tolerances.
Test case added
Some test cases were modified according to new behavior of algorithms
nbv [Tue, 3 Oct 2017 07:30:47 +0000 (10:30 +0300)]
0029176: Exception while projection 2D-point on 2D-line
DRAW-command "2dproj" has been changed. Now, it can return not only 2D-line as extrema but 2D-point.
Test case has been updated.
abv [Fri, 29 Sep 2017 08:18:11 +0000 (11:18 +0300)]
0029160: Coding - AppleCLang 9 compiler warning "binding dereferenced null pointer to reference has undefined behavior"
Avoid returning reference to null in AppDef_MyLineTool
oan [Fri, 15 Sep 2017 14:22:30 +0000 (17:22 +0300)]
0028931: Eliminate dependency from TBB in OSD_Parallel header
Implementation of methods OSD_Parallel::For() and ForEach() is moved to CXX files to avoid direct dependency of client code that uses OSD_Parallel on TBB headers, and necessity to link with TBB explicitly.
Runtime polymorphism (virtual methods) is used to hide implementation (TBB or threads-based).
msv [Fri, 29 Sep 2017 07:43:52 +0000 (10:43 +0300)]
0029159: Sewing fail when using a maximum tolerance
Force setting truly computed tolerance of the edge if BRepLib::SameParameter has put too large tolerance.
kgv [Tue, 26 Sep 2017 14:41:05 +0000 (17:41 +0300)]
0029147: Visualization - D3DHost_FrameBuffer::BindBuffer() fails on some Intel drivers
D3DHost_FrameBuffer::BindBuffer() now implicitly detaches Depth+Stencil texture in case of driver failure.
D3DHost_View::d3dCreateRenderTarget() now does not request Depth+Stencil texture by default.
kgv [Mon, 25 Sep 2017 12:54:45 +0000 (15:54 +0300)]
0029138: Visualization - D3DHost_FrameBuffer should provide software fallback when WGL_NV_DX_interop is unavailable
D3DHost_FrameBuffer now provides fallback code copying OpenGL FBO content into D3D surface (slow).
OpenGl_FrameBuffer::BufferDump() - FBO dump implementation has been moved from OpenGl_Workspace::BufferDump().
kgv [Mon, 25 Sep 2017 12:21:11 +0000 (15:21 +0300)]
0029137: Visualization - D3DHost_FrameBuffer does not release Depth texture and FBO index
abv [Sat, 30 Sep 2017 18:35:05 +0000 (21:35 +0300)]
0029170: GCC 7.1 warnings -Wstrict-aliasing in Graphic3d_ArrayOfPrimitives.hxx
Methods Graphic3d_ArrayOfPrimitives::SetVertexColor() accepting color as three double rgb values and Graphic3d_Vec4ub object are refactored to avoid using reinterpret_cast between pointers to complex types.
Similar correction is made in ViewerTest_ObjectCommands.cxx (static function VDrawSphere).
kgv [Sat, 30 Sep 2017 16:52:10 +0000 (19:52 +0300)]
0029169: Configuration - fix compilation with undefined UNICODE on Windows
Eliminated usage of TEXT macros, usage of OSVERSIONINFO instead of OSVERSIONINFOW.
LoadIcon/LoadCursor are now used instead of LoadIconW/LoadCursorW
when passing macros to standard resources (which depend on UNICODE flag).
abv [Fri, 29 Sep 2017 16:04:13 +0000 (19:04 +0300)]
0029165: Visualization - misuse of enumeration in Prs3d_DatumAspect
Methods SetDrawFirstAndSecondAxis() and SetDrawThirdAxis() of the class Prs3d_DatumAspect are corrected to ensure that myAxis may be set only to valid values of the enum, and avoid unsafe operations.
abv [Fri, 29 Sep 2017 15:35:03 +0000 (18:35 +0300)]
0029164: GCC 7.1 compiler warnings -Wmaybe-uninitialized in gp_XYZ and siblings
Code is corrected to avoid local variables of reference type pointing to fields of temporary objects.
abv [Thu, 28 Sep 2017 07:26:47 +0000 (10:26 +0300)]
0029151: GCC 7.1 warnings "this statement may fall through" [-Wimplicit-fallthrough=]
New macro Standard_FALLTHROUGH is defined for use in a switch statement immediately before a case label, if code associated with the previous case label may fall through to that
next label (i.e. does not end with "break" or "return" etc.).
This macro indicates that the fall through is intentional and should not be diagnosed by a compiler that warns on fallthrough.
The macro is inserted in places that currently generate such warning message and where fallthrough is intentional.
Doxygen comments are provided for this and other macros in Standard_Macro.hxx.
kgv [Thu, 28 Sep 2017 20:48:55 +0000 (23:48 +0300)]
0029156: Coding Rules - eliminate deprecation compiler warnings when targeting macOS 10.12
kgv [Tue, 19 Sep 2017 07:02:37 +0000 (10:02 +0300)]
0029062: Visualization, SelectMgr_ViewerSelector - add NULL-check within ::checkOverlap() method
anv [Thu, 29 Dec 2016 08:48:16 +0000 (11:48 +0300)]
0028188: Improving layer color storage mechanism for DXF Import/Export
Attribute ColorByLayer was added for shapes that should be colored by the color of their layer or, if it's absent, by the parent component's layer color.
Fixing inconsistency of iterating through the map of Styles
Improving ColorByLayer mechanism
Fix for Map/IndexedMad differences.
Renaming according to convention of naming collection typedefs
ski [Fri, 15 Sep 2017 16:10:54 +0000 (19:10 +0300)]
0029118: Incorrect generation of reference documentation for modules
Generation of reference documentation for modules was corrected.
snn [Fri, 22 Sep 2017 08:08:30 +0000 (11:08 +0300)]
0029119: Documentation for PMI in XCAF
Documentation is added to the XDE part of the User Guide for GD&T, Clipping planes and Saved view components.
nbv [Fri, 22 Sep 2017 11:05:01 +0000 (14:05 +0300)]
0028764: [Regression to 7.0] Intersection of faces gives exception in debug mode
Some point were incorrectly removed from the Walking-line.
In the current fix, new method IntWalk_PWalking::RemoveAPoint(...) has been added and implemented in order to provide safe removing.
So, now methods AddAPoint(...) and RemoveAPoint(...) are recommended to use for work with the Walking-line.
kgv [Sun, 10 Sep 2017 18:24:56 +0000 (21:24 +0300)]
0028987: Visualization, SelectMgr_SelectableObject - move out iterator from object
Added method SelectMgr_SelectableObject::Selections() and depreacted methods
Init(), More(), Next() and CurrentSelection().
Added method SelectMgr_Selection::Entities() and depreacted methods
Init(), More(), Next() and Sensitivity().
SelectMgr_SelectableObject::myAssemblyOwner has been moved to AIS_MultipleConnectedInteractive.
SelectMgr_SelectableObject::Selection() now returns NULL handle for not found selection.
SelectMgr_SelectableObject::HasSelection() is no more virtual and just retuns !Selection().IsNull().
SelectMgr_SelectionManager::mySelectors map is now declared using proper
key type Handle(SelectMgr_ViewerSelector) instead of Handle(Standard_Transient).
abv [Fri, 15 Sep 2017 05:35:07 +0000 (08:35 +0300)]
0029112: Visualization - compilation fails on Ubuntu with libavutil 54.x (FFmpeg 2.7.6)
Offending macro is undefined to allow compilation with libavutil 54.x
emv [Fri, 15 Sep 2017 06:31:40 +0000 (09:31 +0300)]
0029073: Regression: General Cut produces invalid shape
Boolean Operations:
1. Face/Face intersection post treatment - Unify vertices put on the section curves, which were rejected as existing ones, with the vertices of edges by which these section curves have been rejected.
2. Extend Warnings Reporting system of Boolean operations with the new warnings:
- BOPAlgo_AlertIntersectionOfPairOfShapesFailed - to be added when the intersection of pair of sub-shapes of the arguments has failed;
- BOPAlgo_AlertBuildingPCurveFailed - to be added when the building of the 2D curve of the edge on face has failed;
- BOPAlgo_AlertAcquiredSelfIntersection - to be added when the positioning and tolerances of the arguments leads to creation of self-interfered shapes.
These new warnings allow completing the operation even if intersection of some of the sub-shapes or building of some of the PCurves has failed. Moreover, they allow getting the pairs of sub-shapes on which the intersection/projection has failed, providing the user ability to analyze the intersection results.
Note that if some of these warnings appear, the result of the operation should be carefully analyzed for validity.
3. Print messages for the Warnings/Errors met during checking of the shape on self-intersection ("bopcheck" command).
kgv [Sun, 10 Sep 2017 18:24:56 +0000 (21:24 +0300)]
0027869: Visualization - AIS_ConnectedInteractive does not support exact HLR mode
AIS_ConnectedInteractive now shares HLR computation code with AIS_Shape.
BRepTools_WireExplorer::Orientation() now returns TopAbs_FORWARD
instead of throwing exception in case of infinite Edge without vertices.
StdSelect_BRepSelectionTool::GetSensitiveForFace() now creates Select3D_SensitiveCurve
from 2 points in case of infinite Edge instead of Select3D_SensitiveFace.
abv [Tue, 15 Aug 2017 13:04:45 +0000 (16:04 +0300)]
0028452: VIS - MSVC 14 compiler warnings
Includes of VTK headers are wrapped in #pragmas to ensure that MSVC warning messages disabled by VTK headers are still enabled for OCCT code
kgv [Wed, 20 Sep 2017 11:28:26 +0000 (14:28 +0300)]
0029127: Visualization - V3d_View::ToPixMap() crashes on tiled rendering without FBO
Fixed out-of-memory writing within fallback View dump mode.
kgv [Tue, 19 Sep 2017 13:53:39 +0000 (16:53 +0300)]
0029122: Visualization - improve Font_BRepFont to handle one-line-fonts
Font_SystemFont - added a new property SingleStrokeFont().
Font_BRepFont::renderGlyph() has been extended to not close contours
when flag SingleStrokeFont() has been set.
abv [Wed, 13 Sep 2017 13:49:04 +0000 (16:49 +0300)]
0029107: Visualization - SelectMgr_FrustumBuilder constructor without arguments is not exported
Standard_EXPORT is added
kgv [Sun, 10 Sep 2017 14:06:19 +0000 (17:06 +0300)]
0028069: Visualization, TKOpenGl - handle flat shading model within GLSL programs
kgv [Tue, 19 Sep 2017 09:53:15 +0000 (12:53 +0300)]
0029125: Visualization, OpenGl_Text - fix access violation within OpenGL1.1 context
OpenGl_Context::DiagnosticInformation() - added OpenGL version check before retrieving GL_SHADING_LANGUAGE_VERSION string.
nbv [Mon, 18 Sep 2017 14:23:44 +0000 (17:23 +0300)]
0028150: Exception is raised during Boolean operation
ProjLib_ComputeApproxOnPolarSurface::BuildInitialCurve2d - Using the correct number of points (computed in GCPnts_QuasiUniformAbscissa class) for creation of the initial curve.