emv [Mon, 5 Dec 2016 12:52:36 +0000 (15:52 +0300)]
0028187: Add possibility to avoid creation of Internal parts in the result of Volume maker algorithm
1. The possibility to prevent addition of internal parts has been added into the following algorithms:
- BOPAlgo_BuilderFace;
- BOPAlgo_BuilderSolid;
- BOPAlgo_MakerVolume.
Setting the option to avoid internal parts for MakerVolume algorithm guarantees that the result solids
will be manifold and not contain any internal parts. But it does not prevent from occurrence
of the internal edges or vertices in the faces.
2. The Set/Get methods of the BOPAlgo_BuilderArea class have been made inline.
3. Draw command mkvolume has been updated to take into account the new option.
4. BRepOffset_MakeOffset::BuildShellsCompleteInter() has been modified to use the new option of BOPAlgo_MakerVolume
to speed up the construction of the final result solid.
5. Documentation has been updated with new section dedicated to BOPAlgo_MakerVolume algorithm.
6. Test case for the issue.
kgv [Mon, 5 Dec 2016 10:53:37 +0000 (13:53 +0300)]
0028181: Documentation - update porting note with missing information
Added information about removed classes StdPrs_WFDeflectionShape,
Prs3d_WFShape, StdPrs_ToolShadedShape and removed property
AIS_InteractiveObject::SelectionMode().
emv [Wed, 30 Nov 2016 10:29:37 +0000 (13:29 +0300)]
0028165: Improve performance of Boolean Operations
1. Unification of the usage of the BRepAdaptor_Surface in Boolean Operations algorithm.
For each face when it is necessary the Adaptor is initialized only once and stored in Context.
For that purpose the new IntTools_Context::SurfaceAdaptor(const TopoDS_Face&) method has been implemented.
To provide possibility to take the Adaptor from the context, the context has been added as
a parameter in following methods:
BOPTools_AlgoTools::MakePCurve()
BOPTools_AlgoTools::Sence()
BOPTools_AlgoTools2D::BuildPCurveForEdgeOnFace()
BOPTools_AlgoTools2D::PointOnSurface
BOPTools_AlgoTools2D::CurveOnSurface
BOPTools_AlgoTools2D::AdjustPCurveOnFace
BOPTools_AlgoTools2D::Make2D
BOPTools_AlgoTools2D::MakePCurveOnFace
BOPTools_AlgoTools3D::GetNormalToFaceOnEdge
It is also possible now to pass the context into BOPAlgo_WireSplitter algorithm.
Also, the new IntTools_Context::UVBounds(const TopoDS_Face&) method
has been implemented to get the UV bounds of a face.
2. Additional improvement is a calculation of reduced intersection range only for the intersection
type VERTEX during computation of Edge/Face interference.
3. The methods IntTools_EdgeFace::Prepare() and IntTools_EdgeFace::FindProjectableRoot()
and the fields IntTools_EdgeFace::myProjectableRanges and IntTools_EdgeFace::myFClass2d
have been removed as obsolete.
4. Test cases for the issue.
emv [Thu, 8 Dec 2016 13:49:29 +0000 (16:49 +0300)]
0027878: Development of the Gluing operations based on the new Boolean component
The Gluing operation is an additional option for the algorithms in the Boolean Component
such as General Fuse, Boolean operations, Section operation, Maker Volume and Cells Builder algorithms.
The Gluing options have been designed to speed up the computation of the interference among arguments of the operations on special cases,
in which the arguments may be overlapping but do not have real intersections between their sub-shapes.
This option cannot be used on the shapes having real intersections, like intersection vertex between edges,
or intersection vertex between edge and a face or intersection line between faces.
The Gluing option is an enumeration implemented in BOPAlgo_GlueEnum.hxx. There are following items in the enum:
* BOPAlgo_GlueOff - default value for the algorithms, Gluing is switched off;
* BOPAlgo_GlueShift - Glue option for shapes with partial coincidence;
* BOPAlgo_GlueFull - Glue option for shapes with full coincidence.
For setting the Gluing options for the algorithm it is just necessary to call the SetGlue(BOPAlgo_GlueEnum) method with appropriate Glue value.
For using this option in DRAW the command bglue has been implemented:
* 0 - default value, Gluing is off;
* 1 - for partial coincidence;
* 2 - for full coincidence
Elimination of the warnings.
dbp [Fri, 18 Nov 2016 08:13:29 +0000 (11:13 +0300)]
0028126: Visualization, Path tracing - Provide ability to use two-sided scattering models
aka [Thu, 8 Dec 2016 13:33:47 +0000 (16:33 +0300)]
0027434: Wrong result of classification of the point in "infinity"
In the case of infinite point due to not enough machine precision the distance from the point to each edge of the face is computed the same, and the algorithm cannot correctly select the nearest edge. To solve this problem checking of point was added, if the point is located too far from the bounding box of the face, then it will be replaced with another point located on the line between the point and the center of the bounding box.
The new point has the same state as initial one but its state can be resolved without ambiguity.
Corrections in CheckPoint method
Small correction of test case for issue CR27434
aml [Thu, 8 Dec 2016 13:30:24 +0000 (16:30 +0300)]
0027954: Create topology-preserving offset computation algorithm
New topology-preserving offset algorithm has been added. It allows to construct offset shape of build solid.
test cases have been added.
Documentation has been updated to be up to date.
Minor corrections.
Grid is renamed for simplification purposes.
Old constructors are restored with Standard_DEPRECATED macros.
emv [Fri, 18 Nov 2016 07:06:50 +0000 (10:06 +0300)]
0028163: 3D Offset algorithm produces incorrect result on attached shape in mode Complete Intersection
1. Correct building of the lists of intersection faces connected to the same vertex.
2. For the artificially invalid cases with only one invalid face avoid usage of the edges having same origins as invalid edges.
3. Test cases for the issue.
4. Test cases offset shape_type_i_c XM1, ZW*,ZX*,ZY* have been modified to provide more clear result.
5. TODO statements have been removed from the test case offset shape_type_i_c XE6 as it is OK.
6. Test case offset shape_type_i_c ZZ2 is improvement.
anv [Thu, 8 Dec 2016 13:24:34 +0000 (16:24 +0300)]
0026026: XtControl_Reader hangs when processing specific data
Small fix for a specific case (was missing).
aka [Thu, 8 Dec 2016 13:22:13 +0000 (16:22 +0300)]
0027674: BRepOffsetAPI_ThruSections make invalid shape if sections are connected at ends
The edge which will be created between same vertexes should be degenerated and without 3d curve.
Small correction of test case for issue CR27674
apn [Thu, 8 Dec 2016 13:19:55 +0000 (16:19 +0300)]
Change OCCT version to 7.1.1 and define OCC_VERSION_DEVELOPMENT to "dev"
msv [Fri, 25 Nov 2016 09:40:25 +0000 (12:40 +0300)]
0027033: Modeling -- ensure stable result of area calculation
The method BRepGProp_Face::LKnots has been corrected to make proper initialization of the output data for the case of a circle.
Added test case bugs/modalg_6/bug27033
ski [Wed, 23 Nov 2016 07:24:20 +0000 (10:24 +0300)]
0025362: Samples - Conversion to B-Spline doesn't show bspline surface on Windows 8
Added constants WM_MOUSEFIRST and WM_PAINT in WaitForInput method for correct handling of system messages.
apn [Thu, 24 Nov 2016 09:00:58 +0000 (12:00 +0300)]
Fix warning on vc14
apn [Thu, 24 Nov 2016 08:57:08 +0000 (11:57 +0300)]
Modify test case bugs/mesh/bug28118
apn [Wed, 23 Nov 2016 16:35:15 +0000 (19:35 +0300)]
Incrementation of OCCT version up to 7.1.0
apn [Wed, 23 Nov 2016 16:33:47 +0000 (19:33 +0300)]
Modify test cases according using imagedir folder for saving tmp files
gka [Wed, 23 Nov 2016 16:31:02 +0000 (19:31 +0300)]
0028118: Mesh generation hangs then crashes
Protection against hangs of mesh and crash(made by epa)
Added test case bugs/mesh/bug28118
Tests mesh* standard_* W7 are corrected (TODO removed)
apn [Wed, 23 Nov 2016 15:07:21 +0000 (18:07 +0300)]
0026450: Boolean operation is running endless
Added test case bugs/modalg_6/bug26450
kgv [Wed, 23 Nov 2016 12:53:48 +0000 (15:53 +0300)]
0028147: Data Exchange - NULL dereference while reading color from STEP file
StepVisual_StyledItem::Item() now does not call IsKind() on NULL object.
Add several checks for NULL to import/export.
Add test case bugs/step/bug28147
msv [Mon, 21 Nov 2016 08:24:23 +0000 (11:24 +0300)]
0025920: BRepAlgoAPI_Fuse makes invalid result
The command OCC426 for test case bugs modalg_2 bug426 has been modified in order to make the test passed. The modification concerns only the old Boolean operation branch (BRepAlgo_Fuse).
gka [Tue, 22 Nov 2016 13:20:36 +0000 (16:20 +0300)]
0028143: In the method ShapeFix_Edge::FixAddPCurve initialized by face location of face is not taking into account.
Class ShapeAnalysis::Surface is initialized by transformed surface in the method
ShapeFix_Edge::FixAddPCurve (const TopoDS_Edge& edge,const TopoDS_Face& face, const Standard_Boolean isSeam, const Standard_Real prec) in the case when face has location.
ski [Fri, 11 Nov 2016 14:00:25 +0000 (17:00 +0300)]
0028077: Add option for genproj to generate UWP projects
Ability to generate UWP solution was added to genproj command, applied when VC version set to "vc14-uwp".
Environment variables are used to find installed Microsoft SDKs.
Visual Studio project option "Use precompiled headers" is set to "Not Using" by default.
Character set option of VS project Unicode is used instead of preprocessor definitions for UWP projects.
mkv [Tue, 22 Nov 2016 16:22:56 +0000 (19:22 +0300)]
0028146: Data files with the same content in test cases
Names of used shapes were corrected in test cases
aiv [Mon, 21 Nov 2016 15:23:28 +0000 (18:23 +0300)]
0028038: Incorrect documentation generated for "user guides/BRep Format"
References to external MathJax.js library were changed from HTTP to HTTPS alternative.
ski [Fri, 18 Nov 2016 11:31:58 +0000 (14:31 +0300)]
0028105: HLR rendering crash in MFC sample
User_Cylinder class was updated according to work as single object in Prs3d_Presentation.
kgv [Fri, 18 Nov 2016 13:00:59 +0000 (16:00 +0300)]
0028127: Visualization - transparent object breaks Z-Layer depth buffer clear
OpenGl_LayerList::Render() now calls glDepthMask(GL_TRUE) before clearing depth buffer.
Depth buffer is now cleared even if ZLayer with this command has no structures.
szy [Mon, 21 Nov 2016 11:14:03 +0000 (14:14 +0300)]
0028134: TDataStd_Name attribute gets null ID.
'myID' field is initialized in constructor now.
emv [Mon, 14 Nov 2016 07:19:15 +0000 (10:19 +0300)]
0028046: Incomplete result of offset operation in mode complete intersection
1. Special usage of the common edges not belonging to any invalidity while rebuilding the invalid faces (method IntersectFaces() in BRepOffset_MakeOffset_1.cxx).
Such edges could only be extended to the valid faces boundaries, thus could only split the face and not create any new part.
2. Test cases for the issue.
razmyslovich [Thu, 8 Sep 2016 08:09:12 +0000 (10:09 +0200)]
0027849: ResourceManager path computations fail for the folders containing dots
Treatment of paths in Resource_Manager is corrected to handle properly paths with dots inside.
Extraction of extension from path in DOS mode when working on Linux is corrected in OSD_Path.
Test case added.
ysn [Wed, 23 Nov 2016 09:57:32 +0000 (12:57 +0300)]
0025560: Documentation - describe changes in AIS_InteractiveConnect and AIS_MultipleConnected introduced within 6.8.0
New section about scene-graph hierarchy and instancing.
Proofreading of extended section about z-layers.
Removal of obsolete information.
Remarks taken into account.
abv [Sat, 19 Nov 2016 14:21:59 +0000 (17:21 +0300)]
0028130: Spelling error in description of class BOPAlgo_Section
Spelling error is corrected
abk [Mon, 14 Nov 2016 15:08:44 +0000 (18:08 +0300)]
0028103: Foundation Classes - extend NCollection_Map to check whether two given maps are intersected
Mehtod HasIntersection added in NCollection_Map to check whether two given maps contain at least one same item.
'Draw' command and test to check the method were created.
dbp [Thu, 17 Nov 2016 15:51:38 +0000 (18:51 +0300)]
0027256: Visualization, Path Tracing - add support of alpha-channel of texture
Regenerate resource files.
dbp [Wed, 16 Nov 2016 12:44:56 +0000 (15:44 +0300)]
0028114: Visualization, Path tracing - Make path tracing mode interactive in high resolutions
kgv [Thu, 17 Nov 2016 12:51:44 +0000 (15:51 +0300)]
0028101: Visualization, Select3D_SensitiveSet - fix NULL dereference on re-adding the same sensitivity
Select3D_SensitiveSet now stores BVH_PrimitiveSet as class field (no dynamic allocation),
and BVH_PrimitiveSet subclass now stores raw pointer to Select3D_SensitiveSet (no smart pointer).
Select3D_BVHPrimitiveContent definition has been moved into Select3D_SensitiveSet
class definition to avoid confusion.
Unused field Select3D_SensitiveSet::myIsLeftChildQueuedFirst has been removed.
msv [Thu, 17 Nov 2016 12:50:16 +0000 (15:50 +0300)]
0027992: Modeling Algorithms - Extrema_ExtPS crashes on face without geometric surface
The algorithm BRepExtrema_DistShapeShape has been protected against exceptions when non-geometric shape data is given on input, like a face containing triangulation only or an edge containing polygon only. Such faces/edges are ignored by the algorithm.
BRepGProps::VolumeProperties() now ignores faces without geometric surface to avoid access violation.
dbp [Wed, 16 Nov 2016 14:47:07 +0000 (17:47 +0300)]
0028115: Visualization, Ray tracing - Fix crash on NVIDIA GPUs with driver version 373.06 when window is resized
kgv [Thu, 17 Nov 2016 12:39:52 +0000 (15:39 +0300)]
0028095: Draw Harness, ViewerTest - use RGBA format instead of BGRA within vreadpixel
OpenGl_Workspace::BufferDump() now implicitly converts RGBA dump
into requested BGR, BGRA and RGB image.
DRAW command dversion is improved to report OpenGL variant used (desktop or ES); reporting of version of MSVC is corrected for VC14 and above; reporting of HAVE_OPENCL option is removed.
Usage of command vdump is corrected in some tests to specify extension .png for an image file.
Compiler warning is eliminated in OpenGl_Text.cxx (OpenGL ES mode only).
kgv [Wed, 13 Aug 2014 06:19:55 +0000 (10:19 +0400)]
0025144: Coding rules - consider rules for formatting pointers and constants placement in expressions
gka [Fri, 11 Nov 2016 14:08:08 +0000 (17:08 +0300)]
0028094: Shape obtained after DRAW command "splitshape" has unnecessary high tolerance.
Check of the gap between ends of the p-curves having common vertex in the parametric space of face similar as in the class BRepCheck_Wire was added.
Check that face lies on the periodic surface was added.
Added check between ends of 2D curves in the 3D space and vertex the same which used in the BRepCheck_Wire::SelfIntersect
Test case for issue CR28094 has been created.
kgv [Fri, 11 Nov 2016 15:20:49 +0000 (18:20 +0300)]
0028093: Visualization - access violation on removal of dynamic highlighting after device loss
OpenGl_Layer::Remove() now tries to remove object from myAlwaysRenderedMap
if it was not removed from other groups.
ysn [Wed, 16 Nov 2016 09:07:55 +0000 (12:07 +0300)]
0028079: Proofreading of updates section and possible documentation changes since 7.0
Added some content from the bugtracker to porting notes.
Reviewed some other recent changes.
ysn [Wed, 16 Nov 2016 14:08:24 +0000 (17:08 +0300)]
0027828: Reference documentation of AIS_Trihedron contains invalid information about default size.
Fixed the description of AIS_Trihedron
kgv [Mon, 14 Nov 2016 10:14:04 +0000 (13:14 +0300)]
0028099: Visualization, OpenGl_Text - handle DIMENSION and SUBTITLE styles within Core Profile
OpenGl_Text now creates VBO for drawing background rectangle.
abv [Thu, 17 Nov 2016 12:14:19 +0000 (15:14 +0300)]
0028096: VC14 compiler warnings of 7.1.0.beta
Warnings are eliminated
// minor corrections in headers
msv [Fri, 11 Nov 2016 12:49:41 +0000 (15:49 +0300)]
0028092: Wrong statement in reference manual for Geom_ToroidalSurface::Bounds
Description has been corrected.
vpa [Wed, 9 Nov 2016 14:55:51 +0000 (17:55 +0300)]
0028061: Samples - Highlighting of any object with "Hidden On" option leads to crash in mfc Modeling
Graphic3d_Structure::Highlight() does not call UnHighlight() anymore.
msv [Wed, 9 Nov 2016 15:27:47 +0000 (18:27 +0300)]
0028081: Fix regression in HLR introduced by the fix for 28053
The whole piece of the walking line between two vertices is no more checked for having length greater than Precision::Confusion(). Instead, only full duplicate points (comparing with gp::Resolution()) are removed, allowing the resulting line have any non-null length.
The test bugs modalg_6 bug27720_5 has been reverted to its original state.
nbv [Wed, 9 Nov 2016 08:22:12 +0000 (11:22 +0300)]
0028076: Test bugs moddata_2 bug469 fails when FPE are enabled
The reason of FPE exception has been eliminated.
kgv [Wed, 9 Nov 2016 13:20:32 +0000 (16:20 +0300)]
0028056: Draw Harness, ViewerTest - correct vanimation command to produce stable timestamp on seek
gka [Thu, 17 Nov 2016 11:44:59 +0000 (14:44 +0300)]
0027575: Reading STEP file gives an empty result
Exception is raised during translation BSpline curve having only one unique knot.
Protection for such case was added
Added protection against exception during reading BSpline curve with number of control points equal to 0
Added protection against exception due to using null binder during writing XDE document
Test case for issue #27575
abv [Tue, 8 Nov 2016 02:08:22 +0000 (05:08 +0300)]
0023639: Exception on attempt to save to XmlOcaf format
Variant FULL is removed from the options of DRAW command pload; ALL can be used in all cases
emv [Mon, 7 Nov 2016 22:09:33 +0000 (01:09 +0300)]
0027428: DRAW command "bsection" did not built section line between two faces (one face based on the plane)
Adjusting test case for the issue.
apn [Wed, 9 Nov 2016 09:12:43 +0000 (12:12 +0300)]
Incrementing OCCT version up to 7.1.0 beta
apn [Wed, 9 Nov 2016 09:08:50 +0000 (12:08 +0300)]
Update test case offset/shape_type_i_c/Q9 according to new behavior
apn [Wed, 9 Nov 2016 09:07:07 +0000 (12:07 +0300)]
Updated dependencies in mfc OCAF sample
kgv [Wed, 2 Nov 2016 09:56:30 +0000 (12:56 +0300)]
0028040: Foundation Classes, Message_Printer - handle Standard_CString messages as UTF-8
ysn [Thu, 3 Nov 2016 11:29:56 +0000 (14:29 +0300)]
0027678: Draw User's guide contains wrong example for for-loop
Signs have been restored in draw UG as per its DOC version.
kgv [Tue, 8 Nov 2016 07:14:49 +0000 (10:14 +0300)]
0028062: Samples - Shading model functionality does not work in mfc Viewer3d
Unsupported shading models have been removed from the sample dialog.
apn [Tue, 8 Nov 2016 14:12:48 +0000 (17:12 +0300)]
0027923: Environment variable INSTALL_DIR_LAYOUT is not documented
Added description of INSTALL_DIR_LAYOUT variable
szy [Thu, 27 Oct 2016 14:55:43 +0000 (17:55 +0300)]
0027932: Improvement of standard attributes usability.
OCAF attributes TDataStd_AsciiString, TDataStd_Integer, TDataStd_Name, TDataStd_Real are extended by possibility to use custom GUID.
Now multiple attributes of any of these types can be placed at the same label using different user-defined GUIDs.
For this new "Set" methods were added into each attribute, which takes this custom GUID as an argument.
Other aspects of management of attributes on labels remain the same.
Version number of persistent OCAF documents is incremented.
However, the attributes are stored in the same way unless non-standard GUID is used for particular attribute.
Previously saved documents are fully supported, but the new documents with this extension used will be non-readable by the previous version of OCAF libraries.
kgv [Tue, 1 Nov 2016 18:36:24 +0000 (21:36 +0300)]
0028036: Visualization, AIS_ColoredShape - handle correctly nested compounds within Shaded display mode
AIS_ColoredShape::Compute() now parses nested compounds in two passes
to handle complex cases with compounds used for grouping styles.
msv [Mon, 7 Nov 2016 12:49:54 +0000 (15:49 +0300)]
0028053: Regressions in HLR when FPE signals are enabled
Protect Contap_Contour from creation of null-length curves.
nbv [Mon, 7 Nov 2016 15:48:37 +0000 (18:48 +0300)]
0028054: Regression: Class BRepProj_Projection gives invalid result after projection edge based on the line on the conical surface
Problem of projection of line on the cone in the special case when starting point of the line coincides with the cone apex is fixed (by shifting this point along the source line).
kgv [Tue, 8 Nov 2016 09:30:31 +0000 (12:30 +0300)]
0028072: Samples - remove deprecated vector export from MFC sample
ski [Tue, 8 Nov 2016 14:26:23 +0000 (17:26 +0300)]
0028068: Samples - Add dimension functionality shows incorrect tip for an Edge in mfc Viewer3d
Warning message was updated to show actual information.
Additional checking of type of shape was added to prevent exceptions for Add Dimension functionality.
abv [Tue, 8 Nov 2016 04:22:06 +0000 (07:22 +0300)]
0028066: Samples - mfc ocaf sample could not read/save any document without environment variables
Persistence libs are loaded using DefineFormat() in OCAF sample
msv [Mon, 7 Nov 2016 17:05:58 +0000 (20:05 +0300)]
0028065: [Regression to 7.0] The method HLRAppli_ReflectLines::GetResult must be const
ski [Tue, 8 Nov 2016 11:57:46 +0000 (14:57 +0300)]
0028064: Samples - Raytracing does not work in Qt samples
QAction signal activated() was changed to signal triggered() to support Qt5.
kgv [Tue, 8 Nov 2016 09:30:31 +0000 (12:30 +0300)]
0028060: Samples - Objects in Geometry/Viewer2d have incorrect color
Broken custom presentations Sample2D_Text and ISession_Text
have been replaced by AIS_TextLabel.
ISession2D_Curve::Compute() - fixed defining the group without presentation aspects.
GeomSources - fixed assigning custom attributes.
msv [Tue, 8 Nov 2016 15:43:09 +0000 (18:43 +0300)]
0028059: Correction of upgrade guide for 7.1
Correction of upgrade guide for 7.1
// minor corrections
emv [Thu, 3 Nov 2016 09:58:25 +0000 (12:58 +0300)]
0028050: Empty result of offset operation in mode complete join type intersection
1. BRepOffset_Inter3d::ConnexIntByInt
Create unique offset edge for each localized part shared between pair of faces of the input shape.
2. Test cases for the issue.
emv [Tue, 8 Nov 2016 15:04:28 +0000 (18:04 +0300)]
0026917: 3D Offset algorithm produces incorrect result
Extension on the 3D Offset algorithm (Mode="Complete", Join Type = "Intersection")
for colliding cases to add support for new configurations of the shapes.
In the previous approach the result of the offset operation was build from
the offset faces using MakerVolume algorithm, without checking of the validity of these faces.
The new extension is based on this approach, but now the offset faces are being checked
on invalidity and rebuild in case of any. This allows (in case of successful rebuilding) to avoid creation
of the unforeseen parts such as dangling parts, spikes, inverted faces in the result of offset operation.
The main criteria for the validity of the faces is the coincidence of the normal
direction of the offset face with the normal direction of the original face.
Check for removal of invalid faces has been removed as obsolete.
BRepOffset_Inter2D: Avoid excess trimming of the edges due to coincidence with other edges.
BRepOffset_Inter3D: Careful treatment of the intersection of the faces connected only through vertices.
Eliminating the compiler warning.
Small corrections of test cases for issue CR26917
dbp [Thu, 20 Oct 2016 09:10:47 +0000 (12:10 +0300)]
0027974: Visualization, ray tracing - Improve ray tracing engine
* Multiple importance sampling for path tracing
* Improved light sources sampling (better handling several light sources)
* Fixed issues in light source intersection (light distance is taken into account)
* Add new TCL sample - OCCT Ball model for demonstrating physically-based materials
* Fix potential issue on NVIDIA GPUs ("Error: Failed to upload light source buffer")
* Path tracing materials reviewed; directional light source was smoother by default
msv [Tue, 8 Nov 2016 12:20:42 +0000 (15:20 +0300)]
0026738: Make Boolean operations safely treating arguments when running with fuzzy option
When fuzzy option is in force prevent increasing tolerance of input shapes. Instead pass increased by fuzzy value the tolerances of sub-shapes everywhere where it is needed by intersection algorithms.
The following changes in API have been made:
- The methods SetFuzzyValue and FuzzyValue have been moved from the classes BOPAlgo_ArgumentAnalyzer, BOPAlgo_Builder, and BOPAlgo_PaveFiller to the base class BOPAlgo_Algo.
- The public method BOPDS_DS::VerticesOnIn has been renamed to SubShapesOnIn, and the new output parameter theCommonPB has been added.
- In BOPTools_AlgoTools, a new argument "theFuzzyValue" has been added in the methods ComputeVV and AreFacesSameDomain.
- In IntTools_Context, a new argument "theFuzzyValue" has been added in the methods ComputeVE and ComputeVF.
- The methods SetFuzzyValue and FuzzyValue have been added in the classes IntTools_EdgeEdge, IntTools_FaceFace.
- In the class IntTools_EdgeFace, the methods SetTolE, SetTolF, TolE, TolF have been removed, and the methods SetFuzzyValue, FuzzyValue have been added.
- The new argument "theTol" has been added in the method IntTools_WLineTool::DecompositionOfWLine.
Some improvements in algorithms have been made during fighting with regressions:
- Correct initialization of pave blocks for degenerated edges.
- In BOPAlgo_PaveFiller::MakeBlocks(), filter out paves on intersection curve that were put on the curve accidentally due to wide range of E-F intersection vertex.
- In the method IntTools_Tools::ComputeTolerance the margin added to the computed tolerance has been increased up to 0.001%.
- The method BOPAlgo_PaveFiller::PutPaveOnCurve has been corrected in order to use the original vertex tolerance instead of the value increased during putting it on other curves.
- The new method BOPDS_PaveBlock::RemoveExtPave has been added.
- The vertex tolerance computation in BOPTools_AlgoTools::CorrectCurveOnSurface has been improved, taking into account intersection segments between p-curves (to avoid regression on "bugs modalg_6 bug22794").
- Improve IsExistingPaveBlock to make more stable catching of coincidence of common block with section curve (against regression "bugs modalg_4 bug697_2" on Linux).
Test case for the bug has been added.
The following test cases have been updated as improvements:
boolean gdml_private ZH2 ZI7 ZJ7
boolean volumemaker C4
The test case bugs/modalg_4/pro19653 has been corrected to make it stable. See comment inside the script for details.
The test case bugs/modalg_6/bug25880 has been corrected to suppress wrong bfuse commands.
The test bugs/modalg_6/bug26954_3 has been corrected to compare the result with more precise reference value.
The "faulty" TODO in boolean/volumemaker/A8 has been made actual for Linux as well.
//Eliminate compilation error on Linux.
ski [Mon, 31 Oct 2016 08:54:54 +0000 (11:54 +0300)]
0028027: Configuration - option BUILD_RESOURCES does not work on CMake 2.8
CMake command "string (APPEND ...)" was replaced by SET equivalent to support CMake 2.8
msv [Wed, 2 Nov 2016 07:59:39 +0000 (10:59 +0300)]
0027802: [Regression to 7.0] Solid classifier raises exception ConstructionError
Test case has been created.
ski [Wed, 12 Oct 2016 15:02:55 +0000 (18:02 +0300)]
0024788: Foundation Classes - remove Dico_Dictionary
Class Dico_Dictionary was replaced by NCollection_DataMap/NCollection_IndexedDataMap classes.
Changed argument name in template class NCollection_Datamap to eliminate redefinitions of static members in dependent code.
kgv [Wed, 2 Nov 2016 09:50:02 +0000 (12:50 +0300)]
0028039: Coding rules, TObj - pass file name by reference
azv [Sat, 29 Oct 2016 08:23:05 +0000 (11:23 +0300)]
0028028: Solid becomes invalid after scaling
The shape after scaling contains PCurves with incorrect parametrization, because of too large tolerance given.
1. Set Precision::PConfution() as a tolerance for GeomLib::SameRange.
2. Do not take into account tolerances of vertices while calculating tolerance of transformed PCurve for edge.
3. Test case bugs/modalg_6/bug28028
kgv [Tue, 1 Nov 2016 12:14:35 +0000 (15:14 +0300)]
0028035: Visualization - V3d_Trihedron::compute() endlessly creates new graphic groups
V3d_Trihedron::compute() now reuses existing groups in the structure
and resets the flag myToCompute.
ifv [Mon, 7 Nov 2016 13:38:53 +0000 (16:38 +0300)]
0028030: Algorith GeomLib_CheckCurveOnSurface takes too much time for Bspline curves with big number of knots
Checking of number of knots is added. If number of knots more then allowed value, algorithm does not search distance between curves for each knot interval, but uses predefined sample point distribution.
This change was born in the scope of work on the issue 26329, but does not have direct connection to it. Therefore it has been postponed to be integrated later in its own context.
Test case for issue #28030
pdn [Tue, 1 Nov 2016 10:43:56 +0000 (13:43 +0300)]
0028034: Application Framework - stack overflow in LDOM destructor
nbv [Fri, 28 Oct 2016 06:37:38 +0000 (09:37 +0300)]
0027896: Prm-Prm intersection algo returns wrong result if it is called with start intersection point, which lies in the domain boundary
Purger has been disabled (in IntPatch_PrmPrmIntersection algorithm) if some points have been added in the Walking line (it is stupidly, first, to insert some points in the line and, after that, to delete points from this line).
Some improvements in IntWalk_PWalking::SeekPointOnBoundary(...) method have been made (see comments in the code for detail information).
Some test cases have been adjusted according to their new behavior.
vpa [Mon, 31 Oct 2016 13:34:15 +0000 (16:34 +0300)]
0027868: Visualization - AIS_InteractiveContext::Remove() might keep removed object in selection list
- AIS_InteractiveContext::unhighlightOwners is corrected to handle all objects in selection regardless of owner's selection state
apn [Thu, 3 Nov 2016 11:20:04 +0000 (14:20 +0300)]
Fixed compilation warnings on vc14 caused by CR27431_5
jgv [Mon, 17 Oct 2016 10:59:58 +0000 (13:59 +0300)]
0027386: BRepOffsetAPI_MakePipeShell does not provide history of generations
The method BRepOffsetAPI_MakePipeShell::Generated now returns generated shapes for sub-edges and sub-vertices of sections.
The method BRepFill_PipeShell::BuildHistory is redesigned: now it builds generated shapes for sub-edges and sub-vertices of sections.
New Draw command "gensweep" is added to sweep commands for testing of history building.
abk [Wed, 5 Oct 2016 10:49:44 +0000 (13:49 +0300)]
0027870: Modeling - refactoring of HLR algorithms
Toolkit 'TKHLR' was fully refactored for 'Standard_Address' and macros except about half of package 'HLRBREP' there 'Standard_Address' is used through the 'generic' mechanism.
ika [Fri, 28 Oct 2016 12:51:58 +0000 (15:51 +0300)]
0028014: PMIVis - some tolerances are attached to points out of the models
Fix a misprint.
osa [Mon, 31 Oct 2016 14:08:37 +0000 (17:08 +0300)]
0028031: Visualization, TKV3d - do not use height/width ratio of window during V3d_View::FitAll()
isk [Fri, 14 Oct 2016 06:17:36 +0000 (09:17 +0300)]
0028010: Visualization, Prs3d_Arrow - add Shading presentation builder
StdPrs_ToolCylinder, StdPrs_ToolDisk, StdPrs_ToolQuadric and StdPrs_ToolSphere
have been moved from StdPrs package to Prs3d.
vpa [Fri, 28 Oct 2016 12:03:38 +0000 (15:03 +0300)]
0027008: Visualization - polygonal selection algorithm does not work with MeshVS_Mesh
- correct calculation of normals for SelectMgr_TriangularFrustum;
- test case for issue #27008
anv [Wed, 2 Nov 2016 12:46:52 +0000 (15:46 +0300)]
0028012: Exception while intersecting two surfaces
Test case for issue CR28012
msv [Fri, 28 Oct 2016 15:20:03 +0000 (18:20 +0300)]
0026673: BOPTools_AlgoTools::ComputeVV incorrectly checks two vertices for intersection
Test case has been created.
msv [Wed, 2 Nov 2016 12:43:50 +0000 (15:43 +0300)]
0024932: addsweep does not check if the supplied variable contains a shape
Check for null shape has been added in the command addsweep implementation.
// eliminate warning
Test case for issue CR24932
Test case has been corrected.
vpa [Thu, 27 Oct 2016 11:29:27 +0000 (14:29 +0300)]
0027530: Visualization - AIS_InteractiveContext::HilightNextDetected() doesn't work in Neutral Point
- added implementation of mentioned methods for neutral point;
- sequence of detected objects was replaced by sequence of detected owner's indexes in AIS_InteractiveContext;
- commands vselnext and vselprev were corrected to update viewer properly;
- test case for issue #27530.
nbv [Wed, 2 Nov 2016 12:39:37 +0000 (15:39 +0300)]
0028009: [Regression vs OCCT7.0.0] Cut produces not valid shape
The algorithm in WorkWithBoundaries::BoundaryEstimation(...) did not take into account opposite directions of cylindrical axes (when the angle between them is obtuse). After the fix it does it.
Small correction of test cases for issue CR28009
nbv [Wed, 2 Nov 2016 12:25:36 +0000 (15:25 +0300)]
0027431: [Regression to 6.9.1] Huge tolerance obtained during intersection of cylinder and sphere
The root of the problem is incorrect processing of cases when intersection line goes through the apex(es) of sphere. The fix improves this situation. The algorithm is taken from DecomposeResult(...) function (see IntPatch_ImpPrmIntersection.cxx file). Before the fix, faltering steps were done to solve this problem. As result, it worked in some particular cases. Now, its possibilities have been extended significantly.
Following changes have been made in the fix:
1. Class IntPatch_ALineToWLine has been rewritten cardinally. It touches as interfaces of existing methods as adding/removing some methods/fields. Correction touches both cases: going through seam of Cone/Sphere and through pole(s) of sphere. Old interface did not allow making some actions with analytical line (ALine), e.g. splitting it on several Walking-lines (WLine).
2. Restriction-line support has been removed from Implicit-Implicit intersection result (see IntPatch_Intersection::GeomGeomPerfom(...) method). It connects with the fact that the intersection algorithm itself returns precise intersection line in analytical cases (in compare with parametric intersector). Therefore, we do not need in additional (restriction) line.
3. New class IntPatch_SpecialPoints has been added. This class contains methods to add some special points (such as apex of cone, pole of sphere, point on surface boundary etc.) in intersection line (IntPatch_PointLine). It is based on the static functions, which already exist in IntPatch_ImpPrmIntersection.cxx file (these functions have been moved to the new class).
4. Method IntPatch_WLineTool::ExtendTwoWlinesToEachOther(...) has been renamed to IntPatch_WLineTool::ExtendTwoWLines(...). It is connected with changing main idea of the method. Now it allows extending WLine to the surface boundary or to the singular point (if it is possible): cone apex, sphere pole etc. Interface of this method has been corrected, too. At that, old functionality (extending to each other) has been kept. For implementation of this algorithm, new enumeration "IntPatchWT_WLsConnectionType" has been created.
5. Method IntPatch_PointLine::CurvatureRadiusOfIntersLine(...) has been added. See IntPatch_PointLine.hxx for detail information. It allows correct step computing depended on the local curvature of the intersection line. This method uses geometrical properties of intersected surfaces to compute local curvature. Therefore, it can be applied in wide range of cases even if the intersection curve is not represented in explicit form (e.g. in case of param-param-intersection).
6. Method IntSurf::SetPeriod(...) has been created.
7. Additional check has been added in Draft_Modification::Perform() method for better choice of correct fragment of intersection line for processing DRAFT operation.
8. New overload method IntPatch_Point::SetValue() has been added.
9. Some refactoring of the code has been made.
Creation of test case for issue #27431.
---------------------------------------------------------------------------------------------
Some test cases have been adjusted according to their new behavior.
tests\bugs\modalg_4\bug62
It is really IMPROVEMENT (but fortuitous).
tests\bugs\modalg_5\bug25838
The behavior of this test has been reverted to the state before fixing the issue #27341. Main problem has not been fixed in #27341. It was fortuitous improvement.
tests\bugs\moddata_2\bug565
Quality of intersection curve was not checked. And the curve is bad on both MASTER and FIX. Input data are really wrong: plane-like-cone. However, on the MASTER, four intersection curves (the quality is insignificant) are expected. On the fix, not empty intersection result is expected simply.
tests\boolean\volumemaker\A8
Differences in images and CPU is expected. Difference in images is expected to be fixed in the issue #26020. Now, we should apply this behavior.
Much CPU time is spent by IntTools_FaceFace::ComputeTolReached3d(...) and GeomInt_IntSS::BuildPCurves(...) methods calling. These methods are not touched by the algorithm. It is the result of change of intersection curve(s) form. However, the new Curve(s) seems to be valid and can be applied. As result, new behavior can be applied, too.
tests\boolean\volumemaker\F8
tests\boolean\volumemaker\F9
tests\boolean\volumemaker\G5
tests\boolean\volumemaker\G6
CPU difference is expected. Much CPU time is spent by IntPatch_PointLine::CurvatureRadiusOfIntersLine(...) method calling. This method is really new (it does not exist on the MASTER) and is really useful. Therefore, we should apply new behavior.
tests\boolean\volumemaker\G1
CPU difference is expected. Much CPU time is spent by IntTools_WLineTool::DecompositionOfWLine(...) and IntTools_FaceFace::ComputeTolReached3d(...) methods calling. These methods are not touched by the algorithm. It is the result of change of intersection curve(s) form. However, the new Curve(s) seems to be valid and can be applied. As result, new behavior can be applied, too.
tests\bugs\modalg_6\bug26619
Differences in images is expected. The test keeps its BAD status on the FIX. But the result on the fix is nearer to expected than on the MASTER. Issue #27014 is still actual. As before, it is not clear, why the number of entities is different. The number of section curves has not been changed. Interfered entities are the same as on the MASTER.
tests\bugs\modalg_5\bug25319_1(2)
The reason is described in the issue #27896.
Small correction in the test case
emv [Wed, 27 Apr 2016 13:28:52 +0000 (16:28 +0300)]
0027441: The method IntTools_Context::IsVertexOnLine incorrectly computes parameter of the point on the curve
Choosing the closest bound to the checking point.