kgv [Wed, 15 Aug 2018 18:08:00 +0000 (21:08 +0300)]
0030068: Documentation - V3d_View::ToPixMap() description should clarify that method will redraw the View content before dump
kgv [Thu, 16 Aug 2018 11:42:30 +0000 (14:42 +0300)]
0030071: Tests - locate_data_file does not skip .git folders
Regexp is now applied to subfolder name to filter folders starting with dot.
skl [Mon, 13 Aug 2018 13:34:26 +0000 (16:34 +0300)]
0029782: Shape Healing - Reading of invalid shape
bugmaster [Wed, 8 Aug 2018 15:33:16 +0000 (18:33 +0300)]
Adjusting testing cases for VC 2017
nbv [Mon, 16 Jul 2018 12:32:23 +0000 (15:32 +0300)]
0029910: Porting to Debian80-64 : Regressions in Modeling Algorithms
Adjusting test cases.
Creation of new test cases.
apn [Mon, 6 Aug 2018 13:58:02 +0000 (16:58 +0300)]
0030015: Documentation - Correct warnings in OCCT and PRODUCTS documentation
Fix warning multiple use of section label 'upgrade_740_extremaalgo' in the file upgrade.md
abv [Thu, 26 Jul 2018 07:36:12 +0000 (10:36 +0300)]
0029978: Data Exchange, macOS - the result of reading some entity from STEP looks odd
On Apple with XCode 9.4.1 and onwards, the compiler optimization is disabled for method gp_Mat::Transpose() as optimizer generates invalid code when that method is used.
Some refactoring of the code affected by this bug.
mnv [Mon, 23 Jul 2018 12:08:01 +0000 (15:08 +0300)]
0029938: Visualization - SelectMgr_ViewerSelector::PickedPoint() should return point lying on an object
Extended SelectBasics_PickResult structure by myObjPickedPnt field, which contained the value of the 3d point on the selected object.
Changed all Overlaps methods. Parameter theDepth replaced on object of the structure SelectBasics_PickResult. This approach will be able to add new fields to SelectBasics_PickResult structure without big changes in modules which contained Overlaps method.
kgv [Tue, 31 Jul 2018 19:12:04 +0000 (22:12 +0300)]
0030005: Visualization, OpenGl_Context - replace NCollection_SparseArray with NCollection_Array1 for myDrawBuffers
kgv [Tue, 31 Jul 2018 14:37:49 +0000 (17:37 +0300)]
0030004: Visualization, AIS_Manipulator - disable detection of Rotating circle when picking ray lies on its plane
jgv [Tue, 17 Jul 2018 18:16:35 +0000 (21:16 +0300)]
0029915: Porting to VC 2017 : Regressions in Modeling Algorithms on VC 2017
Methods GeomConvert::ConcatG1, GeomConvert::ConcatC1, Geom2dConvert::ConcatG1, Geom2dConvert::ConcatC1 are corrected to prevent exceeding maximum degree of BSpline curve in case of closed contour.
vro [Tue, 10 Jul 2018 11:58:08 +0000 (14:58 +0300)]
0029940: The method TPrsStd_AISPresentation::SetSelectionMode() seems useless for transactions
A boolean parameter is added with a default value to the method TPrsStd_AISPresentation::SetSelectionMode().
By default, behavior of the method is not changed. But if the parameter's value is changed to FALSE, change of selection mode for the object will not influence the transaction. In other words, the attribute will not set modified and will not put into transaction delta. This behavior suits the usual notion of the object in an application: the object has color, material, transparency, but selection mode is not a property of the object. It is a property of an operation involving the object. Therefore, it has sense to remove the method SetSelectionMode() from TPrsStd_AISPresentation. For a while, it is marked as obsolete.
nbv [Fri, 27 Jul 2018 13:29:55 +0000 (16:29 +0300)]
0029994: Misprint in IntWalk_PWalking::Perform(...) method
In the fragment
if (aNewPnt[0] < u1min || aNewPnt[0] > u1max ||
aNewPnt[1] < v1min || aNewPnt[1] > v1max ||
aNewPnt[2] < u2min || aNewPnt[2] > u2max ||
aNewPnt[3] < v2min || aNewPnt[3] > v2max)
{
break; // Out of borders, handle this later.
}
the parameters are compared with values obtained by IntPolyh_MaillageAffinage algorithm and do not have any relations to the domain boundaries.
This misprint has been eliminated.
nbv [Tue, 17 Jul 2018 09:32:14 +0000 (12:32 +0300)]
0028085: Incorrect result of CUT operation
Before the fix, small arc of circle returned as intersection result. It was connected with the fact that the circle always was limited in 0 and 2*PI points. Currently the bounds of the circle (retrieved as an intersection curve) are computed from the real domain of the arguments (there is not a snap to the fixed 0 and 2*PI points).
kgv [Sat, 28 Jul 2018 18:18:05 +0000 (21:18 +0300)]
0029997: Coding Rules - eliminate GCC compiler warnings -Wmaybe-uninitialized in Select3D_InteriorSensitivePointSet.cxx
ifv [Fri, 27 Jul 2018 07:21:43 +0000 (10:21 +0300)]
0029573: ConcatenateWireC0 crashes on two edges wire
Wrong setting first/last vertices is fixed
Test case added
abv [Tue, 24 Jul 2018 14:45:15 +0000 (17:45 +0300)]
0029911: Porting to Debian80-64 : Regressions in Foundation Classes
Test for handles is updated according to behavior expected from modern compilers.
Performance test perf ncollection A1 is updated (valid range extended) according to measurements made on Debian 8 with GCC 4.9 and on Ubuntu 16.04 with CLang 3.8 and 6.0 and GCC 4.7, 4.9, and 5.0.
abv [Thu, 26 Jul 2018 04:48:56 +0000 (07:48 +0300)]
0029859: Coding - GCC compiler warning -Warray-bounds in IntPatch_InterferencePolyhedron.cxx
kgv [Fri, 20 Jul 2018 10:07:47 +0000 (13:07 +0300)]
0029967: Draw Harness - command bounding has annoying syntax
Bnd_OBB constructor from Bnd_Box is fixed for VOID input.
DRAW command bounding command is adjusted:
- Support of old syntax 'bounding shape'is restored.
- Exception on VOID bounding box is avoided.
- Arguments are handled in case-insensitive way.
- Options -s, -perfmeter, and ability to set result as first argument are removed as redundant.
- Help is moved to command definition.
Separate command OCC29311 is added (in QADraw) to do the same as option -perfmeter did; tests are updated.
emv [Fri, 20 Jul 2018 12:16:50 +0000 (15:16 +0300)]
0029973: Modeling Algorithms - access violation within BRepAlgoAPI_Cut on empty input shape
Boolean Operations algorithm has been improved to handle the cases with empty shapes arguments correctly.
Test cases for the issue.
emv [Wed, 16 May 2018 09:12:09 +0000 (12:12 +0300)]
0029711: General Fuse operation produces invalid result
The following improvements have been introduced in Boolean Operations algorithm s:
1. UBTree is replaced with EBTree in Boolean operations to be able to add/remove elements into the tree of bounding boxes.
2. Repeated (nested) intersection of sub-shapes is performed with argument vertices whose tolerances increased during the operation.
3. The algorithms of Edge/Edge and Edge/Face intersection have been improved for the cases when the intersection point is located close to the edge boundaries .
4. New procedure has been implemented to ensure forced creation of Edge/Face common blocks in cases when the edge is really close to the face.
5. Post-processing of Face/Face intersection results has been improved.
6. Extension of the planar faces for Plane/Plane intersection is avoided.
7. Builder Face now better classifies potentially internal edges relatively to new faces with filtering by bounding boxes.
Side effect changes:
1. IntTools_ShrunkRange now keeps the length of the valid range of the edge.
2. The method BOPDS_DS::UpdateEdgeTolerance() has been removed as unused (replaced by the BOPAlgo_PaveFiller::UpdateEdgeTolerance()).
Test case for the issue
0029900.
Test case for the issue
0029711.
Adjustments of the existing test cases.
Avoid using uninitialized variables.
kgv [Sat, 14 Jul 2018 10:59:22 +0000 (13:59 +0300)]
0029958: Visualization - add method Graphic3d_ArrayOfPrimitives::AddEdges() taking up to 4 edges
kgv [Fri, 20 Jul 2018 07:40:14 +0000 (10:40 +0300)]
0029975: Visualization - Graphic3d_ClipPlane::ProbeBox() returns Out for fully In box
abv [Mon, 23 Jul 2018 18:58:47 +0000 (21:58 +0300)]
0029981: Coding - Clang 6.0 warning [-Wenum-compare-switch]
In implementation of DRAW command "mkplane", the case labels of the switch statement are corrected to use values of the enum matching the type of the switch argument.
kgv [Mon, 23 Jul 2018 16:13:29 +0000 (19:13 +0300)]
0029980: Configuration, CMake - impossible to override CMAKE_CXX_USE_RESPONSE_FILE_FOR_OBJECTS
Variables are not assigning only if have not been previously defined.
kgv [Mon, 23 Jul 2018 18:12:13 +0000 (21:12 +0300)]
0029740: Draw Harness - eliminate redundant casts to AIS_InteractiveObject
NCollecton_DoubleMap has been extended with two new methods Find1() and Find2()
performing lookup and returning found key withoout throwing an exception
(similar to NCollection_DataMap::Find()).
ViewerTest_DoubleMapOfInteractiveAndName has been redeclared to define
Handle(AIS_InteractiveObject) key instead of Handle(Standard_Transient).
kgv [Thu, 19 Jul 2018 17:32:51 +0000 (20:32 +0300)]
0029974: Visualization - OpenGl_Layer::Render() produces inconsistent state of Polygon Offset settings
OpenGl_Layer::Render() now calls OpenGl_Workspace::SetDefaultPolygonOffset()
for managing default polygon offset settings considering OpenGl_Workspace applied aspect logic.
kgv [Wed, 11 Jul 2018 14:50:39 +0000 (17:50 +0300)]
0029949: Draw Harness - simplify vtriangle command implementation
vtriangle and vsegment commands now share presentation created by vdrawparray command.
Added missing accessors to Graphic3d_ArrayOfPrimitives properties
VertexNumberAllocated(), EdgeNumberAllocated() and BoundNumberAllocated().
kgv [Tue, 17 Jul 2018 22:04:58 +0000 (01:04 +0300)]
0029969: Modeling Algorithms - BRepPrimAPI_MakeHalfSpace::Shape() returns NULL shape while reporting IsDone()
emv [Tue, 17 Jul 2018 07:08:27 +0000 (10:08 +0300)]
0029955: Face and Solid BOP: Building 2D curve of edge on face has failed
Test case for the issue as it is not reproduced anymore.
emv [Tue, 17 Jul 2018 09:07:59 +0000 (12:07 +0300)]
0028113: BOPAlgo_Builder produces invalid shape
Fast rebuilding of the face is now avoided if its edges have been unified during the intersection.
Full rebuilding of the face is required in this case (using BuilderFace algorithm).
kgv [Fri, 20 Jul 2018 08:08:34 +0000 (11:08 +0300)]
0029970: Coding Rules - StdSelect_BRepOwner::Set() method is declared but undefined
Undefined method has been removed.
emv [Mon, 16 Jul 2018 12:45:02 +0000 (15:45 +0300)]
0028123: Boolean Cut produces faulty shape
Test case for the issue as it is not reproduced anymore.
emv [Wed, 18 Jul 2018 12:31:52 +0000 (15:31 +0300)]
0029968: Modeling Algorithms - BRepAlgoAPI_Cut produces an empty result with half-space
IntTools_Context::IsInfiniteFace() - Make the conclusion about infinity of the face basing on its bounding box only. No need to check NaturalRestriction flag.
msv [Fri, 1 Jun 2018 11:38:39 +0000 (14:38 +0300)]
0029830: STEPCAFControl_Reader poor performance - quadratic dependence
Various performance improvements in STEP read/write algorithms:
- Search for the label of a shape or component shape is improved using map mechanism instead of brute force iteration.
- Invariant FindEntities() is moved out of the loop in the method getStyledItem in STEPCAFControl/STEPCAFControl_Writer.cxx.
- A pointer to the end of binders chain is added in Transfer_Binder class to speed up adding a binder to the chain.
- Small fixes are added to eliminate excess copying of handles, calls of handle DownCasts and so on.
Stack overflow is removed during destruction of STEP model with long chains of Transfer_Binder.
It is possible to use the Draw commands ReadStep and WriteStep to read/write from the session without accessing the disk file (use '.' for the file name).
Performance test cases for STEP reading/writing have been added.
abv [Sun, 10 Jun 2018 19:40:12 +0000 (22:40 +0300)]
0029769: Uninitialized data with BSplCLib_Cache, BSplSLib_Cache
Implementation of classes BSplCLib_Cache and BSplSLib_Cache is revised:
- Common functionality dealing with spans along one parametric direction is separated to new struct BSplCLib_CacheParams
- Empty constructors are removed; copying is prohibited
- Code reconsidering degree and other parameters on each call to BuildCache() is eliminated; curve parameters must be the same in constructor and all calls to BuildCache()
- Extra call to BuildCache() from constructor is eliminated
skl [Thu, 12 Jul 2018 06:47:02 +0000 (09:47 +0300)]
0025852: Visualization - Font_BRepFont produces bad faces for circled symbols
Font_BRepFont now uses a dedicated algorithm for text-to-BRep transformation instead of relying on ShapeFix.
It orders wires based on wire classification, analyzes internal zones and creates a few faces (if needed).
TKService dependency from TKShHealing has been dropped.
jgv [Fri, 15 Jun 2018 17:22:38 +0000 (20:22 +0300)]
0029861: Modeling Algorithms - BiTgte_Blend gives exception
The algorithm has been corrected to avoid exception.
Now both Draw commands "brollingball" and "rollingball" give correct results.
Test cases "offset faces_type_a A3, A4, A9" are good now.
gka [Mon, 16 Jul 2018 09:08:00 +0000 (12:08 +0300)]
0029959: Coding - new warnings after integration 29846
Erroneous label declaration has been removed in function SetMaterial from XDEDRAW_Props.cxx
emv [Mon, 16 Jul 2018 10:03:17 +0000 (13:03 +0300)]
0027230: Boolean operations fails on attached shapes
Test case for the issue as it is not reproduced anymore.
kgv [Sun, 15 Jul 2018 08:35:12 +0000 (11:35 +0300)]
0029961: Foundation Classes - NCollection_Shared constructor passes arguments by copy
New NCollection_Shared constructors taking arguments by reference have been added.
kgv [Sat, 14 Jul 2018 16:17:26 +0000 (19:17 +0300)]
0029960: Foundation Classes - disarm OSD_ThreadPool copy constructor
Private copy constructors have been added to OSD_ThreadPool
and Standard_Condition to protect misuse.
gka [Thu, 5 Jul 2018 16:10:31 +0000 (19:10 +0300)]
0029846: Data Exchange - STEP validation properties support is obsolete
Name of the PROPERTY_DEFINITION entity for validation properties is changed to "geometric validation property" according to the current version of the recommended practices.
For compatibility with older definitions (with underscores) the check is made using string with underscores replaced by spaces.
ysn [Mon, 9 Jul 2018 10:53:01 +0000 (13:53 +0300)]
0029817: Documentation - avoid excessive use of "please"
"Please" is now used in the documentation only in sensitive cases.
skl [Tue, 10 Jul 2018 11:45:11 +0000 (14:45 +0300)]
0029873: Data Exchange - STEPCAFControl_Reader::Transfer() returns TRUE even when external files are missing
Output information about failure during reading of external file has been added (it can be checked by using Draw command "tpstat").
If the reader cannot find an external file at the first found location
(using entity APPLIED_EXTERNAL_IDENTIFICATION_ASSIGNMENT) it checks other information about file path
(using entity DOCUMENT_FILE related with the above-mentioned entity) and uses a new location for import of the external file.
kgv [Fri, 6 Jul 2018 23:27:51 +0000 (02:27 +0300)]
0029935: Foundation Classes - introduce OSD_ThreadPool class defining a thread pool
New class OSD_ThreadPool has been introduced to define a Thread Pool for multi-threading algorithm.
Thread Pool assigns a serial number for each thread allowing Multi-Threading algorithm to allocate thread-local storage variables as an array whose size is the same as the number of threads.
OSD_ThreadPool also redirects exceptions to a thread calling parallel execution and consistently initializes FPE exception handling.
New class Standard_Condition provides a platform-independent tool similar to Event in WinAPI.
A new auxiliary function Standard_Atomic_CompareAndSwap() has been introduced
for performing atomic compare and swap of integer number.
Standard_Atomic_Increment/Standard_Atomic_Decrement fallback implementation
using ASM code for x86 processors for GCC has been dropped;
instead, it is expected that GCC should be properly configured targeting modern x86 architectures.
OSD_Signal now declares fFltExceptions as thread_local variable accessible through OSD::ToCatchFloatingSignals() property.
Standard_THREADLOCAL macro (wrapping thread_local attribute) has been moved to public header Standard_Macro.hxx.
OSD_Parallel::ForEach() has been extended with new optional parameter theNbItems and uses OSD_ThreadPool::DefaultPool().
kgv [Thu, 21 Jun 2018 09:19:08 +0000 (12:19 +0300)]
0029425: Visualization - AIS_InteractiveContext::SetAutomaticHilight() has no affect
AIS_InteractiveContext::MoveTo() and ::Select() now do not highlight entities
when ::AutomaticHilight() option is turned off.
vselprops command has been extended with new arguments -autoHighlight and -highlightSelected
(vhighlightselected command is now deprecated).
ika [Wed, 11 Jul 2018 14:29:34 +0000 (17:29 +0300)]
0029945: Export body of revolution to STEP breaks the shape
Now vertex loops on surfaces of revolution are imported from STEP format in the same way as on spheres and b-spline surfaces: in case of a single vertex loop neutral bounds will be used.
kgv [Sat, 7 Jul 2018 01:08:57 +0000 (04:08 +0300)]
0029936: Documentation - improve description of AIS_Animation class
kgv [Wed, 11 Jul 2018 12:52:02 +0000 (15:52 +0300)]
0029947: Visualization - SelectMgr_SelectableObject::GetSelectPresentation() should copy object clipping planes
Methods SelectMgr_SelectableObject::GetHilightPresentation(), ::GetSelectPresentation() and ::UpdateClipping()
have been corrected to copy clipping planes of the object into highlighting and selection presentations.
nbv [Wed, 11 Jul 2018 14:29:54 +0000 (17:29 +0300)]
0029948: Uninitialized variable in GeomEvaluator_OffsetSurface::CalculateD0(...) method
Variable "NStatus" from GeomEvaluator_OffsetSurface class is now initialized correctly.
nbv [Tue, 3 Jul 2018 15:14:30 +0000 (18:14 +0300)]
0029866: Intersector returns two overlapped curves as a result
Since now a new WLine is not created if its start point lies in another earlier computed WLine. It allows avoiding creation of duplicate WLines in the intersection result.
<!break>
1. Methods IsOutSurf1Box(...), IsOutSurf2Box(...), IsOutBox(...) for classes IntSurf_LineOn2S and IntPatch_RLine have been created.
kgv [Wed, 4 Jul 2018 09:09:50 +0000 (12:09 +0300)]
0029939: Modeling Algorithms - add NULL check to BRepGProp_Face::Load()
BRepGProp_Face::Load() has been protected against crash in case of edges without p-curves.
gka [Tue, 10 Jul 2018 16:20:50 +0000 (19:20 +0300)]
0029944: Porting to VC 2017 : Regressions on the gcc (Debian 4.9.2-10) 4.9.2. Exception is raised during load STEP file.
Boolean parameter "same_sence" from class RWStepShape_RWAdvancedFace.cxx is now initialized correctly.
nbv [Tue, 10 Jul 2018 09:50:03 +0000 (12:50 +0300)]
0029942: Porting to Debian80-64 : Regressions in Modeling Algorithms after integration fix for 29807
Correction in the test case perf/modalg/bug27021.
gka [Wed, 4 Jul 2018 16:45:58 +0000 (19:45 +0300)]
0029916: Regressions in Data Exchange on VC 2017
The "end" file from folder "de" has been corrected to exclude comparing the number of edges in the shapes from current result with test data.
"TODO messages generated for differences were removed.
Data exchange tests were regenerated.
kgv [Fri, 6 Jul 2018 16:04:49 +0000 (19:04 +0300)]
0029934: Visualization - handle properly orthogonal clipping plane within SelectMgr_RectangularFrustum::computeClippingRange()
SelectMgr_RectangularFrustum now considers the direction of clipping plane orthogonal to picking ray.
mnv [Mon, 2 Jul 2018 08:21:35 +0000 (11:21 +0300)]
0029823: Visualization, TKOpenGl - highlighting by Bounding Box mistreats Local Transformation
The problem when object transformation was applied to the bounding box twice has been fixed in OpenGl_Structure.
OpenGl_ShaderManager has been extended with GLSL program drawing bounding box.
OpenGl_Structure does not create extra Groups for drawing bounding box.
kgv [Fri, 15 Jun 2018 16:39:31 +0000 (19:39 +0300)]
0029874: Visualization - capping plane transparency does not work
Interface OpenGl_RenderFilter and its implementations have been merged into OpenGl_Workspace.
This limits flexibility of interface, but simplifies logic.
- OpenGl_RenderFilter_FillModeOnly flag replaces OpenGl_CappingAlgoFilter;
- OpenGl_RenderFilter_NonRaytraceableOnly flag replaces OpenGl_RaytraceFilter;
- OpenGl_RenderFilter_OpaqueOnly flag replaces OpenGl_OpaqueFilter;
- OpenGl_RenderFilter_TransparentOnly flag replaces OpenGl_TransparentFilter.
OpenGl_CappingAlgo now:
- avoids redundant Stencil clearing when Layer contains at least one transparent Element;
- renders semitransparent capping plane within transparent elements pass.
vclipplane command has been extended by new argument -transparency.
kgv [Thu, 5 Jul 2018 09:54:05 +0000 (12:54 +0300)]
0029929: Visualization, V3d_View - make method ::FitMinMax() public
apn [Wed, 4 Jul 2018 10:17:51 +0000 (13:17 +0300)]
0029928: Regressions: a lot of warnings produced during generation Overview by Doxygen
Warnings in upgrade.md have been eliminated.
kgv [Wed, 4 Jul 2018 07:49:44 +0000 (10:49 +0300)]
0029927: Coding Rules - eliminate GCC compiler warnings -Wmaybe-uninitialized in BRepApprox
The code has been fixed to avoid taking a reference from a field of a temporary variable
(BRepApprox_ApproxLine::Point() returns non-reference structure).
abv [Tue, 3 Jul 2018 21:54:46 +0000 (00:54 +0300)]
0029834: Coding Rules - eliminate GCC compiler warnings -Wformat-overflow in IGESData_IGESWriter
String buffers have been increased to be sufficient to accommodate result of sprintf() for any possible printed integer values.
kgv [Thu, 14 Jun 2018 15:45:58 +0000 (18:45 +0300)]
0029868: Draw Harness - help message for readstl command is unclear
readstl syntax has been modified, so that it creates a single-face triangulation by default.
The argument "trinagulation" is no more supported.
The new argument "-brep" has been introduced to generate
a compound of per-triangle faces instead (old default behavior of the command).
kgv [Tue, 3 Jul 2018 11:31:40 +0000 (14:31 +0300)]
0029909: Coding - GCC compiler warnings in Qt headers while building Samples in OCCT and Products on Debian80 64 bit
Standard_WarningsDisable.hxx has been extended by ignoring -Wunused-local-typedefs within GCC compiler.
nbv [Fri, 25 May 2018 08:05:58 +0000 (11:05 +0300)]
0029807: [Regression to 7.0.0] Impossible to cut cone from prism
The algorithm has been improved for the cases when the intersection line goes through the cone apex.
<!break>
1. All special points are put to the ALine forcefully (if they are true intersection point). Currently this step has not been implemented yet.
2. Now the tolerance of IntPatch_Point (put into ALine) is computed in order to cover the distance between it and the correspond ALine.
3. Test cases have been created.
4. Procedure of trimming IntAna_Curve has been improved.
5. Criterion when the discriminant of IntAna_Curve can be considered to be equal to 0 has been improved.
6. Methods IntAna_Curve::FindParameter(...) (and IntPatch_ALine::FindParameter(...)) currently returns list of all parameters corresponding the given point (IntAna_Curve can be self-interfered curve). Before the fix, this method always returned only one (randomly chosen) parameter.
7. Interfaces of the following methods have been changed: IntAna_Curve::FindParameter(...), IntPatch_ALine::FindParameter(...), IntPatch_ALine::ChangeVertex(...), IntPatch_SpecialPoints::AddPointOnUorVIso(...), IntPatch_SpecialPoints::AddSingularPole(...), IntPatch_WLineTool::ExtendTwoWLines().
8. Following methods have been added: IntAna_Quadric::SpecialPoints(...), IntPatch_ALineToWLine::GetSectionRadius(...), IntPatch_SpecialPoints::ProcessSphere(...), IntPatch_SpecialPoints::ProcessCone(...), IntPatch_SpecialPoints::GetTangentToIntLineForCone(...).
------------------
1) tests/boolean/volumemaker/C5
tests/boolean/volumemaker/C6
tests/boolean/volumemaker/E7
They are real IMPROVEMENTS. In the FIX (in compare with MASTER), section result between pairs of faces f2&f6 (C5), f3&f7 (C6) and f1&f5 (E7) is closed. Separated test cases have been created in order to focus on the problem with section. Bug #28503 has been fixed.
Correction in test cases.
kgv [Mon, 2 Jul 2018 21:45:41 +0000 (00:45 +0300)]
0029925: Foundation Classes - add missing cast to LowerCase() and UpperCase() arguments
Argument of LowerCase() and UpperCase() is cast to int via unsigned char to avoid passing negative integer in the case if the argument char is in the extended part of ASCII table (which would result in undefined behavior according to C++ standard).
abv [Mon, 2 Jul 2018 15:48:44 +0000 (18:48 +0300)]
0029924: Configuration - remove obsolete folders from .gitignore
Folders drv, sun, sil and ao1 have been removed from .gitignore
ifv [Tue, 26 Jun 2018 11:54:35 +0000 (14:54 +0300)]
0029857: Incorrect behavior of Point-Curve Extrema
Check for double solutions has been added in algorithms Extrema_ELPCOfLocateExtPC and Extrema_ELPCOfLocateExtPC2d
that find extrema between point and curve.
mnv [Tue, 26 Jun 2018 13:27:12 +0000 (16:27 +0300)]
0029894: Visualization - AIS_ColorScale ColorRange returns only min color
A typo in AIS_ColorScale::ColorRange function has been fixed.
ika [Thu, 21 Jun 2018 12:57:39 +0000 (15:57 +0300)]
0029890: Data Exchange - Problem in Expand Compounds
XCAFDoc_ShapeTool::Expand method now avoids creation of subshapes under assemblies.
XCAFDoc_ShapeTool::AddSubShape now avoids creation subshapes under all labels except for simple parts.
ika [Thu, 21 Jun 2018 14:21:02 +0000 (17:21 +0300)]
0029888: [Regression] Data Exchange - XCAFDoc_Editor::Expand() removes names
XCAFDoc_Editor::Expand function avoids expanding references to assemblies.
nbv [Wed, 20 Jun 2018 14:30:00 +0000 (17:30 +0300)]
0029887: Wrong result of CUT operation due to incorrect point-face classification
Use of input tolerance has been eliminated in Geom2dInt_GInter algorithm called from BRepClass_Intersector::Perform(...) method.
Now the input tolerance is used only for checking ON-status of classification.
kgv [Wed, 20 Jun 2018 11:56:09 +0000 (14:56 +0300)]
0029885: Visualization, AIS_Manipulator - Translation is done in wrong direction depending on Camera orientation
AIS_Manipulator::ObjectTransformation() has ceased to use undefined point for myStartPick initialization within AIS_MM_Translation mode.
AIS_MM_Scaling cas has been merged into AIS_MM_Translation to reduce code duplication.
Extrema_ExtElC/IntAna_IntConicQuad are now used directly instead of more generic GeomAPI_ExtremaCurveCurve/GeomAPI_IntCS.
kgv [Wed, 20 Jun 2018 05:48:40 +0000 (08:48 +0300)]
0025467: Visualization - Possibility to remove AIS_LocalContext class
Deprecated functionality related to Local Context has been removed.
The following classes and types have been removed:
AIS_LocalContext, AIS_DataMapOfILC, AIS_LocalStatus, SelectMgr_SequenceOfSelector, SelectMgr_DataMapOfObjectSelectors.
Value AIS_DS_Temporary has been removed from enumeration AIS_DisplayStatus.
The following methods related to Local Context have been removed from AIS_InteractiveContext:
::HasOpenedContext(), ::HighestIndex(), ::LocalContext(),
::LocalSelector(), ::OpenLocalContext(), ::CloseLocalContext(),
::IndexOfCurrentLocal(), ::CloseAllContexts(), ::ResetOriginalState(),
::ClearLocalContext(), ::UseDisplayedObjects(), ::NotUseDisplayedObjects(),
::SetShapeDecomposition(), ::SetTemporaryAttributes(),
::ActivateStandardMode(), ::DeactivateStandardMode(), ::KeepTemporary(),
::SubIntensityOn(), ::SubIntensityOff(),
::ActivatedStandardModes(), ::IsInLocal()
and ::AddOrRemoveSelected() taking TopoDS_Shape.
The methods AIS_InteractiveContext::Display() and ::Load()
taking argument theToAllowDecomposition have been marked as deprecated;
the new methods without this unused argument should be used instead.
AIS_InteractiveContext::DisplayedObjects() - removed argument theOnlyFromNeutral.
SelectMgr_SelectionManager has been simplified so that now it support only single Viewer Selector.
The argument -local has been removed from Draw Harness commands vselmode, vremove, vdisplay, vdisplayall, verase.
kgv [Tue, 19 Jun 2018 07:48:50 +0000 (10:48 +0300)]
0029882: Visualization - AcceptDisplayMode() should be redefined in class AIS_TexturedShape
ifv [Thu, 17 May 2018 12:38:17 +0000 (15:38 +0300)]
0029734: Modeling Algorithms - Compute global properties of tessellated shape
New algorithms calculating global properties on mesh data have been added:
- BRepGProp_MeshCinert computes the global properties of polylines represented by a set of points;
- BRepGProp_MeshProps computes the global properties of a surface mesh.
Existing tool BRepGProp now automatically uses new algorithm for triangulation-only faces.
By default, algorithm will use exact geometry objects (surfaces), when it is available (as before the patch);
this behavior can be switched by a new flag UseTriangulation, forcing usage of triangulation instead of exact geometry when both defined.
abv [Tue, 12 Jun 2018 19:18:34 +0000 (22:18 +0300)]
0029859: Coding - GCC compiler warning -Warray-bounds in IntPatch_InterferencePolyhedron.cxx
Code is corrected to avoid copying uninitialized element of the array
dipts [Wed, 6 Jun 2018 19:42:11 +0000 (22:42 +0300)]
0029847: Visualization, Image_Diff - Tolerance is not effective for 24/32bit image formats
Image_Color - removed semibroken summ/difference operators.
Image_Diff now uses signed integer for computing differnce between ubyte3 components;
properly compare squared tolerance.
Image_Diff - dropped declaration of Image_ColorXXX24.
RGB color difference is now computed using Chebyshev distance instead of Euclidean distance
Image_PixMap - added methods RawValue()/ChangeRawValue() returning a pointer
to image where specified pixel data is defined.
emv [Thu, 7 Jun 2018 05:29:21 +0000 (08:29 +0300)]
0029845: UnifySameDomain does not account the accumulated angle when unifying edges
Check that the accumulated angle does not exceed the given angular tolerance while merging the linear edges.
Test case for the issue.
nds [Thu, 7 Jun 2018 12:59:03 +0000 (15:59 +0300)]
0029841: Test cases from tools/dfbrowser periodically hang on Windows platform
Do not start new thread if the thread has been already started. Restart the thread after the previous has finished.
kgv [Wed, 30 May 2018 15:59:12 +0000 (18:59 +0300)]
0029825: Foundation Classes, NCollection_Vec4 - workaround gcc optimizer issues with xyz() method
Methods of NCollection_Vec3 and NCollection_Vec3 that returned reference to internal buffer as vector of lower dimension (non-const xy(), xyz() etc.) are eliminated.
Use of these methods could led to generation of incorrect binary code by GCC.
Instead added new method SetValues() accepting vector of lower dimension and additional value.
DRAW test command QANColTestVec4 reproducing one situation where the bug occurs is added, along with a test case.
abv [Tue, 5 Jun 2018 13:38:45 +0000 (16:38 +0300)]
0029826: Tests - test case perf/fclasses/strtod is unstable
Check of performance of accelerated Strtod() vs. standard strtod() in the test is relaxed: now test passes if Strtod() is at least 1.5 times faster
vro [Mon, 4 Jun 2018 07:47:18 +0000 (10:47 +0300)]
0029116: [Regression] OCAF attributes insertion order is violated again
kgv [Thu, 24 May 2018 15:06:37 +0000 (18:06 +0300)]
0029814: Modeling Data - add method TopoDS_Shape::NbChildren() for simple check of sub-shapes number
TopoDS_Shape::NbChildren() - new method has been introduced.
TopoDS_Shape.lxx, TopoDS_TShape.lxx - inline methods have been moved to hxx.
TopoDS_TShape_Flags has been redeclared as enumeration instead of preprocessor macros.
Cyclic dependency between headers TopoDS_Shape.hxx and TopoDS_TShape.hxx eliminated.
Places where TopoDS_Iterator is used only for calculation of number of sub-shapes are updated to use NbChildren() instead
jgv [Fri, 30 Mar 2018 10:30:44 +0000 (13:30 +0300)]
0029511: Section fails for these two faces
Modified method: Approx_ComputeLine::Compute
Check of multicurve is now always unconditional, the procedure of check is modified to avoid infinite loops.
Modified classes: GeomLib_CheckBSplineCurve and GeomLib_Check2dBSplineCurve
Correction of poles at the ends of curve is modified to fit the direction of tangent defined by two first points or two last points of walking line.
Also modified:
BOPAlgo_PaveFiller: modified methods PostTreatFF, RemoveUsedVertices - now unused vertices are included in the list of vertices to be absorbed by other ones.
jgv [Mon, 28 May 2018 16:13:01 +0000 (19:13 +0300)]
0029813: BRepFill_PipeShell algorithm produces invalid result
Modified method: BRepFill_Sweep::BuildShell
case of global closedness of path containing several C0-connected parts is corrected.
ika [Mon, 28 May 2018 10:15:37 +0000 (13:15 +0300)]
0029821: Data Exchange - Wrong processing of subshapes in ShapeTool
Improve FindSubShape method in ShapeTool.
Update Expand compounds, according to changes in ShapeTool.
Add FindSubShape and AddSubShape commands for Draw.
emv [Thu, 26 Apr 2018 11:35:35 +0000 (14:35 +0300)]
0028747: Incorrect result of the section operation after edge refinement
Implementation of the method for simplification of the result of Boolean Operation on the API level.
The method BRepAlgoAPI_BuilderAlgo::SimplifyResult has been added, so the derived classes such as BooleanOpeation and Splitter can also use this method.
The result shape simplification should be called after the operation is done. The simplification is performed by the means of ShapeUpgrade_UnifySameDomain algorithm.
Draw command "bsimplify" has been added to control the simplification options.
Documentation for new functionality and draw commands controlling the options of Boolean operations.
Test cases for the new functionality.
Side-effect change:
The algorithms in Boolean component have been changed to use the BRepTools_History as a History tool.
Now it became possible to disable the collection of shapes modifications during Boolean Operations, which may be useful for performance sake (in draw the option is controlled by *setfillhistory* command).
Draw command "unifysamedom" has been changed to accept the angular tolerance in degrees instead of radians.
nbv [Tue, 22 May 2018 09:15:27 +0000 (12:15 +0300)]
0029694: Geom2dGcc_Circ2dTanCenGeo crash
The reason of this issue is in incorrectly interpreted the generic class "TheExtPC" (eliminated after the fix
0024773) as Extrema_ExtPC2d. Correct interpretation must be "Extrema_EPCOfExtPC2d" class.
Now this problem has been fixed in the class Geom2dGcc_Circ2dTanCenGeo.
New testgrid "lowalgos 2dgcc" has been created.
nbv [Fri, 20 Apr 2018 14:00:48 +0000 (17:00 +0300)]
0029712: Extrema algorithm raises exception
1. Extrema algorithm calls Curve-surface intersector. This intersector returns flag about infinite solution (in spite of extrema's returning not-parallel status correctly - axes of considered cylinder and circle are not parallel). In this case, attempt of obtaining number of intersection points leads to exception.
So, the fix adds check of infinite solution after the intersection algorithm.
2. The methods IsDone(), IsParallel(), NbExt(), SquareDistance() and Points() (of Extrema_* classes) have been corrected to make them consistent to the documentation.
3. Revision of some Extrema_* classes has been made in order to avoid places with uninitialized variables.
4. Currently Extrema does not store any points in case when the arguments are parallel. It stores the distance only.
5. Some cases on Extrema-algo have been moved from "fclasses"-group to "modalg"-group.
msv [Wed, 23 May 2018 07:18:49 +0000 (10:18 +0300)]
0029777: Foundation Classes - The methods of moving of one NCollection_Sequence to another are unsafe
Make the methods Append, Prepend, InsertBefore and InsertAfter, which take another sequence as an argument, copying the sequence instead of joining if the allocators are different.
Add test cases for collection classes.
nbv [Thu, 12 Apr 2018 08:10:22 +0000 (11:10 +0300)]
0029691: Constructor of BRepFill_MultiLine adjusts V-parameter of sphere in the range -PI/2 ... +PI/2 mistakenly.
1. Sphere is not V-periodic surface. See the section "Periodicity concept" written in frame of the fix
0029115. Therefore, applying ElCLib::AdjustPeriodic(...) method is unreasonable.
2. Default U work range of sphere is 0 ... 2*PI. Therefore, adjusting U parameter in range -PI/2 ... +PI/2 is unreasonable.
ifv [Fri, 23 Mar 2018 08:33:27 +0000 (11:33 +0300)]
0029586: Revolution creates solid with degenerated edges shared among faces
Substitution of degenerated edges by their copies is implemented to make edges not shared
in BRepPrimAPI_MakeRevol::Build().
Method BRepPrimAPI_MakeRevol::Generated(...) is changed in order to use history of substitutions.
Test case is added.
drazmyslovich [Mon, 23 Apr 2018 14:52:43 +0000 (17:52 +0300)]
0029719: Modeling Algorithms - GeomPlate_BuildPlateSurface has no progress information and is not abortable
The Message_ProgressIndicator handle is added as a parameter to the function LU_Decompose and the the member functions of math_Gauss, Plate_Plate and GeomPlate_BuildPlateSurface classes.
kgv [Fri, 25 May 2018 07:13:38 +0000 (10:13 +0300)]
0029729: Visualization, Graphic3d_ClipPlane - add support of clipping plane chains
Graphic3d_ClipPlane now can define a Chain of Planes (logical AND).
OpenGl_ShaderManager - added new GLSL sub-programs for clipping plane chains.
Bnd_Range::TrimFrom(), ::TrimTo() - added auxiliary methods for trimming the range.
SelectMgr_ViewClipRange now handles non-continuous clipping range.
Graphic3d_SequenceOfHClipPlane now aggregates NCollection_Sequence instead of inheritance.
OpenGl_CappingPlaneResource - triangulation has been adjusted to make front face following CCW order.
Benjamin Bihler [Tue, 15 May 2018 07:43:57 +0000 (10:43 +0300)]
0029765: BOPTools_AlgoTools::MakeSplitEdge Creates Illegal Edge
Method MakeSplitEdge checks arguments order.
This makes the method more generic.
Taking vertex orientation into account.
kgv [Tue, 20 Feb 2018 05:37:38 +0000 (08:37 +0300)]
0029520: Visualization - drop deprecated V3d_View::Export() functionality and dependency from gl2ps
bugmaster [Thu, 14 Jun 2018 10:27:03 +0000 (13:27 +0300)]
Switching #define OCC_VERSION_DEVELOPMENT "dev"
bugmaster [Thu, 14 Jun 2018 11:01:17 +0000 (14:01 +0300)]
Update version of OCCT up to 7.3.1