2 years ago0022886: Bug in Boolean
emv [Fri, 20 Sep 2019 07:05:49 +0000 (10:05 +0300)]
0022886: Bug in Boolean

Updating test case as the problem is not reproduced anymore.

2 years ago0030518: Foundation Classes - NCollection_IndexedDataMap array out of bounds
abv [Mon, 16 Sep 2019 05:01:13 +0000 (08:01 +0300)]
0030518: Foundation Classes - NCollection_IndexedDataMap array out of bounds

Implementation of NCollection_IndexedDataMap::Iterator is revised to avoid unintended access to the element out of array bounds

2 years ago0030981: Foundation Classes - heap-buffer-overflow reported by Clang address sanitize...
abv [Thu, 19 Sep 2019 05:33:31 +0000 (08:33 +0300)]
0030981: Foundation Classes - heap-buffer-overflow reported by Clang address sanitizer in TCollection_ExtendedString

Avoid using memcmp on null-terminated extended (16-bit) strings.
Plain zero is used instead of one-byte null char literal for 16-bit chars.

2 years ago0030980: Data Exchange - global-buffer-overflow reported by Clang address sanitizer...
abv [Thu, 19 Sep 2019 04:07:13 +0000 (07:07 +0300)]
0030980: Data Exchange - global-buffer-overflow reported by Clang address sanitizer in iges_newchar()

Avoid unnecessary copying of characters with zero-length string literal as source

2 years ago0030949: Foundation Classes - Dump improvement for OCCT classes
nds [Thu, 19 Sep 2019 12:13:42 +0000 (15:13 +0300)]
0030949: Foundation Classes - Dump improvement for OCCT classes

1. new file Standard_Dump to prepare and parse Dump in JSON format for OCCT objects
2. some presentations cover the proposed dump functionality.
3. 'bounding', 'vaspects' has '-dumpJson' field to see the DumpJson result
4. Bnd_Box constructor with min/max points is implemented to use Dump of this class in Dump BVH_Box
5. Limitation (some classes of Graphic3d, Prs3d has not full filling for DumpJson)

2 years ago0030180: Data Exchange - VrmlAPI_Writer is expected to return export state
mzernova [Mon, 16 Sep 2019 10:44:02 +0000 (13:44 +0300)]
0030180: Data Exchange - VrmlAPI_Writer is expected to return export state

The VrmlAPI_Writer::WriteDoc() and VrmlAPI_Writer::Write() methods now return the export state.

2 years ago0030978: Visualization - stack-use-after-scope reported by Clang address sanitizer...
abv [Wed, 18 Sep 2019 00:48:35 +0000 (03:48 +0300)]
0030978: Visualization - stack-use-after-scope reported by Clang address sanitizer in OpenGl_Text.cxx

Implementation of auxiliary class in OpenGl_Text.cxx is corrected to avoid storing reference to temporary object.

Off-topic: test parse rules are corrected to recognize situation when test is killed by elapsed time, and report it as such.

2 years ago0029308: Configuration, Inspectors - search of Qt in CMake scripts is separated from...
apn [Fri, 19 Jul 2019 10:52:33 +0000 (13:52 +0300)]
0029308: Configuration, Inspectors - search of Qt in CMake scripts is separated from search of other 3rd-party libs

Qt for inspector and samples is searched together with all 3rd-party products

2 years ago0030967: Configuration, genproj.tcl - generate OCCProducts solution for products
kgv [Mon, 16 Sep 2019 08:08:23 +0000 (11:08 +0300)]
0030967: Configuration, genproj.tcl - generate OCCProducts solution for products

genproj procedure has been extended with new parameters -solution, set to OCCT by default.
Added missing HAVE_RAPIDJSON to env.sh.

Added implicit file path normalization for PRODUCTS_PATH variable,
to avoid genconf.tcl script malfunction on backslashed.

2 years ago0030968: Update the upgrade guide regarding the issue 30778
msv [Mon, 16 Sep 2019 06:51:03 +0000 (09:51 +0300)]
0030968: Update the upgrade guide regarding the issue 30778

2 years ago0030866: Visualization - remove map of AIS_Manipulator from ViewerText
mzernova [Fri, 13 Sep 2019 12:13:29 +0000 (15:13 +0300)]
0030866: Visualization - remove map of AIS_Manipulator from ViewerText

ViewerTest_MapOfAISManipulators and ViewerTest_AISManipulator have been removed from ViewerTest

2 years ago0028144: Modeling Data, GeomAdaptor_Curve - regression in comparison of version OCCT654
abv [Wed, 4 Sep 2019 19:57:24 +0000 (22:57 +0300)]
0028144: Modeling Data, GeomAdaptor_Curve - regression in comparison of version OCCT654

Test case moved to grid modalg_7 and corrected to use BREP instead of STEP, and to use wireframe in 3D viewer

2 years ago0030302: XCAF - Typo in XCAFDoc_GeomTolerance OCCT-740beta2 V7_4_0_beta
gka [Thu, 12 Sep 2019 12:21:19 +0000 (15:21 +0300)]
0030302: XCAF - Typo in XCAFDoc_GeomTolerance

Typo in the XCAFDoc_GeomTolerance.cxx where Loc is used instead of aPnt was corrected.

2 years ago0030113: Data Exchange - STL file in text format with "Facet" keywords can't be imported
gka [Thu, 12 Sep 2019 13:30:09 +0000 (16:30 +0300)]
0030113: Data Exchange - STL file in text format with "Facet" keywords can't be imported

Case-sensitive method strncmp used in the REStl_Reader cosidered register of letter was replaced on the method _strnicmp for Windows and strncasecmp for Linux and MacOs
Test script for case 0030113

2 years ago0030831: ShapeFix algorithm (creation of seam edge) takes too long time with thin...
agv [Wed, 3 Jul 2019 17:04:16 +0000 (20:04 +0300)]
0030831: ShapeFix algorithm (creation of seam edge) takes too long time with thin faces

In class ShapeFix_ComposeShell the U- and V-closedness of input face is taken immediately avoiding the error when the face is small in any of these dimensions.
Test case for bug 0030831

2 years ago0030948: Configuration, CMake - problem building with CMake 3.15.2
abv [Fri, 6 Sep 2019 05:52:03 +0000 (08:52 +0300)]
0030948: Configuration, CMake - problem building with CMake 3.15.2

Minor corrections in CMake procedures and include statements

2 years ago0030946: Visualization - Image_AlienPixMap ignores 1-bit pixelformat when using FreeImage
mzernova [Tue, 10 Sep 2019 14:10:25 +0000 (17:10 +0300)]
0030946: Visualization - Image_AlienPixMap ignores 1-bit pixelformat when using FreeImage

Convert 1-bit image to 8-bit one during its loading because only greyscale images are supported by visualization

2 years ago0030775: Foundation Classes - Preserve application-defined top-level exception filter
kgv [Mon, 17 Jun 2019 15:42:36 +0000 (18:42 +0300)]
0030775: Foundation Classes - Preserve application-defined top-level exception filter

New overload for method OSD::SetSignal() is added accepting argument specifying how to set or unset handlers.
New enum OSD_SignalMode describes different modes of signal handlers setting used in extended version of OSD::SetSignal().
Method OSD::SignalMode() returns mode set by the last call to SetSignal().
Method OSD::IsFloatingSignalSet() is changed to return value based on actual floating point exception flags (rather than on variable set by previous call to SetSignal()).

Added new method OSD::SetThreadLocalSignal() intended to setup thread-specific handlers (e.g. _set_se_translator() on Windows) and FPE settings.
OSD_ThreadPool and Media_PlayerContext now use new method instead of OSD::SetSignal(), to avoid overriding global handlers.

dsetsignal syntax has been extended to support choice of signal handling mode.

DRAW command OCC30775 is added allowing to test signal handling in multithreaded process.

2 years ago0022777: Visualization - Unsafe way to get attribute values from MeshVS_Drawer
mzernova [Fri, 6 Sep 2019 10:56:40 +0000 (13:56 +0300)]
0022777: Visualization - Unsafe way to get attribute values from MeshVS_Drawer

Set default values for local variables used for storing values that are obtained by MeshVS_Drawer::Get****() methods

2 years ago0030963: Visualization, TKOpenGl - texture unit error during FFP global texture's...
iko [Thu, 12 Sep 2019 13:07:30 +0000 (16:07 +0300)]
0030963: Visualization, TKOpenGl - texture unit error during FFP global texture's parameters processing

The texture units used in FFP texture functions are correct now.

2 years ago0030959: OSD_Parallel_TBB: number of execution threads is strictly limited by the...
oan [Wed, 11 Sep 2019 08:04:03 +0000 (11:04 +0300)]
0030959: OSD_Parallel_TBB: number of execution threads is strictly limited by the root scope

Do not limit number of available threads by number of items processed within the root scope due to possibility of spawning of an additional threads within the subscopes.

2 years ago0030957: Data Exchange - Assembly item Id should not start with '/' symbol
tma [Mon, 9 Sep 2019 11:36:22 +0000 (14:36 +0300)]
0030957: Data Exchange - Assembly item Id should not start with '/' symbol

Fix test case: added parsing of the output of the dump note command

2 years ago0023380: BRepOffsetAPI_MakeFilling fails and leaves boundary faces with high tolerance
jgv [Thu, 5 Sep 2019 12:31:15 +0000 (15:31 +0300)]
0023380: BRepOffsetAPI_MakeFilling fails and leaves boundary faces with high tolerance

Avoid exception: use BRep_Builder for building wire instead of using BRepLib_MakeWire.

2 years ago0029858: Modeling Data - Regression in GeomAPI_ExtremaCurveCurve
aml [Tue, 3 Sep 2019 13:08:54 +0000 (16:08 +0300)]
0029858: Modeling Data - Regression in GeomAPI_ExtremaCurveCurve

Fix Newton's minimum projection algorithm onto boundaries in case of conditional optimization.
Add possibility to detect several optimal points at initialization of the math_GlobOptMin.

2 years agoIncrement OCCT version up to 7.4.0beta OCCT-740beta
bugmaster [Fri, 6 Sep 2019 16:04:41 +0000 (19:04 +0300)]
Increment OCCT version up to 7.4.0beta

2 years ago0030870: Data Exchange - Add the support for empty draughting models and empty presen...
drazmyslovich [Wed, 7 Aug 2019 08:04:53 +0000 (11:04 +0300)]
0030870: Data Exchange - Add the support for empty draughting models and empty presentation layer assignments for step import

Protections to avoid exception in the methods  RWStepVisual_RWDraughtingModel::ReadStep and RWStepVisual_RWPresentationLayerAssignment::ReadStep for case when assigned items are absent were added

2 years ago0029979: Data Exchange - Crash by reading STEP file
abv [Tue, 9 Jul 2019 11:47:21 +0000 (14:47 +0300)]
0029979: Data Exchange - Crash by reading STEP file

Added work-around against specific problem of ORIENTED_EDGE referring to another ORIENTED_EDGE instead of EDGE_CURVE.
Added handling of edges with null EDGE_CURVE, to allow passing the translation further instead of exception.

Off-topic: text of warning message is corrected in genproj

Added test bugs step bug29979

2 years ago0030880: Modeling Algorithms - Bug in BRepExtrema_ExtCF
emv [Thu, 22 Aug 2019 10:54:53 +0000 (13:54 +0300)]
0030880: Modeling Algorithms - Bug in BRepExtrema_ExtCF

Use the BRepTopAdaptor_FClass2d instead of BRepClass_FaceClassifier in BRepExtrema_ExtCF for classification of the found intersection points.

2 years ago0030704: Modeling Data, Bnd_OBB - Oriented bounding box gives a wrong result if a...
vro [Thu, 5 Sep 2019 08:23:30 +0000 (11:23 +0300)]
0030704: Modeling Data, Bnd_OBB - Oriented bounding box gives a wrong result if a box is added to a void box

Added protection on a void box to methods Bnd_OBB::Add() to escape taking into account "heap trash" coordinates of a void box.

2 years ago0030876: Data Exchange - StepToTopoDS edge translation should be resistant to malform...
drazmyslovich [Wed, 7 Aug 2019 12:49:59 +0000 (15:49 +0300)]
0030876: Data Exchange - StepToTopoDS edge translation should be resistant to malformed parameter values

Corrected misprint in the method CheckPCurves of the class StepToTopoDS_TranslateEdgeLoop for case when higher bound of the range of pcurve on the edge greater then last parameter of the pcurve.
Added check on the not periodic flag for pcurve when range pcurve on the edge is adjusted to parameters pcurve.

2 years ago0029269: Improvement for thread safety of the STEP translator - cleanup
gka [Wed, 2 Aug 2017 08:36:05 +0000 (11:36 +0300)]
0029269: Improvement for thread safety of the STEP translator - cleanup

Removal of unused stuff and some protections implemented within #29269

2 years ago0030778: [Regression to 7.3.0] Extrema raises exception StdFail_InfiniteSolutions
msv [Thu, 5 Sep 2019 15:09:06 +0000 (18:09 +0300)]
0030778: [Regression to 7.3.0] Extrema raises exception StdFail_InfiniteSolutions

The exception StdFail_InfiniteSolutions has been suppressed in all Points() methods.

2 years ago0030196: [REGRESSION] Modeling Algorithms - Crash in BRepBuilderAPI_GTransform
ifv [Tue, 3 Sep 2019 14:22:35 +0000 (17:22 +0300)]
0030196: [REGRESSION] Modeling Algorithms - Crash in BRepBuilderAPI_GTransform

Test case is added

2 years ago0030942: Draw Harness, ViewerTest - command vdefaults should abort script on unknown...
kgv [Thu, 5 Sep 2019 03:57:33 +0000 (06:57 +0300)]
0030942: Draw Harness, ViewerTest - command vdefaults should abort script on unknown argument

2 years ago0027534: [Regression to 6.9.1]: Infinite loop in Curve on Surface projection algorithm
aml [Tue, 3 Sep 2019 12:36:07 +0000 (15:36 +0300)]
0027534: [Regression to 6.9.1]: Infinite loop in Curve on Surface projection algorithm

Add test case.

2 years ago0030846: Foundation Classes - StorageInfo violates the C++ One Definition Rule
kgv [Wed, 4 Sep 2019 15:42:42 +0000 (18:42 +0300)]
0030846: Foundation Classes - StorageInfo violates the C++ One Definition Rule

Local definitions have been put into anonymouse namespace within files
OSD_MAllocHook.cxx and NCollection_BaseAllocator.cxx.

2 years ago0029717: Shape Healing - ShapeFix_Face::FixSmallAreaWire delivers a face with wrong...
drazmyslovich [Mon, 23 Apr 2018 14:38:32 +0000 (17:38 +0300)]
0029717: Shape Healing - ShapeFix_Face::FixSmallAreaWire delivers a face with wrong-oriented wires + 1 small crash-fix

- Fix FixSmallAreaWire for the reversed faces.

- Add nullptr check for FixOrient...

- Test bugs heal bug25923 is corrected to avoid relying on wrong orientation of face after fixing small wire

2 years ago0030721: Visualization - Arrows in dimensions are drawn behind some other lines after...
kgv [Wed, 4 Sep 2019 14:24:13 +0000 (17:24 +0300)]
0030721: Visualization - Arrows in dimensions are drawn behind some other lines after applying 30716

AIS_Dimension::DrawArrow() now disables polygon offsets for drawing 2D arrow,
so that it is expected to be drawn at the same depth as dimension line.

2 years agoTest for 0023979: Performance problem of STEP export for large files
abv [Wed, 4 Sep 2019 15:28:49 +0000 (18:28 +0300)]
Test for 0023979: Performance problem of STEP export for large files

2 years ago0030728: Visualization - using one implementation of highlight/unhighlight in context
nds [Wed, 4 Sep 2019 07:00:42 +0000 (10:00 +0300)]
0030728: Visualization - using one implementation of highlight/unhighlight in context

2 years ago0029516: Visualization - eliminate redundant property Graphic3d_MaterialAspect::Refle...
kgv [Fri, 30 Aug 2019 18:52:12 +0000 (21:52 +0300)]
0029516: Visualization - eliminate redundant property Graphic3d_MaterialAspect::ReflectionMode()

Decomposition of Ambient, Diffuse, Specular and Emissive properties has been eliminated within *Graphic3d_MaterialAspect* definition,
so that following methods of *Graphic3d_MaterialAspect* class have been removed:
SetReflectionMode(), SetReflectionModeOn(), Ambient(), Diffuse(), Emissive(), Specular(), SetAmbient(), SetDiffuse(), SetSpecular(), SetEmissive().

Graphic3d_NOM_NEON_GNC non-physical material definition has been corrected
and define WHITE emission color coefficient instead of YELLOW.

Added method Graphic3d_ClipPlane::SetCappingColor() for more straight-forward modification of Capping color in case of non-physical material.
Prs3d_ShadingAspect::Color() has been fixed to return InteriorColor instead of material color coefficient in case of non-physical material.

2 years ago0030938: Configuration, genproj - Support building with VS 2019
abv [Wed, 4 Sep 2019 06:35:15 +0000 (09:35 +0300)]
0030938: Configuration, genproj - Support building with VS 2019

Commands genproj and genconf are updated to support generation of projects for VS 2019, toolset v142

2 years ago0030931: Visualization, TKOpenGl - do not render into GL_FRONT within "GDI Generic...
kgv [Sun, 1 Sep 2019 10:19:40 +0000 (13:19 +0300)]
0030931: Visualization, TKOpenGl - do not render into GL_FRONT within "GDI Generic" renderer

OpenGl_Workspace now disables at initialization time
OpenGl_View::SetImmediateModeDrawToFront() property in case of "GDI Generic" OpenGL implementation.

OpenGl_View::redrawImmediate() - fixed no buffer swap in case of
myTransientDrawToFront without offscreen FBO.

2 years ago0030930: Draw Harness, ViewerTest - add commands vlistcolors and vlistmaterials listi...
kgv [Fri, 30 Aug 2019 14:54:09 +0000 (17:54 +0300)]
0030930: Draw Harness, ViewerTest - add commands vlistcolors and vlistmaterials listing standard Colors and Materials

Introduced two new commands vlistcolors listing named colors and vlistmaterials listing standard materials.
These commands also can generate HTML table listing colors/materials with their properties.
vlistmaterials can generate OBJ model for comparing OCCT materials in different viewers.
New test cases use these commands for generating HTML tables.

Graphic3d_MaterialAspect::MaterialType() - added missing getter.
Corrected name of unlit shading model within vaspects and vrenderparams commands.

2 years ago0028242: [Regression] HLR Poly Algo has broken edges
abv [Mon, 2 Sep 2019 15:15:55 +0000 (18:15 +0300)]
0028242: [Regression] HLR Poly Algo has broken edges

Added test hlr poly_hlr bug28242

2 years ago0029334: Simple offsets complicate geometry
abv [Mon, 20 Nov 2017 05:51:32 +0000 (08:51 +0300)]
0029334: Simple offsets complicate geometry

Method BRepOffset::Surface() is used in simple offset algorithm to create offset surface, instead of direct and unconditional construction of new Geom_OffsetSurface instance.

Added test bugs modalg_7 bug29334

2 years ago0030927: Modeling Algorithms - UnifySameDom looses the Closed flag for wires IR-2019-08-30
jgv [Thu, 29 Aug 2019 16:02:25 +0000 (19:02 +0300)]
0030927: Modeling Algorithms - UnifySameDom looses the Closed flag for wires

Add setting the Closed flag for a new wire

2 years ago0030926: Data Exchange - Change of the number of GDT points of a View may lead to...
vro [Thu, 29 Aug 2019 13:20:50 +0000 (16:20 +0300)]
0030926: Data Exchange - Change of the number of GDT points of a View may lead to a crash

2 years ago0030923: Visualization, AIS_ViewCube - avoid mixing non-zoomable text and trihedron...
kgv [Tue, 27 Aug 2019 11:26:45 +0000 (14:26 +0300)]
0030923: Visualization, AIS_ViewCube - avoid mixing non-zoomable text and trihedron-persistence

Box sides labels are now drawn with zoomable flag.

2 years ago0030919: ACIS Import - Improving translation of string attributes into XDE
anv [Wed, 28 Aug 2019 13:31:12 +0000 (16:31 +0300)]
0030919: ACIS Import - Improving translation of string attributes into XDE

- Added possibility to get (or create if absent) a properties attribute via ShapeTool;
- Added Draw command to print properties attached to a Label.

2 years ago0030914: Modeling Algorithms - Improve performance of UnifySameDom algorithm for...
emv [Mon, 26 Aug 2019 13:31:52 +0000 (16:31 +0300)]
0030914: Modeling Algorithms - Improve performance of UnifySameDom algorithm for specific case with many edges

Use cached containers to find the necessary shapes.

2 years ago0030913: Invalid result of Fusing slices
emv [Mon, 19 Aug 2019 05:33:40 +0000 (08:33 +0300)]
0030913: Invalid result of Fusing slices

Refactoring of the Line-Line intersection method strengthening the parallel and coincidence criteria to allow almost parallel lines have an intersection point.

2 years ago0030903: Bug in IntCurvesFace_ShapeIntersector
emv [Tue, 27 Aug 2019 07:02:26 +0000 (10:02 +0300)]
0030903: Bug in IntCurvesFace_ShapeIntersector

When classifying the intersection point check the ON status in 3D - compare the 3D distances with 3D tolerance.

2 years ago0030924: Coding - incorrect header in file OSD_ThreadPool.hxx
kgv [Wed, 28 Aug 2019 07:09:56 +0000 (10:09 +0300)]
0030924: Coding - incorrect header in file OSD_ThreadPool.hxx

Fixed license statements within files BRepGProp_MeshProps.cxx, BRepGProp_MeshProps.hxx,
OSD_ThreadPool.cxx and OSD_ThreadPool.hxx.

Removed non-ASCII char from BRepMesh_ModelHealer.hxx.

2 years ago0030915: Visualization - AIS_ColorScale::FindColor() returns Wrong color for maximal...
kgv [Mon, 26 Aug 2019 08:08:23 +0000 (11:08 +0300)]
0030915: Visualization - AIS_ColorScale::FindColor() returns Wrong color for maximal value

Map the very upper value (theValue==theMax) to the largest color interval.

2 years ago0030857: Visualization - using one implementation of Text in graphic group IR-2019-08-23
nds [Fri, 23 Aug 2019 11:28:04 +0000 (14:28 +0300)]
0030857: Visualization - using one implementation of Text in graphic group

Graphic3d_Group::Text(...) are obsolete, AddText() should be used instead of these methods.
Graphic3d_Text is a new class for parameters necessary to fill OpenGl_Text. All parameters of Graphic3d_Group::Text() are moved into this class.

OpenGl_TextParam is removed, these fields were moved into Graphic3d_Text.
OpenGl_Text constructors/Init with OpenGl_TextParam parameter were removed. Constructor with Graphic3d_Text should be used instead of it.
Using OpenGl_Text Init() with OpenGl_TextParam should be now replaced on two cases. The first case is setting values into Graphic3d_Text and the second case is calling Reset() after. As example, look at modification in OpenGl_FrameStatsPrs.

2 years ago0030807: Visualization, TKOpenGl - supporting cubemaps
iko [Tue, 9 Jul 2019 13:55:49 +0000 (16:55 +0300)]
0030807: Visualization, TKOpenGl - supporting cubemaps

A cubemap texture initialization has been implemented.
Setting environment cubemap as interactive background is posssible now.

2 years ago0030905: Modeling Algorithms - Faulty shapes in UnifySameDomain
emv [Tue, 20 Aug 2019 11:23:29 +0000 (14:23 +0300)]
0030905: Modeling Algorithms - Faulty shapes in UnifySameDomain

Make face FORWARD before adding wire in it.

2 years ago0029662: Modeling Data - Allow replacement of Compounds via BRepTools_ReShape
anv [Thu, 29 Mar 2018 09:36:09 +0000 (12:36 +0300)]
0029662: Modeling Data - Allow replacement of Compounds via BRepTools_ReShape

- Fixed condition to allow proceeding of nested compounds;
- Added new key to "reshape" draw command to state a level of type until which requests are taken into account;
- Test case added.

2 years ago0030874: Modeling Algorithms - GCPnts_TangentialDeflection inserts the points between...
drazmyslovich [Wed, 7 Aug 2019 12:10:32 +0000 (15:10 +0300)]
0030874: Modeling Algorithms - GCPnts_TangentialDeflection inserts the points between nearby points

Check the points distance before inserting a new point in between.

2 years ago0030906: Visualization, SelectMgr_ViewerSelector - Object clipping planes overrides...
kgv [Tue, 20 Aug 2019 13:28:33 +0000 (16:28 +0300)]
0030906: Visualization, SelectMgr_ViewerSelector - Object clipping planes overrides View clipping plane for next objects

Clipping range has been moved from SelectMgr_RectangularFrustum to SelectMgr_SelectingVolumeManager
and passed to frustum as an argument to Overlap() methods.
This fixes an issue when Clipping is customized per-object within SelectMgr_ViewerSelector::traverseObject()
in case when shallow copy of SelectMgr_SelectingVolumeManager is created
(frustums are copied from global frustum manager by Handle).

2 years ago0030901: Visualization - OSD_MemInfo moving memory computation out of the constructor IR-2019-08-16
nds [Thu, 15 Aug 2019 10:17:18 +0000 (13:17 +0300)]
0030901: Visualization - OSD_MemInfo moving memory computation out of the constructor

2 years ago0030900: Configuration - fix compilation using macOS SDK before 10.12
kgv [Wed, 14 Aug 2019 22:04:45 +0000 (01:04 +0300)]
0030900: Configuration - fix compilation using macOS SDK before 10.12

ViewerTest - added compatibility defines.

2 years ago0030899: Data Exchange, RWObj_Reader - reading multiline file with more than one...
kgv [Wed, 14 Aug 2019 12:06:55 +0000 (15:06 +0300)]
0030899: Data Exchange, RWObj_Reader - reading multiline file with more than one line separator leads to memory corruption

Fix misprint in condition.

2 years ago0030897: Modeling Algorithms - Crash in UnifySameDomain [Regression]
msv [Tue, 13 Aug 2019 13:00:48 +0000 (16:00 +0300)]
0030897: Modeling Algorithms - Crash in UnifySameDomain [Regression]

The regression caused by the patch for 0030534 has been eliminated. For that the method InsertWiresIntoFaces() has been corrected: the face to which a wire is added is first oriented as forward.

2 years ago0026978: VIS - Interactive selection is insensitive to swept shell
kgv [Mon, 12 Aug 2019 14:47:28 +0000 (17:47 +0300)]
0026978: VIS - Interactive selection is insensitive to swept shell

IVtkOCC_SelectableObject::BoundingBox(), AIS_Shape::BoundingBox() now don't use
BRepBndLib::AddClose() on arbitrary shapes.

2 years ago0008239: Foundation Classes - directive "using namespace std" doesn't allow to build...
kgv [Tue, 13 Aug 2019 08:33:20 +0000 (11:33 +0300)]
0008239: Foundation Classes - directive "using namespace std" doesn't allow to build application with OCC and other 3rd party libraries

Standard_Stream.hxx no more adds "using std::" entities.

2 years ago0030895: Coding Rules - specify std namespace explicitly for std::cout and streams
tiv [Fri, 2 Aug 2019 07:32:16 +0000 (10:32 +0300)]
0030895: Coding Rules - specify std namespace explicitly for std::cout and streams

"endl" manipulator for Message_Messenger is renamed to "Message_EndLine".

The following entities from std namespace are now used
with std:: explicitly specified (from Standard_Stream.hxx):

2 years ago0030286: Cover polygonal HLR algorithm by regression tests
jgv [Tue, 18 Dec 2018 13:57:32 +0000 (16:57 +0300)]
0030286: Cover polygonal HLR algorithm by regression tests

New folder "hlr" with subfolders "exact_hlr" and "poly_hlr" has been created.
Draw command "vcomputehlr" has been corrected.
QA command "OCC27341" has been deleted as "vcomputehlr" does its job.

2 years ago0030888: Data Exchange, RWGltf_CafReader - fix misprint in condition while iterating...
kgv [Fri, 9 Aug 2019 21:16:05 +0000 (00:16 +0300)]
0030888: Data Exchange, RWGltf_CafReader - fix misprint in condition while iterating binary glTF 2.0 chunks

2 years ago0030872: In case of failure, retry to acquire the driver for the format IR-2019-08-09
drazmyslovich [Wed, 7 Aug 2019 11:01:13 +0000 (13:01 +0200)]
0030872: In case of failure, retry to acquire the driver for the format

2 years ago0030863: Visualization, SelectMgr_ViewerSelector - disabling of View clipping planes...
kgv [Fri, 9 Aug 2019 10:00:30 +0000 (13:00 +0300)]
0030863: Visualization, SelectMgr_ViewerSelector - disabling of View clipping planes is ignored for transformed objects

SelectMgr_ViewerSelector::computeFrustum() - fixed lost clipping planes when creating a new frustum.

2 years ago0030854: Visualization, AIS_ViewCube - pack triangulations into common array(s)
kgv [Mon, 5 Aug 2019 17:26:11 +0000 (20:26 +0300)]
0030854: Visualization, AIS_ViewCube - pack triangulations into common array(s)

Presentation computation has been modified to merge triangulations per box part type.
Prs3d_Drawer::FaceBoundaryDraw() flag is now handled for drawing box sides edges.

Graphic3d_ArrayOfPrimitives has been extended by auxiliary methods:
- ::AddSegmentEdges(), ::AddTriangleEdges(), ::AddQuadEdges() raising exception on wrong primitive type.
- ::AddQuadTriangleEdges() splitting quad into indexed triangulation;
- ::AddTriangleStripEdges() splitting triangle strip into indexed triangulation;
- ::AddTriangleFanEdges() splitting triangle fan into indexed triangulation;
- ::AddPolylineEdges() splitting polyline into indexed segments.

2 years ago0030869: Modeling Data - BRepAdaptor_CompCurve incorrectly evaluates the boundary...
emv [Wed, 7 Aug 2019 06:40:42 +0000 (09:40 +0300)]
0030869: Modeling Data - BRepAdaptor_CompCurve incorrectly evaluates the boundary points

Problem is solved by #0029430. Integrating test case only.

2 years ago0030695: Visualization - selection by box should use clipping planes set for viewer...
nds [Wed, 7 Aug 2019 06:42:33 +0000 (09:42 +0300)]
0030695: Visualization - selection by box should use clipping planes set for viewer - moving check on touching the clipping plane in selection only.

2 years ago0030425: Visualization - possibility to redefine AIS_Selection
nds [Tue, 25 Dec 2018 06:26:49 +0000 (09:26 +0300)]
0030425: Visualization - possibility to redefine AIS_Selection

2 years ago0030865: Samples - sample for 3D version of new OCC logo
abv [Tue, 6 Aug 2019 09:37:56 +0000 (12:37 +0300)]
0030865: Samples - sample for 3D version of new OCC logo

Added new Tcl sample "logo2019.tcl" and relevant test demo/samples/logo2019

2 years ago0030864: Global variable Version defined in TopTools_ShapeSet.cxx is superseded by...
msv [Tue, 6 Aug 2019 06:34:18 +0000 (09:34 +0300)]
0030864: Global variable Version defined in TopTools_ShapeSet.cxx is superseded by same name variable from executable

The variable Version defined in TopTools_ShapeSet.cxx has been declared as static to limit its scope.

2 years ago0030856: Data Exchange - Wrong colors after STEP file import
ika [Wed, 31 Jul 2019 15:09:04 +0000 (18:09 +0300)]
0030856: Data Exchange - Wrong colors after STEP file import

Fix processing of colors, attached to assemblies in STEP file.

2 years ago0030534: Regression in the tool UnifySameDomain - the shape looses faces
jgv [Fri, 15 Mar 2019 09:55:09 +0000 (12:55 +0300)]
0030534: Regression in the tool UnifySameDomain - the shape looses faces

1. Add method TransformPCurves to ShapeUpgrade_UnifySameDomain - to rotate and translate existing pcurves instead of projecting.
2. Modify method ShapeUpgrade_UnifySameDomain::IntUnifyFaces - now it does not apply ShapeFix to new wires and new faces.
3. In the method UnifyEdges: add merging degenerated edges.

2 years ago0030835: Possible performance improvements in methods TDF_Label::FindAttribute
mpv [Mon, 29 Jul 2019 14:11:54 +0000 (17:11 +0300)]
0030835: Possible performance improvements in methods TDF_Label::FindAttribute

Make attribute iterator work with pointers to attributes, so, creation of handle on each iteration is avoided.

2 years ago0029837: Visualization, Graphic3d_Camera - Fit All operation works incorrectly on...
kgv [Mon, 29 Jul 2019 00:21:28 +0000 (03:21 +0300)]
0029837: Visualization, Graphic3d_Camera - Fit All operation works incorrectly on flat object

Graphic3d_Camera has been revised to store camera Direction from Eye explicitly
and Distance to Center instead of auxiliary Center point.

This allows setting camera Distance to 0 (for flat objects) without side effects
like broken FitAll, wobbling on rotating.

2 years ago0026154: Visualization - v3d viewer grid disappears due to automatic z-fit
kgv [Mon, 29 Jul 2019 14:49:58 +0000 (17:49 +0300)]
0026154: Visualization - v3d viewer grid disappears due to automatic z-fit

V3d_RectangularGrid, V3d_CircularGrid, fixed initialization of presentation bounding box (lost Z offset).

2 years ago0030855: Coding - New warnings within Standard_ReadLineBuffer after integration fix...
kgv [Sun, 28 Jul 2019 09:24:53 +0000 (12:24 +0300)]
0030855: Coding - New warnings within Standard_ReadLineBuffer after integration fix for 0030830

Added missing cast.

2 years ago0030744: Visualization, TKOpenGl - stipple line does not work on OpenGL ES 2.0 IR-2019-07-27
kgv [Fri, 19 Jul 2019 13:35:23 +0000 (16:35 +0300)]
0030744: Visualization, TKOpenGl - stipple line does not work on OpenGL ES 2.0

OpenGl_ShaderManager now provides fallback stipple lines GLSL code for obsolete OpenGL ES 2.0 devices.
OpenGl_Caps has been extended by flags disallowing OpenGL extensions usage
and restricting upper OpenGL version to be used by OCCT for testing purposes.

2 years ago0030830: Point Cloud Rendering - use temporary buffer to read lines from .pts and...
osa [Wed, 24 Jul 2019 11:30:53 +0000 (14:30 +0300)]
0030830: Point Cloud Rendering - use temporary buffer to read lines from .pts and .ptx files

Add Standard_ReadLineBuffer - auxiliary tool for buffered reading of lines from input stream.

2 years ago0030853: Visualization, AIS_ViewController - fix 1 pixel Y shift while zooming
kgv [Fri, 26 Jul 2019 02:59:39 +0000 (05:59 +0300)]
0030853: Visualization, AIS_ViewController - fix 1 pixel Y shift while zooming

Fixed error in math converting Y-down mouse coordinates into Y-up within AIS_ViewController::handleZoom().
Added flags ToStickToRayOnZoom()/ToStickToRayOnRotation() enabled by default,
which will project picked point onto ray at mouse cursor to preserve focus on zoom out.

2 years ago0030850: Visualization, OpenGl_Text - text within trihedron persistence jitters when... IR-2019-07-19
kgv [Wed, 17 Jul 2019 21:08:02 +0000 (00:08 +0300)]
0030850: Visualization, OpenGl_Text - text within trihedron persistence jitters when camera is far from origin

OpenGl_Text now discards (redundant) translation part from camera orientation matrix.
Text anchor point alignment to integer coordinates is now not performed for 3D-oriented text.

2 years ago0028954: Visualization - implement interactive object for camera manipulations
aba [Wed, 3 Jul 2019 09:37:36 +0000 (12:37 +0300)]
0028954: Visualization - implement interactive object for camera manipulations

Added new class AIS_ViewCube implementing interactive cube
displaying orientation of the main axes of the model space in the viewer.
Each side, edge, or corner of the cube corresponds to particular orientation of the camera,
and the class provides methods to move the camera to corresponding position (with animation if needed).

AIS_InteractiveContext::LastActiveView(), added new property returning the last View processed by MoveTo() event.
AIS_InteractiveContext::BoundingBoxOfSelection(), added method returning bounding box of selected objects.
SelectMgr_EntityOwner::HandleMouseClick(), added new callback for handling
mouse clicks by owner itself without automatic highlighting and clearing previous selection.
Called by AIS_InteractiveContext::Select() method.

AIS_ViewController::ViewAnimation() has been extened with camera animation propery,
which can be bound to AIS_ViewCube for smooth embedding into event loop.

Prs3d_ToolDisk has been extended with parameters specifying angle range.
Graphic3d_MaterialAspect now initializes all coefficients to 1.0
when Graphic3d_NOM_UserDefined is passed to class constructor.
AIS_AnimationCamera::update() now sets the end camera position if animation duration is 0.
Prs3d_DatumAspect, added missing setters.

New command vviewcube has been added.

2 years ago0030790: [REGRESSION] Modeling Algorithms - Crash when loading specific step file
msv [Mon, 15 Jul 2019 16:47:14 +0000 (19:47 +0300)]
0030790: [REGRESSION] Modeling Algorithms - Crash when loading specific step file

The problem occurred when the algorithm IntCurvesFace_Intersector was called for a face occupying zero extension along V direction. This is obviously a bad face, but we need to have the algorithm not crashing the application. So, the algorithm has been protected against such input data. At attempt to make calculations it establishes NotDone status.

Bad test case tests/de/step_3/D9 has been updated.
False memory leak detection has been suppressed in tests/bugs/fclasses/bug7287_2.

2 years ago0030799: Draw Harness, ViewerTest - setup uniforms via vshader command
mzernova [Wed, 17 Jul 2019 16:05:53 +0000 (19:05 +0300)]
0030799: Draw Harness, ViewerTest - setup uniforms via vshader command

vshaderprog command now supports setup custom uniforms

2 years ago0030668: Visualization - revise adding ZLayer API
kgv [Mon, 15 Jul 2019 18:06:05 +0000 (21:06 +0300)]
0030668: Visualization - revise adding ZLayer API

V3d_Viewer::AddZLayer() has been replaced by
V3d_Viewer::InsertLayerBefore() and V3d_Viewer::InsertLayerAfter() methods
allowing to specify Layer settings and index of existing layer to insert new one before/after.
The behavior of V3d_Viewer::AddZLayer() has been adjusted to append
new Layer before Graphic3d_ZLayerId_Top
(between Graphic3d_ZLayerId_Default and Graphic3d_ZLayerId_Top).

Graphic3d_Layer now provides LayerId() property.
Graphic3d_ZLayerSettings has been extended with IsRaytracable() property;
Ray-Tracing now processes multiple layers instead of Graphic3d_ZLayerId_Default.

Moved some methods from OpenGl_View to the base class Graphic3d_CView.

2 years ago0030630: Visualization - wrong visualization of shape with mirrored transformation
ika [Thu, 4 Apr 2019 13:07:05 +0000 (16:07 +0300)]
0030630: Visualization - wrong visualization of shape with mirrored transformation

Solids with mirror location are displayed, according to their normals.

vaspects -setBackFaceColor, added command to set backface color.

2 years ago0030829: BRepExtrema_ShapeProximity crashes with shape from STL/WRL
msv [Wed, 17 Jul 2019 13:50:43 +0000 (16:50 +0300)]
0030829: BRepExtrema_ShapeProximity crashes with shape from STL/WRL

The fix makes algorithm independent on geometrical data. Only triangulation is needed for its work.

2 years ago0030403: Application Framework - Overwriting Big BinOcaf Files Does Not Reduce Their...
Benjamin Bihler [Thu, 11 Jul 2019 09:16:12 +0000 (11:16 +0200)]
0030403: Application Framework - Overwriting Big BinOcaf Files Does Not Reduce Their Size

OSD_OpenFileDescriptor(), added truncating flag to fopen() flags for std::ios_base::out,
since truncating is implied by C++ output flag.
This fixes misbehavior of OSD_OpenStream() on MinGW-w64 platform.

2 years ago0029736: Some Warnings During Compound Transfer to IGES Look Dubious
abv [Wed, 10 Jul 2019 18:45:45 +0000 (21:45 +0300)]
0029736: Some Warnings During Compound Transfer to IGES Look Dubious

Incorrect (legacy) warnings during IGES export are removed

2 years ago0030628: [REGRESSION] Data Exchange - Crash on importing STEP file
kgv [Thu, 11 Jul 2019 06:38:54 +0000 (09:38 +0300)]
0030628: [REGRESSION] Data Exchange - Crash on importing STEP file

RWHeaderSection_RWFileDescription::ReadStep(), added check for an empty list.

2 years ago0029987: Request for translation of French comments in the code IR-2019-07-12
ysn [Wed, 25 Jul 2018 15:13:26 +0000 (18:13 +0300)]
0029987: Request for translation of French comments in the code

French comments in two files have been translated in English.

2 years ago0030837: Data Exchange, XCAFPrs_DocumentExplorer - fix misprint in XCAFPrs_DocumentEx...
kgv [Wed, 10 Jul 2019 20:24:05 +0000 (23:24 +0300)]
0030837: Data Exchange, XCAFPrs_DocumentExplorer - fix misprint in XCAFPrs_DocumentExplorerFlags_NoStyle check

2 years ago0027710: Make Data-exchange test cases more machine independent
apn [Thu, 8 Sep 2016 12:20:43 +0000 (15:20 +0300)]
0027710: Make Data-exchange test cases more machine independent

Added description of de test grid in user guide.