kgv [Sat, 22 Jul 2017 10:58:22 +0000 (13:58 +0300)]
0028937: Tests, testdiff - link image in diff to the test cases log
kgv [Sat, 22 Jul 2017 11:21:39 +0000 (14:21 +0300)]
0028938: Tests - remove useless file artifacts of test cases perf/de/bug26338
apv [Tue, 25 Jul 2017 10:03:24 +0000 (13:03 +0300)]
Test for
0024145: OCCT fails to project a wire onto BSplineSurface using BRepAlgo_NormalProjection
anv [Wed, 28 Jun 2017 13:10:30 +0000 (16:10 +0300)]
0028871: Various problems in SAT export
apn [Wed, 19 Jul 2017 15:34:09 +0000 (18:34 +0300)]
0028920: Samples - fix msvc.bat for building samples without CMake
Added DevEnvDir to env.bat.
Added window title to "start" command in msvc.bat files.
mkv [Fri, 21 Jul 2017 13:41:14 +0000 (16:41 +0300)]
Test for
0028551: Bad result of general fuse
kgv [Fri, 21 Jul 2017 09:11:19 +0000 (12:11 +0300)]
0028930: Coding Rules - eliminate GCC compiler warnings -Wmisleading-indentation
mkv [Fri, 21 Jul 2017 14:00:38 +0000 (17:00 +0300)]
Test for
0023025: OCC exception is raised when making an extrusion with draft angle from a simple line
mkv [Fri, 14 Jul 2017 16:56:05 +0000 (19:56 +0300)]
Test for
0023176: Intersection of cylinder and cone produces open curve
kgv [Wed, 19 Jul 2017 14:38:54 +0000 (17:38 +0300)]
0028927: Visualization - Graphic3d_StructureManager destructor should invalidate its pointer in Graphic3d_Structure
Graphic3d_Structure::myFirstStructureManager - removed unused class field.
~Graphic3d_StructureManager() now removes displayed Structures explicitly.
kgv [Wed, 19 Jul 2017 09:34:09 +0000 (12:34 +0300)]
0028923: Foundation Classes - Message_Messenger::Send() implementation is not thread-safe
Use (Message_SequenceOfPrinters::Iterator instead of accessing sequence elements by index.
kgv [Mon, 10 Jul 2017 12:43:25 +0000 (15:43 +0300)]
0028912: Visualization, TKOpenGl - multi-texture support
Graphic3d_AspectFillArea3d now stores array of textures.
Graphic3d_TextureParams stores texture unit for mapping texture.
OpenGl_Context::BindTextures() - context now manages the set of active textures.
Related code has been removed from OpenGl_Workspace.
OpenGl_Sampler has been extended to hold texture parameters structure.
OpenGl_Texture now holds OpenGl_Sampler instance as class field.
OpenGl_Texture inherits new class OpenGl_NamedResource and holds
texture identifier used for sharing resource in OpenGl_Context.
OpenGl_RaytraceGeometry now creates bindless textures taking
Sampler object directly from OpenGl_Texture.
OpenGl_Context::BindTextures() automatically recreates immutable
Sampler Object on texture parameters change.
Declared new structure OpenGl_ArbSamplerObject for platform-neutral
usage of related functionality.
Related functions are now loaded within OpenGL ES 3.0+.
Declarations.glsl - occActiveSampler has been renamed to occSampler0
with aliases occSamplerBaseColor (main) and occActiveSampler (for compatibility).
Additional texture samplers should be declared explicitly
within specific GLSL program as occSampler1, occSampler2, etc.
AIS_Shape and AIS_ColoredShape now computes Shaded presentation
with UV coordinates if texture mapping is enabled in Drawer.
vshaderprog now accepts Shader source code as parameter.
kgv [Mon, 17 Jul 2017 12:19:33 +0000 (15:19 +0300)]
0028811: Visualization - merge texturing support into AIS_Shape class and get rid of AIS_TexturedShape
AIS_Shape and AIS_ColoredShape now computes Shaded presentation
with UV coordinates if texture mapping is enabled in Drawer.
OpenGl_Context::SetTextureMatrix() - fixed inconsistent handling
of texture cooridnates translation vector.
vtexture command has been extended to handle new arguments:
* -trsfTrans, -trsfScale, -trsfAngle defining transformation matrix
* -setFilter, -setAnisoFilter to setup texture filtering
abv [Wed, 19 Jul 2017 09:09:21 +0000 (12:09 +0300)]
0028922: Configuration - remove useless Standard_EXPORT in SelectMgr_Frustum::hasOverlap()
mkv [Fri, 14 Jul 2017 15:31:16 +0000 (18:31 +0300)]
Test for
0023166: Intersection of plane and cone produces wrong result
mkv [Wed, 19 Jul 2017 15:05:42 +0000 (18:05 +0300)]
Test for
0023187: Cut with a compound
kgv [Mon, 17 Jul 2017 08:12:48 +0000 (11:12 +0300)]
0028915: Configuration, Font_BRepFont - do not include FreeType headers within OCCT headers
mkv [Thu, 13 Jul 2017 12:43:41 +0000 (15:43 +0300)]
Test for
0022919: Shape Healing fails to correct a face with missing seam
kgv [Mon, 3 Jul 2017 17:22:56 +0000 (20:22 +0300)]
0028887: TKJT - add option to cache file content
Added new auxiliary class Standard_ArrayStreamBuffer implementing
std::streambuf interface for defining std::istream from allocated memory.
apn [Tue, 30 May 2017 14:27:41 +0000 (17:27 +0300)]
0028769: Unification of msvc.bat files.
Modify mfc and qt samples for supporting VS 2017.
Create general vcxproj files for all mfc samples.
Correction msvc.bat and msvc_D3D.bat in CSharp sample
abv [Tue, 2 May 2017 05:36:49 +0000 (08:36 +0300)]
0028701: Configuration - add support of VS 2017
Added support of Visual Studio 2017 (15) in CMake build procedure.
CMake 3.7.2 or above is required to generate projects for VS 2017.
Since version of compiler and toolset remained at 14 (now they are 14.1), and they use the same run-time, the same third-party products as for VS 2015 (14) can be used.
Also the name of the folder for installation of OCCT binaries in OCCT-standard layout (default on Windows) remains "vc14".
Support of Visual Studio 2017 is added in genproj generator and relevant environment, with format specifier "vc141".
The syntax of the genproj command is revised:
- UWP is considered as separate platform ("uwp" alternative to "wnt"), not part of IDE specification
- Option "IDE" is renamed to "Format"
- Obsolete name of local variable "aWokStation" is replaced by equivalent "theFormat"
In environment scripts, additional variables are defined (derived from VCVER, see adm/vcver.bat):
- VCLIB defines name of the subdirectory specific to VS version; it is the same as VCVER except that for VCVER=vc141 VCLIB=vc14 and for VCVER=141-uwp VCLIB=vc14-uwp
- VCFMT is VCVER without optional suffix "-uwp"
- VCPROP is "NativeDesktop" for normal builds or "Universal" for UWP builds
Command genconf is amended to:
- Detect presence of VS 2017 (separately for desktop and UWP)
- Use only two first digits after "vc" in format specification for search of third-party libs
- Have more space in user interface for VS specification
All supported variants of VCVER variable are documented in dev guides / buiding / msvc
mkv [Thu, 13 Jul 2017 10:28:20 +0000 (13:28 +0300)]
Test for
0022886: Bug in boolean
ifv [Thu, 15 Jun 2017 08:53:29 +0000 (11:53 +0300)]
0028856: Extrema between two curves gives wrong result
Treatment for large Lipschitz constant is added
Test case is added
kgv [Mon, 10 Jul 2017 12:43:25 +0000 (15:43 +0300)]
0028895: Visualization, V3d_View::SetComputedMode() - HLR calculation is performed multiple times when 'hlr on' has been called
V3d_View::SetComputedMode() - removed implicit View update.
Graphic3d_CView::SetComputedMode(), ::ReCompute() - fixed
uninitialized bounding box of Computed structure.
PrsMgr_Presentation::Compute() - fixed computation of Computed structure
with transformation within Connected presentation.
StdPrs_HLRPolyShape::Add() now creates Graphic3d_ArrayOfSegments instead of
inefficient Graphic3d_ArrayOfPolylines with boundaries at every segment.
Fixed error in test case bugs/vis/bug24388_1.
kgv [Fri, 7 Jul 2017 14:06:09 +0000 (17:06 +0300)]
0028890: Visualization - After closing all views and then display the view again, just the first view has object(s) displayed
DeviceLost flag has been moved from Graphic3d_GraphicDriver to Graphic3d_StructureManager,
so that all Viewers sharing the same Driver instance are properly invalidated.
Fixed clearing of objects by vclear command in case of multiple Viewers.
mkv [Wed, 12 Jul 2017 10:22:08 +0000 (13:22 +0300)]
Test for
0022487: Reading IGES file produces invalid shape
mkv [Tue, 11 Jul 2017 17:06:45 +0000 (20:06 +0300)]
Test for
0022394: Not valid shape after read iges
mkv [Tue, 11 Jul 2017 15:49:33 +0000 (18:49 +0300)]
Test for
0022288: checkshape works wrong with attached shape.
mkv [Tue, 11 Jul 2017 14:11:25 +0000 (17:11 +0300)]
Test for
0022283: Problem with reading of attached IGES file.
kgv [Mon, 10 Jul 2017 10:40:54 +0000 (13:40 +0300)]
0026213: Visualization - replace sequence in Select3D_SensitiveGroup
NCollection_IndexedMap is now used instead of NCollection_Sequence within Select3D_SensitiveGroup.
kgv [Mon, 10 Jul 2017 08:24:29 +0000 (11:24 +0300)]
0028907: Coding Rules, OpenGl_GraphicDriver - fix class fields accidentally marked public
duv [Tue, 27 Jun 2017 08:22:31 +0000 (11:22 +0300)]
0028762: Visualization, Ray tracing - Implement depth-of-field effect
Graphic3d_RenderingParams - introduced new parameters CameraFocalPlaneDist and CameraApertureRadius managing DOF effect.
TKOpenGl - added new ray generation logic to RaytraceBase.fs.
vrenderparams command - added -focal and -aperture parameters.
OpenGl_View.hxx - function for ray generating was split into two functions (ray tracing and path tracing).
OpenGl_View_Raytrace.cxx - fixed interaction between adaptive sampling and stereo camera
kgv [Mon, 10 Jul 2017 05:54:15 +0000 (08:54 +0300)]
0028889: Visualization, V3d_View - View specific Graphic3d_Structure should be removed if the view is removed
V3d_View::Remove() - erase trihedron and grid structures from structure manager.
kgv [Thu, 6 Jul 2017 07:38:18 +0000 (10:38 +0300)]
0028832: MMgt_TShared can be replaced by Standard_Transient
kgv [Mon, 3 Jul 2017 09:27:08 +0000 (12:27 +0300)]
0028876: Tests, Image_Diff - the image difference is unavailable for test case bugs vis bug28205_1
Quantity_ColorRGBA - added method SetValues().
Image_PixMap::PixelColor() now returns Quantity_ColorRGBA instead of Quantity_Color.
Image_PixMap::SetPixelColor() now takes Quantity_ColorRGBA instead of NCollection_Vec4<float>.
Image_Diff has been improved to support Image_Format_Gray.
Image_Diff::SaveDiffImage() now saves image difference
in Image_Format_Gray format to reduce size of image file.
Image_Diff now uses TColStd_HPackedMapOfInteger instead of
TColStd_MapOfInteger with manual memory allocation.
kgv [Tue, 4 Jul 2017 11:15:34 +0000 (14:15 +0300)]
0028888: Visualization - AIS_InteractiveContext should not hold V3d_View handle which will cause accessing invalid removed V3d_View
emv [Mon, 29 May 2017 08:08:08 +0000 (11:08 +0300)]
0028786: Refactoring of the Warning/Error reporting system of Boolean Operations Algorithm
0. Basic tools for defining classes representing alerts (errors, warnings etc.) and collecting them during execution of algorithms are added in Message package.
1. Refactoring of the Error/Warning reporting system of the algorithms in Boolean Component.
To dump the description of the Error/Warning status of the algorithm the DumpErrors/DumpWarnings method should be called.
Also, the methods GerErrorMsg(int Error) and GetWarningMsg(int Warning) have been implemented to get the description for the given Error/Warning.
All Error/Warning statuses are now listed in the enumeration ErrorStatusEnum/WarningStatusEnum of the algorithm.
It is also possible to get the shapes for which the warning has been set by using the method GetWarningShapes().
2. The new class BOPAlgo_Options has been created to unify the options of the BOPAlgo_* and BRepAlgoAPI* algorithms.
3. The new checks across the algorithms have been added to detect and report errors and warnings.
4. Test cases
boolean bopcut_complex B9 E1 E5 E8
boolean bopfuse_complex B4 B5 C9 D1 D4 D5 D6 D7
have been rewritten to use Cells Builder algorithm instead of Boolean Operations algorithm, because latter always returns error "Unsupported Boolean operation" for these cases.
5. New chapter has been added in the user guide for Boolean Operations - Error / Warning reporting system.
6. Added comment to NCollection_List::Remove(Iterator&)
aba [Mon, 3 Jul 2017 09:36:57 +0000 (12:36 +0300)]
0028884: Modeling - add Standard_EXPORT macro to methods of BRepExtrema_TriangleSet
abv [Thu, 29 Jun 2017 17:17:39 +0000 (20:17 +0300)]
0028417: Using PRECOMPILED HEADER to speed up compilation time
Use of Cotire tool is introduced for acceleration of CMake builds, by usage of precompiled headers.
CMake option BUILD_USE_PCH is added to enable / disable use of precompiled headers
When precompiled headers are used, additional compiler macros are defined globally in the build system to avoid problems due to different order of included files:
- NOMINMAX is defined on Windows to prevent defining "min" and "max" as macros by windows.h
- STRSAFE_NO_DEPRECATE and _SCL_SECURE_NO_WARNINGS are defined on Windows to prevent declaring functions of standard C library as deprecated by #pragma, and other warnings in system headers
- GL_GLEXT_LEGACY and GLX_GLEXT_LEGACY are defined to ensure that only OCCT's own glext.h is used
- __STDC_FORMAT_MACROS is defined to have standard C print format macros always defined
Code is corrected to avoid conflicts with system headers and in case of compiling together as unity builds (partially):
- Some locally defined variables in TKV3d, TKHLR are renamed to be unique
- Duplicated definitions of macros and global functions are eliminated in TKSTEP
- Useless header WNT_UInt.hxx is removed
- Usage of local variables conflicting with X11 macro is avoided in Draw_Viewer.cxx
- Local variables in AIS_ConcentricRelation.cxx are renamed to avoid conflict with macros defined in windows.h
- HXX files containing code are renamed to PXX or merged with corresponding CXX files.
IVtkTools classes are corrected to avoid compiler warnings disabled in non-PCH builds by inclusion of VTK headers.
Useless pragmas disabling warnings on MSVC are removed
emv [Mon, 3 Jul 2017 09:19:55 +0000 (12:19 +0300)]
0028883: Invalid result of Section operation
mpv [Mon, 26 Jun 2017 12:41:09 +0000 (15:41 +0300)]
0028853: TDF_AttributeIterator should give handles instead of pointers
Make "Value" method of the iterator return Handle (instead of pointer) to unify public interfaces.
apv [Thu, 29 Jun 2017 08:46:35 +0000 (11:46 +0300)]
Test for
0021414: GeomAPI_IntCS fails to find all intersections between line and surface of revolution
anv [Tue, 30 May 2017 09:08:47 +0000 (12:08 +0300)]
0028798: Updating SSP sample
apv [Wed, 28 Jun 2017 15:03:25 +0000 (18:03 +0300)]
Test for
0021413: Pipe fails - very sensitive to spine parameterization
vro [Fri, 23 Jun 2017 08:13:47 +0000 (11:13 +0300)]
0028842: Attribute TNaming_NamedShape is not restored from .sgd document
kgv [Wed, 28 Jun 2017 07:36:59 +0000 (10:36 +0300)]
0028877: Documentation - fix unclosed tag in coding_rules.md
abk [Tue, 25 Apr 2017 12:27:33 +0000 (15:27 +0300)]
0028710: Implement 'BRepTools_History' history for algorithm 'ShapeUpgrade_UnifySameDomain'
'BRepTools_History' history was implemented for algorithm
'ShapeUpgrade_UnifySameDomain'.
The history of the changing of the initial shape was corrected to consider all
shapes created by the algorithm as modified shapes instead of generated ones.
The old history interface was replaced by the new one:
- to get the modified shapes use: History()->Modified();
- to check if the shapes has been deleted use: History()->IsRemoved().
abk [Tue, 25 Apr 2017 12:32:51 +0000 (15:32 +0300)]
0028709: Extend type 'BRepTools_ReShape' to support 'BRepTools_History' history
Type 'BRepTools_ReShape' was extended to:
- support the 'BRepTools_History' history;
- merge several shapes to a single shape that
the history of the merged shapes is presented by equal ways.
Type 'ShapeBuild_ReShape' was changed to support 'BRepTools_History' history.
apv [Tue, 27 Jun 2017 11:45:35 +0000 (14:45 +0300)]
Test for
0016740: XCAFDoc_ShapeMapTool is not restored
apv [Mon, 26 Jun 2017 15:34:15 +0000 (18:34 +0300)]
Test for
0017128: ShapeFix WireIntersector make bad shape
abv [Thu, 22 Jun 2017 19:43:38 +0000 (22:43 +0300)]
0028829: dsetsignal command does not work on Linux properly
OSD::SetSignal() is corrected to unset FPE exceptions on Linux if called with False argument
kgv [Thu, 1 Jun 2017 12:30:57 +0000 (15:30 +0300)]
0028801: Visualization, Select3D_SensitivePrimitiveArray - add option to keep index map of detected elements
Select3D_SensitiveGroup - added option to force overlap check for all entities in the group.
Added interface for accessing last detected entity in the group.
Select3D_SensitivePrimitiveArray - added option to keep index map of detected elements
and option to split array into groups for faster initialization of extra-large arrays.
BVH_Geometry, BVH_Object - added missing accessor ::IsDirty() for checking BVH tree state.
nbv [Fri, 16 Jun 2017 09:21:57 +0000 (12:21 +0300)]
0028849: [Regression to 7.1.0] Exception in Boolean operation
The reason of exception has been eliminated.
mpv [Tue, 20 Jun 2017 13:47:48 +0000 (16:47 +0300)]
0028852: TDF_AttributeIterator should not be marked as "handle with care"
Warning lines have been removed.
Added a comment about usage of this class.
abv [Tue, 20 Jun 2017 20:38:35 +0000 (23:38 +0300)]
0028362: Documentation - Doxygen warnings
Formatting of user guide is corrected (code block properly closed)
emv [Fri, 16 Jun 2017 05:59:21 +0000 (08:59 +0300)]
0028844: Regression vs 7.1.0: Exception is raised by the solid classification algorithm
Protection from normalization of the null vector.
Test cases for the issue.
ifv [Fri, 3 Mar 2017 12:34:11 +0000 (15:34 +0300)]
0028490: Point located outside the solid is classified as inside
New method for building surface polyhedron (class IntCurveSurface_Polyhedron), which takes in account intervals of discontinuity of surface is added for constructor IntCurvesFace_Intersector.
Bug in methods NbU(V)Intervals and U(V)Intervals for Offset surfaces is fixed.
gka [Mon, 29 May 2017 15:42:55 +0000 (18:42 +0300)]
0028797: Exceptrion is raised during reading attached STEP file.
Protection for null handle was added in the method RWStepVisual_RWPresentationStyleAssignment::ReadStep
apv [Mon, 19 Jun 2017 13:37:39 +0000 (16:37 +0300)]
0028841: testdiff DRAW command hangs or crash with arithmetical exception
jgv [Mon, 20 Mar 2017 11:43:32 +0000 (14:43 +0300)]
0027079: Bad approximation of intersection curves with variable curvature
1. Method Approx_ComputeLine::Perform is modified: now it contains also recursive calls after new line computation made by new method ApproxInt_MultiLine::MakeMLOneMorePoint.
2. New method MakeMLOneMorePoint is added to ApproxInt_MultiLine: it builds new sub-line as a part of main line with new point added into the middle of the longest interval between existing points.
3. Method ShapeConstruct_ProjectCurveOnSurface::ApproxPCurve is modified to avoid regressions: now it takes care of the set of initial points to be enough close to each other so that an interval between two adjacent points is less than half-period of the surface.
4. Modification in ShapeConstruct_ProjectCurveOnSurface: correction of pcurves of edges which extremities are in the singularities of surface.
kgv [Wed, 14 Jun 2017 10:56:34 +0000 (13:56 +0300)]
0028794: Regenerate .pxx file for Shaders/Display.fs resource
abk [Mon, 24 Apr 2017 13:04:45 +0000 (16:04 +0300)]
0028708: Create a mechanism to serve shape history by a way common for algorithms accepting and producing shapes
A shape history mechanism was created. It supports history for shapes with types
'vertex', 'edge', 'face' and 'solid'. It allows define relations 'generated',
'modified' and 'removed' between the accepted and the produced shapes. It
provides functionality for the other widely used history mechanism 'Generated',
'Modified', 'IsDeleted'. It provides algorithm to merge two histories of
sequentially applied algorithms. Recommendations were formalized to choose
between relations 'generated' and 'modified'.
kgv [Fri, 3 Feb 2017 19:27:02 +0000 (23:27 +0400)]
0028838: Configuration - undefine macros coming from X11 headers in place of collision
The macros Status, Convex, Opposite, FillSolid (coming from X11 headers)
are now undefined in place of definition of methods with same name in OCCT headers.
The usage of variables with name Status is now avoided.
GL_GLEXT_LEGACY is now defined only if not already defined.
The macros AddPrinter (coming from WinAPI headers) is now undefined
within Message_Messenger class definition having method with the same name.
CurrentDirectory macro is now undefined in OSD_Process.hxx.
mkv [Wed, 14 Jun 2017 15:45:38 +0000 (18:45 +0300)]
0028843: Replacing @ symbol in v3d glsl tiles test case
jgv [Fri, 9 Jun 2017 12:21:04 +0000 (15:21 +0300)]
0028802: The tolerance reached by approximator is used in creation of an edge, it is incorrect
Method IntTools_FaceFace::MakeCurve is modified: reached tolerances 2d and 3d of approximator are not used for edges.
apv [Wed, 14 Jun 2017 13:42:49 +0000 (16:42 +0300)]
0023575: Bounding box for a planar edge has non-zero dimension in direction orthogonal to an edge plane
# Test case bugs/moddata_3/bug23575 creation
apv [Wed, 14 Jun 2017 12:51:21 +0000 (15:51 +0300)]
0003883: Problems of reading colors and layers in XDEDRAWEXE
# Test cases bugs/step/bug3883_1, bug3883_2, bug3883_3, bug3883_4, bug3883_5 creation
kgv [Tue, 6 Jun 2017 12:30:19 +0000 (15:30 +0300)]
0028799: Coding Rules - elimilate confusing Quantity aliases of Standard_Real type
Aliases to Standard_Real within Quantity package have been marked as deprecated.
msv [Fri, 9 Jun 2017 07:46:34 +0000 (10:46 +0300)]
0028830: HalfSpace command chooses the wrong side of the given shell
Improve the algorithm BRepPrimAPI_MakeHalfSpace. Earlier it made projection of the point only on faces. If the nearest point does not conform to normal projection criterion the result is wrong. The fix includes search of projection on edges and vertices. This makes the algorithm robust for half spaces with boundaries.
apv [Wed, 14 Jun 2017 11:12:30 +0000 (14:12 +0300)]
0028813: Visualization, AIS_ColorScale - color scale title invalid placement
# Test case bugs/vis/bug28813 creation
abk [Thu, 20 Apr 2017 15:24:00 +0000 (18:24 +0300)]
0028707: Simplify type 'BRepTools_ReShape'
Type 'BRepTools_ReShape' was simplified:
- the functionality to process shapes different only in orientation by different ways was removed as it is not used anywhere;
- method 'Apply' with the build mode parameter was moved to type 'ShapeBuild_ReShape' as it is used only through the last type.
kgv [Thu, 8 Jun 2017 07:44:17 +0000 (10:44 +0300)]
0028826: Visualization, TKOpenGl - fix compatibility with strict OpenGL ES drivers
OpenGl_ShaderProgram::Initialize() - precision declarations have been moved
after the list of enabled extensions.
Declarations.glsl - the fragment shader outputs have been re-declared as array
for proper assignment of default locations (draw buffers).
OpenGl_FrameBuffer - GL_HALF_FLOAT is now used instead of GL_HALF_FLOAT_OES on OpenGL ES 3.2+.
OpenGl_Texture - fixed initialization of Image_Format_RGB32 image format on OpenGL ES 3.0+.
emv [Sat, 29 Apr 2017 22:09:36 +0000 (01:09 +0300)]
0028775: Code duplication removal across the BOPAlgo_PaveFiller algorithm
The methods PerformVerticesEE() and PerformVerticesEF() of the class BOPAlgo_PaveFiller have been replaced with the new PerformNewVertices() method.
While splitting the Pave Blocks with extra paves, check that the new Pave Blocks have the valid intersection range. If the new Pave Block does not have such range do not create it and unify its vertices making SD vertex.
Re-computation of the Shrunk Data for the modified Pave Blocks. The new method BOPDS_DS::IsValidShrunkData(const Handle(BOPDS_PaveBlock)& thePB) has been implemented to check that the Shrunk Data of the Pave Block is still valid. It may become invalid in case the tolerance values of the vertices of the Pave Block have been modified.
The test case bugs/modalg_6/bug27448_2 has been marked as BAD, because it uses the invalid shapes as inputs for BOP.
Test cases for the issue
0028690.
kgv [Fri, 26 May 2017 07:45:22 +0000 (10:45 +0300)]
0028789: Visualization, TKV3d - extend API for accessing and assigning BVH builders
Several methods in Selection classes have been moved to header files for better inlining.
BVH_Constants - added new enumeration defining common constant values used with BVH trees.
BVH - replaced NCollection_Handle with Standard_Transient handle
in classes BVH_Properties, BVH_Builder, BVH_Tree, BVH_Object.
Defined global BVH-builders instead of allocating a new one for each object set.
SelectMgr_ViewerSelector - added new method ::SetEntitySetBuilder() defining
default BVH Tree builder for SelectMgr_SensitiveEntitySet.
Added new method SelectMgr_SensitiveEntitySet::SetBuilder()
for overriding default BVH tree builder.
bugmaster [Thu, 8 Jun 2017 12:01:03 +0000 (15:01 +0300)]
0026303: Problem with test cases boolean/gdml_private L1-9 and K1-K9
Problem is not reproduced on current status of OCCT.
Test cases were reintegrated.
kgv [Thu, 25 May 2017 09:25:43 +0000 (12:25 +0300)]
0028787: Configuration, genproj - add option HAVE_RelWithDebInfo for generating VS project files with Debug info in Release mode
age [Thu, 25 May 2017 11:34:34 +0000 (14:34 +0300)]
0028794: Visualization, Ray tracing - Implement tone mapping
Added enum Graphic3d_ToneMappingMethod for choosing tone mapping mode.
Added new rendering parameters.
Added tone mapping to Display.fs shader.
ysn [Fri, 2 Jun 2017 08:55:34 +0000 (11:55 +0300)]
0028654: Existed tool (gendoc) for generation documentation does not take into account size of images.
The parameter defining image width has been added to all figures to improve their layout in PDF documents and tweaked depending on the nature of each image.
Additionally, some minor changes improving image and text layout have been introduced.
Remove temporary added possibility for setting image width automatically for generation of pdf documentation.
kgv [Wed, 24 May 2017 12:25:09 +0000 (15:25 +0300)]
0028785: Configuration, CMake - handle OCCT layout within 3rdparty_macro.cmake
kgv [Mon, 5 Jun 2017 13:15:04 +0000 (16:15 +0300)]
0028814: Documentation - suggest using # instead of // for temporary comments in commit description
ifv [Tue, 6 Jun 2017 06:56:24 +0000 (09:56 +0300)]
0028812: Regression. bugs modalg_6 bug28468_2 test case is crashed if CSF_FPE set to 1.
Test the possibility of line creation is added
kgv [Wed, 7 Jun 2017 12:12:58 +0000 (15:12 +0300)]
0028822: Configuration, XCAFDoc - fix name collision with macros GetObject()
kgv [Tue, 6 Jun 2017 14:59:57 +0000 (17:59 +0300)]
0028820: Samples - fix compilation of JAVA sample for Android
jgv [Fri, 2 Jun 2017 14:26:10 +0000 (17:26 +0300)]
0028784: [HLR] Crash while getting hidden lines for a compound
Method HLRBRep_PolyHLRToShape::InternalCompound is modified: avoid creation an edge with null length.
Add testing Draw command.
kgv [Tue, 6 Jun 2017 07:27:55 +0000 (10:27 +0300)]
0028815: Visualization, StdPrs_WFShape - fix misprint in condition
kgv [Mon, 5 Jun 2017 06:16:07 +0000 (09:16 +0300)]
0028809: Coding Rules - add .i files to .gitattributes
kgv [Fri, 2 Jun 2017 12:44:28 +0000 (15:44 +0300)]
0028806: Coding Rules - remove not implemented method OpenGl_ShaderObject::Initialize()
nbv [Mon, 29 May 2017 07:42:30 +0000 (10:42 +0300)]
0028795: Boolean operations corrupt the p-curve of the source planar face if "non-destructive" option is switched off
Now, the range of BRep_CurveRepresentation of the edge is updated if at least one of its boundary is not infinite (earlier, it was updated if all two boundaries are not infinite only).
apn [Thu, 1 Jun 2017 13:06:48 +0000 (16:06 +0300)]
0028347: Reuse OCCT implementation for producing end-user documentation for Products
Remove unnecessary definition of PRODROOT
apv [Thu, 1 Jun 2017 09:00:46 +0000 (12:00 +0300)]
0023378: BRepAlgoAPI_Cut returns wrong result
Adding test cases only
mpv [Mon, 29 May 2017 09:16:56 +0000 (12:16 +0300)]
0028714: XmlMFunction_ScopeDriver fail to read and write function label including 0 tag in label path.
Reproduced on TDF_Reference attribute that refers to label with zero-tags entry. Make checking of saved/retrieved tags in XML format pass zero-tags as correct.
bugmaster [Wed, 31 May 2017 15:28:29 +0000 (18:28 +0300)]
0028773: BRepAlgoAPI_Cut invalid result
Adding test case only
ifv [Thu, 2 Feb 2017 12:38:10 +0000 (15:38 +0300)]
0028346: Function ProjectOnSegments of ShapeAnalysis_Curve returns only single solution leading to projection result far from optimal
Subdivision of curve parametric interval based on deflection criteria is added for curve type OtherCurve in
Extrema_GExtPC.gxx. Algorithm of subdivision is implemented in Extrema_Curve(2d)Tool.cxx
New Draw command projpcurve for projection of point on CurveOnSurface is added in SWDRAW_ShapeAnalysis.cxx
projpcurve is modified to reflect "start parameter" in usage message and Draw help.
nbv [Mon, 29 May 2017 14:35:06 +0000 (17:35 +0300)]
0023177: Intersection of plane and torus misses a result and never produces analytical result
Creation of the test case.
kgv [Tue, 30 May 2017 10:43:59 +0000 (13:43 +0300)]
0028316: Coding Rules - Elimilate confusing aliases of Standard_Real type in V3d_View
Quantity_Factor, Quantity_Parameter, Quantity_Ratio, Quantity_Coefficient,
Quantity_PlaneAngle, Quantity_Length, V3d_Parameter and V3d_Coordinate
have been replaced by Standard_Real in visualization classes.
msv [Thu, 25 May 2017 14:02:07 +0000 (17:02 +0300)]
0028782: Shape sewing behavior not consistent for the same CAD file
Get rid of iterations on maps with shape key by replacing simple maps with indexed maps. So iteration is done on integer key.
The map containers have been updated to insert into them type definitions of key and value.
The new methods RemoveKey() and RemoveFromIndex() have been added to indexed [data] map to be able to remove an arbitrary key from the map.
All the code in OCCT has been updated where RemoveLast() and Substitute() methods were used to remove a key from indexed [data] map.
mpv [Tue, 30 May 2017 08:49:26 +0000 (11:49 +0300)]
0028714: Dimension of TDataStd_Real is not serialized to document
Added a comments and Standard_DEPRECATED macros to obsolete methods that these methods will be removed and that the corresponding field myDimension is not stored in the document.
szy [Tue, 30 May 2017 12:47:27 +0000 (15:47 +0300)]
0028616: TNaming - DELETE evolution is not considered by TNaming_NewShapeIterator.
// Fixed TNaming_Builder.
kgv [Fri, 26 May 2017 16:03:03 +0000 (19:03 +0300)]
0028793: Visualization, TKV3d - make BVH_Builder::Build() const for propagating builder by value
Added const for method BVH_Builder::Build().
Added missing Standard_OVERRIDE to overridden methods.
Merged code from .lxx in BVH package directly into .hxx headers.
emv [Sat, 29 Apr 2017 22:09:36 +0000 (01:09 +0300)]
0028259: Method MakeBlocksCnx is duplicated in two different places in BOPAlgo
The methods BOPAlgo_Tools::MakeBlocksCnx(), BOPAlgo_Tools::MakeBlocks() and static method MakeBlocksCnx in BOPAlgo_Builder_2.cxx have been replaced with the new template method BOPAlgo_Tools::MakeBlocks(). The blocks of connected elements are now stored into the list of list instead of data map.
All methods BOPAlgo_Tools::FillMap() have been replaced with the new template method BOPAlgo_Tools::FillMap().
Making the Pave Block with the smallest index of original edge to be the first in the Common Block (i.e. the representing Pave Block).
The following improvements have been made in Boolean Operations algorithm to avoid regressions:
- When updating the existing common block update its pave blocks in a way that the parameters of the paves should be valid for the original edge (bugs/modalg_5/bug24809);
- When trying to reduce the tolerance of the section edge check the tolerance of all Face/Face interferences that created this edge (boolean/volumemaker/C4,D2);
- Avoid producing the different Pave Blocks for the same section edge (boolean/volumemaker/D6);
Adjustment of the test cases.