From: Pawel <pawel-kowalski@wp.pl>
Date: Thu, 26 Jul 2012 09:08:26 +0000 (+0200)
Subject: 0023349: There are identical sub-expressions 'aS1.ShapeType() != TopAbs_FACE' to... 
X-Git-Tag: V6_5_4_beta1~77
X-Git-Url: http://git.dev.opencascade.org/gitweb/?p=occt.git;a=commitdiff_plain;h=b2d4add4b8fde8f5a30cd591c8b36d53ee58d3fc

0023349: There are identical sub-expressions 'aS1.ShapeType() != TopAbs_FACE' to the left and to the right of the '||' operator.

The same shape was checked twice if it was a face. The other shape was omitted instead.
---

diff --git a/src/BOPTest/BOPTest_BOPCommands.cxx b/src/BOPTest/BOPTest_BOPCommands.cxx
index 61b43cd..83ccddd 100755
--- a/src/BOPTest/BOPTest_BOPCommands.cxx
+++ b/src/BOPTest/BOPTest_BOPCommands.cxx
@@ -1508,7 +1508,7 @@ Standard_Integer bopsinf (Draw_Interpretor& di,
   }
   
   if (aS1.ShapeType()!=TopAbs_FACE ||
-      aS1.ShapeType()!=TopAbs_FACE ) {
+      aS2.ShapeType()!=TopAbs_FACE ) {
     //printf(" Shapes #%d #%d are not faces\n", nF1, nF2 );
     di << " Shapes #" << nF1 << " #" << nF2 << " are not faces\n";
     return 0;
@@ -1570,7 +1570,7 @@ Standard_Integer bopsonf (Draw_Interpretor& di,
   }
   
   if (aS1.ShapeType()!=TopAbs_FACE ||
-      aS1.ShapeType()!=TopAbs_FACE ) {
+      aS2.ShapeType()!=TopAbs_FACE ) {
     //printf(" Shapes #%d #%d are not faces\n", nF1, nF2 );
     di << " Shapes #" << nF1 << " #" << nF2 << " are not faces\n";
     return 0;