0023336: The 'strcmp' function returns 0 if corresponding strings are equal.
authorPawel <pawel-kowalski@wp.pl>
Fri, 20 Jul 2012 12:56:44 +0000 (14:56 +0200)
committerPawel Kowalski <pawel-kowalski@wp.pl>
Fri, 27 Jul 2012 11:50:17 +0000 (15:50 +0400)
Checking if the return value from 'strcmp' is '0'.

src/RWStepShape/RWStepShape_RWAngularLocation.cxx
src/RWStepShape/RWStepShape_RWAngularSize.cxx

index de17141..2a7a3e6 100755 (executable)
@@ -71,9 +71,9 @@ void RWStepShape_RWAngularLocation::ReadStep (const Handle(StepData_StepReaderDa
   StepShape_AngleRelator aAngleSelection = StepShape_Small;
   if (data->ParamType (num, 5) == Interface_ParamEnum) {
     Standard_CString text = data->ParamCValue(num, 5);
-    if      (strcmp(text, ".EQUAL.")) aAngleSelection = StepShape_Equal;
-    else if (strcmp(text, ".LARGE.")) aAngleSelection = StepShape_Large;
-    else if (strcmp(text, ".SMALL.")) aAngleSelection = StepShape_Small;
+    if      (strcmp(text, ".EQUAL.") == 0) aAngleSelection = StepShape_Equal;
+    else if (strcmp(text, ".LARGE.") == 0) aAngleSelection = StepShape_Large;
+    else if (strcmp(text, ".SMALL.") == 0) aAngleSelection = StepShape_Small;
     else ach->AddFail("Parameter #5 (angle_selection) has not allowed value");
   }
   else ach->AddFail("Parameter #5 (angle_selection) is not enumeration");
index eaed6f2..d003d40 100755 (executable)
@@ -60,9 +60,9 @@ void RWStepShape_RWAngularSize::ReadStep (const Handle(StepData_StepReaderData)&
   StepShape_AngleRelator aAngleSelection = StepShape_Small;
   if (data->ParamType (num, 3) == Interface_ParamEnum) {
     Standard_CString text = data->ParamCValue(num, 3);
-    if      (strcmp(text, ".EQUAL.")) aAngleSelection = StepShape_Equal;
-    else if (strcmp(text, ".LARGE.")) aAngleSelection = StepShape_Large;
-    else if (strcmp(text, ".SMALL.")) aAngleSelection = StepShape_Small;
+    if      (strcmp(text, ".EQUAL.") == 0) aAngleSelection = StepShape_Equal;
+    else if (strcmp(text, ".LARGE.") == 0) aAngleSelection = StepShape_Large;
+    else if (strcmp(text, ".SMALL.") == 0) aAngleSelection = StepShape_Small;
     else ach->AddFail("Parameter #3 (angle_selection) has not allowed value");
   }
   else ach->AddFail("Parameter #3 (angle_selection) is not enumeration");