0024209: Cppcheck errors "unusedScopedObject"
authoromy <omy@opencascade.com>
Tue, 24 Dec 2013 06:13:13 +0000 (10:13 +0400)
committerbugmaster <bugmaster@opencascade.com>
Thu, 9 Jan 2014 08:24:10 +0000 (12:24 +0400)
Fixed bug with temporary objects.

src/Extrema/Extrema_GenExtCS.cxx
src/MeshTest/MeshTest.cxx
src/Poly/Poly_CoherentTriangulation.cxx
src/QABugs/QABugs_19.cxx
src/StdSelect/StdSelect_BRepSelectionTool.cxx
src/TestTopOpe/TestTopOpe_HDSCommands.cxx

index 5254bac..99fa65b 100644 (file)
@@ -302,7 +302,7 @@ void Extrema_GenExtCS::Perform(const Adaptor3d_Curve& C,
         UV(1) = aMaxCU;
         UV(2) = aMaxSU;
         UV(3) = aMaxSV;
-        math_FunctionSetRoot(myF, UV, Tol, UVinf, UVsup);
+        math_FunctionSetRoot aFunc(myF, UV, Tol, UVinf, UVsup);
         break;
       }
       //
index 123368d..45f3776 100644 (file)
@@ -1230,7 +1230,7 @@ static Standard_Integer wavefront(Draw_Interpretor&, Standard_Integer nbarg, con
   Standard_Real aDeflection = 
     MAX3( aXmax-aXmin , aYmax-aYmin , aZmax-aZmin) * 0.004;
 
-  BRepMesh_IncrementalMesh(S, aDeflection);
+  BRepMesh_IncrementalMesh aMesh (S, aDeflection);
 
 
   TopLoc_Location L;
index 95a88ec..c16168b 100644 (file)
@@ -585,8 +585,8 @@ void Poly_CoherentTriangulation::RemoveLink (Poly_CoherentLink& theLink)
         else if (iNode == pTri[i]->Node(2))
           const_cast<Poly_CoherentTriangle *>(pTri[i])->mypLink[2] = 0L;
         else
-          Standard_ProgramError("Poly_CoherentTriangulation::RemoveLink: "
-                                " wrong connectivity between triangles");
+          Standard_ProgramError::Raise("Poly_CoherentTriangulation::RemoveLink: "
+                                       " wrong connectivity between triangles");
       }
     }
   } 
@@ -660,8 +660,8 @@ Standard_Boolean Poly_CoherentTriangulation::FindTriangle
         else if (aTri.Node(1) == theLink.Node(1))
           pTri[1] = &aTri;
       } else
-        Standard_ProgramError("Poly_CoherentTriangulation::FindTriangle : "
-                              " Data incoherence detected");
+        Standard_ProgramError::Raise("Poly_CoherentTriangulation::FindTriangle : "
+                                     " Data incoherence detected");
       if (pTri[0] && pTri[1])
         break;
     }
index d63a4ff..4df516c 100644 (file)
@@ -118,10 +118,10 @@ static Standard_Integer OCC23237 (Draw_Interpretor& di, Standard_Integer /*argc*
     aPM.Start();
     aTM.Start();
 
-    // do some operation that will take considerable time compared with time or starting / stopping timers
+    // do some operation that will take considerable time compared with time of starting / stopping timers
     BRepPrimAPI_MakeBox aBox (10., 10., 10.);
     BRepPrimAPI_MakeSphere aSphere (10.);
-    BRepAlgo_Cut (aBox.Shape(), aSphere.Shape());
+    BRepAlgo_Cut aCutter (aBox.Shape(), aSphere.Shape());
 
     aTM.Stop();
     aPM.Stop();
index c8a16a7..4c07608 100644 (file)
@@ -80,7 +80,7 @@ void StdSelect_BRepSelectionTool
 
   if( isAutoTriangulation && !BRepTools::Triangulation (theShape, Precision::Infinite()) )
   {
-    BRepMesh_IncrementalMesh(theShape, theDeflection, Standard_False, theDeviationAngle);
+    BRepMesh_IncrementalMesh aMesher(theShape, theDeflection, Standard_False, theDeviationAngle);
   }
 
   Handle(StdSelect_BRepOwner) aBrepOwner;
index e13fb51..178b0a4 100644 (file)
@@ -205,7 +205,7 @@ public:
 
 gp_Pnt tsee_entity0::Pnt() const
 {
-  if (!Is0()) Standard_Failure("not 0d");
+  if (!Is0()) Standard_Failure::Raise("not 0d");
   gp_Pnt P; 
   if      (IsP()) P = myEPDS->Point(myEindex).Point();
   else if (IsV()) P = BRep_Tool::Pnt(TopoDS::Vertex(myEPDS->Shape(myEindex)));