0023132: Suspicious code snippets
authoromy <omy@opencascade.com>
Fri, 16 Nov 2012 09:30:31 +0000 (13:30 +0400)
committeromy <omy@opencascade.com>
Fri, 23 Nov 2012 11:41:20 +0000 (15:41 +0400)
commit4e76d93bf1fe06ae2256d577828f4da7f6d27f0e
tree95e1992d21c31d6abde1c7da3d20db3b8c62ba98
parent49f38e37fcab4ace24b9ef5a8101e3a476a77205
0023132: Suspicious code snippets

1) Warning in Aspect.cxx couldn't be reproduced
2) Description of changes: added 'return' statements into ReadStep(...) functions of RWStepBasic_* classes.
3) BRepFill_OffsetWire.cxx - removed dead code;
4) IFSelect_WorkSession.cxx - swapped arguments;
5) TopOpeBRep_ShapeIntersector2d.cxx - removed 'brake' statement and changed loop to if-statement because of
     void TopOpeBRep_ShapeIntersector2d::FindFFIntersection() function's call features.
6) V2d_RectangularGraphicGrid.cxx - left constants instead of functions beacuse of faster perfomance.
7) Commented unreachable code in files GeomFill_LocationGuide.cxx and TopOpeBRepTool_mkTondgE.cxx
15 files changed:
src/BRepFill/BRepFill_OffsetWire.cxx
src/GeomFill/GeomFill_LocationGuide.cxx
src/IFSelect/IFSelect_WorkSession.cxx
src/IntTools/IntTools_EdgeFace.cxx
src/RWStepBasic/RWStepBasic_RWSiUnitAndAreaUnit.cxx
src/RWStepBasic/RWStepBasic_RWSiUnitAndLengthUnit.cxx
src/RWStepBasic/RWStepBasic_RWSiUnitAndMassUnit.cxx
src/RWStepBasic/RWStepBasic_RWSiUnitAndPlaneAngleUnit.cxx
src/RWStepBasic/RWStepBasic_RWSiUnitAndRatioUnit.cxx
src/RWStepBasic/RWStepBasic_RWSiUnitAndSolidAngleUnit.cxx
src/RWStepBasic/RWStepBasic_RWSiUnitAndThermodynamicTemperatureUnit.cxx
src/RWStepBasic/RWStepBasic_RWSiUnitAndTimeUnit.cxx
src/RWStepBasic/RWStepBasic_RWSiUnitAndVolumeUnit.cxx
src/TopOpeBRep/TopOpeBRep_ShapeIntersector2d.cxx
src/TopOpeBRepTool/TopOpeBRepTool_mkTondgE.cxx