0027772: Foundation Classes - define Standard_Boolean using C++ type "bool" instead... IR-2016-08-25
authorkgv <kgv@opencascade.com>
Thu, 25 Aug 2016 11:58:51 +0000 (14:58 +0300)
committerabv <abv@opencascade.com>
Fri, 26 Aug 2016 07:16:17 +0000 (10:16 +0300)
commitdde688338291eb36205d7e172cd4b05c2ec2e0c1
treee91474c4e67c4cbe84f94e76ce17513c04cf3c85
parent3fe9ce0edd41c58bc0321f59b0fd147124d27e71
0027772: Foundation Classes - define Standard_Boolean using C++ type "bool" instead of "unsigned int"

Code has been updated to remove no-op casts and implicit casts to Standard_Boolean.

Places of inproper use of Standard_Boolean instead of Standard_Integer
have been corrected:
- Bnd_Box, Bnd_Box2d
  Bit flags are now defined as private enum
- HLRAlgo_BiPoint, HLRAlgo_EdgesBlock, HLRBRep_EdgeData, HLRBRep_FaceData
  Bit flags are now defined as enum
- HLRAlgo_EdgeStatus, HLRBRep_BiPnt2D, HLRBRep_BiPoint
  Bit flags are now defined as bool fields
- HLRAlgo_PolyData
  Bit flags are now defined as Standard_Integer
- OSD_DirectoryIterator, OSD_FileIterator
  Boolean flag is now defined as Standard_Boolean
- ShapeAnalysis_Surface::SurfaceNewton()
  now returns Standard_Integer (values 0, 1 or 3)
- ChFi2d_FilletAlgo
  now uses TColStd_SequenceOfBoolean instead of TColStd_SequenceOfInteger
  for storing boolean flags

Method IFSelect_Dispatch::PacketsCount() has been dropped from interface.

ShapeFix_Solid::Status() has been fixed to decode requested status
instead of returning integer value.

TopOpeBRepBuild_Builder1 now defines map storing Standard_Boolean values
instead of Standard_Integer.

Persistence for Standard_Boolean type has been corrected
to keep backward compatibility:
- BinMDataStd, BinTools, FSD_BinaryFile

Broken Draw Harness commands vdisplaymode and verasemode have been removed.

BRepMesh_FastDiscretFace::initDataStructure() - workaround old gcc limitations

BRepMesh_IncrementalMesh::clear() - avoid ambiguity
211 files changed:
dox/dev_guides/upgrade/upgrade.md
samples/mfc/standard/08_HLR/src/SelectionDialog.cpp
samples/mfc/standard/Common/ColoredMeshDlg.cpp
samples/mfc/standard/Common/DimensionDlg.cpp
samples/mfc/standard/Common/User_Cylinder.cxx
src/Adaptor3d/Adaptor3d_IsoCurve.cxx
src/BOPDS/BOPDS_IndexRange.lxx
src/BOPDS/BOPDS_Interf.hxx
src/BOPTest/BOPTest_OptionCommands.cxx
src/BOPTools/BOPTools_AlgoTools.cxx
src/BOPTools/BOPTools_AlgoTools.hxx
src/BRep/BRep_TEdge.cxx
src/BRepAlgo/BRepAlgo_Tool.cxx
src/BRepBuilderAPI/BRepBuilderAPI_Sewing.cxx
src/BRepBuilderAPI/BRepBuilderAPI_Sewing.hxx
src/BRepFill/BRepFill_Sweep.cxx
src/BRepFill/BRepFill_TrimShellCorner.cxx
src/BRepMesh/BRepMesh_Delaun.cxx
src/BRepMesh/BRepMesh_FastDiscretFace.cxx
src/BRepMesh/BRepMesh_IncrementalMesh.cxx
src/BRepPrim/BRepPrim_GWedge.cxx
src/BRepPrim/BRepPrim_OneAxis.cxx
src/BRepTest/BRepTest_CheckCommands.cxx
src/BRepTest/BRepTest_CurveCommands.cxx
src/BRepTest/BRepTest_DraftAngleCommands.cxx
src/BRepTest/BRepTest_FeatureCommands.cxx
src/BRepTest/BRepTest_FillingCommands.cxx
src/BRepTest/BRepTest_SweepCommands.cxx
src/BRepToIGES/BRepToIGES_BREntity.cxx
src/BRepToIGESBRep/BRepToIGESBRep_Entity.cxx
src/BRepTools/BRepTools_Quilt.cxx
src/BinLDrivers/BinLDrivers_DocumentSection.cxx
src/BinMDataStd/BinMDataStd_ByteArrayDriver.cxx
src/BinMDataStd/BinMDataStd_ExtStringArrayDriver.cxx
src/BinMDataStd/BinMDataStd_IntPackedMapDriver.cxx
src/BinMDataStd/BinMDataStd_IntegerArrayDriver.cxx
src/BinMDataStd/BinMDataStd_RealArrayDriver.cxx
src/BinMDataXtd/BinMDataXtd_ConstraintDriver.cxx
src/BinMDataXtd/BinMDataXtd_PatternStdDriver.cxx
src/BinMDataXtd/BinMDataXtd_PresentationDriver.cxx
src/BinObjMgt/BinObjMgt_Persistent.lxx
src/BinTools/BinTools.cxx
src/Bnd/Bnd_Box.cxx
src/Bnd/Bnd_Box.hxx
src/Bnd/Bnd_Box.lxx [deleted file]
src/Bnd/Bnd_Box2d.hxx
src/Bnd/Bnd_Box2d.lxx [deleted file]
src/Bnd/FILES
src/ChFi2d/ChFi2d_FilletAlgo.cxx
src/ChFi2d/ChFi2d_FilletAlgo.hxx
src/ChFi3d/ChFi3d_Builder.hxx
src/ChFi3d/ChFi3d_Builder_2.cxx
src/ChFi3d/ChFi3d_Builder_6.cxx
src/ChFi3d/ChFi3d_Builder_C1.cxx
src/ChFi3d/ChFi3d_Builder_C2.cxx
src/ChFi3d/ChFi3d_ChBuilder.cxx
src/ChFi3d/ChFi3d_ChBuilder.hxx
src/ChFi3d/ChFi3d_ChBuilder_C3.cxx
src/ChFi3d/ChFi3d_FilBuilder.cxx
src/ChFi3d/ChFi3d_FilBuilder.hxx
src/ChFi3d/ChFi3d_FilBuilder_C3.cxx
src/ChFiDS/ChFiDS_SurfData.lxx
src/DDataStd/DDataStd_BasicCommands.cxx
src/DDataStd/DDataStd_TreeCommands.cxx
src/DNaming/DNaming.cxx
src/DNaming/DNaming_BasicCommands.cxx
src/DNaming/DNaming_Line3DDriver.cxx
src/DNaming/DNaming_ModelingCommands.cxx
src/DNaming/DNaming_SelectionCommands.cxx
src/Draw/Draw.cxx
src/Draw/Draw_Interpretor.cxx
src/Extrema/Extrema_Curve2dTool.lxx
src/FSD/FSD_BinaryFile.cxx
src/FilletSurf/FilletSurf_InternalBuilder.cxx
src/FilletSurf/FilletSurf_InternalBuilder.hxx
src/GeometryTest/GeometryTest_CurveCommands.cxx
src/Graphic3d/Graphic3d_MarkerImage.cxx
src/HLRAlgo/FILES
src/HLRAlgo/HLRAlgo_BiPoint.cxx
src/HLRAlgo/HLRAlgo_BiPoint.hxx
src/HLRAlgo/HLRAlgo_BiPoint.lxx [deleted file]
src/HLRAlgo/HLRAlgo_EdgeStatus.cxx
src/HLRAlgo/HLRAlgo_EdgeStatus.hxx
src/HLRAlgo/HLRAlgo_EdgeStatus.lxx [deleted file]
src/HLRAlgo/HLRAlgo_EdgesBlock.hxx
src/HLRAlgo/HLRAlgo_EdgesBlock.lxx [deleted file]
src/HLRAlgo/HLRAlgo_PolyAlgo.cxx
src/HLRAlgo/HLRAlgo_PolyData.cxx
src/HLRAlgo/HLRAlgo_PolyData.hxx
src/HLRBRep/FILES
src/HLRBRep/HLRBRep_BiPnt2D.cxx [deleted file]
src/HLRBRep/HLRBRep_BiPnt2D.hxx
src/HLRBRep/HLRBRep_BiPnt2D.lxx [deleted file]
src/HLRBRep/HLRBRep_BiPoint.cxx [deleted file]
src/HLRBRep/HLRBRep_BiPoint.hxx
src/HLRBRep/HLRBRep_BiPoint.lxx [deleted file]
src/HLRBRep/HLRBRep_EdgeData.hxx
src/HLRBRep/HLRBRep_EdgeData.lxx
src/HLRBRep/HLRBRep_FaceData.hxx
src/HLRBRep/HLRBRep_FaceData.lxx
src/HLRBRep/HLRBRep_PolyAlgo.cxx
src/HLRBRep/HLRBRep_PolyAlgo.hxx
src/IFSelect/IFSelect_DispGlobal.cxx
src/IFSelect/IFSelect_DispGlobal.hxx
src/IFSelect/IFSelect_DispPerCount.cxx
src/IFSelect/IFSelect_DispPerCount.hxx
src/IFSelect/IFSelect_DispPerFiles.cxx
src/IFSelect/IFSelect_DispPerFiles.hxx
src/IFSelect/IFSelect_DispPerOne.cxx
src/IFSelect/IFSelect_DispPerOne.hxx
src/IFSelect/IFSelect_Dispatch.cxx
src/IFSelect/IFSelect_Dispatch.hxx
src/IFSelect/IFSelect_Functions.cxx
src/IFSelect/IFSelect_SelectRootComps.cxx
src/IFSelect/IFSelect_SelectRoots.cxx
src/IFSelect/IFSelect_SessionPilot.cxx
src/IGESData/IGESData_IGESEntity.cxx
src/IGESDraw/IGESDraw_CircArraySubfigure.cxx
src/IGESDraw/IGESDraw_CircArraySubfigure.hxx
src/IGESDraw/IGESDraw_ConnectPoint.cxx
src/IGESDraw/IGESDraw_ConnectPoint.hxx
src/IGESDraw/IGESDraw_RectArraySubfigure.cxx
src/IGESDraw/IGESDraw_RectArraySubfigure.hxx
src/IGESSolid/IGESSolid_TopoBuilder.cxx
src/IGESSolid/IGESSolid_TopoBuilder.hxx
src/IGESToBRep/IGESToBRep_Actor.cxx
src/IVtkDraw/IVtkDraw.cxx
src/IVtkDraw/IVtkDraw_Interactor.cxx
src/IVtkOCC/IVtkOCC_ShapeMesher.cxx
src/IntPatch/IntPatch_RstInt.cxx
src/IntTools/IntTools_EdgeEdge.cxx
src/LocOpe/LocOpe_SplitShape.cxx
src/LocOpe/LocOpe_WiresOnShape.cxx
src/OSD/OSD_DirectoryIterator.cxx
src/OSD/OSD_DirectoryIterator.hxx
src/OSD/OSD_FileIterator.cxx
src/OSD/OSD_FileIterator.hxx
src/OpenGl/OpenGl_Clipping.hxx
src/Poly/Poly_MakeLoops.hxx
src/QABugs/QABugs_11.cxx
src/QABugs/QABugs_19.cxx
src/QADNaming/QADNaming_BasicCommands.cxx
src/QANewBRepNaming/QANewBRepNaming_Loader.cxx
src/QANewBRepNaming/QANewBRepNaming_LoaderParent.cxx
src/QANewDBRepNaming/QANewDBRepNaming_PrimitiveCommands.cxx
src/QANewModTopOpe/QANewModTopOpe_Tools.cxx
src/RWStl/RWStl.cxx
src/STEPCAFControl/STEPCAFControl_Writer.cxx
src/STEPControl/STEPControl_ActorRead.cxx
src/STEPControl/STEPControl_ActorWrite.cxx
src/STEPControl/STEPControl_Reader.cxx
src/SWDRAW/SWDRAW_ShapeAnalysis.cxx
src/SWDRAW/SWDRAW_ShapeCustom.cxx
src/SWDRAW/SWDRAW_ShapeExtend.cxx
src/SelectMgr/SelectMgr_BaseFrustum.cxx
src/SelectMgr/SelectMgr_BaseFrustum.hxx
src/ShapeAnalysis/ShapeAnalysis_Surface.cxx
src/ShapeAnalysis/ShapeAnalysis_Surface.hxx
src/ShapeCustom/ShapeCustom_DirectModification.cxx
src/ShapeFix/ShapeFix_ComposeShell.cxx
src/ShapeFix/ShapeFix_Face.cxx
src/ShapeFix/ShapeFix_Shape.cxx
src/ShapeFix/ShapeFix_Shell.cxx
src/ShapeFix/ShapeFix_Solid.cxx
src/ShapeFix/ShapeFix_Wire.cxx
src/ShapePersistent/ShapePersistent_BRep.cxx
src/ShapePersistent/ShapePersistent_TopoDS.cxx
src/ShapeProcess/ShapeProcess_Context.cxx
src/ShapeProcess/ShapeProcess_OperLibrary.cxx
src/Standard/Standard_Character.hxx
src/Standard/Standard_Transient.cxx
src/Standard/Standard_TypeDef.hxx
src/StdLPersistent/StdLPersistent_Collection.cxx
src/StdLPersistent/StdLPersistent_Collection.hxx
src/StepToTopoDS/StepToTopoDS_TranslateEdge.cxx
src/TColStd/TColStd_PackedMapOfInteger.hxx
src/TDataStd/TDataStd_BooleanList.cxx
src/TFunction/FILES
src/TFunction/TFunction_Function.hxx
src/TFunction/TFunction_Function.lxx [deleted file]
src/TObj/TObj_Object.cxx
src/TestTopOpe/TestTopOpe_BOOPCommands.cxx
src/TopOpeBRep/TopOpeBRep_FFTransitionTool.cxx
src/TopOpeBRep/TopOpeBRep_FacesFiller.hxx
src/TopOpeBRep/TopOpeBRep_FacesFiller_1.cxx
src/TopOpeBRep/TopOpeBRep_traceBOOPNINT.cxx
src/TopOpeBRep/TopOpeBRep_vpr.cxx
src/TopOpeBRep/TopOpeBRep_vprclo.cxx
src/TopOpeBRepBuild/TopOpeBRepBuild_Builder.cxx
src/TopOpeBRepBuild/TopOpeBRepBuild_Builder1.cxx
src/TopOpeBRepBuild/TopOpeBRepBuild_Builder1.hxx
src/TopOpeBRepBuild/TopOpeBRepBuild_GTool.cxx
src/TopOpeBRepBuild/TopOpeBRepBuild_GTopo.cxx
src/TopOpeBRepBuild/TopOpeBRepBuild_GTopo.hxx
src/TopOpeBRepBuild/TopOpeBRepBuild_KPart.cxx
src/TopOpeBRepDS/TopOpeBRepDS_redu.cxx
src/TopOpeBRepDS/TopOpeBRepDS_repvg.cxx
src/TopoDSToStep/TopoDSToStep_MakeStepEdge.cxx
src/TopoDSToStep/TopoDSToStep_MakeStepFace.cxx
src/TopoDSToStep/TopoDSToStep_MakeStepVertex.cxx
src/ViewerTest/ViewerTest.cxx
src/ViewerTest/ViewerTest_CmdParser.cxx
src/ViewerTest/ViewerTest_ObjectCommands.cxx
src/ViewerTest/ViewerTest_ViewerCommands.cxx
src/XCAFDoc/XCAFDoc_Dimension.cxx
src/XSDRAWSTLVRML/XSDRAWSTLVRML.cxx
src/XmlMDataStd/XmlMDataStd_ByteArrayDriver.cxx
src/XmlMDataStd/XmlMDataStd_ExtStringArrayDriver.cxx
src/XmlMDataStd/XmlMDataStd_IntPackedMapDriver.cxx
src/XmlMDataStd/XmlMDataStd_IntegerArrayDriver.cxx
src/XmlMDataStd/XmlMDataStd_RealArrayDriver.cxx