0028687: Offset for open wire is built with incorrect direction

Added new condition to exclude offsetting non closed part of circle as complete circle

diff --git a/src/BRepFill/BRepFill_OffsetWire.cxx b/src/BRepFill/BRepFill_OffsetWire.cxx
index be82150111d91aeb40dde6a1bb2f474c61500aab..a1a16992117fede85f2a36322d3a6411ac318dfc 100644 (file)
--- a/src/BRepFill/BRepFill_OffsetWire.cxx
+++ b/src/BRepFill/BRepFill_OffsetWire.cxx
@@ -283,6 +283,10 @@ static Standard_Boolean KPartCircle
     {
       if (E.Orientation() == TopAbs_FORWARD)
         anOffset *= -1;
+      if (!BRep_Tool::IsClosed(E))
+      {
+        anOffset *= -1;
+      }
       gp_Circ2d theCirc = AHC->Circle();
       if (anOffset > 0. || Abs(anOffset) < theCirc.Radius())
         OC = new Geom2d_Circle (theCirc.Position(), theCirc.Radius() + anOffset);

diff --git a/tests/bugs/modalg_5/bug25334_1 b/tests/bugs/modalg_5/bug25334_1
index 550317e322d4b6dd272f75e273e9413e7b20ba59..f4d7734dcdd3ee3bf0e4339fd526090b6f591912 100644 (file)
--- a/tests/bugs/modalg_5/bug25334_1
+++ b/tests/bugs/modalg_5/bug25334_1
@@ -23,7 +23,7 @@ vori result
 
 fit
 
-checkprops result -l 613.39 
+checkprops result -l 644.509 
 checkshape result 
 checksection result
 

diff --git a/tests/bugs/modalg_5/bug25334_2 b/tests/bugs/modalg_5/bug25334_2
index 3f16c789c7f620ba75b278761e9d849b26631bd8..b5f90d7539e409561d9f1cc852b06b152368520a 100644 (file)
--- a/tests/bugs/modalg_5/bug25334_2
+++ b/tests/bugs/modalg_5/bug25334_2
@@ -23,7 +23,7 @@ vori result
 
 fit
 
-checkprops result -l 644.509 
+checkprops result -l 613.39 
 checkshape result 
 checksection result
 

diff --git a/tests/bugs/modalg_5/bug25334_3 b/tests/bugs/modalg_5/bug25334_3
index 8659654edeef8765b41526bbbe8abadf633b6f42..e045bc1b6afd3ceaf138538a7b2c40000e5d49d6 100644 (file)
--- a/tests/bugs/modalg_5/bug25334_3
+++ b/tests/bugs/modalg_5/bug25334_3
@@ -23,7 +23,7 @@ vori result
 
 fit
 
-checkprops result -l 354.958 
+checkprops result -l 386.077 
 checkshape result 
 checksection result
 

diff --git a/tests/bugs/modalg_5/bug25334_4 b/tests/bugs/modalg_5/bug25334_4
index d22bb01edc594221572fc8709b57d45b250accca..40b13eb67e4ff5d95cdfe1efee81a24dc01a51d5 100644 (file)
--- a/tests/bugs/modalg_5/bug25334_4
+++ b/tests/bugs/modalg_5/bug25334_4
@@ -23,7 +23,7 @@ vori result
 
 fit
 
-checkprops result -l 386.077 
+checkprops result -l 354.958 
 checkshape result 
 checksection result