0023512: Incorrect triangulation on revolution shape

Added test cases bugs/modalg_5/bug23512_1 bug23512_2
Moved test cases for issue 23512 moved to folder bugs/mesh. Square checking is made in END file

diff --git a/tests/bugs/end b/tests/bugs/end
index 4d2f5ddafd3d54a2a1a959ea621df1f688feda34..df647a3576cc1a4e621d2bde5bccf1c71975e2b1 100755 (executable)
--- a/tests/bugs/end
+++ b/tests/bugs/end
@@ -139,6 +139,18 @@ if { [info exists nb_fe_good] && [info exists nb_fe] } {
     }
 }
 
+if { [info exists rel_tol] } {
+   puts "\nChecking triangulation area (triarea command)..."
+   set rel_err [expr abs([CheckTriArea result $area_eps])]
+   if { $rel_err > $rel_tol } {
+      puts "Error   : area by triangles differs from the actual area by $rel_err %"
+   } else {
+      if { $rel_tol > 1 && $rel_tol < 100 } {
+        puts "Error: Improvement: The current area difference is $rel_err instead of $rel_tol"
+      }
+   }
+}
+
 if { [isdraw result] } {
     if { [info exists 2dviewer] } {
        clear

diff --git a/tests/bugs/mesh/bug23512_1 b/tests/bugs/mesh/bug23512_1
new file mode 100644 (file)
index 0000000..4bc65dd
--- /dev/null
+++ b/tests/bugs/mesh/bug23512_1
@@ -0,0 +1,35 @@
+puts "================"
+puts "OCC23512"
+puts "================"
+puts ""
+#######################################################################################
+# Incorrect triangulation on revolution shape
+######################################################################################
+
+set BugNumber OCC23512
+
+restore [locate_data_file bug23512_rev_bad_shading.brep] result
+
+vinit
+tclean result
+
+vsetdispmode 1
+vdisplay result
+vaxo
+vfit
+
+set nb_v_good 6
+set nb_e_good 14
+set nb_w_good 8
+set nb_f_good 7
+set nb_sh_good 1
+set nb_sol_good 1
+set nb_compsol_good 0
+set nb_compound_good 0
+set nb_shape_good 37
+
+# relative tolerance (%)
+set rel_tol 1
+set area_eps 0
+
+set only_screen 1

diff --git a/tests/bugs/mesh/bug23512_2 b/tests/bugs/mesh/bug23512_2
new file mode 100644 (file)
index 0000000..55f1fcd
--- /dev/null
+++ b/tests/bugs/mesh/bug23512_2
@@ -0,0 +1,37 @@
+puts "================"
+puts "OCC23512"
+puts "================"
+puts ""
+#######################################################################################
+# Incorrect triangulation on revolution shape
+######################################################################################
+
+set BugNumber OCC23512
+
+restore [locate_data_file bug23512_rev_bad_shading.brep] result
+
+vinit
+tclean result
+
+incmesh result 0.000001
+
+vsetdispmode 1
+vdisplay result
+vaxo
+vfit
+
+set nb_v_good 6
+set nb_e_good 14
+set nb_w_good 8
+set nb_f_good 7
+set nb_sh_good 1
+set nb_sol_good 1
+set nb_compsol_good 0
+set nb_compound_good 0
+set nb_shape_good 37
+
+# relative tolerance (%)
+set rel_tol 1
+set area_eps 0
+
+set only_screen 1

diff --git a/tests/bugs/modalg_2/bug22818_1 b/tests/bugs/modalg_2/bug22818_1
index fcd7c99ebd0e2080803341a94958b4e0886960e2..47bfffd9ae4f8d2002f768df9ae907ddac1d3021 100755 (executable)
--- a/tests/bugs/modalg_2/bug22818_1
+++ b/tests/bugs/modalg_2/bug22818_1
@@ -45,15 +45,5 @@ vzfit
 # relative tolerance (%)
 set rel_tol 1
 set area_eps 0
-#
-puts "\nChecking triangulation area (triarea command)..."
-set rel_err [expr abs([CheckTriArea result $area_eps])]
-if { $rel_err > $rel_tol } {
-   puts "Error   : area by triangles differs from the actual area by $rel_err %"
-} else {
-   if { $rel_tol > 1 && $rel_tol < 100 } {
-      puts "Error: Improvement: The current area difference is $rel_err instead of $rel_tol"
-   }
-}
 
 set only_screen 1

diff --git a/tests/bugs/modalg_2/bug22818_2 b/tests/bugs/modalg_2/bug22818_2
index 5272e462a7d4281bc65c6bdbfafe28ea53e3be18..6e89e4d4bec281b53978e6cafdc07613164c514f 100755 (executable)
--- a/tests/bugs/modalg_2/bug22818_2
+++ b/tests/bugs/modalg_2/bug22818_2
@@ -46,15 +46,5 @@ vzfit
 # relative tolerance (%)
 set rel_tol 1
 set area_eps 0
-#
-puts "\nChecking triangulation area (triarea command)..."
-set rel_err [expr abs([CheckTriArea result $area_eps])]
-if { $rel_err > $rel_tol } {
-   puts "Error   : area by triangles differs from the actual area by $rel_err %"
-} else {
-   if { $rel_tol > 1 && $rel_tol < 100 } {
-      puts "Error: Improvement: The current area difference is $rel_err instead of $rel_tol"
-   }
-}
 
 set only_screen 1

diff --git a/tests/bugs/modalg_2/bug22818_3 b/tests/bugs/modalg_2/bug22818_3
index 596714c6ef2dd2a23c62b271bc469d4526cf653d..29d5716b316df45e2fcab7329b7c4cd83f150998 100755 (executable)
--- a/tests/bugs/modalg_2/bug22818_3
+++ b/tests/bugs/modalg_2/bug22818_3
@@ -33,15 +33,5 @@ vzfit
 # relative tolerance (%)
 set rel_tol 1
 set area_eps 0
-#
-puts "\nChecking triangulation area (triarea command)..."
-set rel_err [expr abs([CheckTriArea result $area_eps])]
-if { $rel_err > $rel_tol } {
-   puts "Error   : area by triangles differs from the actual area by $rel_err %"
-} else {
-   if { $rel_tol > 1 && $rel_tol < 100 } {
-      puts "Error: Improvement: The current area difference is $rel_err instead of $rel_tol"
-   }
-}
 
 set only_screen 1

diff --git a/tests/bugs/modalg_2/bug22818_4 b/tests/bugs/modalg_2/bug22818_4
index d96171a9f10cc8c64614ea02a89218c190424808..83b79ad078ff7e38a638591a2ea76b4247609e69 100755 (executable)
--- a/tests/bugs/modalg_2/bug22818_4
+++ b/tests/bugs/modalg_2/bug22818_4
@@ -36,15 +36,5 @@ vzfit
 # relative tolerance (%)
 set rel_tol 1
 set area_eps 0
-#
-puts "\nChecking triangulation area (triarea command)..."
-set rel_err [expr abs([CheckTriArea result $area_eps])]
-if { $rel_err > $rel_tol } {
-   puts "Error   : area by triangles differs from the actual area by $rel_err %"
-} else {
-   if { $rel_tol > 1 && $rel_tol < 100 } {
-      puts "Error: Improvement: The current area difference is $rel_err instead of $rel_tol"
-   }
-}
 
 set only_screen 1

diff --git a/tests/bugs/modalg_5/bug23282_1 b/tests/bugs/modalg_5/bug23282_1
index 58e24fa7a9806e16e984341d45cc341b38b02d96..82a6067708e202965fea3eab096eda5ea13b3ba9 100755 (executable)
--- a/tests/bugs/modalg_5/bug23282_1
+++ b/tests/bugs/modalg_5/bug23282_1
@@ -33,15 +33,5 @@ vzfit
 # relative tolerance (%)
 set rel_tol 1
 set area_eps 0
-#
-puts "\nChecking triangulation area (triarea command)..."
-set rel_err [expr abs([CheckTriArea result $area_eps])]
-if { $rel_err > $rel_tol } {
-   puts "Error   : area by triangles differs from the actual area by $rel_err %"
-} else {
-   if { $rel_tol > 1 && $rel_tol < 100 } {
-      puts "Error: Improvement: The current area difference is $rel_err instead of $rel_tol"
-   }
-}
 
 set only_screen 1

diff --git a/tests/bugs/modalg_5/bug23282_2 b/tests/bugs/modalg_5/bug23282_2
index b54a3c0c92da1c329627cfd7d5dc6cb7ac2248b2..5c2814d6d93b53ce05019bcd4590146b912eda1f 100755 (executable)
--- a/tests/bugs/modalg_5/bug23282_2
+++ b/tests/bugs/modalg_5/bug23282_2
@@ -36,15 +36,5 @@ vzfit
 # relative tolerance (%)
 set rel_tol 1
 set area_eps 0
-#
-puts "\nChecking triangulation area (triarea command)..."
-set rel_err [expr abs([CheckTriArea result $area_eps])]
-if { $rel_err > $rel_tol } {
-   puts "Error   : area by triangles differs from the actual area by $rel_err %"
-} else {
-   if { $rel_tol > 1 && $rel_tol < 100 } {
-      puts "Error: Improvement: The current area difference is $rel_err instead of $rel_tol"
-   }
-}
 
 set only_screen 1